From unknown Mon Aug 11 18:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26068: [PATCH] bug in generator function with pcase Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Mar 2017 08:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 26068@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148930869512879 (code B ref -1); Sun, 12 Mar 2017 08:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Mar 2017 08:51:35 +0000 Received: from localhost ([127.0.0.1]:51957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmzDz-0003Lf-Hd for submit@debbugs.gnu.org; Sun, 12 Mar 2017 04:51:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmzDx-0003LL-Mw for submit@debbugs.gnu.org; Sun, 12 Mar 2017 04:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmzDr-0005po-If for submit@debbugs.gnu.org; Sun, 12 Mar 2017 04:51:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cmzDr-0005pC-ES for submit@debbugs.gnu.org; Sun, 12 Mar 2017 04:51:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmzDq-0004kw-9g for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 04:51:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmzDp-0005iU-Bt for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 04:51:26 -0400 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:36202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cmzDp-0005fs-78 for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 04:51:25 -0400 Received: by mail-pf0-x22a.google.com with SMTP id o126so57923534pfb.3 for ; Sun, 12 Mar 2017 00:51:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=RXYyTtq6Lsg11FkcYlU1ZHja445EaVpQPwLCY0W6u/0=; b=K0aDLKWhF6Y8kzXtO5llEtOYg0I7WfQ2Ng1VDFvtmRkVV9QL3Prsr4BftBDmfDBBXl ls/GW++in9nXmBjAEE+/py13uvHjOfW4BtVTTIXBgfc2oyOaAQAiGPdqjF3/cwc5giP9 cI6d/UPkc6T582gdCrquJ7nPB67uUQLnC9pZU8DrC/EML0BbZM8Ftk84KgegRIOjnaFF Lq+5J2heHZjSJVNrv46if/N0iaCQ6BdWXxkbj37ybqm3EOJeG2mgIvWaASUxye6wc+Vc 5OlPO4Gvv0clZH8pd6DuTbVu3mX31Tfv7jDJlwR3KX++qzYLMI/dD4sD4HC/Mmp0J0e8 E+BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=RXYyTtq6Lsg11FkcYlU1ZHja445EaVpQPwLCY0W6u/0=; b=M4a9gtcOAGwpPc4g9FDZO0jmruY6NI3Lcc9aPjauj54ylw1VkjOPWtiD7+GGwGRLy3 wxEXzspXItaRzK1jrrlb+Lg/uGuiAu9t4PHvell5aMFG90tt5o3f7gGXIjUpu3GqbJ+z HwxEnqVn+kqnAEtZ1Yk0wh1tYFCRJWLA9zf7NKz4Tppj5ncI073O/T6M7XzmsEJ1Vy4g kXNu2MsgGINTGvfE/HqJ/8dpwC//ZfaKKeGV/IJgUHcTzz7OpYDfWDduyfVVn/S2cP4q mZzw62TqL7lk0yUmaB1bDLsq3hgZXAPGJR2a7jgxjmMKJiWj41YMGCyWodiTkBRTWhqf iEOw== X-Gm-Message-State: AMke39kyA6J59qrYoMQQs6eR9zJ3MW7/RxUXe9wqvpOC187eWoNjnCOJSWM+oRC7DOGfwWHW9ixS6wLkbt2/rA== X-Received: by 10.84.172.1 with SMTP id m1mr38012854plb.5.1489308683909; Sun, 12 Mar 2017 00:51:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.176.176 with HTTP; Sun, 12 Mar 2017 00:51:23 -0800 (PST) From: Paul Pogonyshev Date: Sun, 12 Mar 2017 09:51:23 +0100 Message-ID: Content-Type: multipart/mixed; boundary=94eb2c13e3ea10d81b054a84b32d X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --94eb2c13e3ea10d81b054a84b32d Content-Type: text/plain; charset=UTF-8 To reproduce: (iter-next (funcall (iter-lambda () (pcase (list 1 2) (`(,a ,b) (iter-yield (+ a b))))))) Patch is attached. I have no idea if it affects something else, but matching symbols with `eq' on their names (`eq' on strings?!) seems outright wrong to me. On a side note: bug report I sent yesterday with M-x report-emacs-bug was silently lost. Paul --94eb2c13e3ea10d81b054a84b32d Content-Type: text/plain; charset=US-ASCII; name="cl-macs.diff" Content-Disposition: attachment; filename="cl-macs.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j06fxmjy0 ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsIGIvbGlzcC9lbWFjcy1saXNw L2NsLW1hY3MuZWwKaW5kZXggNDAzNDJmM2ZlNC4uNThiY2RkNTJhYyAxMDA2NDQKLS0tIGEvbGlz cC9lbWFjcy1saXNwL2NsLW1hY3MuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MuZWwK QEAgLTIwNTksOCArMjA1OSw4IEBAIGV4Y2VwdCB0aGF0IGl0IGFkZGl0aW9uYWxseSBleHBhbmRz IHN5bWJvbCBtYWNyb3MuIgogICAgICAgICAgIChwY2FzZSBleHAKICAgICAgICAgICAgICgocHJl ZCBzeW1ib2xwKQogICAgICAgICAgICAgIDs7IFBlcmZvcm0gc3ltYm9sLW1hY3JvIGV4cGFuc2lv bi4KLSAgICAgICAgICAgICAod2hlbiAoY2RyIChhc3NxIChzeW1ib2wtbmFtZSBleHApIGVudikp Ci0gICAgICAgICAgICAgICAoc2V0cSBleHAgKGNhZHIgKGFzc3EgKHN5bWJvbC1uYW1lIGV4cCkg ZW52KSkpKSkKKyAgICAgICAgICAgICAod2hlbiAoY2RyIChhc3NxIGV4cCBlbnYpKQorICAgICAg ICAgICAgICAgKHNldHEgZXhwIChjYWRyIChhc3NxIGV4cCBlbnYpKSkpKQogICAgICAgICAgICAg KGAoc2V0cSAuICxfKQogICAgICAgICAgICAgIDs7IENvbnZlcnQgc2V0cSB0byBzZXRmIGlmIHJl cXVpcmVkIGJ5IHN5bWJvbC1tYWNybyBleHBhbnNpb24uCiAgICAgICAgICAgICAgKGxldCogKChh cmdzIChtYXBjYXIgKGxhbWJkYSAoZikgKGNsLS1zbS1tYWNyb2V4cGFuZCBmIGVudikpCkBAIC0y MDc4LDcgKzIwNzgsNyBAQCBleGNlcHQgdGhhdCBpdCBhZGRpdGlvbmFsbHkgZXhwYW5kcyBzeW1i b2wgbWFjcm9zLiIKICAgICAgICAgICAgICAobGV0ICgobGV0ZiBuaWwpIChmb3VuZCBuaWwpIChu YnMgKCkpKQogICAgICAgICAgICAgICAgKGRvbGlzdCAoYmluZGluZyBiaW5kaW5ncykKICAgICAg ICAgICAgICAgICAgKGxldCogKCh2YXIgKGlmIChzeW1ib2xwIGJpbmRpbmcpIGJpbmRpbmcgKGNh ciBiaW5kaW5nKSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAoc20gKGFzc3EgKHN5bWJvbC1u YW1lIHZhcikgZW52KSkpCisgICAgICAgICAgICAgICAgICAgICAgICAoc20gKGFzc3EgdmFyIGVu dikpKQogICAgICAgICAgICAgICAgICAgIChwdXNoIChpZiAobm90IChjZHIgc20pKQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBiaW5kaW5nCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAobGV0ICgobmV4cCAoY2FkciBzbSkpKQpAQCAtMjE0OSw3ICsyMTQ5LDcgQEAgYnkgRVhQQU5T SU9OLCBhbmQgKHNldHEgTkFNRSAuLi4pIHdpbGwgYWN0IGxpa2UgKHNldGYgRVhQQU5TSU9OIC4u LikuCiAgICAgICAgICAgICAobGV0ICgoZXhwYW5zaW9uCiAgICAgICAgICAgICAgICAgICAgOzsg RklYTUU6IEZvciBOIGJpbmRpbmdzLCB0aGlzIHdpbGwgdHJhdmVyc2UgYGJvZHknIE4gdGltZXMh CiAgICAgICAgICAgICAgICAgICAgKG1hY3JvZXhwYW5kLWFsbCAobWFjcm9leHAtcHJvZ24gYm9k eSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjb25zIChsaXN0IChzeW1i b2wtbmFtZSAoY2FhciBiaW5kaW5ncykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoY29ucyAobGlzdCAoY2FhciBiaW5kaW5ncykKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChjbC1jYWRhciBiaW5kaW5ncykpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtYWNyb2V4cGFuZC1hbGwtZW52aXJvbm1l bnQpKSkpCiAgICAgICAgICAgICAgIChpZiAob3IgKG51bGwgKGNkYXIgYmluZGluZ3MpKSAoY2wt Y2RkYXIgYmluZGluZ3MpKQo= --94eb2c13e3ea10d81b054a84b32d-- From unknown Mon Aug 11 18:16:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Pogonyshev Subject: bug#26068: closed (Re: bug#26068: [PATCH] bug in generator function with pcase) Message-ID: References: <87wpblkrc8.fsf@holos> X-Gnu-PR-Message: they-closed 26068 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 26068@debbugs.gnu.org Date: Sun, 19 Mar 2017 19:19:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1489951142-10482-1" This is a multi-part message in MIME format... ------------=_1489951142-10482-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #26068: [PATCH] bug in generator function with pcase which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 26068@debbugs.gnu.org. --=20 26068: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26068 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1489951142-10482-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 26068-done) by debbugs.gnu.org; 19 Mar 2017 19:18:55 +0000 Received: from localhost ([127.0.0.1]:35446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpgLv-0002in-J3 for submit@debbugs.gnu.org; Sun, 19 Mar 2017 15:18:55 -0400 Received: from mail-qk0-f179.google.com ([209.85.220.179]:33803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpgLu-0002iY-Kg for 26068-done@debbugs.gnu.org; Sun, 19 Mar 2017 15:18:54 -0400 Received: by mail-qk0-f179.google.com with SMTP id p64so96552002qke.1 for <26068-done@debbugs.gnu.org>; Sun, 19 Mar 2017 12:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TP+b1KqGjEhRlahhE44yLxxjUssQLEiGqLKFgToCPrI=; b=k0dSTgTRmfUFr0WEJTp4WpUbisVq0WgP6LHzGjsnXxSNFymsA7Fd3Hc+3ht3aavdEv g3GC2VeEh95vLmkmrx8DM0YOoytQaI+c7dlVWbBx/CBK+PCLcbZA9QcdbUNNY69aTarG isWyN5M2BZzh6s+g9MUJYLU2JqrLR2P+88tjOko17oh74AwGU7yG2VaqqkfKWrSm74SN lETEBBHfCaVEsxuQZzwFnzUCQyCD1a/Fx/p8pEAFY8FHE6iRXvorWe5vybeKG6wfOyyr P42WdLopnjzSG4HPJdfLJnqxndvXI6daMWxx2Hb1IZbODdPcX8Q7TxsB2KxpEFkVpFKa qV1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TP+b1KqGjEhRlahhE44yLxxjUssQLEiGqLKFgToCPrI=; b=Ysds+94CHOnGusngG/xiozl+u3S74YHmx84c5ylBLAMejddmWL5GSQZusdx0g7wN8o stgFl9aMSXklIGt50EiM/6hzqVk5oJBEB7h+J4evj/KuR7s2qxWAowppc0G3tTot0aQH QqKvBD5nsWiiQt5l2A4SlCCN2NRERYwDx36hnPo7znrqdELpN8HcVL8803Z7LxqMOOsl /yeHwsLhwVuyGZ/5nNdDrZrkwwVDD8GR1auENjuV1mM3cy2Vb+HE/8oM/afHNPIuPgQZ OHnUrqIRLrdzQJt7NRvHtqJ5tT3JAN+a7nXaDEwzS3xZnSSYKSRhdyNSfkTNgejixWr7 xgyQ== X-Gm-Message-State: AFeK/H2ev+Rd/tVY4kAy6r4bTDVrPMp/wh9hg6BlTfKZILTdNrIy5D6RYlJeLrm4BJFFW5Dm X-Received: by 10.55.151.3 with SMTP id z3mr1878618qkd.79.1489951129015; Sun, 19 Mar 2017 12:18:49 -0700 (PDT) Received: from holos.localdomain (pool-173-67-40-97.bltmmd.fios.verizon.net. [173.67.40.97]) by smtp.gmail.com with ESMTPSA id s71sm10797936qkl.60.2017.03.19.12.18.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Mar 2017 12:18:48 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 042CD69607; Sun, 19 Mar 2017 15:18:47 -0400 (EDT) From: Mark Oteiza To: Paul Pogonyshev Subject: Re: bug#26068: [PATCH] bug in generator function with pcase References: Date: Sun, 19 Mar 2017 15:18:47 -0400 In-Reply-To: (Paul Pogonyshev's message of "Sun, 12 Mar 2017 09:51:23 +0100") Message-ID: <87wpblkrc8.fsf@holos> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26068-done Cc: 26068-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Paul Pogonyshev writes: > To reproduce: > > (iter-next (funcall (iter-lambda () (pcase (list 1 2) > (`(,a ,b) (iter-yield (+ a b))))))) > > Patch is attached. I have no idea if it affects something else, but > matching symbols with `eq' on their names (`eq' on strings?!) seems > outright wrong to me. > > On a side note: bug report I sent yesterday with M-x report-emacs-bug > was silently lost. Applied as 0d112c00. ------------=_1489951142-10482-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Mar 2017 08:51:35 +0000 Received: from localhost ([127.0.0.1]:51957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmzDz-0003Lf-Hd for submit@debbugs.gnu.org; Sun, 12 Mar 2017 04:51:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmzDx-0003LL-Mw for submit@debbugs.gnu.org; Sun, 12 Mar 2017 04:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmzDr-0005po-If for submit@debbugs.gnu.org; Sun, 12 Mar 2017 04:51:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cmzDr-0005pC-ES for submit@debbugs.gnu.org; Sun, 12 Mar 2017 04:51:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmzDq-0004kw-9g for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 04:51:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmzDp-0005iU-Bt for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 04:51:26 -0400 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:36202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cmzDp-0005fs-78 for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 04:51:25 -0400 Received: by mail-pf0-x22a.google.com with SMTP id o126so57923534pfb.3 for ; Sun, 12 Mar 2017 00:51:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=RXYyTtq6Lsg11FkcYlU1ZHja445EaVpQPwLCY0W6u/0=; b=K0aDLKWhF6Y8kzXtO5llEtOYg0I7WfQ2Ng1VDFvtmRkVV9QL3Prsr4BftBDmfDBBXl ls/GW++in9nXmBjAEE+/py13uvHjOfW4BtVTTIXBgfc2oyOaAQAiGPdqjF3/cwc5giP9 cI6d/UPkc6T582gdCrquJ7nPB67uUQLnC9pZU8DrC/EML0BbZM8Ftk84KgegRIOjnaFF Lq+5J2heHZjSJVNrv46if/N0iaCQ6BdWXxkbj37ybqm3EOJeG2mgIvWaASUxye6wc+Vc 5OlPO4Gvv0clZH8pd6DuTbVu3mX31Tfv7jDJlwR3KX++qzYLMI/dD4sD4HC/Mmp0J0e8 E+BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=RXYyTtq6Lsg11FkcYlU1ZHja445EaVpQPwLCY0W6u/0=; b=M4a9gtcOAGwpPc4g9FDZO0jmruY6NI3Lcc9aPjauj54ylw1VkjOPWtiD7+GGwGRLy3 wxEXzspXItaRzK1jrrlb+Lg/uGuiAu9t4PHvell5aMFG90tt5o3f7gGXIjUpu3GqbJ+z HwxEnqVn+kqnAEtZ1Yk0wh1tYFCRJWLA9zf7NKz4Tppj5ncI073O/T6M7XzmsEJ1Vy4g kXNu2MsgGINTGvfE/HqJ/8dpwC//ZfaKKeGV/IJgUHcTzz7OpYDfWDduyfVVn/S2cP4q mZzw62TqL7lk0yUmaB1bDLsq3hgZXAPGJR2a7jgxjmMKJiWj41YMGCyWodiTkBRTWhqf iEOw== X-Gm-Message-State: AMke39kyA6J59qrYoMQQs6eR9zJ3MW7/RxUXe9wqvpOC187eWoNjnCOJSWM+oRC7DOGfwWHW9ixS6wLkbt2/rA== X-Received: by 10.84.172.1 with SMTP id m1mr38012854plb.5.1489308683909; Sun, 12 Mar 2017 00:51:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.176.176 with HTTP; Sun, 12 Mar 2017 00:51:23 -0800 (PST) From: Paul Pogonyshev Date: Sun, 12 Mar 2017 09:51:23 +0100 Message-ID: Subject: [PATCH] bug in generator function with pcase To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary=94eb2c13e3ea10d81b054a84b32d X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --94eb2c13e3ea10d81b054a84b32d Content-Type: text/plain; charset=UTF-8 To reproduce: (iter-next (funcall (iter-lambda () (pcase (list 1 2) (`(,a ,b) (iter-yield (+ a b))))))) Patch is attached. I have no idea if it affects something else, but matching symbols with `eq' on their names (`eq' on strings?!) seems outright wrong to me. On a side note: bug report I sent yesterday with M-x report-emacs-bug was silently lost. Paul --94eb2c13e3ea10d81b054a84b32d Content-Type: text/plain; charset=US-ASCII; name="cl-macs.diff" Content-Disposition: attachment; filename="cl-macs.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j06fxmjy0 ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsIGIvbGlzcC9lbWFjcy1saXNw L2NsLW1hY3MuZWwKaW5kZXggNDAzNDJmM2ZlNC4uNThiY2RkNTJhYyAxMDA2NDQKLS0tIGEvbGlz cC9lbWFjcy1saXNwL2NsLW1hY3MuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MuZWwK QEAgLTIwNTksOCArMjA1OSw4IEBAIGV4Y2VwdCB0aGF0IGl0IGFkZGl0aW9uYWxseSBleHBhbmRz IHN5bWJvbCBtYWNyb3MuIgogICAgICAgICAgIChwY2FzZSBleHAKICAgICAgICAgICAgICgocHJl ZCBzeW1ib2xwKQogICAgICAgICAgICAgIDs7IFBlcmZvcm0gc3ltYm9sLW1hY3JvIGV4cGFuc2lv bi4KLSAgICAgICAgICAgICAod2hlbiAoY2RyIChhc3NxIChzeW1ib2wtbmFtZSBleHApIGVudikp Ci0gICAgICAgICAgICAgICAoc2V0cSBleHAgKGNhZHIgKGFzc3EgKHN5bWJvbC1uYW1lIGV4cCkg ZW52KSkpKSkKKyAgICAgICAgICAgICAod2hlbiAoY2RyIChhc3NxIGV4cCBlbnYpKQorICAgICAg ICAgICAgICAgKHNldHEgZXhwIChjYWRyIChhc3NxIGV4cCBlbnYpKSkpKQogICAgICAgICAgICAg KGAoc2V0cSAuICxfKQogICAgICAgICAgICAgIDs7IENvbnZlcnQgc2V0cSB0byBzZXRmIGlmIHJl cXVpcmVkIGJ5IHN5bWJvbC1tYWNybyBleHBhbnNpb24uCiAgICAgICAgICAgICAgKGxldCogKChh cmdzIChtYXBjYXIgKGxhbWJkYSAoZikgKGNsLS1zbS1tYWNyb2V4cGFuZCBmIGVudikpCkBAIC0y MDc4LDcgKzIwNzgsNyBAQCBleGNlcHQgdGhhdCBpdCBhZGRpdGlvbmFsbHkgZXhwYW5kcyBzeW1i b2wgbWFjcm9zLiIKICAgICAgICAgICAgICAobGV0ICgobGV0ZiBuaWwpIChmb3VuZCBuaWwpIChu YnMgKCkpKQogICAgICAgICAgICAgICAgKGRvbGlzdCAoYmluZGluZyBiaW5kaW5ncykKICAgICAg ICAgICAgICAgICAgKGxldCogKCh2YXIgKGlmIChzeW1ib2xwIGJpbmRpbmcpIGJpbmRpbmcgKGNh ciBiaW5kaW5nKSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAoc20gKGFzc3EgKHN5bWJvbC1u YW1lIHZhcikgZW52KSkpCisgICAgICAgICAgICAgICAgICAgICAgICAoc20gKGFzc3EgdmFyIGVu dikpKQogICAgICAgICAgICAgICAgICAgIChwdXNoIChpZiAobm90IChjZHIgc20pKQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBiaW5kaW5nCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAobGV0ICgobmV4cCAoY2FkciBzbSkpKQpAQCAtMjE0OSw3ICsyMTQ5LDcgQEAgYnkgRVhQQU5T SU9OLCBhbmQgKHNldHEgTkFNRSAuLi4pIHdpbGwgYWN0IGxpa2UgKHNldGYgRVhQQU5TSU9OIC4u LikuCiAgICAgICAgICAgICAobGV0ICgoZXhwYW5zaW9uCiAgICAgICAgICAgICAgICAgICAgOzsg RklYTUU6IEZvciBOIGJpbmRpbmdzLCB0aGlzIHdpbGwgdHJhdmVyc2UgYGJvZHknIE4gdGltZXMh CiAgICAgICAgICAgICAgICAgICAgKG1hY3JvZXhwYW5kLWFsbCAobWFjcm9leHAtcHJvZ24gYm9k eSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjb25zIChsaXN0IChzeW1i b2wtbmFtZSAoY2FhciBiaW5kaW5ncykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoY29ucyAobGlzdCAoY2FhciBiaW5kaW5ncykKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChjbC1jYWRhciBiaW5kaW5ncykpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtYWNyb2V4cGFuZC1hbGwtZW52aXJvbm1l bnQpKSkpCiAgICAgICAgICAgICAgIChpZiAob3IgKG51bGwgKGNkYXIgYmluZGluZ3MpKSAoY2wt Y2RkYXIgYmluZGluZ3MpKQo= --94eb2c13e3ea10d81b054a84b32d-- ------------=_1489951142-10482-1-- From unknown Mon Aug 11 18:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26068: [PATCH] bug in generator function with pcase Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Apr 2017 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Pogonyshev Cc: Mark Oteiza , tino.calancha@gmail.com, 26068@debbugs.gnu.org, Stefan Monnier Received: via spool by 26068-submit@debbugs.gnu.org id=B26068.149105214926794 (code B ref 26068); Sat, 01 Apr 2017 13:10:01 +0000 Received: (at 26068) by debbugs.gnu.org; 1 Apr 2017 13:09:09 +0000 Received: from localhost ([127.0.0.1]:55179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuImD-0006y4-AK for submit@debbugs.gnu.org; Sat, 01 Apr 2017 09:09:09 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuImA-0006xe-Pt for 26068@debbugs.gnu.org; Sat, 01 Apr 2017 09:09:07 -0400 Received: by mail-pg0-f66.google.com with SMTP id g2so22107602pge.2 for <26068@debbugs.gnu.org>; Sat, 01 Apr 2017 06:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xjEEnJDmhUsqMZunlJqdVmYc32fSxUxZpLPowvg4xck=; b=DerXWPtPedEBF16n0/UEPKn6ka3vMiDEazA+mLJLoWekidFCK+TEYxedhydaUpMMrR jACNI4nOUZ84rlcZ2C0jYPKvnVKsdNPOoEs8v2OvfZ/5EzIzFvIHS5IyY5+0XVJK/mDw 6QEFaSJ2RIs5KSCjZOSxf8LA+utAH8gm2vVOdFnSo3DDgSK9usJkvmCscFOPufnMMjj/ CvPMSQzFVXJeDPH1TUqg5pdbiOHlHWnXfRwrB6LfmvzQAiRMMLGJYvzb+tCFvhSBGu0y kWIu5JCh/5qM2Viyk2yX2+6GDBdXjWurSlRAoqZd1pqm0PRXTqISpFneGQNGLjyUb7yy rvMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=xjEEnJDmhUsqMZunlJqdVmYc32fSxUxZpLPowvg4xck=; b=anRrrSBNDpM3hJcbrKPf6OQ8PBY667PJCXjJZQFYKevo0pXhGJf0OFRAa0xQN/1z5A 3mcl0MXVsmIrmbI6aPULTCkoJ8y2u9wMgviiHanS4bBhMv2iJDAEDzVtkUGhVDLLTTMX R7QRVMcFDLpa3XMwcQAu3NdLY0fq5i3NOJtVl1vbKfmA/Hjbj+tZj/j7ZHRNuReuX2nw 1EZdISMF6rGg/g/FIuRfS/N4BNKmUmqUiq4wF93/VnXvK1AzAdxiTG8BLzrtSFm5OOku cAoxF6zyh3L2AAVneJVtjWSCHf8lMANptzfroKY0SJUlPdopMJwDwA2Opqs7EfQbiQVN /xFw== X-Gm-Message-State: AFeK/H10kJIHUcQD+ni2Ca6kAFSmFCqHbi9clpn8BN3HifHcyi7bJv4FSYQ2ISvOIDFcfg== X-Received: by 10.98.160.194 with SMTP id p63mr7418343pfl.72.1491052141155; Sat, 01 Apr 2017 06:09:01 -0700 (PDT) Received: from calancha-pc (234.204.100.220.dy.bbexcite.jp. [220.100.204.234]) by smtp.gmail.com with ESMTPSA id a21sm16222317pfc.36.2017.04.01.06.08.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Apr 2017 06:09:00 -0700 (PDT) From: Tino Calancha References: Date: Sat, 01 Apr 2017 22:08:57 +0900 In-Reply-To: (Paul Pogonyshev's message of "Sun, 12 Mar 2017 09:51:23 +0100") Message-ID: <87efxcp95i.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Paul Pogonyshev writes: > To reproduce: > > (iter-next (funcall (iter-lambda () (pcase (list 1 2) > (`(,a ,b) (iter-yield (+ a b))))))) > > Patch is attached. I have no idea if it affects something else, but > matching symbols with `eq' on their names (`eq' on strings?!) seems > outright wrong to me. It looks also weird to me. It seems written on purpose in order to not expand fuction names in `cl-symbol-macrolet'. Stefan has added a new test 2 days ago which fails after your patch: * test/lisp/emacs-lisp/cl-lib-tests.el (cl-lib-symbol-macrolet) From unknown Mon Aug 11 18:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26068: [PATCH] bug in generator function with pcase Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Apr 2017 13:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Tino Calancha Cc: Mark Oteiza , 26068@debbugs.gnu.org, Stefan Monnier Received: via spool by 26068-submit@debbugs.gnu.org id=B26068.149105426429873 (code B ref 26068); Sat, 01 Apr 2017 13:45:01 +0000 Received: (at 26068) by debbugs.gnu.org; 1 Apr 2017 13:44:24 +0000 Received: from localhost ([127.0.0.1]:55189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuJKK-0007lk-GO for submit@debbugs.gnu.org; Sat, 01 Apr 2017 09:44:24 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuJKI-0007lV-UI for 26068@debbugs.gnu.org; Sat, 01 Apr 2017 09:44:23 -0400 Received: by mail-pf0-f174.google.com with SMTP id 197so4864216pfv.1 for <26068@debbugs.gnu.org>; Sat, 01 Apr 2017 06:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lTdAeICBIlMfndJmXzdud6ngJE44hSjiZ31vM8UTRjc=; b=jqdi4n1s3vWrn5zCuU4C2pFNspG8vzCxucjL767i0OKKz/L0U0EtKM5TfGqSrWKpak TO9spsn+nW0tquQ9gaGdQQjUL8hY8h12ii2SKTo4NPLIHNHDX2pcBpsgjEuii+8676m4 1LghpLvYv7Lzs7PNMP+GLtKVK3oZoOgceJHGLEUBtVi9aN/j67wj3xPepTGlz1EmzKr8 wapr77pDkvpUPI4HdsjJzoGoCOVPMTErRa+znx124cGSyOoBqIc+Tvp55n1rJIhLf4k0 8nN4lIQDvpCR2Y+SEYKe6L5lfwJnCRjXIEgQ6K7a6KPn7hjJb0e7OFdSU5+hpJG0dlak lM0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lTdAeICBIlMfndJmXzdud6ngJE44hSjiZ31vM8UTRjc=; b=gY2xc+SlRgCo1yxFxGbD04/U+xmvVjW0UPGi6yHs+TRJ76Srht7R7esrpZj/1seHmk qvlJpZUvjExE8bXGGXujC6P40DmamBV++G41MvSr3eR4H913yXNOPvs1uCAINTGB1bp5 4tXiKohNasX1l1ExPLgGvWoKL7NTnk8Mwx4JRCNeoCxeqYkTUcrv0azRSRrNmGmqXOe7 jzTvNFRlVt5APIE3Dfz7DTPEXI15wg/fnUy6a97/MauA12LOAevFGv6y/gKEQKnM3TnK KR4VEwnzpHcCFCnpD6e4cQe9mGdl7/TEdcRTuWkAyNdSBB28vY0gzNU1qvKt9PygdygM 1O9w== X-Gm-Message-State: AFeK/H0njpUB41wgfN3JvdjfQBJdTJi45cSRhtn3MHnwuxDaqpxtO1QvwQDMAq+WfGysJmk2yuSJYK1hdNV71A== X-Received: by 10.84.230.129 with SMTP id e1mr9391508plk.66.1491054257117; Sat, 01 Apr 2017 06:44:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.143.234 with HTTP; Sat, 1 Apr 2017 06:44:16 -0700 (PDT) In-Reply-To: <87efxcp95i.fsf@calancha-pc> References: <87efxcp95i.fsf@calancha-pc> From: Paul Pogonyshev Date: Sat, 1 Apr 2017 15:44:16 +0200 Message-ID: Content-Type: multipart/mixed; boundary=94eb2c11acc6564a6d054c1b1ff8 X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) --94eb2c11acc6564a6d054c1b1ff8 Content-Type: text/plain; charset=UTF-8 Attached is the testcase from the bug as a patch. It might be best to reformulate it without `pcase' though, to avoid depending on its implementation details. The testcase fails before the patch, passes now. So, I don't know anything about `cl-flet', but the patch was not without reasons. Paul On 1 April 2017 at 15:08, Tino Calancha wrote: > Paul Pogonyshev writes: > >> To reproduce: >> >> (iter-next (funcall (iter-lambda () (pcase (list 1 2) >> (`(,a ,b) (iter-yield (+ a b))))))) >> >> Patch is attached. I have no idea if it affects something else, but >> matching symbols with `eq' on their names (`eq' on strings?!) seems >> outright wrong to me. > It looks also weird to me. It seems written on purpose in order to > not expand fuction names in `cl-symbol-macrolet'. > > Stefan has added a new test 2 days ago which fails after your > patch: > * test/lisp/emacs-lisp/cl-lib-tests.el (cl-lib-symbol-macrolet) --94eb2c11acc6564a6d054c1b1ff8 Content-Type: text/plain; charset=US-ASCII; name="pcase-generator-test.diff" Content-Disposition: attachment; filename="pcase-generator-test.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j0zb75o50 ZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2dlbmVyYXRvci10ZXN0cy5lbCBiL3Rl c3QvbGlzcC9lbWFjcy1saXNwL2dlbmVyYXRvci10ZXN0cy5lbAppbmRleCAxYTU2N2FjNzBmLi4x MTU0MmFiMTVkIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9nZW5lcmF0b3ItdGVz dHMuZWwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvZ2VuZXJhdG9yLXRlc3RzLmVsCkBAIC0y ODIsMyArMjgyLDEwIEBAIGlkZW50aWNhbCBvdXRwdXQuCiAoZXJ0LWRlZnRlc3QgY3BzLXRlc3Qt ZGVjbGFyYXRpb25zLXByZXNlcnZlZCAoKQogICAoc2hvdWxkIChlcXVhbCAoZG9jdW1lbnRhdGlv biAnZ2VuZXJhdG9yLXdpdGgtZG9jc3RyaW5nKSAiRG9jdW1lbnRhdGlvbiEiKSkKICAgKHNob3Vs ZCAoZXF1YWwgKGdldCAnZ2VuZXJhdG9yLXdpdGgtZG9jc3RyaW5nICdsaXNwLWluZGVudC1mdW5j dGlvbikgNSkpKQorCis7OyBCdWcgIzI2MDY4LiAgVGhlIHByb2JsZW0gaXMgdGhhdCBgcGNhc2Un IHVzZXMgc2V2ZXJhbCBgeCcgc3ltYm9scywKKzs7IHdoaWNoIGFyZSBub3QgaWRlbnRpY2FsLCBi dXQgaGF2ZSB0aGUgc2FtZSBuYW1lLgorKGVydC1kZWZ0ZXN0IGNwcy10ZXN0LXN5bWJvbHMtd2l0 aC1zYW1lLW5hbWUgKCkKKyAgKHNob3VsZCAoZXF1YWwgKGl0ZXItbmV4dCAoZnVuY2FsbCAoaXRl ci1sYW1iZGEgKCkgKHBjYXNlIChsaXN0IDEgMikKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYCgsYSAsYikgKGl0ZXIteWllbGQgKCsgYSBi KSkpKSkpKQorICAgICAgICAgICAgICAgICAzKSkpCg== --94eb2c11acc6564a6d054c1b1ff8-- From unknown Mon Aug 11 18:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26068: [PATCH] bug in generator function with pcase Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Apr 2017 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Pogonyshev Cc: Mark Oteiza , 26068@debbugs.gnu.org, Tino Calancha Received: via spool by 26068-submit@debbugs.gnu.org id=B26068.149106314011611 (code B ref 26068); Sat, 01 Apr 2017 16:13:02 +0000 Received: (at 26068) by debbugs.gnu.org; 1 Apr 2017 16:12:20 +0000 Received: from localhost ([127.0.0.1]:55908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuLdU-00031D-4G for submit@debbugs.gnu.org; Sat, 01 Apr 2017 12:12:20 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:46764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuLdR-000315-Mz for 26068@debbugs.gnu.org; Sat, 01 Apr 2017 12:12:18 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v31GCFwi021623; Sat, 1 Apr 2017 12:12:16 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 8F558661EE; Sat, 1 Apr 2017 12:12:15 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87efxcp95i.fsf@calancha-pc> Date: Sat, 01 Apr 2017 12:12:15 -0400 In-Reply-To: (Paul Pogonyshev's message of "Sat, 1 Apr 2017 15:44:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5988=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5988> : inlines <5770> : streams <1739496> : uri <2402034> X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > +;; Bug #26068. The problem is that `pcase' uses several `x' symbols, > +;; which are not identical, but have the same name. > +(ert-deftest cps-test-symbols-with-same-name () > + (should (equal (iter-next (funcall (iter-lambda () (pcase (list 1 2) > + (`(,a ,b) (iter-yield (+ a b))))))) > + 3))) Right. I guess the core if the issue would be reproduced with something like (defmacro cl-lib-symbol-macrolet-4+5 () (let* ((sname "x") (s1 (make-symbol sname)) (s2 (make-symbol sname))) `(cl-symbol-macrolet ((,s1 4) (,s2 5)) (+ ,s1 ,s2)))) (ert-deftest cl-lib-symbol-macrolet-2 () (should (equal (cl-lib-symbol-macrolet-4+5) (+ 4 5)))) Before your patch, the macro's code returned 10 rather than 9. I installed this test in cl-lib-tests.el. Stefan