From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 01:45:01 2017 Received: (at submit) by debbugs.gnu.org; 10 Mar 2017 06:45:01 +0000 Received: from localhost ([127.0.0.1]:48322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmEIO-0001sH-QY for submit@debbugs.gnu.org; Fri, 10 Mar 2017 01:45:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmDjm-0000vv-65 for submit@debbugs.gnu.org; Fri, 10 Mar 2017 01:09:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmDjf-0003FG-MF for submit@debbugs.gnu.org; Fri, 10 Mar 2017 01:09:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43709) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cmDjf-0003FB-Ja for submit@debbugs.gnu.org; Fri, 10 Mar 2017 01:09:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmDje-0004Nv-5g for bug-coreutils@gnu.org; Fri, 10 Mar 2017 01:09:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmDjb-0003E5-1O for bug-coreutils@gnu.org; Fri, 10 Mar 2017 01:09:06 -0500 Received: from mail-ua0-x235.google.com ([2607:f8b0:400c:c08::235]:34974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cmDja-0003DV-T4 for bug-coreutils@gnu.org; Fri, 10 Mar 2017 01:09:02 -0500 Received: by mail-ua0-x235.google.com with SMTP id q7so88285282uaf.2 for ; Thu, 09 Mar 2017 22:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:content-transfer-encoding:mime-version:subject :date; bh=MELau+2Giui6XQvFgdOLJMb6fOciHZSUOByjyyegnrU=; b=q+qr88IJVNsNoNmrtVqcdD3TGAitu8U6ug2to7dsi+R72+lwvnceZUZINMV2vQAzbM VrKmVBXqVmESM3PPM970YjXfjz5axq4O77QxcaoDM6vxcwFybd8sG8xVJbvdB21pzkFV v6U71uskpJNBDzOpRphU4N6irscs2rowIo1STXTqTq0GhS6ofY3snizZ47aOVBKyOSRs j8Sn06DyTX51bpUtM34Bps9+7M+Q+tipY/SzWP0Yt5HiN2GdPeLkRK2JNDan86INp4yF ZYt1VraLWE0Cvwe3kRkl8Y6vO387eJS/ukYzd1MAsHDyEov2xDqA+VFKRs8zZivL3H/s RPHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:content-transfer-encoding :mime-version:subject:date; bh=MELau+2Giui6XQvFgdOLJMb6fOciHZSUOByjyyegnrU=; b=BfumqI0aVV3R/YFhMtTHS1feLeUEF0dYU7Vl066pPHGbT2ZMwLl90wQ6H2TJsfkTFu 2vdmiFBOyCS0gRSyyOCq77GaQB90uIhw+1Fo+ZBCqU0JgOV49n5j+/D0eDScoEPuVmck cOFBDLzEqOfixmf0WVo6unc+Wf0/DI9IeMTgwNVOF/zPByTJlYSNf1LGQhSJirqtXrbw JSBMw41VSs5MSBXDHbkSG+arhH+14M57dlgPZDo6sZOeSdAZZ7/X02QMy0GaCOQGRBfh yVmosTo5QW6gu1ZilBLpMfIG5P3LAqId4t+VlIFYDJS8ag7QaOHV6wC55XnZ3qDKaBTi XBmg== X-Gm-Message-State: AMke39kshQeuo00abslr8xAZZ7J6Xz8o0dLxINyFq+uyVZwgyydF+RmSJCTBqXfHJTE7SA== X-Received: by 10.176.7.38 with SMTP id h35mr9108485uah.103.1489126140720; Thu, 09 Mar 2017 22:09:00 -0800 (PST) Received: from [192.168.1.3] (71-34-145-239.clsp.qwest.net. [71.34.145.239]) by smtp.gmail.com with ESMTPSA id w135sm2046783vkw.0.2017.03.09.22.09.00 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 09 Mar 2017 22:09:00 -0800 (PST) Message-Id: <0CEBF02A-FCFB-4923-BC30-BC5F8C0A770D@gmail.com> From: J Rogowsky To: bug-coreutils@gnu.org Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: coreutils-8.27 fails to build Date: Thu, 9 Mar 2017 23:08:58 -0700 X-Mailer: Apple Mail (2.936) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 10 Mar 2017 01:44:59 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) coreutils-8.27 fails to build. function renameat, found in src/force-link.c, is not found on my system, which is an iBook G4 running OSX 10.5.8. Therefore the link step fails, citing the linker cannot find _renameat. I see there is a similar function in lib/at-func2.c which could be used, but I chose to solve this problem in the simplest way possible by defining renameat in src/force-link.c like so: diff src/force-link.c src/force-link.c.OEM 86,93d85 < /* see: https://www.freebsd.org/cgi/man.cgi?query=rename&sektion=2 */ < static int < renameat(int fromfd,const char *from,int tofd,const char *to) < { < return rename(from,to); < } < < Perhaps there is a better solution? Such as using at_func2 in src/force-link.c like so: static int renameat(int fromfd,const char *from,int tofd,const char *to) { return at_func2(fromfd,from,tofd,to,rename); } ???????????????? BTW, I had only one test FAIL in "make check": tests/misc/sort-debug- keys Is this related to the above? If you would like further assistance on this matter, just let me know how I could help. Thanks, J Rogowsky From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 02:23:03 2017 Received: (at 26044) by debbugs.gnu.org; 10 Mar 2017 07:23:04 +0000 Received: from localhost ([127.0.0.1]:48352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmEtD-0002lx-LO for submit@debbugs.gnu.org; Fri, 10 Mar 2017 02:23:03 -0500 Received: from midir.magicbluesmoke.com ([82.195.144.46]:55692 helo=mail.magicbluesmoke.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmEtC-0002lJ-0Q for 26044@debbugs.gnu.org; Fri, 10 Mar 2017 02:23:02 -0500 Received: from localhost.localdomain (mobile-166-171-250-007.mycingular.net [166.171.250.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id BB2E8155; Fri, 10 Mar 2017 07:22:59 +0000 (GMT) Subject: Re: bug#26044: coreutils-8.27 fails to build To: J Rogowsky , 26044@debbugs.gnu.org References: <0CEBF02A-FCFB-4923-BC30-BC5F8C0A770D@gmail.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: Date: Thu, 9 Mar 2017 23:22:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <0CEBF02A-FCFB-4923-BC30-BC5F8C0A770D@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26044 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 09/03/17 22:08, J Rogowsky wrote: > coreutils-8.27 fails to build. > > function renameat, found in src/force-link.c, is not found on my > system, which is an iBook G4 running OSX 10.5.8. > Therefore the link step fails, citing the linker cannot find _renameat. Drats. It looks like the coreutils source repo will need something like: diff --git a/bootstrap.conf b/bootstrap.conf index 7def1f9..30ce621 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -202,6 +202,7 @@ gnulib_modules=" regex remove rename + renameat rmdir root-dev-ino rpmatch > I see there is a similar function in lib/at-func2.c which could be > used, but I chose to solve this problem in the simplest way possible > by defining renameat in src/force-link.c like so: > > diff src/force-link.c src/force-link.c.OEM > 86,93d85 > < /* see: https://www.freebsd.org/cgi/man.cgi?query=rename&sektion=2 */ > < static int > < renameat(int fromfd,const char *from,int tofd,const char *to) > < { > < return rename(from,to); > < } I've not analysed whether that will work (in all cases). > Perhaps there is a better solution? > Such as using at_func2 in src/force-link.c like so: > > static int > renameat(int fromfd,const char *from,int tofd,const char *to) > { > return at_func2(fromfd,from,tofd,to,rename); > } > > ???????????????? I've applied that locally and generated an untested tarball with `make dist`: https://www.pixelbeat.org/cu/coreutils-8.27.4-3c9d7.tar.xz Could you test that one out? > BTW, I had only one test FAIL in "make check": tests/misc/sort-debug- > keys > Is this related to the above? I'm guessing that "failure" might be locale related. Could you attach the tests/test-suite.log file generated with: make TESTS=tests/misc/sort-debug-keys.sh SUBDIRS=. VERBOSE=yes check thanks, Pádraig From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 02:33:16 2017 Received: (at 26044) by debbugs.gnu.org; 10 Mar 2017 07:33:16 +0000 Received: from localhost ([127.0.0.1]:48364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmF36-00034B-3X for submit@debbugs.gnu.org; Fri, 10 Mar 2017 02:33:16 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmF33-00033y-Hq for 26044@debbugs.gnu.org; Fri, 10 Mar 2017 02:33:14 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7E62F160069; Thu, 9 Mar 2017 23:33:07 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id W3f9TSE37wx9; Thu, 9 Mar 2017 23:33:06 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 936DA160072; Thu, 9 Mar 2017 23:33:06 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MvMZy_IC8hVC; Thu, 9 Mar 2017 23:33:06 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7349D160069; Thu, 9 Mar 2017 23:33:06 -0800 (PST) Subject: Re: bug#26044: coreutils-8.27 fails to build To: =?UTF-8?Q?P=c3=a1draig_Brady?= , J Rogowsky , 26044@debbugs.gnu.org References: <0CEBF02A-FCFB-4923-BC30-BC5F8C0A770D@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <4a22f214-f83d-2da1-a29f-534697fc75ca@cs.ucla.edu> Date: Thu, 9 Mar 2017 23:33:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26044 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) P=C3=A1draig Brady wrote: > Drats. It looks like the coreutils source repo will need something like= : > > diff --git a/bootstrap.conf b/bootstrap.conf > index 7def1f9..30ce621 100644 > --- a/bootstrap.conf > +++ b/bootstrap.conf > @@ -202,6 +202,7 @@ gnulib_modules=3D" > regex > remove > rename > + renameat > rmdir > root-dev-ino > rpmatch Yes, that looks like the right fix. Sorry about that. >> diff src/force-link.c src/force-link.c.OEM >> 86,93d85 >> < /* see: https://www.freebsd.org/cgi/man.cgi?query=3Drename&sektion=3D= 2 */ >> < static int >> < renameat(int fromfd,const char *from,int tofd,const char *to) >> < { >> < return rename(from,to); >> < } > > I've not analysed whether that will work (in all cases). It should be an adequate workaround for coreutils. I'd rather fix it the = right=20 way, though, as the module is intended for more-general use. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 15:19:28 2017 Received: (at 26044) by debbugs.gnu.org; 10 Mar 2017 20:19:28 +0000 Received: from localhost ([127.0.0.1]:50018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmR0a-0007Hu-Lp for submit@debbugs.gnu.org; Fri, 10 Mar 2017 15:19:28 -0500 Received: from powered.by.root24.eu ([5.135.3.88]:56962 helo=Root24.de ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmR0Z-0007Hm-4W for 26044@debbugs.gnu.org; Fri, 10 Mar 2017 15:19:27 -0500 Received: from nopileos.local (178.162.222.41.adsl.inet-telecom.org [178.162.222.41]) by mail.ionic.de (Postfix) with ESMTPSA id 31AAF4F00456 for <26044@debbugs.gnu.org>; Fri, 10 Mar 2017 21:19:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1489177164; bh=vwWmWB26OGknvvTpJsliZ9cZfJrXfNtPju/36aYT5fw=; h=To:From:Subject:Date:From; b=k0PijNPjB65BfNxPEGiT8ZCLhf1ZdHmx0C1vo7wbXTvQpWu/Wl1GB5H03hazsVbCp KiPz1hguIuUt9u+2eGR1rvZzlvaX4oossEb49l/GSMb4yuildbLtkHX9LbvHsP/bz0 /8BHkqiZxHdZ8xU07ieXnrBXru1XjaacISlgGfWU= To: 26044@debbugs.gnu.org From: Mihai Moldovan Subject: Re: coreutils-8.27 fails to build Message-ID: Date: Fri, 10 Mar 2017 21:19:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QSlh37Ub8bj1bcAceTQKTtJ8pflDWollo" X-Spam-Score: 3.7 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: We (naturally) also hit that in MacPorts. Downstream bug report: https://trac.macports.org/ticket/53764 I've fixed it for our package by manually inserting the renameat gnulib module. [...] Content analysis details: (3.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 3.7 FAKE_REPLY_A1 No description available. X-Debbugs-Envelope-To: 26044 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 3.7 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: We (naturally) also hit that in MacPorts. Downstream bug report: https://trac.macports.org/ticket/53764 I've fixed it for our package by manually inserting the renameat gnulib module. [...] Content analysis details: (3.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 3.7 FAKE_REPLY_A1 No description available. This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QSlh37Ub8bj1bcAceTQKTtJ8pflDWollo Content-Type: multipart/mixed; boundary="VeFLeM087V5vu0CU6IQ7VNhvIgI3XQOcE"; protected-headers="v1" From: Mihai Moldovan To: 26044@debbugs.gnu.org Message-ID: Subject: Re: coreutils-8.27 fails to build --VeFLeM087V5vu0CU6IQ7VNhvIgI3XQOcE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable We (naturally) also hit that in MacPorts. Downstream bug report: https://trac.macports.org/ticket/53764 I've fixed it for our package by manually inserting the renameat gnulib m= odule. I assume that your change to bootstrap.conf also (automatically) adds the= renameat gnulib module, so that's indeed to right way to go. Mihai --VeFLeM087V5vu0CU6IQ7VNhvIgI3XQOcE-- --QSlh37Ub8bj1bcAceTQKTtJ8pflDWollo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJYwwpIAAoJEB/WLtluJTqHqIwQALz7mGGxjkf586R5eV9GjE6A JQhA50qkIe82NcPpyav/ZZ4+SlENY/6cpOV5KkaF9AK9vRk9F7dP6T0nL1JDUm+w Qld6508wrfepMApSJLX5A4Hq68uxeuqBtXni8b0PWXqVvtMtTv4+DTtuAQORpsoL hiFZkGORqu79LyAU9nH6gMselLLQHrEG8IaQMJbReb9Sl/P40Tb/gOFuGVEE2QT5 2uUFi2xR4vgh8vbOrN0Tt5ZiqN+7yhXUO+h27GCcYDxcBvmGvWwy0Kwx9EwFHBDZ EENRRstOpiJ90Vzq35wO5J/MyzMEq5Xz1z/qtLtf8PM72dE0xEEpSwIj65dSy1y+ p6RmD8dyKY0P4jUAcF75BcL69XHG0AoJDtLc5Oeyn00lGfCiv2WF1CWxDPvguHSH ggS2CXP9fjByLaES46iC748kO1VPlXKdWcqhpoljtcLQqFdlxrV5dWIwKVyENJBO TEwlCm73oNGlN8fW2lwGYmbPaTBzBX+xknetrDFlanNhc8OdtJoCbVhdmeCUHdte GRqcfmUIcezTH+LnQC6MrnNmJzYYcUAW9+p/BuWgido9Th2N9tU7iK+vExOSExNN QeuKTV+JWZYq/OfoiwDzU/L5gDh+CO+fJfPlhOCGwAY48ZC7eWWSuUfZnnb0aNVb juYUtADG7pxn70EQKCZz =ti4U -----END PGP SIGNATURE----- --QSlh37Ub8bj1bcAceTQKTtJ8pflDWollo-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 11 00:29:06 2017 Received: (at 26044-done) by debbugs.gnu.org; 11 Mar 2017 05:29:06 +0000 Received: from localhost ([127.0.0.1]:50170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmZaT-0006bB-VD for submit@debbugs.gnu.org; Sat, 11 Mar 2017 00:29:06 -0500 Received: from midir.magicbluesmoke.com ([82.195.144.46]:36856 helo=mail.magicbluesmoke.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmZaS-0006b2-2e for 26044-done@debbugs.gnu.org; Sat, 11 Mar 2017 00:29:04 -0500 Received: from localhost.localdomain (unknown [166.170.37.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 1A5CE4A41; Sat, 11 Mar 2017 05:28:58 +0000 (GMT) Subject: Re: bug#26044: coreutils-8.27 fails to build To: Mihai Moldovan , 26044-done@debbugs.gnu.org References: <0CEBF02A-FCFB-4923-BC30-BC5F8C0A770D@gmail.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <68267b45-d997-0673-773f-6a21b1c927cd@draigBrady.com> Date: Fri, 10 Mar 2017 21:28:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26044-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 10/03/17 12:19, Mihai Moldovan wrote: > We (naturally) also hit that in MacPorts. > > Downstream bug report: https://trac.macports.org/ticket/53764 > > I've fixed it for our package by manually inserting the renameat gnulib module. > > I assume that your change to bootstrap.conf also (automatically) adds the > renameat gnulib module, so that's indeed to right way to go. Right. I had provided a tarball generated with the bootstrap.conf change for the original reporter at: https://www.pixelbeat.org/cu/coreutils-8.27.4-3c9d7.tar.xz which you might find useful for comparison. J has reported the build now works with the above change in effect, so I've pushed and I'm marking this as done. cheers, Pádraig From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 11 02:11:10 2017 Received: (at 26044) by debbugs.gnu.org; 11 Mar 2017 07:11:10 +0000 Received: from localhost ([127.0.0.1]:50207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmbBG-0000hz-HP for submit@debbugs.gnu.org; Sat, 11 Mar 2017 02:11:10 -0500 Received: from midir.magicbluesmoke.com ([82.195.144.46]:40004 helo=mail.magicbluesmoke.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmbBE-0000hp-MY for 26044@debbugs.gnu.org; Sat, 11 Mar 2017 02:11:09 -0500 Received: from localhost.localdomain (unknown [166.170.37.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 7118C94BB; Sat, 11 Mar 2017 07:11:06 +0000 (GMT) Subject: Re: bug#26044: coreutils-8.27 fails to build To: J Rogowsky , 26044@debbugs.gnu.org References: <0CEBF02A-FCFB-4923-BC30-BC5F8C0A770D@gmail.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: Date: Fri, 10 Mar 2017 23:11:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------7CB2CA833016D684CE077143" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26044 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------7CB2CA833016D684CE077143 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit On 09/03/17 23:22, Pádraig Brady wrote: >> BTW, I had only one test FAIL in "make check": tests/misc/sort-debug- >> keys >> Is this related to the above? > I'm guessing that "failure" might be locale related. > Could you attach the tests/test-suite.log file generated with: > make TESTS=tests/misc/sort-debug-keys.sh SUBDIRS=. VERBOSE=yes check Best keep all responses on the list. The log you sent privately, did indeed indicate a locale issue. In particular sort was operating in LC_ALL=C mode when it should have been in fr_FR.utf8. This is the only test that sets LC_MESSAGES separately to LC_COLLATE etc. so perhaps if we use LC_ALL for each sort invocation in this test, it avoids this particular issue on your system? Can you try running the above make check command again, with the attached patch applied. thanks, Pádraig --------------7CB2CA833016D684CE077143 Content-Type: text/x-patch; name="sort-debug-osx.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="sort-debug-osx.patch" diff --git a/tests/misc/sort-debug-keys.sh b/tests/misc/sort-debug-keys.sh index f90aa0f..cb03a1f 100755 --- a/tests/misc/sort-debug-keys.sh +++ b/tests/misc/sort-debug-keys.sh @@ -324,13 +324,13 @@ if test "$LOCALE_FR_UTF8" != "none"; then echo ' 1²---++3 1,234 Mi' | LC_ALL=C sort --debug -k2g -k1b,1 echo ' 1²---++3 1,234 Mi' | - LC_COLLATE=$f LC_CTYPE=$f LC_NUMERIC=$f LC_MESSAGES=C \ - sort --debug -k2g -k1b,1 + LC_ALL=$f sort --debug -k2g -k1b,1 echo '+1234 1234Gi 1,234M' | - LC_COLLATE=$f LC_CTYPE=$f LC_NUMERIC=$f LC_MESSAGES=C \ - sort --debug -k1,1n -k1,1g \ - -k1,1h -k2,2n -k2,2g -k2,2h -k3,3n -k3,3g -k3,3h - ) > out + LC_ALL=$f sort --debug \ + -k1,1n -k1,1g -k1,1h \ + -k2,2n -k2,2g -k2,2h \ + -k3,3n -k3,3g -k3,3h + ) | sed 's/^^ .*/^ no match for key/' > out compare exp out || fail=1 fi --------------7CB2CA833016D684CE077143-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 11 12:12:18 2017 Received: (at 26044) by debbugs.gnu.org; 11 Mar 2017 17:12:18 +0000 Received: from localhost ([127.0.0.1]:51648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmkZ0-0003fN-KJ for submit@debbugs.gnu.org; Sat, 11 Mar 2017 12:12:18 -0500 Received: from mail-vk0-f42.google.com ([209.85.213.42]:34724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmkYz-0003fA-Fm for 26044@debbugs.gnu.org; Sat, 11 Mar 2017 12:12:17 -0500 Received: by mail-vk0-f42.google.com with SMTP id r136so20022113vke.1 for <26044@debbugs.gnu.org>; Sat, 11 Mar 2017 09:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=cc:message-id:from:to:in-reply-to:mime-version:subject:date :references; bh=4j6nuamvemE1cvCz+nn/7+DgbJPrnDOGjp7SYtYnR6U=; b=ZPY7vcD2Lp1iHkdJvwsOxUj/W2KqRTaRp/kraVYI6SItYHK7080lGw+9pVCG/6FMW9 IER7/ntKr7mpOy4rXKfEQ9PT4s0cVQwU3+CU46NdjBvfuJ1Y6TSMrqLSY1K8wMiO26wF 4h2Z8ken5utK//vjJz19CREYWubOfILugzETBw0r3q3ZS3HWSwd/hcYIzD+FP+tmMbv2 7ivMEyY346J7IxRJro6k3Xsp9veB/tl+j2wgrcL6eftvYJQFHiXUdaOes72CFrQ73xxw Htf6n2icPO8p9eaPHb+H4m9yiKD1Wznw0ZL5HPxHgUBM26mmWWG+8vNtmbRhbPzIOzma Jsmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:message-id:from:to:in-reply-to:mime-version :subject:date:references; bh=4j6nuamvemE1cvCz+nn/7+DgbJPrnDOGjp7SYtYnR6U=; b=QKas5jL7AxErVm7FAO8IEDbATbUJUxIITZNFtmbnXldAFUxK0bibFgVWLWSP4rf9bz HimLJLUypXCbx4xsOfI73OfxqUivHhFv0ksZ48iGcaL37r9KyAHpvec9Yy62Sk+8dpWe aHNN5vsPCdwZOvcozT8f+DaFyKx4HEsFL32R1CmfOupUCq8TwhS1EJ5VUISOeEtKmokX wKBIsmN0pVA+vi+feCipzYiHtuoO1EYMVjX+KtnyS1E8a2k8Y/2K/LLD4WLWvsaTJZU1 rftbfxn9R7s8itK5eZk//7lVQ15jFP+yDxM3FOy39bDxch7eZk7xArRVbHF93O6j0uTE LAhQ== X-Gm-Message-State: AMke39mZJa6MN71WReAtU3E++/Sdl8u+eFrv0ONnVpMH93D6pTFsTJrRL4yL27PKkyjdWQ== X-Received: by 10.31.151.196 with SMTP id z187mr12213600vkd.41.1489252331869; Sat, 11 Mar 2017 09:12:11 -0800 (PST) Received: from [192.168.1.3] (71-34-145-239.clsp.qwest.net. [71.34.145.239]) by smtp.gmail.com with ESMTPSA id k3sm3373298uak.27.2017.03.11.09.12.10 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 11 Mar 2017 09:12:11 -0800 (PST) Message-Id: <7E7BD971-FD32-4D73-A5FB-1F4066EDC6E7@gmail.com> From: J Rogowsky To: 26044@debbugs.gnu.org In-Reply-To: Content-Type: multipart/mixed; boundary=Apple-Mail-29--155978587 Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: bug#26044: coreutils-8.27 fails to build Date: Sat, 11 Mar 2017 10:12:09 -0700 References: <0CEBF02A-FCFB-4923-BC30-BC5F8C0A770D@gmail.com> X-Mailer: Apple Mail (2.936) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26044 Cc: =?WINDOWS-1252?Q?P=E1draig_Brady?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --Apple-Mail-29--155978587 Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable On 2017.03.11, at 00:11:03, P=E1draig Brady wrote: > On 09/03/17 23:22, P=E1draig Brady wrote: >>> BTW, I had only one test FAIL in "make check": tests/misc/sort-=20 >>> debug- >>> keys >>> Is this related to the above? >> I'm guessing that "failure" might be locale related. >> Could you attach the tests/test-suite.log file generated with: >> make TESTS=3Dtests/misc/sort-debug-keys.sh SUBDIRS=3D. VERBOSE=3Dyes = check > > Best keep all responses on the list. Sorry. I am a newbie at this and not accustomed to doing this kind of =20= thing. > The log you sent privately, did indeed indicate a locale issue. > In particular sort was operating in LC_ALL=3DC mode when > it should have been in fr_FR.utf8. This is the only test > that sets LC_MESSAGES separately to LC_COLLATE etc. > so perhaps if we use LC_ALL for each sort invocation in > this test, it avoids this particular issue on your system? > > Can you try running the above make check command again, > with the attached patch applied. > > thanks, > P=E1draig > Yes, that solved the problem. test results attached. --Apple-Mail-29--155978587 Content-Disposition: attachment; filename=testresults Content-Type: application/octet-stream; x-unix-mode=0644; name="testresults" Content-Transfer-Encoding: 7bit # patch -p0 -b < sort-debug-osx.patch can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/tests/misc/sort-debug-keys.sh b/tests/misc/sort-debug-keys.sh |index f90aa0f..cb03a1f 100755 |--- a/tests/misc/sort-debug-keys.sh |+++ b/tests/misc/sort-debug-keys.sh -------------------------- File to patch: tests/misc/sort-debug-keys.sh patching file tests/misc/sort-debug-keys.sh # ls -l tests/misc/sort-debug-keys* -rw-r--r-- 1 gopher staff 9345 Mar 10 09:49 tests/misc/sort-debug-keys.log -rwxr-xr-x 1 gopher staff 4874 Mar 11 09:32 tests/misc/sort-debug-keys.sh -rwxr-xr-x 1 gopher staff 4924 Mar 9 23:55 tests/misc/sort-debug-keys.sh.orig -rw-r--r-- 1 gopher staff 84 Mar 10 09:49 tests/misc/sort-debug-keys.trs # # # # # make TESTS=tests/misc/sort-debug-keys.sh SUBDIRS=. VERBOSE=yes check GEN public-submodule-commit make check-recursive make[1]: Entering directory '/Users/gopher/src/coreutils-8.27.4-3c9d7' Making check in . make[2]: Entering directory '/Users/gopher/src/coreutils-8.27.4-3c9d7' make check-TESTS check-local make[3]: Entering directory '/Users/gopher/src/coreutils-8.27.4-3c9d7' make[4]: Entering directory '/Users/gopher/src/coreutils-8.27.4-3c9d7' PASS: tests/misc/sort-debug-keys.sh ============================================================================ Testsuite summary for GNU coreutils 8.27.4-3c9d7 ============================================================================ # TOTAL: 1 # PASS: 1 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ make[4]: Leaving directory '/Users/gopher/src/coreutils-8.27.4-3c9d7' GEN check-README GEN check-duplicate-no-install GEN sc-avoid-builtin GEN sc-avoid-io GEN sc-avoid-non-zero GEN sc-avoid-path GEN sc-avoid-timezone GEN sc-avoid-zeroes GEN sc-exponent-grouping GEN sc-lower-case-var GEN check-texinfo make[3]: Leaving directory '/Users/gopher/src/coreutils-8.27.4-3c9d7' make[2]: Leaving directory '/Users/gopher/src/coreutils-8.27.4-3c9d7' make[1]: Leaving directory '/Users/gopher/src/coreutils-8.27.4-3c9d7' # --Apple-Mail-29--155978587 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Thank you for your efforts. If there is anything I can do for you in the future, just let me know. Regards, J Rogowsky --Apple-Mail-29--155978587-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 11 13:53:33 2017 Received: (at 26044) by debbugs.gnu.org; 11 Mar 2017 18:53:33 +0000 Received: from localhost ([127.0.0.1]:51728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmm8z-0001Hb-Hx for submit@debbugs.gnu.org; Sat, 11 Mar 2017 13:53:33 -0500 Received: from midir.magicbluesmoke.com ([82.195.144.46]:44758 helo=mail.magicbluesmoke.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmm8x-0001HN-Et for 26044@debbugs.gnu.org; Sat, 11 Mar 2017 13:53:31 -0500 Received: from localhost.localdomain (unknown [166.170.37.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 27B9725A; Sat, 11 Mar 2017 18:53:28 +0000 (GMT) Subject: Re: bug#26044: coreutils-8.27 fails to build To: J Rogowsky , 26044@debbugs.gnu.org References: <0CEBF02A-FCFB-4923-BC30-BC5F8C0A770D@gmail.com> <7E7BD971-FD32-4D73-A5FB-1F4066EDC6E7@gmail.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <64c4e1c3-678a-ff2d-d9a2-2cda9ac864ff@draigBrady.com> Date: Sat, 11 Mar 2017 10:53:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <7E7BD971-FD32-4D73-A5FB-1F4066EDC6E7@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26044 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 11/03/17 09:12, J Rogowsky wrote: > On 2017.03.11, at 00:11:03, Pádraig Brady wrote: > >> On 09/03/17 23:22, Pádraig Brady wrote: >>>> BTW, I had only one test FAIL in "make check": tests/misc/sort- >>>> debug- >>>> keys >>>> Is this related to the above? >>> I'm guessing that "failure" might be locale related. >>> Could you attach the tests/test-suite.log file generated with: >>> make TESTS=tests/misc/sort-debug-keys.sh SUBDIRS=. VERBOSE=yes check >> >> Best keep all responses on the list. > Sorry. I am a newbie at this and not accustomed to doing this kind of > thing. > >> The log you sent privately, did indeed indicate a locale issue. >> In particular sort was operating in LC_ALL=C mode when >> it should have been in fr_FR.utf8. This is the only test >> that sets LC_MESSAGES separately to LC_COLLATE etc. >> so perhaps if we use LC_ALL for each sort invocation in >> this test, it avoids this particular issue on your system? >> >> Can you try running the above make check command again, >> with the attached patch applied. >> >> thanks, >> Pádraig >> > > Yes, that solved the problem. > test results attached. Excellent. Pushed at: http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.27-6-g04148c9 thanks! Pádraig. From unknown Fri Jun 20 07:18:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 09 Apr 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator