From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: Evgeni Kolev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Mar 2017 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 26037@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148908029420766 (code B ref -1); Thu, 09 Mar 2017 17:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 Mar 2017 17:24:54 +0000 Received: from localhost ([127.0.0.1]:47953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cm1o5-0005Oq-SG for submit@debbugs.gnu.org; Thu, 09 Mar 2017 12:24:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cm1O8-0004jo-Fu for submit@debbugs.gnu.org; Thu, 09 Mar 2017 11:58:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cm1O0-0006Xt-Hh for submit@debbugs.gnu.org; Thu, 09 Mar 2017 11:57:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cm1O0-0006Xn-ER for submit@debbugs.gnu.org; Thu, 09 Mar 2017 11:57:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cm1Nx-000870-JY for bug-gnu-emacs@gnu.org; Thu, 09 Mar 2017 11:57:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cm1Nu-0006WQ-Kj for bug-gnu-emacs@gnu.org; Thu, 09 Mar 2017 11:57:53 -0500 Received: from mail-qk0-x229.google.com ([2607:f8b0:400d:c09::229]:35956) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cm1Nu-0006Vo-Dt for bug-gnu-emacs@gnu.org; Thu, 09 Mar 2017 11:57:50 -0500 Received: by mail-qk0-x229.google.com with SMTP id 1so128078994qkl.3 for ; Thu, 09 Mar 2017 08:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=xeNskJ+Pmp3xgaP2E+IEeJrNgbWXLT1X7tVyy6pDc20=; b=p09w/KDJsYaWIfD0hcrXEfUEg9sB0LlkuAqfy72x+zQAtCUPKhb4cdpYYgbPNXfw98 JERM2Y2RNpppPqgEc8EFvUTatytCBhivK6VYAzBVow8R07ZUUGb+AQLKVR8+H/65K3EC HuLz0syv1R8zWoVDBf0z7wDaDEhslJCXJs0cn+nLUxGNQ21GpNZDXy+R+2BZtTtKpaWd zzyrcltoz4rVNIyAK4/5bb0u4i+bKHMPzAK0gZgS43mllaIf81kt9oUWpndOGafLtuI/ 0RxpKCtA79k+jAuUR49ezLG6nGL481Za4/3+SymyGb0ot1KG1eQslTSttQdJETjeDugr QZaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=xeNskJ+Pmp3xgaP2E+IEeJrNgbWXLT1X7tVyy6pDc20=; b=Q5YAw+BdGhFuBsSVHenaumvA/5TqgzE1eTInTE1mfFaZDjarpznez+Lqr9y6pngqvm GWKMwjIDqs0/sG6k4j7VpiDp6Fu/AAbRi7NjHp1301u+ehYZ3KWQeKFmTi4etbLLeC6a ksebX9tjv+G70MYR4tZ52T8qzUv8e+BlqapXy32lfYu7EgyvHcxJ5GufFv0S2xcm25Vx T35M6kL5Rr694KjNjlS7Wjoh31cXDJoHNhGkuoP+ob8VcxGTn2hIO7OLvATIhg4/CGk5 Wz/rsCD9Li2UeA6czyKgCNFj+HWzXw4I1JQjIC9P7eME7wDU76Of9LI/jDVF0l0r7wrf sNRQ== X-Gm-Message-State: AMke39k6ERvci1HtSS1Yc07L7BE/9EQeiZQJybgDVcIe6/YZDZYyqV8TDw4wgf6qpeG/TZczaf5Ql1LAKYjrJg== X-Received: by 10.55.72.210 with SMTP id v201mr14613221qka.308.1489078666994; Thu, 09 Mar 2017 08:57:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.149.151 with HTTP; Thu, 9 Mar 2017 08:57:16 -0800 (PST) From: Evgeni Kolev Date: Thu, 9 Mar 2017 18:57:16 +0200 X-Google-Sender-Auth: jwXMh_6wAvTCx3PiFL2nUDE3ySM Message-ID: Content-Type: multipart/alternative; boundary=001a114a8baafd2909054a4f2461 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Thu, 09 Mar 2017 12:24:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a114a8baafd2909054a4f2461 Content-Type: text/plain; charset=UTF-8 perl 5.20 (released May 2014) added experimental support for subroutine signatures. So this is valid perl code: sub test ($param) { ... } However, perl-mode's syntax rules treat everything between ( and ) as punctuation (syntax class "."). As a result (thing-at-point 'word) doesn't return $param when the point is on $param because $param is considered punctuation. The patch below tries to address this by using syntax class "@" inside the parens. diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index a516f07..2b9d9ad 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -258,7 +258,7 @@ ;; Funny things in `sub' arg-specs like `sub myfun ($)' or `sub ($)'. ;; Be careful not to match "sub { (...) ... }". ("\\ c") In GNU Emacs 25.1.1 (x86_64-apple-darwin15.6.0) of 2017-01-21 built on evgeni-mba.local Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/25.1/share/info/emacs --prefix=/usr/local/Cellar/emacs/25.1 --without-x --with-xml2 --without-dbus --without-gnutls --without-ns' Configured features: JPEG NOTIFY ACL LIBXML2 ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 value of $LC_CTYPE: UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: aggressive-indent-mode: t beacon-mode: t yas-global-mode: t yas-minor-mode: t global-smart-tab-mode: t smart-tab-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-mode: t winner-mode: t ivy-mode: t which-key-mode: t shackle-mode: t ido-vertical-mode: t save-place-mode: t recentf-mode: t global-evil-visualstar-mode: t evil-visualstar-mode: t evil-commentary-mode: t global-evil-surround-mode: t evil-surround-mode: t global-undo-tree-mode: t undo-tree-mode: t evil-mode: t evil-local-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent messages: Loading package haskell-snippets...done Loading package uniquify... Configuring package uniquify...done Loading package uniquify...done Loading package beacon... Configuring package beacon...done Loading package beacon...done Loading /Users/edkolev/.emacs.d/init.el...done (1.320s) [after-init] Configuring package aggressive-indent...done Configuring package dired...done Load-path shadows: ~/dev/evil/evil hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil ~/dev/evil/evil-vars hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-vars ~/dev/evil/evil-types hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-types ~/dev/evil/evil-states hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-states ~/dev/evil/evil-search hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-search ~/dev/evil/evil-repeat hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-repeat ~/dev/evil/evil-pkg hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-pkg ~/dev/evil/evil-maps hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-maps ~/dev/evil/evil-macros hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-macros ~/dev/evil/evil-jumps hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-jumps ~/dev/evil/evil-integration hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-integration ~/dev/evil/evil-ex hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-ex ~/dev/evil/evil-digraphs hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-digraphs ~/dev/evil/evil-core hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-core ~/dev/evil/evil-common hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-common ~/dev/evil/evil-commands hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-commands ~/dev/evil/evil-command-window hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-command-window /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-xact hides /usr/local/share/emacs/site-lisp/ledger/ledger-xact /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-texi hides /usr/local/share/emacs/site-lisp/ledger/ledger-texi /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-test hides /usr/local/share/emacs/site-lisp/ledger/ledger-test /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-state hides /usr/local/share/emacs/site-lisp/ledger/ledger-state /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-sort hides /usr/local/share/emacs/site-lisp/ledger/ledger-sort /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-schedule hides /usr/local/share/emacs/site-lisp/ledger/ledger-schedule /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-report hides /usr/local/share/emacs/site-lisp/ledger/ledger-report /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-regex hides /usr/local/share/emacs/site-lisp/ledger/ledger-regex /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-reconcile hides /usr/local/share/emacs/site-lisp/ledger/ledger-reconcile /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-post hides /usr/local/share/emacs/site-lisp/ledger/ledger-post /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-occur hides /usr/local/share/emacs/site-lisp/ledger/ledger-occur /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-navigate hides /usr/local/share/emacs/site-lisp/ledger/ledger-navigate /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-mode hides /usr/local/share/emacs/site-lisp/ledger/ledger-mode /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-init hides /usr/local/share/emacs/site-lisp/ledger/ledger-init /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-fonts hides /usr/local/share/emacs/site-lisp/ledger/ledger-fonts /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-fontify hides /usr/local/share/emacs/site-lisp/ledger/ledger-fontify /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-exec hides /usr/local/share/emacs/site-lisp/ledger/ledger-exec /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-context hides /usr/local/share/emacs/site-lisp/ledger/ledger-context /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-complete hides /usr/local/share/emacs/site-lisp/ledger/ledger-complete /Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-commodities hides /usr/local/share/emacs/site-lisp/ledger/ledger-commodities /Users/edkolev/.emacs.d/elpa/seq-2.19/seq hides /usr/local/Cellar/emacs/25.1/share/emacs/25.1/lisp/emacs-lisp/seq Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec epg mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils colir color term/xterm xterm aggressive-indent beacon haskell-snippets yasnippet smart-tab smartparens-config smartparens dash s ucs-normalize winner whitespace ivy delsel ivy-overlay which-key shackle compile ido-vertical-mode ido saveplace evil-indent-plus recentf tree-widget wid-edit evil-visualstar evil-replace-with-register evil-exchange evil-commentary evil-commentary-integration evil-surround evil evil-integration undo-tree diff evil-maps evil-commands ffap url-parse auth-source eieio eieio-core gnus-util time-date mm-util help-fns mail-prsvr password-cache url-vars evil-jumps cl-seq evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core evil-common derived cl-macs windmove cl thingatpt rect evil-digraphs evil-vars hippie-exp comint regexp-opt ansi-color ring edmacro kmacro general spacemacs-light-theme spacemacs-common use-package diminish bind-key easy-mmode finder-inf advice info tool-bar package epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue multi-tty make-network-process emacs) Memory information: ((conses 16 452052 73574) (symbols 48 35184 3) (miscs 40 56 271) (strings 32 62447 49959) (string-bytes 1 1927618) (vectors 16 47695) (vector-slots 8 855243 19673) (floats 8 777 568) (intervals 56 270 16) (buffers 976 17)) --001a114a8baafd2909054a4f2461 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
perl 5.20 (released May 2014) added experimental= support for subroutine
signatures. So this is valid perl cod= e:

sub test ($param) {
=C2=A0 ...
<= div>}

However, perl-mode's syntax rules treat = everything between ( and ) as
punctuation (syntax class ".&q= uot;). As a result (thing-at-point 'word)
doesn't return = $param when the point is on $param because $param is
considered p= unctuation. The patch below tries to address this by
using syntax= class "@" inside the parens.


=
diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el=
index a516f07..2b9d9ad 100644
--- a/lisp/progmodes/per= l-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -258,7 += 258,7 @@
=C2=A0 =C2=A0 =C2=A0 =C2=A0;; Funny things in `sub' = arg-specs like `sub myfun ($)' or `sub ($)'.
=C2=A0 =C2= =A0 =C2=A0 =C2=A0;; Be careful not to match "sub { (...) ... }".<= /div>
=C2=A0 =C2=A0 =C2=A0 =C2=A0("\\<sub\\(?:[\s\t\n]+\\(?:\\s= w\\|\\s_\\)+\\)?[\s\t\n]*(\\([^)]+\\))"
- =C2=A0 =C2=A0 =C2= =A0 (1 "."))
+ =C2=A0 =C2=A0 =C2=A0 (1 "@"))<= /div>
=C2=A0 =C2=A0 =C2=A0 =C2=A0;; Turn __DATA__ trailer into a commen= t.
=C2=A0 =C2=A0 =C2=A0 =C2=A0("^\\(_\\)_\\(?:DATA\\|END\\)_= _[ \t]*\\(?:\\(\n\\)#.-\\*-.*perl.*-\\*-\\|\n.*\\)"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 (1 "< c") (2 "> c")






In GNU Emacs 25.1.1 (x86_64-apple-darwin15.6.0)
= =C2=A0of 2017-01-21 built on evgeni-mba.local
Configured using:
=C2=A0'configure --disable-dependency-tracking --disable-silen= t-rules
=C2=A0--enable-locallisppath=3D/usr/local/share/emacs/sit= e-lisp
=C2=A0--infodir=3D/usr/local/Cellar/emacs/25.1/share/info/= emacs
=C2=A0--prefix=3D/usr/local/Cellar/emacs/25.1 --without-x -= -with-xml2
=C2=A0--without-dbus --without-gnutls --without-ns'= ;

Configured features:
JPEG NOTIFY ACL L= IBXML2 ZLIB

Important settings:
=C2=A0 v= alue of $LC_ALL: en_US.UTF-8
=C2=A0 value of $LC_CTYPE: UTF-8
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 locale-coding-sy= stem: utf-8-unix

Major mode: Emacs-Lisp
=
Minor modes in effect:
=C2=A0 aggressive-indent-mo= de: t
=C2=A0 beacon-mode: t
=C2=A0 yas-global-mode: t
=C2=A0 yas-minor-mode: t
=C2=A0 global-smart-tab-mode: t=
=C2=A0 smart-tab-mode: t
=C2=A0 show-smartparens-globa= l-mode: t
=C2=A0 show-smartparens-mode: t
=C2=A0 smartp= arens-mode: t
=C2=A0 winner-mode: t
=C2=A0 ivy-mode: t<= /div>
=C2=A0 which-key-mode: t
=C2=A0 shackle-mode: t
=C2=A0 ido-vertical-mode: t
=C2=A0 save-place-mode: t
=C2=A0 recentf-mode: t
=C2=A0 global-evil-visualstar-mode: t
=C2=A0 evil-visualstar-mode: t
=C2=A0 evil-commentary-mod= e: t
=C2=A0 global-evil-surround-mode: t
=C2=A0 evil-su= rround-mode: t
=C2=A0 global-undo-tree-mode: t
=C2=A0 u= ndo-tree-mode: t
=C2=A0 evil-mode: t
=C2=A0 evil-local-= mode: t
=C2=A0 override-global-mode: t
=C2=A0 tooltip-m= ode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 electric-inde= nt-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 globa= l-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 aut= o-composition-mode: t
=C2=A0 auto-encryption-mode: t
= =C2=A0 auto-compression-mode: t
=C2=A0 line-number-mode: t
<= div>=C2=A0 transient-mark-mode: t
=C2=A0 abbrev-mode: t

Recent messages:
Loading package haskell-snippets= ...done
Loading package uniquify...
Configuring package= uniquify...done
Loading package uniquify...done
Loadin= g package beacon...
Configuring package beacon...done
L= oading package beacon...done
Loading /Users/edkolev/.emacs.d/init= .el...done (1.320s) [after-init]
Configuring package aggressive-i= ndent...done
Configuring package dired...done

Load-path shadows:
~/dev/evil/evil hides /Users/edkolev/.em= acs.d/elpa/evil-20170209.1259/evil
~/dev/evil/evil-vars hides /Us= ers/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-vars
~/dev/evil= /evil-types hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-type= s
~/dev/evil/evil-states hides /Users/edkolev/.emacs.d/elpa/evil-= 20170209.1259/evil-states
~/dev/evil/evil-search hides /Users/edk= olev/.emacs.d/elpa/evil-20170209.1259/evil-search
~/dev/evil/evil= -repeat hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-repeat
~/dev/evil/evil-pkg hides /Users/edkolev/.emacs.d/elpa/evil-201702= 09.1259/evil-pkg
~/dev/evil/evil-maps hides /Users/edkolev/.emacs= .d/elpa/evil-20170209.1259/evil-maps
~/dev/evil/evil-macros hides= /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-macros
~/de= v/evil/evil-jumps hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evi= l-jumps
~/dev/evil/evil-integration hides /Users/edkolev/.emacs.d= /elpa/evil-20170209.1259/evil-integration
~/dev/evil/evil-ex hide= s /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-ex
~/dev/e= vil/evil-digraphs hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evi= l-digraphs
~/dev/evil/evil-core hides /Users/edkolev/.emacs.d/elp= a/evil-20170209.1259/evil-core
~/dev/evil/evil-common hides /User= s/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-common
~/dev/evil= /evil-commands hides /Users/edkolev/.emacs.d/elpa/evil-20170209.1259/evil-c= ommands
~/dev/evil/evil-command-window hides /Users/edkolev/.emac= s.d/elpa/evil-20170209.1259/evil-command-window
/Users/edkolev/.e= macs.d/elpa/ledger-mode-20170208.425/ledger-xact hides /usr/local/share/ema= cs/site-lisp/ledger/ledger-xact
/Users/edkolev/.emacs.d/elpa/ledg= er-mode-20170208.425/ledger-texi hides /usr/local/share/emacs/site-lisp/led= ger/ledger-texi
/Users/edkolev/.emacs.d/elpa/ledger-mode-20170208= .425/ledger-test hides /usr/local/share/emacs/site-lisp/ledger/ledger-test<= /div>
/Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-stat= e hides /usr/local/share/emacs/site-lisp/ledger/ledger-state
/Use= rs/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-sort hides /usr/lo= cal/share/emacs/site-lisp/ledger/ledger-sort
/Users/edkolev/.emac= s.d/elpa/ledger-mode-20170208.425/ledger-schedule hides /usr/local/share/em= acs/site-lisp/ledger/ledger-schedule
/Users/edkolev/.emacs.d/elpa= /ledger-mode-20170208.425/ledger-report hides /usr/local/share/emacs/site-l= isp/ledger/ledger-report
/Users/edkolev/.emacs.d/elpa/ledger-mode= -20170208.425/ledger-regex hides /usr/local/share/emacs/site-lisp/ledger/le= dger-regex
/Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/= ledger-reconcile hides /usr/local/share/emacs/site-lisp/ledger/ledger-recon= cile
/Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger= -post hides /usr/local/share/emacs/site-lisp/ledger/ledger-post
/= Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-occur hides /us= r/local/share/emacs/site-lisp/ledger/ledger-occur
/Users/edkolev/= .emacs.d/elpa/ledger-mode-20170208.425/ledger-navigate hides /usr/local/sha= re/emacs/site-lisp/ledger/ledger-navigate
/Users/edkolev/.emacs.d= /elpa/ledger-mode-20170208.425/ledger-mode hides /usr/local/share/emacs/sit= e-lisp/ledger/ledger-mode
/Users/edkolev/.emacs.d/elpa/ledger-mod= e-20170208.425/ledger-init hides /usr/local/share/emacs/site-lisp/ledger/le= dger-init
/Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/l= edger-fonts hides /usr/local/share/emacs/site-lisp/ledger/ledger-fonts
/Users/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-fontify = hides /usr/local/share/emacs/site-lisp/ledger/ledger-fontify
/Use= rs/edkolev/.emacs.d/elpa/ledger-mode-20170208.425/ledger-exec hides /usr/lo= cal/share/emacs/site-lisp/ledger/ledger-exec
/Users/edkolev/.emac= s.d/elpa/ledger-mode-20170208.425/ledger-context hides /usr/local/share/ema= cs/site-lisp/ledger/ledger-context
/Users/edkolev/.emacs.d/elpa/l= edger-mode-20170208.425/ledger-complete hides /usr/local/share/emacs/site-l= isp/ledger/ledger-complete
/Users/edkolev/.emacs.d/elpa/ledger-mo= de-20170208.425/ledger-commodities hides /usr/local/share/emacs/site-lisp/l= edger/ledger-commodities
/Users/edkolev/.emacs.d/elpa/seq-2.19/se= q hides /usr/local/Cellar/emacs/25.1/share/emacs/25.1/lisp/emacs-lisp/seq

Features:
(shadow sort mail-extr emacsbug= message dired format-spec rfc822 mml
mml-sec epg mm-decode mm-bo= dies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader= sendmail rfc2047 rfc2045 ietf-drums mail-utils
colir color term/= xterm xterm aggressive-indent beacon haskell-snippets
yasnippet s= mart-tab smartparens-config smartparens dash s ucs-normalize
winn= er whitespace ivy delsel ivy-overlay which-key shackle compile
id= o-vertical-mode ido saveplace evil-indent-plus recentf tree-widget
wid-edit evil-visualstar evil-replace-with-register evil-exchange
evil-commentary evil-commentary-integration evil-surround evil
evil-integration undo-tree diff evil-maps evil-commands ffap url-parse
auth-source eieio eieio-core gnus-util time-date mm-util help-fns
mail-prsvr password-cache url-vars evil-jumps cl-seq evil-command-w= indow
evil-types evil-search evil-ex evil-macros evil-repeat evil= -states
evil-core evil-common derived cl-macs windmove cl thingat= pt rect
evil-digraphs evil-vars hippie-exp comint regexp-opt ansi= -color ring
edmacro kmacro general spacemacs-light-theme spacemac= s-common
use-package diminish bind-key easy-mmode finder-inf advi= ce info tool-bar
package epg-config seq byte-opt gv bytecomp byte= -compile cl-extra
help-mode easymenu cconv cl-loaddefs pcase cl-l= ib mule-util tooltip
eldoc electric uniquify ediff-hook vc-hooks = lisp-float-type
tabulated-list newcomment elisp-mode lisp-mode pr= og-mode register page
menu-bar rfn-eshadow timer select mouse jit= -lock font-lock syntax
facemenu font-core frame cl-generic cham g= eorgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao= korean japanese eucjp-ms cp51932
hebrew greek romanian slovak cz= ech european ethiopic indian cyrillic
chinese charscript case-tab= le epa-hook jka-cmpr-hook help simple abbrev
minibuffer cl-preloa= ded nadvice loaddefs button faces cus-face macroexp
files text-pr= operties overlay sha1 md5 base64 format env code-pages mule
custo= m widget hashtable-print-readable backquote kqueue multi-tty
make= -network-process emacs)

Memory information:
<= div>((conses 16 452052 73574)
=C2=A0(symbols 48 35184 3)
=C2=A0(miscs 40 56 271)
=C2=A0(strings 32 62447 49959)
=C2=A0(string-bytes 1 1927618)
=C2=A0(vectors 16 47695)
=C2=A0(vector-slots 8 855243 19673)
=C2=A0(floats 8 777 568)
=C2=A0(intervals 56 270 16)
=C2=A0(buffers 976 17))

--001a114a8baafd2909054a4f2461-- From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Mar 2017 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Evgeni Kolev Cc: 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.148924231323235 (code B ref 26037); Sat, 11 Mar 2017 14:26:02 +0000 Received: (at 26037) by debbugs.gnu.org; 11 Mar 2017 14:25:13 +0000 Received: from localhost ([127.0.0.1]:50414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmhxI-00062c-VM for submit@debbugs.gnu.org; Sat, 11 Mar 2017 09:25:13 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:34590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmhxG-00062J-2W; Sat, 11 Mar 2017 09:25:11 -0500 Received: by mail-io0-f194.google.com with SMTP id n76so9468092ioe.1; Sat, 11 Mar 2017 06:25:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bxYvvEQzE0biN2D+KDK6m9cIdCHBRS7K+VETsiUnmzA=; b=Zw0/Ephq/gh76qIGegASi2LO+eWKmFHvQa27S6TndofoGmfXjsP7qGd+bXZWhJGaeQ 6sWw3+ZoDqXE+icp5MNj49ULSFtlMDoH9Oscu0gtcsFY0pg7FIkyXe11sl1aYjkXZJvN nYUXQEnFVR2yKov3y0UYKVHLSSSsSkAwQCEk0mVA4BxMEOJD9pPX6irrvAKVOn3f9lH5 YkF+uPkJZPIdPxfFFRkjw8g0DTfiZfD1rO1kA3V0HCJNY+mnXGKeHy7OLfEhbXaRZb2r EOm2S0CK7kHEFWwdSzkB1szaIqbClzZw8ZXepSej7iLCKPvEqpWhLw7OoUXUFDWm6NR0 S2Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=bxYvvEQzE0biN2D+KDK6m9cIdCHBRS7K+VETsiUnmzA=; b=iLUpaWIuYB4/+kbVejmUYGXFBlLdxVYXnmTU1GhI5J4vv+W6aY6hz7MhepPh/cEZ6Q 0walzLccaTROHfaGvf7HBRQMX+8r8ieepf0Fl1q344GTR9o8cOsOzXGbX7V6R4XyMw9Q 8Fm1UmIsRhRtFHpvwdR5T24b/u6nWlcWeAkmPoCSZ6G5l2CsV3gQ8CAQ0wcSQmU3D8kI DVitkx9UBdcHpe4zi0fWCh9Eg9REnIMzB2Wp+/F46HDBkFRdLMZaZpqCOcFEGL3GP4kh MhB0YNt8+Zu0EO5lmZlFPK535xDzTa5coH5PTCGGN2faLwek2slHOu3hZu0Yf473BMae /cmw== X-Gm-Message-State: AMke39maS5mYoqWc2Pz1lPg7qyxLG+hoXbO2EpEqjkzw/9TbALJa7EowVI58P8+YVGfHWw== X-Received: by 10.107.3.170 with SMTP id e42mr19700677ioi.208.1489242304589; Sat, 11 Mar 2017 06:25:04 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p77sm5760907iod.4.2017.03.11.06.25.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Mar 2017 06:25:04 -0800 (PST) From: npostavs@users.sourceforge.net References: Date: Sat, 11 Mar 2017 09:26:21 -0500 In-Reply-To: (Evgeni Kolev's message of "Thu, 9 Mar 2017 18:57:16 +0200") Message-ID: <87bmt799f6.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.8 (/) severity 26037 wishlist quit Evgeni Kolev writes: > perl 5.20 (released May 2014) added experimental support for subroutine > signatures. So this is valid perl code: > > sub test ($param) { > ... > } > > However, perl-mode's syntax rules treat everything between ( and ) as > punctuation (syntax class "."). As a result (thing-at-point 'word) > doesn't return $param when the point is on $param because $param is > considered punctuation. The patch below tries to address this by > using syntax class "@" inside the parens. > > diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el > index a516f07..2b9d9ad 100644 > --- a/lisp/progmodes/perl-mode.el > +++ b/lisp/progmodes/perl-mode.el > @@ -258,7 +258,7 @@ > ;; Funny things in `sub' arg-specs like `sub myfun ($)' or `sub ($)'. > ;; Be careful not to match "sub { (...) ... }". > ("\\ - (1 ".")) > + (1 "@")) Don't we still want 'sub ($)' and such to be marked with punctuation syntax? From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures References: In-Reply-To: Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Mar 2017 02:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Evgeni Kolev , 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.14895436511197 (code B ref 26037); Wed, 15 Mar 2017 02:08:02 +0000 Received: (at 26037) by debbugs.gnu.org; 15 Mar 2017 02:07:31 +0000 Received: from localhost ([127.0.0.1]:56181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnyLb-0000JF-Hb for submit@debbugs.gnu.org; Tue, 14 Mar 2017 22:07:31 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:36111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnyLZ-0000J1-Q5 for 26037@debbugs.gnu.org; Tue, 14 Mar 2017 22:07:30 -0400 Received: by mail-io0-f170.google.com with SMTP id l7so11600703ioe.3 for <26037@debbugs.gnu.org>; Tue, 14 Mar 2017 19:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=lAg0N18gpj0Ui0y9uTsUt2+mnIRdIBkq4vZHzWHau1o=; b=WyBuE/uyaZ4hts7wWlDzHzsotMyScjC3NezqR3pZykJ1Y3bq3lshfCdXxq9HvxKk0s B8hU9TFXKLtDdJfdp8Y5uTUoJDV5O8/Glq9ZtPs/l0cvZo0WpXTE3LGHvUKME2tiJ9wJ U6EViIFpt4+Xg7MQ58/DC1KT3jkL/pLXH065W6TX1roEqw+dZx7J2YQE2qDthVcYqSsJ XyWYxRGb3cPdRnv+FpA+BDhi+P9dssTcP54fc1xofmLGOaoXsCIDJqtf1LiTcV172FXb IW96y225M96NcILLG+wnXeETfPEB/mgfPjKS6ega495HCOyPclvGIDwOuJSV7Cm7Ed/G WEmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=lAg0N18gpj0Ui0y9uTsUt2+mnIRdIBkq4vZHzWHau1o=; b=CZ/z1wo5l/yruVPOD4KcG1My35tcQ5B3bdCok40HqbuCYwLCk1ZSQi1KgnKoP1Kxlh mP29r6SwpC7h+VuYudF6gi1QwrNBMLRBS91bZDDcqN8Qejaa73KWrOZXUNb5hkdKN2Zw CkemE2ICCEtd7QZmj7NDxmpgKH0T3GkPD6msDO3996YRBihHtPOlnyKum8t6pSw/a15h IP8ZGxxM4kvzvR/OhcJDTQPDgtlaPetqFPXKIQjb9CsjgkJ3n4ztuzY6E7tg+U9AO3Vm mZMMioBVr0M8zsvwgCdTVA3doQO2/t3ouWDBxDiHOV09MhSAqhjQaM7FWWPA8BmNY90O jV7A== X-Gm-Message-State: AFeK/H213JV+KTD8+p7lgF4HHk8au6x3EXwQ+nk5AJdF5l5v73BVgFwi6RZ0k/S8yFZNvQ== X-Received: by 10.107.128.17 with SMTP id b17mr3010220iod.25.1489543644229; Tue, 14 Mar 2017 19:07:24 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 198sm843426ioz.59.2017.03.14.19.07.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Mar 2017 19:07:23 -0700 (PDT) From: npostavs@users.sourceforge.net Date: Tue, 14 Mar 2017 22:08:41 -0400 Message-ID: <87k27r5m1i.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain [Please keep 26037@debbugs.gnu.org on CC] --=-=-= Content-Type: message/rfc822 Content-Disposition: inline Sender: evgenysw@gmail.com Received: by 10.12.149.151 with HTTP; Tue, 14 Mar 2017 05:14:58 -0700 (PDT) In-Reply-To: <87bmt799f6.fsf@users.sourceforge.net> References: <87bmt799f6.fsf@users.sourceforge.net> From: Evgeni Kolev Date: Tue, 14 Mar 2017 14:14:58 +0200 X-Google-Sender-Auth: 8YmUmNXTptxerBXeOpNGJsKqUrI Message-ID: Subject: Re: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures To: npostavs@users.sourceforge.net X-Spam-Score: -0.1 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.216.174 listed in list.dnswl.org] -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (evgenysw[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 1.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.216.174 listed in dnsbl.sorbs.net] X-Headers-End: 1cnlMU-0008Kj-Ef MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="====-=-=" --====-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi, thanks for your reply! The '$' inside 'sub ($)' should be treated as punctuation (or symbol, sorry, I'm not 100% sure, see below) due to the "@" syntax class - if I'm not mistaken, "@" will let the syntax "fall-through" to the standard syntax table; the standard syntax table, in turn, should define '$' and other perl sigils as punctuation. However, I'm not sure how to verify that the '$' in 'sub ($)' is punctuation or symbol. I'm using this document for reference to syntax classes: https://www.gnu.org/software/emacs/manual/html_node/elisp/Syntax-Class-Table.html --====-=-=-- --=-=-= Content-Type: text/plain I believe the standard syntax table is fundamental mode's syntax table, not perl's. Otherwise you might as well just delete the entry entirely. You can check any character's current syntax by moving point to it, and doing C-u C-x =. --=-=-=-- From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures References: In-Reply-To: Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Mar 2017 00:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 26037@debbugs.gnu.org Cc: evgenysw@gmail.com Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.148962529121279 (code B ref 26037); Thu, 16 Mar 2017 00:49:01 +0000 Received: (at 26037) by debbugs.gnu.org; 16 Mar 2017 00:48:11 +0000 Received: from localhost ([127.0.0.1]:57720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coJaN-0005X9-0L for submit@debbugs.gnu.org; Wed, 15 Mar 2017 20:48:11 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:34635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coJaL-0005Wv-2X for 26037@debbugs.gnu.org; Wed, 15 Mar 2017 20:48:09 -0400 Received: by mail-io0-f169.google.com with SMTP id b140so32245145iof.1 for <26037@debbugs.gnu.org>; Wed, 15 Mar 2017 17:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version; bh=Z+rg6D/skEO8D3lOzpuuImePqcbBzMZf43pHVgJT5i0=; b=bZH+oHec/mDVnlHHJ0Fb+/6DQuMPVrBlRO4iAeYCQO3f/PQWtArTi2WK5IVqWf/rvZ gL/z0lGFrG7yc/NKk1qKVNYWn70PIzyL/KiLezV9PI7ZY6Owa7684DtteolIlBsg+eTX oZc8S1bkYQJNdLbZqOqnzjobcocffxFN4tE4FMMjXcQYZ10xm05xsYqul9fcxeARkEMo LNhGWCfGRVT0MT8QDeBGXQWnflxIsKOnGt/XM03OMT3i2gNOvtTMQRX7g0Gp8XTlVC5V tMEt08YzOB58yRxbS7UlEbujTCjs0d3Opi7kangmvjMP4ay/Cu5k60u12OAOUJp06Yot PJHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version; bh=Z+rg6D/skEO8D3lOzpuuImePqcbBzMZf43pHVgJT5i0=; b=SttBh6JZZptw8M3/ifA9nFEtDuAQo6s++u2BRVULn2sX5iPyc+8GI/a4sp2vQ8STui gGnG0i81qJbDzD41SHUz8lvtxMgWonEs1jLP63+QiLFwBwHxTPlGyn0CIa/JV7mHunvV FB4dO/VQ15KtKO8jkTFUP8xrRa118+uq99AL98r1D02OU8i8uvB0sny4Lkv/K+fID9XR /SiRJs1vz40uUjVctmaTddBOdtAFH9Ue13fao4oBKiKk7aTZ24N2uZmi4y6a1gv+EvWu GsWMtWqfSQ291VnaMOoZKfuvXUruQuzaOwaEsIlf/UrN1An62RHN2EUB4XA5Kzev3UXu Qz9g== X-Gm-Message-State: AFeK/H2YgQ/3b6zzgye3Yd0v98ocYooDNrgjGkq2nxigGOekbDtO4idKehccNm9E1iJZhg== X-Received: by 10.107.180.145 with SMTP id d139mr8170975iof.101.1489625283434; Wed, 15 Mar 2017 17:48:03 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id f196sm307473itc.2.2017.03.15.17.48.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Mar 2017 17:48:02 -0700 (PDT) From: npostavs@users.sourceforge.net Date: Wed, 15 Mar 2017 20:49:21 -0400 Message-ID: <87bmt259m6.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain [Please use Reply All to keep 26037@debbugs.gnu.org on CC] --=-=-= Content-Type: message/rfc822 Content-Disposition: inline Sender: evgenysw@gmail.com Received: by 10.25.157.82 with HTTP; Wed, 15 Mar 2017 03:00:32 -0700 (PDT) In-Reply-To: <87k27r5m1i.fsf@users.sourceforge.net> References: <87k27r5m1i.fsf@users.sourceforge.net> From: Evgeni Kolev Date: Wed, 15 Mar 2017 12:00:32 +0200 X-Google-Sender-Auth: 2FgKjsy98sxtsnj7vXkCQs33HjE Message-ID: Subject: Re: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures To: npostavs@users.sourceforge.net X-Spam-Score: -0.3 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (evgenysw[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.46 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.2 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1co5jx-0002ob-Bt MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="====-=-=" --====-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline OK, I see. After a bit of testing with C-u C-x =, I see that with my proposed change the sigils in 'sub test ($)' will *not* have punctuation class as they did before the chagne. I see these options: 1. I can try to improve the proposed change to preserve backward compatibility - I can try to add another rule which will strictly match only the allowed prototype-sigils $%&*;@[\] 2. discard my proposed change as it might have undesired side effects - at this point, I don't see anything in perl-mode which depends on these prototype-sigils having punctioation class, however, I could be missing something. 3. accept my proposed change as-is, but we must be sure nothing will be broken as a result. I'm sure syntax highlighting will not be broken (I've tested with different themes, different perl sub definitions). Please let me know what you think. --====-=-=-- --=-=-= Content-Type: text/plain I ran git blame against the relevant lines, and turned up Bug#18502. Please check if your change breaks the indentation test case at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=18502#5. --=-=-=-- From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2017 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: npostavs@users.sourceforge.net Cc: 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.14898522576350 (code B ref 26037); Sat, 18 Mar 2017 15:51:02 +0000 Received: (at 26037) by debbugs.gnu.org; 18 Mar 2017 15:50:57 +0000 Received: from localhost ([127.0.0.1]:34094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpGd7-0001eM-1H for submit@debbugs.gnu.org; Sat, 18 Mar 2017 11:50:57 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:34237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpFHq-0006AF-NX for 26037@debbugs.gnu.org; Sat, 18 Mar 2017 10:24:55 -0400 Received: by mail-lf0-f45.google.com with SMTP id z15so42304162lfd.1 for <26037@debbugs.gnu.org>; Sat, 18 Mar 2017 07:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GvfRacd9DC4HsK6GB6zYwsEU7bNpV9ll9D8ji6mT6rw=; b=mdBfuqTPqJcukWHX68gC6YWAgQo3kytaRknzK/3UvTPjncdF8ZtbGMnomnzJ3ECGey x8v1N05tMMmp9tTXZUdbNTjupdfiiL3yTSAucCge2CAaNXFbyhKfR+xYgAIb5k/O1WTA BCWgxzlxWHzMTQsg0Us2sifQbuNDoDoSyhOPmArzyhKAZGg8HNMWIkWMRrXUBevZRoBk e7pp+js9ZTRfy0I8MNJxHZ85uQDJpfTcY8LoxVobB+yBDuWziuO/STZRga01MYcvo095 G6oR13+7LNUTkEK1OL7Y/c5YOtXsPa5IvJAocXbvTDqKbFptk/N+KJf/8IIxlRo85oU2 eHlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GvfRacd9DC4HsK6GB6zYwsEU7bNpV9ll9D8ji6mT6rw=; b=YVoM1uXbw2nt7BqJJLNJrx7BTPubHU12LDUmAXOAXxuf04g/CETIcXKo1SRJCRC0eE WUNK1zDOZka4d5KosD7j64F5J13MlErF+fzhPWRB318W99A8PgRC7WrNvkrbR9Y6FCDB x9G50uIoBUJ+yAgz14o0WOPAeV13umxHOQcF5/P4/nPilv9/ct5jbVmQlmkk+WO67j5O l0fZ+xIp9a1yvD5RjTw7xE3HpN772+V6r8fRonsDed4t65w5YIArfjXkJTZ+2JXBdwkZ PPs7rORfxOeP8KxKei468+HshFO/barInGJvzXnYNoo9pGfYURYU7xQ6Fid7XYWPtvZ+ A7ww== X-Gm-Message-State: AFeK/H15iLkV3mb6zqhoHJEZQeCQK5N7ewlQM0XADOeYxjehn6dfOaiyvnQug6QD5RJu+zl9U2OZQibRRx6n4g== X-Received: by 10.46.88.79 with SMTP id x15mr6598418ljd.39.1489847088563; Sat, 18 Mar 2017 07:24:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.157.82 with HTTP; Sat, 18 Mar 2017 07:24:18 -0700 (PDT) In-Reply-To: <87bmt259m6.fsf@users.sourceforge.net> References: <87bmt259m6.fsf@users.sourceforge.net> From: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Date: Sat, 18 Mar 2017 16:24:18 +0200 Message-ID: Content-Type: multipart/alternative; boundary=f40304387f4c7bcb70054b020e64 X-Spam-Score: -0.0 (/) X-Mailman-Approved-At: Sat, 18 Mar 2017 11:50:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --f40304387f4c7bcb70054b020e64 Content-Type: text/plain; charset=UTF-8 Yes, my change does break the indentation test case. So changing the class doesn't seem like a good option. After giving some thought to this, I think we can instead make the regex more strict so that it matches only the allowed characters in perl's prototypes. The allowed chars are: $%&*;@[\] This is what I have in mind - diff is pasted below. However, please note the change below doesn't handle these 3 chars [ / ] I'll add them if you think this is the correct approach: diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index a516f07..840aa4e 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -257,7 +257,7 @@ (1 (prog1 "\"" (perl-syntax-propertize-special-constructs end)))) ;; Funny things in `sub' arg-specs like `sub myfun ($)' or `sub ($)'. ;; Be careful not to match "sub { (...) ... }". - ("\\ wrote: > [Please use Reply All to keep 26037@debbugs.gnu.org on CC] > > > > ---------- Forwarded message ---------- > From: Evgeni Kolev > To: npostavs@users.sourceforge.net > Cc: > Bcc: > Date: Wed, 15 Mar 2017 12:00:32 +0200 > Subject: Re: bug#26037: 25.1; perl-mode add syntax support for subroutine > signatures > OK, I see. > > After a bit of testing with C-u C-x =, I see that with my proposed > change the sigils in 'sub test ($)' will *not* have punctuation class > as they did before the chagne. > > I see these options: > > 1. I can try to improve the proposed change to preserve backward > compatibility - I can try to add another rule which will strictly > match only the allowed prototype-sigils $%&*;@[\] > > 2. discard my proposed change as it might have undesired side effects - > at this point, I don't see anything in perl-mode which depends on > these prototype-sigils having punctioation class, however, I could be > missing something. > > 3. accept my proposed change as-is, but we must be sure nothing will > be broken as a result. I'm sure syntax highlighting will not be > broken (I've tested with different themes, different perl sub > definitions). > > Please let me know what you think. > > > > I ran git blame against the relevant lines, and turned up Bug#18502. > Please check if your change breaks the indentation test case at > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=18502#5. > > --f40304387f4c7bcb70054b020e64 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Yes, my change does break the indentation test case.<= /div>
So changing the class doesn't seem like a good option.
<= div>
After giving some thought to this, I think we can instea= d
make the regex more strict so that it matches only the
allowed characters in perl's prototypes. The allowed chars
= are:=C2=A0$%&*;@[\]

This is what I have in min= d - diff is pasted below.
However, please note the change below d= oesn't handle
these 3 chars [ / ] =C2=A0I'll add them if = you think this is the correct
approach:

=
diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el=
index a516f07..840aa4e 100644
--- a/lisp/progmodes/per= l-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -257,7 += 257,7 @@
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (1 (prog1 "\""= ; (perl-syntax-propertize-special-constructs end))))
=C2=A0 =C2= =A0 =C2=A0 =C2=A0;; Funny things in `sub' arg-specs like `sub myfun ($)= ' or `sub ($)'.
=C2=A0 =C2=A0 =C2=A0 =C2=A0;; Be careful = not to match "sub { (...) ... }".
- =C2=A0 =C2=A0 =C2= =A0("\\<sub\\(?:[\s\t\n]+\\(?:\\sw\\|\\s_\\)+\\)?[\s\t\n]*(\\([^)]+= \\))"
+ =C2=A0 =C2=A0 =C2=A0("\\<sub\\(?:[\s\t\n]+\\= (?:\\sw\\|\\s_\\)+\\)?[\s\t\n]*(\\([$%&*;@]+\\))"
=C2=A0= =C2=A0 =C2=A0 =C2=A0 (1 "."))
=C2=A0 =C2=A0 =C2=A0 =C2= =A0;; Turn __DATA__ trailer into a comment.
=C2=A0 =C2=A0 =C2=A0 = =C2=A0("^\\(_\\)_\\(?:DATA\\|END\\)__[ \t]*\\(?:\\(\n\\)#.-\\*-.*perl.= *-\\*-\\|\n.*\\)"

On Thu, Mar 16, 2017 at 2:49 AM, = <npo= stavs@users.sourceforge.net> wrote:
[Please use Reply All to keep 26037@debbugs.gnu.org on CC]



---------- Forwarded message ----------
From:=C2=A0Evgeni Kolev = <evgeni.d.kolev@gmail.com>
To:=C2=A0npostav= s@users.sourceforge.net
Cc:=C2=A0
Bcc:=C2=A0
Date:=C2=A0Wed, 1= 5 Mar 2017 12:00:32 +0200
Subject:=C2=A0Re: bug#26037: 25.1; perl-mode a= dd syntax support for subroutine signatures
OK, I see.

After a bit of testing with C-u C-x =3D, I see that with my proposed
change the sigils in 'sub test ($)' will *not* have punctuation cla= ss
as they did before the chagne.

I see these options:

1. I can try to improve the proposed change to preserve backward
compatibility - I can try to add another rule which will strictly
match only the allowed prototype-sigils $%&*;@[\]

2. discard my proposed change as it might have undesired side effects -
at this point, I don't see anything in perl-mode which depends on
these prototype-sigils having punctioation class, however, I could be
missing something.

3. accept my proposed change as-is, but we must be sure nothing will
be broken as a result.=C2=A0 I'm sure syntax highlighting will not be broken (I've tested with different themes, different perl sub
definitions).

Please let me know what you think.



I ran git blame against the relevant lines, and turned up Bug#18502.
Please check if your change breaks the indentation test case at
https://debbugs.gnu.org/cgi/bugreport.cg= i?bug=3D18502#5.


--f40304387f4c7bcb70054b020e64-- From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2017 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Cc: 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.14898526547188 (code B ref 26037); Sat, 18 Mar 2017 15:58:02 +0000 Received: (at 26037) by debbugs.gnu.org; 18 Mar 2017 15:57:34 +0000 Received: from localhost ([127.0.0.1]:34123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpGjW-0001rs-KL for submit@debbugs.gnu.org; Sat, 18 Mar 2017 11:57:34 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:37880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpGjU-0001rf-EX for 26037@debbugs.gnu.org; Sat, 18 Mar 2017 11:57:32 -0400 Received: by mail-it0-f42.google.com with SMTP id g138so56949889itb.0 for <26037@debbugs.gnu.org>; Sat, 18 Mar 2017 08:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=FsOonmjegpgo+w3ZMnmggYU2R/SUylmTjuVOWm/pt4I=; b=aFi8VIvolXdAJfO6rDL3ilaIkz9YYlo0gPTJVDDuvqNJPWY2FXhWs38nj5mk2vsclf H8SrB1a+jPiPBGiBGYxQcqsaMQE9tTACcZcaHUIzePnBGZ9RXFa5Vzcqh87/F88PeA2v mqP5y6G8M5BhIoTBQ2LAt9EfUkhna7CUwxoLf8/LkTGQZ9MAqvmBueaTZTkR00F8aMfb iMjszB5K+Czz/Hxb1xo52DEzTUZM4/j1/++RwzvXGfRic94YGkMbnzMOvS5zOtlimxvg MI2yqLcXXIeuP/8g32/u4tFF6wTRI1+ZwqBWMY3GIZrSBJluUJ+5d7v8ncMPLXQtSXP2 wBMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=FsOonmjegpgo+w3ZMnmggYU2R/SUylmTjuVOWm/pt4I=; b=KumOoPWufR7O1arNBzSH3/fFLVkuDqy4+oGp+Ecz12jrFezr725fVOH/RnqC8ESmo4 5Vh0xifo67yrzxH4RWHOc0AoK12/ULUM8f+aAKBhD8blxHYNmasejmuR2i/P+fJckoBF dp/L+jqm/Qm34NpLmbOuJT9ftXprIquX6WdLGyefCZq+S6caF4tBHTN/qbZvkx3sOtO2 Xbdp7SU/Kbg6NK9hnfWFPrr6YuxGp4/fVaW9i2oXQIAvvbUaNzPRKAanbeP0rbk7bVO2 /N3DonfrwPxjdf4qG3kjJRvIU+JJx1RWForH0RwuGyMHGmFBNttMJ16V5mTznlTt15Hc mjhg== X-Gm-Message-State: AFeK/H3mjAFoSLKpQ6xBCHSsdjHu2w30Cfdp2AFDRIEzxAkOryMaGiGhmsXfJEzgRKp1Gg== X-Received: by 10.107.56.11 with SMTP id f11mr19608370ioa.131.1489852646817; Sat, 18 Mar 2017 08:57:26 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e20sm4197239itc.3.2017.03.18.08.57.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Mar 2017 08:57:26 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87bmt259m6.fsf@users.sourceforge.net> Date: Sat, 18 Mar 2017 11:58:46 -0400 In-Reply-To: ("=?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?="'s message of "Sat, 18 Mar 2017 16:24:18 +0200") Message-ID: <87o9wy4lvt.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8 =D0=9A=D0=BE=D0=BB=D0=B5=D0=B2 writes: > > After giving some thought to this, I think we can instead > make the regex more strict so that it matches only the > allowed characters in perl's prototypes. The allowed chars > are: $%&*;@[\] > > This is what I have in mind - diff is pasted below. > However, please note the change below doesn't handle > these 3 chars [ / ] I'll add them if you think this is the correct > approach: Yeah, that looks right to me (although I don't know perl very well). From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2017 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: npostavs@users.sourceforge.net Cc: 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.149054993813165 (code B ref 26037); Sun, 26 Mar 2017 17:39:02 +0000 Received: (at 26037) by debbugs.gnu.org; 26 Mar 2017 17:38:58 +0000 Received: from localhost ([127.0.0.1]:46127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csC82-0003QH-72 for submit@debbugs.gnu.org; Sun, 26 Mar 2017 13:38:58 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:33930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csBzs-0003EF-GR for 26037@debbugs.gnu.org; Sun, 26 Mar 2017 13:30:33 -0400 Received: by mail-lf0-f45.google.com with SMTP id z15so11234281lfd.1 for <26037@debbugs.gnu.org>; Sun, 26 Mar 2017 10:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IWIBnRH82fH5D4hnY3rLGzkdAsGEIt+35HNZMO7fyMA=; b=R36f1Xdm9B4qc0pz4uAaxMYNbkvxfmWxKXlYkkDl7jHzeKpsCpyYdhZnTDRFsYyIKe /qXV0nE0gDec7MigKjFRAfBTtYtrp24grdHywbq1wDlqPJkDhuu1r8MhZ7WvHOGQYXWG O+IdEn97uao6rbqt0g3VcULPa6EZMOJxGEu+OIfkfEHysG04e3uSBRJqxE279Gx3STAN cNPEc4NzNKp+MnlktiykzEvjqnRrKIb8Wg1MWbQ7jOiQB5OLIS06PObjuADVMBzalQq2 VuEZrJ+ydEpK+K6GGyzz1jYvOB/SCLX3bLYQt9U+TJRyaehOpsIb4x0Scgj/nX7LzbcC sqKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IWIBnRH82fH5D4hnY3rLGzkdAsGEIt+35HNZMO7fyMA=; b=Y6fO8PRh0zcK7Ky5tOHpzspnY24lyeFjG1rQOd3pc3knoF55xzg70WeBg/HIN6JVCw v2AVLyfbLYGtkM4k3xagTSurGCc0Y/N6mU99wdOskXWy9H5U4tqFzu6vX8evlEWD1xis 0Dy0CLArfGdDP8qmouqHl61uaQfrqK7TCGBRchwopXJjA1UGkD0bEGGGZfCMImgFCwv9 bi8aue6P2068SjbZdYtFqzYL4b9ChCDVYTTZ1UnEagQ/yjvbdqCUTM0zVIy6qRpJ0Bj9 crnew3btvWa83K1VMhdh7JHjUrzGL6M6iQgc3ZNRxM/0Ag11uW3j39J5NKVDke5HG+dU 3veQ== X-Gm-Message-State: AFeK/H3J7OM6T+ouWtDMgI7EBMTdyjB4m7dlH5eOmBKI+FINlpAq3W386ZpUG4ddoAkibvBLUV9Z4G0wzT5blQ== X-Received: by 10.25.80.1 with SMTP id e1mr9041110lfb.82.1490549426294; Sun, 26 Mar 2017 10:30:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.157.82 with HTTP; Sun, 26 Mar 2017 10:29:55 -0700 (PDT) In-Reply-To: <87o9wy4lvt.fsf@users.sourceforge.net> References: <87bmt259m6.fsf@users.sourceforge.net> <87o9wy4lvt.fsf@users.sourceforge.net> From: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Date: Sun, 26 Mar 2017 20:29:55 +0300 Message-ID: Content-Type: multipart/alternative; boundary=94eb2c1cc6aa131646054ba595fc X-Spam-Score: -0.0 (/) X-Mailman-Approved-At: Sun, 26 Mar 2017 13:38:57 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --94eb2c1cc6aa131646054ba595fc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The regex is now updated to include all the chars $%&*;@[\] I got the list of chars from here http://perldoc.perl.org/perlsub.html#Prototypes This is the diff, please let me if it can be improved: diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index a516f07..43eb462 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -257,7 +257,7 @@ (1 (prog1 "\"" (perl-syntax-propertize-special-constructs end)))) ;; Funny things in `sub' arg-specs like `sub myfun ($)' or `sub ($)'= . ;; Be careful not to match "sub { (...) ... }". - ("\\ wrote: > =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8 =D0=9A=D0=BE=D0=BB=D0=B5=D0=B2 writes: > > > > > After giving some thought to this, I think we can instead > > make the regex more strict so that it matches only the > > allowed characters in perl's prototypes. The allowed chars > > are: $%&*;@[\] > > > > This is what I have in mind - diff is pasted below. > > However, please note the change below doesn't handle > > these 3 chars [ / ] I'll add them if you think this is the correct > > approach: > > Yeah, that looks right to me (although I don't know perl very well). > --94eb2c1cc6aa131646054ba595fc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
The regex is now updated to include all the char= s $%&*;@[\]

I got the list of chars from= here

This is the diff, please let me if it can be improved:

diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode= .el
index a516f07..43eb462 100644
--- a/lisp/progmodes/= perl-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -257,= 7 +257,7 @@
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (1 (prog1 "\"&q= uot; (perl-syntax-propertize-special-constructs end))))
=C2=A0 = =C2=A0 =C2=A0 =C2=A0;; Funny things in `sub' arg-specs like `sub myfun = ($)' or `sub ($)'.
=C2=A0 =C2=A0 =C2=A0 =C2=A0;; Be caref= ul not to match "sub { (...) ... }".
- =C2=A0 =C2=A0 = =C2=A0("\\<sub\\(?:[\s\t\n]+\\(?:\\sw\\|\\s_\\)+\\)?[\s\t\n]*(\\([^= )]+\\))"
+ =C2=A0 =C2=A0 =C2=A0("\\<sub\\(?:[\s\t\n]= +\\(?:\\sw\\|\\s_\\)+\\)?[\s\t\n]*(\\([][$%&*;@\\]+\\))"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (1 "."))
=C2=A0 =C2=A0 =C2= =A0 =C2=A0;; Turn __DATA__ trailer into a comment.
=C2=A0 =C2=A0 = =C2=A0 =C2=A0("^\\(_\\)_\\(?:DATA\\|END\\)__[ \t]*\\(?:\\(\n\\)#.-\\*-= .*perl.*-\\*-\\|\n.*\\)"

On Sat, Mar 18, 2017 at 5:58 PM, <np= ostavs@users.sourceforge.net> wrote:
=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8 =D0=9A=D0= =BE=D0=BB=D0=B5=D0=B2 <evgenysw@gm= ail.com> writes:

>
> After giving some thought to this, I think we can instead
> make the regex more strict so that it matches only the
> allowed characters in perl's prototypes. The allowed chars
> are: $%&*;@[\]
>
> This is what I have in mind - diff is pasted below.
> However, please note the change below doesn't handle
> these 3 chars [ / ]=C2=A0 I'll add them if you think this is the c= orrect
> approach:

Yeah, that looks right to me (although I don't know perl very we= ll).

--94eb2c1cc6aa131646054ba595fc-- From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2017 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Cc: 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.149055141315487 (code B ref 26037); Sun, 26 Mar 2017 18:04:02 +0000 Received: (at 26037) by debbugs.gnu.org; 26 Mar 2017 18:03:33 +0000 Received: from localhost ([127.0.0.1]:46143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csCVo-00041i-PI for submit@debbugs.gnu.org; Sun, 26 Mar 2017 14:03:32 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:38842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csCVm-00041V-Cp for 26037@debbugs.gnu.org; Sun, 26 Mar 2017 14:03:31 -0400 Received: by mail-it0-f53.google.com with SMTP id y18so32031356itc.1 for <26037@debbugs.gnu.org>; Sun, 26 Mar 2017 11:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=A0H3qwD6cA7afVbSC2VoFBTjCLjQCqtR62qPQ07vOqw=; b=tfMfQlULS8vaFYMkiK/mlBNi2HrX36jEOH8TCKLK85vKP94mzljXWZrFzRUfVcTUm1 PmXAUUNHSJVqXjYH763IdvE0ehSNCiy7M1MD3ALYJa6zXoxrglYTO3WelHcTG3yS0epH K8MdTpE0EgcTPwVtgDL14CFWCCV9lKVkfD7j2RZEcgSwaeRaHoSqfvcEBSC5WvmQR76t 9MbS6MCqP6UeyazBfalqw03I2wNPoss+yJvBiVHF8oa2vAAMrsi/6GJaLdKnUEsYDpwE KH6Lhh9qI+WXAI5tKI7zcVgzfiZguvsvxOebwUkUl6u2EYnRAgyKNYFuZ76TcdlkAovc qeDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=A0H3qwD6cA7afVbSC2VoFBTjCLjQCqtR62qPQ07vOqw=; b=YICFiknFhqpGIjjoZbEd1TTNq0qfPm0THjg8vXcqUuYUlxU6qNIQNhmOhHGXFarVUn 4irLZGromItqeHKmubxS8s0HP167fyRkLP3sod6Hk00VjJUG0tZofl+zYCEeBBd02gIM n9IAo1Eo78eMVL6GtJMIkc/O7Ru2zU57o54Z3BUOghX2pneVSU/htonUTQnlBxYlW6Lt vxZec7maN6BG+GJusfnkelwPgbk7HYpuLMV4AwfILmNDhqjEH9T1iRhSgtWAysve5OGp fyTsIycsV/N/WiRsm/5vCsZYNLYsy8g4rMLobK+hkg4BNILmXFU4ZPHebODX3KysQgdg 1g5A== X-Gm-Message-State: AFeK/H1jgKKJOhYOll6IH9crV+ytEUvhipQHDpxrOsJB58SsBo1D63CbzpqCbESh3PUpLw== X-Received: by 10.36.122.209 with SMTP id a200mr6160165itc.9.1490551404865; Sun, 26 Mar 2017 11:03:24 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id z20sm4434153ioz.23.2017.03.26.11.03.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 26 Mar 2017 11:03:24 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87bmt259m6.fsf@users.sourceforge.net> <87o9wy4lvt.fsf@users.sourceforge.net> Date: Sun, 26 Mar 2017 14:04:45 -0400 In-Reply-To: ("=?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?="'s message of "Sun, 26 Mar 2017 20:29:55 +0300") Message-ID: <87d1d352yq.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8 =D0=9A=D0=BE=D0=BB=D0=B5=D0=B2 writes: > The regex is now updated to include all the chars $%&*;@[\] > > I got the list of chars from here > http://perldoc.perl.org/perlsub.html#Prototypes It looks like "+" is another possible character: The + prototype is a special alternative to $ that will act like \[@%] when given a literal array or hash variable, but will otherwise force scalar context on the argument. This is useful for functions which should accept either a literal array or an array reference as the argument: sub mypush (+@) { > > This is the diff, please let me if it can be improved: > > ;; Funny things in `sub' arg-specs like `sub myfun ($)' or `sub ($)'. > ;; Be careful not to match "sub { (...) ... }". > - ("\\ + ("\\ In-Reply-To: Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2017 03:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 26037@debbugs.gnu.org Cc: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.149067200822917 (code B ref 26037); Tue, 28 Mar 2017 03:34:01 +0000 Received: (at 26037) by debbugs.gnu.org; 28 Mar 2017 03:33:28 +0000 Received: from localhost ([127.0.0.1]:48114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cshsu-0005xZ-J3 for submit@debbugs.gnu.org; Mon, 27 Mar 2017 23:33:28 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:38155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cshss-0005xM-Pq for 26037@debbugs.gnu.org; Mon, 27 Mar 2017 23:33:27 -0400 Received: by mail-it0-f52.google.com with SMTP id y18so5362476itc.1 for <26037@debbugs.gnu.org>; Mon, 27 Mar 2017 20:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version; bh=JyBhMbW9JePatK3C4WsmGWkdkP7O7cwS9ebHfAfX5WI=; b=TWgbqQP/dM8AIZ6uDkJHTS0VcMF8D4CZ6ifOqnt+PuiaQRoqGSwuTRAUjtqOdE76L8 jM8tQp3DwaZs2Kcex3BSIg7ocjJgUdbjHw69YnV66i3njgZv5d6Nn2Cw475UnIuOBBJ2 /vsk8JcEA0ddIvEDtxo8mIpU4VJVFXW59ekE0+3zCyNiC7WPQSR2Pdd77kASK7R0/Ym9 ioNMd/oTG0x4lcpNZBm7DqhVfIQS/WFfW2aHQq3aUzoWXb++bLvDTW/V7LX2FCR68P39 2xIACbx1l7zlqE1Ukexn6FIq+0wbGR5ObDQZe60L79AMNKhoaqzQfNPYcGzsIKQynikI gxMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version; bh=JyBhMbW9JePatK3C4WsmGWkdkP7O7cwS9ebHfAfX5WI=; b=ohCtXvsr5bS6tk1zFTVnY9FwPBfXipQftZhS8YFvH6wHUQP1xILVx+xnP5RoQbWkan KCLek1IIv1nuKaQX4PlW0murmXfcBrtVjhPK9coAlQAXMFDWzT+C8ft6bYLsGE0uVIny DWqbKvfu4LsCqfr/YovbVOJNRW2UW4V1WBcWVWOzPIMnXR3SCsYSu8bK/WCZ6bI0FRPt upy8a45YvG/FXWB8WN2w4UfHocOqzXKFzsUJSruUU+d1jOJbrSNdePoEGvRFS7sQ+qjh MJS24NQ5sRYI0mTCnNufjULBzzOqnA/RauJJ1vtjroD8m0MANCj1/2hRk/FzGQ1S/92h g6Bw== X-Gm-Message-State: AFeK/H1QGa0rY6obKAOuF+TXvA5Kutq2bSqv56xcxvXgF9LOKOow9bD9WRhiOXkakBU+HA== X-Received: by 10.107.201.208 with SMTP id z199mr23204143iof.217.1490672001357; Mon, 27 Mar 2017 20:33:21 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id b25sm1290158iod.32.2017.03.27.20.33.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Mar 2017 20:33:20 -0700 (PDT) From: npostavs@users.sourceforge.net Date: Mon, 27 Mar 2017 23:34:42 -0400 Message-ID: <87o9wm2hwt.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain [Please use Reply All to keep 26037@debbugs.gnu.org on Cc] --=-=-= Content-Type: message/rfc822 Content-Disposition: inline In-Reply-To: <87d1d352yq.fsf@users.sourceforge.net> References: <87bmt259m6.fsf@users.sourceforge.net> <87o9wy4lvt.fsf@users.sourceforge.net> <87d1d352yq.fsf@users.sourceforge.net> From: =?utf-8?B?0JXQstCz0LXQvdC4INCa0L7Qu9C10LI=?= Date: Mon, 27 Mar 2017 09:55:55 +0300 Message-ID: Subject: Re: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures To: npostavs@users.sourceforge.net X-Headers-End: 1csOZr-0001IU-SH MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="====-=-=" --====-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Sure! Here's output of format-patch, with `+' added to the regex and updated comment, and again, please let me know if it can be improved: >From 250e022caf3889a1778820bac1ad072240fa93d4 Mon Sep 17 00:00:00 2001 From: Evgeni Kolev Date: Mon, 27 Mar 2017 09:30:10 +0300 Subject: [PATCH] Propertize only perl prototype chars `][$%&*;+@\' as punctuation As a result, variables in signatures such as `sub add ($a, $b) are not treated as punctuation. * lisp/progmodes/perl-mode.el (perl-syntax-propertize-function): Strictly match only prototype characters as punctuation. (Bug#26037) Copyright-paperwork-exempt: yes --- lisp/progmodes/perl-mode.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index a516f07..1bcc743 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -255,9 +255,10 @@ ;; format statements ("^[ \t]*format.*=[ \t]*\\(\n\\)" (1 (prog1 "\"" (perl-syntax-propertize-special-constructs end)))) - ;; Funny things in `sub' arg-specs like `sub myfun ($)' or `sub ($)'. - ;; Be careful not to match "sub { (...) ... }". - ("\\ Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2017 03:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 26037@debbugs.gnu.org Cc: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.149067244523531 (code B ref 26037); Tue, 28 Mar 2017 03:41:01 +0000 Received: (at 26037) by debbugs.gnu.org; 28 Mar 2017 03:40:45 +0000 Received: from localhost ([127.0.0.1]:48119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cshzx-00067T-CJ for submit@debbugs.gnu.org; Mon, 27 Mar 2017 23:40:45 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:32811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cshzv-00067H-S8 for 26037@debbugs.gnu.org; Mon, 27 Mar 2017 23:40:44 -0400 Received: by mail-it0-f51.google.com with SMTP id 76so9775143itj.0 for <26037@debbugs.gnu.org>; Mon, 27 Mar 2017 20:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8vVYXKx1N2nevh2j9HFdn9lklGOwAXGBhLfH6CiwD1g=; b=GH6eSiluPIXO8r4W1d6/k9SUIxLjTFpUwgPNxkZY/ryS5ql5uAmz+MVIqvi/T6aDwv g1WWRf/+QQiyTIb8soGy0/xYHjTb+rYv7G1OxVTxNkNFy3vBXFJzCIl0bw6YercAIIB5 lFHc3G0ZSIAcTvFhWonE9A2ooeYdLUuR3VWDyyecg3hX1JyAAOpmiamHT2Jr4dTOkg1P Lz1szmRcxdhn/XmsFXzqcINRY2ToXkYUKwZjZCJHqLbp0V0d3As5tl0joU9L/St0K7M5 jxFBBvlngp1RDDKVWshKUfUvUSIjB0oaP5DOgyqPHoOVdVkeGP+s09SsAo60r7obv7H9 sQpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=8vVYXKx1N2nevh2j9HFdn9lklGOwAXGBhLfH6CiwD1g=; b=bIWc0RS4iw+lUjTlTemlrzF2fXTUAVQsqDkKQURCVv1eSRBIILuwaMLSB8pitg/Om+ 7yrmIdO4lZM/T6vI5jLTEyybYgGECYxLC5krpTf9i6WxApy4uyQM4cjMNKO+BTGsUmvl EqMTEQX7xESiPzMmwvfxSj7PpkDVySbXM8i8uEimQZx4usEZ6Mhioha9LI69ZoAJHTin //yn6Q/6bmPcSjnJrwH8thyiGuniXH2QLLjqgYQMeJlwrLzTw5kos2jktPUyMiiPvk/7 UYI+nnkWzd6w70dQHFCHGtAmTQo9sCnmMqxSE74Li9sK88Z/ytPLtmGkdM94SsDRRgcK 2Tjw== X-Gm-Message-State: AFeK/H3hCPx+JgLthlw1ob24tfUduZEdxeib9MXPWEbAG42BpXt8Lq7le9NVHLROc2T8Fw== X-Received: by 10.107.143.203 with SMTP id r194mr24689290iod.69.1490672438400; Mon, 27 Mar 2017 20:40:38 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id f127sm882968ite.14.2017.03.27.20.40.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Mar 2017 20:40:37 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87o9wm2hwt.fsf@users.sourceforge.net> Date: Mon, 27 Mar 2017 23:41:59 -0400 In-Reply-To: <87o9wm2hwt.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Mon, 27 Mar 2017 23:34:42 -0400") Message-ID: <87lgrq2hko.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) npostavs@users.sourceforge.net writes: > + ;; Propertize perl prototype chars `][$%&*;+@\' as punctioation ^^^^ Typo. > + ;; in `sub' arg-specs like `sub myfun ($)' or `sub ($)'. Be > + ;; careful not to match "sub { (...) ... }". Perhaps you could mention that we're trying not match subroutine signatures? From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: =?UTF-8?Q?[=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2]?= Re: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Mar 2017 06:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: npostavs@users.sourceforge.net Cc: 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.149076895820133 (code B ref 26037); Wed, 29 Mar 2017 06:30:02 +0000 Received: (at 26037) by debbugs.gnu.org; 29 Mar 2017 06:29:18 +0000 Received: from localhost ([127.0.0.1]:49985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ct76c-0005Ef-Ft for submit@debbugs.gnu.org; Wed, 29 Mar 2017 02:29:18 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:34365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ct76a-0005ES-9v for 26037@debbugs.gnu.org; Wed, 29 Mar 2017 02:29:16 -0400 Received: by mail-lf0-f54.google.com with SMTP id z15so2583092lfd.1 for <26037@debbugs.gnu.org>; Tue, 28 Mar 2017 23:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=p+tdLE4QP+OxMN0rDN7mpGbHW22nqp1rhIum5NRVLzM=; b=LSGXmonM3HcRWgTFRg7vY/oxxuWESUDycIfqJQ/UITb9ioy2gdvk5rTQNMy50e7QT0 lrYMdSdxH1iNMdDfensPy3XJLlZtc9AhnBFqjo2dqo3WOcEhZWEtpMlOsloehpCfkfIG w1wF4zbP++BZMTCPjVBabdalhQpjhM3jWxdS6fI5YOfilBbuCo1e1eNFmKTlmzJaK4NG bFJGvmM4qxA44hn5RSgwRxFFIPQdL8YA4gf1IaMGCmYbnDAIwguGi4zhStB18GdiSdOL eN7oyLXQGNDyy6XvaVlSJ5yWT9vFeQMQVUtp76jxUc4+265L5laLbH8+C5u+py9H7P78 gAig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=p+tdLE4QP+OxMN0rDN7mpGbHW22nqp1rhIum5NRVLzM=; b=KOxzEZIOtZ+BjDd7xZZ9aS5VIPT/y1E+7ulpLNE05rSe4jQyQ4VGkkbOQ4Zb/TzF/w 4TUqUJzNbo706rCQURyP7UMecs5kPpactl9V7n5AbacuDCiZUMcG0AJXmgu9xffvoO8Z I/Uh5P65OcHeNXWhmgjjQGZcpDPw6kh21iXxZtX+bvlN7o2uJjTuTt6ZLJ0JrS5lweCa Z/p7JljfWBHtC0Ts+wHHhlsP2Pm+dM+EV8bQ94hdMJevjMzyT45MPkfHL0L/KlCZDbwL dKpfVbr0TdssigG3QjBsB7ObLhbxX0e+kPo7Yhij4dJf2XE3gBbadV6p8R2novHqoQBg XTOw== X-Gm-Message-State: AFeK/H0WGeFAEh3ro6NkuPhSWP7ob35fIMaKnc5v1o/CUhX0Gdw8Q43cg7/byU+RufhRFawGyGAoCkxp6sBoKg== X-Received: by 10.25.33.208 with SMTP id h199mr14006348lfh.68.1490768950578; Tue, 28 Mar 2017 23:29:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.157.82 with HTTP; Tue, 28 Mar 2017 23:28:40 -0700 (PDT) In-Reply-To: <87lgrq2hko.fsf@users.sourceforge.net> References: <87o9wm2hwt.fsf@users.sourceforge.net> <87lgrq2hko.fsf@users.sourceforge.net> From: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Date: Wed, 29 Mar 2017 09:28:40 +0300 Message-ID: Content-Type: multipart/alternative; boundary=001a114104f8bdf218054bd8b182 X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a114104f8bdf218054bd8b182 Content-Type: text/plain; charset=UTF-8 Sure, here's the updated patch: >From de1c6f786b8366423cca7edce1ecfabe763567d0 Mon Sep 17 00:00:00 2001 From: Evgeni Kolev Date: Mon, 27 Mar 2017 09:30:10 +0300 Subject: [PATCH] Propertize only perl prototype chars `][$%&*;+@\' as punctuation As a result, variables in signatures such as `sub add ($a, $b) are not treated as punctuation. * lisp/progmodes/perl-mode.el (perl-syntax-propertize-function): Strictly match only prototype characters as punctuation. (Bug#26037) Copyright-paperwork-exempt: yes --- lisp/progmodes/perl-mode.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index a516f07..45628e3 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -255,9 +255,11 @@ ;; format statements ("^[ \t]*format.*=[ \t]*\\(\n\\)" (1 (prog1 "\"" (perl-syntax-propertize-special-constructs end)))) - ;; Funny things in `sub' arg-specs like `sub myfun ($)' or `sub ($)'. - ;; Be careful not to match "sub { (...) ... }". - ("\\Sure, here's the updated patch:

From de1c6f786b8366423cca7edce1ecfabe763567d0 Mon Sep 17 0= 0:00:00 2001
From: Evgeni Kolev <evgenysw@gmail.com>
Date: Mon, 27 Mar 2017 09:30:= 10 +0300
Subject: [PATCH] Propertize only perl prototype chars `]= [$%&*;+@\' as
=C2=A0punctuation

= As a result, variables in signatures such as `sub add ($a, $b) are not
treated as punctuation.
* lisp/progmodes/perl-mode.el (perl= -syntax-propertize-function):
Strictly match only prototype chara= cters as punctuation. (Bug#26037)

Copyright-paperw= ork-exempt: yes
---
=C2=A0lisp/progmodes/perl-mode.el |= 8 +++++---
=C2=A01 file changed, 5 insertions(+), 3 deletions(-)=

diff --git a/lisp/progmodes/perl-mode.el b/lisp/p= rogmodes/perl-mode.el
index a516f07..45628e3 100644
---= a/lisp/progmodes/perl-mode.el
+++ b/lisp/progmodes/perl-mode.el<= /div>
@@ -255,9 +255,11 @@
=C2=A0 =C2=A0 =C2=A0 =C2=A0;; form= at statements
=C2=A0 =C2=A0 =C2=A0 =C2=A0("^[ \t]*format.*= =3D[ \t]*\\(\n\\)"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (1 (prog1 &qu= ot;\"" (perl-syntax-propertize-special-constructs end))))
- =C2=A0 =C2=A0 =C2=A0;; Funny things in `sub' arg-specs like `sub m= yfun ($)' or `sub ($)'.
- =C2=A0 =C2=A0 =C2=A0;; Be caref= ul not to match "sub { (...) ... }".
- =C2=A0 =C2=A0 = =C2=A0("\\<sub\\(?:[\s\t\n]+\\(?:\\sw\\|\\s_\\)+\\)?[\s\t\n]*(\\([^= )]+\\))"
+ =C2=A0 =C2=A0 =C2=A0;; Propertize perl prototype = chars `$%&*;+@\[]' as punctuation
+ =C2=A0 =C2=A0 =C2=A0;= ; in `sub' arg-specs like `sub myfun ($)' and `sub ($)'. But
+ =C2=A0 =C2=A0 =C2=A0;; don't match subroutine signatures like= `sub add ($a, $b)', or
+ =C2=A0 =C2=A0 =C2=A0;; anonymous su= bs like "sub { (...) ... }".
+ =C2=A0 =C2=A0 =C2=A0(&qu= ot;\\<sub\\(?:[\s\t\n]+\\(?:\\sw\\|\\s_\\)+\\)?[\s\t\n]*(\\([][$%&*;= +@\\]+\\))"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (1 "."))
=C2=A0 =C2=A0 =C2=A0 =C2=A0;; Turn __DATA__ trailer into a comment= .
=C2=A0 =C2=A0 =C2=A0 =C2=A0("^\\(_\\)_\\(?:DATA\\|END\\)__= [ \t]*\\(?:\\(\n\\)#.-\\*-.*perl.*-\\*-\\|\n.*\\)"
--=C2=A0<= /div>
2.10.0

--001a114104f8bdf218054bd8b182-- From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Mar 2017 23:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Cc: 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.14908311079045 (code B ref 26037); Wed, 29 Mar 2017 23:46:02 +0000 Received: (at 26037) by debbugs.gnu.org; 29 Mar 2017 23:45:07 +0000 Received: from localhost ([127.0.0.1]:51738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctNH0-0002Lj-Ql for submit@debbugs.gnu.org; Wed, 29 Mar 2017 19:45:07 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:35919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctNGy-0002Ku-NT; Wed, 29 Mar 2017 19:45:04 -0400 Received: by mail-io0-f174.google.com with SMTP id l7so9238524ioe.3; Wed, 29 Mar 2017 16:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=bRImMz5XgrWf6buohiPDTOsyTZRwaOIreC898IV2cFg=; b=nGfcH4CVgrxT7s5Kxfqqp7SKNTTDO1F+8RhW1SH4gFOgtKhdxG+cA1llB0hlK/AKOw nOJpx9mSKmieGl0B5eacnTp/l8SDHaKDHsxdWLTXbDynaABCkRj6tnjOSRprbesYEUFg fN/VneqedOGJB4m+UIvj0YvFOgkxhWUQMW58RrWwjlxEnW5UtADPZsR6hFWU20YlQAkq o7xPGgHkxN6WkKhfTQICxFMQrzkuxFjP/8gYGii/mKViSRvk96RSZfOisX8ZMEk+Az42 qPc462QkhRYDPSjBwRxxwNFHEVvjqsPF1AlbED5ine8HCPlWzHx9uUQwl8UXLi+M0ICT o5sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=bRImMz5XgrWf6buohiPDTOsyTZRwaOIreC898IV2cFg=; b=TfpFXrNCUY7X0DNAHusjx8tISV15T5TcaWhLwNQq7dWx1a4eEouhbtimXZ66kPpvfc zmUmAqU2laXDOeO7TN/TUy1/meuLroWkgkxtAkOhVM5FqC3Y2A9i3h5lPI/e8xNR9Ebx sdVABCtzpU4A4DbFleAtQiMGu6nPrSIQiOmv+UtgO7IAWqzgb5WCt9zpfnNHSEur/EXX /EcoT590PAyrzsgASv1PEdlEzEZlWmEZQ0oLOs00aS4+0jN2EQF0k6mGohnkWox0NHF7 OY+cHgApHGfRspVXpnz582vpFtmaIUrFD2PhxhAoA4C/SbgveWMQCJD8aKtkW0Ls3hag Ig9A== X-Gm-Message-State: AFeK/H2EIv8udjymD5yyGvlWP2cnuR8at2uXQa5eyVqhqG3ncjrORTqblEY6/kvBxE78yw== X-Received: by 10.107.145.87 with SMTP id t84mr4115134iod.64.1490831099040; Wed, 29 Mar 2017 16:44:59 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p79sm489012ioe.1.2017.03.29.16.44.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Mar 2017 16:44:56 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87o9wm2hwt.fsf@users.sourceforge.net> <87lgrq2hko.fsf@users.sourceforge.net> Date: Wed, 29 Mar 2017 19:46:18 -0400 In-Reply-To: ("=?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?="'s message of "Wed, 29 Mar 2017 09:28:40 +0300") Message-ID: <87a8833aut.fsf_-_@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 26037 patch quit =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8 =D0=9A=D0=BE=D0=BB=D0=B5=D0=B2 writes: > Sure, here's the updated patch: Thanks, looks good to me, I will push to master in a few days. From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Apr 2017 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Cc: 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.14910827659357 (code B ref 26037); Sat, 01 Apr 2017 21:40:02 +0000 Received: (at 26037) by debbugs.gnu.org; 1 Apr 2017 21:39:25 +0000 Received: from localhost ([127.0.0.1]:56007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuQk1-0002Qm-04 for submit@debbugs.gnu.org; Sat, 01 Apr 2017 17:39:25 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:32944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuQjz-0002QT-Ay; Sat, 01 Apr 2017 17:39:23 -0400 Received: by mail-io0-f182.google.com with SMTP id f84so57225713ioj.0; Sat, 01 Apr 2017 14:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=dQY6P1Ph2TsC9qSYLzBWoKbeqmyPcmAbmyuC4Qy3sEw=; b=dM9+ruUb5+ImpthXSomS94bP2yeET2Wh0khlbLbMpbFZFVtNGEYoMpd2LtVJ7kgCYk 6pJdz68onK5vMbBls5IYHJGJyx1UNTQw2r3ZASnpVf43EfIrAB+KlCxyofNKYmr0FOOc 4WnV4FXOAyQvluLMkoEd4gDI3x594rEAFRx77Y3/4qd1KKobXNJ2Nc+MTGFaQw0zeJIZ TLOfX4OR8UlxrElxbadxx4fR90N0/giHBDFE6rTXLoKgOcjRgFpecxRXVQdgY6XrJ3v9 EM98gi2TYp+kXP/CgQInAy7shWK8EzEQ5MQW9GJ/+JU926cx23BbJJyI6gtt4hXn2NFK SJOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=dQY6P1Ph2TsC9qSYLzBWoKbeqmyPcmAbmyuC4Qy3sEw=; b=r8B0oAVZHGlb1tO8atoSa4bPRAuMUzUFBsQg0Z2noA9PBnNnS9pW/8z1NlcyZ+4cQW dVqdrm+T+mCDLvVyGhcrXOKazSzr2Y+tyt6K8Nvn89eBgRyNPie/6c1Yvejxi1WDJm8v 1tAY6eFxz39b6sqthdomDt3UTL3XNgpauFqExN7NPPnXAMKaFVixPJDE0YCEBDL9BJIG wtrmPyiIF1HtrDy3mjeRy1+/KdFS7qhLn03jeDkXHRAgB6FOmSGWW24GL/s9YXF7rZwR zI6JAaAF0ebY+FUTo4eps55DNqJgBEy3vGLttBda9sCa3KZWQs7VhmB7OeIVmd5nDu6S GAcw== X-Gm-Message-State: AFeK/H1+U+JX3zWNJ3JMUcUWydc84InsEYdsOZzpbdd1fS/z+Lru0zBMBO8JBVMhlMc25g== X-Received: by 10.107.56.11 with SMTP id f11mr10084302ioa.131.1491082757794; Sat, 01 Apr 2017 14:39:17 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e20sm4834795itc.3.2017.04.01.14.39.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Apr 2017 14:39:16 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87o9wm2hwt.fsf@users.sourceforge.net> <87lgrq2hko.fsf@users.sourceforge.net> <87a8833aut.fsf_-_@users.sourceforge.net> Date: Sat, 01 Apr 2017 17:40:40 -0400 In-Reply-To: <87a8833aut.fsf_-_@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Wed, 29 Mar 2017 19:46:18 -0400") Message-ID: <87bmsf24dj.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 26037 fixed close 26037 26.1 quit npostavs@users.sourceforge.net writes: > > =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8 =D0=9A=D0=BE=D0=BB=D0=B5=D0=B2 writes: > >> Sure, here's the updated patch: > > Thanks, looks good to me, I will push to master in a few days. Pushed to master [1: a184a7edc5] (I fixed a missing double space between sentences and a missing ' in the commit message). Thanks for working on this. PS gmail line-wrapped your patch, it's better to send as attachment when using gmail. 1: 2017-04-01 17:32:18 -0400 a184a7edc58e1e053aa317a0f162df7e225597e1 Propertize only perl prototype chars `][$%&*;+@\' as punctuation From unknown Sat Jun 21 05:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Resent-From: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Apr 2017 07:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: npostavs@users.sourceforge.net Cc: 26037@debbugs.gnu.org Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.149120580725204 (code B ref 26037); Mon, 03 Apr 2017 07:51:01 +0000 Received: (at 26037) by debbugs.gnu.org; 3 Apr 2017 07:50:07 +0000 Received: from localhost ([127.0.0.1]:58079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuwkZ-0006YS-6t for submit@debbugs.gnu.org; Mon, 03 Apr 2017 03:50:07 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:34933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuwkX-0006Xu-CI for 26037@debbugs.gnu.org; Mon, 03 Apr 2017 03:50:05 -0400 Received: by mail-lf0-f47.google.com with SMTP id j90so67305145lfk.2 for <26037@debbugs.gnu.org>; Mon, 03 Apr 2017 00:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3x2K13y4iS/KFZYgkpjLB9dHnNqob1wucz35MZ2k0U8=; b=sTMFTt4/LyBhWkB/WHw4+iqr6pTOqPeKDf4UiomD1qZbf1E/ohDzbmfzXBaXgbbzvT eGmF7P/iV6Lh4N05R/Z7jtkfjtZzxjpd7f/LpWWnqp0zkTbcNuTAVAN+k9p4mhBjNxft GqAJ4OjKlqbjXgs+Fpra5aTFkBN26QXDmTWPF7SQuGIczSIv7Jg9PZLwgItwVyy+s1LS +DdGTZ+Xkji0z3muZGnOrYJQ3aTgd+DI8sfibKhYq0t5jd4qBLUdGnQaj+JsqOGhY1FB Axrdi7HBbgRHpFILZ8OMbISeChauFO2losWyAUifl+LP8nzjXFkY0AOqR0lMadDRFKEn O+4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3x2K13y4iS/KFZYgkpjLB9dHnNqob1wucz35MZ2k0U8=; b=FhaqkW8LOhEdnz7AVqSDI5Y+ENORpGXxK0tBDWBK3vh7nS62mL1xnlpnqkHTgXDh1r kdxKE3jvNykVJCN4KWWsFFEneIRMRa+UIh+JM6glGsbg6ayV/wWsNWn1FPYMhC2CMpdW ehcP8xVOv0t0QRRTBzgiWO0ES5gx8h2biBjx2SNp9WTzhxzvAf+xsLIMSa8VsxffJxj4 nD6/GsLZ7Nc5m2BeCDgJFZjpMa/sGBC27uVrGiPbbWl3tl0mSz4E/9WsZVmmxyf3hX1N vez+ONT/rqQ7p/WTKlsgMsz8YDF/Q33+8xDObS2yP5Z4PX9Bd+uQ5j6H3+NOjfeUNhgQ foug== X-Gm-Message-State: AFeK/H3FeHCCfzfEnkfZljd6c8t5qJvJ2b3VxmDNWPIGCNSFDclYOpyD7OhtQFMLaX7CcTBEQu87iZHg6IvUMA== X-Received: by 10.46.88.79 with SMTP id x15mr4471807ljd.39.1491205799270; Mon, 03 Apr 2017 00:49:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.157.82 with HTTP; Mon, 3 Apr 2017 00:49:28 -0700 (PDT) In-Reply-To: <87bmsf24dj.fsf@users.sourceforge.net> References: <87o9wm2hwt.fsf@users.sourceforge.net> <87lgrq2hko.fsf@users.sourceforge.net> <87a8833aut.fsf_-_@users.sourceforge.net> <87bmsf24dj.fsf@users.sourceforge.net> From: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8_?= =?UTF-8?Q?=D0=9A=D0=BE=D0=BB=D0=B5=D0=B2?= Date: Mon, 3 Apr 2017 10:49:28 +0300 Message-ID: Content-Type: multipart/alternative; boundary=f40304387f4cf3de7e054c3e67a9 X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --f40304387f4cf3de7e054c3e67a9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks, and thanks for working on improving emacs! On Sun, Apr 2, 2017 at 12:40 AM, wrote: > tags 26037 fixed > close 26037 26.1 > quit > > npostavs@users.sourceforge.net writes: > > > > > =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8 =D0=9A=D0=BE=D0=BB=D0=B5=D0=B2 writes: > > > >> Sure, here's the updated patch: > > > > Thanks, looks good to me, I will push to master in a few days. > > Pushed to master [1: a184a7edc5] (I fixed a missing double space between > sentences and a missing ' in the commit message). Thanks for working on > this. > > PS gmail line-wrapped your patch, it's better to send as attachment when > using gmail. > > 1: 2017-04-01 17:32:18 -0400 a184a7edc58e1e053aa317a0f162df7e225597e1 > Propertize only perl prototype chars `][$%&*;+@\' as punctuation > > --f40304387f4cf3de7e054c3e67a9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks, and thanks for working on improving emacs!

On Sun, Apr 2, 2017= at 12:40 AM, <npostavs@users.sourceforge.net>= wrote:
tags 26037 fixed
close 26037 26.1
quit

npostavs@users.sourceforg= e.net writes:

>
> =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8 =D0=9A=D0=BE=D0=BB=D0=B5=D0=B2 &l= t;evgenysw@gmail.com> writes:<= br> >
>> Sure, here's the updated patch:
>
> Thanks, looks good to me, I will push to master in a few days.

Pushed to master [1: a184a7edc5] (I fixed a missing double space bet= ween
sentences and a missing ' in the commit message).=C2=A0 Thanks for work= ing on
this.

PS gmail line-wrapped your patch, it's better to send as attachment whe= n
using gmail.

1: 2017-04-01 17:32:18 -0400 a184a7edc58e1e053aa317a0f162df7e225597e1<= br>
=C2=A0 Propertize only perl prototy= pe chars `][$%&*;+@\' as punctuation


--f40304387f4cf3de7e054c3e67a9--