From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 07 12:05:48 2017 Received: (at submit) by debbugs.gnu.org; 7 Mar 2017 17:05:48 +0000 Received: from localhost ([127.0.0.1]:44864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clIYW-0006EH-6R for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:05:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clIYT-0006E5-N5 for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:05:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clIYN-0007Ql-9s for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:05:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45250) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clIYN-0007Qg-6u for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:05:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clIYL-0007bv-Nd for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:05:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clIYG-0007Nx-Qm for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:05:37 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51774) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clIYG-0007Mu-H2 for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:05:32 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C21AA160069; Tue, 7 Mar 2017 09:05:26 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ew7TyK4Xx6Xc; Tue, 7 Mar 2017 09:05:24 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8E38516009A; Tue, 7 Mar 2017 09:05:24 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jDEXHZ2domwd; Tue, 7 Mar 2017 09:05:24 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 71970160069; Tue, 7 Mar 2017 09:05:24 -0800 (PST) Subject: Emacs workaround for Solaris 10 is unnecessary To: "Burt, Timothy C - GS" References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <42889902-fc49-5271-f603-ab4358c265ca@cs.ucla.edu> Date: Tue, 7 Mar 2017 09:05:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Emacs bug reports X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Going back to the old bug report copied below, because I'm trying to simplify the isnan code in Emacs. I cannot reproduce the problem on Solaris 10 sparc with the bundled GCC 3.4.3 (/usr/sfw/bin/gcc, which reports "gcc (GCC) 3.4.3 (csl-sol210-3_4-branch+sol_rpath)". So I am inclined to think that the compiler mentioned below wasn't installed correctly. I notice, for example, that when I run the command 'nm floatfns.o' the output does not contain the symbols __builtin_isnan or __builtin_isfinite. Instead, the Fisnan function contains open code that tests where a register contains a NaN, which is what I would expect GCC to do. So I am now inclined to think that the bug report is a false alarm. I'll CC: this to bug-gnu-emacs so that this gets a bug number. On 10/22/2013 06:43 PM, Burt, Timothy C - GS wrote: > Paul --- > > My apologies if you are not involved with emacs development or even care to be notified of what seems to be a regression to one of your fixes. But if you're still willing to read on then can I presume on you to point me in the right direction to report this? > > In short, while compiling emacs 24.3 on a Sparc Solaris 10 machine with gcc v3.4.3 I encountered fatal errors[fn:1] with __builtin_isnan and __builtin_isfinite being undefined symbols. I found your fix for isnan, but the code base I used (from http://gnu.spinellicreations.com/emacs/emacs-24.3.tar.gz) had isnan surrounded by an #ifndef/#endif guard instead of your #undef solution. So, I changed it back and did the same for isfinite then the compilation was successful. I think this is a bug but I hesitated to use bug-gnu-emacs@gnu.org since that seemed to be for emacs, not necessarily emacs development. Would you be able to point me in the right direction? > > > Thank you, > and I'm sorry for the cold call. > > > > [fn:1] Internal compilation notes that include error at temacs step: > + IMPORTANT: For Solaris 10 with gcc v3.4.3 the following changes need > to be made to src/floatfns.c > : 37c37 > : < #ifndef isfinite > : --- > : > #undef isfinite > : 39,40c39 > : < #endif > : < #ifndef isnan > : --- > : > #undef isnan > : 42d40 > : < #endif > - Paul Eggert noticed an fixed a problem with isnan (see > http://lists.gnu.org/archive/html/emacs-diffs/2011-09/msg00041.html). > However, somewhere between that fix and the code base used here a > minor, but vital, change was made that broke the compilation on > Solaris 10 with gcc v3.4.3. Specifically, isnan should have > been #undef'd. The changes above take away the #ifndef/#endif > guards and replace them with a leading #undef for both isnan and > isfinite since they both contribute to the fatal error making > temacs. > #+begin_src text > cc -std=gnu99 -Demacs -I. -I/vendor/emacs-24.3/emacs-24.3/src -I../lib -I/vendor/emacs-24.3/emacs-24.3/src/../lib -I/usr/openwin/include -I/usr/include/libxml2 -MMD -MF deps/.d -MP -g3 -O2 -L/usr/openwin/lib \ > -o temacs dispnew.o frame.o scroll.o xdisp.o menu.o xmenu.o window.o charset.o coding.o category.o ccl.o character.o chartab.o bidi.o cm.o term.o terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o xsmfns.o xsettings.o xgselect.o emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o filelock.o insdel.o marker.o minibuf.o fileio.o dired.o cmds.o casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o doc.o editfns.o callint.o eval.o floatfns.o fns.o font.o print.o lread.o syntax.o unexsol.o bytecode.o process.o gnutls.o callproc.o region-cache.o sound.o atimer.o doprnt.o intervals.o textprop.o composite.o xml.o profiler.o xfont.o fontset.o fringe.o image.o terminfo.o lastfile.o widget.o ../lib/libgnu.a ../lwlib/liblw.a -ltiff -ljpeg -lpng -lz -lm -lXpm -lXaw -lXmu -lXt -lSM -lICE -lXext -lX11 -lrt -lrt -lxml2 -lpthread -lz -lm -lsocket -lnsl -lresolv -lsocket -lnsl -lncurses -lfontconfig -lpthread -lm > Undefined first referenced > symbol in file > __builtin_isnan floatfns.o > __builtin_isfinite floatfns.o > ld: fatal: Symbol referencing errors. No output written to temacs > collect2: ld returned 1 exit status > gmake[1]: *** [temacs] Error 1 > gmake[1]: Leaving directory `/ssd/system/vendor/emacs-24.3/emacs-24.3/src' > gmake: *** [src] Error 2 > #+end_src > > > > Timothy C. Burt, PhD > Senior Staff Scientist > timothy.burt@exelisinc.com > (585) 269-5230 > > > > ________________________________ > > This e-mail and any files transmitted with it may be proprietary and are intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error please notify the sender. Please note that any views or opinions presented in this e-mail are solely those of the author and do not necessarily represent those of Exelis Inc. The recipient should check this e-mail and any attachments for the presence of viruses. Exelis Inc. accepts no liability for any damage caused by any virus transmitted by this e-mail. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 07 12:53:08 2017 Received: (at 26018-done) by debbugs.gnu.org; 7 Mar 2017 17:53:08 +0000 Received: from localhost ([127.0.0.1]:44922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clJIK-0000iv-8A for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:53:08 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clJII-0000iQ-0R for 26018-done@debbugs.gnu.org; Tue, 07 Mar 2017 12:53:06 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 17E7D160060; Tue, 7 Mar 2017 09:53:00 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 03j54TYKAEe4; Tue, 7 Mar 2017 09:52:59 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3E99516007A; Tue, 7 Mar 2017 09:52:59 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jDwcgJlmWn81; Tue, 7 Mar 2017 09:52:59 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 21CDE160060; Tue, 7 Mar 2017 09:52:59 -0800 (PST) To: 26018-done@debbugs.gnu.org From: Paul Eggert Subject: Emacs workaround for Solaris 10 is unnecessary Organization: UCLA Computer Science Department Message-ID: Date: Tue, 7 Mar 2017 09:52:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------719A7D0C757EC064AF988103" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26018-done Cc: "Burt, Timothy C - GS" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------719A7D0C757EC064AF988103 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I installed the attached patch and am closing the bug report. --------------719A7D0C757EC064AF988103 Content-Type: application/x-patch; name="0001-Remove-isnan-hack-for-Solaris-10-gcc-3.4.3.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Remove-isnan-hack-for-Solaris-10-gcc-3.4.3.patch" RnJvbSBmMGRhMjQzZjczNjdmODczYmFhNzIyNTI3ODQ2ODc4YmE1YjQ2MTI4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDcgTWFyIDIwMTcgMDk6NTA6MTUgLTA4MDAKU3ViamVjdDogW1BBVENI XSBSZW1vdmUgaXNuYW4gaGFjayBmb3IgU29sYXJpcyAxMCBnY2MgMy40LjMKClRoaXMgc2Vl bXMgdG8gaGF2ZSBiZWVuIGEgZmFsc2UgYWxhcm0gKEJ1ZyMyNjAxOCkuCiogc3JjL2RhdGEu YyAoaXNuYW4pOgoqIHNyYy9mbG9hdGZucy5jIChpc2Zpbml0ZSwgaXNuYW4pOgpVc2Ugc3Rh bmRhcmQgaW1wbGVtZW50YXRpb24gaWYgYXZhaWxhYmxlLgotLS0KIHNyYy9kYXRhLmMgICAg IHwgIDcgKysrKystLQogc3JjL2Zsb2F0Zm5zLmMgfCAxMyArKysrKystLS0tLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvc3JjL2RhdGEuYyBiL3NyYy9kYXRhLmMKaW5kZXggYWU4OGUzZi4uMjk1NDdkOCAx MDA2NDQKLS0tIGEvc3JjL2RhdGEuYworKysgYi9zcmMvZGF0YS5jCkBAIC0xOSw2ICsxOSw4 IEBAIGFsb25nIHdpdGggR05VIEVtYWNzLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251 Lm9yZy9saWNlbnNlcy8+LiAgKi8KIAogCiAjaW5jbHVkZSA8Y29uZmlnLmg+CisKKyNpbmNs dWRlIDxtYXRoLmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KIAogI2luY2x1ZGUgPGJ5dGVzd2Fw Lmg+CkBAIC0yODEyLDggKzI4MTQsOSBAQCBhcml0aF9kcml2ZXIgKGVudW0gYXJpdGhvcCBj b2RlLCBwdHJkaWZmX3QgbmFyZ3MsIExpc3BfT2JqZWN0ICphcmdzKQogICByZXR1cm4gdmFs OwogfQogCi0jdW5kZWYgaXNuYW4KLSNkZWZpbmUgaXNuYW4oeCkgKCh4KSAhPSAoeCkpCisj aWZuZGVmIGlzbmFuCisjIGRlZmluZSBpc25hbih4KSAoKHgpICE9ICh4KSkKKyNlbmRpZgog CiBzdGF0aWMgTGlzcF9PYmplY3QKIGZsb2F0X2FyaXRoX2RyaXZlciAoZG91YmxlIGFjY3Vt LCBwdHJkaWZmX3QgYXJnbnVtLCBlbnVtIGFyaXRob3AgY29kZSwKZGlmZiAtLWdpdCBhL3Ny Yy9mbG9hdGZucy5jIGIvc3JjL2Zsb2F0Zm5zLmMKaW5kZXggODUzNGYxZC4uNDc1NTNmMiAx MDA2NDQKLS0tIGEvc3JjL2Zsb2F0Zm5zLmMKKysrIGIvc3JjL2Zsb2F0Zm5zLmMKQEAgLTQ3 LDEzICs0NywxMiBAQCBhbG9uZyB3aXRoIEdOVSBFbWFjcy4gIElmIG5vdCwgc2VlIDxodHRw Oi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4gICovCiAKICNpbmNsdWRlIDxjb3VudC1sZWFk aW5nLXplcm9zLmg+CiAKLS8qICdpc2Zpbml0ZScgYW5kICdpc25hbicgY2F1c2UgYnVpbGQg ZmFpbHVyZXMgb24gU29sYXJpcyAxMCB3aXRoIHRoZQotICAgYnVuZGxlZCBHQ0MgaW4gYzk5 IG1vZGUuICBXb3JrIGFyb3VuZCB0aGUgYnVncyB3aXRoIHNpbXBsZQotICAgaW1wbGVtZW50 YXRpb25zIHRoYXQgYXJlIGdvb2QgZW5vdWdoLiAgKi8KLSN1bmRlZiBpc2Zpbml0ZQotI2Rl ZmluZSBpc2Zpbml0ZSh4KSAoKHgpIC0gKHgpID09IDApCi0jdW5kZWYgaXNuYW4KLSNkZWZp bmUgaXNuYW4oeCkgKCh4KSAhPSAoeCkpCisjaWZuZGVmIGlzZmluaXRlCisjIGRlZmluZSBp c2Zpbml0ZSh4KSAoKHgpIC0gKHgpID09IDApCisjZW5kaWYKKyNpZm5kZWYgaXNuYW4KKyMg ZGVmaW5lIGlzbmFuKHgpICgoeCkgIT0gKHgpKQorI2VuZGlmCiAKIC8qIENoZWNrIHRoYXQg WCBpcyBhIGZsb2F0aW5nIHBvaW50IG51bWJlci4gICovCiAKLS0gCjIuOS4zCgo= --------------719A7D0C757EC064AF988103-- From unknown Sat Sep 20 08:01:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 05 Apr 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator