Subject: Re: bug#26009: libpng-apng

From: [email-masked] (Ludovic Courtès)
Date: Thu, 16 Mar 2017 09:02:51 +0100

Good morning!

Kei Kebreau <[email-masked]> skribis:

> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001
> From: ng0 <[email-masked]>
> Date: Tue, 10 Jan 2017 20:49:30 +0000
> Subject: [PATCH] gnu: Add libpng-apng.
> To: [email-masked]
>
> * gnu/packages/image.scm (libpng-apng): New variable.
>
> Signed-off-by: Kei Kebreau <[email-masked]>

[...]

> +         (add-before 'configure 'no-checks
> +           (lambda _
> +             (substitute* "Makefile.in"
> +               (("^scripts/symbols.chk") "")
> +               (("check: scripts/symbols.chk") ""))
> +             (zero? (system* "libtool"))
> +             #t)))))

Do you really want to run ‘libtool’ here?  I think that doesn’t have any
effect:

--8<---------------cut here---------------start------------->8---
$ libtool
Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]...
Try 'libtool --help' for more information.
libtool:   error: you must specify a MODE
--8<---------------cut here---------------end--------------->8---

If there’s nothing else blocking this patch, I think you can go ahead.

Thanks,
Ludo’.