From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 07 06:11:26 2017 Received: (at submit) by debbugs.gnu.org; 7 Mar 2017 11:11:26 +0000 Received: from localhost ([127.0.0.1]:43647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clD1U-0003b3-GG for submit@debbugs.gnu.org; Tue, 07 Mar 2017 06:11:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:32873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clD1S-0003ao-Sr for submit@debbugs.gnu.org; Tue, 07 Mar 2017 06:11:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clD1M-0007ZP-Ko for submit@debbugs.gnu.org; Tue, 07 Mar 2017 06:11:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52773) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clD1M-0007ZE-Hp for submit@debbugs.gnu.org; Tue, 07 Mar 2017 06:11:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clD1K-0002nN-OV for guix-patches@gnu.org; Tue, 07 Mar 2017 06:11:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clD1H-0007Xd-JE for guix-patches@gnu.org; Tue, 07 Mar 2017 06:11:10 -0500 Received: from perdizione.investici.org ([2001:41d0:2:33d0::19]:47911) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clD1G-0007XO-OU for guix-patches@gnu.org; Tue, 07 Mar 2017 06:11:07 -0500 Received: from [94.23.50.208] (perdizione [94.23.50.208]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id D5BB9120531 for ; Tue, 7 Mar 2017 11:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488885065; bh=3apvgPvG0ZezVJ6Lg7aI8+v789mnx47GXMJQ6BG683U=; h=Date:From:To:Subject; b=CwChEfgF1frNwOIblS0q48T8hBjsW6rptbJvuAKMPZmqlKm6CLCIuIMAsB+/fHhH6 jUpolIhOI6p91eTlc51kcJJeUSLvIy4FK021NLnGOLiCoRCSYX84JT+MBJFobdfEB6 /Kas/hA7A/4nL25e/cUWQ7KHPPTqr97kcQe9IHpk= Date: Tue, 7 Mar 2017 12:19:31 +0000 From: ng0 To: guix-patches@gnu.org Subject: libpng-apng Message-ID: <20170307121931.k5mec7wx57xsj3xa@abyayala> Mail-Followup-To: guix-patches@gnu.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="qjr7zvs4k5ku2h6u" Content-Disposition: inline Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) --qjr7zvs4k5ku2h6u Content-Type: text/plain; charset=utf-8 Content-Disposition: inline This adds `libpng-apng'. I had this in the dependency graph of palemoon, a webbrowser I stopped to work on because of license/trademark/legal insecurities. libpng-apng can be used to unbundle it from icecat. Despite the comment in gnu/packages/gnuzilla.scm: This is a real, maintained software which bases on top of libpng and tracks its releases. When libpng is updated, this package needs to be updated aswell as soon as the updated release of the patch is out. I have appended the last version I packaged as a git format-patch file. In the description the 2 occurences of APGN (Animated Portable Network Graphics) could be written with the @defn{} of texinfo I think, and the synopsis could be changed to just "Animated Portable Network Graphics library". I think back then I just copied upstrema in text. Should anyone be interested to finish the work on the webbrowser, the repository with the branch is available at request. --qjr7zvs4k5ku2h6u Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-gnu-Add-libpng-apng.patch" Content-Transfer-Encoding: quoted-printable >From b25f8506b8183e5fb9cc5ce0e59384f4a61a83a2 Mon Sep 17 00:00:00 2001 From: ng0 Date: Tue, 10 Jan 2017 20:49:30 +0000 Subject: [PATCH 1/2] gnu: Add libpng-apng. * gnu/packages/image.scm (libpng-apng): New variable. --- gnu/packages/image.scm | 47 ++++++++++++++++++++++++++++++++++++++++++++= +++ 1 file changed, 47 insertions(+) diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index 53ed69a84..89e843c75 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -14,6 +14,7 @@ ;;; Copyright =C2=A9 2016 Eric Bavier ;;; Copyright =C2=A9 2016 Arun Isaac ;;; Copyright =C2=A9 2016 Kei Kebreau +;;; Copyright =C2=A9 2017 ng0 ;;; ;;; This file is part of GNU Guix. ;;; @@ -98,6 +99,52 @@ library. It supports almost all PNG features and is e= xtensible.") (inherit (package-source libpng)) (patches (search-patches "libpng-CVE-2016-10087.patch")))))) =20 +(define-public libpng-apng + (package + (inherit libpng) + (name "libpng-apng") + (version (package-version libpng)) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-apng + (lambda* (#:key inputs #:allow-other-keys) + (define (apply-patch file) + (zero? (system* "patch" "-p1" "--force" + "--input" file))) + (let ((apng.gz (assoc-ref inputs "apng"))) + (format #t "Applying APNG patch '~a'...~%" + apng.gz) + (system (string-append "gunzip < " apng.gz " > the-patch"= )) + (and (apply-patch "the-patch") + (for-each apply-patch + (find-files "\\.patch")))) + #t)) + (add-before 'configure 'no-checks + (lambda _ + (substitute* "Makefile.in" + (("^scripts/symbols.chk") "") + (("check: scripts/symbols.chk") "")) + (zero? (system* "libtool")) + #t))))) + (inputs + `(("apng" ,(origin + (method url-fetch) + (uri + (string-append "mirror://sourceforge/libpng-apng/libp= ng16/" + version "/libpng-" version "-apng.patc= h.gz")) + (sha256 + (base32 + "026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh= 5")))))) + (native-inputs + `(("libtool" ,libtool))) + (synopsis "APNG patch for libpng") + (description + "APNG (Animated Portable Network Graphics) is an unofficial +extension of the APNG (Portable Network Graphics) format. +APNG patch provides APNG support to libpng.") + (home-page "https://sourceforge.net/projects/libpng-apng/"))) + (define-public libpng-1.2 (package (inherit libpng) --=20 2.12.0 --qjr7zvs4k5ku2h6u-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 12 22:02:23 2017 Received: (at submit) by debbugs.gnu.org; 13 Mar 2017 02:02:23 +0000 Received: from localhost ([127.0.0.1]:53060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnFJX-0006C8-Bf for submit@debbugs.gnu.org; Sun, 12 Mar 2017 22:02:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnFJV-0006Bu-AT for submit@debbugs.gnu.org; Sun, 12 Mar 2017 22:02:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnFJP-0007Jj-7d for submit@debbugs.gnu.org; Sun, 12 Mar 2017 22:02:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cnFJP-0007Jf-4M for submit@debbugs.gnu.org; Sun, 12 Mar 2017 22:02:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnFJN-0006BV-QT for guix-patches@gnu.org; Sun, 12 Mar 2017 22:02:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnFJK-0007JB-P3 for guix-patches@gnu.org; Sun, 12 Mar 2017 22:02:13 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:54131 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnFJK-0007J3-Fu for guix-patches@gnu.org; Sun, 12 Mar 2017 22:02:10 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id A68E851F76E; Mon, 13 Mar 2017 03:02:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489370528; bh=CUjUQfmSOzIGHK3JWV6hmigRHKXNw8wjfXYjYfdwVmA=; h=From:To:Subject:In-Reply-To:References:Date:From; b=it9VqZHcFQ+DEWyZTTQx95HYwIL+bffGWNOEiGMjcXZ3QbSdlyKwFmr0/1W146oLV EQUiMFHFGoL6y0SriWHTI2fh/f8WplqiTfv1yJwDcMd8MCkINYHF/IM6lmL532R5le 75RMDSVPWUzHCiOjLmROES+StcbQB6mtx36uP3mQ= From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489370528; bh=CUjUQfmSOzIGHK3JWV6hmigRHKXNw8wjfXYjYfdwVmA=; h=From:To:Subject:In-Reply-To:References:Date:From; b=it9VqZHcFQ+DEWyZTTQx95HYwIL+bffGWNOEiGMjcXZ3QbSdlyKwFmr0/1W146oLV EQUiMFHFGoL6y0SriWHTI2fh/f8WplqiTfv1yJwDcMd8MCkINYHF/IM6lmL532R5le 75RMDSVPWUzHCiOjLmROES+StcbQB6mtx36uP3mQ= To: guix-patches@gnu.org Subject: Re: bug#26009: libpng-apng In-Reply-To: <20170307121931.k5mec7wx57xsj3xa@abyayala> (ng0's message of "Tue, 7 Mar 2017 12:19:31 +0000") References: <20170307121931.k5mec7wx57xsj3xa@abyayala> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Date: Sun, 12 Mar 2017 22:02:04 -0400 Message-ID: <87lgsa9boj.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain ng0 writes: > This adds `libpng-apng'. I had this in the dependency graph of palemoon, > a webbrowser I stopped to work on because of license/trademark/legal > insecurities. > > libpng-apng can be used to unbundle it from icecat. Despite the comment > in gnu/packages/gnuzilla.scm: This is a real, maintained software which > bases on top of libpng and tracks its releases. > > When libpng is updated, this package needs to be updated aswell as soon > as the updated release of the patch is out. > > I have appended the last version I packaged as a git format-patch file. > > In the description the 2 occurences of APGN (Animated Portable Network Graphics) > could be written with the @defn{} of texinfo I think, > and the synopsis could be changed to just "Animated Portable Network > Graphics library". I think back then I just copied upstrema in text. > > Should anyone be interested to finish the work on the webbrowser, the > repository with the branch is available at request. For whatever reason, I can't get Guix to recognize libpng-apng as a package seperate from libpng (i.e. "guix build libpng-apng" returns a vanilla libpng directory). Do you have any idea why this is? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljF/ZwACgkQ5qXuPBlG eg0iShAAqAKUuZ9CqCPykLxXRFr2S4NK9JkFrRUlP8O7xfexHNUlYDmEbIyfRxd0 JaQ9d6N/4rIZRsjTY7vT6l9k36s4kvOjroj/yzLO66AXi1CDC1kb1cxozo6G370t CUaTwC2SwmsSNvnVrzyb/f5jqFf9PFG6m+BHb4wD10FH6xFCzhNZhm8j98HwjTRS 1TMgSxRiLhlB1Gw3tmmuWkjCDfViGExgcmF87vD72OLbGoK+sk0pWVwB6nUQULMM y5zgStBtJAttZChtPu3o7vk55xRzNcDl+3V+tfPYZQM5AIiY5aHeCJDs5LJT4B5B joGCid/5WSt/FpKkVOM/mGXBWUjWLo7Naqm2Pj9+mEbi1MQAdNVQxuwOTZoqowU2 yH95GspgvkstlfblnRnvxH0CoG3/U6u3Jedw4vBwdpuzIMfLtVcZLZ3aS5tceIsB o5Z//srcsAYpvaIfRs+QyxET0NHnH7E/aQ+L8auvI3piHyqtCKoI8HXvDYoykoGT //V+UtVyDSyJRpys8hrc3QXPpnf+RjEvDY88kbtyrGn11GnAjxAp46FTevRheg4q 7aJRr3j8BlP6B1ZH/tsvpHxPXPeb8DgQtS8XnYbA8mSNn6h8IlH5CI7nP9UkPQxu g1Ny8WBVewqPGsHLFo6etfePoyx8ezPEI2WBy7WumcaEKDDdN7c= =PQIG -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 05:55:53 2017 Received: (at 26009) by debbugs.gnu.org; 13 Mar 2017 09:55:53 +0000 Received: from localhost ([127.0.0.1]:53231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnMhl-0002Ud-AS for submit@debbugs.gnu.org; Mon, 13 Mar 2017 05:55:53 -0400 Received: from perdizione.investici.org ([94.23.50.208]:24763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnMhj-0002UU-Dq for 26009@debbugs.gnu.org; Mon, 13 Mar 2017 05:55:52 -0400 Received: from [94.23.50.208] (perdizione [94.23.50.208]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 32D761211D0; Mon, 13 Mar 2017 09:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1489398950; bh=jRgbGGWcRej0Jw3xIkQPT1jabLvim5vgPwZWtNnUv9g=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=VzLKVSKHHZpj/fs1fFxd60vU2vTk9Cax7y9pdb10vHS4VwNb6jlqbnW8U+dnqI81f x08/7RQ/Kz8mrFPVJFEN0x6lJzIoeQbX4YKkWVN4Ggw2RVstwUlzobvmgAv/PJTCjM HQ+I32fxfbEBkT27B2f8UFu/Pn+oODqLcya6Yz+s= Date: Mon, 13 Mar 2017 11:04:32 +0000 From: ng0 To: Kei Kebreau Subject: Re: bug#26009: libpng-apng Message-ID: <20170313110432.frxgnw6alg3slsyt@abyayala> Mail-Followup-To: Kei Kebreau , 26009@debbugs.gnu.org References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87lgsa9boj.fsf@openmailbox.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Kei Kebreau transcribed 2.1K bytes: > ng0 writes: > > > This adds `libpng-apng'. I had this in the dependency graph of palemoon, > > a webbrowser I stopped to work on because of license/trademark/legal > > insecurities. > > > > libpng-apng can be used to unbundle it from icecat. Despite the comment > > in gnu/packages/gnuzilla.scm: This is a real, maintained software which > > bases on top of libpng and tracks its releases. > > > > When libpng is updated, this package needs to be updated aswell as soon > > as the updated release of the patch is out. > > > > I have appended the last version I packaged as a git format-patch file. > > > > In the description the 2 occurences of APGN (Animated Portable Network Graphics) > > could be written with the @defn{} of texinfo I think, > > and the synopsis could be changed to just "Animated Portable Network > > Graphics library". I think back then I just copied upstrema in text. > > > > Should anyone be interested to finish the work on the webbrowser, the > > repository with the branch is available at request. > > For whatever reason, I can't get Guix to recognize libpng-apng as a > package seperate from libpng (i.e. "guix build libpng-apng" returns a > vanilla libpng directory). Do you have any idea why this is? Interesting. For the process of building palemoon it worked. I'll look into this as soon as I can, thanks for your feedback. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 09:07:19 2017 Received: (at 26009) by debbugs.gnu.org; 13 Mar 2017 13:07:19 +0000 Received: from localhost ([127.0.0.1]:53316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnPh0-00027l-6P for submit@debbugs.gnu.org; Mon, 13 Mar 2017 09:07:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnPgz-00027Y-3i for 26009@debbugs.gnu.org; Mon, 13 Mar 2017 09:07:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnPgo-00010Q-5A for 26009@debbugs.gnu.org; Mon, 13 Mar 2017 09:07:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnPgo-00010K-1l; Mon, 13 Mar 2017 09:07:06 -0400 Received: from [193.50.110.140] (port=34454 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cnPgn-0002fI-Gb; Mon, 13 Mar 2017 09:07:05 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Kei Kebreau Subject: Re: bug#26009: libpng-apng References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> Date: Mon, 13 Mar 2017 14:07:03 +0100 In-Reply-To: <87lgsa9boj.fsf@openmailbox.org> (Kei Kebreau's message of "Sun, 12 Mar 2017 22:02:04 -0400") Message-ID: <874lyxfhqg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) Kei Kebreau skribis: > For whatever reason, I can't get Guix to recognize libpng-apng as a > package seperate from libpng (i.e. "guix build libpng-apng" returns a > vanilla libpng directory). Do you have any idea why this is? This is because libpng in current master has a =E2=80=98replacement=E2=80= =99 field, and since libpng-apng inherits from libpng, it also gets that replacement. The fix is to write: (define-public libpng-apng (package (inherit libpng) (replacement #f) ;libpng=E2=80=99s replacement doesn=E2=80=99t app= ly here =E2=80=A6)) That said, please make sure the security issues fixed in =E2=80=98libpng/fi= xed=E2=80=99 are also fixed in libpng-apng! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 09:15:20 2017 Received: (at 26009) by debbugs.gnu.org; 13 Mar 2017 13:15:20 +0000 Received: from localhost ([127.0.0.1]:53341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnPol-0002eK-SI for submit@debbugs.gnu.org; Mon, 13 Mar 2017 09:15:20 -0400 Received: from latitanza.investici.org ([82.94.249.234]:26891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnPok-0002bl-Ap for 26009@debbugs.gnu.org; Mon, 13 Mar 2017 09:15:19 -0400 Received: from [82.94.249.234] (latitanza [82.94.249.234]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 7DB4F120D6B; Mon, 13 Mar 2017 13:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1489410916; bh=nx3lbgCMsjyTOTM6acOVawdzG5Pvz49ynYHmAeIZFJ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=rx09anBHIs+DCI6sNbM2VLze2VnT4QXMCs+QQxUgrX/4PjpzQWn3Lu0k7grAv0JTn LW1kFmfLQ+9zpPUTHWl72/gj7o9sKdrOl3EOqDKqaeSHnKfHO8e39TSQtmwvGBRQm6 AMv4HRUkAWU/rKC4NXZp6JoOsW6t5Oo/p37uG5Lw= Date: Mon, 13 Mar 2017 14:23:59 +0000 From: ng0 To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#26009: libpng-apng Message-ID: <20170313142359.r4fhaqbvme474vb3@abyayala> Mail-Followup-To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Kei Kebreau , 26009@debbugs.gnu.org References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> <874lyxfhqg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <874lyxfhqg.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org, Kei Kebreau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Ludovic Courtès transcribed 0.7K bytes: > Kei Kebreau skribis: > > > For whatever reason, I can't get Guix to recognize libpng-apng as a > > package seperate from libpng (i.e. "guix build libpng-apng" returns a > > vanilla libpng directory). Do you have any idea why this is? > > This is because libpng in current master has a ‘replacement’ field, and > since libpng-apng inherits from libpng, it also gets that replacement. > > The fix is to write: > > (define-public libpng-apng > (package > (inherit libpng) > (replacement #f) ;libpng’s replacement doesn’t apply here > …)) Thanks. > > That said, please make sure the security issues fixed in ‘libpng/fixed’ > are also fixed in libpng-apng! > > Thanks, > Ludo’. > Do you have any advice how this could be achieved? From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 09:25:36 2017 Received: (at 26009) by debbugs.gnu.org; 13 Mar 2017 13:25:36 +0000 Received: from localhost ([127.0.0.1]:53358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnPyh-0004MA-UH for submit@debbugs.gnu.org; Mon, 13 Mar 2017 09:25:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnPyh-0004Ly-08 for 26009@debbugs.gnu.org; Mon, 13 Mar 2017 09:25:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnPyY-0000gP-P4 for 26009@debbugs.gnu.org; Mon, 13 Mar 2017 09:25:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnPyY-0000gE-La; Mon, 13 Mar 2017 09:25:26 -0400 Received: from [193.50.110.140] (port=36060 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cnPyY-00047s-08; Mon, 13 Mar 2017 09:25:26 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Kei Kebreau Subject: Re: bug#26009: libpng-apng References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 13 Mar 2017 14:25:23 +0100 In-Reply-To: <20170313142359.r4fhaqbvme474vb3@abyayala> (ng0's message of "Mon, 13 Mar 2017 14:23:59 +0000") Message-ID: <87fuihe2bg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) ng0 skribis: >> That said, please make sure the security issues fixed in =E2=80=98libpng= /fixed=E2=80=99 >> are also fixed in libpng-apng! [...] > Do you have any advice how this could be achieved? I=E2=80=99d check whether libpng-CVE-2016-10087.patch applies to libpng-apng (it=E2=80=99s the patch that =E2=80=98libpng/fixed=E2=80=99 applies.) Going forward, if the code bases are similar enough, we may have to add a (cpe-name . "libpng") property to libpng-apng so that =E2=80=98guix lint = -c cve=E2=80=99 would report libpng=E2=80=99s vulnerabilities. HTH! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 13:24:32 2017 Received: (at 26009) by debbugs.gnu.org; 14 Mar 2017 17:24:32 +0000 Received: from localhost ([127.0.0.1]:55885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnqBU-0007gm-Er for submit@debbugs.gnu.org; Tue, 14 Mar 2017 13:24:32 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:57447 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnqBR-0007gc-74 for 26009@debbugs.gnu.org; Tue, 14 Mar 2017 13:24:29 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 1DFA1507DA0; Tue, 14 Mar 2017 18:24:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489512268; bh=sqtHZv1JpJxvtoOjr7JSPN8Q6KiwWtp1JwC51ZvfCC0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZiCdqAFkwQH4VykoiDWECI54FD1DfI6Q/NQhlbNWeFeX+MX9O6GRjnBPU7viWE5Vj gAeFHs7c9VIJtFvVXdsPG7lYATH9PlwFJZlsZzdER9IFyUOD8+Qf1Q6vgZuU3S4k2m DMZjMLYsonAqvKqzvw74CEp4Xe656GhST/FhG+Uw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR003 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489512266; bh=sqtHZv1JpJxvtoOjr7JSPN8Q6KiwWtp1JwC51ZvfCC0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fp62h06MzLFmkmqauY804QJ/l+13X/CEJU0G/f1q/MAQgZVydbn7jxgYqhTiEsovw 4aMCTWaQyJufZs5oVaAojm2ydFsyDWGFXTsCv2MiAtzyF8VROY6ZnUOPzWNlLBjFJf x+pjIRTyfhf4NQmyYQzZAHTH8ErZpZrvNhGIaL1U= To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#26009: libpng-apng In-Reply-To: <87fuihe2bg.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 13 Mar 2017 14:25:23 +0100") References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> <87fuihe2bg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Date: Tue, 14 Mar 2017 13:24:22 -0400 Message-ID: <87o9x393g9.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > ng0 skribis: > >>> That said, please make sure the security issues fixed in =E2=80=98libpn= g/fixed=E2=80=99 >>> are also fixed in libpng-apng! > > [...] > >> Do you have any advice how this could be achieved? > > I=E2=80=99d check whether libpng-CVE-2016-10087.patch applies to libpng-a= png > (it=E2=80=99s the patch that =E2=80=98libpng/fixed=E2=80=99 applies.) > > Going forward, if the code bases are similar enough, we may have to add > a (cpe-name . "libpng") property to libpng-apng so that =E2=80=98guix lin= t -c > cve=E2=80=99 would report libpng=E2=80=99s vulnerabilities. > > HTH! > > Ludo=E2=80=99. Those tips helped quite a bit! Libpng-apng now builds reproducibly. Now the only issues are the CVE patch name not beginning with "libpng-apng" and the sourceforge URL using "*.sourceforge.net/project" instead of "*.sourceforge.net/projects" (this detail leads to a 404 Error while lintin= g). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljIJ0YACgkQ5qXuPBlG eg2Q7A/8CA+FSRvZ4fXAdRxPEiZtp0Al3rbnn95VoLxJ6gLMXf8DNY9RzodbQu3U PCwjUYy359J5WsHeWLhN6/U+tc+EzHVlXSot78mQPeaTFsio1rBmJaRER2+EEoLJ RC5ECMPMG3Otq6376VUyvB9bxcA/+bEEF7UFNP1sO97GjsTCOGvQhTo1YQCilj3w MH9VEn/4tU+EkyHFqQSuMMNFIpevGit0fuphlPNuwtVSML6++EW+suerTJfK4YQO y71UXJtsA8lsrp+j+5vl7QnPn4X/h7VM9f8TgHwkV9rucExUojvVWDwRzwO5UwJv WcEKP+907it/er5kBeiP7TE3FlzDPNhYm071mJTahcbBo0+PbPE/0DKTHO3js2LO aOK5h4B8n4sqLTclGI/TTfFCGn+2jcehsKTQoItNLXTqvz8F1Sj1U90i3+dAGNlM fjcc6O0Cy6yXKqA+y4j17IGptkuO0Yn5wfVGUpoqX6dHRMPw6RQp1jqDmlhB08FL cfeEZJHlkSaZGLuC8umIORJLFnoMcyXd27DdxRcQbRgQ2hbsC+VlcXOp4ED3eL8S 9HqMrpJe0/ZB61ulA4f7KlzFYlY8gdKpKRjTUvmhJbbZjyk1fKid9l6JF1Hp/lMA MxZB3HnfWtX7gwIvvyhkY/c62EYGu3Gn8BgsK/21nin330yMhoA= =3mUE -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 16:09:02 2017 Received: (at 26009) by debbugs.gnu.org; 14 Mar 2017 20:09:02 +0000 Received: from localhost ([127.0.0.1]:56053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnskg-0006ff-67 for submit@debbugs.gnu.org; Tue, 14 Mar 2017 16:09:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnske-0006fK-6V for 26009@debbugs.gnu.org; Tue, 14 Mar 2017 16:09:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnskU-0007Tw-8I for 26009@debbugs.gnu.org; Tue, 14 Mar 2017 16:08:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnskU-0007Tn-53; Tue, 14 Mar 2017 16:08:50 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:50570 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cnskT-0007F6-JK; Tue, 14 Mar 2017 16:08:49 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Kei Kebreau Subject: Re: bug#26009: libpng-apng References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> <87fuihe2bg.fsf@gnu.org> <87o9x393g9.fsf@openmailbox.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 14 Mar 2017 21:08:46 +0100 In-Reply-To: <87o9x393g9.fsf@openmailbox.org> (Kei Kebreau's message of "Tue, 14 Mar 2017 13:24:22 -0400") Message-ID: <877f3rboz5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Kei Kebreau skribis: > Those tips helped quite a bit! Libpng-apng now builds reproducibly. Now > the only issues are the CVE patch name not beginning with > "libpng-apng" You can ignore this warning from =E2=80=98guix lint=E2=80=99. > and the sourceforge URL using "*.sourceforge.net/project" instead of > "*.sourceforge.net/projects" (this detail leads to a 404 Error while > linting). Can=E2=80=99t you change the URL as done in 998ac26a1e4f025ac75147c3497453615bb32d40? HTH! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 19:22:58 2017 Received: (at 26009) by debbugs.gnu.org; 14 Mar 2017 23:22:58 +0000 Received: from localhost ([127.0.0.1]:56105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnvmM-0002sH-Hw for submit@debbugs.gnu.org; Tue, 14 Mar 2017 19:22:58 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:59356 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnvmK-0002s9-CN for 26009@debbugs.gnu.org; Tue, 14 Mar 2017 19:22:56 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 20C5051E2AE; Wed, 15 Mar 2017 00:22:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489533775; bh=seZ5YKSP+c7bXAPx++HrDRT9OERIpDBbeWlOmI2+Gj4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=G5WKiFDBbp+pAzxXAn9+YGWnv9R7Mp8hMBa1txNW9HnVYqLAlBRbj3qtmGajbAngs /t6ymUQAcFlchhQ/PTJwyPTWkG0IozNjf95X3UVqKNgCHXavCQ/T/upEm+MzYMDiQc Q/5CkN8RDo2nVYiEgPL6BldsnSMS1TzqmAuKlE8M= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR002 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489533774; bh=seZ5YKSP+c7bXAPx++HrDRT9OERIpDBbeWlOmI2+Gj4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IXBJB04Fwe9hPG/M0IzeLi5h1OVK5LyXPeUg5TWZz7tXKhvRP/u+u4J5a9zNsIe/W bCY3N23xi66QPSzpuJyxNa7+CmfGuCERy8GyUyLSYWfSjVRh31AvVL9cpxysOJbJnU Ml+3j2dUJ+l9lbi3hZG1XOAlY+tps10b25Iiourc= To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#26009: libpng-apng References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> <87fuihe2bg.fsf@gnu.org> <87o9x393g9.fsf@openmailbox.org> <877f3rboz5.fsf@gnu.org> Date: Tue, 14 Mar 2017 19:22:39 -0400 In-Reply-To: <877f3rboz5.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 14 Mar 2017 21:08:46 +0100") Message-ID: <87innb8mv4.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Kei Kebreau skribis: > >> Those tips helped quite a bit! Libpng-apng now builds reproducibly. Now >> the only issues are the CVE patch name not beginning with >> "libpng-apng" > > You can ignore this warning from =E2=80=98guix lint=E2=80=99. > >> and the sourceforge URL using "*.sourceforge.net/project" instead of >> "*.sourceforge.net/projects" (this detail leads to a 404 Error while >> linting). > > Can=E2=80=99t you change the URL as done in > 998ac26a1e4f025ac75147c3497453615bb32d40? Yes, but libpng is already using a "mirror://sourceforge" URL. Also, the URL turned out not to be the actual issue. The real issue is that version 1.6.25 of libpng isn't present at either of the given source locations. I guess Guix has been using a local copy from my store or a cache tarball to build libpng-apng from source! > > HTH! > > Ludo=E2=80=99. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljIe0EACgkQ5qXuPBlG eg0AnBAAuMBjRxtqKi6QaeiOQGphVR/GtChwLxTTyCdvZtniAA/sx4vwQGo8m72B js97UKtgjwgNug0mcyKF7X5mlzqVaVejfyDOS7Tnojw0qYF1bAC72JTPu2pvFmZK pfWM24BnWBEc86oMKqzxlhs+S7bAO6bZG/erQMVr12A916CghD69p6+2qEW7YWTN fQkGYK32AdDeDeB+cbSlYsWMHGtzBAl7s7OqsBF3oIfuBd3C1goNAqIQiTe91EFa bIFt3XJDTiQQ0pQoz7tvN4Y7W2Tk3Iragqzel2+1AcupITgIxJoZp2ZRMBknSqSm Eckpm7yVus5kF+/5coNAw5uhvKlJym23dai2fffVHM6DLzbxojvQ3azv/VULK/jC flQWjFhHNUYA3GIx4lsOiby1V2n5AgrCmL3XN2V+gZG0ZKmto6AFVmZESbYldyTB v6dlPoRqEgFZLvs7VQYwB7U4vgmx9Bkiq/oZM1Lh+j2l8miEzPdNIoS6oTLoc7C8 SkA4sElShe7zXDFPReJpOO8/wcHatuk+GYFrLeVFDQ7J2eK5pONByPcUccBjeU28 xbZhORiwdX99/lnXfHq0QM/nmfr+dTIy3hzQBSkQD/NGKanX2lBF1iOgAopCa9s2 g9sfK/R76l/mwd+IRGWfrofi+Be3AJ/EcNt7PeYzRj0ebHJPg2Y= =5zZz -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 05:38:03 2017 Received: (at 26009) by debbugs.gnu.org; 15 Mar 2017 09:38:03 +0000 Received: from localhost ([127.0.0.1]:56293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1co5Nb-0004iG-Cc for submit@debbugs.gnu.org; Wed, 15 Mar 2017 05:38:03 -0400 Received: from fragranza.investici.org ([178.175.144.26]:54010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1co5NZ-0004hp-0v for 26009@debbugs.gnu.org; Wed, 15 Mar 2017 05:38:01 -0400 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 631C42C01FF; Wed, 15 Mar 2017 09:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1489570678; bh=gH/7wxePbcFqJz/SrukJjB5zM/Ez7EP8UIFFzu4oA/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=f69GsUTk6EhrAgF4zQckr15pNbzUKTDRwxidSqMYqLg0DCUs1LJxDo/dPWVNVIRd2 yfaBk64Qjkx75Z9eQXG9/kwrYdGpDWgL18Z5X0UEfGkUFkVvybt8nWQxKZTOQ557uJ p/rhae4TU46aJ4peW8vMnfkclz6WEM7IjQcMco9o= Date: Wed, 15 Mar 2017 10:46:39 +0000 From: ng0 To: Kei Kebreau Subject: Re: bug#26009: libpng-apng Message-ID: <20170315104639.gzcl6lbwq6ushqfs@abyayala> Mail-Followup-To: Kei Kebreau , Ludovic =?utf-8?Q?Court=C3=A8s?= , 26009@debbugs.gnu.org References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> <87fuihe2bg.fsf@gnu.org> <87o9x393g9.fsf@openmailbox.org> <877f3rboz5.fsf@gnu.org> <87innb8mv4.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87innb8mv4.fsf@openmailbox.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Kei Kebreau transcribed 1.9K bytes: > ludo@gnu.org (Ludovic Courtès) writes: > > > Kei Kebreau skribis: > > > >> Those tips helped quite a bit! Libpng-apng now builds reproducibly. Now > >> the only issues are the CVE patch name not beginning with > >> "libpng-apng" > > > > You can ignore this warning from ‘guix lint’. > > > >> and the sourceforge URL using "*.sourceforge.net/project" instead of > >> "*.sourceforge.net/projects" (this detail leads to a 404 Error while > >> linting). > > > > Can’t you change the URL as done in > > 998ac26a1e4f025ac75147c3497453615bb32d40? > > Yes, but libpng is already using a "mirror://sourceforge" URL. Also, the > URL turned out not to be the actual issue. The real issue is that > version 1.6.25 of libpng isn't present at either of the given source > locations. I guess Guix has been using a local copy from my store or a > cache tarball to build libpng-apng from source! Can you share your additions to my patch? I'd like to apply last fixes and send a new version. When I packaged it, mirror:// did not work (or at least I assumed so, this was the second reason for my mirror addition patch), so I used the full url. > > > > HTH! > > > > Ludo’. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 09:48:23 2017 Received: (at 26009) by debbugs.gnu.org; 15 Mar 2017 13:48:23 +0000 Received: from localhost ([127.0.0.1]:56431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1co9Hm-00049M-3n for submit@debbugs.gnu.org; Wed, 15 Mar 2017 09:48:23 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:39147 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1co9Hj-00049D-VB for 26009@debbugs.gnu.org; Wed, 15 Mar 2017 09:48:16 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 868F8507CA0; Wed, 15 Mar 2017 14:47:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489585664; bh=ays90ZghnqEAzzo29knruDQHEQaQFOgkMiz1MucQ9pY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=f6/jaJuFUCZgND1G33CUxsGI2LjLVPCtbfbFm3oOH+EXJXkjx76ev+YvRE8K7oSnm 98IkebBhqeKMbK4WTPGtwsEUiP7NOWHz4WqMlEqsImlLBRO0JMmwggsqMEU4Kos7hx R28yPyq88c0B1JrcGEvl0CqZNPheA7oqS1M+lnKA= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR003 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489585653; bh=ays90ZghnqEAzzo29knruDQHEQaQFOgkMiz1MucQ9pY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=I8wGI3snsAtp2u5SLauCBuiynECXXcSnSg553a32Le193ExJLhLIMDXEVw4Rr2GCf FxUiQnyJZFbLmQxZazNydxDl02Pz9R8OSNRyY52w9CLOt3gX1BNmCs7zSmTYFSa1GU otmnVPS9KD3BntIZVoB+oD4xFEjmmGD4dOsffCrM= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#26009: libpng-apng References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> <87fuihe2bg.fsf@gnu.org> <87o9x393g9.fsf@openmailbox.org> <877f3rboz5.fsf@gnu.org> <87innb8mv4.fsf@openmailbox.org> <20170315104639.gzcl6lbwq6ushqfs@abyayala> Date: Wed, 15 Mar 2017 09:46:57 -0400 In-Reply-To: <20170315104639.gzcl6lbwq6ushqfs@abyayala> (ng0's message of "Wed, 15 Mar 2017 10:46:39 +0000") Message-ID: <87a88m8xf2.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ng0 writes: > Kei Kebreau transcribed 1.9K bytes: >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>=20 >> > Kei Kebreau skribis: >> > >> >> Those tips helped quite a bit! Libpng-apng now builds reproducibly. N= ow >> >> the only issues are the CVE patch name not beginning with >> >> "libpng-apng" >> > >> > You can ignore this warning from =E2=80=98guix lint=E2=80=99. >> > >> >> and the sourceforge URL using "*.sourceforge.net/project" instead of >> >> "*.sourceforge.net/projects" (this detail leads to a 404 Error while >> >> linting). >> > >> > Can=E2=80=99t you change the URL as done in >> > 998ac26a1e4f025ac75147c3497453615bb32d40? >>=20 >> Yes, but libpng is already using a "mirror://sourceforge" URL. Also, the >> URL turned out not to be the actual issue. The real issue is that >> version 1.6.25 of libpng isn't present at either of the given source >> locations. I guess Guix has been using a local copy from my store or a >> cache tarball to build libpng-apng from source! > > Can you share your additions to my patch? I'd like to apply last fixes > and send a new version. > When I packaged it, mirror:// did not work (or at least I assumed so, > this was the second reason for my mirror addition patch), so I used the > full url. > Sure thing! See the attached file. >> > >> > HTH! >> > >> > Ludo=E2=80=99. --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-Add-libpng-apng.patch Content-Transfer-Encoding: quoted-printable From=2076e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001 From: ng0 Date: Tue, 10 Jan 2017 20:49:30 +0000 Subject: [PATCH] gnu: Add libpng-apng. To: guix-patches@gnu.org * gnu/packages/image.scm (libpng-apng): New variable. Signed-off-by: Kei Kebreau =2D-- gnu/packages/image.scm | 52 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index 53ed69a84..f348a61c9 100644 =2D-- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -14,6 +14,7 @@ ;;; Copyright =C2=A9 2016 Eric Bavier ;;; Copyright =C2=A9 2016 Arun Isaac ;;; Copyright =C2=A9 2016 Kei Kebreau +;;; Copyright =C2=A9 2017 ng0 ;;; ;;; This file is part of GNU Guix. ;;; @@ -98,6 +99,57 @@ library. It supports almost all PNG features and is ext= ensible.") (inherit (package-source libpng)) (patches (search-patches "libpng-CVE-2016-10087.patch")))))) =20 +(define-public libpng-apng + (package + (inherit libpng) + (replacement #f) ;libpng's replacement doesn't apply here + (name "libpng-apng") + (version (package-version libpng)) + (source + (origin + (inherit (package-source libpng)) + (patches (search-patches "libpng-CVE-2016-10087.patch")))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-apng + (lambda* (#:key inputs #:allow-other-keys) + (define (apply-patch file) + (zero? (system* "patch" "-p1" "--force" + "--input" file))) + (let ((apng.gz (assoc-ref inputs "apng"))) + (format #t "Applying APNG patch '~a'...~%" + apng.gz) + (system (string-append "gunzip < " apng.gz " > the-patch")) + (and (apply-patch "the-patch") + (for-each apply-patch + (find-files "\\.patch")))) + #t)) + (add-before 'configure 'no-checks + (lambda _ + (substitute* "Makefile.in" + (("^scripts/symbols.chk") "") + (("check: scripts/symbols.chk") "")) + (zero? (system* "libtool")) + #t))))) + (inputs + `(("apng" ,(origin + (method url-fetch) + (uri + (string-append "mirror://sourceforge/libpng-apng/libpng= 16/" + version "/libpng-" version "-apng.patch.= gz")) + (sha256 + (base32 + "026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5"= )))))) + (native-inputs + `(("libtool" ,libtool))) + (synopsis "APNG patch for libpng") + (description + "APNG (Animated Portable Network Graphics) is an unofficial +extension of the APNG (Portable Network Graphics) format. +APNG patch provides APNG support to libpng.") + (home-page "https://sourceforge.net/projects/libpng-apng/"))) + (define-public libpng-1.2 (package (inherit libpng) =2D-=20 2.12.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljJRdIACgkQ5qXuPBlG eg3NehAAkuJoGvvThAkpAXUjm13O4vADbGoEVTlUm5zqCnHasb8PGr2YQWf5s9+y 86DxbcefYiI2ImFjM5wSXvFz+Sn7FtIW4S3M7+DBxsEWmGgI0f0CPDxdlwrI1NO5 9TeQRneP3bcUwlt8fk0Tx2QZ4I6I31rlX6hIob+CuyAwS0r+2aq+xgExEP85e2Uh aJecvRAcsxh6uqCEi36qf3px7RO4xCiP4pZvrUNCBKR8PI1huGnhgxH4l7DW0wRP ZxL75WmRWRqme//WfR5mY4TGFCt9Nnn357uMIkw6BUPiWtDb5ub1flvvQxCsPyUn C9nFs1pv+Pdru8E6WkImQX43lukX8yEk4cotZ89lBDe4gDHQrag5rStUscfwuY5h au18Dx80AiQVCj5CppeEASeGrD2e9R0UIoCcSnwGmNwO9/2F7LfmGSKQPbUFtzPf O33yt4YuvUs/aqKzQd1ohhd7t0wEFOIvWled/Z1dknfN4jo0fKKDh6CIdicdnTZJ 00lI1CalZ6hovkg2TPXutnxVBs4fD4YZaci1fnS8OzB55VVmIgAt0/vhi0yhPRKh /XQRFZt8eZBx4t4COBb1R4ge3wyw1yzsdzNucrkRjymm4zthtXgNLbZUqv+fhE4S YyiqX98UftOourRZZu/g4YCPHLkp/pqR4tgCiSLNqXfnoASIWP8= =Hfnb -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 04:03:10 2017 Received: (at 26009) by debbugs.gnu.org; 16 Mar 2017 08:03:10 +0000 Received: from localhost ([127.0.0.1]:57919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coQNJ-0003fg-RF for submit@debbugs.gnu.org; Thu, 16 Mar 2017 04:03:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coQNH-0003fS-9u for 26009@debbugs.gnu.org; Thu, 16 Mar 2017 04:03:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coQN4-0001tL-E2 for 26009@debbugs.gnu.org; Thu, 16 Mar 2017 04:03:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coQN4-0001tH-AU; Thu, 16 Mar 2017 04:02:54 -0400 Received: from [193.50.110.167] (port=51760 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1coQN3-0002pF-Ow; Thu, 16 Mar 2017 04:02:54 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Kei Kebreau Subject: Re: bug#26009: libpng-apng References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> <87fuihe2bg.fsf@gnu.org> <87o9x393g9.fsf@openmailbox.org> <877f3rboz5.fsf@gnu.org> <87innb8mv4.fsf@openmailbox.org> <20170315104639.gzcl6lbwq6ushqfs@abyayala> <87a88m8xf2.fsf@openmailbox.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 16 Mar 2017 09:02:51 +0100 In-Reply-To: <87a88m8xf2.fsf@openmailbox.org> (Kei Kebreau's message of "Wed, 15 Mar 2017 09:46:57 -0400") Message-ID: <87inn93az8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Good morning! Kei Kebreau skribis: > From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001 > From: ng0 > Date: Tue, 10 Jan 2017 20:49:30 +0000 > Subject: [PATCH] gnu: Add libpng-apng. > To: guix-patches@gnu.org > > * gnu/packages/image.scm (libpng-apng): New variable. > > Signed-off-by: Kei Kebreau [...] > + (add-before 'configure 'no-checks > + (lambda _ > + (substitute* "Makefile.in" > + (("^scripts/symbols.chk") "") > + (("check: scripts/symbols.chk") "")) > + (zero? (system* "libtool")) > + #t))))) Do you really want to run =E2=80=98libtool=E2=80=99 here? I think that doe= sn=E2=80=99t have any effect: --8<---------------cut here---------------start------------->8--- $ libtool Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]... Try 'libtool --help' for more information. libtool: error: you must specify a MODE --8<---------------cut here---------------end--------------->8--- If there=E2=80=99s nothing else blocking this patch, I think you can go ahe= ad. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 14:39:30 2017 Received: (at 26009) by debbugs.gnu.org; 16 Mar 2017 18:39:30 +0000 Received: from localhost ([127.0.0.1]:59251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coaJ7-0000Fd-VR for submit@debbugs.gnu.org; Thu, 16 Mar 2017 14:39:30 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:36466 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coaJ6-0000FV-2i for 26009@debbugs.gnu.org; Thu, 16 Mar 2017 14:39:28 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 148FD50C706; Thu, 16 Mar 2017 19:39:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489689567; bh=VI2WJvgyNQhotIsl9hGpRxzRsgLnlWsmzTgi+2Bbw3s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fk8C98TLKFNz3C9BEM9Txkg7tFkKss8fI8EBHx+nhF1zxkE9MLzUJ05Gch/mFFjEy YL3gwnWhNNELpFWgyq4iXMubSDgY9ed2wLPsJG2EhBznQO8uHv+dmlQPswHS4zf3o/ E0qXng+keLdWOBg/mvzPZVwdb0cY2/z2nyBmZvP0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR003 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489689563; bh=VI2WJvgyNQhotIsl9hGpRxzRsgLnlWsmzTgi+2Bbw3s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S57cirCjegQGtqZCXq3dsFkK78yiVSnnxxLa2qHizO5w3oN+EVur2Xwna63m0yR7H zwu8CsSi6hbkrva5BFc8yAVTW6vUPndKppNmlexZG2IFhT4+TKfoi3sK39r+XA6VRf DXvkwD8fXe7wHnh9u9s+1wxbnE1o5fY4KWrhW6sk= To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#26009: libpng-apng References: <20170307121931.k5mec7wx57xsj3xa@abyayala> <87lgsa9boj.fsf@openmailbox.org> <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> <87fuihe2bg.fsf@gnu.org> <87o9x393g9.fsf@openmailbox.org> <877f3rboz5.fsf@gnu.org> <87innb8mv4.fsf@openmailbox.org> <20170315104639.gzcl6lbwq6ushqfs@abyayala> <87a88m8xf2.fsf@openmailbox.org> <87inn93az8.fsf@gnu.org> Date: Thu, 16 Mar 2017 14:39:16 -0400 In-Reply-To: <87inn93az8.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 16 Mar 2017 09:02:51 +0100") Message-ID: <87shmd6p7v.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009 Cc: contact.ng0@cryptolab.net, 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Good morning! > Howdy! :-) > Kei Kebreau skribis: > >> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001 >> From: ng0 >> Date: Tue, 10 Jan 2017 20:49:30 +0000 >> Subject: [PATCH] gnu: Add libpng-apng. >> To: guix-patches@gnu.org >> >> * gnu/packages/image.scm (libpng-apng): New variable. >> >> Signed-off-by: Kei Kebreau > > [...] > >> + (add-before 'configure 'no-checks >> + (lambda _ >> + (substitute* "Makefile.in" >> + (("^scripts/symbols.chk") "") >> + (("check: scripts/symbols.chk") "")) >> + (zero? (system* "libtool")) >> + #t))))) > > Do you really want to run =E2=80=98libtool=E2=80=99 here? I think that d= oesn=E2=80=99t have any > effect: > > $ libtool > Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]... > Try 'libtool --help' for more information. > libtool: error: you must specify a MODE > ng0 had some adjustments to make to the patch for sending it upstream, so I'm waiting for a response. Perhaps removing this libtool execution is one of them. > If there=E2=80=99s nothing else blocking this patch, I think you can go a= head. > > Thanks, > Ludo=E2=80=99. Thank you. I'll push it when I get the okay from ng0. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 15:49:57 2017 Received: (at 26009) by debbugs.gnu.org; 16 Mar 2017 19:49:57 +0000 Received: from localhost ([127.0.0.1]:59287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cobPI-0001zD-S3 for submit@debbugs.gnu.org; Thu, 16 Mar 2017 15:49:57 -0400 Received: from fragranza.investici.org ([178.175.144.26]:39682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cobPG-0001z2-Cw for 26009@debbugs.gnu.org; Thu, 16 Mar 2017 15:49:55 -0400 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 537FF2C02E5; Thu, 16 Mar 2017 19:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1489693792; bh=6w0Niksrfb48YLzvZ8tKntuHYJPFumirp8Qm6VrlBVg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Ubcuvud3SYvmk5ud7L4ROzcBlzzcUyIL34DbV+LJQCUzrSQ5gWIHTBU4lkeRKf+tw a398gf8KEMgJCAPwumP3RCBlhOtcIhoI3eetp9V/YgBfUbFR3X7MN5OV1WgBXaHmZr iCsZ9Eqm8yhRDgYTltOE07zAigp0xi1/NBBe10nI= Date: Thu, 16 Mar 2017 20:58:34 +0000 From: ng0 To: Kei Kebreau Subject: Re: bug#26009: libpng-apng Message-ID: <20170316205834.ktmdh3ojiaqyz2md@abyayala> Mail-Followup-To: Kei Kebreau , Ludovic =?utf-8?Q?Court=C3=A8s?= , 26009@debbugs.gnu.org References: <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> <87fuihe2bg.fsf@gnu.org> <87o9x393g9.fsf@openmailbox.org> <877f3rboz5.fsf@gnu.org> <87innb8mv4.fsf@openmailbox.org> <20170315104639.gzcl6lbwq6ushqfs@abyayala> <87a88m8xf2.fsf@openmailbox.org> <87inn93az8.fsf@gnu.org> <87shmd6p7v.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87shmd6p7v.fsf@openmailbox.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Kei Kebreau transcribed 1.3K bytes: > ludo@gnu.org (Ludovic Courtès) writes: > > > Good morning! > > > > Howdy! :-) > > > Kei Kebreau skribis: > > > >> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001 > >> From: ng0 > >> Date: Tue, 10 Jan 2017 20:49:30 +0000 > >> Subject: [PATCH] gnu: Add libpng-apng. > >> To: guix-patches@gnu.org > >> > >> * gnu/packages/image.scm (libpng-apng): New variable. > >> > >> Signed-off-by: Kei Kebreau > > > > [...] > > > >> + (add-before 'configure 'no-checks > >> + (lambda _ > >> + (substitute* "Makefile.in" > >> + (("^scripts/symbols.chk") "") > >> + (("check: scripts/symbols.chk") "")) > >> + (zero? (system* "libtool")) > >> + #t))))) > > > > Do you really want to run ‘libtool’ here? I think that doesn’t have any > > effect: > > > > $ libtool > > Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]... > > Try 'libtool --help' for more information. > > libtool: error: you must specify a MODE > > > > ng0 had some adjustments to make to the patch for sending it upstream, > so I'm waiting for a response. Perhaps removing this libtool execution > is one of them. On the one hand I wanted to check on this, but on the other hand it looks like you have already solved most or all of the problems? I decided to take an almost-vacation for 3 weeks, just plan and document and maybe add some thoughts to patches which are open, minimal work. If it looks good for you and it works, please gp ahead (and add the Co-authored-by line). Thanks for your fixes on this :) > > If there’s nothing else blocking this patch, I think you can go ahead. > > > > Thanks, > > Ludo’. > > Thank you. I'll push it when I get the okay from ng0. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 11:38:19 2017 Received: (at 26009) by debbugs.gnu.org; 17 Mar 2017 15:38:19 +0000 Received: from localhost ([127.0.0.1]:32775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cotxH-0001s3-1p for submit@debbugs.gnu.org; Fri, 17 Mar 2017 11:38:19 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:45461 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cotxE-0001rp-5O for 26009@debbugs.gnu.org; Fri, 17 Mar 2017 11:38:12 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id E8FDF513883; Fri, 17 Mar 2017 16:38:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489765090; bh=jdiK0c2FY+DEPodHlyIP2gRsu/FQpUFmXEFnoiWQ7fk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=vGU7S/4gDSVZ/v8proEbk4YERmJLb5c0hgly7wdw+Y1F+iVUhs2Q5uWEqwSzfe05D tbeaw53U8dx6XGI9i7A5A+szhLoStbBmWaQZn01QhHeCCT373pg4XFHXp7SFxACnPn wa/SIRA9WSjRutzG0ZQ90R9WbmmXqTVsKey/msrg= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR003 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489765088; bh=jdiK0c2FY+DEPodHlyIP2gRsu/FQpUFmXEFnoiWQ7fk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kbKvTCDoYMoazLIE/M639UaCShsp9+wtVVBLxsSOVqGtLnUTaXvaaiHZk2MtbMWLs DGiprwKYWixwJ4XvCrL02p0vZ0qBDvpSK0144MAekYXiItc9fiJpRtxgr4tNu0gpag L6p2bnaOpuK1Rt3beHasG4hKpZ4nUiZ+W/JCX1dg= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#26009: libpng-apng References: <874lyxfhqg.fsf@gnu.org> <20170313142359.r4fhaqbvme474vb3@abyayala> <87fuihe2bg.fsf@gnu.org> <87o9x393g9.fsf@openmailbox.org> <877f3rboz5.fsf@gnu.org> <87innb8mv4.fsf@openmailbox.org> <20170315104639.gzcl6lbwq6ushqfs@abyayala> <87a88m8xf2.fsf@openmailbox.org> <87inn93az8.fsf@gnu.org> <87shmd6p7v.fsf@openmailbox.org> <20170316205834.ktmdh3ojiaqyz2md@abyayala> Date: Fri, 17 Mar 2017 11:37:59 -0400 In-Reply-To: <20170316205834.ktmdh3ojiaqyz2md@abyayala> (ng0's message of "Thu, 16 Mar 2017 20:58:34 +0000") Message-ID: <87h92r7w2w.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009 Cc: 26009@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ng0 writes: > Kei Kebreau transcribed 1.3K bytes: >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>=20 >> > Good morning! >> > >>=20 >> Howdy! :-) >>=20 >> > Kei Kebreau skribis: >> > >> >> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001 >> >> From: ng0 >> >> Date: Tue, 10 Jan 2017 20:49:30 +0000 >> >> Subject: [PATCH] gnu: Add libpng-apng. >> >> To: guix-patches@gnu.org >> >> >> >> * gnu/packages/image.scm (libpng-apng): New variable. >> >> >> >> Signed-off-by: Kei Kebreau >> > >> > [...] >> > >> >> + (add-before 'configure 'no-checks >> >> + (lambda _ >> >> + (substitute* "Makefile.in" >> >> + (("^scripts/symbols.chk") "") >> >> + (("check: scripts/symbols.chk") "")) >> >> + (zero? (system* "libtool")) >> >> + #t))))) >> > >> > Do you really want to run =E2=80=98libtool=E2=80=99 here? I think tha= t doesn=E2=80=99t have any >> > effect: >> > >> > $ libtool >> > Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]... >> > Try 'libtool --help' for more information. >> > libtool: error: you must specify a MODE >> > >>=20 >> ng0 had some adjustments to make to the patch for sending it upstream, >> so I'm waiting for a response. Perhaps removing this libtool execution >> is one of them. > > On the one hand I wanted to check on this, but on the other hand it > looks like you have already solved most or all of the problems? > I decided to take an almost-vacation for 3 weeks, just plan and document > and maybe add some thoughts to patches which are open, minimal work. > If it looks good for you and it works, please gp ahead (and add the > Co-authored-by line). > > Thanks for your fixes on this :) > You're welcome. Thanks to Ludovic as well for pointing out the replacement issue. >> > If there=E2=80=99s nothing else blocking this patch, I think you can g= o ahead. >> > >> > Thanks, >> > Ludo=E2=80=99. >>=20 >> Thank you. I'll push it when I get the okay from ng0. Pushed to master! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljMAtcACgkQ5qXuPBlG eg1mAA/6AgNVFef0QuuB5urvzUypj/OqZkoHCNcjggXdTG/Zim63nMaVhMyEqHI9 bt5KLkC1PdeTEFDH/V6C7I5B+BpSnmF/zUA9N0kSbBMofgCYQTOOgK3yPqRB+iT5 7VGuJEQ9+YwKxxkELk+z41cmd0fmpqPsshA7MXeihdqrgwx56XGPeb8KcQJF3hJn qQtYXfmtL9MXRy5OMFN/rcFDuiOpeHtrnpqwL/m+MT7/bgE3tYrFp6ZSjzCA3EiN HD/NbC/DNFd7CpdyH4ejOQU0elEINjV/XPGdCEQv31wPuutVdoKxWc59qRQyHTxn zFGA0qxDlqEbXGlANJFZI0X2BJITwpX7d8faugWuoR8CgfbZ2DqNUQTelAlFNQOj DzjlUkHnfccaMx5nvB+CGPVICL8x/WkC40WcuusHdxcUMTDZaNKoAOghd1+Q14CS jHkeJ3m7G9d/2mHf6z/TIjPVMl+8vu1+HJM7NNZg907JZ4shMQc/2s5zQ48hVwI3 a/Z0CGT3nJiRih3Vq/B7yye2X06j4sn+aSxe+4QVEIiRKWxNsNm9dvdMmxsPVCjC YvR/CDFVe65D3AcC9yCkOTYXtdn+jF32tZXJJqdlvxq5+s26wEHwIMgYrVjEJvnj 2+5CqVWwoH/1I09lQUZBar5qlZ4YDuGjExAooRofAQ1zlZPes3I= =VH/a -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 07:33:14 2017 Received: (at 26009-done) by debbugs.gnu.org; 23 Mar 2017 11:33:14 +0000 Received: from localhost ([127.0.0.1]:40207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cr0zO-0001M6-9r for submit@debbugs.gnu.org; Thu, 23 Mar 2017 07:33:14 -0400 Received: from fragranza.investici.org ([178.175.144.26]:37524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cr0zM-0001Ly-HB for 26009-done@debbugs.gnu.org; Thu, 23 Mar 2017 07:33:09 -0400 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 099D02C013D; Thu, 23 Mar 2017 11:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1490268787; bh=+R5FAj0OvYQTBj+YeORTB2JWsvgGYsBwX5ly4QVld88=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=svTAx/liM5xMHJO0lchXc7vv6II4sxKuH2wn6x+6ZYYP6PqPAOdkxznFxXBAbIQW3 0pqYXi+F1AXBbW/R5SYlTbJNDtf5RJxDDuF9kSIq0B0zIO7j4pRckGMOEFppijACtk N+3MVUqsVlsSGt0zZ19YfDjruWAlFpysB5ydpAok= Date: Thu, 23 Mar 2017 11:36:05 +0000 From: ng0 To: Kei Kebreau Subject: Re: bug#26009: libpng-apng Message-ID: <20170323113605.kstgmtm6kmz2yjom@abyayala> Mail-Followup-To: Kei Kebreau , Ludovic =?utf-8?Q?Court=C3=A8s?= , 26009-done@debbugs.gnu.org References: <87fuihe2bg.fsf@gnu.org> <87o9x393g9.fsf@openmailbox.org> <877f3rboz5.fsf@gnu.org> <87innb8mv4.fsf@openmailbox.org> <20170315104639.gzcl6lbwq6ushqfs@abyayala> <87a88m8xf2.fsf@openmailbox.org> <87inn93az8.fsf@gnu.org> <87shmd6p7v.fsf@openmailbox.org> <20170316205834.ktmdh3ojiaqyz2md@abyayala> <87h92r7w2w.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h92r7w2w.fsf@openmailbox.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26009-done Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 26009-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Kei Kebreau transcribed 3.1K bytes: > ng0 writes: > > > Kei Kebreau transcribed 1.3K bytes: > >> ludo@gnu.org (Ludovic Courtès) writes: > >> > >> > Good morning! > >> > > >> > >> Howdy! :-) > >> > >> > Kei Kebreau skribis: > >> > > >> >> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001 > >> >> From: ng0 > >> >> Date: Tue, 10 Jan 2017 20:49:30 +0000 > >> >> Subject: [PATCH] gnu: Add libpng-apng. > >> >> To: guix-patches@gnu.org > >> >> > >> >> * gnu/packages/image.scm (libpng-apng): New variable. > >> >> > >> >> Signed-off-by: Kei Kebreau > >> > > >> > [...] > >> > > >> >> + (add-before 'configure 'no-checks > >> >> + (lambda _ > >> >> + (substitute* "Makefile.in" > >> >> + (("^scripts/symbols.chk") "") > >> >> + (("check: scripts/symbols.chk") "")) > >> >> + (zero? (system* "libtool")) > >> >> + #t))))) > >> > > >> > Do you really want to run ‘libtool’ here? I think that doesn’t have any > >> > effect: > >> > > >> > $ libtool > >> > Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]... > >> > Try 'libtool --help' for more information. > >> > libtool: error: you must specify a MODE > >> > > >> > >> ng0 had some adjustments to make to the patch for sending it upstream, > >> so I'm waiting for a response. Perhaps removing this libtool execution > >> is one of them. > > > > On the one hand I wanted to check on this, but on the other hand it > > looks like you have already solved most or all of the problems? > > I decided to take an almost-vacation for 3 weeks, just plan and document > > and maybe add some thoughts to patches which are open, minimal work. > > If it looks good for you and it works, please gp ahead (and add the > > Co-authored-by line). > > > > Thanks for your fixes on this :) > > > > You're welcome. Thanks to Ludovic as well for pointing out the > replacement issue. > > >> > If there’s nothing else blocking this patch, I think you can go ahead. > >> > > >> > Thanks, > >> > Ludo’. > >> > >> Thank you. I'll push it when I get the okay from ng0. > > Pushed to master! Thanks. closed From unknown Sat Sep 20 04:26:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 Apr 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator