From unknown Sat Sep 20 13:26:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25995 <25995@debbugs.gnu.org> To: bug#25995 <25995@debbugs.gnu.org> Subject: Status: 26.0.50; Mismatch between documented and actual behaviour of icomplete Reply-To: bug#25995 <25995@debbugs.gnu.org> Date: Sat, 20 Sep 2025 20:26:29 +0000 retitle 25995 26.0.50; Mismatch between documented and actual behaviour of = icomplete reassign 25995 emacs submitter 25995 Alexis severity 25995 minor tag 25995 confirmed fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 06 06:12:40 2017 Received: (at submit) by debbugs.gnu.org; 6 Mar 2017 11:12:40 +0000 Received: from localhost ([127.0.0.1]:41773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckqZE-0006Rj-DP for submit@debbugs.gnu.org; Mon, 06 Mar 2017 06:12:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckqZC-0006RV-Gb for submit@debbugs.gnu.org; Mon, 06 Mar 2017 06:12:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckqZ6-0003xX-0y for submit@debbugs.gnu.org; Mon, 06 Mar 2017 06:12:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56479) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ckqZ5-0003xR-TE for submit@debbugs.gnu.org; Mon, 06 Mar 2017 06:12:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckqZ4-0002Wh-8P for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2017 06:12:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckqZ0-0003wi-Ui for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2017 06:12:30 -0500 Received: from mail-pg0-x233.google.com ([2607:f8b0:400e:c05::233]:36760) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckqZ0-0003wT-OU for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2017 06:12:26 -0500 Received: by mail-pg0-x233.google.com with SMTP id 187so11530169pgb.3 for ; Mon, 06 Mar 2017 03:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=HIZLeZ0/XZalAn7sQDbK1fnMi7eekmK+/hgSZVk931M=; b=e709axyxr8ARPgohI9TS2eD4vTj9K9k9suZGelIKdO18fEazCccIejLEn667YotZK4 Lxuli5GuHfXgpZ5zihmv6yj3ZWPP77fNIKjeKygTvMXy6ZNyrex/NBk0WChG608DSoXQ Tv833qhfyZoEbNd6Fconp9a4scvdEIOBLMLe1X97lA7WOyrYdf3p8thTNrzi/MzSvwbY vqlJX0zTBn8odrxv3/EnkrK1TaIULoHBz967m+YAGxnLyCSEgBUgXBpkXP6kFUqHK9Mj PgYAB9HgJnc2G0T0U8uv+g32VV4hyIjDu4g5OJBdtnWiuqf31b+YO7PJjUodgGPLKiJu n+jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=HIZLeZ0/XZalAn7sQDbK1fnMi7eekmK+/hgSZVk931M=; b=myJ1tVdT4awPC2AlWmMo8gYoIDwwFXF3SsfxNB3HHhb3D4nMhOuDnJCjEgQg1L27gi ttZa9BYOodMspEpniz26PuLAiNMt6ABPeagUGo/hPUs4SKug4O3KxTecW7tp/+gEoyAL wNl6cKtQZAoi6Y9wHZLwqfwkloUNKfm9gA8FkWM6N6KEV/Z769eOsH/eKEo7XOWCVrnx X66rnUbee6BBqzuXook2cHN5LmRPpf5YdMi0gTf12D/c7CDGYzLmy/T94wqUlWLo8lyS 5tWTHCn0rNoGuTgGwV1BK1964L1yMYCBTEsCo4rqctY4JaOwlrbgHMGFmQ3xbdxOFp0l pxjg== X-Gm-Message-State: AMke39nylAeH9jmhEMTkATOJwib5U7qW+znzeGXdrLFCIO4/Tq17ijDyw1y5cAAskj4y6g== X-Received: by 10.99.113.11 with SMTP id m11mr19415985pgc.142.1488798744146; Mon, 06 Mar 2017 03:12:24 -0800 (PST) Received: from localhost (58-7-128-128.dyn.iinet.net.au. [58.7.128.128]) by smtp.gmail.com with ESMTPSA id o8sm4175358pfk.64.2017.03.06.03.12.22 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Mar 2017 03:12:23 -0800 (PST) User-agent: mu4e 0.9.19; emacs 26.0.50 From: Alexis To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Mismatch between documented and actual behaviour of icomplete Date: Mon, 06 Mar 2017 22:12:20 +1100 Message-ID: <87a88yveuj.fsf@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * Create a test directory containing three files: '1', '2', '3'. * Change to that directory and run emacs -Q. * M-x icomplete-mode * C-x C-f * C-j Section 19.7.2 of the Emacs manual states: "At any time, you can type ‘C-j’ to select the first completion in the list." Reading left-to-right, '1' is the first item in the list. So C-j should visit that file. Instead, it visits '3'. -- In GNU Emacs 26.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.8) of 2017-02-27 built on debian Repository revision: 8db75f0ef9ad821bab0a2613bb8e549edbf14eb6 Windowing system distributor 'The X.Org Foundation', version 11.0.11901000 System Description: Debian GNU/Linux 9.0 (stretch) Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Icomplete mode enabled Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LC_MESSAGES: C value of $LC_TIME: en_AU.UTF-8 value of $LANG: en_AU.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: icomplete-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message puny seq byte-opt subr-x gv bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cus-start cus-load icomplete time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 103412 6170) (symbols 48 21091 1) (miscs 40 47 129) (strings 32 19810 4401) (string-bytes 1 604390) (vectors 16 14041) (vector-slots 8 478821 4680) (floats 8 50 66) (intervals 56 206 1) (buffers 976 11)) From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 09 18:24:11 2017 Received: (at 25995) by debbugs.gnu.org; 9 Mar 2017 23:24:11 +0000 Received: from localhost ([127.0.0.1]:48193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cm7Pn-0006Ja-7h for submit@debbugs.gnu.org; Thu, 09 Mar 2017 18:24:11 -0500 Received: from mail-io0-f178.google.com ([209.85.223.178]:35522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cm7Pm-0006JH-6A; Thu, 09 Mar 2017 18:24:10 -0500 Received: by mail-io0-f178.google.com with SMTP id z13so38912416iof.2; Thu, 09 Mar 2017 15:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5UNFpzd+tAE7GYrB7g6tEDB7e+fRfp4/MIQrHjeLYeQ=; b=s/fuM9BBbUhFeijuqQPV4ZmZp8qI2gBnVpkZaXjqVV2OcWEfDSi6p/9QSGtPlhj2x+ InMalwpT532eleVns++RlQFNkmQLNrh2LmYtyChZZb3kT6zaPhzo39RB38EDbmFj4O76 0snOBVcSOpzajPQNpctW0s0optt5Zj9wDuz18vdrLs89qNp/t/mDzl8Us6MjZG7d7rGk IEtZWbFMdoczunhZfhMiw9R3iaK0NPuehkNYYwJ3JXvPT67sTk3/8y21bHcvgU4+0XTn bpH8NT24OTDKoaH13DpYp/bcTFVBuTU0T667x/rKHQUCI9pXtjxpu0Xe+J3kKvMhlo6+ ReSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=5UNFpzd+tAE7GYrB7g6tEDB7e+fRfp4/MIQrHjeLYeQ=; b=sk5d7OlgQEFDvjCMDq65gVmltROAgIIa6cgcsisXDlbnoqKplVoGfrD5mXEFeOKp+Y 5xWcSgHQRneaNzl22Vnkfs/TPUuklYbW4FJouUZkJoGoIZDbS8ydveR/CuRd1wtwrXHO nLVSNXdkjDOHZdPb19qpilQkOyceYdwwzcIzM/8ZhOPQddeZ0OAEobclEwotTkrBnkts C7l2gmcC2l877/Bee1NBf4JqGWc2oY6OC6MI3Xmje3oH2EJOPvY5usSr0kTFuvviEd3m 8zePpLTDdS2JqWsrcb5HD2Y84oVR22tBxanCr5E6I+c5nVxQPDT6k5qKSj7BsIdrDeSd soZw== X-Gm-Message-State: AMke39kSsPUbIgK6Lc8/g6zS7cJkrQU2YebxL026EfalV6Q0CfuGhy3ZdzZTB8IO51kzAw== X-Received: by 10.107.46.163 with SMTP id u35mr15109745iou.196.1489101844581; Thu, 09 Mar 2017 15:24:04 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 62sm635405itl.1.2017.03.09.15.24.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Mar 2017 15:24:04 -0800 (PST) From: npostavs@users.sourceforge.net To: Alexis Subject: Re: bug#25995: 26.0.50; Mismatch between documented and actual behaviour of icomplete References: <87a88yveuj.fsf@debian> Date: Thu, 09 Mar 2017 18:25:21 -0500 In-Reply-To: <87a88yveuj.fsf@debian> (Alexis's message of "Mon, 06 Mar 2017 22:12:20 +1100") Message-ID: <87shmm823i.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 25995 Cc: 25995@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.8 (/) tags 25995 confirmed quit Alexis writes: > * Create a test directory containing three files: '1', '2', '3'. > > * Change to that directory and run emacs -Q. > > * M-x icomplete-mode > > * C-x C-f > > * C-j > > Section 19.7.2 of the Emacs manual states: > > "At any time, you can type =E2=80=98C-j=E2=80=99 to select the first comp= letion in the > list." > > Reading left-to-right, '1' is the first item in the list. So C-j > should visit that file. Instead, it visits '3'. This seems to have been introduced by [1: 65797b1]. I guess completion-pcm--filename-try-filter should not reverse its input? 1: 2016-04-28 19:31:43 +0200 65797b1d75e9f608ffd50fd88be47a854b143bb1 Make icomplete respect `completion-ignored-extensions' --- i/lisp/minibuffer.el +++ w/lisp/minibuffer.el @@ -3257,7 +3257,7 @@ completion-pcm--filename-try-filter "\\)\\'"))) (dolist (f all) (unless (string-match-p re f) (push f try))) - (or try all)))) + (or (nreverse try) all)))) =20 =20 (defun completion-pcm--merge-try (pattern all prefix suffix) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 20:19:27 2017 Received: (at 25995) by debbugs.gnu.org; 19 Jun 2017 00:19:27 +0000 Received: from localhost ([127.0.0.1]:55460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMkPf-0005VG-2P for submit@debbugs.gnu.org; Sun, 18 Jun 2017 20:19:27 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMkPd-0005V2-FX for 25995@debbugs.gnu.org; Sun, 18 Jun 2017 20:19:25 -0400 Received: by mail-wm0-f42.google.com with SMTP id d64so14924870wmf.1 for <25995@debbugs.gnu.org>; Sun, 18 Jun 2017 17:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=49qaqMdrBcj2mU84jKAP+Y0tov3oD0nk/O30siIAc9w=; b=NvJvmVkgOWeusEIiU2yjd3Rx0jhLtN/7N7zwKqCw0EgriFUkiAz7YNBJvGmiqjyclu frJxaEGtTogUVW2/PSn2CuJ5dnL8QZ6+Z/IrlTgFFrS6xZkQLJpRNq0k2iVW4FnYlKGI GkxW2vKppZYlse5WVgsgkatQuodqYfwjfTXcZzVUPjjMhyUSCfeBx/5i+4D1N3QGgrRD xTSvEB9ocKzXzKMthifQf/9+mhQl579uHlSoAWk9VQ+9/hcLu3LpYxAXdCDnURnlaiiR 96t5u2G7H/DfcCMlFOLCk+3Ip8mrO9S1SnoFGBGwlYtPx46Q7cEsAY9jIkHs5viFAsNT UnJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=49qaqMdrBcj2mU84jKAP+Y0tov3oD0nk/O30siIAc9w=; b=G0YxFh5ggxBcNdkisSeNjmeGesR7RqXxEzmmfZLQusw+UBdkm6ikYsFUeMvpNxDG/g gLfAXaogyV/7HpAkhHR8xKl3caB9UHX11LbOcnaUu+b7nOHQdqEEVHWPzE5Ohuu1DBYS N3krD1smKBpA4zTTf8+UKVvltUNnbJ0m2HZtj6HZhoGlluwpQ7AxSvqpjKLTl4oaBBtm USUhRVUfWo9Huh1sc0EqYwM81Dk8oAscaM7W6TPsyVTq5PdGelEU6Docjorl9/0/2Qev KczbjlmWl+OxIESAoXiqD2JOIPHFCEzWhht3FRLaXyBN7dJQ7lsZoBkaznXMjeKqwSr1 i7IQ== X-Gm-Message-State: AKS2vOwV38bsgkRujZdnyyzAyVa7Ntv0v4T0PLbthx6tf2EKzESkT+Sx Gpg1csqD8MNNVj/inXg= X-Received: by 10.28.189.67 with SMTP id n64mr13863305wmf.115.1497831559404; Sun, 18 Jun 2017 17:19:19 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id n14sm4092075wmd.1.2017.06.18.17.19.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Jun 2017 17:19:18 -0700 (PDT) Subject: Re: bug#25995: 26.0.50; Mismatch between documented and actual behaviour of icomplete To: npostavs@users.sourceforge.net, Alexis References: <87a88yveuj.fsf@debian> <87shmm823i.fsf@users.sourceforge.net> From: Dmitry Gutov Message-ID: <93815f6a-22a9-f8b5-2583-5b8bd9906d48@yandex.ru> Date: Mon, 19 Jun 2017 03:19:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <87shmm823i.fsf@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 3/10/17 1:25 AM, > This seems to have been introduced by [1: 65797b1]. I guess > completion-pcm--filename-try-filter should not reverse its input? > > 1: 2016-04-28 19:31:43 +0200 65797b1d75e9f608ffd50fd88be47a854b143bb1 > Make icomplete respect `completion-ignored-extensions' > > --- i/lisp/minibuffer.el > +++ w/lisp/minibuffer.el > @@ -3257, 7 +3257, 7 @@ completion-pcm--filename-try-filter > "\\)\\'"))) > (dolist (f all) > (unless (string-match-p re f) (push f try))) > - (or try all)))) > + (or (nreverse try) all)))) [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.42 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.42 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 25995 Cc: 25995@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 3/10/17 1:25 AM, > This seems to have been introduced by [1: 65797b1]. I guess > completion-pcm--filename-try-filter should not reverse its input? > > 1: 2016-04-28 19:31:43 +0200 65797b1d75e9f608ffd50fd88be47a854b143bb1 > Make icomplete respect `completion-ignored-extensions' > > --- i/lisp/minibuffer.el > +++ w/lisp/minibuffer.el > @@ -3257,7 +3257,7 @@ completion-pcm--filename-try-filter > "\\)\\'"))) > (dolist (f all) > (unless (string-match-p re f) (push f try))) > - (or try all)))) > + (or (nreverse try) all)))) [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.42 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.42 listed in list.dnswl.org] 1.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different On 3/10/17 1:25 AM, npostavs@users.sourceforge.net wrote: > This seems to have been introduced by [1: 65797b1]. I guess > completion-pcm--filename-try-filter should not reverse its input? > > 1: 2016-04-28 19:31:43 +0200 65797b1d75e9f608ffd50fd88be47a854b143bb1 > Make icomplete respect `completion-ignored-extensions' > > --- i/lisp/minibuffer.el > +++ w/lisp/minibuffer.el > @@ -3257,7 +3257,7 @@ completion-pcm--filename-try-filter > "\\)\\'"))) > (dolist (f all) > (unless (string-match-p re f) (push f try))) > - (or try all)))) > + (or (nreverse try) all)))) Looks good to me, thank you. But what are the chances of this 'nreverse' (or the whole function) being performance-significant? Maybe we could switch this code to `cl-delete-if'. From my testing, it's considerably faster than dolist+push (even without nreverse). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 23:27:26 2017 Received: (at 25995) by debbugs.gnu.org; 19 Jun 2017 03:27:26 +0000 Received: from localhost ([127.0.0.1]:55495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMnLa-0001Nc-BB for submit@debbugs.gnu.org; Sun, 18 Jun 2017 23:27:26 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:36338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMnLY-0001NO-P9 for 25995@debbugs.gnu.org; Sun, 18 Jun 2017 23:27:25 -0400 Received: by mail-io0-f171.google.com with SMTP id y77so56044266ioe.3 for <25995@debbugs.gnu.org>; Sun, 18 Jun 2017 20:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vuc34Kqt1aWzKAJe7Ape031GyMJ7ZVf2zVXq5q6kTpM=; b=nvdfDxrgKkZ30DXj7489emwkZmO+LlQsh3UHd6b9DBpAw6krvVl8DQJrVl9ZHmXZEH u3qAwdpT5+vO6dm//jMLVb8KNl04d3LDiGY9wx+hr/u8btvHQz2OFikNctrMdCEC2B1z P0vKZyug3UQJEIVPL3zhmvbXw3Ls+Ms5gkqDuyUjZPN/rrJkLFuFjOxhkraYSzT66EN1 zIrUvR4kG6SU+Enifdzac6s0vEyYfjqFjqxBodpzddf7QyDwngLNpNHIslN74q/pn2YU tJ9hx2wpaJA3GcOevB5T1HxnVoms8hM2qjHEJXTXs/HWATORouMXAQJky1O5s3ddrB5o jTxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=vuc34Kqt1aWzKAJe7Ape031GyMJ7ZVf2zVXq5q6kTpM=; b=WYZmWg1n12u0hSKP+VlvojbVF2xrrcwzpGIPBIHiqxIbF6YAdstIQ0jJFUoJ/J8Fq7 jUqsgGzRvZSLpsrTrAgfrKu0og7UNU7vJOSJOMEZONmBzvuKHxgdoZVI4CsG4Hy/LpYx uSK/KXKJq5oPTONpmiiT0pe/tO2949Oz+eMowJV5+jb0nzY+Es2nPEYLbA9Hh7w8SEXV G8x1MuCnu/mQwlPNblsP7kHlew5WyIayjNjyB8Ep8d/8E1PLMrtMAdvKYMix/oZdB3Ik gVjwNhgdGsBw2Q7IcQ+WyvjYZf106OzD7Ky82mvz7mlapEJI27paI+ODlMGlBVLMA3nS uDtw== X-Gm-Message-State: AKS2vOxkAnwft7dYUWxzH9BqFSQfo7xO2mKvAJ7SR2EFr/wXB0ceOLjc Yt4gSz443LKXNr/O X-Received: by 10.107.18.219 with SMTP id 88mr20543315ios.149.1497842838869; Sun, 18 Jun 2017 20:27:18 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id k2sm3216421itk.3.2017.06.18.20.27.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Jun 2017 20:27:18 -0700 (PDT) From: npostavs@users.sourceforge.net To: Dmitry Gutov Subject: Re: bug#25995: 26.0.50; Mismatch between documented and actual behaviour of icomplete References: <87a88yveuj.fsf@debian> <87shmm823i.fsf@users.sourceforge.net> <93815f6a-22a9-f8b5-2583-5b8bd9906d48@yandex.ru> Date: Sun, 18 Jun 2017 23:28:52 -0400 In-Reply-To: <93815f6a-22a9-f8b5-2583-5b8bd9906d48@yandex.ru> (Dmitry Gutov's message of "Mon, 19 Jun 2017 03:19:16 +0300") Message-ID: <87injsr6yz.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dmitry Gutov writes: > On 3/10/17 1:25 AM, npostavs@users.sourceforge.net wrote: > >> --- i/lisp/minibuffer.el >> +++ w/lisp/minibuffer.el >> @@ -3257, 7 +3257, 7 @@ completion-pcm--filename-try-filter >> "\\)\\'"))) >> (dolist (f all) >> (unless (string-match-p re f) (push f try))) >> - (or try all)))) >> + (or (nreverse try) all)))) > > Looks good to me, thank you. > > But what are the chances of this 'nreverse' (or the whole function) > being performance-significant? > > Maybe we could switch this code to `cl-delete-if'. From my testing, > it's considerably faster than dolist+push (even without nreverse). [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.223.171 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.223.171 listed in wl.mailspike.net] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 25995 Cc: 25995@debbugs.gnu.org, Alexis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dmitry Gutov writes: > On 3/10/17 1:25 AM, npostavs@users.sourceforge.net wrote: > >> --- i/lisp/minibuffer.el >> +++ w/lisp/minibuffer.el >> @@ -3257,7 +3257,7 @@ completion-pcm--filename-try-filter >> "\\)\\'"))) >> (dolist (f all) >> (unless (string-match-p re f) (push f try))) >> - (or try all)))) >> + (or (nreverse try) all)))) > > Looks good to me, thank you. > > But what are the chances of this 'nreverse' (or the whole function) > being performance-significant? > > Maybe we could switch this code to `cl-delete-if'. From my testing, > it's considerably faster than dolist+push (even without nreverse). [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.223.171 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.223.171 listed in list.dnswl.org] 1.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different --=-=-= Content-Type: text/plain Dmitry Gutov writes: > On 3/10/17 1:25 AM, npostavs@users.sourceforge.net wrote: > >> --- i/lisp/minibuffer.el >> +++ w/lisp/minibuffer.el >> @@ -3257,7 +3257,7 @@ completion-pcm--filename-try-filter >> "\\)\\'"))) >> (dolist (f all) >> (unless (string-match-p re f) (push f try))) >> - (or try all)))) >> + (or (nreverse try) all)))) > > Looks good to me, thank you. > > But what are the chances of this 'nreverse' (or the whole function) > being performance-significant? > > Maybe we could switch this code to `cl-delete-if'. From my testing, > it's considerably faster than dolist+push (even without nreverse). I don't have a good sense of how the completion code fits together, so I'm not sure how significant the performance of this function is, but in my simplistic benchmark I found the opposite: dolist+push+nreverse is quite a bit faster (although the difference can be swamped by GC). So adding `nreverse' won't be a problem. ~/src$ emacs -Q -batch -l emacs/bench-filter.elc dolist+push 1000 Elapsed time: 0.000335s dolist+push 10000 Elapsed time: 0.001951s dolist+push 100000 Elapsed time: 0.056526s (0.035910s in 1 GCs) dolist+push+nreverse 1000 Elapsed time: 0.000212s dolist+push+nreverse 10000 Elapsed time: 0.002086s dolist+push+nreverse 100000 Elapsed time: 0.019966s cl-delete-if 1000 Elapsed time: 0.002174s cl-delete-if 10000 Elapsed time: 0.003604s cl-delete-if 100000 Elapsed time: 0.034759s --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=bench-filter.el Content-Transfer-Encoding: quoted-printable Content-Description: benchmark code ;;; -*- lexical-binding: t -*- (require 'cl-lib) (defconst filter-biglist0 (number-sequence 0 1000)) (defconst filter-biglist1 (number-sequence 0 10000)) (defconst filter-biglist2 (number-sequence 0 100000)) (defconst filter-biglist3 (number-sequence 0 1000000)) (defconst filter-biglist4 (number-sequence 0 10000000)) (defun filter-by-dolist+push+nreverse (list) (let ((result nil)) (dolist (num list) (when (cl-evenp num) (push num result))) (nreverse result))) (defun filter-by-dolist+push (list) (let ((result nil)) (dolist (num list) (when (cl-evenp num) (push num result))) result)) (defun filter-by-cl-delete-if (list) (cl-delete-if #'cl-evenp list)) (progn (message "dolist+push 1000") (benchmark 1 '(filter-by-dolist+push filter-biglist0)) (message "dolist+push 10000") (benchmark 1 '(filter-by-dolist+push filter-biglist1)) (message "dolist+push 100000") (benchmark 1 '(filter-by-dolist+push filter-biglist2)) (message "dolist+push 1000000") (benchmark 1 '(filter-by-dolist+push filter-biglist3))) (progn (message "dolist+push+nreverse 1000") (benchmark 1 '(filter-by-dolist+push+nreverse filter-biglist0)) (message "dolist+push+nreverse 10000") (benchmark 1 '(filter-by-dolist+push+nreverse filter-biglist1)) (message "dolist+push+nreverse 100000") (benchmark 1 '(filter-by-dolist+push+nreverse filter-biglist2)) (message "dolist+push+nreverse 1000000") (benchmark 1 '(filter-by-dolist+push+nreverse filter-biglist3))) (progn (message "cl-delete-if 1000") (benchmark 1 '(filter-by-cl-delete-if filter-biglist0)) (message "cl-delete-if 10000") (benchmark 1 '(filter-by-cl-delete-if filter-biglist1)) (message "cl-delete-if 100000") (benchmark 1 '(filter-by-cl-delete-if filter-biglist2)) (message "cl-delete-if 1000000") (benchmark 1 '(filter-by-cl-delete-if filter-biglist3))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 20 22:05:02 2017 Received: (at 25995) by debbugs.gnu.org; 21 Jun 2017 02:05:02 +0000 Received: from localhost ([127.0.0.1]:58646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNV0w-00012n-3R for submit@debbugs.gnu.org; Tue, 20 Jun 2017 22:05:02 -0400 Received: from mail-wr0-f178.google.com ([209.85.128.178]:36317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNV0u-00012R-GN for 25995@debbugs.gnu.org; Tue, 20 Jun 2017 22:05:00 -0400 Received: by mail-wr0-f178.google.com with SMTP id c11so59060744wrc.3 for <25995@debbugs.gnu.org>; Tue, 20 Jun 2017 19:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ntWFMFCQoSdpNty6uAAPQf4mBrYaR//94MZ3xUGnqm0=; b=unyWO1S6eRIm/4AyIySXa1jO/OZFkd3CEdRFBv2nKEqX49nbltDSBw8qYPWQxh7NfC Dqyfy5B0LQM6hNJjeKkccxR1b08zSRXKgtRzkujBGb2HsZZBAdu7uST11e6IMRrYBFBa Szh16kundZqpX9Nzb7bWA1TmxPiDfDYGaQSr7E3DWPexmYc5+PC5k92iaZpK5bn2+mzp 5WI0gU/LzDA6Mq/l4IJ/OWXIm3jHq7fJgKnp+m8TLjWrHaIL8rgu5ZreXdmvSXP8oQi0 XqOFmAoS6ysFSxKx1tSyWEpsZ3YZHiaa7Gt7FHb/PL7J6dtRVbT30TPvAaG0QBe3zAUU hGAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ntWFMFCQoSdpNty6uAAPQf4mBrYaR//94MZ3xUGnqm0=; b=Yi3RYkY6jBprCKHhxxKTNqBEF0HVhYoo+ic3auXN2uHntURRuQ4PqKFvvSvc80Tu3B 2UovbI8p9O0z9LdrQ4prKhLBOMsr5QFwe8hvGWYRgruVxJpOE/GPy4Sr5iAIqe6uTw8w JXKmuWqwzc4sKDPH9o82Y0OBIWeg8ouTDDbfnSSIUye8nrvo8IPKDWvEih8whXg6dgF+ Woz5T/Ce4XP65n1oDYdB/kQzuihPYt+KRqaGUbZYW2/mfhjUNhImhinUFAlvAXqbrMEf WHh40pe3cLWG6K1H65Y/LBw1ocbF1O0bC0DPIYMHcw8qQL9ft/XOSiVDhEmP28MqNOMJ RPRw== X-Gm-Message-State: AKS2vOxEa2VwVsQrTuxQbjNhnvaCzw1CdbvMGboYVywiFyOiIP8Iy3Wv iGCWo1i53S/Z8Q== X-Received: by 10.223.154.41 with SMTP id z38mr21665222wrb.76.1498010694888; Tue, 20 Jun 2017 19:04:54 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id e130sm19987161wmf.10.2017.06.20.19.04.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jun 2017 19:04:53 -0700 (PDT) Subject: Re: bug#25995: 26.0.50; Mismatch between documented and actual behaviour of icomplete To: npostavs@users.sourceforge.net References: <87a88yveuj.fsf@debian> <87shmm823i.fsf@users.sourceforge.net> <93815f6a-22a9-f8b5-2583-5b8bd9906d48@yandex.ru> <87injsr6yz.fsf@users.sourceforge.net> From: Dmitry Gutov Message-ID: Date: Wed, 21 Jun 2017 05:04:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <87injsr6yz.fsf@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 25995 Cc: 25995@debbugs.gnu.org, Alexis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/19/17 6:28 AM, npostavs@users.sourceforge.net wrote: > I don't have a good sense of how the completion code fits together, so > I'm not sure how significant the performance of this function is, but in > my simplistic benchmark I found the opposite: dolist+push+nreverse is > quite a bit faster (although the difference can be swamped by GC). So > adding `nreverse' won't be a problem. Thank you for the benchmark file. Indeed, in batch mode my results are similar to yours: dolist+push 1000 Elapsed time: 0.000135s dolist+push 10000 Elapsed time: 0.001112s dolist+push 100000 Elapsed time: 0.011830s dolist+push+nreverse 1000 Elapsed time: 0.000130s dolist+push+nreverse 10000 Elapsed time: 0.001084s dolist+push+nreverse 100000 Elapsed time: 0.011518s cl-delete-if 1000 Elapsed time: 0.001173s cl-delete-if 10000 Elapsed time: 0.001621s cl-delete-if 100000 Elapsed time: 0.017909s When running it interactively, however (M-x eval-buffer, also starting with 'emacs -Q'), I'm getting consistently opposite results: dolist+push 1000 Elapsed time: 0.000836s dolist+push 10000 Elapsed time: 0.007698s dolist+push 100000 Elapsed time: 0.045281s dolist+push+nreverse 1000 Elapsed time: 0.000512s dolist+push+nreverse 10000 Elapsed time: 0.007719s dolist+push+nreverse 100000 Elapsed time: 0.186524s (0.140654s in 1 GCs) cl-delete-if 1000 Elapsed time: 0.002603s cl-delete-if 10000 Elapsed time: 0.003347s cl-delete-if 100000 Elapsed time: 0.021793s In any case, nreverse barely affects the runtime, so please go ahead and push the patch. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 20 22:49:21 2017 Received: (at 25995) by debbugs.gnu.org; 21 Jun 2017 02:49:21 +0000 Received: from localhost ([127.0.0.1]:58703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNVhp-00023x-18 for submit@debbugs.gnu.org; Tue, 20 Jun 2017 22:49:21 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:33915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNVhj-00023W-SC; Tue, 20 Jun 2017 22:49:16 -0400 Received: by mail-it0-f68.google.com with SMTP id y134so4998166itc.1; Tue, 20 Jun 2017 19:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T7vsp+GuE9Sag+GMCNtjZksZhddx6CLBwWb2kDQMm+0=; b=JWR3KnjgP9mtoImX4AggJbXa4RN9npklh7pEbtBPoKg7I0o6mikhgRRKmZMPu64bZb njYremh6zXZHLRt4HMq8p8p6xV1YGwPj0kvtZazTOYnxwkk1NQfbQojfYuOukX4DT+vP /aww64j9hOFq97rGPB3PhaYPR8RTuhHYHW+l3u3NnFWeA+gsg2uNKjzl6u6HxB+GZxC/ D3wjzvKI6LyQ+f6zQKPZFaK/gLn9E5uPyu0vS5cNNqW89VxaajGkAbR3+G1qdxnkhGGf BEX2AUwypLC25CppBgsofhzjXsPMO5zEc5aOwPbOFYLZ16l4qrypqLUigUuoF8Sn+pNU K3QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=T7vsp+GuE9Sag+GMCNtjZksZhddx6CLBwWb2kDQMm+0=; b=X6wCj9fXCUmNsALErtlkWXV3URBVRiJhLURIJXwSTP4VmXpSk3OqCaHlbLX5BVqGJz l4t1tSThdmlbBo0f9cEtIHw3xdpdNHg/AqX0nXEpPAgmmnkUuZzvqZ5t9DacY8atYBVH xPiivsoJQpkRh9GLsbAJrbszf1GT/Ly2M7fMsSV5NaEqPc9b90bh3zK0DuakKhJNPorD 0fRxpgp3a1yC7zghZrLVBFhLHduFjkDATuv736M0QVHSfeCMR5Rbcon2QzgbryKQYJrK 0Vxo30Tj+1OM3umRk+WZxklWN9xcbEsns9GpswyvKm7DMiykiKvRCtYoK+aPZ524tqRg u//A== X-Gm-Message-State: AKS2vOwBAcyBO3y7Bpu5GKurQshhlwJpyAEJQD/ne26/K3K6Py0tQFuh RIvhkUJgZa8evVdr X-Received: by 10.36.121.216 with SMTP id z207mr6523114itc.86.1498013350049; Tue, 20 Jun 2017 19:49:10 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 86sm318298ioj.8.2017.06.20.19.49.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Jun 2017 19:49:09 -0700 (PDT) From: npostavs@users.sourceforge.net To: Dmitry Gutov Subject: Re: bug#25995: 26.0.50; Mismatch between documented and actual behaviour of icomplete References: <87a88yveuj.fsf@debian> <87shmm823i.fsf@users.sourceforge.net> <93815f6a-22a9-f8b5-2583-5b8bd9906d48@yandex.ru> <87injsr6yz.fsf@users.sourceforge.net> Date: Tue, 20 Jun 2017 22:50:45 -0400 In-Reply-To: (Dmitry Gutov's message of "Wed, 21 Jun 2017 05:04:51 +0300") Message-ID: <87d19yqcje.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25995 Cc: 25995@debbugs.gnu.org, Alexis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 25995 fixed close 25995 26.1 tags 24676 fixed close 24676 26.1 quit Dmitry Gutov writes: > When running it interactively, however (M-x eval-buffer, also starting > with 'emacs -Q'), I'm getting consistently opposite results: Ah, you're measuring interpreted code which will penalize the open-coded loop more than the `cl-delete-if' call which has the loop tucked away (and compiled). > In any case, nreverse barely affects the runtime, so please go ahead > and push the patch. Thanks! Pushed to master [1: 1ed2086a03], also fixes the same issue for `completion-pcm--all-completions' (Bug#24676). [1: 1ed2086a03]: 2017-06-20 22:44:24 -0400 Keep order of completion candidates (Bug#25995, Bug#24676) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1ed2086a03a5f33482d2f184e57dad9e6a9d25d8 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 21 18:17:56 2017 Received: (at 25995) by debbugs.gnu.org; 21 Jun 2017 22:17:56 +0000 Received: from localhost ([127.0.0.1]:60352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNnwh-000843-UD for submit@debbugs.gnu.org; Wed, 21 Jun 2017 18:17:56 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNnwg-00083p-Qe for 25995@debbugs.gnu.org; Wed, 21 Jun 2017 18:17:55 -0400 Received: by mail-wr0-f196.google.com with SMTP id k67so2285013wrc.1 for <25995@debbugs.gnu.org>; Wed, 21 Jun 2017 15:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h/2Vl+EgR894FDosOP6kJKCCP210wpKKhsPO0nmGGi0=; b=pQ5CHrJR/28WPNR6K/IYhr/8QpUJ+kyQpiyyd5wDvZExFsIhSerZmKMu0nY4gOZ764 S3oNkO8qG6vTRm8eNpIwMFUlMOvW4XS34KYBzAl1K4TUem77Ks44oy/4Ci7oi/Ac8BOh nHf02etKtrjL5j7hlUX8EN+Fw8cEa+ZOZuHMRJANikyQVDY/Dkeh6WWffO7BvTyJTSPi rtrqMblxKLgG3YVKReeFOvVfP1GFylzBa0fbvbZlAKqsPvcKZixGaPZ5SRCKuXkT6DzA 1nNSuoVycYMiDXAmZ968RF+vMSc4/J//p5MO6Tsv+rzeSokn1WFJWKl8Gvr6Hl6Av3l7 5S6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h/2Vl+EgR894FDosOP6kJKCCP210wpKKhsPO0nmGGi0=; b=EHio8mgVpJcCjzCpKSodp6ucAPGaj9IpyV/ClYDUDvH+Om0YwvM/6idARykibXxurd JzXO1gdKpYRxBlkaWq4n0nBLgvgJiHhHs/BliLlIiPZ052WJsaGfD+BHzcHyUjUpkdAs WeJdTtguusCJky3jr6ujUtcNW75ikWB7RRW3hXmDAAWVek2TItrYKnPXIrA9vp6ddD5p a83Av6nj9E0EtcYzluBKacyLexA8AhE9DxIRifClNmUfkF+wCp4TkupzJ4S1Wnyjcp/W wmIoyC9tH4BbPOTzudD/+42/ygVRQtohpuXVP8ru0URIWhYLO3Q4YfisXVqaStIT1Txm wrRQ== X-Gm-Message-State: AKS2vOz60OXx+JocVI2rB8q7HtI4KDsBVhA0BYpR9BTQd2etFHEd163Q dgiRiJ86AJAK/w== X-Received: by 10.28.234.79 with SMTP id i76mr22723wmh.3.1498083468838; Wed, 21 Jun 2017 15:17:48 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id h16sm33699590wma.14.2017.06.21.15.17.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jun 2017 15:17:47 -0700 (PDT) Subject: Re: bug#25995: 26.0.50; Mismatch between documented and actual behaviour of icomplete To: npostavs@users.sourceforge.net References: <87a88yveuj.fsf@debian> <87shmm823i.fsf@users.sourceforge.net> <93815f6a-22a9-f8b5-2583-5b8bd9906d48@yandex.ru> <87injsr6yz.fsf@users.sourceforge.net> <87d19yqcje.fsf@users.sourceforge.net> From: Dmitry Gutov Message-ID: Date: Thu, 22 Jun 2017 01:17:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <87d19yqcje.fsf@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 25995 Cc: 25995@debbugs.gnu.org, Alexis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/21/17 5:50 AM, npostavs@users.sourceforge.net wrote: > Ah, you're measuring interpreted code which will penalize the open-coded > loop more than the `cl-delete-if' call which has the loop tucked away > (and compiled). Indeed, thanks. Since eager macro-expansion landed, I don't recall seeing more than a 2x difference between byte-compiled and interpreted code, but here it is. :) >> In any case, nreverse barely affects the runtime, so please go ahead >> and push the patch. Thanks! > > Pushed to master [1: 1ed2086a03], also fixes the same issue for > `completion-pcm--all-completions' (Bug#24676). Indeed! From unknown Sat Sep 20 13:26:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Jul 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator