From unknown Sat Sep 20 06:23:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25991: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. Resent-From: Mekeor Melire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Mar 2017 01:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25991 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 25991@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148876531730460 (code B ref -1); Mon, 06 Mar 2017 01:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Mar 2017 01:55:17 +0000 Received: from localhost ([127.0.0.1]:41551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckhrp-0007vE-8a for submit@debbugs.gnu.org; Sun, 05 Mar 2017 20:55:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckhrn-0007v0-5x for submit@debbugs.gnu.org; Sun, 05 Mar 2017 20:55:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckhrg-00033k-Td for submit@debbugs.gnu.org; Sun, 05 Mar 2017 20:55:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56909) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ckhrg-00033Z-Qf for submit@debbugs.gnu.org; Sun, 05 Mar 2017 20:55:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckhrf-0004Bh-FY for guix-patches@gnu.org; Sun, 05 Mar 2017 20:55:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckhre-00030Z-Dk for guix-patches@gnu.org; Sun, 05 Mar 2017 20:55:07 -0500 Received: from mail-wr0-x233.google.com ([2a00:1450:400c:c0c::233]:34316) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckhre-0002zr-7m for guix-patches@gnu.org; Sun, 05 Mar 2017 20:55:06 -0500 Received: by mail-wr0-x233.google.com with SMTP id l37so106664338wrc.1 for ; Sun, 05 Mar 2017 17:55:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:message-id:date:mime-version; bh=+7ZqyNwcv1m0h3hvyuvPg6+3+QIguAXFIp7Fa5ogy6U=; b=sKBevJD3pR92hM5kDTkMr8YLdbLmwq/S7l/btR6SbAFT9KwFRDnjNXyTbSW+YxqBJU adskIchi6a0u42OC01jJff8zZ8H/WSVYSTCnQZeLAxx6CmlUNO0foWCfRS4qwHrt/yCW lYR0lfVF3nopM8m9WGj005dfnQB2JX08AYUeabwm2fdcsEyVBMSwlxnGJ1OYbmKIRy3g ISXn49zv22ctOgmZqvhmDANE5FatPtydQKARd4Av18Nhr/D6slZLrcL5owOL/JDTJbui WSIWHx+mFwEl9X6oJ4t1lLHuYQj20uYxnbU9HokKftYoKmbqN34RiHizqZxKHfJeR2Vf MGjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:message-id:date :mime-version; bh=+7ZqyNwcv1m0h3hvyuvPg6+3+QIguAXFIp7Fa5ogy6U=; b=K+mzlCesO8gEJhOWP7nE5W3y2WNcf0X1Obs+0wgZBKe0G1bQKjS1qIXctYsLHLbesI b2fKNbfsmmtSH9ti7Bfo5qirxjjXeppEuyfWOnhlvPQCqmFvAtodFm8u1nPNM1oiSsq2 AL7tCVGjucCIdX7mRvTKbkVuGOyO7rdwSsShNv2phxzqE8FVZKcPvHd+Fc0n8Q/BTmW9 srkKX+9tdwy/LWUEbz1IQ7q/3xCTTAITFfeDuvz2ZJqC+e/A6SQL+Bd6AomT/0cthTSe NF5Fs5c4p+D9MAz8vMMy9+NCASIEV5HSSqXShpyGw33IjQxTcNBx6DCRWPjGXKC97euG 62pg== X-Gm-Message-State: AMke39mGvXwFb/jB5wgDFcA/aFRDK8T6Pg+4Qp3BTYLyYVs3QGHgCPuimaxeQc4owzcoeA== X-Received: by 10.223.142.40 with SMTP id n37mr11345596wrb.137.1488765303334; Sun, 05 Mar 2017 17:55:03 -0800 (PST) Received: from melire. ([2001:a61:220b:9e01:5870:869d:4c38:2906]) by smtp.gmail.com with ESMTPSA id 63sm12738302wmp.9.2017.03.05.17.55.02 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Mar 2017 17:55:02 -0800 (PST) User-agent: mu4e 0.9.18; emacs 25.1.1 From: Mekeor Melire Message-ID: <87mvczch1w.fsf@gmail.com> Date: Mon, 06 Mar 2017 02:55:01 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit This is meant to fix bug#25759 “Should 'surf' depend on 'xprop' and 'dmenu'?“: https://lists.gnu.org/archive/html/bug-guix/2017-02/msg00054.html I'm not sure if we really want this patch to be merged because there was not much of a discussion on this proposal on the mailing list. Also, I hope I'm sending it to the right mailing-list. I'm quite confused by all the mailing-lists and bug-trackers. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-surf-Add-dmenu-and-xprop-to-inputs.patch Content-Description: gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. >From 4f11e27908987cc8d607809785726fceadc0535f Mon Sep 17 00:00:00 2001 From: Mekeor Melire Date: Mon, 6 Mar 2017 02:36:47 +0100 Subject: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. * gnu/packages/suckless.scm (surf)[inputs]: Add dmenu and xprop. --- gnu/packages/suckless.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index e30a0883a..c845a0c72 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -257,9 +257,11 @@ drawing.") (modify-phases %standard-phases (delete 'configure)))) (inputs - `(("glib-networking" ,glib-networking) + `(("dmenu" ,dmenu) + ("glib-networking" ,glib-networking) ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) - ("webkitgtk" ,webkitgtk/gtk+-2))) + ("webkitgtk" ,webkitgtk/gtk+-2) + ("xprop" ,xprop))) (native-inputs `(("pkg-config" ,pkg-config))) (home-page "http://surf.suckless.org/") -- 2.12.0 --=-=-= Content-Type: text/plain -- mekeor ~ EDD3 DFFA 76F6 11C0 145F 9A99 AC85 BAD8 A2F8 C868 --=-=-=-- From unknown Sat Sep 20 06:23:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25991: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Mar 2017 02:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25991 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mekeor Melire Cc: 25991@debbugs.gnu.org Received: via spool by 25991-submit@debbugs.gnu.org id=B25991.148876615631767 (code B ref 25991); Mon, 06 Mar 2017 02:10:02 +0000 Received: (at 25991) by debbugs.gnu.org; 6 Mar 2017 02:09:16 +0000 Received: from localhost ([127.0.0.1]:41562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cki5L-0008GI-Se for submit@debbugs.gnu.org; Sun, 05 Mar 2017 21:09:16 -0500 Received: from dd1012.kasserver.com ([85.13.128.8]:48081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cki5K-0008GB-Ty for 25991@debbugs.gnu.org; Sun, 05 Mar 2017 21:09:15 -0500 Received: from localhost (178.113.175.251.wireless.dyn.drei.com [178.113.175.251]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 4C6F61CA06E3; Mon, 6 Mar 2017 03:09:13 +0100 (CET) Date: Mon, 6 Mar 2017 03:09:08 +0100 From: Danny Milosavljevic Message-ID: <20170306030908.2599fc96@scratchpost.org> In-Reply-To: <87mvczch1w.fsf@gmail.com> References: <87mvczch1w.fsf@gmail.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, On Mon, 06 Mar 2017 02:55:01 +0100 Mekeor Melire wrote: > This is meant to fix bug#25759 =E2=80=9CShould 'surf' depend on 'xprop' a= nd > 'dmenu'?=E2=80=9C: >=20 > https://lists.gnu.org/archive/html/bug-guix/2017-02/msg00054.html >=20 > I'm not sure if we really want this patch to be merged because there was > not much of a discussion on this proposal on the mailing list. It's not finished. http://git.suckless.org/surf/tree/config.def.h#n38 invok= es xprop and dmenu - and these places would have to be substituted by store= references, like: (substitute* "tree/config.def.h" (("xprop") (string-append (assoc-ref inputs "xprop") "/bin/xprop")) (("dmenu") (string-append (assoc-ref inputs "dmenu") "/bin/dmenu"))) I'm not sure whether Guix will retain the store references on the next GC, = though. From unknown Sat Sep 20 06:23:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25991: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Mar 2017 03:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25991 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mekeor Melire Cc: 25991@debbugs.gnu.org Received: via spool by 25991-submit@debbugs.gnu.org id=B25991.14887704255819 (code B ref 25991); Mon, 06 Mar 2017 03:21:01 +0000 Received: (at 25991) by debbugs.gnu.org; 6 Mar 2017 03:20:25 +0000 Received: from localhost ([127.0.0.1]:41581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckjCC-0001Vn-TC for submit@debbugs.gnu.org; Sun, 05 Mar 2017 22:20:25 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:51542 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckjCA-0001Vd-Ch for 25991@debbugs.gnu.org; Sun, 05 Mar 2017 22:20:22 -0500 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 1B5F851EEDD; Mon, 6 Mar 2017 04:20:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1488770421; bh=QzPQKcfq1XwzdjK03ltR45xmFBuG1FuglZ9U46QohjQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=trTAz+d+w7KKTUTl7Wb9jWBnAhDcpbL1kSv6xQpycW1QFwLY4w44xblf47L9A0lSi yuwb08xxnpHMQmVP1WmgWdiA6c2SqYHhcxNBnUo6fE8K2iGkw1H2aAvFe9U9e8khCh xDGoN3u1pPk3Ui+OQBVj5FWOCxy90YD8eYgCcc+Y= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR002 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1488770420; bh=QzPQKcfq1XwzdjK03ltR45xmFBuG1FuglZ9U46QohjQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=d8fmS4F4PgksxVF3eCpKpwHNl8DDFEF9/xQJmBK+2pSZi6LNCi9uOKnoC8jo9xJpz AJSeOMMoCqhAL6nveHIjvvgmSfIP6zwalKIzo0M5qFVirfm+hK+MYn7LO0r+QFfYtc MBe0Nh63tyShZ9yom6WVZ9rkI7ULXVyRWRlAi+RI= References: <87mvczch1w.fsf@gmail.com> Date: Sun, 05 Mar 2017 22:20:09 -0500 In-Reply-To: <87mvczch1w.fsf@gmail.com> (Mekeor Melire's message of "Mon, 06 Mar 2017 02:55:01 +0100") Message-ID: <87zigzgkgm.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mekeor Melire writes: > This is meant to fix bug#25759 =E2=80=9CShould 'surf' depend on 'xprop' a= nd > 'dmenu'?=E2=80=9C: > > https://lists.gnu.org/archive/html/bug-guix/2017-02/msg00054.html > > I'm not sure if we really want this patch to be merged because there was > not much of a discussion on this proposal on the mailing list. > This patch concerns basic functionality of the software, so I don't think we'll hear objections. > Also, I hope I'm sending it to the right mailing-list. I'm quite > confused by all the mailing-lists and bug-trackers. > I'm seeing this in my debbugs interface, so you must be doing something correctly. >>>From 4f11e27908987cc8d607809785726fceadc0535f Mon Sep 17 00:00:00 2001 > From: Mekeor Melire > Date: Mon, 6 Mar 2017 02:36:47 +0100 > Subject: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. > > * gnu/packages/suckless.scm (surf)[inputs]: Add dmenu and xprop. > --- > gnu/packages/suckless.scm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm > index e30a0883a..c845a0c72 100644 > --- a/gnu/packages/suckless.scm > +++ b/gnu/packages/suckless.scm > @@ -257,9 +257,11 @@ drawing.") > (modify-phases %standard-phases > (delete 'configure)))) > (inputs > - `(("glib-networking" ,glib-networking) > + `(("dmenu" ,dmenu) > + ("glib-networking" ,glib-networking) > ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) > - ("webkitgtk" ,webkitgtk/gtk+-2))) > + ("webkitgtk" ,webkitgtk/gtk+-2) > + ("xprop" ,xprop))) > (native-inputs > `(("pkg-config" ,pkg-config))) > (home-page "http://surf.suckless.org/") This patch doesn't work as-is, but it's halfway done. The next step would be to replace the "dmenu" and "xprop" instances in surf's source code with the path to the two binaries you just included. For example: (let ((libc (assoc-ref inputs "libc"))) (substitute* "lib/nscd.c" (("/usr/sbin/nscd") (string-append libc "/sbin/nscd")))) This code was taken from line 296 of gnu/packages/admin.scm in the Guix source tree. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAli81WkACgkQ5qXuPBlG eg0coxAArKyuWrtaXXRfrvsWLaiItIuWQAv4X/hR4pwisQ9vCqAEdvozaOP0GkKp M5fUP1oBLHSIJpBUISVZ8DdLHafpgK+y7iAC3MMryhfK0qLxizFPqKVE6ZTl4eTE hykYknRIr4EKyM5qquycFlymiPekRcid6n18oN9y/KFmIC61sm9Sdf7F2g12httV 05zEDJIHDZ/zfgql5e8Rpm32cnFbrXJ6lIXu3H2+r4inl+IX6HfLikt0l2U6KOux SjSsVpXs3+2vg2M9R8wxYnLXHQ+A/a4/8lORfabT/nspZmoAmKWI1I6/x0CioZpK 9sHIoTlCxuAPeNI8jw7HK+Wr3QiWtJM/myGsWsG2R7w0W6c//sHVlcfis8hbNIu1 YaUNJAIoJ7p2GxKxMrqHVBQM7bTrDvYdSVCVielkDvqSmmavtuFYH6NSe/ks07S5 p8LMTSnqCp3r3zhU2ppnKrUA7f8j9JREFDU65tuEdKUwHB3S75YHJqSPmTCWIhla yVX2zyW3RUP22Tx5bxC8TTD/b+9SOeDST/krJw0OPvIcDFR/HpV8+uEekezj9A1t CLVeN1pjBpOkJODTzTvy/6swMPML0oCvKF06Tmt0ARbbJ5KbffdwbkmJIs/ZiNvZ 5CdvYk3Ob8CVU/w+IvCARXq3m9b/0JE5zfPt3AzQic61pIyS/i0= =uGDP -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 20 06:23:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25991: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Mar 2017 03:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25991 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: Mekeor Melire , 25991@debbugs.gnu.org Received: via spool by 25991-submit@debbugs.gnu.org id=B25991.14887706376161 (code B ref 25991); Mon, 06 Mar 2017 03:24:02 +0000 Received: (at 25991) by debbugs.gnu.org; 6 Mar 2017 03:23:57 +0000 Received: from localhost ([127.0.0.1]:41585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckjFd-0001bJ-Es for submit@debbugs.gnu.org; Sun, 05 Mar 2017 22:23:57 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:33585 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckjFb-0001b9-Tp for 25991@debbugs.gnu.org; Sun, 05 Mar 2017 22:23:56 -0500 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 33A0D51C64C; Mon, 6 Mar 2017 04:23:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1488770635; bh=Xy19oyCjVThNigEYxBv0BQWRMRQRuo6srkzQmNBGC+M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=vn8WHqT5JcRarf454Otx+3xLJa9OFCpU2t1fRj66j8WLR3Z869yBKbXorvHKfEInv ZkhCupOq3sYpgGRxqxueWeBApOc5PQJH/u6lDGDAxtPBtat7pyWf29m0jPAtQF9DL/ mxTgU0i/RoqoTeGSrBdtm1LO/RePRaMkCCcJdm2Y= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR003 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1488770634; bh=Xy19oyCjVThNigEYxBv0BQWRMRQRuo6srkzQmNBGC+M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=rBfFPdHpwwHTWv/4rwCjs/4OSvnrgo6LCeryKhOkS9heM2TJmSmwn/csE5wA8XvZd ipcqrJBq3Nl9Z2+GTo+jtJkD0k1SjelUn+a/oMK1e3rBDSdP+Kp1rab510sezeefoG yMpYf1PgBPrHtsCvDwDSLOT3nQeugqEJLFvJTg3w= References: <87mvczch1w.fsf@gmail.com> <20170306030908.2599fc96@scratchpost.org> Date: Sun, 05 Mar 2017 22:23:48 -0500 In-Reply-To: <20170306030908.2599fc96@scratchpost.org> (Danny Milosavljevic's message of "Mon, 6 Mar 2017 03:09:08 +0100") Message-ID: <87wpc3gkaj.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Danny Milosavljevic writes: > Hi, > > On Mon, 06 Mar 2017 02:55:01 +0100 > Mekeor Melire wrote: > >> This is meant to fix bug#25759 =E2=80=9CShould 'surf' depend on 'xprop' = and >> 'dmenu'?=E2=80=9C: >>=20 >> https://lists.gnu.org/archive/html/bug-guix/2017-02/msg00054.html >>=20 >> I'm not sure if we really want this patch to be merged because there was >> not much of a discussion on this proposal on the mailing list. > > It's not finished. http://git.suckless.org/surf/tree/config.def.h#n38 > invokes xprop and dmenu - and these places would have to be > substituted by store references, like: > > (substitute* "tree/config.def.h" > (("xprop") (string-append (assoc-ref inputs "xprop") "/bin/xprop")) > (("dmenu") (string-append (assoc-ref inputs "dmenu") "/bin/dmenu"))) > > I'm not sure whether Guix will retain the store references on the next > GC, though. I'm sure Guix does, considering we use this trick for all sorts of packages, including important ones like shadow. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAli81kUACgkQ5qXuPBlG eg2qtBAAuHYBZOUBbkLQklBryOXVdm4tWAj66fxsijMyCFHnjkMw09XRcEAvchuN VT/0pTtexLcMy0nRwq+Au0g29a3xle+MK+WHckjYCuqFomFJsGS/lG2RNnU6dir8 5kIBk58UV58DC3PV7PQ0asS4oNOsRFWOmaRwIwH3R/h2TP78nqLKN3LFBHe27pqB yyEVYKMlcERWGnVTn1/W9Bx3t6DCRgRJ0FPDpsm5P7BV4Kl87yHlS77ol5idzV70 FIsxAztvYJgaDfWOBglDdSDYdC9T83OF0a4xVkcw+gD0LvGSG9ryv4pu2C4ydiCY w/bO256CDNzFGGdhOgSt2JWaE0wMVQ/E8E3lJ5bdevxNao/ppwFUoHh/LRS1Biiv nAQDk2wRX2XUzfkVwq0IKVeMtnXgi2ixZOFvApzJTDPOpj6oNuqyGwyInJcZgOwf fBUBoPrKMa3srCGUx+TYsmpRHL4MPK2Nkzh8zzvfR50+AgX+9KZ8vDYmyhi0XxzY J4KgKY+YjUkKrid0BoA2YAD0UyCd2ho6gVpbwvKMt3yjQMEOGyiA2B9i8SoAVlsj fCDE6hRw4a2mMBicgguJjlippgfzzLc2T2XjusDk3FBXx70dykC89irafhI0jnOq Sn9SKqq1mfxygHk5MOweV/lGPnJ90Ni6JgnIcQWKAfBmfBAjB/8= =mevo -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 20 06:23:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25991: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Mar 2017 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25991 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kei Kebreau Cc: Danny Milosavljevic , 25991@debbugs.gnu.org Received: via spool by 25991-submit@debbugs.gnu.org id=B25991.148882551124254 (code B ref 25991); Mon, 06 Mar 2017 18:39:02 +0000 Received: (at 25991) by debbugs.gnu.org; 6 Mar 2017 18:38:31 +0000 Received: from localhost ([127.0.0.1]:43129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckxWh-0006J7-8q for submit@debbugs.gnu.org; Mon, 06 Mar 2017 13:38:31 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckxWf-0006J0-WE for 25991@debbugs.gnu.org; Mon, 06 Mar 2017 13:38:30 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D9DED2082B; Mon, 6 Mar 2017 13:38:29 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Mon, 06 Mar 2017 13:38:29 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=famulari.name; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=F1ylLwSemoPrk+iQjPqbuf3eCa8=; b=qYh9Mh jvzB0ezDEb3wug1n4U6n0REkVWWKLJpapB2Mjq//sEqkwhnNWE3PcgwiSPIUnEtB 6Gt/ACufeFdQCn2jrywUeZQUPdgDVyV6BJIaI3IHPGjExCSc794IJGAntlwH8e8y xd6UFCz9Z3GVx8rnF+slsCkD3SzaWeJfGQWos= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=F1ylLwSemoPrk+ iQjPqbuf3eCa8=; b=a5jkVQsvnxKXaDR8XxyHEJSHy1YJrR840epQlGTyF4MI3m UcTVMahqa2oZNK198HOFlRiVigRgEYpUOdc4LK4O4lR+y6sZ91a1y4PB8SolxGrs WvxMPC1A5c2AUhd8tndut8UMmf9SnK2HKaBvb1RXtqExL7Ho1cundUmlewcbA= X-ME-Sender: X-Sasl-enc: D8w7vRB84VZShIeqvmAOOV9hZMACLgWnoUXJzo05hgXA 1488825509 Received: from localhost (c-73-188-17-148.hsd1.pa.comcast.net [73.188.17.148]) by mail.messagingengine.com (Postfix) with ESMTPA id 97BBB245E2; Mon, 6 Mar 2017 13:38:29 -0500 (EST) Date: Mon, 6 Mar 2017 13:38:28 -0500 From: Leo Famulari Message-ID: <20170306183828.GC2185@jasmine> References: <87mvczch1w.fsf@gmail.com> <20170306030908.2599fc96@scratchpost.org> <87wpc3gkaj.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xesSdrSSBC0PokLI" Content-Disposition: inline In-Reply-To: <87wpc3gkaj.fsf@openmailbox.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --xesSdrSSBC0PokLI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 05, 2017 at 10:23:48PM -0500, Kei Kebreau wrote: > Danny Milosavljevic writes: > > It's not finished. http://git.suckless.org/surf/tree/config.def.h#n38 > > invokes xprop and dmenu - and these places would have to be > > substituted by store references, like: > > > > (substitute* "tree/config.def.h" > > (("xprop") (string-append (assoc-ref inputs "xprop") "/bin/xprop")) > > (("dmenu") (string-append (assoc-ref inputs "dmenu") "/bin/dmenu"))) > > > > I'm not sure whether Guix will retain the store references on the next > > GC, though. >=20 > I'm sure Guix does, considering we use this trick for all sorts of > packages, including important ones like shadow. Basically, after building the package, Guix scans the built output for store references. That is, strings like '/gnu/store/cabba9e...-foo-1.0/'. If it finds them, they are recorded in a database in $localstatedir. If the store references are obscured somehow [0], this method fails and things break. So, as long as 'tree/config.def.h' is included in the built output of surf as plaintext, everything should work. [0] For example, in cases like these: https://bugs.gnu.org/24703 https://bugs.gnu.org/20765 --xesSdrSSBC0PokLI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAli9rKQACgkQJkb6MLrK fwh+1g//Q66IYJxpclsspLAXbFHBmz0tO+Ia8Zh1sdEY1QDNLHXm1qBLfO4DLBTW yXwt1u6pnIN0z40w+yohMDDmaOJkVN+xQCDU6gg8pY/p3+Bt7z+Rn2aMJ4nFAkjr L4q/CqKTjNjSINaAXb4vTSUaklwfbHJVYnxQjQM6znJIYB3ppz0Y/SockMrEo6jW T9tuML7hpfgAevmzMaKlc8K7LzQbj3yKiglZagdyOeC9PHbnPCraFGhSPdxz5lgH I0JnKnTGsq5KTM75mnr93lwg5eARqJS72a6nI+OEAHDOO6LRMPwmo+HWdNyoW3Lb 5zvs7d4EzaXBMishI4n/JmJXBltn6lAmLb74QE6khrtmYz7+J5xHxw+h9fLYUZJS Z72Y/wdLygt2+MjEFUXj/jSS/U2EvSwI9fYhmYheGe0Ze4eV/ngi4k4O4ydJudPy RydVN3ygT/sg1RhT1RW1mbfwewxMNe4kUDDcfKLNG9K2/rWkuLwxf3CzgtwzcTt8 X+vvTc3rveBmN+RpBMambKO7bW/lMT0mLeHVn8hyqRWFajyW6CZs/QrwaI/Ov++k Xpk6Jk01U+msAZeTAheMXUbQUvBb44o6HJQgJwC5173OmGm/G5Uz4xuldb5yI8W1 m3QjCJ8foQ9FebT4MyTW+dYQG4g6DsUiyR1CwxyBU6nx6QIvVew= =xvKB -----END PGP SIGNATURE----- --xesSdrSSBC0PokLI-- From unknown Sat Sep 20 06:23:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25991: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. Resent-From: Mekeor Melire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Mar 2017 19:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25991 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kei Kebreau Cc: Danny Milosavljevic , 25991@debbugs.gnu.org, Mekeor Melire Received: via spool by 25991-submit@debbugs.gnu.org id=B25991.148882728727227 (code B ref 25991); Mon, 06 Mar 2017 19:09:02 +0000 Received: (at 25991) by debbugs.gnu.org; 6 Mar 2017 19:08:07 +0000 Received: from localhost ([127.0.0.1]:43172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckxzK-000755-VV for submit@debbugs.gnu.org; Mon, 06 Mar 2017 14:08:07 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckxzJ-00074c-F2 for 25991@debbugs.gnu.org; Mon, 06 Mar 2017 14:08:05 -0500 Received: by mail-wr0-f194.google.com with SMTP id u48so22977842wrc.1 for <25991@debbugs.gnu.org>; Mon, 06 Mar 2017 11:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=M/pfPFasB+GRFu6p3ePprTCA/ig184V/KvgEti1TyLk=; b=JL8VPJ1A7ekkrkkwE44lFZdpkR9Xb6deLm42A9MPYdYfEp3RusNdwwqYZtJ3/8Uo+v xk/7YTH53Dd/Na8j2mf4MPPx9s6jtCoWCf8HXFHtdRClSooc7NOgS/CV/Dc6cvobLkdQ enWtdvOAvel50X5AnTXPphmrF0ZpTK1ouYjJX3Dx0iYQMg9PGt2Pchy0kYX189J/LJ8I rK4zdatUHDFvj6GF+dpYA3hjhwS0YhJ0a5e5Tj/ke6deDDGHR83A4Uvc7eHTP1nGcgK5 PlYhJI04oVhyTbiznJPs9udohGUSMVoQyNS66K2ZPslTgD1FwvLNx8tDcSvodDPKksjX Pq3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=M/pfPFasB+GRFu6p3ePprTCA/ig184V/KvgEti1TyLk=; b=E5Jd/Fk9mmpv2mQXGJ5kTkLz8q2NVFKR3C8gzak/qUo0YeoMgj/jv7FhNiC2/LDSzS +sC9Wj01r16hcbtePAARFNWX0YeE5cGA8fQce4hl3a5fJW4u0M+HAzK5up1iF+tITIGv Cq3kdq9vfGzlyrVqBCH/haVPX66BPUmttGq8h0j4qA7ue07qeRW+zKSzDsSGuPkLIgvG xaq+1rJMB31QIvqsnm00U/YKsaG3WJas2m6KzUbYTmZ8FvX0iz9InUNg4ZbEbrWZU74Q VsrrvJxwmksPbap/8/4xdlbXHtTtAWH+EMtQtTbMxDy9IiaAvKOYZjYPFpL2Y4NI/Qyn UQrQ== X-Gm-Message-State: AMke39lGn/bTw9joJ5thxzE4npyvMFXz6Pyt0vAGEESSNU9OCKwb69FPpoBczW6Y09XTCQ== X-Received: by 10.223.150.10 with SMTP id b10mr15560999wra.98.1488827279843; Mon, 06 Mar 2017 11:07:59 -0800 (PST) Received: from melire. ([2001:a61:220b:9e01:5870:869d:4c38:2906]) by smtp.gmail.com with ESMTPSA id h3sm28148561wrb.31.2017.03.06.11.07.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Mar 2017 11:07:59 -0800 (PST) References: <87mvczch1w.fsf@gmail.com> <20170306030908.2599fc96@scratchpost.org> <87wpc3gkaj.fsf@openmailbox.org> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Mekeor Melire In-reply-to: <87wpc3gkaj.fsf@openmailbox.org> Date: Mon, 06 Mar 2017 20:07:45 +0100 Message-ID: <8737eqb4vy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain Hello Guix. I'm sorry, I was too careless about this. The new, revised patch is attached inline at the end. Kei Kebreau writes: > Danny Milosavljevic writes: > >> (substitute* "tree/config.def.h" >> (("xprop") (string-append (assoc-ref inputs "xprop") "/bin/xprop")) >> (("dmenu") (string-append (assoc-ref inputs "dmenu") "/bin/dmenu"))) -- mekeor ~ EDD3 DFFA 76F6 11C0 145F 9A99 AC85 BAD8 A2F8 C868 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-surf-Add-dmenu-and-xprop-to-inputs.patch Content-Description: gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. >From bb7b07e301305ce7f1d113b10d27e7d4130989c5 Mon Sep 17 00:00:00 2001 From: Mekeor Melire Date: Mon, 6 Mar 2017 02:36:47 +0100 Subject: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. * gnu/packages/suckless.scm (surf)[inputs]: Add dmenu and xprop. --- gnu/packages/suckless.scm | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index e30a0883a..33eb69ffb 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -255,11 +255,20 @@ drawing.") (string-append "PREFIX=" %output)) #:phases (modify-phases %standard-phases - (delete 'configure)))) + (delete 'configure) + ;; Use the right file name for dmenu and xprop. + (add-before 'build 'set-dmenu-and-xprop-file-name + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "tree/config.def.h" + (("dmenu") (string-append (assoc-ref inputs "dmenu") "/bin/dmenu")) + (("xprop") (string-append (assoc-ref inputs "xprop") "/bin/xprop"))) + #t))))) (inputs - `(("glib-networking" ,glib-networking) + `(("dmenu" ,dmenu) + ("glib-networking" ,glib-networking) ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) - ("webkitgtk" ,webkitgtk/gtk+-2))) + ("webkitgtk" ,webkitgtk/gtk+-2) + ("xprop" ,xprop))) (native-inputs `(("pkg-config" ,pkg-config))) (home-page "http://surf.suckless.org/") -- 2.12.0 --=-=-=-- From unknown Sat Sep 20 06:23:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25991: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Mar 2017 05:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25991 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mekeor Melire Cc: Danny Milosavljevic , 25991@debbugs.gnu.org Received: via spool by 25991-submit@debbugs.gnu.org id=B25991.14888649768520 (code B ref 25991); Tue, 07 Mar 2017 05:37:01 +0000 Received: (at 25991) by debbugs.gnu.org; 7 Mar 2017 05:36:16 +0000 Received: from localhost ([127.0.0.1]:43486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cl7nE-0002DM-GX for submit@debbugs.gnu.org; Tue, 07 Mar 2017 00:36:16 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:38150 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cl7nB-0002DC-Ba for 25991@debbugs.gnu.org; Tue, 07 Mar 2017 00:36:14 -0500 Received: by mail.openmailbox.org (Postfix, from userid 20002) id CD570504113; Tue, 7 Mar 2017 06:36:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1488864971; bh=hKpM0pec5OickzevCPYKH11svb8aqBgJ4fMUnLrjUA0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=D3urb6UmkgQtrnUTDJN1kVhzP2J+Y/IuahKCNHV1zaBTo6SxqtxYfsfmEbRLrav4/ plAXb+FF3vx1gCoK5jzAnFEWEKBZhbR+ITV2zw7/cJKE71nuh8KAssuvBA3arOewIy r+dN/TaK4aJFouymlzw+9hfHOGr6ceb66mq/IQmg= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR003 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1488864971; bh=hKpM0pec5OickzevCPYKH11svb8aqBgJ4fMUnLrjUA0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=D3urb6UmkgQtrnUTDJN1kVhzP2J+Y/IuahKCNHV1zaBTo6SxqtxYfsfmEbRLrav4/ plAXb+FF3vx1gCoK5jzAnFEWEKBZhbR+ITV2zw7/cJKE71nuh8KAssuvBA3arOewIy r+dN/TaK4aJFouymlzw+9hfHOGr6ceb66mq/IQmg= References: <87mvczch1w.fsf@gmail.com> <20170306030908.2599fc96@scratchpost.org> <87wpc3gkaj.fsf@openmailbox.org> <8737eqb4vy.fsf@gmail.com> Date: Tue, 07 Mar 2017 00:36:05 -0500 In-Reply-To: <8737eqb4vy.fsf@gmail.com> (Mekeor Melire's message of "Mon, 06 Mar 2017 20:07:45 +0100") Message-ID: <87r329hcmy.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mekeor Melire writes: > Hello Guix. > > I'm sorry, I was too careless about this. The new, revised patch is > attached inline at the end. > > Kei Kebreau writes: > >> Danny Milosavljevic writes: >> >>> (substitute* "tree/config.def.h" >>> (("xprop") (string-append (assoc-ref inputs "xprop") "/bin/xprop")) >>> (("dmenu") (string-append (assoc-ref inputs "dmenu") "/bin/dmenu"))) > > --=20 > mekeor ~ EDD3 DFFA 76F6 11C0 145F 9A99 AC85 BAD8 A2F8 C868 > >>>From bb7b07e301305ce7f1d113b10d27e7d4130989c5 Mon Sep 17 00:00:00 2001 > From: Mekeor Melire > Date: Mon, 6 Mar 2017 02:36:47 +0100 > Subject: [PATCH] gnu: surf: Add 'dmenu' and 'xprop' to 'inputs'. > > * gnu/packages/suckless.scm (surf)[inputs]: Add dmenu and xprop. > --- > gnu/packages/suckless.scm | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm > index e30a0883a..33eb69ffb 100644 > --- a/gnu/packages/suckless.scm > +++ b/gnu/packages/suckless.scm > @@ -255,11 +255,20 @@ drawing.") > (string-append "PREFIX=3D" %output)) > #:phases > (modify-phases %standard-phases > - (delete 'configure)))) > + (delete 'configure) > + ;; Use the right file name for dmenu and xprop. > + (add-before 'build 'set-dmenu-and-xprop-file-name > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "tree/config.def.h" It turns out we only needed "config.def.h" here. > + (("dmenu") (string-append (assoc-ref inputs "dmenu") "/bi= n/dmenu")) > + (("xprop") (string-append (assoc-ref inputs "xprop") "/bi= n/xprop"))) > + #t))))) > (inputs > - `(("glib-networking" ,glib-networking) > + `(("dmenu" ,dmenu) > + ("glib-networking" ,glib-networking) > ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) > - ("webkitgtk" ,webkitgtk/gtk+-2))) > + ("webkitgtk" ,webkitgtk/gtk+-2) > + ("xprop" ,xprop))) > (native-inputs > `(("pkg-config" ,pkg-config))) > (home-page "http://surf.suckless.org/") Works like a charm. Pushed to master as 45321beb7d6cc92ff20ef1811bcc8119bb822ed9 with info added about the new phase. Thanks for the patch! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAli+RsUACgkQ5qXuPBlG eg1mSg/9HfmLo/GwrXSFZnxdBtFigQau+qRuWiLOyefw2fYoM6r1iHsqPKMh/cP4 mjuugdIadRWl8yA18IGfXKDcH7SleGB+FQNJk24JyksrU49hfSM1EMlLNRUndrKn ogfi8FTih52+baYEkdfATfQziXW3VUa9OOHWAkxYDWuDWYko7JnvBp4ut1CKoGnL UAs8+jqNjsSDWZZHbm526g6J476GuDkayYa5CmrQqmtKRbNIZ+Gc2Pfcjfs4q2w/ Qr4oZJ7hucvr8HpFTVm+u32Y/jSuK5Fx0dfpjHeASJ0G7PPCT0Xl7Fq/a9Aksb9G 9ED7H/Ir7U2E7uNPlumV72Kc5TN/g/fCMtMcNzPnGLdfCg77A548IpKbB/CO9jOE wyuVlB1ORPZpdtCx3JzEKW5zZ/1HjDGu9LjEgWrTgLE3HtdCUo/9Op3cVpNFzSUS C5rKVEAwd4owuTxu7sR5LOXSXOzd9uwINiC01u5SaRKq3l4kIyb1WB4wvS5q1haq t/PeD10jkd1foYzBRdoS+TgO0bnzDfKoKT9y+tNrjia8BtCVxALDLPheYYdBSt0N Mv/gx0r4+c4x/yexIwAqa6Hqj/4eisnAcN9sOMp8SraeUDwoQ+tWu1CRO7afvEKa zYQYBQydDQahOyuK3n8CcDWTbngqMEiEmyp4EqA88jJ9cXzj2dA= =6KLV -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 07 12:04:59 2017 Received: (at control) by debbugs.gnu.org; 7 Mar 2017 17:04:59 +0000 Received: from localhost ([127.0.0.1]:44859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clIXi-0006CZ-TU for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:04:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clIXh-0006CG-3q for control@debbugs.gnu.org; Tue, 07 Mar 2017 12:04:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clIXY-00079o-VV for control@debbugs.gnu.org; Tue, 07 Mar 2017 12:04:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clIXY-00079i-SQ for control@debbugs.gnu.org; Tue, 07 Mar 2017 12:04:48 -0500 Received: from [193.50.110.248] (port=33032 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1clIXY-0004rR-9k for control@debbugs.gnu.org; Tue, 07 Mar 2017 12:04:48 -0500 Date: Tue, 07 Mar 2017 18:04:45 +0100 Message-Id: <87efy99fwy.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #25991 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) tags 25991 fixed close 25991