GNU bug report logs - #25987
25.2; support gcc fixit notes

Previous Next

Package: emacs;

Reported by: Tom Tromey <tom <at> tromey.com>

Date: Sun, 5 Mar 2017 21:49:01 UTC

Severity: wishlist

Merged with 29004

Found in versions 25.2, 27.0.50

Full log


View this message in rfc822 format

From: Tom Tromey <tom <at> tromey.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 25987 <at> debbugs.gnu.org, Tom Tromey <tom <at> tromey.com>
Subject: bug#25987: 25.2; support gcc fixit notes
Date: Sat, 05 Aug 2017 21:31:22 -0600
>>>>> "Dmitry" == Dmitry Gutov <dgutov <at> yandex.ru> writes:

>> * One way for this to work would be to display the buffer and
>> show the proposed change as an overlay; and then use y-or-n-p
>> to ask whether it should be applied.  I was thinking something like:
[...]

Dmitry> I'm not sure we want to tie this feature to compilation-mode. Many
Dmitry> modes that derive from it don't support fix-its, e.g. those of them
Dmitry> that run the test suites. And even for those that do, Compilation
Dmitry> provides a very basic UI.

To me it seems very natural.  I compile, then as I next-error through
the results, Emacs offers to apply a change.

I think it's fine that some sub-modes don't support fix-its.  Actually I
don't understand how that would be a problem.  Presumably `grep' or
whatever isn't going to emit a fixit note anyhow.

Dmitry> Even to find and apply all fix-its, we'd need to add some new buffer,
Dmitry> to show the list.

That doesn't seem necessary to me either.

Tom




This bug report was last modified 4 years and 248 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.