From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 11:20:24 2017 Received: (at submit) by debbugs.gnu.org; 4 Mar 2017 16:20:24 +0000 Received: from localhost ([127.0.0.1]:40193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckCPv-0000G9-Pn for submit@debbugs.gnu.org; Sat, 04 Mar 2017 11:20:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckCPu-0000Fx-L5 for submit@debbugs.gnu.org; Sat, 04 Mar 2017 11:20:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckCPo-00072G-LX for submit@debbugs.gnu.org; Sat, 04 Mar 2017 11:20:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48047) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ckCPo-000729-IK for submit@debbugs.gnu.org; Sat, 04 Mar 2017 11:20:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckCPn-0002PP-9r for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 11:20:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckCPk-00071N-4L for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 11:20:15 -0500 Received: from mail-qk0-f177.google.com ([209.85.220.177]:35904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckCPj-00070j-VC for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 11:20:12 -0500 Received: by mail-qk0-f177.google.com with SMTP id 1so100212480qkl.3 for ; Sat, 04 Mar 2017 08:20:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:message-id:subject:mime-version; bh=simfx4Qe2MTWbObNOULmgIAV5YjqNY3Q5EwSrlKQdDk=; b=iLFuczPpNvtF5D7hjAqn/5Hqjj5xGOwBNRc5gPuzXfdrTOrH1eATB3ASxnPOapPLdi uYinJpoOQxzA+b7XL+2NcHNyiJJ/ACVsxJN8su50Yq5ya/oXjUeQGOd9MiQTGlcnn3JD NbPXnjfqOvn+FKQHBvvd+IhD/bJmzY/UQw9H/eMLBAdwb2byncvT4eqe8Kj72cwEiPqJ ZHdXXkjVpRsRw1kc5YKMFSx8phm7v5dgv4tiy+HxR59Wze4cSgmCPQYlqsBngZ8sbxaz NrBCmQyrDn+U7S4O/8LRrrdNsQiQJUvlyuX6pn9GF/H5ExLVMYO9hZf3iwSBUk5L2U9O nyjQ== X-Gm-Message-State: AMke39n+QQhh+lzpn2vEFJgNOxb8Ud9lgFEXka2/lNj8aLZdThJSVifD9RF+2zWhyIKSqg== X-Received: by 10.55.110.6 with SMTP id j6mr7945479qkc.67.1488644409269; Sat, 04 Mar 2017 08:20:09 -0800 (PST) Received: from [2601:184:4500:e8f5:c809:6193:70::] ([2601:184:4500:e8f5:8805:57dd:af73:8d62]) by smtp.gmail.com with ESMTPSA id e5sm1687907qtc.6.2017.03.04.08.20.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 08:20:08 -0800 (PST) Date: Sat, 4 Mar 2017 11:17:41 -0500 From: Tej Chajed To: bug-gnu-emacs@gnu.org Message-ID: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> Subject: 25.1; Support for ImageMagick 7 X-Readdle-Message-ID: 6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="58bae936_41b71efb_73ce" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) --58bae936_41b71efb_73ce Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Are there plans to upgrade from ImageMagick 6 to 7=3F I ask because I=E2=80= =99m fixing imagemagick support for the Emacs formula in Homebrew (pull =23= 10477) and Homebrew has to depend on the legacy ImageMagick 6 to build Em= acs with ImageMagick support. It looks like there was a brief discussion on emacs-devel about this in a= thread about the 64-bit Windows build, where the belief was that ImageMa= gick 7 is too unstable to use. If this is indeed the case it makes sense = to stick with ImageMagick 6 but I don=E2=80=99t think there was much of a= n explicit discussion about upgrading in that thread. --58bae936_41b71efb_73ce Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Are there plans = to upgrade from ImageMagick 6 to 7=3F I ask because I=E2=80=99m fixing im= agemagick support for the Emacs formula in Homebrew (pull =2310477) and H= omebrew has to depend on the legacy ImageMagick 6 to build Emacs with Ima= geMagick support.

It looks like there was a brief discussion on emacs-deve= l about this in a thread about the 64-bit Windows build, where the be= lief was that ImageMagick 7 is too unstable to use. If this is indeed the= case it makes sense to stick with ImageMagick 6 but I don=E2=80=99t thin= k there was much of an explicit discussion about upgrading in that thread= .
--58bae936_41b71efb_73ce-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 12:56:14 2017 Received: (at control) by debbugs.gnu.org; 5 Mar 2017 17:56:14 +0000 Received: from localhost ([127.0.0.1]:41235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckaOE-0001Cd-05 for submit@debbugs.gnu.org; Sun, 05 Mar 2017 12:56:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckaOD-0001CS-0R for control@debbugs.gnu.org; Sun, 05 Mar 2017 12:56:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckaO7-0002En-AN for control@debbugs.gnu.org; Sun, 05 Mar 2017 12:56:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckaO7-0002Eh-6k for control@debbugs.gnu.org; Sun, 05 Mar 2017 12:56:07 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ckaO6-0005bP-No for control@debbugs.gnu.org; Sun, 05 Mar 2017 12:56:06 -0500 Subject: control message for bug 24655 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sun, 05 Mar 2017 12:56:06 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 24655 by 25967 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 14:03:56 2017 Received: (at 25967) by debbugs.gnu.org; 10 Mar 2017 19:03:57 +0000 Received: from localhost ([127.0.0.1]:49978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmPpU-0003lJ-JQ for submit@debbugs.gnu.org; Fri, 10 Mar 2017 14:03:56 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmPpS-0003l3-2m for 25967@debbugs.gnu.org; Fri, 10 Mar 2017 14:03:54 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A0092160064; Fri, 10 Mar 2017 11:03:47 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id P9EDwMmcJ2GJ; Fri, 10 Mar 2017 11:03:47 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 04B86160072; Fri, 10 Mar 2017 11:03:47 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GFmaaGlO3IBg; Fri, 10 Mar 2017 11:03:46 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E1E31160064; Fri, 10 Mar 2017 11:03:46 -0800 (PST) To: Tej Chajed From: Paul Eggert Subject: 25.1; Support for ImageMagick 7 Organization: UCLA Computer Science Department Message-ID: <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> Date: Fri, 10 Mar 2017 11:03:46 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25967 Cc: 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I don't know of anyone currently working on porting Emacs to ImageMagick 7. It'd be nice if someone would volunteer to do that. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 14:04:21 2017 Received: (at control) by debbugs.gnu.org; 10 Mar 2017 19:04:21 +0000 Received: from localhost ([127.0.0.1]:49982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmPps-0003mN-UN for submit@debbugs.gnu.org; Fri, 10 Mar 2017 14:04:21 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmPpr-0003m6-Bg for control@debbugs.gnu.org; Fri, 10 Mar 2017 14:04:19 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 08AE8160064 for ; Fri, 10 Mar 2017 11:04:14 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id dvP2gNzpSl3v for ; Fri, 10 Mar 2017 11:04:13 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5AAD8160072 for ; Fri, 10 Mar 2017 11:04:13 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EvRDG_xfqqyI for ; Fri, 10 Mar 2017 11:04:13 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 43B92160064 for ; Fri, 10 Mar 2017 11:04:13 -0800 (PST) To: control@debbugs.gnu.org From: Paul Eggert Subject: 25967 is wishist Organization: UCLA Computer Science Department Message-ID: <044e13fa-a11b-57a6-4c99-93e5e1ee621b@cs.ucla.edu> Date: Fri, 10 Mar 2017 11:04:13 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) severity 25967 wishlist From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 24 12:42:11 2017 Received: (at 25967) by debbugs.gnu.org; 24 Jul 2017 16:42:11 +0000 Received: from localhost ([127.0.0.1]:54524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZgQs-0008N8-Pm for submit@debbugs.gnu.org; Mon, 24 Jul 2017 12:42:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZgQr-0008Mr-An for 25967@debbugs.gnu.org; Mon, 24 Jul 2017 12:42:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZgQl-0007bI-GY for 25967@debbugs.gnu.org; Mon, 24 Jul 2017 12:42:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZgQi-0007aF-4v; Mon, 24 Jul 2017 12:42:00 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dZgQh-0002Z8-N3; Mon, 24 Jul 2017 12:41:59 -0400 From: Glenn Morris To: Paul Eggert Subject: Re: bug#25967: 25.1; Support for ImageMagick 7 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> X-Spook: Tornado Center for Disease Control Mossad Lockdown FAMS X-Ran: *e/MV%8YRpqNmxvE,Dvv?||/zz.F'[rj\2wVTZ7BO#R8F`L2;B*8Ivh6-s]c$fs79Sj X-Hue: blue X-Attribution: GM Date: Mon, 24 Jul 2017 12:41:59 -0400 In-Reply-To: <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> (Paul Eggert's message of "Fri, 10 Mar 2017 11:03:46 -0800") Message-ID: <9ginihyeg8.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.8 (-------) X-Debbugs-Envelope-To: 25967 Cc: Tej Chajed , 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.8 (-------) Paul Eggert wrote: > I don't know of anyone currently working on porting Emacs to > ImageMagick 7. It'd be nice if someone would volunteer to do that. There seems to be a patch at http://lists.gnu.org/archive/html/emacs-devel/2017-01/msg00180.html Maybe it is MS-Windows-specific though, I haven't examined it. In the meantime, configure should explicitly reject versions > 6, to avoid confusion. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 24 18:15:49 2017 Received: (at 25967) by debbugs.gnu.org; 24 Jul 2017 22:15:49 +0000 Received: from localhost ([127.0.0.1]:54764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZldk-0003RJ-OQ for submit@debbugs.gnu.org; Mon, 24 Jul 2017 18:15:48 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZldi-0003R5-MQ for 25967@debbugs.gnu.org; Mon, 24 Jul 2017 18:15:47 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A89C5160238; Mon, 24 Jul 2017 15:15:40 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ajW7gme_n1gs; Mon, 24 Jul 2017 15:15:36 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 70FC916023A; Mon, 24 Jul 2017 15:15:36 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id S2ALMmamCnTQ; Mon, 24 Jul 2017 15:15:36 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4FC1F160226; Mon, 24 Jul 2017 15:15:36 -0700 (PDT) Subject: Re: bug#25967: 25.1; Support for ImageMagick 7 To: Glenn Morris References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> <9ginihyeg8.fsf@fencepost.gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <06f4a735-2915-14e4-e5db-0df6ca6c5484@cs.ucla.edu> Date: Mon, 24 Jul 2017 15:15:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <9ginihyeg8.fsf@fencepost.gnu.org> Content-Type: multipart/mixed; boundary="------------67080A5253DB06DF81809EAB" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25967 Cc: Tej Chajed , 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------67080A5253DB06DF81809EAB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Glenn Morris wrote: > http://lists.gnu.org/archive/html/emacs-devel/2017-01/msg00180.html >=20 > Maybe it is MS-Windows-specific though, I haven't examined it. It looks quite MS-Windows-specific, unfortunately. > In the meantime, configure should explicitly reject versions > 6, to > avoid confusion. That's easy enough; I installed the attached. --------------67080A5253DB06DF81809EAB Content-Type: text/x-patch; name="0001-Do-not-use-ImageMagick-7-and-later.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Do-not-use-ImageMagick-7-and-later.patch" =46rom bc78bd0be41a2438a522df9fa3f46b64589403dc Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 24 Jul 2017 15:13:26 -0700 Subject: [PATCH] Do not use ImageMagick 7 and later Suggested by Glenn Morris (Bug#25967#15). * configure.ac (IMAGEMAGICK_MODULE): Reject 7 and later. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 5e6dbda..648da99 100644 --- a/configure.ac +++ b/configure.ac @@ -2507,7 +2507,8 @@ AC_DEFUN if test "${with_imagemagick}" !=3D "no"; then ## 6.3.5 is the earliest version known to work; see Bug#17339. ## 6.8.2 makes Emacs crash; see Bug#13867. - IMAGEMAGICK_MODULE=3D"Wand >=3D 6.3.5 Wand !=3D 6.8.2" + ## 7 and later have not been ported to; See Bug#25967. + IMAGEMAGICK_MODULE=3D"Wand >=3D 6.3.5 Wand !=3D 6.8.2 Wand < 7" EMACS_CHECK_MODULES([IMAGEMAGICK], [$IMAGEMAGICK_MODULE]) =20 if test $HAVE_IMAGEMAGICK =3D yes; then --=20 2.7.4 --------------67080A5253DB06DF81809EAB-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 24 21:25:26 2017 Received: (at 25967) by debbugs.gnu.org; 25 Jul 2017 01:25:26 +0000 Received: from localhost ([127.0.0.1]:54864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZobG-0007nF-2M for submit@debbugs.gnu.org; Mon, 24 Jul 2017 21:25:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZobE-0007n0-Sx for 25967@debbugs.gnu.org; Mon, 24 Jul 2017 21:25:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZob9-00071f-1L for 25967@debbugs.gnu.org; Mon, 24 Jul 2017 21:25:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZob4-0006zx-Hx; Mon, 24 Jul 2017 21:25:14 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dZob4-00075t-4C; Mon, 24 Jul 2017 21:25:14 -0400 From: Glenn Morris To: Paul Eggert Subject: Re: bug#25967: 25.1; Support for ImageMagick 7 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> <9ginihyeg8.fsf@fencepost.gnu.org> <06f4a735-2915-14e4-e5db-0df6ca6c5484@cs.ucla.edu> X-Spook: Kosovo Nationalist BLU-97 A/B cryptographic UOP X-Ran: Gz/CKn@L*t5=oUYs5q\fU^D!;.`:";XBlANky/GGvMf@ (Paul Eggert's message of "Mon, 24 Jul 2017 15:15:36 -0700") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.8 (-------) X-Debbugs-Envelope-To: 25967 Cc: Tej Chajed , 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.8 (-------) Paul Eggert wrote: >> In the meantime, configure should explicitly reject versions > 6, to >> avoid confusion. > > That's easy enough; I installed the attached. I think it would be nicer if: checking for IMAGEMAGICK... no became checking for IMAGEMAGICK (version 6)... no From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 09:06:58 2017 Received: (at control) by debbugs.gnu.org; 2 Sep 2017 13:06:58 +0000 Received: from localhost ([127.0.0.1]:41817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do88Y-0002Il-9r for submit@debbugs.gnu.org; Sat, 02 Sep 2017 09:06:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do88X-0002IY-Br for control@debbugs.gnu.org; Sat, 02 Sep 2017 09:06:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do88M-0002rC-8q for control@debbugs.gnu.org; Sat, 02 Sep 2017 09:06:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do88M-0002r3-6N; Sat, 02 Sep 2017 09:06:46 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2125 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1do88L-0001Ih-CT; Sat, 02 Sep 2017 09:06:45 -0400 Date: Sat, 02 Sep 2017 16:06:36 +0300 Message-Id: <83k21hz1ur.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Mon, 24 Jul 2017 21:25:13 -0400) Subject: Re: bug#25967: 25.1; Support for ImageMagick 7 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> <9ginihyeg8.fsf@fencepost.gnu.org> <06f4a735-2915-14e4-e5db-0df6ca6c5484@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control Cc: tchajed@mit.edu, 25967@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) unblock 24655 by 25967 thanks > From: Glenn Morris > Date: Mon, 24 Jul 2017 21:25:13 -0400 > Cc: Tej Chajed , 25967@debbugs.gnu.org > > Paul Eggert wrote: > > >> In the meantime, configure should explicitly reject versions > 6, to > >> avoid confusion. > > > > That's easy enough; I installed the attached. > > I think it would be nicer if: > > checking for IMAGEMAGICK... no > > became > > checking for IMAGEMAGICK (version 6)... no I agree that would be nicer, but I don't think this minor issue, nor the more general one of supporting ImageMagick 7, should block the release of Emacs 26.1. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 21:11:12 2017 Received: (at 25967) by debbugs.gnu.org; 3 Sep 2017 01:11:12 +0000 Received: from localhost ([127.0.0.1]:44307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doJRP-0007aD-U5 for submit@debbugs.gnu.org; Sat, 02 Sep 2017 21:11:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doJRO-0007a1-Hc for 25967@debbugs.gnu.org; Sat, 02 Sep 2017 21:11:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doJRE-0004zR-TB for 25967@debbugs.gnu.org; Sat, 02 Sep 2017 21:11:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD, UNRESOLVED_TEMPLATE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doJR4-0004r0-2V; Sat, 02 Sep 2017 21:10:50 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1doJR3-0005Ko-Du; Sat, 02 Sep 2017 21:10:49 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#25967: 25.1; Support for ImageMagick 7 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> <9ginihyeg8.fsf@fencepost.gnu.org> <06f4a735-2915-14e4-e5db-0df6ca6c5484@cs.ucla.edu> <83k21hz1ur.fsf@gnu.org> X-Spook: Noriega Wave First responder DEA Water borne Uzbekistan X-Ran: {4U*6/S-_\nUF+aW0dU2K?~jBmjW#3_iASnY*NQ5^FKlrubc'c&%BYF%(XnfaF"7h=^F+3 X-Hue: brightcyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sat, 02 Sep 2017 21:10:49 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 25967 Cc: tchajed@mit.edu, 25967@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Eli Zaretskii wrote: > I agree that would be nicer, but I don't think this minor issue, nor > the more general one of supporting ImageMagick 7, should block the > release of Emacs 26.1. My motivation was that at some point ImageMagick 7 will become the default version in GNU/Linux distributions. For example, possibly as soon as Fedora 28, next May, ref https://pagure.io/fesco/issue/1766 In terms of Emacs releases, this kind of change isn't far away, and quite possibly before Emacs 27. At some point Emacs will need to support it. Reference porting info: https://www.imagemagick.org/script/porting.php From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 12:00:07 2017 Received: (at 25967) by debbugs.gnu.org; 12 Dec 2017 17:00:07 +0000 Received: from localhost ([127.0.0.1]:58785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOnuY-0004i2-78 for submit@debbugs.gnu.org; Tue, 12 Dec 2017 12:00:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOnuW-0004gz-5F for 25967@debbugs.gnu.org; Tue, 12 Dec 2017 12:00:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOnuQ-0008GQ-3h for 25967@debbugs.gnu.org; Tue, 12 Dec 2017 11:59:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD, UNRESOLVED_TEMPLATE autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOnuP-0008GE-WB; Tue, 12 Dec 2017 11:59:58 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eOnuP-0007fh-D2; Tue, 12 Dec 2017 11:59:57 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#25967: 25.1; Support for ImageMagick 7 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> <9ginihyeg8.fsf@fencepost.gnu.org> <06f4a735-2915-14e4-e5db-0df6ca6c5484@cs.ucla.edu> <83k21hz1ur.fsf@gnu.org> X-Spook: defense information warfare Glock Somolia Sinaloa SCUD X-Ran: T|>K$>wW:S;^%rZ4ynv)(8$[XN.jtKmI)zXL|%W_pt&b2lAan0jCHUTe1KUw_|P67J+@XP X-Hue: brightwhite X-Attribution: GM Date: Tue, 12 Dec 2017 11:59:57 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 25967 Cc: tchajed@mit.edu, 25967@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Glenn Morris wrote: > My motivation was that at some point ImageMagick 7 will become the > default version in GNU/Linux distributions. For example, possibly as > soon as Fedora 28, next May, ref > > https://pagure.io/fesco/issue/1766 > > In terms of Emacs releases, this kind of change isn't far away, and > quite possibly before Emacs 27. At some point Emacs will need to support it. Seems to have happened already in Arch Linux. https://git.archlinux.org/svntogit/packages.git/log/trunk?h=packages/imagemagick From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 12:16:32 2017 Received: (at 25967) by debbugs.gnu.org; 12 Dec 2017 17:16:32 +0000 Received: from localhost ([127.0.0.1]:58809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOoAS-0005B1-BX for submit@debbugs.gnu.org; Tue, 12 Dec 2017 12:16:32 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:56293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOoAP-0005Ao-6n for 25967@debbugs.gnu.org; Tue, 12 Dec 2017 12:16:29 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 63FBDE6B21; Tue, 12 Dec 2017 18:16:25 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Su3gUrAZpNyy; Tue, 12 Dec 2017 18:16:21 +0100 (CET) Received: from localhost (unknown [62.3.162.131]) by mail.mojserwer.eu (Postfix) with ESMTPSA id F386BE62BE; Tue, 12 Dec 2017 18:16:20 +0100 (CET) References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> <9ginihyeg8.fsf@fencepost.gnu.org> <06f4a735-2915-14e4-e5db-0df6ca6c5484@cs.ucla.edu> <83k21hz1ur.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Glenn Morris Subject: Re: bug#25967: 25.1; Support for ImageMagick 7 In-reply-to: Date: Tue, 12 Dec 2017 18:15:59 +0100 Message-ID: <87vahbeuk0.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25967 Cc: tchajed@mit.edu, Eli Zaretskii , eggert@cs.ucla.edu, 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2017-12-12, at 17:59, Glenn Morris wrote: > Glenn Morris wrote: > >> My motivation was that at some point ImageMagick 7 will become the >> default version in GNU/Linux distributions. For example, possibly as >> soon as Fedora 28, next May, ref >> >> https://pagure.io/fesco/issue/1766 >> >> In terms of Emacs releases, this kind of change isn't far away, and >> quite possibly before Emacs 27. At some point Emacs will need to support it. > > Seems to have happened already in Arch Linux. > > https://git.archlinux.org/svntogit/packages.git/log/trunk?h=packages/imagemagick Yes, exactly this bit me today. Is there a chance that this could be fixed soon? Can I help that happen? -- Marcin Borkowski From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 12:44:41 2017 Received: (at 25967) by debbugs.gnu.org; 12 Dec 2017 17:44:41 +0000 Received: from localhost ([127.0.0.1]:58838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOobh-0005yO-L7 for submit@debbugs.gnu.org; Tue, 12 Dec 2017 12:44:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOobg-0005yB-Aq for 25967@debbugs.gnu.org; Tue, 12 Dec 2017 12:44:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOoba-0003aT-7G for 25967@debbugs.gnu.org; Tue, 12 Dec 2017 12:44:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOobN-0003Sj-AR; Tue, 12 Dec 2017 12:44:21 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eOobM-0003IA-Sk; Tue, 12 Dec 2017 12:44:20 -0500 From: Glenn Morris To: Marcin Borkowski Subject: Re: bug#25967: 25.1; Support for ImageMagick 7 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <6036e279-8f34-68cf-7717-3971a29b4932@cs.ucla.edu> <9ginihyeg8.fsf@fencepost.gnu.org> <06f4a735-2915-14e4-e5db-0df6ca6c5484@cs.ucla.edu> <83k21hz1ur.fsf@gnu.org> <87vahbeuk0.fsf@mbork.pl> X-Spook: Reno New World Order assassinate Aldergrove Osama USCODE X-Ran: DnNEn|0/#0LcmP0#Z0]h3!OuoT8Q#G#,bQwQ16\NYNC0 (Marcin Borkowski's message of "Tue, 12 Dec 2017 18:15:59 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25967 Cc: tchajed@mit.edu, Eli Zaretskii , eggert@cs.ucla.edu, 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Marcin Borkowski wrote: > Yes, exactly this bit me today. (If you just want things to work, probably you could install "imagemagick6". https://www.archlinux.org/packages/extra/x86_64/imagemagick6/ ) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 01 15:18:03 2018 Received: (at 25967) by debbugs.gnu.org; 1 Jun 2018 19:18:03 +0000 Received: from localhost ([127.0.0.1]:58188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOpYp-00009s-Cj for submit@debbugs.gnu.org; Fri, 01 Jun 2018 15:18:03 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:35745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOpYl-00009F-W6 for 25967@debbugs.gnu.org; Fri, 01 Jun 2018 15:18:01 -0400 Received: by mail-it0-f48.google.com with SMTP id a3-v6so3127869itd.0 for <25967@debbugs.gnu.org>; Fri, 01 Jun 2018 12:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=Fd7jusWSjbgoYH0m7R4VKKgnAmGl7HsSqClwEGq+gZA=; b=xi4tndz3QGm2lGNZkOydV0m0JR6o0uk4xjkoGrVR74KmGbeSKFilvGHuIcDpc9yfV+ 2hZiOubI13DA/OPnVj2VGsDVK+5QErjm32qlsdWfenY8lkgx0ERqSPw1fnyoD1+PT5YK rGwJITMH0pMbNsZd/a/HZKMO+mTHRm+U8rSJ5jATcY2E5IEbHxBbEDUHaVhzndQkb+MC bx4iQ/5KlFi4xsx0ctljG3KkdHKsKNrz4OWXCRDm+s6l1X75jtKcyjXfOe8+zN6NOAQ7 FthUIB9/XRaySyHTcJhppV/qW2uYcn+vIvY+y3CJUnIMHlYK31bHDvaeJ7PIw/NqVTc5 J5uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Fd7jusWSjbgoYH0m7R4VKKgnAmGl7HsSqClwEGq+gZA=; b=Lia8QSpAtg8XRmxB82IVYkgx2HByDBMSf596I1juFjJ23af8jRFECbaVXGhZ6ybhCd O+7oRe+v2NsGc8+tBNxHVLLULjU1DlDAX6PbaqgyWReaDFEg0VhXrD+VoFIpaGEwhHTN +m1SKqn+zCnjmbVwMXQl7fd6aFEUTp5SKeL9jD8k6oadCUDwiSOUhihtUWNZo5G3vXcB jRWVqDvvzVjm8aSMuxFoZFFQsKbXWt4G08S9zaWg4s1tmmTS9nsBwVcB9ik7/dw5sJlG 8XaSWLDA8d3vzK29hJRCUE4ClWKdOIqPMAYQ9zysyzdwphJQOgrdqbsg7WUDrLLNDMRi dYEg== X-Gm-Message-State: ALKqPwcCdsLD3q3vAoSlFMf27Bm1RbF9a9Y8JPidcP643X6yP81JRbIu HcrCGDe8JwxDMAAhnUS/ceYrAgiZW5g= X-Google-Smtp-Source: ADUXVKKxUydAwNCEslsFaTaLIRsnNuKQKniqmVb5EuB/CWEBR0N3vnKa86lzT5HQc/R4rKq934cxfA== X-Received: by 2002:a24:b95e:: with SMTP id k30-v6mr5819890iti.82.1527880674368; Fri, 01 Jun 2018 12:17:54 -0700 (PDT) Received: from mail-it0-f53.google.com (mail-it0-f53.google.com. [209.85.214.53]) by smtp.gmail.com with ESMTPSA id 131-v6sm1592369itv.29.2018.06.01.12.17.53 for <25967@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jun 2018 12:17:53 -0700 (PDT) Received: by mail-it0-f53.google.com with SMTP id d10-v6so3068075itj.1 for <25967@debbugs.gnu.org>; Fri, 01 Jun 2018 12:17:53 -0700 (PDT) X-Received: by 2002:a24:7a92:: with SMTP id a140-v6mr5335628itc.123.1527880672972; Fri, 01 Jun 2018 12:17:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:41d4:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 12:17:32 -0700 (PDT) From: Karl Otness Date: Fri, 1 Jun 2018 14:17:32 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: [PATCH] Add support for ImageMagick 7 (Bug#25967) To: 25967@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000c5cd14056d9970c6" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25967 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c5cd14056d9970c6 Content-Type: text/plain; charset="UTF-8" I have attached a patch which adds support for ImageMagick version 7. I have tried to keep compatibility with version 6 as well. I have gotten clean builds against both versions on my machine (running Arch and overriding PKG_CONFIG_PATH to test). I also did a quick build on a Mac and it also seemed to link up to the ImageMagick 7 from homebrew. On both machines I could open/resize/rotate images and page through the frames of animated GIFs. The changes that seem to be needed are doable with a #define and a typedef to rename a function and type in image.c. The patch makes these conditional on the major version that is found by pkg-config during ./configure, trying version 7 first and falling back to 6. I'm not very familiar with autoconf, but the conditional checking in the patch seems to work and avoids checking for ImageMagick 6 if it finds version 7 first. I used AS_IF for this rather than the action arguments to EMACS_CHECK_MODULES since this way seems to avoid the redundant checks. Thanks, Karl --000000000000c5cd14056d9970c6 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-support-for-ImageMagick-7-Bug-25967.patch" Content-Disposition: attachment; filename="0001-Add-support-for-ImageMagick-7-Bug-25967.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jhwamj5b0 RnJvbSAyZDliOWU2MTFlMWMwODI0MDgzMGNiYjk5ZmU0NDVhOTljYzkzNTk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXJsIE90bmVzcyA8a2FybEBrYXJsb3RuZXNzLmNvbT4KRGF0 ZTogVGh1LCAzMSBNYXkgMjAxOCAxOToyMzoyMSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBz dXBwb3J0IGZvciBJbWFnZU1hZ2ljayA3IChCdWcjMjU5NjcpCgoqIGNvbmZpZ3VyZS5hYzogQWxs b3cgbGlua2luZyB0byBJbWFnZU1hZ2ljayA3IGFuZCBleHBvc2UgdGhlIG1ham9yCnZlcnNpb24g Zm91bmQgdG8gdGhlIHJlc3Qgb2YgYnVpbGQuCiogc3JjL2ltYWdlLmMgW01hZ2lja1dhbmQgPj0g N106IERlZmluZSBmdW5jdGlvbnMgYW5kIHR5cGVzIGZvcgpJbWFnZU1hZ2ljayA3IGNvbXBhdGli aWxpdHkuCi0tLQogY29uZmlndXJlLmFjIHwgMTcgKysrKysrKysrKysrKy0tLS0KIHNyYy9pbWFn ZS5jICB8IDE1ICsrKysrKysrKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3Vy ZS5hYwppbmRleCBhMTFhYmMxYjY1Li5jM2E1NDAxNTcwIDEwMDY0NAotLS0gYS9jb25maWd1cmUu YWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0yNTQ5LDkgKzI1NDksMTYgQEAgQUNfREVGVU4KIAog ICAgICMjIDYuMy41IGlzIHRoZSBlYXJsaWVzdCB2ZXJzaW9uIGtub3duIHRvIHdvcms7IHNlZSBC dWcjMTczMzkuCiAgICAgIyMgNi44LjIgbWFrZXMgRW1hY3MgY3Jhc2g7IHNlZSBCdWcjMTM4Njcu Ci0gICAgIyMgNyBhbmQgbGF0ZXIgaGF2ZSBub3QgYmVlbiBwb3J0ZWQgdG87IFNlZSBCdWcjMjU5 NjcuCi0gICAgSU1BR0VNQUdJQ0tfTU9EVUxFPSJXYW5kID49IDYuMy41IFdhbmQgIT0gNi44LjIg V2FuZCA8IDciCi0gICAgRU1BQ1NfQ0hFQ0tfTU9EVUxFUyhbSU1BR0VNQUdJQ0tdLCBbJElNQUdF TUFHSUNLX01PRFVMRV0pCisgICAgSU1BR0VNQUdJQ0s3X01PRFVMRT0iTWFnaWNrV2FuZCA+PSA3 IgorICAgIElNQUdFTUFHSUNLNl9NT0RVTEU9IldhbmQgPj0gNi4zLjUgV2FuZCAhPSA2LjguMiIK KyAgICAjIEFzIHdlIGNoZWNrIGZvciBJbWFnZU1hZ2ljayA3IHRoZW4gNiB0cmFjayB3aGljaCB2 ZXJzaW9uIHdlIGZpbmQKKyAgICBFTUFDU19DSEVDS19NT0RVTEVTKFtJTUFHRU1BR0lDS10sIFsk SU1BR0VNQUdJQ0s3X01PRFVMRV0pCisgICAgQVNfSUYoW3Rlc3QgJEhBVkVfSU1BR0VNQUdJQ0sg PSB5ZXNdLAorICAgICAgW0lNQUdFTUFHSUNLX01BSk9SPTddLAorICAgICAgWworICAgICAgICBF TUFDU19DSEVDS19NT0RVTEVTKFtJTUFHRU1BR0lDS10sIFskSU1BR0VNQUdJQ0s2X01PRFVMRV0p CisgICAgICAgIEFTX0lGKFt0ZXN0ICRIQVZFX0lNQUdFTUFHSUNLID0geWVzXSwgW0lNQUdFTUFH SUNLX01BSk9SPTZdKQorICAgICAgXSkKIAogICAgIGlmIHRlc3QgJEhBVkVfSU1BR0VNQUdJQ0sg PSB5ZXM7IHRoZW4KICAgICAgIE9MRF9DRkxBR1M9JENGTEFHUwpAQCAtMjU3MSw2ICsyNTc4LDgg QEAgQUNfREVGVU4KICAgICBmaQogICAgIGlmIHRlc3QgJEhBVkVfSU1BR0VNQUdJQ0sgPSB5ZXM7 IHRoZW4KICAgICAgIEFDX0RFRklORShbSEFWRV9JTUFHRU1BR0lDS10sIDEsIFtEZWZpbmUgdG8g MSBpZiB1c2luZyBJbWFnZU1hZ2ljay5dKQorICAgICAgQUNfREVGSU5FX1VOUVVPVEVEKFtJTUFH RU1BR0lDS19NQUpPUl0sIFskSU1BR0VNQUdJQ0tfTUFKT1JdLAorICAgICAgICAgICAgICAgICAg ICAgICAgIFtJbWFnZU1hZ2ljayBtYWpvciB2ZXJzaW9uIG51bWJlciAoZnJvbSBjb25maWd1cmUp Ll0pCiAgICAgZWxzZQogICAgICAgSU1BR0VNQUdJQ0tfQ0ZMQUdTPQogICAgICAgSU1BR0VNQUdJ Q0tfTElCUz0KQEAgLTU0NTgsNyArNTQ2Nyw3IEBAIEFDX0RFRlVOCiAgIERvZXMgRW1hY3MgdXNl IC1scnN2Zy0yPyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJHtIQVZFX1JTVkd9CiAg IERvZXMgRW1hY3MgdXNlIGNhaXJvPyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JHtIQVZFX0NBSVJPfQogICBEb2VzIEVtYWNzIHVzZSAtbGxjbXMyPyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICR7SEFWRV9MQ01TMn0KLSAgRG9lcyBFbWFjcyB1c2UgaW1hZ2VtYWdp Y2sgKHZlcnNpb24gNik/ICAgICAgICAgICAgICAgICAke0hBVkVfSU1BR0VNQUdJQ0t9CisgIERv ZXMgRW1hY3MgdXNlIGltYWdlbWFnaWNrPyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJHtI QVZFX0lNQUdFTUFHSUNLfQogICBEb2VzIEVtYWNzIHN1cHBvcnQgc291bmQ/ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICR7SEFWRV9TT1VORH0KICAgRG9lcyBFbWFjcyB1c2UgLWxncG0/ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAke0hBVkVfR1BNfQogICBEb2VzIEVt YWNzIHVzZSAtbGRidXM/ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICR7SEFWRV9E QlVTfQpkaWZmIC0tZ2l0IGEvc3JjL2ltYWdlLmMgYi9zcmMvaW1hZ2UuYwppbmRleCA5OTJiMjI1 ZDdiLi4zYzEzNjZmNWNlIDEwMDY0NAotLS0gYS9zcmMvaW1hZ2UuYworKysgYi9zcmMvaW1hZ2Uu YwpAQCAtODI3MiwxMSArODI3MiwyMCBAQCBpbWFnZW1hZ2lja19pbWFnZV9wIChMaXNwX09iamVj dCBvYmplY3QpCiAvKiBUaGUgR0lGIGxpYnJhcnkgYWxzbyBkZWZpbmVzIERyYXdSZWN0YW5nbGUs IGJ1dCBpdHMgbmV2ZXIgdXNlZCBpbiBFbWFjcy4KICAgIFRoZXJlZm9yZSByZW5hbWUgdGhlIGZ1 bmN0aW9uIHNvIGl0IGRvZXNuJ3QgY29sbGlkZSB3aXRoIEltYWdlTWFnaWNrLiAgKi8KICNkZWZp bmUgRHJhd1JlY3RhbmdsZSBEcmF3UmVjdGFuZ2xlR2lmCi0jaW5jbHVkZSA8d2FuZC9NYWdpY2tX YW5kLmg+CisKKyNpZiBJTUFHRU1BR0lDS19NQUpPUiA9PSA2CisjIGluY2x1ZGUgPHdhbmQvTWFn aWNrV2FuZC5oPgorIyBpbmNsdWRlIDxtYWdpY2svdmVyc2lvbi5oPgorI2Vsc2UKKyMgaW5jbHVk ZSA8TWFnaWNrV2FuZC9NYWdpY2tXYW5kLmg+CisjIGluY2x1ZGUgPE1hZ2lja0NvcmUvdmVyc2lv bi5oPgorLyogSW1hZ2VNYWdpY2sgNyBjb21wYXRpYmlsaXR5IGRlZmluaXRpb25zICovCisjIGRl ZmluZSBQaXhlbFNldE1hZ2lja0NvbG9yIFBpeGVsU2V0UGl4ZWxDb2xvcgordHlwZWRlZiBQaXhl bEluZm8gTWFnaWNrUGl4ZWxQYWNrZXQ7CisjZW5kaWYKIAogLyogSW1hZ2VNYWdpY2sgNi41LjMg dGhyb3VnaCA2LjYuNSBoaWQgUGl4ZWxHZXRNYWdpY2tDb2xvciBmb3Igc29tZSByZWFzb24uCiAg ICBFbWFjcyBzZWVtcyB0byB3b3JrIGZpbmUgd2l0aCB0aGUgaGlkZGVuIHZlcnNpb24sIHNvIHVu aGlkZSBpdC4gICovCi0jaW5jbHVkZSA8bWFnaWNrL3ZlcnNpb24uaD4KICNpZiAweDY1MyA8PSBN YWdpY2tMaWJWZXJzaW9uICYmIE1hZ2lja0xpYlZlcnNpb24gPD0gMHg2NjUKIGV4dGVybiBXYW5k RXhwb3J0IHZvaWQgUGl4ZWxHZXRNYWdpY2tDb2xvciAoY29uc3QgUGl4ZWxXYW5kICosCiAJCQkJ CSAgICBNYWdpY2tQaXhlbFBhY2tldCAqKTsKQEAgLTg4MTQsNyArODgyMyw3IEBAIGltYWdlbWFn aWNrX2xvYWRfaW1hZ2UgKHN0cnVjdCBmcmFtZSAqZiwgc3RydWN0IGltYWdlICppbWcsCiAjZW5k aWYgLyogSEFWRV9NQUdJQ0tFWFBPUlRJTUFHRVBJWEVMUyAqLwogICAgIHsKICAgICAgIHNpemVf dCBpbWFnZV9oZWlnaHQ7Ci0gICAgICBNYWdpY2tSZWFsVHlwZSBjb2xvcl9zY2FsZSA9IDY1NTM1 LjAgLyBRdWFudHVtUmFuZ2U7CisgICAgICBNYWdpY2tSZWFsVHlwZSBjb2xvcl9zY2FsZSA9IDY1 NTM1LjAgLyAoTWFnaWNrUmVhbFR5cGUpIFF1YW50dW1SYW5nZTsKICNpZmRlZiBVU0VfQ0FJUk8K ICAgICAgIGRhdGEgPSB4bWFsbG9jICh3aWR0aCAqIGhlaWdodCAqIDQpOwogICAgICAgY29sb3Jf c2NhbGUgLz0gMjU2OwotLSAKMi4xNy4xCgo= --000000000000c5cd14056d9970c6-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 23 06:09:59 2018 Received: (at 25967) by debbugs.gnu.org; 23 Jun 2018 10:10:00 +0000 Received: from localhost ([127.0.0.1]:60806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWfUV-0004vd-Nx for submit@debbugs.gnu.org; Sat, 23 Jun 2018 06:09:59 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:39225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWfUU-0004vO-Ik for 25967@debbugs.gnu.org; Sat, 23 Jun 2018 06:09:58 -0400 Received: by mail-wr0-f196.google.com with SMTP id b8-v6so3499194wro.6 for <25967@debbugs.gnu.org>; Sat, 23 Jun 2018 03:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=D4NQi5w11TRmUgr914fyzRkyTjBtENk9yETZoxPEF/4=; b=Z60N4IK22SydhPOswaY/yoMT0sUjga9DUV/bVtxBJtN2vOAMuHFmQgi+Uy7Y426dHP Qyx95x69AaWPeUG3XNFg/fmYE1wdfEG8+SLDKLDzab+JsyIEGSFuwak49bxgzhk0uVEs Q8Xd4noH210dSEWKlmRZistQ32B9BrllFkid7ZBQ3Kyl1F7H1E2AJnw4TfZ9LWnKDM4i YtNR/bYoZ9VT+mQF+kO4f5FUCh2A/asJkOKtzHASqKomxzPRJ8dNfE6LvWkgdfsKVCDB gtTY88ntvBmkyw98nQv8OcXsMgrMChTlw0RUGrLD6e9RP18/39ADZLdDGgYM1sW7zW/n 39EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=D4NQi5w11TRmUgr914fyzRkyTjBtENk9yETZoxPEF/4=; b=TGxJVAgYe1fIBB1UBI5y2M6ti1uzEu3yOanWKbQimVVDXo8QmRtlTCJgRwpb2t25he p/AuM++7pXbaWgxe0ZnavQmlKhtx9sFiAytWVdfurveYNKlL1miMCntFXH+dC2BBQcZ9 zUg2QNO51DA/OHhe6SbR0eEEMaBIKzbCuiwMf072Ow99QPxzzn5OaduUaRoyS2knirA2 rtkb/cRlpBQlZObd5rbMFrgb1H4KTie8xyXFS+QwGadfaKDyl9eyxibrOqEDQp29+Oi0 umk+MNbn1ClAVc8ARBZqifLFV6wPREOgCXlZtiAdZ0N1yy6Jd7isGlZw2Hnuf5jRl/Na c35A== X-Gm-Message-State: APt69E0YKR2wSe0dxbT4D3voWPA1D1cs2b30VuUK4VF9gh2elcx3i44n Ug/x8XkXLwqhYbiyBsmMQqM= X-Google-Smtp-Source: AAOMgpfMIaZhC3Vw8cOEcBeGQYYZjwQTu3TwLdWy8scMlLm97tYY9kzR2sKcPNfSdu62z3gIQMyHkg== X-Received: by 2002:adf:ff09:: with SMTP id k9-v6mr4681717wrr.15.1529748592823; Sat, 23 Jun 2018 03:09:52 -0700 (PDT) Received: from my-little-tumbleweed (2a01cb04010fc800922b34fffe959aed.ipv6.abo.wanadoo.fr. [2a01:cb04:10f:c800:922b:34ff:fe95:9aed]) by smtp.gmail.com with ESMTPSA id l78-v6sm6346443wmb.39.2018.06.23.03.09.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Jun 2018 03:09:51 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: 25967@debbugs.gnu.org Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> Date: Sat, 23 Jun 2018 12:09:51 +0200 In-Reply-To: (Karl Otness's message of "Fri, 1 Jun 2018 14:17:32 -0500") Message-ID: <87a7rlhl00.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25967 Cc: Karl Otness X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) FWIW, I tried this patch on Tumbleweed (OpenSUSE's rolling-release distribution) which only has ImageMagick version 7[^1]. I also tried it on Debian stable, which only has ImageMagick version 6[^1]. Like Karl, I successfully compiled emacs's master branch, opened, resized and rotated a few PNGs and JPEGs. Are there other features to try out to assess the patch's soundness? [^1]: AFAICT from some hasty zypper/apt searching. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 23 07:26:40 2018 Received: (at control) by debbugs.gnu.org; 23 Jun 2018 11:26:40 +0000 Received: from localhost ([127.0.0.1]:60858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWggi-0006zK-DG for submit@debbugs.gnu.org; Sat, 23 Jun 2018 07:26:40 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:32973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWggg-0006z7-OO for control@debbugs.gnu.org; Sat, 23 Jun 2018 07:26:38 -0400 Received: by mail-it0-f48.google.com with SMTP id k17-v6so7765659ita.0 for ; Sat, 23 Jun 2018 04:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=GJSSHpDkdbYDgYoA/kqf2Q7t/xQbP2WM6eHMPRYKU/o=; b=crR5mpDjXiFDANt+hf/Cs9I183VbMHXrDAu+UOi3TNWuCYOCHlo3Mp5Xa5Q9pWU2wb BBh+sdLkj447xDurKJrYrcOoZeKVIScEM9fcOZTQu/pYlwK/3U/ZdJ5ZLITyFOx5e++g lYBOiTr6uPybCSWXHafudJZZzDpxiznTbNz6Sx2aFc3822KQcxFYP6I6Wr65PB51DGr+ YpouR+0EvrY9oWWsYXNV/FCfue/hAZjd18i+LapGm7NK2z1FiuxcmTHhfVGJpiiV/D94 Xq1iC94jskFyu+6l+57AO4k16m0qaJcARJefLmMxtVDTQs2ChhDszpEjdZx/+RbvcwZ2 b1hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=GJSSHpDkdbYDgYoA/kqf2Q7t/xQbP2WM6eHMPRYKU/o=; b=h5w+hzowyhlJ2q1NN5Iw3hbnmYxu82HI1aSvHr4eARes00ONw8e2QY2lTVDa4RwEnX GNlgLaWxB+oylt4QtDFutzXIPeAu81I+obAOu1JB74ro4rYEdrf2tEmB2DssgwilKloy DnEsS9fKBMpokit/La68K26EfU32UjeSs6E/aQxcz6CwVAxebAme191RK/yyhhdcRiar 98EcKb8dkt67ITnchadrGv7MPb6oRgsNhVdJGIfDyINNbizrf8DXkVNVxWZx9Jym5E9P TI/rAgOUZUxxEQE8YSH0tPsaKYg3fUEg5XfSXRCiseKWgAumjYqV1BQTR8m/QuUp3y9R KivA== X-Gm-Message-State: APt69E2BnoNte1/xATWQPKZ9Xf2EAaZScaftT3WRfUvuNhA1FzRKWBjC sSmWJVkCx2TaLtXozIa23z78Pw== X-Google-Smtp-Source: AAOMgpf/5yej2SXJeLoIHjdk7KgwtembHyuziIsgfdWfAwkeNsrxRceXI1KQzVCB8Ln02axMbP4FUg== X-Received: by 2002:a24:33cb:: with SMTP id k194-v6mr4293522itk.81.1529753193123; Sat, 23 Jun 2018 04:26:33 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d195-v6sm1698319itd.29.2018.06.23.04.26.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Jun 2018 04:26:32 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #25967 Date: Sat, 23 Jun 2018 07:26:31 -0400 Message-ID: <878t75rbfc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 25967 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 25 17:08:37 2018 Received: (at 25967) by debbugs.gnu.org; 25 Jun 2018 21:08:37 +0000 Received: from localhost ([127.0.0.1]:35358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXYiz-0007gW-38 for submit@debbugs.gnu.org; Mon, 25 Jun 2018 17:08:37 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:37130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXYix-0007gK-FH for 25967@debbugs.gnu.org; Mon, 25 Jun 2018 17:08:35 -0400 Received: by mail-it0-f65.google.com with SMTP id j129-v6so7184687ita.2 for <25967@debbugs.gnu.org>; Mon, 25 Jun 2018 14:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=k8x26al2JfAAYjAGtab6F4hpzXppxlxo4sKGyWu6FiA=; b=jHffpZrcFD1U+FZ/DJ4uWGS9+FevL4tOMnlNTzAgRqLyJsGoINZfH7RPrdVTLQhMD0 DMe9ptFt0fwOip29cRCZ7d4L3bIgEOR/QOgY5c4K1jBZQxbr81HoAc7SQ7+jdZF8vGH9 gprnfX8baaSlIczOucY13UGeQ1iagukqCc+/E0h99l4rDt8S0wUXFngiHEjuduxxo5t7 EFQ3doTlktgCDvUJOqaBgDbruGEbLcQ+6r7Lr0Q0WGzbXpkoovny/An9yW7b0pyYVZBq D4w16HZMPffcZUJ8EbGRXZzgQhVihxin6aj7fM+uWzr9pJny75pmYL+5jUZIvE/c8wh9 iXaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k8x26al2JfAAYjAGtab6F4hpzXppxlxo4sKGyWu6FiA=; b=Ch1bckPRtTAB9XOiFoLaSJFf4xViy3HRvnl6hLEOt9T6HJa9LTTXehJgGupMjNyksV /BgX9rGoNZEEYdJvaYS78f8BltmBkGEMtnMt6Cmkqng6MRbotUEjaa5zHjKsNyxSkjbc lolDWhXhly7/OM9wqFm3kWmVlfjEtTPmGTo9fZ/RL65cbz9Nvhpg8QoMp73pSjOUP1Fx QyM2cRx7P7Z3JzP8R32+FCyfPUFgL37yJggtyiIyqQlaN+NZyktfwsLBhUtDGKFTAM4V O8eF3GDFse5J/uDRWJbRU6giRlT64amX2gSbOp05Fj8aAEv/MFBMIi8S5um8nWEZThcf G6Ig== X-Gm-Message-State: APt69E3hr4CdPp6aGzuO753FnNXzCN80J8wAj7EXDSkKRh2sYfY/zmVR c15LSCKGcYddLXvNgvjJw6hRo2POziI= X-Google-Smtp-Source: AAOMgpeKTNzpuwxIb8V0q3tk3GmZ+T6dWLHda2x5nEXoQ73A0+vjTmHWpZcT9864l/XuLpXK+yZO9w== X-Received: by 2002:a02:e84:: with SMTP id 126-v6mr8510884jae.113.1529960909688; Mon, 25 Jun 2018 14:08:29 -0700 (PDT) Received: from mail-it0-f44.google.com (mail-it0-f44.google.com. [209.85.214.44]) by smtp.gmail.com with ESMTPSA id i10-v6sm95044itb.38.2018.06.25.14.08.29 for <25967@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 14:08:29 -0700 (PDT) Received: by mail-it0-f44.google.com with SMTP id m194-v6so14547712itg.2 for <25967@debbugs.gnu.org>; Mon, 25 Jun 2018 14:08:29 -0700 (PDT) X-Received: by 2002:a24:ad56:: with SMTP id a22-v6mr2178866itj.19.1529960908955; Mon, 25 Jun 2018 14:08:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:93d6:0:0:0:0:0 with HTTP; Mon, 25 Jun 2018 14:08:08 -0700 (PDT) In-Reply-To: <87a7rlhl00.fsf@gmail.com> References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <87a7rlhl00.fsf@gmail.com> From: Karl Otness Date: Mon, 25 Jun 2018 16:08:08 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) To: =?UTF-8?Q?K=C3=A9vin_Le_Gouguec?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25967 Cc: 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jun 23, 2018 at 5:09 AM, K=C3=A9vin Le Gouguec wrote: > FWIW, I tried this patch on Tumbleweed (OpenSUSE's rolling-release > distribution) which only has ImageMagick version 7[^1]. I also tried it > on Debian stable, which only has ImageMagick version 6[^1]. > > Like Karl, I successfully compiled emacs's master branch, opened, > resized and rotated a few PNGs and JPEGs. Are there other features to > try out to assess the patch's soundness? Thanks for trying out the patch. I really appreciate you testing it out on some other systems. I've been using it in my Emacs for a while and haven't really seen any issues. I'd also be happy to test other steps out if there's something more specific I should check. Thanks, Karl From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 27 22:10:43 2018 Received: (at 25967) by debbugs.gnu.org; 28 Aug 2018 02:10:44 +0000 Received: from localhost ([127.0.0.1]:34647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuTSt-0005aO-NK for submit@debbugs.gnu.org; Mon, 27 Aug 2018 22:10:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuTSr-0005aC-UK for 25967@debbugs.gnu.org; Mon, 27 Aug 2018 22:10:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fuTSk-0002AL-SZ for 25967@debbugs.gnu.org; Mon, 27 Aug 2018 22:10:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fuTSe-00028x-9Q; Mon, 27 Aug 2018 22:10:29 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1fuTSe-0007R3-3i; Mon, 27 Aug 2018 22:10:28 -0400 From: Glenn Morris To: Karl Otness Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> X-Spook: Agro virus Suspicious substance Israel Legion of Doom X-Ran: M.G+Ml/%v_!z7^]x>bmeoX.yUH::rEbTo4HBWN!-!H!Ij8BBe1^A'1^w81Y@)kb[#i?wu0 X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 27 Aug 2018 22:10:27 -0400 In-Reply-To: (Karl Otness's message of "Fri, 1 Jun 2018 14:17:32 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25967 Cc: 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Karl Otness wrote: > I have attached a patch which adds support for ImageMagick version 7. Thanks very much! It looks much simpler than I was expecting. I applied it as 5729486, then tweaked it in bf1b147 (mainly to avoid printing two identical "checking for imagemagick"); it would be good if you check I did not break it. :) We normally like to get copyright assignments for Emacs; see eg https://www.gnu.org/licenses/why-assign.en.html I think your patch is just small enought not to require this. But if you would like to contribute more in future, or just would like to, you can start the assignment process by filing out the form at http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future Thanks again! From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 27 22:12:23 2018 Received: (at 25967-done) by debbugs.gnu.org; 28 Aug 2018 02:12:23 +0000 Received: from localhost ([127.0.0.1]:34652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuTUV-0005d7-2w for submit@debbugs.gnu.org; Mon, 27 Aug 2018 22:12:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuTUT-0005cv-6C for 25967-done@debbugs.gnu.org; Mon, 27 Aug 2018 22:12:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fuTUN-0003GD-FR for 25967-done@debbugs.gnu.org; Mon, 27 Aug 2018 22:12:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fuTUN-0003Fi-BA for 25967-done@debbugs.gnu.org; Mon, 27 Aug 2018 22:12:15 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1fuTUN-00012Z-35; Mon, 27 Aug 2018 22:12:15 -0400 From: Glenn Morris To: 25967-done@debbugs.gnu.org Subject: Re: bug#25967: 25.1; Support for ImageMagick 7 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> X-Spook: Screening smuggle Secret Service class struggle Indigo X-Ran: 64N;_I1gmfkdvd)I:b.+>Qj#TBIYb5rvZrcP7aF6UM|8K6]!a/r0}SwEWMXME"8k<2GiZy X-Hue: green X-Attribution: GM Date: Mon, 27 Aug 2018 22:12:15 -0400 In-Reply-To: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> (Tej Chajed's message of "Sat, 4 Mar 2017 11:17:41 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25967-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Version: 27.1 Added in 5729486. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 28 16:32:48 2018 Received: (at 25967) by debbugs.gnu.org; 28 Aug 2018 20:32:49 +0000 Received: from localhost ([127.0.0.1]:35983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fukfQ-0001ZT-Ev for submit@debbugs.gnu.org; Tue, 28 Aug 2018 16:32:48 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:55562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fukfO-0001ZD-7P for 25967@debbugs.gnu.org; Tue, 28 Aug 2018 16:32:46 -0400 Received: by mail-it0-f65.google.com with SMTP id d10-v6so4551568itj.5 for <25967@debbugs.gnu.org>; Tue, 28 Aug 2018 13:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PpLbuSni9s9sqcg2NwOroRT7EY4WSNMKu1xyzNgquNw=; b=Ep7D6g5ZEf7S9jb1Pxg9kqRxWh90a0WSTRxCiBN0JW9kdZ7AIOIg1QmbuIamUXfJLt qwP/Ur2lDCOAPEsYBhxqbyDK0Tks/0emJRiLsyNxAD5E2kGbFhqhHE5PRdYlMt0wJwPu cIhQECJRNZyiRlxfiDrJpXzhYl+d8Am0ONl4QGFhakunk/hSWrrYnOK86YkbYsJ5dfTO WaRv6cg6667+GtGogjlhOqCvsxH29SxHdVYvy37d4qz+HUFRuVnd+qI3pt/g5uVJDvLv SgRpY5A909Wcsp9NzOF+TBfdQBTBIq0LR36MNZLdpLyD3pmQ9fwd/sPQQGER63epxFvX ADJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PpLbuSni9s9sqcg2NwOroRT7EY4WSNMKu1xyzNgquNw=; b=CYjDmNgHBxe4CiFgZqPDTGm7ZxvWRhDjbA3+/NLoktqalcJcrUw2gLFcG8e4fBEUWS CCLHSyIc1qPr2oSaG28qy3xA9bUKGXfzmAWQfA8nNqn8lcu6Kh04da5Kbw+5NRujbH94 dUoC4lxYF90PmWRXeoudiS3ZF/SoZcWl9T+oKLGaKeKSTN2jOBBWDqjpJEw2Wv0a21hX ffwbKPyNkjNl7Sukt0FShD/0EYatDso4NrKXpQjQW43+Bah4/Ml7VlRh2sjGrspn2Blo g8DDA1VzphwGMndtyHvbtTOXs5BYgcM0NmqiEeX6jFJKgVYMQEERRARrSNTjBsIWivTY 0SyQ== X-Gm-Message-State: APzg51ANyydpXgjYk5127eELoLktcdTpIi+qq1rb/pAYXVLDtTSmH+Md IOgxa2E6tVio0Eqe+za5I2gIhZtI4Ug= X-Google-Smtp-Source: ANB0VdYtdZsomBGPzkvsGbRPghDd6BiU69AAb8zvF+Ul4g3/YAMpTMO46TFUzOhTUZaBhio9jcZp/g== X-Received: by 2002:a02:6c45:: with SMTP id w66-v6mr2954360jab.87.1535488360254; Tue, 28 Aug 2018 13:32:40 -0700 (PDT) Received: from mail-io0-f172.google.com (mail-io0-f172.google.com. [209.85.223.172]) by smtp.gmail.com with ESMTPSA id u68-v6sm1112468ita.36.2018.08.28.13.32.39 for <25967@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Aug 2018 13:32:39 -0700 (PDT) Received: by mail-io0-f172.google.com with SMTP id 75-v6so2587265iou.11 for <25967@debbugs.gnu.org>; Tue, 28 Aug 2018 13:32:39 -0700 (PDT) X-Received: by 2002:a6b:90d4:: with SMTP id s203-v6mr2874726iod.249.1535488358875; Tue, 28 Aug 2018 13:32:38 -0700 (PDT) MIME-Version: 1.0 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> In-Reply-To: From: Karl Otness Date: Tue, 28 Aug 2018 15:32:26 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) To: rgm@gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25967 Cc: 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I hate to say this, but it looks like the modified patch might not be linking up quite right. It seems like the issue has to do with the new "IMAGEMAGICK7" prefix for EMACS_CHECK_MODULES. Some of the downstream tests, specifically looking for MagickRelinquishMemory try to use the IMAGEMAGICK_CFLAGS which won't be defined if configure finds version 7. The test will then fail ImageMagick and it won't be linked. I don't remember exactly, but I think this may have been the reason why I had initially set it up to use the same HAVE_IMAGEMAGICK prefix for both pkg-config checks, and then manually added the IMAGEMAGICK_MAJOR definition to sort out which was actually found. Using separate test variables can probably work, but will require updating the AC_CHECK_FUNCS tests later on. When I put together the initial patch, I think I wanted to touch as little of configure as possible, so I left those alone. It may be simpler to go back to using the same IMAGEMAGICK prefix for both package checks, but I agree it is nicer to not re-use the same pkg-config variables. Thanks for helping get this checked in. Karl On Mon, Aug 27, 2018 at 9:10 PM Glenn Morris wrote: > > Karl Otness wrote: > > > I have attached a patch which adds support for ImageMagick version 7. > > Thanks very much! It looks much simpler than I was expecting. > > I applied it as 5729486, then tweaked it in bf1b147 (mainly to avoid > printing two identical "checking for imagemagick"); it would be good if you > check I did not break it. :) > > We normally like to get copyright assignments for Emacs; see eg > https://www.gnu.org/licenses/why-assign.en.html > > I think your patch is just small enought not to require this. > But if you would like to contribute more in future, or just would like > to, you can start the assignment process by filing out the form at > > http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future > > Thanks again! From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 28 23:21:29 2018 Received: (at 25967) by debbugs.gnu.org; 29 Aug 2018 03:21:29 +0000 Received: from localhost ([127.0.0.1]:36244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fur2v-0002Xe-9j for submit@debbugs.gnu.org; Tue, 28 Aug 2018 23:21:29 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:40857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fur2t-0002XR-B6 for 25967@debbugs.gnu.org; Tue, 28 Aug 2018 23:21:27 -0400 Received: by mail-it0-f50.google.com with SMTP id h23-v6so5361208ita.5 for <25967@debbugs.gnu.org>; Tue, 28 Aug 2018 20:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S9fpmir3z+PdcdWBzyZaG4goXvn0PskXfLP+mvT1/lM=; b=Co2dcbrv7B/EcSSPe+pF8DCPWpQaqYsk26dsQpJOzFzJjbiSokKa54mhgub+X7qnLn BfZIz0MvQH+SntyStQgxfecT8QOk559JpBjBQMOs7FbigXT6f0vTMq06wftCXmnxIous yCm4zGo2nds9svAsbOPwVgunSm2XdoXaAroXkBba3fQrEZQtTXFdVxcWzVSbT3jgcpdE YMD0REjs3ZZGizdZz/8wP7W+I0x+OKkzYMAhjNeMpRPik7gL5oUmOoc/HklnnfnbrPv4 X/1urWktv3k/6qP01IHCCrVl0ZvLSw0f8v2QEz1sZw9ue+s7UCgxWGpWtYzr/WhMqXrZ /U6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S9fpmir3z+PdcdWBzyZaG4goXvn0PskXfLP+mvT1/lM=; b=gowxLZcERCJMS1iMFVF8bSurTK7MRgNF7bwFjjWJGWl0pWt7kM+zZmO4USYsUt+TKk quEBA94pDmhuL1cKygCBGuYucCKbrAE9qTdJx6OWrRwI72ydg2E77/q9b62BIhikrZvV 0il8OLfpZ1eOKIOeTP8xF7L5XHd6BHFH1OlkDiQkq1MMfvgkJLdeuiuJ5DnTknRGZLyb fypquYtVOA6LVZPu7i3xAGcs4mWA1zkubh3OeYq8IKZ2OSQR/ddeIriKUtYZkYkAcgGq qDS1Gb6c20OiDsIocmz2mSHwdmM0fyOnq9fZPn6/Mt5z0obcOb41SpzBwN4AjCL5qO4T gFzg== X-Gm-Message-State: APzg51B1s7cLiQTVBIEzqHqN+R0WDDB5caNBAWHtl2s4FTBzjyygLTvP dTH5Xo6SzZQLPdqnQ1pfEYNZph2juck= X-Google-Smtp-Source: ANB0Vdb+it+Ag97VhtB/1iPLZwWuGWr4g7uWubtXZEY8tXQ7mNBBXTqB2LtNnqJdT9hyPms8wcQwmw== X-Received: by 2002:a02:898d:: with SMTP id p13-v6mr3893752jaj.74.1535512881441; Tue, 28 Aug 2018 20:21:21 -0700 (PDT) Received: from mail-it0-f52.google.com (mail-it0-f52.google.com. [209.85.214.52]) by smtp.gmail.com with ESMTPSA id l26-v6sm1144097iok.34.2018.08.28.20.21.19 for <25967@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Aug 2018 20:21:20 -0700 (PDT) Received: by mail-it0-f52.google.com with SMTP id d10-v6so5668529itj.5 for <25967@debbugs.gnu.org>; Tue, 28 Aug 2018 20:21:19 -0700 (PDT) X-Received: by 2002:a24:4ecb:: with SMTP id r194-v6mr3668921ita.39.1535512879670; Tue, 28 Aug 2018 20:21:19 -0700 (PDT) MIME-Version: 1.0 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> In-Reply-To: From: Karl Otness Date: Tue, 28 Aug 2018 22:21:07 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) To: rgm@gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25967 Cc: 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Aug 27, 2018 at 9:10 PM Glenn Morris wrote: > I applied it as 5729486, then tweaked it in bf1b147 (mainly to avoid > printing two identical "checking for imagemagick") I did a quick run of configure and I'm not sure if this is a difference in version of autoconf (mine reports version 2.69), but on my machine it seems to use the module definition when printing. I see: "checking for MagickWand >= 7... yes" I wonder if that might help the situation possibly using the same prefix for both pkg-config checks? Thanks, Karl From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 30 14:00:14 2018 Received: (at 25967) by debbugs.gnu.org; 30 Aug 2018 18:00:14 +0000 Received: from localhost ([127.0.0.1]:39378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvREs-0006SH-AB for submit@debbugs.gnu.org; Thu, 30 Aug 2018 14:00:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvREr-0006S6-3B for 25967@debbugs.gnu.org; Thu, 30 Aug 2018 14:00:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fvREl-0004cn-65 for 25967@debbugs.gnu.org; Thu, 30 Aug 2018 14:00:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvREj-0004cC-Af; Thu, 30 Aug 2018 14:00:05 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1fvREj-0005pM-1A; Thu, 30 Aug 2018 14:00:05 -0400 From: Glenn Morris To: Karl Otness Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> X-Spook: Subway FMD MD4 Gang BLU-114/B Operation Iraqi Freedom X-Ran: ;.ih4%1j|wd47ypl0&f{&kQsFe(1`oX6m/e{`P6cvRjI%;@6^*^[PLt!.-,pug6L5dLN2U X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 30 Aug 2018 14:00:04 -0400 In-Reply-To: (Karl Otness's message of "Tue, 28 Aug 2018 15:32:26 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25967 Cc: 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Sorry, my change was garbage. I hope I fixed it in 3cc42bb... > I did a quick run of configure and I'm not sure if this is a > difference in version of autoconf (mine reports version 2.69), but on > my machine it seems to use the module definition when printing. I see: > "checking for MagickWand >= 7... yes" Looks like this changed in 37b2f9f when m4/pkg.m4 was synced with pkg-config 0.29.2 earlier this year. PKG_CHECK_MODULE used to print $1, now it prints $2. Progress! From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 30 17:53:57 2018 Received: (at 25967) by debbugs.gnu.org; 30 Aug 2018 21:53:57 +0000 Received: from localhost ([127.0.0.1]:39519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvUt2-0005l7-Oj for submit@debbugs.gnu.org; Thu, 30 Aug 2018 17:53:56 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:40206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvUt0-0005kt-Rq for 25967@debbugs.gnu.org; Thu, 30 Aug 2018 17:53:55 -0400 Received: by mail-it0-f49.google.com with SMTP id h23-v6so4723959ita.5 for <25967@debbugs.gnu.org>; Thu, 30 Aug 2018 14:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xidxRW4J+b5CK/+7hCoubREqbZE7g425GscmEYEn4yM=; b=zpa9jROEpwzVBAEDqBkU5acS9zoqGMCldTkaB1k4UsiPjfRtIRWl/KIVWdc5yNDIMt PRIc04SMD4jT65OtA+H+LwUVq12oRgZORcajMGSKZiAzZRBF1F70DS9VY9YEoTCqTBvh Lb/lbAmf+r6Aw73DV64zCwLqPjQXFGGA8ixo8kNkTm/Hmivs+6V1OZsXHSJDqQl4FK8A pb259+CEErF/KuVKq38gVQ3RaR5kgxuuk6DQRueiI6/nrzniCSvjAVjtInU6BwdN4Uj4 CrwDmMRfvUjjLXqIbJjY0x+l6MuBPpKB1ZAX0L+zN3Qqd1PTrA4k/tyGUCl/5IG0IWcI eOew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xidxRW4J+b5CK/+7hCoubREqbZE7g425GscmEYEn4yM=; b=FpfchxsjCXKKEisfR8AZk02J/eLQIgM3EcA8Zo8qa+M7VmbXneRGg4bFtlDSoRVKZ9 JQ61zMB0RvZHpbKYmkia7pvhBMIqCeY0WJicXYWtL/e09mr53VAznVhhoa0Obk0WRxUt 82VEHv4qSk32ZadQTGK3EWb6YAlwMu4JWu0j8t5UHlR1xMeh448du5rO1/7a91KWzQBB W8+Flpd+mq1Cy+OypHhLFNObqzv/v8ueXl3c95sCexGL+9aBhsy2g3W66UKt7jnQhxrJ 4Fiz7fNQAy1C5YcWUOLI0NUjEXEZqlMHRi8Hp1ogc43jiY91iAFJD8Wn84gbkiIK1G8T 4Zew== X-Gm-Message-State: APzg51Bk6q6e9QDLS+GA/B4HI1Is+G/nzeUbDUiSdYw905d6KmydoOB2 JQBrKnwArMFcwgIG4c/7fyaDyzo2BBY= X-Google-Smtp-Source: ANB0VdY0f9GZUITDsht+KARyxsZG+9n2zSQRMboNXoqoR7x343Ge2l2R0Lk9W65z2u2g43xEc6+0Cg== X-Received: by 2002:a24:1013:: with SMTP id 19-v6mr3417713ity.141.1535666029062; Thu, 30 Aug 2018 14:53:49 -0700 (PDT) Received: from mail-it0-f43.google.com (mail-it0-f43.google.com. [209.85.214.43]) by smtp.gmail.com with ESMTPSA id p22-v6sm3685501iod.74.2018.08.30.14.53.47 for <25967@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Aug 2018 14:53:48 -0700 (PDT) Received: by mail-it0-f43.google.com with SMTP id p129-v6so4735031ite.3 for <25967@debbugs.gnu.org>; Thu, 30 Aug 2018 14:53:47 -0700 (PDT) X-Received: by 2002:a02:90cf:: with SMTP id c15-v6mr11164738jag.130.1535666027617; Thu, 30 Aug 2018 14:53:47 -0700 (PDT) MIME-Version: 1.0 References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> In-Reply-To: From: Karl Otness Date: Thu, 30 Aug 2018 16:53:35 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) To: rgm@gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25967 Cc: 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Aug 30, 2018 at 1:00 PM Glenn Morris wrote: > Looks like this changed in 37b2f9f when m4/pkg.m4 was synced with > pkg-config 0.29.2 earlier this year. PKG_CHECK_MODULE used to print > $1, now it prints $2. Progress! That's good to know, nice that it should be consistent and give a good description of the check. > Sorry, my change was garbage. I hope I fixed it in 3cc42bb... No problem, it is tricky to try the configure step with different versions. I just did a new build off of master and I ended up with an Emacs linked to libmagick version 7 and it opened images just fine. Seems like everything is working. Thanks again for your help getting this in. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 03 18:57:32 2018 Received: (at submit) by debbugs.gnu.org; 3 Sep 2018 22:57:32 +0000 Received: from localhost ([127.0.0.1]:44733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwxml-0001mo-00 for submit@debbugs.gnu.org; Mon, 03 Sep 2018 18:57:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwxmi-0001mY-Rh for submit@debbugs.gnu.org; Mon, 03 Sep 2018 18:57:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fwxmb-0005Xq-Ps for submit@debbugs.gnu.org; Mon, 03 Sep 2018 18:57:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55567) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fwxmb-0005Xf-L8 for submit@debbugs.gnu.org; Mon, 03 Sep 2018 18:57:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fwxmZ-0006Hy-Vu for bug-gnu-emacs@gnu.org; Mon, 03 Sep 2018 18:57:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fwxmV-0005VM-Sg for bug-gnu-emacs@gnu.org; Mon, 03 Sep 2018 18:57:19 -0400 Received: from [195.159.176.226] (port=53619 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fwxmV-0005UY-G9 for bug-gnu-emacs@gnu.org; Mon, 03 Sep 2018 18:57:15 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fwxkL-0008Rt-4X for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 00:55:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) Date: Mon, 03 Sep 2018 23:57:05 +0100 Lines: 369 Message-ID: <86wos25gvy.fsf@gmail.com> References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) Cancel-Lock: sha1:Rt168fYDYxD1CMoePN5vYKqYGdk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) --=-=-= Content-Type: text/plain On Fri 01 Jun 2018, Karl Otness wrote: > I have attached a patch which adds support for ImageMagick version 7. > I have tried to keep compatibility with version 6 as well. I have > gotten clean builds against both versions on my machine (running Arch > and overriding PKG_CONFIG_PATH to test). I also did a quick build on a > Mac and it also seemed to link up to the ImageMagick 7 from homebrew. > On both machines I could open/resize/rotate images and page through > the frames of animated GIFs. As a followup, here is a patch to add ImageMagick support for Windows. The patch was initially developed for Imagemagick 6, but I've updated it to support ImageMagick 7. I've given this some light testing on a 64bit mingw64 (MSYS2) and 64bit cygwin builds, both of which use Imagemagick 7. Please test, and report if it breaks anything on other platforms. AndyM --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=imagemagick7.patch diff --git a/configure.ac b/configure.ac index 6f3d7338c3..25e42fdbaf 100644 --- a/configure.ac +++ b/configure.ac @@ -2533,6 +2533,10 @@ AC_DEFUN MagickMergeImageLayers MagickAutoOrientImage]) CFLAGS=$OLD_CFLAGS LIBS=$OLD_LIBS + # Windows loads libmagickwand dynamically + if test "${opsys}" = "mingw32"; then + IMAGEMAGICK_LIBS= + fi # Check that ImageMagick links. It does not link on Fedora 25 # with './configure CC=clang', as pkg-config outputs flags like # -lomp that work for GCC but not Clang. diff --git a/lisp/term/w32-win.el b/lisp/term/w32-win.el index dc57160d04..e07a011de5 100644 --- a/lisp/term/w32-win.el +++ b/lisp/term/w32-win.el @@ -277,7 +277,8 @@ libgnutls-version '(libxml2 "libxml2-2.dll" "libxml2.dll") '(zlib "zlib1.dll" "libz-1.dll") '(lcms2 "liblcms2-2.dll") - '(json "libjansson-4.dll"))) + '(json "libjansson-4.dll") + '(imagemagick "libMagickWand-7.Q16HDRI-6.dll"))) ;;; multi-tty support (defvar w32-initialized nil diff --git a/src/image.c b/src/image.c index 24decbc099..3faa3c6b3c 100644 --- a/src/image.c +++ b/src/image.c @@ -8277,8 +8277,8 @@ imagemagick_image_p (Lisp_Object object) #ifdef HAVE_IMAGEMAGICK7 # include # include -/* ImageMagick 7 compatibility definitions. */ -# define PixelSetMagickColor PixelSetPixelColor +/* ImageMagick 7 compatibility definitions. API functions are + redefined later, after the w32 runtime linking support code. */ typedef PixelInfo MagickPixelPacket; #else # include @@ -8292,6 +8292,255 @@ extern WandExport void PixelGetMagickColor (const PixelWand *, MagickPixelPacket *); #endif +#if defined HAVE_NTGUI && defined WINDOWSNT + +/* Imagemagick MagickWand library functions. */ + +DEF_DLL_FN (MagickWand *, CloneMagickWand, (const MagickWand *)); +DEF_DLL_FN (MagickWand *, DestroyMagickWand, (MagickWand *)); +DEF_DLL_FN (PixelIterator *, DestroyPixelIterator, (PixelIterator *)); +DEF_DLL_FN (PixelWand *, DestroyPixelWand, (PixelWand *)); +DEF_DLL_FN (MagickBooleanType, MagickCropImage, + (MagickWand *, const size_t, const size_t, const ssize_t, + const ssize_t)); +DEF_DLL_FN (MagickBooleanType, MagickExportImagePixels, + (MagickWand *, const ssize_t, const ssize_t, const size_t, + const size_t, const char *, const StorageType, void *)); +#ifndef HAVE_MAGICKMERGEIMAGELAYERS +DEF_DLL_FN(MagickWand *, MagickFlattenImages, (MagickWand *)); +#endif +DEF_DLL_FN (char *, MagickGetException, (const MagickWand *, ExceptionType *)); +DEF_DLL_FN (MagickWand *, MagickGetImage, (MagickWand *)); +DEF_DLL_FN (size_t, MagickGetImageDelay, (MagickWand *)); +DEF_DLL_FN (DisposeType, MagickGetImageDispose, (MagickWand *)); +DEF_DLL_FN (size_t, MagickGetImageHeight, (MagickWand *)); +DEF_DLL_FN (MagickBooleanType, MagickGetImagePage, + (MagickWand *, size_t *, size_t *, ssize_t *, ssize_t *)); +DEF_DLL_FN (char *, MagickGetImageSignature, (MagickWand *)); +DEF_DLL_FN (size_t, MagickGetImageWidth, (MagickWand *)); +DEF_DLL_FN (size_t, MagickGetNumberImages, (MagickWand *)); +#ifdef HAVE_MAGICKMERGEIMAGELAYERS +DEF_DLL_FN (MagickWand *, MagickMergeImageLayers, + (MagickWand *, const LayerMethod)); +#endif +DEF_DLL_FN (char **, MagickQueryFormats, (const char *, size_t *)); +DEF_DLL_FN (MagickBooleanType, MagickReadImage, (MagickWand *, const char *)); +DEF_DLL_FN (MagickBooleanType, MagickReadImageBlob, + (MagickWand *, const void *, const size_t)); +DEF_DLL_FN (void *, MagickRelinquishMemory, (void *)); +DEF_DLL_FN (MagickBooleanType, MagickRotateImage, + (MagickWand *, const PixelWand *, const double)); +DEF_DLL_FN (MagickBooleanType, MagickScaleImage, + (MagickWand *, const size_t, const size_t)); +DEF_DLL_FN (MagickBooleanType, MagickSetFilename, (MagickWand *, const char *)); +DEF_DLL_FN (MagickBooleanType, MagickSetImageBackgroundColor, + (MagickWand *,const PixelWand *)); +DEF_DLL_FN (MagickBooleanType, MagickSetIteratorIndex, + (MagickWand *, const ssize_t)); +DEF_DLL_FN (void, MagickWandGenesis, (void)); +DEF_DLL_FN (void, MagickWandTerminus, (void)); +DEF_DLL_FN (MagickWand *, NewMagickWand, (void)); +DEF_DLL_FN (PixelIterator *, NewPixelIterator, (MagickWand *)); +DEF_DLL_FN (PixelWand *, NewPixelWand, (void)); +DEF_DLL_FN (double, PixelGetAlpha, (const PixelWand *)); +DEF_DLL_FN (void, PixelGetMagickColor, (const PixelWand *, MagickPixelPacket *)); +DEF_DLL_FN (PixelWand **, PixelGetNextIteratorRow, (PixelIterator *, size_t *)); +DEF_DLL_FN (void, PixelSetBlue, (PixelWand *, const double)); +DEF_DLL_FN (void, PixelSetGreen, (PixelWand *, const double)); +DEF_DLL_FN (MagickBooleanType, PixelSetIteratorRow, + (PixelIterator *, const ssize_t)); +#ifdef HAVE_IMAGEMAGICK7 +DEF_DLL_FN (void, PixelSetPixelColor, (PixelWand *, const MagickPixelPacket *)); +#else +DEF_DLL_FN (void, PixelSetMagickColor, (PixelWand *, const MagickPixelPacket *)); +#endif +DEF_DLL_FN (void, PixelSetRed, (PixelWand *, const double)); +DEF_DLL_FN (MagickBooleanType, PixelSyncIterator, (PixelIterator *)); + +DEF_DLL_FN (MagickBooleanType, MagickSetSize, + (MagickWand *, const size_t, const size_t)); +DEF_DLL_FN (MagickBooleanType, MagickSetDepth, + (MagickWand *, const size_t)); +#ifdef HAVE_MAGICKAUTOORIENTIMAGE +DEF_DLL_FN (MagickBooleanType, MagickAutoOrientImage, (MagickWand *)); +#endif + +static bool +init_imagemagick_functions (void) +{ + HMODULE library = NULL; + + if (!(library = w32_delayed_load (Qimagemagick))) + { + return 0; + } + + LOAD_DLL_FN (library, CloneMagickWand); + LOAD_DLL_FN (library, DestroyMagickWand); + LOAD_DLL_FN (library, DestroyPixelIterator); + LOAD_DLL_FN (library, DestroyPixelWand); + LOAD_DLL_FN (library, MagickCropImage); + LOAD_DLL_FN (library, MagickExportImagePixels); +#ifndef HAVE_MAGICKMERGEIMAGELAYERS + LOAD_DLL_FN (library, MagickFlattenImages); +#endif + LOAD_DLL_FN (library, MagickGetException); + LOAD_DLL_FN (library, MagickGetImage); + LOAD_DLL_FN (library, MagickGetImageDelay); + LOAD_DLL_FN (library, MagickGetImageDispose); + LOAD_DLL_FN (library, MagickGetImageHeight); + LOAD_DLL_FN (library, MagickGetImagePage); + LOAD_DLL_FN (library, MagickGetImageSignature); + LOAD_DLL_FN (library, MagickGetImageWidth); + LOAD_DLL_FN (library, MagickGetNumberImages); +#ifdef HAVE_MAGICKMERGEIMAGELAYERS + LOAD_DLL_FN (library, MagickMergeImageLayers); +#endif + LOAD_DLL_FN (library, MagickQueryFormats); + LOAD_DLL_FN (library, MagickReadImage); + LOAD_DLL_FN (library, MagickReadImageBlob); + LOAD_DLL_FN (library, MagickRelinquishMemory); + LOAD_DLL_FN (library, MagickRotateImage); + LOAD_DLL_FN (library, MagickScaleImage); + LOAD_DLL_FN (library, MagickSetFilename); + LOAD_DLL_FN (library, MagickSetImageBackgroundColor); + LOAD_DLL_FN (library, MagickSetIteratorIndex); + LOAD_DLL_FN (library, MagickWandGenesis); + LOAD_DLL_FN (library, MagickWandTerminus); + LOAD_DLL_FN (library, NewMagickWand); + LOAD_DLL_FN (library, NewPixelIterator); + LOAD_DLL_FN (library, NewPixelWand); + LOAD_DLL_FN (library, PixelGetAlpha); + LOAD_DLL_FN (library, PixelGetMagickColor); + LOAD_DLL_FN (library, PixelGetNextIteratorRow); + LOAD_DLL_FN (library, PixelSetBlue); + LOAD_DLL_FN (library, PixelSetGreen); + LOAD_DLL_FN (library, PixelSetIteratorRow); +#ifdef HAVE_IMAGEMAGICK7 + LOAD_DLL_FN (library, PixelSetPixelColor); +#else + LOAD_DLL_FN (library, PixelSetMagickColor); +#endif + LOAD_DLL_FN (library, PixelSetRed); + LOAD_DLL_FN (library, PixelSyncIterator); + + LOAD_DLL_FN (library, MagickSetSize); + LOAD_DLL_FN (library, MagickSetDepth); +#ifdef HAVE_MAGICKAUTOORIENTIMAGE + LOAD_DLL_FN (library, MagickAutoOrientImage); +#endif + + return 1; +} + +#undef CloneMagickWand +#undef DestroyMagickWand +#undef DestroyPixelIterator +#undef DestroyPixelWand +#undef MagickCropImage +#undef MagickExportImagePixels +#undef MagickFlattenImages +#undef MagickGetException +#undef MagickGetImage +#undef MagickGetImageDelay +#undef MagickGetImageDispose +#undef MagickGetImageHeight +#undef MagickGetImagePage +#undef MagickGetImageSignature +#undef MagickGetImageWidth +#undef MagickGetNumberImages +#undef MagickMergeImageLayers +#undef MagickQueryFormats +#undef MagickReadImage +#undef MagickReadImageBlob +#undef MagickRelinquishMemory +#undef MagickRotateImage +#undef MagickScaleImage +#undef MagickSetFilename +#undef MagickSetImageBackgroundColor +#undef MagickSetIteratorIndex +#undef MagickWandGenesis +#undef MagickWandTerminus +#undef NewMagickWand +#undef NewPixelIterator +#undef NewPixelWand +#undef PixelGetAlpha +#undef PixelGetMagickColor +#undef PixelGetNextIteratorRow +#undef PixelSetBlue +#undef PixelSetGreen +#undef PixelSetIteratorRow +#undef PixelSetMagickColor +#undef PixelSetPixelColor +#undef PixelSetRed +#undef PixelSyncIterator + +#undef MagickSetSize +#undef MagickSetDepth +#undef MagickAutoOrientImage + +#define CloneMagickWand fn_CloneMagickWand +#define DestroyMagickWand fn_DestroyMagickWand +#define DestroyPixelIterator fn_DestroyPixelIterator +#define DestroyPixelWand fn_DestroyPixelWand +#define MagickCropImage fn_MagickCropImage +#define MagickExportImagePixels fn_MagickExportImagePixels +#ifndef HAVE_MAGICKMERGEIMAGELAYERS +#define MagickFlattenImages fn_MagickFlattenImages +#endif +#define MagickGetException fn_MagickGetException +#define MagickGetImage fn_MagickGetImage +#define MagickGetImageDelay fn_MagickGetImageDelay +#define MagickGetImageDispose fn_MagickGetImageDispose +#define MagickGetImageHeight fn_MagickGetImageHeight +#define MagickGetImagePage fn_MagickGetImagePage +#define MagickGetImageSignature fn_MagickGetImageSignature +#define MagickGetImageWidth fn_MagickGetImageWidth +#define MagickGetNumberImages fn_MagickGetNumberImages +#define MagickMergeImageLayers fn_MagickMergeImageLayers +#define MagickQueryFormats fn_MagickQueryFormats +#define MagickReadImage fn_MagickReadImage +#define MagickReadImageBlob fn_MagickReadImageBlob +#define MagickRelinquishMemory fn_MagickRelinquishMemory +#define MagickRotateImage fn_MagickRotateImage +#define MagickScaleImage fn_MagickScaleImage +#define MagickSetFilename fn_MagickSetFilename +#define MagickSetImageBackgroundColor fn_MagickSetImageBackgroundColor +#define MagickSetIteratorIndex fn_MagickSetIteratorIndex +#define MagickWandGenesis fn_MagickWandGenesis +#define MagickWandTerminus fn_MagickWandTerminus +#define NewMagickWand fn_NewMagickWand +#define NewPixelIterator fn_NewPixelIterator +#define NewPixelWand fn_NewPixelWand +#define PixelGetAlpha fn_PixelGetAlpha +#define PixelGetMagickColor fn_PixelGetMagickColor +#define PixelGetNextIteratorRow fn_PixelGetNextIteratorRow +#define PixelSetBlue fn_PixelSetBlue +#define PixelSetGreen fn_PixelSetGreen +#define PixelSetIteratorRow fn_PixelSetIteratorRow +#ifdef HAVE_IMAGEMAGICK7 +#define PixelSetPixelColor fn_PixelSetPixelColor +#else +#define PixelSetMagickColor fn_PixelSetMagickColor +#endif +#define PixelSetRed fn_PixelSetRed +#define PixelSyncIterator fn_PixelSyncIterator + +#define MagickSetSize fn_MagickSetSize +#define MagickSetDepth fn_MagickSetDepth +#ifdef HAVE_MAGICKAUTOORIENTIMAGE +#define MagickAutoOrientImage fn_MagickAutoOrientImage +#endif + +# endif /* HAVE_NTGUI WINDOWSNT */ + +#ifdef HAVE_IMAGEMAGICK7 +/* ImageMagick 7 compatibility definitions. Redefine API functions + here, after the w32 runtime linking support code. */ +# define PixelSetMagickColor PixelSetPixelColor +#endif + + /* Log ImageMagick error message. Useful when an ImageMagick function returns the status `MagickFalse'. */ @@ -8411,7 +8660,7 @@ imagemagick_get_animation_cache (MagickWand *wand) pcache = &cache->next; } - DestroyString (signature); + MagickRelinquishMemory (signature); cache->update_time = current_timespec (); return cache; } @@ -8985,13 +9234,14 @@ and `imagemagick-types-inhibit'. */) { Lisp_Object typelist = Qnil; size_t numf = 0; - ExceptionInfo *ex; char **imtypes; size_t i; - ex = AcquireExceptionInfo (); - imtypes = GetMagickList ("*", &numf, ex); - DestroyExceptionInfo (ex); + if (imagemagick_type.init && !imagemagick_type.init ()) + return Qnil; + + MagickWandGenesis (); + imtypes = MagickQueryFormats ("*", &numf); for (i = 0; i < numf; i++) { @@ -9001,6 +9251,8 @@ and `imagemagick-types-inhibit'. */) } MagickRelinquishMemory (imtypes); + MagickWandTerminus (); + return Fnreverse (typelist); } --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 04 13:12:07 2018 Received: (at 25967) by debbugs.gnu.org; 4 Sep 2018 17:12:08 +0000 Received: from localhost ([127.0.0.1]:45963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxEs3-0005wu-MX for submit@debbugs.gnu.org; Tue, 04 Sep 2018 13:12:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxEs1-0005wP-Jc for 25967@debbugs.gnu.org; Tue, 04 Sep 2018 13:12:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxErt-0003pQ-73 for 25967@debbugs.gnu.org; Tue, 04 Sep 2018 13:12:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxErt-0003oZ-2o; Tue, 04 Sep 2018 13:11:57 -0400 Received: from [176.228.60.248] (port=2904 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fxErs-000351-H3; Tue, 04 Sep 2018 13:11:57 -0400 Date: Tue, 04 Sep 2018 20:11:49 +0300 Message-Id: <83wos1xk4q.fsf@gnu.org> From: Eli Zaretskii To: Andy Moreton In-reply-to: <86wos25gvy.fsf@gmail.com> (message from Andy Moreton on Mon, 03 Sep 2018 23:57:05 +0100) Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <86wos25gvy.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25967 Cc: 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Andy Moreton > Date: Mon, 03 Sep 2018 23:57:05 +0100 > > As a followup, here is a patch to add ImageMagick support for Windows. > The patch was initially developed for Imagemagick 6, but I've updated it > to support ImageMagick 7. > > I've given this some light testing on a 64bit mingw64 (MSYS2) and 64bit > cygwin builds, both of which use Imagemagick 7. > > Please test, and report if it breaks anything on other platforms. Thanks. A couple of minor comments: This needs a NEWS entry. > + '(imagemagick "libMagickWand-7.Q16HDRI-6.dll"))) Is this DLL name fixed for all the supported versions? It sounds like it's only for Imagemagick v7, and so the DLL for version 6 will be named differently. Also, AFAIU, there are binary incompatibilities between v6 and v7, so an Emacs compiled with one of them should not attempt to load DLLs from another, is that right? For these two reasons, I think we should have a Lisp variable that provides the version of Imagemagick with which Emacs was built, and we need the dispatch in w32-win.el for loading the correct DLLs based on that variable, like we do with libgif etc. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 04 15:03:41 2018 Received: (at submit) by debbugs.gnu.org; 4 Sep 2018 19:03:41 +0000 Received: from localhost ([127.0.0.1]:45999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxGc1-0000N1-8f for submit@debbugs.gnu.org; Tue, 04 Sep 2018 15:03:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxGc0-0000Mo-Hi for submit@debbugs.gnu.org; Tue, 04 Sep 2018 15:03:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxGbq-0000aX-FM for submit@debbugs.gnu.org; Tue, 04 Sep 2018 15:03:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fxGbo-0000Zp-Rj for submit@debbugs.gnu.org; Tue, 04 Sep 2018 15:03:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxGbn-0000VQ-WE for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:03:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxGbf-0000Uj-Is for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:03:25 -0400 Received: from [195.159.176.226] (port=52122 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxGbf-0000U6-4w for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 15:03:19 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fxGZU-0007bS-At for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 21:01:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) Date: Tue, 04 Sep 2018 20:03:07 +0100 Lines: 42 Message-ID: References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <86wos25gvy.fsf@gmail.com> <83wos1xk4q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) Cancel-Lock: sha1:SsJfPOm7Qcm8sHmD5YJ6jp4pfgY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) On Tue 04 Sep 2018, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Mon, 03 Sep 2018 23:57:05 +0100 >> >> As a followup, here is a patch to add ImageMagick support for Windows. >> The patch was initially developed for Imagemagick 6, but I've updated it >> to support ImageMagick 7. >> >> I've given this some light testing on a 64bit mingw64 (MSYS2) and 64bit >> cygwin builds, both of which use Imagemagick 7. >> >> Please test, and report if it breaks anything on other platforms. > > Thanks. A couple of minor comments: > > This needs a NEWS entry. > >> + '(imagemagick "libMagickWand-7.Q16HDRI-6.dll"))) > > Is this DLL name fixed for all the supported versions? It sounds > like it's only for Imagemagick v7, and so the DLL for version 6 will > be named differently. Indeed. v6 is legacy (and not available on any platform I currently test on). The DLL name is from the current package for MSYS2. > Also, AFAIU, there are binary incompatibilities between v6 and v7, so > an Emacs compiled with one of them should not attempt to load DLLs > from another, is that right? Correct. > For these two reasons, I think we should have a Lisp variable that > provides the version of Imagemagick with which Emacs was built, and we > need the dispatch in w32-win.el for loading the correct DLLs based on > that variable, like we do with libgif etc. Agreed. Do you use Imagemagick on mingw.org builds ? Is there a packaged library available there ? AndyM From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 04 22:39:01 2018 Received: (at 25967) by debbugs.gnu.org; 5 Sep 2018 02:39:01 +0000 Received: from localhost ([127.0.0.1]:46192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxNif-0007Gc-Co for submit@debbugs.gnu.org; Tue, 04 Sep 2018 22:39:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxNid-0007GK-0g for 25967@debbugs.gnu.org; Tue, 04 Sep 2018 22:38:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxNiU-0004Mc-Nr for 25967@debbugs.gnu.org; Tue, 04 Sep 2018 22:38:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxNiU-0004MA-EH; Tue, 04 Sep 2018 22:38:50 -0400 Received: from [176.228.60.248] (port=2105 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fxNiU-0006TH-1P; Tue, 04 Sep 2018 22:38:50 -0400 Date: Wed, 05 Sep 2018 05:38:45 +0300 Message-Id: <83r2i8y8ga.fsf@gnu.org> From: Eli Zaretskii To: Andy Moreton In-reply-to: (message from Andy Moreton on Tue, 04 Sep 2018 20:03:07 +0100) Subject: Re: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> <86wos25gvy.fsf@gmail.com> <83wos1xk4q.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25967 Cc: 25967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Andy Moreton > Date: Tue, 04 Sep 2018 20:03:07 +0100 > > >> + '(imagemagick "libMagickWand-7.Q16HDRI-6.dll"))) > > > > Is this DLL name fixed for all the supported versions? It sounds > > like it's only for Imagemagick v7, and so the DLL for version 6 will > > be named differently. > > Indeed. v6 is legacy (and not available on any platform I currently test > on). I see a precompiled binary on the Imagemagick site. > The DLL name is from the current package for MSYS2. How frequently does the name of the DLL change? If it changes with each update, we should find a way of allowing users to still use previous or next compatible DLLs. We don't want to require them to upgrade all the time. > > For these two reasons, I think we should have a Lisp variable that > > provides the version of Imagemagick with which Emacs was built, and we > > need the dispatch in w32-win.el for loading the correct DLLs based on > > that variable, like we do with libgif etc. > > Agreed. Do you use Imagemagick on mingw.org builds ? Is there a packaged > library available there ? No, not that I know of. I think we should provide compatibility to MSYS2 packages and to packages provided by Imagemagick themselves. From unknown Sat Jun 21 10:43:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 03 Oct 2018 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator