GNU bug report logs -
#25966
Fix bug 25957 and updates gitolite
Previous Next
Reported by: ng0 <contact.ng0 <at> cryptolab.net>
Date: Sat, 4 Mar 2017 12:59:02 UTC
Severity: normal
Done: Leo Famulari <leo <at> famulari.name>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
contact.ng0 <at> cryptolab.net writes:
> + (add-before 'install 'fix-hooks-shebangs
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((perl (string-append (assoc-ref inputs "perl")
> + "/bin/perl")))
> + ;; The files in 'lib/Gitolite/Hooks' keep references to
> + ;; '/usr/bin/perl', without this fix it is impossible to
> + ;; to run gitolite in production.
> + (substitute* (find-files "src/lib/Gitolite/Hooks" ".*")
> + (("/usr/bin/perl")
> + perl))
> + #t)))
This patch introduces references to the store in files installed by
"gitolite setup" command. Those files are installed once and for all.
So for example .gitolite/hooks/common/update's shebang is
#!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. But
then what happens when perl is upgraded, and Guix garbage collected? My
understanding is that the shebang won't work anymore, and gitolite will
be broken.
One can use instead special-files-service-type, which allows to have
/usr/bin/perl working. But it won't work anymore with this patch.
I suggest we revert it, but I might be wrong. WDYT?
This bug report was last modified 8 years and 70 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.