From unknown Fri Jun 20 19:57:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25966 <25966@debbugs.gnu.org> To: bug#25966 <25966@debbugs.gnu.org> Subject: Status: Fix bug 25957 and updates gitolite Reply-To: bug#25966 <25966@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:57:39 +0000 retitle 25966 Fix bug 25957 and updates gitolite reassign 25966 guix-patches submitter 25966 ng0 severity 25966 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 07:58:30 2017 Received: (at submit) by debbugs.gnu.org; 4 Mar 2017 12:58:30 +0000 Received: from localhost ([127.0.0.1]:39243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9GY-0001tq-MC for submit@debbugs.gnu.org; Sat, 04 Mar 2017 07:58:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9GV-0001tZ-RE for submit@debbugs.gnu.org; Sat, 04 Mar 2017 07:58:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ck9GP-0002L5-FX for submit@debbugs.gnu.org; Sat, 04 Mar 2017 07:58:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46380) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ck9GP-0002Ky-Ce for submit@debbugs.gnu.org; Sat, 04 Mar 2017 07:58:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ck9GO-0004dS-Cd for guix-patches@gnu.org; Sat, 04 Mar 2017 07:58:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ck9GJ-0002KK-R3 for guix-patches@gnu.org; Sat, 04 Mar 2017 07:58:20 -0500 Received: from fragranza.investici.org ([178.175.144.26]:22770) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ck9GJ-0002KD-En for guix-patches@gnu.org; Sat, 04 Mar 2017 07:58:15 -0500 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id F163D2C0170 for ; Sat, 4 Mar 2017 12:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488632293; bh=f7i50zP0ib7D/U4Q9hG/iXsu9vSKFbFh4EEiR98eAA4=; h=Date:From:To:Subject; b=q9YXPBMOlkw/TPvoiwxuBFIMlYzcvCbiYGEbxoQd05c4VwX0FhH2UN4m0onuqIGXa HlpUm9m7dEPjmZ34LP1avKiKL+/WpTefprdQ7GKKrviJk4zBvfGfCzRPRCUfVg4aqI jjGwzLO+u53LGgd950zERK++SImJ4SfXIPFwAuo8= Date: Sat, 4 Mar 2017 14:06:59 +0000 From: ng0 To: guix-patches@gnu.org Subject: Fix bug 25957 and updates gitolite Message-ID: <20170304140659.vqhba7zwoaqgyzby@abyayala> Mail-Followup-To: guix-patches@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) These two patches: * update gitolite to 3.6.6, * (attempt to) fix #25957. I write attempt, in theory this closes the bug. I don't run this on my server. I have greped for more occurences of /usr/bin/perl, and the ones I had problems with are gone, remaining are 2 which are completely unrelated to the bug and to the issue in general. I'm 99% positive that the bug will be fixed once this is applied. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 08:01:05 2017 Received: (at 25966) by debbugs.gnu.org; 4 Mar 2017 13:01:05 +0000 Received: from localhost ([127.0.0.1]:39249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9J3-0002sr-2q for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:01:05 -0500 Received: from aibo.runbox.com ([91.220.196.211]:58130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9J0-0002pR-C7 for 25966@debbugs.gnu.org; Sat, 04 Mar 2017 08:01:02 -0500 Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1ck9Iy-0004EJ-Qo; Sat, 04 Mar 2017 14:01:00 +0100 Received: from 136.ip-92-222-84.eu ([92.222.84.136] helo=localhost) by mailfront11.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1ck9It-00018O-Qe; Sat, 04 Mar 2017 14:00:56 +0100 From: contact.ng0@cryptolab.net To: 25966@debbugs.gnu.org Subject: [PATCH 1/2] gnu: gitolite: Update to 3.6.6. Date: Sat, 4 Mar 2017 14:09:31 +0000 Message-Id: <20170304140932.30144-1-contact.ng0@cryptolab.net> X-Mailer: git-send-email 2.12.0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25966 Cc: ng0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) From: ng0 * gnu/packages/version-control.scm (gitolite): Update to 3.6.6. --- gnu/packages/version-control.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 1c3ffb040..1076c1890 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -591,7 +591,7 @@ also walk each side of a merge and test those changes individually.") (define-public gitolite (package (name "gitolite") - (version "3.6.5") + (version "3.6.6") (source (origin (method url-fetch) (uri (string-append @@ -600,7 +600,7 @@ also walk each side of a merge and test those changes individually.") (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 - "0xpqg04gyr4dhdhxx5lbk61lwwd5ml32530bigg2qy663icngwqm")))) + "07q33f86694s0x3k9lcmy1vzfw9appdrlmmb9j3bz4qkrxqdnwb9")))) (build-system gnu-build-system) (arguments '(#:tests? #f ; no tests -- 2.12.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 08:01:06 2017 Received: (at 25966) by debbugs.gnu.org; 4 Mar 2017 13:01:06 +0000 Received: from localhost ([127.0.0.1]:39251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9J4-0002u7-Fs for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:01:06 -0500 Received: from aibo.runbox.com ([91.220.196.211]:58142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9J2-0002sD-LB for 25966@debbugs.gnu.org; Sat, 04 Mar 2017 08:01:05 -0500 Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1ck9J1-0004Ea-Rl; Sat, 04 Mar 2017 14:01:03 +0100 Received: from 136.ip-92-222-84.eu ([92.222.84.136] helo=localhost) by mailfront11.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1ck9Ix-0001Bl-8p; Sat, 04 Mar 2017 14:00:59 +0100 From: contact.ng0@cryptolab.net To: 25966@debbugs.gnu.org Subject: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. Date: Sat, 4 Mar 2017 14:09:32 +0000 Message-Id: <20170304140932.30144-2-contact.ng0@cryptolab.net> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170304140932.30144-1-contact.ng0@cryptolab.net> References: <20170304140932.30144-1-contact.ng0@cryptolab.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25966 Cc: ng0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) From: ng0 Fixes . * gnu/packages/version-control.scm (gitolite)[arguments]: Add 'fix-hooks-shebangs' phase to fix references to '/usr/bin/perl'. --- gnu/packages/version-control.scm | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 1076c1890..ccda00173 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -616,6 +616,17 @@ also walk each side of a merge and test those changes individually.") (substitute* (find-files "." ".*") ((" perl -") (string-append " " perl " -")))))) + (add-before 'install 'fix-hooks-shebangs + (lambda* (#:key inputs #:allow-other-keys) + (let ((perl (string-append (assoc-ref inputs "perl") + "/bin/perl"))) + ;; The files in 'lib/Gitolite/Hooks' keep references to + ;; '/usr/bin/perl', without this fix it is impossible to + ;; to run gitolite in production. + (substitute* (find-files "src/lib/Gitolite/Hooks" ".*") + (("/usr/bin/perl") + perl)) + #t))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) (let* ((output (assoc-ref outputs "out")) -- 2.12.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 08:06:29 2017 Received: (at submit) by debbugs.gnu.org; 4 Mar 2017 13:06:29 +0000 Received: from localhost ([127.0.0.1]:39260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9OH-0003qj-F5 for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:06:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9OF-0003qW-CM for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:06:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ck9O9-0005At-0E for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:06:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58685) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ck9O8-0005Ap-TT for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:06:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ck9O7-0006EQ-Qj for guix-patches@gnu.org; Sat, 04 Mar 2017 08:06:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ck9O4-0005AD-L9 for guix-patches@gnu.org; Sat, 04 Mar 2017 08:06:19 -0500 Received: from perdizione.investici.org ([2001:41d0:2:33d0::19]:38146) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ck9O4-00059w-AW for guix-patches@gnu.org; Sat, 04 Mar 2017 08:06:16 -0500 Received: from [94.23.50.208] (perdizione [94.23.50.208]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id A4CAE120FE7 for ; Sat, 4 Mar 2017 13:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488632774; bh=uwfcN4WzzCdGLNqNWnTTdsCUuWDaIWD5hsZcczb/z84=; h=Date:From:To:Subject:References:In-Reply-To; b=imiLFfjJGO6CBA/49zx+mqUzUAj2fbzG/1OoQytv4TvVdz0FGitG7BJrf0UiSu6/x HmqgARnM3BdFhjFFC/CSncnpV04IoZCTn0QswnwMjVAk+UPkL/mEiPplUmzUeEIyjF bzxcvVUqcGKCExcRPjfaMx4S+YQvkJ5TXyv+T6Qk= Date: Sat, 4 Mar 2017 14:15:01 +0000 From: ng0 To: guix-patches@gnu.org Subject: Re: bug#25966: Fix bug 25957 and updates gitolite Message-ID: <20170304141501.q2pjacwnlmiowdso@abyayala> Mail-Followup-To: guix-patches@gnu.org References: <20170304140659.vqhba7zwoaqgyzby@abyayala> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170304140659.vqhba7zwoaqgyzby@abyayala> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) On 17-03-04 14:06:59, ng0 wrote: > These two patches: > > * update gitolite to 3.6.6, > * (attempt to) fix #25957. > > I write attempt, in theory this closes the bug. I don't run this on my > server. I have greped for more occurences of /usr/bin/perl, and the ones > I had problems with are gone, remaining are 2 which are completely > unrelated to the bug and to the issue in general. > I'm 99% positive that the bug will be fixed once this is applied. > > > I think I missed something very obvious. In the source of gitolite references to /usr/bin/perl occur in these two files, later they don't. Yet at runtime hooks/update and hooks/post-update make gitolite impossible to use as it is now. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 08:08:30 2017 Received: (at submit) by debbugs.gnu.org; 4 Mar 2017 13:08:30 +0000 Received: from localhost ([127.0.0.1]:39264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9QD-0003tf-Sg for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:08:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck9QC-0003tT-F2 for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:08:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ck9Q6-0005cw-Ei for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:08:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ck9Q6-0005cl-B5 for submit@debbugs.gnu.org; Sat, 04 Mar 2017 08:08:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ck9Q5-0006SE-90 for guix-patches@gnu.org; Sat, 04 Mar 2017 08:08:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ck9Q2-0005bV-3z for guix-patches@gnu.org; Sat, 04 Mar 2017 08:08:21 -0500 Received: from latitanza.investici.org ([2001:888:2000:56::19]:20369) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ck9Q1-0005ar-Tv for guix-patches@gnu.org; Sat, 04 Mar 2017 08:08:18 -0500 Received: from [82.94.249.234] (latitanza [82.94.249.234]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 1021C120F04 for ; Sat, 4 Mar 2017 13:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488632896; bh=J5IWbmLfDc4YfbIK0Ecvyecku9HDxuqMlcTMMyHG3Q4=; h=Date:From:To:Subject:References:In-Reply-To; b=jazsm+8m5t32t3MXCECDB2DGKiJquQg0XGgiQjhRBEbTE0hiKnpM6ph6OJRyNcrKt glXGPICXkchpEbDjrjMh4wvCL82oaEV04tcz2lzfg8dF074vFFYCnuKXBDtzeljvUo ckgc0dTX8G1/6Zo6yT6tg/EfWW0XCMVmF28686No= Date: Sat, 4 Mar 2017 14:17:02 +0000 From: ng0 To: guix-patches@gnu.org Subject: Re: bug#25966: Fix bug 25957 and updates gitolite Message-ID: <20170304141702.pevov2rn7norzqbm@abyayala> Mail-Followup-To: guix-patches@gnu.org References: <20170304140659.vqhba7zwoaqgyzby@abyayala> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170304140659.vqhba7zwoaqgyzby@abyayala> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) On 17-03-04 14:06:59, ng0 wrote: > These two patches: > > * update gitolite to 3.6.6, > * (attempt to) fix #25957. > > I write attempt, in theory this closes the bug. I don't run this on my > server. I have greped for more occurences of /usr/bin/perl, and the ones > I had problems with are gone, remaining are 2 which are completely > unrelated to the bug and to the issue in general. > I'm 99% positive that the bug will be fixed once this is applied. > > > Please ignore the previous message I've sent in reply to the one I'm quoting. I was looking for a shebang. There is a __DATA__ section at the end of the perl file, this has been fixed with my patch. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 17:53:13 2017 Received: (at 25966-done) by debbugs.gnu.org; 4 Mar 2017 22:53:13 +0000 Received: from localhost ([127.0.0.1]:40345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckIY5-00038O-7z for submit@debbugs.gnu.org; Sat, 04 Mar 2017 17:53:13 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckIY3-00038F-Ha for 25966-done@debbugs.gnu.org; Sat, 04 Mar 2017 17:53:11 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C940A208B6; Sat, 4 Mar 2017 17:53:09 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Sat, 04 Mar 2017 17:53:09 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=famulari.name; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=3kR72tZ95KIDNc75hKvl9z01Vlw=; b=K2UxtC pXwetEpAqvN+38ao2YdkaDdD7ovyu9e4ESxW4/g37EvhYyqGey2Dhq5zmWE2mg3o Gh5F/bVKFQMhtptlRP/0D9bkPJqwhy+1KcslNoL8+nAW+18WC9vUUUvONMVIgxyv 4aiv3fDyqgCPp+jKTQS4bylAzSemQThiKutjE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=3kR72tZ95KIDNc 75hKvl9z01Vlw=; b=sen8TskxxuTfwnjyXIPd3qExloZBe3aF1C1FrgHIzKaTnQ 8KuxJL3x7PVtv2AwZkI5ylgut2/5IXkgm0lzAmZ1573OLQqfwIIKN3+Y3Hr6iMqe ShW+WEQlwSILHP16wUiH76KBoPZlxfQW4yitEwcBUAkOMvC89xPofIT8RS8ao= X-ME-Sender: X-Sasl-enc: W8wf8fRjLhcAIF+zHci81ehB8i4Zw7uneDSaP2AgrKdt 1488667989 Received: from localhost (c-73-188-17-148.hsd1.pa.comcast.net [73.188.17.148]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D8147E638 for <25966-done@debbugs.gnu.org>; Sat, 4 Mar 2017 17:53:09 -0500 (EST) Date: Sat, 4 Mar 2017 17:53:08 -0500 From: Leo Famulari To: 25966-done@debbugs.gnu.org Subject: Re: bug#25966: Fix bug 25957 and updates gitolite Message-ID: <20170304225308.GA19780@jasmine> References: <20170304140659.vqhba7zwoaqgyzby@abyayala> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170304140659.vqhba7zwoaqgyzby@abyayala> User-Agent: Mutt/1.8.0 (2017-02-23) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25966-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Mar 04, 2017 at 02:06:59PM +0000, ng0 wrote: > These two patches: > > * update gitolite to 3.6.6, > * (attempt to) fix #25957. > > I write attempt, in theory this closes the bug. I don't run this on my > server. I have greped for more occurences of /usr/bin/perl, and the ones > I had problems with are gone, remaining are 2 which are completely > unrelated to the bug and to the issue in general. > I'm 99% positive that the bug will be fixed once this is applied. Pushed From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 18:10:34 2017 Received: (at 25966) by debbugs.gnu.org; 4 Mar 2017 23:10:34 +0000 Received: from localhost ([127.0.0.1]:40371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckIor-0003b5-TV for submit@debbugs.gnu.org; Sat, 04 Mar 2017 18:10:34 -0500 Received: from perdizione.investici.org ([94.23.50.208]:50161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckIop-0003au-5h for 25966@debbugs.gnu.org; Sat, 04 Mar 2017 18:10:31 -0500 Received: from [94.23.50.208] (perdizione [94.23.50.208]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id DD0E41201DF; Sat, 4 Mar 2017 23:10:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488669030; bh=4Y8XhzE03a2UFS6sYrskIRdwpiD/MflkydfXWUkPUDE=; h=Date:From:To:Subject:References:In-Reply-To; b=T4LfoytO9AQlaFyMdVwqlkaGlGMS9uPBMSbqRwc0gaOExTbQakAp838nGHMt1oafm J2Awfohncte1uclC95ykm8evnGpFCGTiDzXv36TylYT3+OtPCUGPpoZC9N89l8POnj F6rE/KBKruu926OENifVV9oPIq9BVSPzLr+MKrEo= Date: Sun, 5 Mar 2017 00:19:13 +0000 From: ng0 To: 25966@debbugs.gnu.org, leo@famulari.name Subject: Re: bug#25966: Fix bug 25957 and updates gitolite Message-ID: <20170305001913.rdqe7pnx5lna3vbx@abyayala> Mail-Followup-To: 25966@debbugs.gnu.org, leo@famulari.name References: <20170304140659.vqhba7zwoaqgyzby@abyayala> <20170304225308.GA19780@jasmine> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170304225308.GA19780@jasmine> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25966 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 17-03-04 17:53:08, Leo Famulari wrote: > On Sat, Mar 04, 2017 at 02:06:59PM +0000, ng0 wrote: > > These two patches: > > > > * update gitolite to 3.6.6, > > * (attempt to) fix #25957. > > > > I write attempt, in theory this closes the bug. I don't run this on my > > server. I have greped for more occurences of /usr/bin/perl, and the ones > > I had problems with are gone, remaining are 2 which are completely > > unrelated to the bug and to the issue in general. > > I'm 99% positive that the bug will be fixed once this is applied. > > Pushed > > > I've been reading the bugtracker again, and there's this: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25508 quoting in full: The git package ships with a number of sample hook files. These are shell scripts and therefore the #!/bin/sh line gets substituted at build time. However these files get installed into every git repostory that is created, and users are invited to use them as templates for their own hooks. This will be fine until both git and bash are updated. Now the original bash is free to be garbage collected. If that happens, the path: #!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh will no longer exist. I suggest what we turn off the shebang patching for the files in share/templates for git. J' quote end. The "hooks/update" in resulting repositories using gitolite is a symlink to "/home/git/.gitolite/hooks/common/update". Will this file ever change? Maybe it makes more sense to have the symlink to "~/.guix-profile/bin/perl" or something similar? I guess only time will tell, and I will notice as soon as garbage collection removed the perl in the shebang. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 10:24:19 2017 Received: (at 25966) by debbugs.gnu.org; 5 Mar 2017 15:24:19 +0000 Received: from localhost ([127.0.0.1]:41112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckY1D-0005kr-7g for submit@debbugs.gnu.org; Sun, 05 Mar 2017 10:24:19 -0500 Received: from mail.lassieur.org ([83.152.10.219]:55128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckY1B-0005ki-B9 for 25966@debbugs.gnu.org; Sun, 05 Mar 2017 10:24:18 -0500 Received: from rodion (unknown [192.168.0.254]) by mail.lassieur.org (Postfix) with ESMTPSA id E1504640103; Sun, 5 Mar 2017 16:24:13 +0100 (CET) References: <20170304140932.30144-1-contact.ng0@cryptolab.net> <20170304140932.30144-2-contact.ng0@cryptolab.net> User-agent: mu4e 0.9.18; emacs 25.2.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: contact.ng0@cryptolab.net Subject: Re: bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. In-reply-to: <20170304140932.30144-2-contact.ng0@cryptolab.net> Date: Sun, 05 Mar 2017 16:24:14 +0100 Message-ID: <87o9xfsq5d.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25966 Cc: 25966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) contact.ng0@cryptolab.net writes: > + (add-before 'install 'fix-hooks-shebangs > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((perl (string-append (assoc-ref inputs "perl") > + "/bin/perl"))) > + ;; The files in 'lib/Gitolite/Hooks' keep references to > + ;; '/usr/bin/perl', without this fix it is impossible to > + ;; to run gitolite in production. > + (substitute* (find-files "src/lib/Gitolite/Hooks" ".*") > + (("/usr/bin/perl") > + perl)) > + #t))) This patch introduces references to the store in files installed by "gitolite setup" command. Those files are installed once and for all. So for example .gitolite/hooks/common/update's shebang is #!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. But then what happens when perl is upgraded, and Guix garbage collected? My understanding is that the shebang won't work anymore, and gitolite will be broken. One can use instead special-files-service-type, which allows to have /usr/bin/perl working. But it won't work anymore with this patch. I suggest we revert it, but I might be wrong. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 10:45:50 2017 Received: (at 25966) by debbugs.gnu.org; 5 Mar 2017 15:45:50 +0000 Received: from localhost ([127.0.0.1]:41125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckYM1-0006GD-PH for submit@debbugs.gnu.org; Sun, 05 Mar 2017 10:45:49 -0500 Received: from perdizione.investici.org ([94.23.50.208]:56173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckYM0-0006G5-J8 for 25966@debbugs.gnu.org; Sun, 05 Mar 2017 10:45:48 -0500 Received: from [94.23.50.208] (perdizione [94.23.50.208]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 5BBB3121270; Sun, 5 Mar 2017 15:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488728747; bh=c5HvdCuYcxV97PdEK2RdVlWcWaNuchjWFEm9AUDn5Jw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=JQsVjtWfOBykPgbWAu4JEAeKIyt5iYlI5sYZ7avV+oNj+h5weSsKUOrRnokJfhblV glM2Gh5YpumTWyh62SEyLSVxZd6SyrEftUxoKIWJ67nqVAwCmx1gtprI5yodp/CS2W 1SOxJTkfVCxpTg5yr/wFiZve2FuT5yIV/gqmt4yU= Date: Sun, 5 Mar 2017 16:54:31 +0000 From: ng0 To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. Message-ID: <20170305165431.b5mpnwpriqk4p5rn@abyayala> Mail-Followup-To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur , 25966@debbugs.gnu.org References: <20170304140932.30144-1-contact.ng0@cryptolab.net> <20170304140932.30144-2-contact.ng0@cryptolab.net> <87o9xfsq5d.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87o9xfsq5d.fsf@lassieur.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25966 Cc: 25966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 17-03-05 16:24:14, Clément Lassieur wrote: > contact.ng0@cryptolab.net writes: > > > + (add-before 'install 'fix-hooks-shebangs > > + (lambda* (#:key inputs #:allow-other-keys) > > + (let ((perl (string-append (assoc-ref inputs "perl") > > + "/bin/perl"))) > > + ;; The files in 'lib/Gitolite/Hooks' keep references to > > + ;; '/usr/bin/perl', without this fix it is impossible to > > + ;; to run gitolite in production. > > + (substitute* (find-files "src/lib/Gitolite/Hooks" ".*") > > + (("/usr/bin/perl") > > + perl)) > > + #t))) > > This patch introduces references to the store in files installed by > "gitolite setup" command. Those files are installed once and for all. > So for example .gitolite/hooks/common/update's shebang is > #!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. But > then what happens when perl is upgraded, and Guix garbage collected? My > understanding is that the shebang won't work anymore, and gitolite will > be broken. > > One can use instead special-files-service-type, which allows to have > /usr/bin/perl working. But it won't work anymore with this patch. > > I suggest we revert it, but I might be wrong. WDYT? I wanted a solution which works. I didn't consider this until it was merged in (see my last reply). I don't think special-file-types are a solution, I want this to work out of the box so that a service I want to write for gitolite will work. It can be a solution if it would work with the service and when it will be documented as a requirement for gitolite. The off-the-shelves status of gitolite is broken, you are not informed about these shebangs.. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 10:30:09 2017 Received: (at 25966) by debbugs.gnu.org; 13 Mar 2017 14:30:09 +0000 Received: from localhost ([127.0.0.1]:53998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnQzA-0007t8-TW for submit@debbugs.gnu.org; Mon, 13 Mar 2017 10:30:09 -0400 Received: from mail.lassieur.org ([83.152.10.219]:49484 helo=ron) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnQz9-0007sM-AD for 25966@debbugs.gnu.org; Mon, 13 Mar 2017 10:30:07 -0400 Received: from newt (46.218.109.88 [46.218.109.88]) by ron (OpenSMTPD) with ESMTPSA id bc250ef6 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 13 Mar 2017 14:30:02 +0000 (UTC) References: <20170304140932.30144-1-contact.ng0@cryptolab.net> <20170304140932.30144-2-contact.ng0@cryptolab.net> <87o9xfsq5d.fsf@lassieur.org> <20170305165431.b5mpnwpriqk4p5rn@abyayala> User-agent: mu4e 0.9.18; emacs 25.2.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: ng0 Subject: Re: bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. In-reply-to: <20170305165431.b5mpnwpriqk4p5rn@abyayala> X-TUID: zVPmOuf7x6ul Date: Mon, 13 Mar 2017 15:30:01 +0100 Message-ID: <8737eh8d1y.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 25966 Cc: 25966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) ng0 writes: > On 17-03-05 16:24:14, Clément Lassieur wrote: >> contact.ng0@cryptolab.net writes: >> >> > + (add-before 'install 'fix-hooks-shebangs >> > + (lambda* (#:key inputs #:allow-other-keys) >> > + (let ((perl (string-append (assoc-ref inputs "perl") >> > + "/bin/perl"))) >> > + ;; The files in 'lib/Gitolite/Hooks' keep references to >> > + ;; '/usr/bin/perl', without this fix it is impossible to >> > + ;; to run gitolite in production. >> > + (substitute* (find-files "src/lib/Gitolite/Hooks" ".*") >> > + (("/usr/bin/perl") >> > + perl)) >> > + #t))) >> >> This patch introduces references to the store in files installed by >> "gitolite setup" command. Those files are installed once and for all. >> So for example .gitolite/hooks/common/update's shebang is >> #!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. But >> then what happens when perl is upgraded, and Guix garbage collected? My >> understanding is that the shebang won't work anymore, and gitolite will >> be broken. >> >> One can use instead special-files-service-type, which allows to have >> /usr/bin/perl working. But it won't work anymore with this patch. >> >> I suggest we revert it, but I might be wrong. WDYT? > > I wanted a solution which works. I didn't consider this until it was > merged in (see my last reply). I don't think special-file-types are > a solution, I want this to work out of the box so that a service I want > to write for gitolite will work. > It can be a solution if it would work with the service and when it will > be documented as a requirement for gitolite. The off-the-shelves status > of gitolite is broken, you are not informed about these shebangs.. This solution works right now, but later, when perl is garbage collected, it won't work anymore. And this is worse that just not working, because things may already be in production when the bug appears. The special-files-service-type workaround has the benefit of being stable: while the user doesn't change her configuration, it will work. Even though it does not work "out of the box". So once again, I suggest we revert it. Please could someone else comment on this? (BTW, when this is reverted, users who did run "gitolite setup" with this patch applied will still have the bug: they'll have to fix it manually. So the sooner the better.) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 13:00:56 2017 Received: (at 25966) by debbugs.gnu.org; 13 Mar 2017 17:00:56 +0000 Received: from localhost ([127.0.0.1]:54135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnTL6-00034K-B0 for submit@debbugs.gnu.org; Mon, 13 Mar 2017 13:00:56 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnTL4-000349-8H for 25966@debbugs.gnu.org; Mon, 13 Mar 2017 13:00:54 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 87318208BD; Mon, 13 Mar 2017 13:00:53 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Mon, 13 Mar 2017 13:00:53 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=E4mPwIZBhRZHSxckyIUuTs8JPQY=; b=HFSu0E vylZby0eQJuPq/9vBevcB1OI14QA2IYBaWvTQF/HpGlMclvjzsWY8yJVMXCtvw5c op4FVplQnT8ExfQsY4hBoo/H76fvdn3QmZsOZw5FuGSr3T8KqJU1VhJF02/qBzrZ xEE70yTMIGByWowAqSjCcZQtdrvz+apRxYTZE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=E4mPwIZBhRZHSx ckyIUuTs8JPQY=; b=uUKe3ofHlYhyMKyJIVEiMLbUgyl0KLYhkv9PViK6DUpYax 4T/+421fNgn9x7Za2nIoMDH4DsVlWyzbkHeeSDRJ0RCuOk9cjXiL9TRHUB3OxgNB KuZqQSo+ru7yay7/4ZQ1b3EjO5sYbCMWHQzZBc0OvwObt9s4bbRa7x8KQtNiI= X-ME-Sender: X-Sasl-enc: BtgtpP7lzTkIUv+e+9H0/p95oyFg1EUoubqXyVmZJ64Q 1489424453 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 1939D7E41F; Mon, 13 Mar 2017 13:00:52 -0400 (EDT) From: Marius Bakke To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur , ng0 Subject: Re: bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. In-Reply-To: <8737eh8d1y.fsf@lassieur.org> References: <20170304140932.30144-1-contact.ng0@cryptolab.net> <20170304140932.30144-2-contact.ng0@cryptolab.net> <87o9xfsq5d.fsf@lassieur.org> <20170305165431.b5mpnwpriqk4p5rn@abyayala> <8737eh8d1y.fsf@lassieur.org> User-Agent: Notmuch/0.23.7 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) Date: Mon, 13 Mar 2017 18:00:51 +0100 Message-ID: <87bmt5i01o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25966 Cc: 25966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cl=C3=A9ment Lassieur writes: > ng0 writes: > >> On 17-03-05 16:24:14, Cl=C3=A9ment Lassieur wrote: >>> contact.ng0@cryptolab.net writes: >>>=20 >>> > + (add-before 'install 'fix-hooks-shebangs >>> > + (lambda* (#:key inputs #:allow-other-keys) >>> > + (let ((perl (string-append (assoc-ref inputs "= perl") >>> > + "/bin/perl"))) >>> > + ;; The files in 'lib/Gitolite/Hooks' keep re= ferences to >>> > + ;; '/usr/bin/perl', without this fix it is i= mpossible to >>> > + ;; to run gitolite in production. >>> > + (substitute* (find-files "src/lib/Gitolite/H= ooks" ".*") >>> > + (("/usr/bin/perl") >>> > + perl)) >>> > + #t))) >>>=20 >>> This patch introduces references to the store in files installed by >>> "gitolite setup" command. Those files are installed once and for all. >>> So for example .gitolite/hooks/common/update's shebang is >>> #!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. But >>> then what happens when perl is upgraded, and Guix garbage collected? My >>> understanding is that the shebang won't work anymore, and gitolite will >>> be broken. >>>=20 >>> One can use instead special-files-service-type, which allows to have >>> /usr/bin/perl working. But it won't work anymore with this patch. >>>=20 >>> I suggest we revert it, but I might be wrong. WDYT? >> >> I wanted a solution which works. I didn't consider this until it was >> merged in (see my last reply). I don't think special-file-types are >> a solution, I want this to work out of the box so that a service I want >> to write for gitolite will work. >> It can be a solution if it would work with the service and when it will >> be documented as a requirement for gitolite. The off-the-shelves status >> of gitolite is broken, you are not informed about these shebangs.. > > This solution works right now, but later, when perl is garbage > collected, it won't work anymore. And this is worse that just not > working, because things may already be in production when the bug > appears. > > The special-files-service-type workaround has the benefit of being > stable: while the user doesn't change her configuration, it will work. > Even though it does not work "out of the box". > > So once again, I suggest we revert it. Please could someone else > comment on this? > > (BTW, when this is reverted, users who did run "gitolite setup" with > this patch applied will still have the bug: they'll have to fix it > manually. So the sooner the better.) So the problem is that created repositories has a perl reference that is not visible to the garbage collector. Would it be possible to convince Gitolite to create GC roots for each repo? That's about the only thing I can think of that will work on both GuixSD and foreign distros. Using the "special-files-service-type" to create /usr/bin/perl on GuixSD seems "hacky"; users might want to have a different perl in "/usr/bin". --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljG0EMACgkQoqBt8qM6 VPotmwf9HCOeWQzQKNYW1YCi0L67jLAwbbc+3bvZtZhVX3wqZmHub0gNuXtYMGll A7XIAt03RYLLFo3zWw0sjA8GphH3VSQHsvpvubEqmmOYzOp1XmHJ7K4TmQqo0HBK 8OUPdNPy6vmUIMDhADvAR0kYKvJkt7K3nzrF7eGwSzJNQpk3sy8T56DqGnuQgFZe FxAiLN4iBY5/P+u1CmiP3docuvBQk/V0BuFZ6ECVu4W9U70Gi801EwZleg7KWYPx 8hz5Yssp8tcX4H7YkkQZ24OpnsYjbI5QBZRDL6vr5LFDU3dPQ4E3gc5yQoGp+/0D AlLX/ufA9u5mo7hHFhDPfOMpUWuaMg== =cGxx -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 13:16:37 2017 Received: (at 25966) by debbugs.gnu.org; 13 Mar 2017 17:16:37 +0000 Received: from localhost ([127.0.0.1]:54145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnTaH-0003Su-15 for submit@debbugs.gnu.org; Mon, 13 Mar 2017 13:16:37 -0400 Received: from fragranza.investici.org ([178.175.144.26]:60322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnTaE-0003Sk-Dc for 25966@debbugs.gnu.org; Mon, 13 Mar 2017 13:16:35 -0400 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 519D72C01E4; Mon, 13 Mar 2017 17:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1489425392; bh=/g98eGstFugimrE1ONU/xx/mSFtzVH2Bfu1nNM6N08U=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=hyPvPMGAejM0PxPO6/1ugmvZIyAHHBYBjwzXgSAQPUkh52uIDpWxG1Qx80gVd/eaC kEDpBVDA7TVmSm7rrKWphcT73L3JAY5U+y+6dYq1ntiXLtfC2zOED6hwe+UcxUnMMb SP8PQSxcdCRAQ6Udt5ruKgCWhitUOvVbqc6T6Fbg= Date: Mon, 13 Mar 2017 18:25:14 +0000 From: ng0 To: Marius Bakke Subject: Re: bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. Message-ID: <20170313182514.pvp3dbw5h6krdlxm@abyayala> Mail-Followup-To: Marius Bakke , =?utf-8?Q?Cl=C3=A9ment?= Lassieur , 25966@debbugs.gnu.org References: <20170304140932.30144-1-contact.ng0@cryptolab.net> <20170304140932.30144-2-contact.ng0@cryptolab.net> <87o9xfsq5d.fsf@lassieur.org> <20170305165431.b5mpnwpriqk4p5rn@abyayala> <8737eh8d1y.fsf@lassieur.org> <87bmt5i01o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87bmt5i01o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25966 Cc: 25966@debbugs.gnu.org, =?utf-8?Q?Cl=C3=A9ment?= Lassieur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Marius Bakke transcribed 3.8K bytes: > Clément Lassieur writes: > > > ng0 writes: > > > >> On 17-03-05 16:24:14, Clément Lassieur wrote: > >>> contact.ng0@cryptolab.net writes: > >>> > >>> > + (add-before 'install 'fix-hooks-shebangs > >>> > + (lambda* (#:key inputs #:allow-other-keys) > >>> > + (let ((perl (string-append (assoc-ref inputs "perl") > >>> > + "/bin/perl"))) > >>> > + ;; The files in 'lib/Gitolite/Hooks' keep references to > >>> > + ;; '/usr/bin/perl', without this fix it is impossible to > >>> > + ;; to run gitolite in production. > >>> > + (substitute* (find-files "src/lib/Gitolite/Hooks" ".*") > >>> > + (("/usr/bin/perl") > >>> > + perl)) > >>> > + #t))) > >>> > >>> This patch introduces references to the store in files installed by > >>> "gitolite setup" command. Those files are installed once and for all. > >>> So for example .gitolite/hooks/common/update's shebang is > >>> #!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. But > >>> then what happens when perl is upgraded, and Guix garbage collected? My > >>> understanding is that the shebang won't work anymore, and gitolite will > >>> be broken. > >>> > >>> One can use instead special-files-service-type, which allows to have > >>> /usr/bin/perl working. But it won't work anymore with this patch. > >>> > >>> I suggest we revert it, but I might be wrong. WDYT? > >> > >> I wanted a solution which works. I didn't consider this until it was > >> merged in (see my last reply). I don't think special-file-types are > >> a solution, I want this to work out of the box so that a service I want > >> to write for gitolite will work. > >> It can be a solution if it would work with the service and when it will > >> be documented as a requirement for gitolite. The off-the-shelves status > >> of gitolite is broken, you are not informed about these shebangs.. > > > > This solution works right now, but later, when perl is garbage > > collected, it won't work anymore. And this is worse that just not > > working, because things may already be in production when the bug > > appears. > > > > The special-files-service-type workaround has the benefit of being > > stable: while the user doesn't change her configuration, it will work. > > Even though it does not work "out of the box". > > > > So once again, I suggest we revert it. Please could someone else > > comment on this? > > > > (BTW, when this is reverted, users who did run "gitolite setup" with > > this patch applied will still have the bug: they'll have to fix it > > manually. So the sooner the better.) > > So the problem is that created repositories has a perl reference that is > not visible to the garbage collector. Would it be possible to convince > Gitolite to create GC roots for each repo? That's about the only thing I Can you clarify what you mean? Convince it… how? Do you have an idea how to achieve this, or some further thoughts on the matter? > can think of that will work on both GuixSD and foreign distros. > > Using the "special-files-service-type" to create /usr/bin/perl on GuixSD > seems "hacky"; users might want to have a different perl in "/usr/bin". From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 15:35:58 2017 Received: (at 25966) by debbugs.gnu.org; 13 Mar 2017 19:35:58 +0000 Received: from localhost ([127.0.0.1]:54324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnVl7-0006w6-Nm for submit@debbugs.gnu.org; Mon, 13 Mar 2017 15:35:58 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnVl5-0006vz-PC for 25966@debbugs.gnu.org; Mon, 13 Mar 2017 15:35:56 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A7FF620A32; Mon, 13 Mar 2017 15:35:55 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Mon, 13 Mar 2017 15:35:55 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=MqNsRCVlGr0c59SAHe5B6N1Cvnk=; b=eEVpe3 V4AeZo6rIR99hlMFu59l0KHq410nLtjIRX5BaG4WzCVh0eBugLfO9YdxS+prvNBb EwveAwYtzCz4JniPxKH6294pX3JJtJULU09P4ITzEN3SBIKmhrtuvSFjK+jbN/Qh jQjydNk2VxtmGpeFEH+pCt425Nk7QlCSt/PLg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=MqNsRCVlGr0c59 SAHe5B6N1Cvnk=; b=RokBk4hgKkeo5BC2Bgikwl5/LV6rlQRTXPgP3claRv7t+8 fa8M4we1N/4uwd9fgmdFflaS6JMoiMASymT7LYnwANrSaXOMrMAkOjjq+mBKR6Xs HmLxGNl2jYOAefX4njnHY0adULxQUUHgqtjLDEYj6UV7HAiK+0rywfJjSGVC0= X-ME-Sender: X-Sasl-enc: XtdFC0a719oJ1msPj5AUnqhx8xn9qkDN39RAAe91oXIn 1489433755 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 30538241D8; Mon, 13 Mar 2017 15:35:55 -0400 (EDT) From: Marius Bakke To: ng0 Subject: Re: bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. In-Reply-To: <20170313182514.pvp3dbw5h6krdlxm@abyayala> References: <20170304140932.30144-1-contact.ng0@cryptolab.net> <20170304140932.30144-2-contact.ng0@cryptolab.net> <87o9xfsq5d.fsf@lassieur.org> <20170305165431.b5mpnwpriqk4p5rn@abyayala> <8737eh8d1y.fsf@lassieur.org> <87bmt5i01o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170313182514.pvp3dbw5h6krdlxm@abyayala> User-Agent: Notmuch/0.24 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) Date: Mon, 13 Mar 2017 20:35:53 +0100 Message-ID: <87tw6x3r6u.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25966 Cc: 25966@debbugs.gnu.org, =?utf-8?Q?Cl=C3=A9ment?= Lassieur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ng0 writes: > Marius Bakke transcribed 3.8K bytes: >> Cl=C3=A9ment Lassieur writes: >>=20 >> > ng0 writes: >> > >> >> On 17-03-05 16:24:14, Cl=C3=A9ment Lassieur wrote: >> >>> contact.ng0@cryptolab.net writes: >> >>>=20 >> >>> > + (add-before 'install 'fix-hooks-shebangs >> >>> > + (lambda* (#:key inputs #:allow-other-keys) >> >>> > + (let ((perl (string-append (assoc-ref input= s "perl") >> >>> > + "/bin/perl"))) >> >>> > + ;; The files in 'lib/Gitolite/Hooks' keep= references to >> >>> > + ;; '/usr/bin/perl', without this fix it i= s impossible to >> >>> > + ;; to run gitolite in production. >> >>> > + (substitute* (find-files "src/lib/Gitolit= e/Hooks" ".*") >> >>> > + (("/usr/bin/perl") >> >>> > + perl)) >> >>> > + #t))) >> >>>=20 >> >>> This patch introduces references to the store in files installed by >> >>> "gitolite setup" command. Those files are installed once and for al= l. >> >>> So for example .gitolite/hooks/common/update's shebang is >> >>> #!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. = But >> >>> then what happens when perl is upgraded, and Guix garbage collected?= My >> >>> understanding is that the shebang won't work anymore, and gitolite w= ill >> >>> be broken. >> >>>=20 >> >>> One can use instead special-files-service-type, which allows to have >> >>> /usr/bin/perl working. But it won't work anymore with this patch. >> >>>=20 >> >>> I suggest we revert it, but I might be wrong. WDYT? >> >> >> >> I wanted a solution which works. I didn't consider this until it was >> >> merged in (see my last reply). I don't think special-file-types are >> >> a solution, I want this to work out of the box so that a service I wa= nt >> >> to write for gitolite will work. >> >> It can be a solution if it would work with the service and when it wi= ll >> >> be documented as a requirement for gitolite. The off-the-shelves stat= us >> >> of gitolite is broken, you are not informed about these shebangs.. >> > >> > This solution works right now, but later, when perl is garbage >> > collected, it won't work anymore. And this is worse that just not >> > working, because things may already be in production when the bug >> > appears. >> > >> > The special-files-service-type workaround has the benefit of being >> > stable: while the user doesn't change her configuration, it will work. >> > Even though it does not work "out of the box". >> > >> > So once again, I suggest we revert it. Please could someone else >> > comment on this? >> > >> > (BTW, when this is reverted, users who did run "gitolite setup" with >> > this patch applied will still have the bug: they'll have to fix it >> > manually. So the sooner the better.) >>=20 >> So the problem is that created repositories has a perl reference that is >> not visible to the garbage collector. Would it be possible to convince >> Gitolite to create GC roots for each repo? That's about the only thing I > > Can you clarify what you mean? Convince it=E2=80=A6 how? Do you have an i= dea how > to achieve this, or some further thoughts on the matter? It was just a passing thought, but I don't think it's a good solution since we don't want users to rely on potentially outdated versions of perl. So a 'special-file-service' for '/usr/bin/perl' is indeed better. Or perhaps use "env" from coreutils to execute whatever perl is in PATH. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljG9JkACgkQoqBt8qM6 VPoUKAf8DPcvuIampcZUrWPzz1Mymqaxm2OHa7GP4qHCNp99QKcX1P9Qw2OwyJaT nk3k5yHgBPYtlxmf0REuL8hkqZjxLqH5Ovwqi3tHko9B57CP1MGk9Xrjp0xZqe/w gC1so/Nh/szZimT8DdB9Fm/WObzRE4z5BvlWiEfFirVAgtKjCgVv6Nn9JsJyO3hF Yst5l01ffvh7GhmQHWt5o95nV63v7p0TaKddo8drrptzJAOY3RwGXuxP6ovRBFiE vxB0xgXWtXQE3UkPmrZJAweB3XWH7ah6UsvkZSNnU2AWNwfaSvwxzeLj/VeClN+c dSomJDXqOmfIwmpdN2RG/Q68GmIrLA== =iCMQ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 13:39:12 2017 Received: (at 25966) by debbugs.gnu.org; 14 Mar 2017 17:39:12 +0000 Received: from localhost ([127.0.0.1]:55904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnqPf-00083A-UY for submit@debbugs.gnu.org; Tue, 14 Mar 2017 13:39:12 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnqPc-00082y-Hy for 25966@debbugs.gnu.org; Tue, 14 Mar 2017 13:39:10 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2493721A86; Tue, 14 Mar 2017 13:39:08 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Tue, 14 Mar 2017 13:39:08 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=famulari.name; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=0KfI93c82DSLpXDI06Tlucw3GeE=; b=chGtKw bgLksEs2HYKGk1mYUqF3RhhFlkmuP5l3xQO+8YB/4kUoQX7ebpIzqg9hPbmQHWTy Q594BsgvcQPRqlVp0lmIkgyNEXOMGIiPl4ww59t6gY6OJX4NBMn2ZLXXiziBU2CW mgKc3UQR+ivUwaN5txfOFq1NkugsCnlQpHp4w= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=0KfI93c82DSLpX DI06Tlucw3GeE=; b=jm7YVumMJYZnJtrsNAu20PwVTNZW+4QO19WAVnbBakvvGW WZtEX5+EQyPHCn/G5eOd29M/q54QytClGeirra+t6ry9qRQigx7sAOXSu9Q6RUMh sndF/8qH4wFTlCLdUQcOgwCgnLm1yxTcAHZw3gRtXcwy0kpF3LyRTd/IOEKLE= X-ME-Sender: X-Sasl-enc: LeWTKglIKwBMhs/kBCzVXXroCBwiE0zcOdRk1tOLltxM 1489513147 Received: from localhost (c-73-188-17-148.hsd1.pa.comcast.net [73.188.17.148]) by mail.messagingengine.com (Postfix) with ESMTPA id D406D241ED; Tue, 14 Mar 2017 13:39:07 -0400 (EDT) Date: Tue, 14 Mar 2017 13:39:06 -0400 From: Leo Famulari To: =?iso-8859-1?Q?Cl=E9ment?= Lassieur Subject: Re: bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. Message-ID: <20170314173906.GA9175@jasmine> References: <20170304140932.30144-1-contact.ng0@cryptolab.net> <20170304140932.30144-2-contact.ng0@cryptolab.net> <87o9xfsq5d.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uAKRQypu60I7Lcqm" Content-Disposition: inline In-Reply-To: <87o9xfsq5d.fsf@lassieur.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25966 Cc: 25966@debbugs.gnu.org, contact.ng0@cryptolab.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 05, 2017 at 04:24:14PM +0100, Cl=E9ment Lassieur wrote: > contact.ng0@cryptolab.net writes: >=20 > > + (add-before 'install 'fix-hooks-shebangs > > + (lambda* (#:key inputs #:allow-other-keys) > > + (let ((perl (string-append (assoc-ref inputs "pe= rl") > > + "/bin/perl"))) > > + ;; The files in 'lib/Gitolite/Hooks' keep refe= rences to > > + ;; '/usr/bin/perl', without this fix it is imp= ossible to > > + ;; to run gitolite in production. > > + (substitute* (find-files "src/lib/Gitolite/Hoo= ks" ".*") > > + (("/usr/bin/perl") > > + perl)) > > + #t))) >=20 > This patch introduces references to the store in files installed by > "gitolite setup" command. Those files are installed once and for all. > So for example .gitolite/hooks/common/update's shebang is > #!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. But > then what happens when perl is upgraded, and Guix garbage collected? My > understanding is that the shebang won't work anymore, and gitolite will > be broken. >=20 > One can use instead special-files-service-type, which allows to have > /usr/bin/perl working. But it won't work anymore with this patch. Ah, seems like the same issue as with the Git hooks. > I suggest we revert it, but I might be wrong. WDYT? If these hooks are intended to be copied out of /gnu/store, then the change should be reverted until we have a better solution. I think it's better for the hook scripts to fail the first time than for them to fail later, after a seemingly unrelated action like `guix gc`. --uAKRQypu60I7Lcqm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAljIKrcACgkQJkb6MLrK fwgHIA/+PDppBXU+/mJnBcwZXJ6otRiCHJQOYtKHyksNTvDDY26wcNQq9Moud5r7 Wx1hrfjdikTJ8FIs53w8oEs2UqSE+u89qk7hlmFjLDCfb3Rt5tl2l1wQDZoLBdmI gplCIc8UC/o8Uwm0XFlwoxeQzE0zPa4W6cQ1iBYlzshqDZauINNHhTC7CStVqR1R wH6PwsrBhwrjJJP/t46tZcX1Zu1zpa+F6lLbARQyA/WR4UFIAs8RKZV8soDjfb/N DXdjF/NiTSoYgm475XDHYxBvFAj84Lv4Dv28SXS9kltzSZnsNmUohPYTNSMFm7cY YwRU8xkrYgIRP2R6KtaaUEXmP5NZypr+R08IBJEoOtm79IeurcseHmbp508/NJD1 HHml38GZSWG2Lriex3l4sm9xbwRxJ0yesssRuoMCBUa3qXsyV1NdP20SCnYJsYzc nxALKptUyodahyzdDgrOnYbe3nsSxSkae5qR/nKe35WfM7a/0f9Tt9NIjuEay3ND Z7Ng42vwqoz1aBW6+cRjG2opnwlaHMfFbwa8tK9ggrZHyd6TTMkSLNS5vQTdlSVo L8u7yiHPsIJVRY032eOT/3ZIjJRy4jqo9GKu5LWUfU3XKxFC+rR3kz79ZCX8T81l vInDiU2ZWFnQw7K6JWEXS6WvBLKLcH032eHI5Z8nODExbSFCXAM= =77QW -----END PGP SIGNATURE----- --uAKRQypu60I7Lcqm-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 14:18:29 2017 Received: (at 25966) by debbugs.gnu.org; 14 Mar 2017 18:18:29 +0000 Received: from localhost ([127.0.0.1]:55925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnr1h-0000W7-6N for submit@debbugs.gnu.org; Tue, 14 Mar 2017 14:18:29 -0400 Received: from fragranza.investici.org ([178.175.144.26]:38896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnr1e-0000Vw-7T for 25966@debbugs.gnu.org; Tue, 14 Mar 2017 14:18:27 -0400 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 914372C036C; Tue, 14 Mar 2017 18:18:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1489515504; bh=AQ2UWHWqPyyPKd1TwqdBcRy/icCsPRg0ndIT0NHhrFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=s7waGB1jSRyRZ+fwAoSvL9KFcSRMNQ4vsODpZTeSihgj4Egb/uD7DFWCm/Ju0YxeD 4BaxImyIvPcU8iHdi79d+FrB8JZhAzMseC3KmXcoS74aF5bTsR4foCW3IJ/Mhpecwg aolaoO/6FK+q8IIgfNJgM6Nbj2eTURclA35YTR60= Date: Tue, 14 Mar 2017 19:27:02 +0000 From: ng0 To: Leo Famulari Subject: Re: bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. Message-ID: <20170314192702.mnkxvdwj7neiefk4@abyayala> Mail-Followup-To: Leo Famulari , =?utf-8?Q?Cl=C3=A9ment?= Lassieur , 25966@debbugs.gnu.org References: <20170304140932.30144-1-contact.ng0@cryptolab.net> <20170304140932.30144-2-contact.ng0@cryptolab.net> <87o9xfsq5d.fsf@lassieur.org> <20170314173906.GA9175@jasmine> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170314173906.GA9175@jasmine> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25966 Cc: 25966@debbugs.gnu.org, =?utf-8?Q?Cl=C3=A9ment?= Lassieur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Leo Famulari transcribed 2.8K bytes: > On Sun, Mar 05, 2017 at 04:24:14PM +0100, Clément Lassieur wrote: > > contact.ng0@cryptolab.net writes: > > > > > + (add-before 'install 'fix-hooks-shebangs > > > + (lambda* (#:key inputs #:allow-other-keys) > > > + (let ((perl (string-append (assoc-ref inputs "perl") > > > + "/bin/perl"))) > > > + ;; The files in 'lib/Gitolite/Hooks' keep references to > > > + ;; '/usr/bin/perl', without this fix it is impossible to > > > + ;; to run gitolite in production. > > > + (substitute* (find-files "src/lib/Gitolite/Hooks" ".*") > > > + (("/usr/bin/perl") > > > + perl)) > > > + #t))) > > > > This patch introduces references to the store in files installed by > > "gitolite setup" command. Those files are installed once and for all. > > So for example .gitolite/hooks/common/update's shebang is > > #!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. But > > then what happens when perl is upgraded, and Guix garbage collected? My > > understanding is that the shebang won't work anymore, and gitolite will > > be broken. > > > > One can use instead special-files-service-type, which allows to have > > /usr/bin/perl working. But it won't work anymore with this patch. > > Ah, seems like the same issue as with the Git hooks. > > > I suggest we revert it, but I might be wrong. WDYT? > > If these hooks are intended to be copied out of /gnu/store, then the > change should be reverted until we have a better solution. > > I think it's better for the hook scripts to fail the first time than for > them to fail later, after a seemingly unrelated action like `guix gc`. I agree. Please revert it. I'd like to continue this discussion to see what we can come up with. Thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 06:12:56 2017 Received: (at 25966) by debbugs.gnu.org; 16 Mar 2017 10:12:56 +0000 Received: from localhost ([127.0.0.1]:58102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coSOu-0007Hn-J3 for submit@debbugs.gnu.org; Thu, 16 Mar 2017 06:12:56 -0400 Received: from mail.lassieur.org ([83.152.10.219]:49532 helo=ron) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coSOs-0007He-HI for 25966@debbugs.gnu.org; Thu, 16 Mar 2017 06:12:55 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by ron (OpenSMTPD) with ESMTPSA id de17ac30 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Thu, 16 Mar 2017 10:12:52 +0000 (UTC) References: <20170304140932.30144-1-contact.ng0@cryptolab.net> <20170304140932.30144-2-contact.ng0@cryptolab.net> <87o9xfsq5d.fsf@lassieur.org> <20170314173906.GA9175@jasmine> User-agent: mu4e 0.9.18; emacs 25.2.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: Leo Famulari Subject: Re: bug#25966: [PATCH 2/2] gnu: gitolite: Fix shebangs in hooks. In-reply-to: <20170314173906.GA9175@jasmine> Date: Thu, 16 Mar 2017 11:12:51 +0100 Message-ID: <87ziglr0m4.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25966 Cc: 25966@debbugs.gnu.org, contact.ng0@cryptolab.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Leo Famulari writes: > On Sun, Mar 05, 2017 at 04:24:14PM +0100, Clément Lassieur wrote: >> contact.ng0@cryptolab.net writes: >> >> > + (add-before 'install 'fix-hooks-shebangs >> > + (lambda* (#:key inputs #:allow-other-keys) >> > + (let ((perl (string-append (assoc-ref inputs "perl") >> > + "/bin/perl"))) >> > + ;; The files in 'lib/Gitolite/Hooks' keep references to >> > + ;; '/usr/bin/perl', without this fix it is impossible to >> > + ;; to run gitolite in production. >> > + (substitute* (find-files "src/lib/Gitolite/Hooks" ".*") >> > + (("/usr/bin/perl") >> > + perl)) >> > + #t))) >> >> This patch introduces references to the store in files installed by >> "gitolite setup" command. Those files are installed once and for all. >> So for example .gitolite/hooks/common/update's shebang is >> #!/gnu/store/vcjvzmdy5091bklv73rx9nc0yvlk12yv-perl-5.24.0/bin/perl. But >> then what happens when perl is upgraded, and Guix garbage collected? My >> understanding is that the shebang won't work anymore, and gitolite will >> be broken. >> >> One can use instead special-files-service-type, which allows to have >> /usr/bin/perl working. But it won't work anymore with this patch. > > Ah, seems like the same issue as with the Git hooks. > >> I suggest we revert it, but I might be wrong. WDYT? > > If these hooks are intended to be copied out of /gnu/store, then the > change should be reverted until we have a better solution. > > I think it's better for the hook scripts to fail the first time than for > them to fail later, after a seemingly unrelated action like `guix gc`. I saw it was reverted. Thank you all! From unknown Fri Jun 20 19:57:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 13 Apr 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator