GNU bug report logs - #25957
gitolite broken: created repositories keep references to /usr/bin for hooks

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Thompson, David" <dthompson2 <at> worcester.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#25957: closed (gitolite broken: created repositories keep
 references to /usr/bin for hooks)
Date: Mon, 24 Oct 2022 21:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 24 Oct 2022 17:21:44 -0400
with message-id <CAJ=RwfZfRHz0Fx4hnzd5C9eQzjnvuWZDCM2EPnsznJgJTqqbZw <at> mail.gmail.com>
and subject line Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks
has caused the debbugs.gnu.org bug report #25957,
regarding gitolite broken: created repositories keep references to /usr/bin for hooks
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
25957: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25957
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ng0 <contact.ng0 <at> cryptolab.net>
To: bug-guix <at> gnu.org
Subject: gitolite broken: created repositories keep references to /usr/bin
 for hooks
Date: Fri, 3 Mar 2017 21:58:19 +0000

Our gitolite package currently creates all
(including gitolite-admin.git) git repositories with references to
"/usr/bin/perl" as shebang, which makes it completely useless on
serverside.
Given that the server side in the case of a gitolite from Guix runs an
environment where you will not run perl from /usr/bin/, you will have to
change all hooks manually currently.

When you install perl into the profile of the user which hosts the
repositories and change the shebangs, gitolite can be used.

[Message part 3 (message/rfc822, inline)]

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 25957-done <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>,
 25957 <at> debbugs.gnu.org
Subject: Re: bug#25957: gitolite broken: created repositories keep references
 to /usr/bin for hooks
Date: Mon, 24 Oct 2022 17:21:44 -0400

On Sat, Oct 8, 2022 at 9:40 PM Thompson, David <dthompson2 <at> worcester.edu> wrote:
>
> On Sat, Oct 8, 2022 at 11:16 AM zimoun <zimon.toutoune <at> gmail.com> wrote:
> >
> > Hi Dave,
> >
> > On Thu, 06 Oct 2022 at 09:26, "Thompson, David" <dthompson2 <at> worcester.edu> wrote:
> >
> > > Some news: I have updated the gitolite package to use G-expressions.
> > > The package builds and the gitolite system test passes so I pushed
> > > that change to master a little while ago.  That patch has made the
> > > (hopefully) final step in this saga easier. The attached patch
> > > introduces a 'make-gitolite' procedure that can be used to add
> > > arbitrary packages to the wrappers for the gitolite and gitolite-shell
> > > programs.  The return value of this procedure can be used in the
> > > gitolite service configuration to enable the desired optional features
> > > like Redis or git-annex.  The base package inputs are unchanged and
> > > the gitolite system test still passes.
> >
> > Thank you for working on this!  Neat.
> >
> > Well, your proposal LGTM although I do not see the difference between
> > ’make-gitolite’ and a simple ’inherent’ for building a package variant.
> > Yeah, this make-gitolite is probably more handy.
>
> The reason for the constructor is so that extra packages can be easily
> added to the gexp that calls wrap-program.  It would be much harder to
> modify the package in this way without a helper procedure.

Pushed as commit 966118da711506b04c11fbfcac9483d59ed2d912.  This bug
can finally be closed!

- Dave

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.