From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 15:49:52 2017 Received: (at submit) by debbugs.gnu.org; 3 Mar 2017 20:49:52 +0000 Received: from localhost ([127.0.0.1]:38849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cju9A-0002RB-EB for submit@debbugs.gnu.org; Fri, 03 Mar 2017 15:49:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cju98-0002Qy-UW for submit@debbugs.gnu.org; Fri, 03 Mar 2017 15:49:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cju92-0008AW-MP for submit@debbugs.gnu.org; Fri, 03 Mar 2017 15:49:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37862) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cju92-0008AO-JL for submit@debbugs.gnu.org; Fri, 03 Mar 2017 15:49:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cju91-0006X4-GX for bug-guix@gnu.org; Fri, 03 Mar 2017 15:49:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cju8w-00088l-ST for bug-guix@gnu.org; Fri, 03 Mar 2017 15:49:43 -0500 Received: from fragranza.investici.org ([178.175.144.26]:64476) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cju8w-00088B-G2 for bug-guix@gnu.org; Fri, 03 Mar 2017 15:49:38 -0500 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 219562C01FE for ; Fri, 3 Mar 2017 20:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488574173; bh=KF1Kl9ZvId1/W1+KAf8hAqqDRJmLUlkv1XzXF7PsufI=; h=Date:From:To:Subject; b=NSqFxDI980r36+6AJEpGNu330jfd12Vl09bc1UCFedMQGGDNGqvDUZriNV9FcfLmD 6WTOjS6cmyRsXZd8BHrmpRu6oQeXq7TXo6hdL/R7U7Vkka0JaRFXOGwficjybmGVnp gQjlx/ifDRed++/xxdirsmCfNqTuIuPSQeqN7/j4= Date: Fri, 3 Mar 2017 21:58:19 +0000 From: ng0 To: bug-guix@gnu.org Subject: gitolite broken: created repositories keep references to /usr/bin for hooks Message-ID: <20170303215819.bttmrfsbhlxyipmy@abyayala> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Our gitolite package currently creates all (including gitolite-admin.git) git repositories with references to "/usr/bin/perl" as shebang, which makes it completely useless on serverside. Given that the server side in the case of a gitolite from Guix runs an environment where you will not run perl from /usr/bin/, you will have to change all hooks manually currently. When you install perl into the profile of the user which hosts the repositories and change the shebangs, gitolite can be used. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 16:19:01 2017 Received: (at 25957) by debbugs.gnu.org; 3 Mar 2017 21:19:01 +0000 Received: from localhost ([127.0.0.1]:38859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjubN-00035y-42 for submit@debbugs.gnu.org; Fri, 03 Mar 2017 16:19:01 -0500 Received: from fragranza.investici.org ([178.175.144.26]:61652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjubL-00035m-74 for 25957@debbugs.gnu.org; Fri, 03 Mar 2017 16:18:59 -0500 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 6AA8D2C0198 for <25957@debbugs.gnu.org>; Fri, 3 Mar 2017 21:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488575937; bh=k6vSPHoxl0iAWO9RL+kAnrvrhFbxtZiCsob/QA2wqhA=; h=Date:From:To:Subject:References:In-Reply-To; b=uG/m0ByCoDU+j9ZUuLnxvtY5xImMPygqYIvH8unhk6Q2HBiz9jKgLYvBQPkuahRGx j/HqPg79iW0ycUKMf+rXjG9McQMZKYrNocHgCoKJzqSRKwHl1A0PWqlsKUFWpzn6CG DVe9hNWACXJG5Axghbq2OY9HuD268afsQwZ66jPE= Date: Fri, 3 Mar 2017 22:27:43 +0000 From: ng0 To: 25957@debbugs.gnu.org Subject: Re: bug#25957: Acknowledgement (gitolite broken: created repositories keep references to /usr/bin for hooks) Message-ID: <20170303222743.wf777eedaauuof3f@abyayala> Mail-Followup-To: 25957@debbugs.gnu.org References: <20170303215819.bttmrfsbhlxyipmy@abyayala> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) What makes this worse, with every update (push) of gitolite-admin repository the shebang of "hooks/update" is reset. Other repositories seem to keep changes in the hooks shebangs so far. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 07:24:08 2017 Received: (at 25957) by debbugs.gnu.org; 4 Mar 2017 12:24:08 +0000 Received: from localhost ([127.0.0.1]:39220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck8jH-00064h-Uv for submit@debbugs.gnu.org; Sat, 04 Mar 2017 07:24:08 -0500 Received: from perdizione.investici.org ([94.23.50.208]:51753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck8jG-00064Z-4e for 25957@debbugs.gnu.org; Sat, 04 Mar 2017 07:24:06 -0500 Received: from [94.23.50.208] (perdizione [94.23.50.208]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id C474B12115B for <25957@debbugs.gnu.org>; Sat, 4 Mar 2017 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488630245; bh=LN3FqxqM3RRqOuSMzS7h/iQUOUEFeAHdRNCc9TGdbyQ=; h=Date:From:To:Subject:References:In-Reply-To; b=iDW/6LkM5TyZNw3WHrSQLlFtpFwrG9pNfQgH9Xlk02DT4IM16SHrrf7a4U2FcMd2c M+yRa4TrDfJg5NXe6Wv3cUX5NWQmU79nyxTr50xwkQ7b/NfBpgd9fm+avtvzDr3Oc/ kCVHCYvtMZZSg0TVwfp/bRfItWwtEiCzzJZqmro4= Date: Sat, 4 Mar 2017 13:32:42 +0000 From: ng0 To: 25957@debbugs.gnu.org Subject: Re: bug#25957: Acknowledgement (gitolite broken: created repositories keep references to /usr/bin for hooks) Message-ID: <20170304133242.towlmzdcm6x43hvi@abyayala> Mail-Followup-To: 25957@debbugs.gnu.org References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170303222743.wf777eedaauuof3f@abyayala> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 17-03-03 22:27:43, ng0 wrote: > What makes this worse, with every update (push) of gitolite-admin > repository the shebang of "hooks/update" is reset. > Other repositories seem to keep changes in the hooks shebangs so > far. > > > When I build gitolite from guix, this looks trivial to fix. [user@abyayala /gnu/store/jw252kw9blfh1lrrib3yk4fkbj5mvdpm-gitolite-3.6.5/share/gitolite]$ egrep -nr "/usr/" commands/svnserve:9:$svnserve ||= "/usr/bin/svnserve -r /var/svn/ -t --tunnel-user=%u"; lib/Gitolite/Test/Tsh.pm:42:# path when cwd is [...] at /usr/share/perl5/File/Temp.pm line 902". lib/Gitolite/Hooks/PostUpdate.pm:62:#!/usr/bin/perl lib/Gitolite/Hooks/Update.pm:158:#!/usr/bin/perl lib/Gitolite/Cache.pm:127: open( REDIS, "|-", "/usr/sbin/redis-server", "-" ) or die "start redis server fail ed: $!"; The parts I want to fix as my immediately affect every user, are in the directory "lib/Gitolite/Hooks/", I have no idea about redis, but I think there should be a reference to /gnu/store/ reddis and not "/usr/sbin/redis-server". Different problem, related bug.. This can be solved in a commit after this bug. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 10:43:15 2017 Received: (at 25957) by debbugs.gnu.org; 4 Mar 2017 15:43:15 +0000 Received: from localhost ([127.0.0.1]:40170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckBpz-0007oV-Fb for submit@debbugs.gnu.org; Sat, 04 Mar 2017 10:43:15 -0500 Received: from dd1012.kasserver.com ([85.13.128.8]:56742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckBpx-0007oN-QR for 25957@debbugs.gnu.org; Sat, 04 Mar 2017 10:43:14 -0500 Received: from localhost (77.118.173.103.wireless.dyn.drei.com [77.118.173.103]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 80FE61CA00B1; Sat, 4 Mar 2017 16:43:10 +0100 (CET) Date: Sat, 4 Mar 2017 16:43:09 +0100 From: Danny Milosavljevic To: ng0 Subject: Re: bug#25957: Acknowledgement (gitolite broken: created repositories keep references to /usr/bin for hooks) Message-ID: <20170304164309.08e43b4c@scratchpost.org> In-Reply-To: <20170304133242.towlmzdcm6x43hvi@abyayala> References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi ng0, > I think there should be a reference to /gnu/store/ reddis and not > "/usr/sbin/redis-server". Different problem, related bug.. This can be > solved in a commit after this bug. Yeah. I would question why a normal application needs to start a redis *server* in the first place. Sounds strange to me. But I agree that if it wants to do that it should use a store reference. says "Redis is designed to be a very long running process in your server" so that definitely reads to me that a normal program shouldn't just start redis-server when it feels like it (and I hope it stops it again later? After reading the source code it doesn't appear that way...). says "WARNING: this has not been tested in a while. YMMV". Uhhhh. Not confidence-inspiring. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 11:25:09 2017 Received: (at 25957) by debbugs.gnu.org; 4 Mar 2017 16:25:09 +0000 Received: from localhost ([127.0.0.1]:40198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckCUX-0000PO-Dp for submit@debbugs.gnu.org; Sat, 04 Mar 2017 11:25:09 -0500 Received: from fragranza.investici.org ([178.175.144.26]:34816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckCUU-0000PF-Uz for 25957@debbugs.gnu.org; Sat, 04 Mar 2017 11:25:07 -0500 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 398DF2C0100; Sat, 4 Mar 2017 16:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1488644705; bh=mfqYYF1Hhn2h1JPkA6jsxjMTwoUonvbP4GmL0gUh7PM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Afh6k/VYa246EDvaRmXFLlmhX+J1XSo2ezCp8FTPTBaW4vSSFplHRww0/1QooUBG2 gib8ZCkV90qP1nVZAjc185+5gJ1SXtRk11hJPgdEdCnmA5bTVDQ/lRyfSxIvj/UFRQ Jv9rvYLPcJXQbvH5UmoBJ5Rt0Ew6SP1pAdwOizBQ= Date: Sat, 4 Mar 2017 17:33:39 +0000 From: ng0 To: Danny Milosavljevic Subject: Re: bug#25957: Acknowledgement (gitolite broken: created repositories keep references to /usr/bin for hooks) Message-ID: <20170304173339.ubumkmfdfrkbascj@abyayala> Mail-Followup-To: Danny Milosavljevic , 25957@debbugs.gnu.org References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <20170304164309.08e43b4c@scratchpost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170304164309.08e43b4c@scratchpost.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 17-03-04 16:43:09, Danny Milosavljevic wrote: > Hi ng0, > > > I think there should be a reference to /gnu/store/ reddis and not > > "/usr/sbin/redis-server". Different problem, related bug.. This can be > > solved in a commit after this bug. > > Yeah. > > I would question why a normal application needs to start a redis *server* in the first place. Sounds strange to me. But I agree that if it wants to do that it should use a store reference. > > says "Redis is designed to be a very long running process in your server" so that definitely reads to me that a normal program shouldn't just start redis-server when it feels like it (and I hope it stops it again later? After reading the source code it doesn't appear that way...). > > says "WARNING: this has not been tested in a while. YMMV". Uhhhh. Not confidence-inspiring. It was the first time I read about reddis in gitolite context, and in all the time I used gitolite I never really needed it when building or running. I disregard this as not very important and not really important at all to fix. It should be fixed in the long run, but my main concern was usability of gitolite, which has been addressed in one of the two patches I've sent. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 04 19:14:41 2022 Received: (at 25957) by debbugs.gnu.org; 5 Jan 2022 00:14:41 +0000 Received: from localhost ([127.0.0.1]:39165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4twu-0008Cc-OY for submit@debbugs.gnu.org; Tue, 04 Jan 2022 19:14:41 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:40741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4twr-0008CI-GD for 25957@debbugs.gnu.org; Tue, 04 Jan 2022 19:14:39 -0500 Received: by mail-wr1-f52.google.com with SMTP id q16so79388005wrg.7 for <25957@debbugs.gnu.org>; Tue, 04 Jan 2022 16:14:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-transfer-encoding; bh=KykoRBFlRgOlzQ2oL8Aoev9+AcUuntRCL1tHps8B4dQ=; b=M6YeBkdSRRlbgVS8jwL9y4ez5r5x0blVS14k1f9JUWxIn9YMrzGAtUoOKL6grJVrqv YPSPzekE3paqJeuvYboFs4JIE9hhNoLWlE73CCy299rJ4ibnRJgZ0EPId7IYsxdmp0Z3 bpmMiThFhzjJS6wJi+VnOYmh7+9xwzu27VvsFkxTPRMwH3NrKUd+ZFQwfhd2T5RHwm6z HtI1ZFyFRwkhqylxmgnVeteinoYo5U+FuBiVHuTt2LQ9q2GH485E86bu6G2+nZ5t0E6P a0LvI5P9YXZ/PMyhXSEFJn4hTR1XmeoDxynBOWUQhOMQaWvobZNhng4APL27EiZHZKk4 LDKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=KykoRBFlRgOlzQ2oL8Aoev9+AcUuntRCL1tHps8B4dQ=; b=Wp9RTIf74RYEEOQukTKHdrQmeKKqfdxK+u3UPK72Od1uHvvGrp20Jad0BkCdzxoh7i fYgeEHZo451fNmmTvIhdB5v/QM7gCWgZYJsTZjfjhg6jOSXlFhDU90MBBN9lTsM5rmRd iJcF5uV8rbGA8dLzyPUzahP2BTsAFlJmaerTHsO6ah7EwKNxm4GSCPQ1oWpXThMkXuKu kKI6+PfKBPCmVNnwMHwtrOmFMIKSrGaMBfvlOlb2St9DlAjhA752vwHdWXXhThgKPnFL uPQGlEeB4sNrNiL5fnrSqUueyk6WUPcUtBSr24d4fYRxmghPrAfxDMagWThMkArEsPcS /EcA== X-Gm-Message-State: AOAM532xf6S0IVA2wcndeREafZ1ePjSjLakQAhI8YNIUW6aZ0oHYUSGB V/TtF++kLXIAVu4+E/ec9KLK0fy8BlM= X-Google-Smtp-Source: ABdhPJyJYRwlarQqwuKKK4ZUVG5PENG2+uXhSc20d09J67JbNHAv5FSaFVPJWwDcT8b4Ve2TsicU5g== X-Received: by 2002:a5d:6d06:: with SMTP id e6mr43823353wrq.273.1641341671441; Tue, 04 Jan 2022 16:14:31 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id ba18sm3015843wrb.40.2022.01.04.16.14.30 for <25957@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 16:14:31 -0800 (PST) From: zimoun To: 25957@debbugs.gnu.org Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> Date: Wed, 05 Jan 2022 01:07:07 +0100 In-Reply-To: <20170304133242.towlmzdcm6x43hvi@abyayala> (ng0's message of "Sat, 4 Mar 2017 13:32:42 +0000") Message-ID: <86k0ff9has.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, This old bug [1] is still relevant. 1: On Sat, 04 Mar 2017 at 13:32, ng0 wrote: > On 17-03-03 22:27:43, ng0 wrote: This previous=E2=80=A6 > [user@abyayala /gnu/store/jw252kw9blfh1lrrib3yk4fkbj5mvdpm-gitolite-3.6.5= /share/gitolite]$ egrep -nr "/usr/" > commands/svnserve:9:$svnserve ||=3D "/usr/bin/svnserve -r /var/svn/ -t --= tunnel-user=3D%u"; > lib/Gitolite/Test/Tsh.pm:42:# path when cwd is [...] at /usr/share/perl5/= File/Temp.pm line 902". > lib/Gitolite/Hooks/PostUpdate.pm:62:#!/usr/bin/perl > lib/Gitolite/Hooks/Update.pm:158:#!/usr/bin/perl > lib/Gitolite/Cache.pm:127: open( REDIS, "|-", "/usr/sbin/redis-server"= , "-" ) or die "start redis server fail > ed: $!"; =E2=80=A6is now=E2=80=A6 --8<---------------cut here---------------start------------->8--- share/gitolite/lib/Gitolite/Test/Tsh.pm:42:# path when cwd is [...] at /usr= /share/perl5/File/Temp.pm line 902". share/gitolite/lib/Gitolite/Cache.pm:127: open( REDIS, "|-", "/usr/sbin/= redis-server", "-" ) or die "start redis server failed: $!"; share/gitolite/commands/svnserve:9:$svnserve ||=3D "/usr/bin/svnserve -r /v= ar/svn/ -t --tunnel-user=3D%u"; --8<---------------cut here---------------end--------------->8--- =E2=80=A6but=E2=80=A6 > The parts I want to fix as my immediately affect every user, are in > the directory "lib/Gitolite/Hooks/", I have no idea about redis, but > I think there should be a reference to /gnu/store/ reddis and not > "/usr/sbin/redis-server". Different problem, related bug.. This can be > solved in a commit after this bug. =E2=80=A6the package redis is not a dependency of gitolite. Therefore, the question is: is our Gitolite package working with Redis? Even using the /usr/bin one? Idem for SVN. Otherwise, I am favor to remove the 2 =E2=80=9Cproblematic=E2=80=9D referen= ces. WDYT? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 12 13:08:20 2022 Received: (at 25957) by debbugs.gnu.org; 12 Jan 2022 18:08:20 +0000 Received: from localhost ([127.0.0.1]:59046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7i2l-0007pg-Tq for submit@debbugs.gnu.org; Wed, 12 Jan 2022 13:08:20 -0500 Received: from flashner.co.il ([178.62.234.194]:43228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7i2h-0007pK-70 for 25957@debbugs.gnu.org; Wed, 12 Jan 2022 13:08:18 -0500 Received: from localhost (unknown [141.226.10.247]) by flashner.co.il (Postfix) with ESMTPSA id 499654013B; Wed, 12 Jan 2022 18:08:09 +0000 (UTC) Date: Wed, 12 Jan 2022 20:07:37 +0200 From: Efraim Flashner To: zimoun Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Message-ID: Mail-Followup-To: Efraim Flashner , zimoun , 25957@debbugs.gnu.org References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+tUEcTHzo1qyejda" Content-Disposition: inline In-Reply-To: <86k0ff9has.fsf_-_@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --+tUEcTHzo1qyejda Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 05, 2022 at 01:07:07AM +0100, zimoun wrote: > Hi, >=20 > This old bug [1] is still relevant. >=20 > 1: >=20 > On Sat, 04 Mar 2017 at 13:32, ng0 wrote: > > On 17-03-03 22:27:43, ng0 wrote: >=20 > This previous=E2=80=A6 >=20 > > [user@abyayala /gnu/store/jw252kw9blfh1lrrib3yk4fkbj5mvdpm-gitolite-3.6= =2E5/share/gitolite]$ egrep -nr "/usr/" > > commands/svnserve:9:$svnserve ||=3D "/usr/bin/svnserve -r /var/svn/ -t = --tunnel-user=3D%u"; > > lib/Gitolite/Test/Tsh.pm:42:# path when cwd is [...] at /usr/share/perl= 5/File/Temp.pm line 902". > > lib/Gitolite/Hooks/PostUpdate.pm:62:#!/usr/bin/perl > > lib/Gitolite/Hooks/Update.pm:158:#!/usr/bin/perl > > lib/Gitolite/Cache.pm:127: open( REDIS, "|-", "/usr/sbin/redis-serve= r", "-" ) or die "start redis server fail > > ed: $!"; >=20 > =E2=80=A6is now=E2=80=A6 >=20 > --8<---------------cut here---------------start------------->8--- > share/gitolite/lib/Gitolite/Test/Tsh.pm:42:# path when cwd is [...] at /u= sr/share/perl5/File/Temp.pm line 902". > share/gitolite/lib/Gitolite/Cache.pm:127: open( REDIS, "|-", "/usr/sbi= n/redis-server", "-" ) or die "start redis server failed: $!"; > share/gitolite/commands/svnserve:9:$svnserve ||=3D "/usr/bin/svnserve -r = /var/svn/ -t --tunnel-user=3D%u"; > --8<---------------cut here---------------end--------------->8--- >=20 > =E2=80=A6but=E2=80=A6 >=20 > > The parts I want to fix as my immediately affect every user, are in > > the directory "lib/Gitolite/Hooks/", I have no idea about redis, but > > I think there should be a reference to /gnu/store/ reddis and not > > "/usr/sbin/redis-server". Different problem, related bug.. This can be > > solved in a commit after this bug. >=20 > =E2=80=A6the package redis is not a dependency of gitolite. Therefore, t= he > question is: is our Gitolite package working with Redis? Even using the > /usr/bin one? Idem for SVN. >=20 > Otherwise, I am favor to remove the 2 =E2=80=9Cproblematic=E2=80=9D refer= ences. WDYT? Or change it to search the $PATH for the binary, so it would just be 'redis-server' or 'svnserve' --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --+tUEcTHzo1qyejda Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmHfGOgACgkQQarn3Mo9 g1H5RQ//UJ90vtM+nXuz+3mhuFap57Df4c1llA3rHCpg9OI/o4ZgBdqF1pO8Shcp iy8S/MVOsfpOzTC3Xu88wA5Z03sEmEGRNTPnZKi1dEng5SYIczy9BIsQcxhL/xuy XEJg7FuFWLX2N1beREWlAAcWyB12mu2I0AeRS+5yqY4AClUeHdJ+iR8kN1BrOTy/ 1hTeGJDPNbxMqDAfdLtWcdX4G4PRhpfykAOyGZmj6DrFNczgs+RB/vCMWTAoEKcx uuvinG/WFohduA4hbtgczQPbJ3P1cgQQl5o/1qUdgzWOK6bD9EUXhUhiQFpRyDXg lu0pnGTRXJ+Ac6yp7/N5oRPiSqJY8bR43FSbjr6dSuXTt71HXzL0bDtjroOLdHi7 S/72adidesoXFtYiGUnMu2vGYrr3mDEUHRqMiccbNifaPthJwSpI1vbTe5pHUWw5 sT0s48DXCy7MDqHZ4gEpVpk8NFBBxMCVAPHERxSQihg45ca6DnIptwGSilntm0Xz zI474GcJi2XdD1pQgJ3QsS40G1/RlgfEjgGgd/Y+gILDFS2BQKI4LjmTvNwVVn4B ONjL1tvwAabnKnmeDgEQSvQz1IedgJVdSqPCIts/0qMAkFASygzS14TL171lzfCR GoLH1rjcBujj0iF683SGET38r30kGqsnCo34vjhSAxeFoal2zO0= =caCW -----END PGP SIGNATURE----- --+tUEcTHzo1qyejda-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 02 21:51:02 2022 Received: (at 25957) by debbugs.gnu.org; 3 Feb 2022 02:51:02 +0000 Received: from localhost ([127.0.0.1]:54077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFSD7-00011r-Kx for submit@debbugs.gnu.org; Wed, 02 Feb 2022 21:51:01 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:52194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFSD5-00011A-TV for 25957@debbugs.gnu.org; Wed, 02 Feb 2022 21:51:00 -0500 Received: by mail-wm1-f42.google.com with SMTP id i132so829773wma.1 for <25957@debbugs.gnu.org>; Wed, 02 Feb 2022 18:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=1SDGJW+zYPWPn63MXWjtzEvIUzOuPaGq3cZF0aypCpg=; b=hVB3U4th5M94xNQysYhleyM+cnLPv6ejX6F5a1xsHyJUIYIY68DLlyT6/UynfVpxZD Y8ZiClwFi4afP5KpRSnuWKddSYJ7jPQ45IZ0KLCcxmGwNsvJ+9gMcg0MWMEZP8exFzFN KKVzxeVYepcNCjuwRja2xN3+mJ9SnYl/RDHXS9wcgSEF5wASMBUiyMZSLZD6UNoSSeOm lQuPpuZbUQY1HQm0P247PPx+mJBNSeCQaHchF4nuoTR2NVMA23utdBFaaq8B68pzw2Pf 4v35SObH/3zfZQtmIWnuqPzayUJaRJHcDxwoRx+W+A+863MluCNQNaC7/buhUkhIHtO/ 34qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=1SDGJW+zYPWPn63MXWjtzEvIUzOuPaGq3cZF0aypCpg=; b=OQXhxUvXUkK1e1cwFrWMrfiN4HP0WMf0hE56mo9DrBVQFOIb4K3DQ+GfUQ3/oxiNkz f76xc+1OOKJ6s07RcIHNQBoERrpLtH/d+2cFcpkvGEpgPmGdBKBUpVH6n0RhWve4W2YP JKJ8izEwdWAbrJIxNpI/U4Wm+9gsxe8Vt0Q72G6HumDwrCqwBMbD4cY2I9ko2LNdEdka 5HpioBdhQV/U1WdtvINVrvIdJr57mifRPZ+PKmaVVMYiekUgxiGmxy3tFUA9a9yHgcn7 gula2S5JichcP8aP5X7WWYTouxgj/NN2WpvEyiJiH+uyg6n7ecWVFjV9+v9zAxj7zoXZ xcvA== X-Gm-Message-State: AOAM531BMf5IrwPWkhwwzz6nfPZ/NpNNqaSytCCvbtweGALqr9akgqu2 T7beVFs0UeDFPW/dU46WZukjNyyO43g= X-Google-Smtp-Source: ABdhPJzfucXDhEwj02dJHsu/ZZavAIc7Ow8LOJva8AKfRerc4wBQYMLCEN3SMULlcIw2ZvmZcUYoeA== X-Received: by 2002:a05:600c:3b91:: with SMTP id n17mr8491762wms.116.1643856654137; Wed, 02 Feb 2022 18:50:54 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id u17sm6563971wmq.41.2022.02.02.18.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 18:50:53 -0800 (PST) From: zimoun To: Efraim Flashner Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> Date: Thu, 03 Feb 2022 03:49:13 +0100 In-Reply-To: (Efraim Flashner's message of "Wed, 12 Jan 2022 20:07:37 +0200") Message-ID: <8635l01x7a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Efraim, On Wed, 12 Jan 2022 at 20:07, Efraim Flashner wrote: >> =E2=80=A6the package redis is not a dependency of gitolite. Therefore, = the >> question is: is our Gitolite package working with Redis? Even using the >> /usr/bin one? Idem for SVN. >> >> Otherwise, I am favor to remove the 2 =E2=80=9Cproblematic=E2=80=9D refe= rences. WDYT? > > Or change it to search the $PATH for the binary, so it would just be > 'redis-server' or 'svnserve' Is our Gitolite package working with Redis? If not, why try to fix. ;-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 06:51:49 2022 Received: (at 25957) by debbugs.gnu.org; 23 Mar 2022 10:51:50 +0000 Received: from localhost ([127.0.0.1]:42872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWyaj-0007gw-JD for submit@debbugs.gnu.org; Wed, 23 Mar 2022 06:51:49 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:33148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWyag-0007gK-Fj for 25957@debbugs.gnu.org; Wed, 23 Mar 2022 06:51:46 -0400 Received: by mail-wm1-f52.google.com with SMTP id o7-20020a05600c4fc700b0038c87edc21eso3107339wmq.0 for <25957@debbugs.gnu.org>; Wed, 23 Mar 2022 03:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=f8LWbvG0kAiZpk6FXX+s5wrIs2HnfZA396FWczXUnm8=; b=pBPUmx+V3Moal6xZqHZGWLFKAn89ey2xI1bckzafJAIlxIhcmJJLf7P/PFMs0xqhW/ JbYRfWsEBZgrhI7aleDtfqgHgIOzPOgyTJ83UaNRNnCke0i3/obhkFYxwtWjySq7Kdjs 0bh8eleavhW22qX7uZGxdZbLxFv43hYQRaIOCU4TRhSlM2XtVGHyX6MLkVwcTqiXupPZ 1JrPDUGTEp4llDoBuFk8z4kKy+2J9h4qgfN4XTOer1lILCVxN9Ao7IhOeFNxkna6x7NV 2PWptbzliruFeWi+VDmjMWRQkKpmq2nKjT1uV4ccJnS6t9lkyJ7anv62nwLeviAKizPH obXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=f8LWbvG0kAiZpk6FXX+s5wrIs2HnfZA396FWczXUnm8=; b=StvHq5uYrA4OoA+SC0woHLjB/+T4ZKXzAF+Z/a2+aWkeL5LY95t4CTAZHqKYMSLLrI 1q1E41OpvRldIcrwSIC/LOLBwiI5Docppel2VQpSS5kDebjQUVeEpk/1iz4VC3ialT8z sIQ8UqZdF01hGk07UjMX6BV9NuBh8FeoOK2fyiKpZjD2Cm58k5uC0jlFViWIJM278crZ ZPojGMJdlWsM2W2fphffeG8MnZ44LZsfx7jDjXDicz9F1JQBzRpKfwSdw89LMH30Bokp SdK9icOqRkuI9SYN/WiiDAQUMm41m6eSeS/wOGXMBCoN+8ujuPtSTxkS43slGUuaLbYu XoRQ== X-Gm-Message-State: AOAM533C2+7Mxfy4en8IkcyEyr8Bf6jREAej6V4AySzkX5br5iy6eLZ5 vLbNiwPDuiJFZtbk9sP1xViN2cR+lCy9hg== X-Google-Smtp-Source: ABdhPJxAbrpe19KQn9OdndN56Usct+qb61Zq5DOMQ/YwS5PR8S/JfIaw4e7szrVIqgGlH1mA40jI8w== X-Received: by 2002:a05:600c:5024:b0:38c:a426:8ea6 with SMTP id n36-20020a05600c502400b0038ca4268ea6mr8618288wmr.193.1648032700657; Wed, 23 Mar 2022 03:51:40 -0700 (PDT) Received: from lili (client-eduroam632.canalip.upmc.fr. [134.157.122.122]) by smtp.gmail.com with ESMTPSA id g10-20020adfe40a000000b00203eb3551f0sm20696385wrm.117.2022.03.23.03.51.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 03:51:40 -0700 (PDT) From: zimoun To: Efraim Flashner Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> Date: Wed, 23 Mar 2022 11:45:56 +0100 In-Reply-To: <8635l01x7a.fsf@gmail.com> (zimoun's message of "Thu, 03 Feb 2022 03:49:13 +0100") Message-ID: <86lex10wwr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Thu, 03 Feb 2022 at 03:49, zimoun wrote: > On Wed, 12 Jan 2022 at 20:07, Efraim Flashner wro= te: > >>> =E2=80=A6the package redis is not a dependency of gitolite. Therefore,= the >>> question is: is our Gitolite package working with Redis? Even using the >>> /usr/bin one? Idem for SVN. >>> >>> Otherwise, I am favor to remove the 2 =E2=80=9Cproblematic=E2=80=9D ref= erences. WDYT? >> >> Or change it to search the $PATH for the binary, so it would just be >> 'redis-server' or 'svnserve' > > Is our Gitolite package working with Redis? If not, why try to fix. ;-) What is the status of this old bug [1]? Is it actionable? If yes, what is the action? If no, let close it. :-) WDYT? 1: Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 23 08:44:34 2022 Received: (at 25957) by debbugs.gnu.org; 23 Mar 2022 12:44:34 +0000 Received: from localhost ([127.0.0.1]:43028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX0Lq-0006fa-4y for submit@debbugs.gnu.org; Wed, 23 Mar 2022 08:44:34 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:51168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX0Lp-0006fT-53 for 25957@debbugs.gnu.org; Wed, 23 Mar 2022 08:44:33 -0400 Received: from [IPv6:2a02:2c40:200:b001::1:66ec] ([IPv6:2a02:2c40:200:b001::1:66ec]) by baptiste.telenet-ops.be with bizsmtp id 9okW2700648ECPd01okX3p; Wed, 23 Mar 2022 13:44:31 +0100 Message-ID: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks From: Maxime Devos To: zimoun , Efraim Flashner Date: Wed, 23 Mar 2022 13:44:29 +0100 In-Reply-To: <86lex10wwr.fsf@gmail.com> References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-anTmt5byQRsYcRXFgng6" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1648039471; bh=vqiiXIecM1A/rI43aGnJRNNgPNgwjeI41kY3w0rnEcw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=XVKRuPYHA8f80tFDKab/bHdV9+qc+G2A2mGZ9h9PiTSMl82flCfazy9hQBQtVJx+n 05bUyk/97qHsEva6158DYBInsVaoWvVk1XgVWZ6ausUjIAITANeJ9Sqg7ksAv/R/R5 ofrcOoC0lPyTZRpPvPfJ+YutrXr9y4NnBFyhAumWf+kJsQgHLx0RmOe9TVykmjdojM HtIeI5zk7VWXCWSDKx0jMj02LI4mEhGW5uzlnziLMDGhfqnj5gUxjtELNdcF/HuPsz ay0M4tRTLufSG6jkB6TWdvODwtxx9fnT27NkywUyNtI7vWhES5V9jPEDB37ZqOIWyh EB63+WZqIPTyQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-anTmt5byQRsYcRXFgng6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable zimoun schreef op wo 23-03-2022 om 11:45 [+0100]: > > On Wed, 12 Jan 2022 at 20:07, Efraim Flashner > > wrote: > >=20 > > > > =E2=80=A6the package redis is not a dependency of gitolite.=C2=A0 T= herefore, > > > > the > > > > question is: is our Gitolite package working with Redis?=C2=A0 Even > > > > using the > > > > /usr/bin one?=C2=A0 Idem for SVN. > > > >=20 > > > > Otherwise, I am favor to remove the 2 =E2=80=9Cproblematic=E2=80=9D > > > > references.=C2=A0=C2=A0 WDYT? > > >=20 > > > Or change it to search the $PATH for the binary, so it would just > > > be > > > 'redis-server' or 'svnserve' > >=20 > > Is our Gitolite package working with Redis?=C2=A0 If not, why try to > > fix. ;-) >=20 > What is the status of this old bug [1]?=C2=A0 Is it actionable?=C2=A0 If = yes, > what > is the action?=C2=A0 If no, let close it. :-)=C2=A0 WDYT? Seems like all we have to do is 'substitute*' a '/usr/bin/svnserve' into a '/gnu/store/...' (untested), so seems actionable to me. Alternatively, as Efraim wrote, let it search the $PATH (that might be useful if adding svnserve would increase the closure too much and it is an optional dependency in practice?). Greetings, Maxime. --=-anTmt5byQRsYcRXFgng6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjsWLRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7i9eAQC7udOOdgxpn6huFy0Pq6TulGQr rM8xLyTjPS/y6olwAgEAvrKQqgpEJv4qd5J0k59AI3N34xLGk68jzBMn2eQrMQg= =JfJY -----END PGP SIGNATURE----- --=-anTmt5byQRsYcRXFgng6-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 28 02:50:12 2022 Received: (at 25957) by debbugs.gnu.org; 28 Mar 2022 06:50:12 +0000 Received: from localhost ([127.0.0.1]:57010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYjCe-0003am-Jq for submit@debbugs.gnu.org; Mon, 28 Mar 2022 02:50:12 -0400 Received: from flashner.co.il ([178.62.234.194]:51016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYjCd-0003aX-05 for 25957@debbugs.gnu.org; Mon, 28 Mar 2022 02:50:11 -0400 Received: from localhost (unknown [5.102.239.82]) by flashner.co.il (Postfix) with ESMTPSA id A74AC40D0D; Mon, 28 Mar 2022 06:50:02 +0000 (UTC) Date: Mon, 28 Mar 2022 09:49:29 +0300 From: Efraim Flashner To: Maxime Devos Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Message-ID: Mail-Followup-To: Efraim Flashner , Maxime Devos , zimoun , 25957@debbugs.gnu.org References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TzPdF/YzzWOLJluu" Content-Disposition: inline In-Reply-To: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --TzPdF/YzzWOLJluu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 23, 2022 at 01:44:29PM +0100, Maxime Devos wrote: > zimoun schreef op wo 23-03-2022 om 11:45 [+0100]: > > > On Wed, 12 Jan 2022 at 20:07, Efraim Flashner > > > wrote: > > >=20 > > > > > =E2=80=A6the package redis is not a dependency of gitolite.=C2=A0= Therefore, > > > > > the > > > > > question is: is our Gitolite package working with Redis?=C2=A0 Ev= en > > > > > using the > > > > > /usr/bin one?=C2=A0 Idem for SVN. > > > > >=20 > > > > > Otherwise, I am favor to remove the 2 =E2=80=9Cproblematic=E2=80= =9D > > > > > references.=C2=A0=C2=A0 WDYT? > > > >=20 > > > > Or change it to search the $PATH for the binary, so it would just > > > > be > > > > 'redis-server' or 'svnserve' > > >=20 > > > Is our Gitolite package working with Redis?=C2=A0 If not, why try to > > > fix. ;-) > >=20 > > What is the status of this old bug [1]?=C2=A0 Is it actionable?=C2=A0 I= f yes, > > what > > is the action?=C2=A0 If no, let close it. :-)=C2=A0 WDYT? >=20 > Seems like all we have to do is 'substitute*' a '/usr/bin/svnserve' > into a '/gnu/store/...' (untested), so seems actionable to me. > Alternatively, as Efraim wrote, let it search the $PATH (that might be > useful if adding svnserve would increase the closure too much and it is > an optional dependency in practice?). I spent some time looking at gitolite and the service. As I understand it, with the exception of svnserve, it searches $PATH for a number of different binaries, including git-annex. I believe that this would only work if git-annex (and potentially other packages) are installed globally. In addition, git (not git-minimal) and openssh are propagated inputs AND wrapped. I haven't tested to see if wrapping only is enough. I think the best choice is to: A: Replace /usr/bin/svnserve with svnserve so it will just search $PATH, like it does with the other helpers. B: Adjust the service so that it automatically creates a variant (or just a wrapped version) of the package which is wrapped with a list of additional packages so that they can be in gitolite's path. If I were deploying this to an arm device I wouldn't want it wrapped with git-annex since it doesn't build, but would definitely want it for an x86_64 machine. I suppose we should try to find someone who is using the gitolite service and see if they can be our test subject for wrapping the package with optional addons. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --TzPdF/YzzWOLJluu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmJBWnIACgkQQarn3Mo9 g1F36A//TNGr5K6tptHG5aR4e6/StBJM5qrUJb/ldVQZ8yr0LpHQZF+PgHsdOX3S /thtlEwQuqVTnaBptF+9w8R35IowpDc1fwwQgy5zgKpFdH1r90ufFaNFm2YJ6Pep dLxpRyr3hxc3bOk6/B7cEfyBbD2A56qh4pLcGUrSbmfOH1VYZDKWNonBz1zZd4PC oyViPxFLWdXxblaSLo2CCxfKcsM0jmBV7VHgfOYaTrSvr+UStiKLf1Doib4Hfz2V ZnPq2oTv+tTr4gI7dSF5eOu4UtK45KcFLwuPWDNBw3s9dDeGcZ8ly6snbPFRhevU mAHo7rqkn1rpQLxAUYSZv35eZnpj2953TtekdCacHtrw+I9AhhBNwLhWJg3FF5By KkG9jbLp1d64UdTDCrxCte5XacS3mailiW0Oh2wzr/R5W42CntrVGPK1PSduyCe1 EzbkdnGd3lLpmk6IDhTrjh6vGq07QdsyH+i9vfEsTboM2sbAUeT4IQagYAYL4Q0H WFatKL4I00BUYI/cGfaxIO6Cc1566CI4YNkTCGf0Y6nOKMMjllZdOGXsQ3D/cm3T nyBDsIZc2PPSkC63CN9KNz3XWFiRqw4i9pmLe0KLTOsL8i+goYkSYxkWlI8rdqad HP75zsuJ8+uK/06SpwPRbodCr1CzGzMtCnXZjFhFAdL8K3zIF90= =KBfr -----END PGP SIGNATURE----- --TzPdF/YzzWOLJluu-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 10:00:15 2022 Received: (at 25957) by debbugs.gnu.org; 1 Sep 2022 14:00:15 +0000 Received: from localhost ([127.0.0.1]:43777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTkju-0002WO-Lg for submit@debbugs.gnu.org; Thu, 01 Sep 2022 10:00:15 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:45801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTkjs-0002W7-Mx for 25957@debbugs.gnu.org; Thu, 01 Sep 2022 10:00:13 -0400 Received: by mail-lf1-f47.google.com with SMTP id w8so15487431lft.12 for <25957@debbugs.gnu.org>; Thu, 01 Sep 2022 07:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=EvaorlmA5uk3ndQ45BlMiPbS2v4c/Qeiq06Ul3FUkA0=; b=YI7C8wgwe0RjSCnbYLSOSt3nMf2gtLdToiictPmKQPfIqgKmpGC9Vi13dZ40O7I4gE NMKZJIrPsC5dAeySggp+oYxOdxARGuI0P0PdfZ1qOs2+qU3LaGYZGs5+dg8APh5J2ETG 2QE0ejEYeRQ/4uUJH8HPxJLwgiSUXvXgpri1pI+aOauFm6Dl7v7StRJin24waD8hkZba lsnOK9m+LiJFKbLMdx2ll3iuo3VrIhoCf67cBzXhEHvwnfOXjlW/QIZgnGOnL200ypOd S6RvVEElPdBGxIC7rpXZn95Gn9Yhl17DXdq0HwdVR0MOJNIZ70k+j+uTVVRRe4w5JYpd AGqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=EvaorlmA5uk3ndQ45BlMiPbS2v4c/Qeiq06Ul3FUkA0=; b=wdQWYRgOlY261QsDMaf/dpGfBv+2RgGR8E+iwzois6jnWYOGlWnoQwaHO3lguZQLzQ t62tKFGM6+IPTh6Hma9NwOJcxR1U5tnMVznlNGyA46VQyLsvLVdXhoOw+0sI9AVccKaK ghj3srprG9yMP8l0xeiZkv/B+GVW0tfc/i4bL0xnpoQutEgU8WfbQf7KQ/GOmNoFfV8s 8LsrtpgRrGIShDES16W6YNIyVEF8pndnPHMgJ8+Fj9dzW1CSoHH3mFzQkYLsc8vDvNDG pMXM7ggeDYV5eXBnPlTjQyXULPGhCNfFHceVCSRjHmaMMOwMALJ3A3e9JplsJQrWtqlh IHXg== X-Gm-Message-State: ACgBeo1mPbOKu8h/Mkab3JTzcz55f8kMm/0jvR1wyNldIpf1Gfd5kOOD 9zf3ffbwAYYPTtFIwWGK+H4A1aoA0hLdaMb+8E9I7w== X-Google-Smtp-Source: AA6agR6o0noh63MseoHGqcN5wvMxr1PnET9nsLE7aNUUyYyHAIgljoStYPIaZyUgoQxOGsdz88otFoLqCzIpUBk/KGg= X-Received: by 2002:a05:6512:3fc:b0:494:663f:c017 with SMTP id n28-20020a05651203fc00b00494663fc017mr7292445lfq.472.1662040806610; Thu, 01 Sep 2022 07:00:06 -0700 (PDT) MIME-Version: 1.0 References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> In-Reply-To: From: "Thompson, David" Date: Thu, 1 Sep 2022 09:59:55 -0400 Message-ID: Subject: Re: [EXT] bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: Efraim Flashner , Maxime Devos , zimoun , 25957@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi all, Reviving this old thread. On Mon, Mar 28, 2022 at 2:51 AM Efraim Flashner wrote: > > > > Seems like all we have to do is 'substitute*' a '/usr/bin/svnserve' > > into a '/gnu/store/...' (untested), so seems actionable to me. > > Alternatively, as Efraim wrote, let it search the $PATH (that might be > > useful if adding svnserve would increase the closure too much and it is > > an optional dependency in practice?). > > I spent some time looking at gitolite and the service. As I understand > it, with the exception of svnserve, it searches $PATH for a number of > different binaries, including git-annex. I believe that this would only > work if git-annex (and potentially other packages) are installed > globally. > > In addition, git (not git-minimal) and openssh are propagated inputs AND > wrapped. I haven't tested to see if wrapping only is enough. > > I think the best choice is to: > A: Replace /usr/bin/svnserve with svnserve so it will just search $PATH, > like it does with the other helpers. I see that you have done this. Thanks! We could also replace the reference to /usr/sbin/redis-server in src/lib/Gitolite/Cache.pm. That's the only other /usr reference I can find (that isn't in a comment) in the output. I have the patch ready if that sounds good to you. > B: Adjust the service so that it automatically creates a variant (or > just a wrapped version) of the package which is wrapped with a list of > additional packages so that they can be in gitolite's path. If I were > deploying this to an arm device I wouldn't want it wrapped with > git-annex since it doesn't build, but would definitely want it for an > x86_64 machine. The service configuration record could accept a list of addons like '(git-annex cache svnserve), with a default of no addons '(), and create a package that extends the gitolite package with the appropriate propagated inputs. Does that sound like what you had in mind? A more robust solution could modify the build to hardcode the store paths needed for the add-ons but given that we already propagate git and openssh I don't think it's necessary right now. > I suppose we should try to find someone who is using the gitolite > service and see if they can be our test subject for wrapping the package > with optional addons. I use the gitolite service and can be the test subject. I don't currently use any add-ons, but the redis one sounds easy enough to try and hey maybe it's a good excuse to finally learn how to use git-annex. As a longer term thing, it would be cool to revisit propagating git and openssh in this package. I punted on it back in 2015 for the reason stated in the source comments but maybe there's a reasonable and reliable way to directly embed the store paths now. - Dave From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 10:20:14 2022 Received: (at 25957) by debbugs.gnu.org; 1 Sep 2022 14:20:14 +0000 Received: from localhost ([127.0.0.1]:43801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTl3F-0002zo-Hx for submit@debbugs.gnu.org; Thu, 01 Sep 2022 10:20:14 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:44828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTl3E-0002zZ-9U for 25957@debbugs.gnu.org; Thu, 01 Sep 2022 10:20:12 -0400 Received: by mail-wm1-f43.google.com with SMTP id n17-20020a05600c501100b003a84bf9b68bso1554480wmr.3 for <25957@debbugs.gnu.org>; Thu, 01 Sep 2022 07:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date; bh=YCrMg2Jl7LtHFY1Yqybpwp4o4qQX3YGnDNTS91GL6S0=; b=hng3zozNIs/yGTvW1OR5hwYHcuOMJJ4TYoSawY2fqow3roIIUlLjwddE4qQhOJEQoC A5BDJj7Z4Uc/ZoIyx1qxqa+Cmf0wIWy/dJYDqeQ+fLsDps6pFqFB2WQMm47HcFFokgcT KZ7SDT5WS9xB6OGeaJMT0T2BMf4p9ox/WXloohB7xZRrE5CYVjjP6GcZOvkb4Kqk4hEB YrzjN7nk58QrPfGKXipM/gHisRcLI0Fu5AHahEsAsOHnOvuoqU0WmX2qV7wdR67gY6qZ C7wY8NkBIG07cAmBC9m3UOzQ3Jt1P6ksX+/4KjAoEHJldgJiUNyJxsYd1Q3uoGjJarLe Ed2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date; bh=YCrMg2Jl7LtHFY1Yqybpwp4o4qQX3YGnDNTS91GL6S0=; b=zG384u3GtI1Ribu/32UmvGQMf3jhw5yitFQkg996I2itxTXZIkIuRCKx/vl41K8B+j 3uxNSSaSF41ruTlQ1RjB1BYMx9TipiD89StvVCbnEWWa5YCxH4AnfjOJ6iE3KHQlf6wD 9Mf1hZ/XgCpFJBxtaBwwUzel5yO1oOoYqI2mKrz0fQo07s7l8QZ1ffm7/Df0vq9VLRDw IIPBnJj8XTqhyLntMolhQfEmg3pP4MMQ5wWoHHPkwHZTy2pBsIXDa4p4sNejx67WKlXb g95NB9RAnMpk1YRh8Ibf2lTyT6nMkWWEo7KCL5rcBUnX4X6zJL4x1vgESZ0Nci0WIJCE BJGw== X-Gm-Message-State: ACgBeo0qjZfEhUiYFOUhh5xmhjDlwmIC5GlKvJKpcY59ZGz3rRQGok0Z xttiu0mW1ef2AlSE+7m74r4= X-Google-Smtp-Source: AA6agR7Vyhs1516eOBgosSM3epI8RNOPpdAMNPX5bIdaDv2uOJA8s0M9Hb8QRMpZvh0XAC095DNe6Q== X-Received: by 2002:a1c:4b01:0:b0:3a5:94e8:948e with SMTP id y1-20020a1c4b01000000b003a594e8948emr5378449wma.197.1662042006128; Thu, 01 Sep 2022 07:20:06 -0700 (PDT) Received: from localhost ([141.226.13.1]) by smtp.gmail.com with ESMTPSA id q13-20020adff78d000000b0022533c4fa48sm14481054wrp.55.2022.09.01.07.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 07:20:05 -0700 (PDT) Date: Thu, 1 Sep 2022 17:20:01 +0300 From: Efraim Flashner To: "Thompson, David" Subject: Re: [EXT] bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Message-ID: Mail-Followup-To: Efraim Flashner , "Thompson, David" , Maxime Devos , zimoun , 25957@debbugs.gnu.org References: <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FEi425vITRaO+k/f" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org, Maxime Devos , zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --FEi425vITRaO+k/f Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 01, 2022 at 09:59:55AM -0400, Thompson, David wrote: > Hi all, >=20 > Reviving this old thread. >=20 > On Mon, Mar 28, 2022 at 2:51 AM Efraim Flashner w= rote: > > > > > > Seems like all we have to do is 'substitute*' a '/usr/bin/svnserve' > > > into a '/gnu/store/...' (untested), so seems actionable to me. > > > Alternatively, as Efraim wrote, let it search the $PATH (that might be > > > useful if adding svnserve would increase the closure too much and it = is > > > an optional dependency in practice?). > > > > I spent some time looking at gitolite and the service. As I understand > > it, with the exception of svnserve, it searches $PATH for a number of > > different binaries, including git-annex. I believe that this would only > > work if git-annex (and potentially other packages) are installed > > globally. > > > > In addition, git (not git-minimal) and openssh are propagated inputs AND > > wrapped. I haven't tested to see if wrapping only is enough. > > > > I think the best choice is to: > > A: Replace /usr/bin/svnserve with svnserve so it will just search $PATH, > > like it does with the other helpers. >=20 > I see that you have done this. Thanks! We could also replace the > reference to /usr/sbin/redis-server in src/lib/Gitolite/Cache.pm. > That's the only other /usr reference I can find (that isn't in a > comment) in the output. I have the patch ready if that sounds good to > you. Sounds good to me > > B: Adjust the service so that it automatically creates a variant (or > > just a wrapped version) of the package which is wrapped with a list of > > additional packages so that they can be in gitolite's path. If I were > > deploying this to an arm device I wouldn't want it wrapped with > > git-annex since it doesn't build, but would definitely want it for an > > x86_64 machine. >=20 > The service configuration record could accept a list of addons like > '(git-annex cache svnserve), with a default of no addons '(), and > create a package that extends the gitolite package with the > appropriate propagated inputs. Does that sound like what you had in > mind? A more robust solution could modify the build to hardcode the > store paths needed for the add-ons but given that we already propagate > git and openssh I don't think it's necessary right now. Assuming this is deployed into some sort of container then propagated inputs wouldn't help much, we'd need either the PATH for the container to be extended to include those extra packages or to have gitolite itself wrapped similar to icedove/wayland. Just extending the PATH in the #:environment-variables would be enough I'd think. > > I suppose we should try to find someone who is using the gitolite > > service and see if they can be our test subject for wrapping the package > > with optional addons. >=20 > I use the gitolite service and can be the test subject. I don't > currently use any add-ons, but the redis one sounds easy enough to try > and hey maybe it's a good excuse to finally learn how to use > git-annex. >=20 > As a longer term thing, it would be cool to revisit propagating git > and openssh in this package. I punted on it back in 2015 for the > reason stated in the source comments but maybe there's a reasonable > and reliable way to directly embed the store paths now. It's actually been forever since I looked at gitolite so I don't know remember what those inputs were needed for, but it'd be great to improve the service. > - Dave Interestingly, I almost have a working ghc-8.6 for aarch64 after all these years. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --FEi425vITRaO+k/f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmMQv5EACgkQQarn3Mo9 g1E8nQ//Xj8Mzpi/6jL0+Ci+XmXAUOclrz/aNNsp2gzbRLzSCN76eW0d7ejVzVTj F/kQdy3EkEwg1OXgEZhvlkWx3qUY5Tma840llz0h+IhTIRax/KCXfbT6Sk/m27G8 rD2XHSirW35YmJuQlHadtq1uzUDxWLCGxY9r32G1xp+laorujSjVMeHTsnAoD1gS BpnieOvgD91DTk7zHJYtGCfavMRiuJOij/uS+9fs+oM8c17FcTaG4bndlxmy1F6+ 5BudwiY/HjzVn+jvbLsY/vMpSmGxaexQyJKQVJS792wnFF5sNRC+QOTmR0UztU6m mI9DCTPqHejR0i1jncnHKjUmI855avcEL8evNsjvjmF2NuWVb6YiwEtPuSpoCVn+ tLGnr4SceOgiRiXKLLOAzIA/JdcLmvkK6F15YhoBZSZEwsOAt5AVFXcOqiZ+FL6h /gXmGOc5Wrc9SuX7Ssb7YnKRXbZMq2rzj2Uu0J4+hPx9d27nn/HRoYZRvsLQjSNk +6W9R4DJc7clyu0dQ4qA/IynUud/UJ81GAVbqzT/Zcym7HQPMSM2hzLB28sluPag w0/mUoMwLEznjW+n3+tYbH6J+obF70jep70RTO6ldM4dHC1D8udWVLo9PsfP1tRb Eb1o967VkUg/rFWWL0ZexOip7lGs0s2LsSSKHyDirWFaRHvakCw= =TD+i -----END PGP SIGNATURE----- --FEi425vITRaO+k/f-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 10:41:41 2022 Received: (at 25957) by debbugs.gnu.org; 1 Sep 2022 14:41:41 +0000 Received: from localhost ([127.0.0.1]:43827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTlO0-0003WV-WF for submit@debbugs.gnu.org; Thu, 01 Sep 2022 10:41:41 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:38851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTlNz-0003WG-CG for 25957@debbugs.gnu.org; Thu, 01 Sep 2022 10:41:40 -0400 Received: by mail-lf1-f46.google.com with SMTP id q7so24727061lfu.5 for <25957@debbugs.gnu.org>; Thu, 01 Sep 2022 07:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=PwD0MIxgrGwDc3SffHFWttqDmvD8XhjLVKM5Lkmy9JE=; b=8PohvdlS22T4IqaBQQRDhMuEQXCBzxvHePIPe5DP4Qc+9RCbgJ/CMexBqiA/g/FAGW ruhxE5S4gyw1hVXRa0/3sCJtDTvWnUW0xjnzIAGPOyZxMSV0W0GuIH1v1JXPSsk9TUxD EkwLNsVB/ojWCbH9xWhIkGgwYQxIf1dvWC0Y62SbsXKpM9Dxn7RV1nHElKyef+eGHTbI L7UuC3sgQJiiJnB1I8Dc4dImh/du7xuOalrxfDcoy4t95J+3xi/fsg9w6Lbys+I98+gD QaWcNytMZdzoB6RUfdifl+MTt0S+R8DfNcT7TO4ZbFlHVWqQRp3+MHcF7VJ5G0fqQZVM 4oWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=PwD0MIxgrGwDc3SffHFWttqDmvD8XhjLVKM5Lkmy9JE=; b=ZKGB3YoWUgC2BxW8YAD5YhnQyVWx3rkQT1vpt9YRmKgYT8jHS7iYU5L0uG/hPpSdsR jU4SNZNfN0s1hv/JHRFXSl9vpuD4Z33F1x+ufpsjkOd9og0ggtvV9egxgg093lpbxLEt pDzqoDv7c3TWXqHHnbg+G8UfW7McpwEbcjMvoDQg5ar0WtKz8YxwPfhtGxdUGv1wqKri araKFXg1nQgKRhBpkf7HRQuUFCnHle9qFAWlOLi0wTuWY/JXYWQ1PqUjoZ53fWBdtNbI 36DPCa++Ic3tXGdze4CVoO8X4vfaclhOJTvRSaQXfDnmMaUBb+9jf3wnk5FpQnXd24ly robA== X-Gm-Message-State: ACgBeo2Xm3sRQ+NcZ8nqQtgvJjkFL5BU7dGfQpsXSMt4hdbfcbHjaW8q vqh0kEh1v5qLj//7KvPNY25WMwKWNCQaCvgQhmrk3w== X-Google-Smtp-Source: AA6agR6xCAOoZl9s2Mmkntq/5pgj63gOMoKJa6Dv92GVxJI8D35lS97MLc3ERKFTnFWu8GBIXJF2sWAl1iVdeLJVqu4= X-Received: by 2002:ac2:4c88:0:b0:494:96d0:334 with SMTP id d8-20020ac24c88000000b0049496d00334mr1867619lfl.146.1662043293089; Thu, 01 Sep 2022 07:41:33 -0700 (PDT) MIME-Version: 1.0 References: <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> In-Reply-To: From: "Thompson, David" Date: Thu, 1 Sep 2022 10:41:21 -0400 Message-ID: Subject: Re: [EXT] Re: [EXT] bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: Efraim Flashner , "Thompson, David" , Maxime Devos , zimoun , 25957@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Efraim, On Thu, Sep 1, 2022 at 10:20 AM Efraim Flashner wrote: > > On Thu, Sep 01, 2022 at 09:59:55AM -0400, Thompson, David wrote: > > Hi all, > > > > Reviving this old thread. > > > > On Mon, Mar 28, 2022 at 2:51 AM Efraim Flashner wrote: > > > > > > > > Seems like all we have to do is 'substitute*' a '/usr/bin/svnserve' > > > > into a '/gnu/store/...' (untested), so seems actionable to me. > > > > Alternatively, as Efraim wrote, let it search the $PATH (that might be > > > > useful if adding svnserve would increase the closure too much and it is > > > > an optional dependency in practice?). > > > > > > I spent some time looking at gitolite and the service. As I understand > > > it, with the exception of svnserve, it searches $PATH for a number of > > > different binaries, including git-annex. I believe that this would only > > > work if git-annex (and potentially other packages) are installed > > > globally. > > > > > > In addition, git (not git-minimal) and openssh are propagated inputs AND > > > wrapped. I haven't tested to see if wrapping only is enough. > > > > > > I think the best choice is to: > > > A: Replace /usr/bin/svnserve with svnserve so it will just search $PATH, > > > like it does with the other helpers. > > > > I see that you have done this. Thanks! We could also replace the > > reference to /usr/sbin/redis-server in src/lib/Gitolite/Cache.pm. > > That's the only other /usr reference I can find (that isn't in a > > comment) in the output. I have the patch ready if that sounds good to > > you. > > Sounds good to me Thanks, pushed as commit c053dfa52dc778eb3d965f58a85c435ae7fab0dd. > > > B: Adjust the service so that it automatically creates a variant (or > > > just a wrapped version) of the package which is wrapped with a list of > > > additional packages so that they can be in gitolite's path. If I were > > > deploying this to an arm device I wouldn't want it wrapped with > > > git-annex since it doesn't build, but would definitely want it for an > > > x86_64 machine. > > > > The service configuration record could accept a list of addons like > > '(git-annex cache svnserve), with a default of no addons '(), and > > create a package that extends the gitolite package with the > > appropriate propagated inputs. Does that sound like what you had in > > mind? A more robust solution could modify the build to hardcode the > > store paths needed for the add-ons but given that we already propagate > > git and openssh I don't think it's necessary right now. > > Assuming this is deployed into some sort of container then propagated > inputs wouldn't help much, we'd need either the PATH for the container > to be extended to include those extra packages or to have gitolite > itself wrapped similar to icedove/wayland. Just extending the PATH in > the #:environment-variables would be enough I'd think. Hmm, I hadn't thought about the container use case. Your approach sounds like the way to go. For what it's worth, I think the gitolite service as-is would suffer the same issue in a containerized environment because it relies upon the git and openssh propagated inputs to do anything at all. With the gitolite service in my system, /run/current-system/profile/bin has both git and ssh in it due to the propagation. So it sounds like there's 2 steps needed: 1) Use a wrapper like icedove/wayland for the base gitolite package so that git and openssh no longer need propagation, and then 2) extend the gitolite service to wrap up additional packages needed for the desired extensions. Sound good? > > > I suppose we should try to find someone who is using the gitolite > > > service and see if they can be our test subject for wrapping the package > > > with optional addons. > > > > I use the gitolite service and can be the test subject. I don't > > currently use any add-ons, but the redis one sounds easy enough to try > > and hey maybe it's a good excuse to finally learn how to use > > git-annex. > > > > As a longer term thing, it would be cool to revisit propagating git > > and openssh in this package. I punted on it back in 2015 for the > > reason stated in the source comments but maybe there's a reasonable > > and reliable way to directly embed the store paths now. > > It's actually been forever since I looked at gitolite so I don't know > remember what those inputs were needed for, but it'd be great to improve > the service. Are you referring to git and openssh or redis, svnserve, git-annex, etc.? I'm no expert and I really don't like Perl, but I know gitolite well enough to explain some of this stuff. > Interestingly, I almost have a working ghc-8.6 for aarch64 after all > these years. Some things move at a glacial pace, but eventually they get done. Best of luck wrapping that up. :) - Dave From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 01 13:29:34 2022 Received: (at 25957) by debbugs.gnu.org; 1 Sep 2022 17:29:34 +0000 Received: from localhost ([127.0.0.1]:44092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTo0T-0001ib-QY for submit@debbugs.gnu.org; Thu, 01 Sep 2022 13:29:34 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:38862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTo0R-0001iI-PZ for 25957@debbugs.gnu.org; Thu, 01 Sep 2022 13:29:32 -0400 Received: by mail-wm1-f50.google.com with SMTP id n23-20020a7bc5d7000000b003a62f19b453so1776309wmk.3 for <25957@debbugs.gnu.org>; Thu, 01 Sep 2022 10:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc; bh=pZgKT64IayPeaPcXTzbKJTxbOzKpJ/0oXGPYHpihY/8=; b=WoOhWMauJFEY2Z11btOdVXVNMFOPEE2viYDCCpA1p5S+F8piyDavd6nfaZLvOLJsc/ RZHrg4i9w3VZslGLU++iRhkAJiMgtLLklYYAcF1eafTsE2n7EDLuJOXmybBfKckrkEF2 7HNuvyhBhLp5Cer+HxAXixjuILP8AGKQ2HtHhli2yLKyT5/JBCL9n1CKUNTfE9A658Tp 5GYkdvZ/su5Vp4elu8Blt2A1hGUhcWdxZJNRbD850N+Zl78eTrdSJGya8rqttKJTgf3R HwV4pK7h2jmeUA9j1CvXvY25WA/rOUDsC2WJUjA6Oo+11+NKxsqbjoiXu8/uCYC+oqGb T1PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc; bh=pZgKT64IayPeaPcXTzbKJTxbOzKpJ/0oXGPYHpihY/8=; b=rIu8z3Ba7Lq5wF4D5de7sqquv6QRs3wduZQfc9jh4En4SA3nTjhx/iRKEuSkeP4Wj7 hoJJw46/9SwEtuSvYKUBe+SlyfIHbfu8sK0ZmbYi9wAiZgrsfD5MgrmGvHssYnRTySYt DAIM+FKnxmPQsEHNDKD8cjC5hC/HnDA3BAAATEyomyeU93mHBs0ACWlbMexMe4cI45GF X+e+DFCQb9mRNKqLS6reisaufoXS66+LjXsmfqovs5yctXwj6FPWBcAjoQNweUk98TYo h7NXj49gzUC5tB+5tCARkG1B5pSdAmlkzRvuY1kEUyzMo332Uv8U3I0lZAYRCwtOmMUF ZeVQ== X-Gm-Message-State: ACgBeo16WjfV0qP4wGg97K0tc0P1P/uzGLhOHSco2hRds2sLSYLjD/9v mEEFsu+rMDYk1CG/Ge6ZUbxXsTF2o9I= X-Google-Smtp-Source: AA6agR6cOd95N7IGIAGqHTcYi9LqQgjiG4p2ZYAN4Vp/0VCDIpWk23nxX8jakIQYW8AY/v8KRD54ng== X-Received: by 2002:a1c:4c11:0:b0:3a5:4d01:54be with SMTP id z17-20020a1c4c11000000b003a54d0154bemr171276wmf.32.1662053365587; Thu, 01 Sep 2022 10:29:25 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id h23-20020a05600c2cb700b003a2f2bb72d5sm7005427wmc.45.2022.09.01.10.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 10:29:24 -0700 (PDT) From: zimoun To: "Thompson, David" , Efraim Flashner , "Thompson, David" , Maxime Devos , 25957@debbugs.gnu.org Subject: Re: bug#25957: [EXT] Re: [EXT] bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks In-Reply-To: References: <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> Date: Thu, 01 Sep 2022 19:00:45 +0200 Message-ID: <874jxruj0i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On jeu., 01 sept. 2022 at 10:41, "Thompson, David" wrote: > Thanks, pushed as commit c053dfa52dc778eb3d965f58a85c435ae7fab0dd. Cool! Thank you. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 02 03:00:09 2022 Received: (at 25957) by debbugs.gnu.org; 2 Sep 2022 07:00:09 +0000 Received: from localhost ([127.0.0.1]:44671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU0eu-0007ey-Gq for submit@debbugs.gnu.org; Fri, 02 Sep 2022 03:00:09 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:40902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU0es-0007cs-8U for 25957@debbugs.gnu.org; Fri, 02 Sep 2022 03:00:07 -0400 Received: by mail-wm1-f49.google.com with SMTP id h204-20020a1c21d5000000b003a5b467c3abso2760411wmh.5 for <25957@debbugs.gnu.org>; Fri, 02 Sep 2022 00:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date; bh=gl23N613o5DcERzNEvTZ54KPAZK36B7TZsMf9nTaPT8=; b=aPHrCV1AdwZcjNDBOLOutulnfOtTJt0KzNV1emBAP68LKKqkE1klmnWgaI62F3fCL9 Ce0p9fNKSuD8BdKwdl2ATv+hwcs1l6Hzx9Y640yP6ZMTH2WAg4lXbEpJXkwsbsC8RuNk hlI0eXEyP+jVyrPBLgMoKCcAa8UU6Vu5+bFRd16oFXAA7z+UdmPxdNnv2BjiiCXrD5i+ mkxZkC7afqC114MfvPhffQ6PgjRqrMA9KJu7Uob9chmxEHZ9SBWrmcZBjfJiMfl3CzNG Y/GXTTZ5x3HXOB5qJSEhtQ2K44NcT0Cj0mGKwIE/inDnrKR1NWvg4Xx4ZBUAvQ1TaVeA zHgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date; bh=gl23N613o5DcERzNEvTZ54KPAZK36B7TZsMf9nTaPT8=; b=ukED455myBERBEhqGlgn+5rjwq1Yo+QH56ZqwoxxBEsQgoUxT4s1p0np71YCOGxhe1 8Ix391ItUbjWivmBlHGxnFnBkMmd1hbhUbzSaOPcKAi8y5RB50E8cPoL/vOWQJw85h1O QE9YjE77Gx1OUNVnOIPJ5JZHUFMoryAXVJ0KJFIi/cOr/snDN7TJJM/hov3yvEcq67I8 R5UGGx4FkBQDaVU2iEr72aOzr1afsca1NwPV8k6zLfthhZnEqeA2A8ODIRbezcpKryL5 pEwj4LWIKBBFbunJVpq6ENnf0d96k9LsjqJCmtVSwagOgcE8ezx3+GqW7IyarlGBtPP6 02WA== X-Gm-Message-State: ACgBeo3KGFaGn4fVEpINf5+q2Y8dVtTfM4g0nBo2gaFLyO1cgmQXRjQ7 Jy113INg1qvMDecaEPr5hpM= X-Google-Smtp-Source: AA6agR7RViISeHxw2fT2KYlckDSu9zUzNa0PtMsWqrzEi+opcy6dyyga2W8GEp6VHnAcvKTS9+etYQ== X-Received: by 2002:a05:600c:3781:b0:3a6:804a:afc with SMTP id o1-20020a05600c378100b003a6804a0afcmr1661588wmr.27.1662102000254; Fri, 02 Sep 2022 00:00:00 -0700 (PDT) Received: from localhost ([141.226.13.1]) by smtp.gmail.com with ESMTPSA id g26-20020a7bc4da000000b003a54f49c1c8sm1226924wmk.12.2022.09.01.23.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 23:59:59 -0700 (PDT) Date: Fri, 2 Sep 2022 09:56:49 +0300 From: Efraim Flashner To: "Thompson, David" Subject: Re: [EXT] Re: [EXT] bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Message-ID: Mail-Followup-To: Efraim Flashner , "Thompson, David" , Maxime Devos , zimoun , 25957@debbugs.gnu.org References: <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VYaaI6pqkucRAJLI" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org, Maxime Devos , zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --VYaaI6pqkucRAJLI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 01, 2022 at 10:41:21AM -0400, Thompson, David wrote: > Hi Efraim, >=20 > On Thu, Sep 1, 2022 at 10:20 AM Efraim Flashner w= rote: > > > > On Thu, Sep 01, 2022 at 09:59:55AM -0400, Thompson, David wrote: > > > Hi all, > > > > > > Reviving this old thread. > > > > > > On Mon, Mar 28, 2022 at 2:51 AM Efraim Flashner wrote: > > > > > > > > > > Seems like all we have to do is 'substitute*' a '/usr/bin/svnserv= e' > > > > > into a '/gnu/store/...' (untested), so seems actionable to me. > > > > > Alternatively, as Efraim wrote, let it search the $PATH (that mig= ht be > > > > > useful if adding svnserve would increase the closure too much and= it is > > > > > an optional dependency in practice?). > > > > > > > > I spent some time looking at gitolite and the service. As I underst= and > > > > it, with the exception of svnserve, it searches $PATH for a number = of > > > > different binaries, including git-annex. I believe that this would = only > > > > work if git-annex (and potentially other packages) are installed > > > > globally. > > > > > > > > In addition, git (not git-minimal) and openssh are propagated input= s AND > > > > wrapped. I haven't tested to see if wrapping only is enough. > > > > > > > > I think the best choice is to: > > > > A: Replace /usr/bin/svnserve with svnserve so it will just search $= PATH, > > > > like it does with the other helpers. > > > > > > I see that you have done this. Thanks! We could also replace the > > > reference to /usr/sbin/redis-server in src/lib/Gitolite/Cache.pm. > > > That's the only other /usr reference I can find (that isn't in a > > > comment) in the output. I have the patch ready if that sounds good to > > > you. > > > > Sounds good to me >=20 > Thanks, pushed as commit c053dfa52dc778eb3d965f58a85c435ae7fab0dd. >=20 > > > > B: Adjust the service so that it automatically creates a variant (or > > > > just a wrapped version) of the package which is wrapped with a list= of > > > > additional packages so that they can be in gitolite's path. If I we= re > > > > deploying this to an arm device I wouldn't want it wrapped with > > > > git-annex since it doesn't build, but would definitely want it for = an > > > > x86_64 machine. > > > > > > The service configuration record could accept a list of addons like > > > '(git-annex cache svnserve), with a default of no addons '(), and > > > create a package that extends the gitolite package with the > > > appropriate propagated inputs. Does that sound like what you had in > > > mind? A more robust solution could modify the build to hardcode the > > > store paths needed for the add-ons but given that we already propagate > > > git and openssh I don't think it's necessary right now. > > > > Assuming this is deployed into some sort of container then propagated > > inputs wouldn't help much, we'd need either the PATH for the container > > to be extended to include those extra packages or to have gitolite > > itself wrapped similar to icedove/wayland. Just extending the PATH in > > the #:environment-variables would be enough I'd think. >=20 > Hmm, I hadn't thought about the container use case. Your approach > sounds like the way to go. For what it's worth, I think the gitolite > service as-is would suffer the same issue in a containerized > environment because it relies upon the git and openssh propagated > inputs to do anything at all. With the gitolite service in my system, > /run/current-system/profile/bin has both git and ssh in it due to the > propagation. So it sounds like there's 2 steps needed: 1) Use a > wrapper like icedove/wayland for the base gitolite package so that git > and openssh no longer need propagation, and then 2) extend the > gitolite service to wrap up additional packages needed for the desired > extensions. Sound good? >=20 > > > > I suppose we should try to find someone who is using the gitolite > > > > service and see if they can be our test subject for wrapping the pa= ckage > > > > with optional addons. > > > > > > I use the gitolite service and can be the test subject. I don't > > > currently use any add-ons, but the redis one sounds easy enough to try > > > and hey maybe it's a good excuse to finally learn how to use > > > git-annex. > > > > > > As a longer term thing, it would be cool to revisit propagating git > > > and openssh in this package. I punted on it back in 2015 for the > > > reason stated in the source comments but maybe there's a reasonable > > > and reliable way to directly embed the store paths now. > > > > It's actually been forever since I looked at gitolite so I don't know > > remember what those inputs were needed for, but it'd be great to improve > > the service. >=20 > Are you referring to git and openssh or redis, svnserve, git-annex, > etc.? I'm no expert and I really don't like Perl, but I know gitolite > well enough to explain some of this stuff. >=20 > > Interestingly, I almost have a working ghc-8.6 for aarch64 after all > > these years. >=20 > Some things move at a glacial pace, but eventually they get done. > Best of luck wrapping that up. :) I took a look at the gitolite service finally and I hadn't realized there wasn't a running daemon to containerize. I assumed we could do something like: (start $~(make-forkexec-constructor/container (list ...) #:environment-variables '("PATH=3D...") #:mappings ...)) Given that's not the case then I'd need to look at gitolite itself to see how it calls the other binaries it expects to be available, and if wrapping it would be enough or if we would need to just propagate the other packages for functionality. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --VYaaI6pqkucRAJLI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmMRqS4ACgkQQarn3Mo9 g1GJmw//ZKP6b51L8skZwo84dNH4hRRRG4wee4pIPts+EtKaop6g0j2JVvTQTJ7k 0SuBySy6TUTokrNjLpiW0KgqSV5/UZLHqDV8W+an5hC0nxKj/7cux9Qaj1QcZXgq x5DBlBE7y5XLGmxFtqz/BrdmfINAeuh7xlLxOg0YHxwISQ6XwRlC3X1OGliSTc7d pCZC+zY0FloethSoFuSy+TWBO3yxm/aE5IevXSGFfjMreD45ma48C5AGwEH5je0C ghytFcrZxolEelYJdRi62oFsVaQSYnUQKbssyh0E3KigOLDwuLnARmq5NzRyvt4W N48ViseelBDSeR57Gs7gM+sY5AZQxBSjbesgqEVVGEklwnJTMqecDCP1KxQJI5nz ywf8FOgQxx0+6Loa5opPumXJRl2QxPs++1aPXsMP+Km5KnDfl6ZjrhASA4JLOm4n ZrPvHBHnFKj4HGbBdwK2gx6mbziIpFvmxrsYfdPr04YOYpfMJv/vA9OUC7DAiVmF ncewfG4BAWlofkFKYOYZ9lYCKWZm2xKvYLFnQp5+s0LAMBoaENM5rGpM/7xF+mNJ bE++fi1JtMK/h15iKJtGaqR9DYi5GZvNEf+bdRjT7u2kP2hbmQUbqSLFwO1nUw0G xyjhJ0TgNWHp+rTOWMgPF5BuVm0JUvLq5CMDKbbVZvOc48UCWIs= =7wb3 -----END PGP SIGNATURE----- --VYaaI6pqkucRAJLI-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 02 07:12:19 2022 Received: (at 25957) by debbugs.gnu.org; 2 Sep 2022 11:12:19 +0000 Received: from localhost ([127.0.0.1]:45047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU4ax-0004lH-8N for submit@debbugs.gnu.org; Fri, 02 Sep 2022 07:12:19 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:44891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU4ap-0004kw-9E for 25957@debbugs.gnu.org; Fri, 02 Sep 2022 07:12:17 -0400 Received: by mail-lf1-f52.google.com with SMTP id g7so2747028lfe.11 for <25957@debbugs.gnu.org>; Fri, 02 Sep 2022 04:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=u16j1Rn1pzZd8LRkwYULudM4G/dhnQ9bQuiGAgBU/Q0=; b=GiMqGHjRzDm59rDxYM1iytvb2gkGPmHOnNzsE/hxznz8QsyEV5QC9qFBY98gQuxjHt 4Qfmv4C3rIDG3sYZOSUmJ90niABZbvk8aRSFg5FE57jipKViG59dWCndvNUyRLVsN0CZ E2anbit1Myu7lvW2vw5Ik0E/J6fRVjV7LTmlOk6bmlMWr6bksGLjyfcNNA708jcoWfmM ClNHnSg8l74sg4oYFwTaZbpiLSmQARKmsQe8+VNE/K7BGDAhUmog1eXJU3GmfbETfCmI q+ggr35QdHUhzeWvzJnwIbdA6pB2U2wC3Q9E9LIwQNtGcVju6wI3JGO6yVLvku7Pdndx NXsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=u16j1Rn1pzZd8LRkwYULudM4G/dhnQ9bQuiGAgBU/Q0=; b=HCQ00eWxmbCiJp2FCxuMGawjWsGa/Ob/SrMNm0soqudZ5RVB27JPnYbKIhogJ9BAMJ FoIvHlMlu1n+BmPEodVhwmj5JTR+mdqBn2DNH6b+8X8w9VgE/v9sr++Fyfrxjs/GXIma lbmC/17hbttoCxKIgGnpFFEWAj6bW7ttQtZm/qhSUrJnFlhgUyHMvdWUFg+3OEwSlOr9 ZLSEobX+2s0Su1QwNdPkHT6QR5/i5BJLcH3NmYI6ZbThn0ee/4fsSeheZkgxKZFsltmA ebPyBGxOxioQqlAzrDwRj79Oe86GYxqCAfROLDBNBgFbCFO8mnKCwJnQTzPYCCbshE+j vxBw== X-Gm-Message-State: ACgBeo2Hb3D9m5VquU0jNeNoP0eFbrF5lQvY9SpKSSjMAQC2YuUWESWN U5/HO2hmZGtHN1SSDSq0Z17Q3glhYSWPZef43Wv2Tw== X-Google-Smtp-Source: AA6agR7ecR3rln814GR6VBnHIwudiT9plDgIzKAbx3EmkY+D4RHLYbpzsv88BI7bTuZfisdd3oj+n3FCxxB4XxPebpA= X-Received: by 2002:ac2:5e8c:0:b0:494:6d14:f16e with SMTP id b12-20020ac25e8c000000b004946d14f16emr7469749lfq.316.1662117125199; Fri, 02 Sep 2022 04:12:05 -0700 (PDT) MIME-Version: 1.0 References: <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> In-Reply-To: From: "Thompson, David" Date: Fri, 2 Sep 2022 07:11:54 -0400 Message-ID: Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: Efraim Flashner , "Thompson, David" , zimoun , 25957@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Sep 2, 2022 at 3:00 AM Efraim Flashner wrote: > > I took a look at the gitolite service finally and I hadn't realized > there wasn't a running daemon to containerize. I assumed we could do > something like: > > (start $~(make-forkexec-constructor/container > (list ...) > #:environment-variables > '("PATH=...") > #:mappings ...)) > > Given that's not the case then I'd need to look at gitolite itself to > see how it calls the other binaries it expects to be available, and if > wrapping it would be enough or if we would need to just propagate the > other packages for functionality. Gitolite simply expects tools like git to be on $PATH. It's a pretty naive system, there's nothing like a configure script that is determining the absolute file name of these tools and substituting those names into the built files. The executable is already wrapped so that coreutils, findutils, and git are on $PATH, but notably not openssh: (add-after 'install 'wrap-scripts (lambda* (#:key inputs outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out")) (coreutils (assoc-ref inputs "coreutils")) (findutils (assoc-ref inputs "findutils")) (git (assoc-ref inputs "git"))) (wrap-program (string-append out "/bin/gitolite") `("PATH" ":" prefix ,(map (lambda (dir) (string-append dir "/bin")) (list out coreutils findutils git))))))) However, git and openssh are still propagated inputs. I'm going to move the propagated inputs to regular inputs, potentially add openssh to the wrapper once I remind myself what gitolite does with those tools, and test it all out on my server using the gitolite service. If that all works, we have a good starting point for adding extension support in the service. - Dave From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 02 08:45:07 2022 Received: (at 25957) by debbugs.gnu.org; 2 Sep 2022 12:45:07 +0000 Received: from localhost ([127.0.0.1]:45223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU62l-00016M-3Q for submit@debbugs.gnu.org; Fri, 02 Sep 2022 08:45:07 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:44669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU62j-00015K-4t for 25957@debbugs.gnu.org; Fri, 02 Sep 2022 08:45:05 -0400 Received: by mail-wr1-f43.google.com with SMTP id c7so2149617wrp.11 for <25957@debbugs.gnu.org>; Fri, 02 Sep 2022 05:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date; bh=+5Hw0SlAqpM5kLBhzzDwpWeIbKRsY9n22egGfAFFW5E=; b=iIT71+31r0fwQ0GtUdCxo2fwyH7zHmU7cUuA+NhM0cndlZ6x1kB2w7LdlGoPZA6YgT M8k9CUZBpk8vsLSeu+RasO4QG0Vj7ys8CEkkWq05xUITy8l0ldZ6lkRrJL8MsV/LiijA ciZOAhxTMvLfUkBfS6oqW/dPivWL5rtP8D7P64eSdZ3AveFePnhRniR8u3qW6V9bBc+y PJ/HNB6fbj3uD3Tg0UEljMRaDqlwejaa/dsx8yQlh9p7yaD323cIDyjSwcvIUUglAlWx S033Ym+qSn9XzdCrq6zLPXmo0z6X284cMiH6uaS1ERJD8Twj5FMuIs2Lh1EzmmjVyJz2 vmkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date; bh=+5Hw0SlAqpM5kLBhzzDwpWeIbKRsY9n22egGfAFFW5E=; b=Gd2gO3l7HQpA8xqxCes2eYYi/lt+U2+KFiwI5ohR/2wjyQVOj+FDPwZ7N4gK9ujaji nLklLqMAe47XnL6G6I9sNOX8qkOZRtbr7jW3r6Qhr1GRywOq3DTxYTHYmjiHQf631nix bAL3xtLJ3GXf2nfHc6lA0a4fOuJ7KM6xjzaMMvYgcXWqENH5Nb6ueitUeCJ9Kb8B13ex 4iisA6qULwRjVKK3Cequ9ZGyL7lrOiOtiDunGwCF7Im0f1lyiwovrOdOp7NWt1Z3hYiA PnEdWEBQo0cqiFWYDiavDxLo9+i+c7Oquw3yFBX/ShjGcrgmy5MY5tXBvtPaxs4O9iO8 4KAw== X-Gm-Message-State: ACgBeo1WHtcVyZV16P5tmF54Z2kJaAlvRFNbnpuR1pxwTscQfOeOgDJ/ db3uLZEhplwN5lnnbl2FxLE= X-Google-Smtp-Source: AA6agR7yBIsYk4/TEQpfzavgw10D2i5p7+imrQZ9+uIb9D3THg81InLuxl+kvHZZF/m+T5DJ6xmT8w== X-Received: by 2002:adf:fb8f:0:b0:225:2def:221e with SMTP id a15-20020adffb8f000000b002252def221emr17391655wrr.130.1662122699291; Fri, 02 Sep 2022 05:44:59 -0700 (PDT) Received: from localhost ([141.226.13.1]) by smtp.gmail.com with ESMTPSA id z4-20020a1cf404000000b003a603fbad5bsm1950208wma.45.2022.09.02.05.44.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 05:44:57 -0700 (PDT) Date: Fri, 2 Sep 2022 15:41:42 +0300 From: Efraim Flashner To: "Thompson, David" Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Message-ID: Mail-Followup-To: Efraim Flashner , "Thompson, David" , zimoun , 25957@debbugs.gnu.org References: <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rdBhjiGdVK8p+O+o" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --rdBhjiGdVK8p+O+o Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 02, 2022 at 07:11:54AM -0400, Thompson, David wrote: > On Fri, Sep 2, 2022 at 3:00 AM Efraim Flashner wr= ote: > > > > I took a look at the gitolite service finally and I hadn't realized > > there wasn't a running daemon to containerize. I assumed we could do > > something like: > > > > (start $~(make-forkexec-constructor/container > > (list ...) > > #:environment-variables > > '("PATH=3D...") > > #:mappings ...)) > > > > Given that's not the case then I'd need to look at gitolite itself to > > see how it calls the other binaries it expects to be available, and if > > wrapping it would be enough or if we would need to just propagate the > > other packages for functionality. >=20 > Gitolite simply expects tools like git to be on $PATH. It's a pretty > naive system, there's nothing like a configure script that is > determining the absolute file name of these tools and substituting > those names into the built files. >=20 > The executable is already wrapped so that coreutils, findutils, and > git are on $PATH, but notably not openssh: >=20 > (add-after 'install 'wrap-scripts > (lambda* (#:key inputs outputs #:allow-other-keys) > (let ((out (assoc-ref outputs "out")) > (coreutils (assoc-ref inputs "coreutils")) > (findutils (assoc-ref inputs "findutils")) > (git (assoc-ref inputs "git"))) > (wrap-program (string-append out "/bin/gitolite") > `("PATH" ":" prefix > ,(map (lambda (dir) > (string-append dir "/bin")) > (list out coreutils findutils git))))))) >=20 > However, git and openssh are still propagated inputs. I'm going to > move the propagated inputs to regular inputs, potentially add openssh > to the wrapper once I remind myself what gitolite does with those > tools, and test it all out on my server using the gitolite service. > If that all works, we have a good starting point for adding extension > support in the service. I like it. Let us know how it goes. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --rdBhjiGdVK8p+O+o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmMR+gMACgkQQarn3Mo9 g1FfIBAAmVbRlh96YZnlmbAKijXgMIT8HXSTCgCqpuiUE3LH9HM+vh9pGHO+CSkd W26HV5G+VCcpzLnSFAnUgpm4W2eMgZDt6IfTG7SzwpZs6z5+Oc9XRuxaqRdoBMiT zK5ATgZoGkn4bK5yfVC4xTUTyrNJEsS7fZzNm7UnoU83G6GHv3SvoRICL5eWYgf5 CvLVmH5gRYtJSQGKZkh9iCLadGezDT2oyZXK58q0GrWb0M2esG+lVRw5xjLjXrsh 4vy+pACbM4iHg/XJsh6ObcUKDAtybsbaK9Os0uMKnOICC3s2giCLkZ8oU46+o5dT Jga9j9ObWJlxiLhGzSzPBx2mEAolKjh1ofSe0f1I2/fBU+P+mjvLgKW7aFZIkdY0 ij6iJKGZ58SvbgX3cxptKkyzV8C9AgZUmFsmEOeKAgjxopjjPA3jG87t3Mivtteu p1xWtimunzMFbNURB9/rMrK5Q9BqbB3cgTa4XJZPNMg7B44pzY0pnXt3F3IxMxea dj5R/ceFSJclu9BSmZyRU7ZKMRrRnXshZd7bmxBqf+Qupq16qYvQhXFlMoxkOhdy 0bqswHRQ9YLgscXPlb2hmvNuceXEOm0dpHUa9V4aElh37zPO7fBIcZchfOnab/h3 7zVEfZZlIS5o2yunnuUmtt9TmeXx4bmp5cSGZ2Q9lIbQSYdPpyU= =dCOk -----END PGP SIGNATURE----- --rdBhjiGdVK8p+O+o-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 02 08:50:42 2022 Received: (at 25957) by debbugs.gnu.org; 2 Sep 2022 12:50:42 +0000 Received: from localhost ([127.0.0.1]:45242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU689-0001Iq-P4 for submit@debbugs.gnu.org; Fri, 02 Sep 2022 08:50:42 -0400 Received: from mail-lj1-f181.google.com ([209.85.208.181]:39792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU688-0001Ic-Iu for 25957@debbugs.gnu.org; Fri, 02 Sep 2022 08:50:41 -0400 Received: by mail-lj1-f181.google.com with SMTP id bn9so2159750ljb.6 for <25957@debbugs.gnu.org>; Fri, 02 Sep 2022 05:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=coH0PBd9cdxKtfhZ0t9em8hbI1VNqWHp+1aL9vE4PdA=; b=Mw4wtEaYXWTWsT/LHvkQ+HzE+NNmtGSeUzsRzqPIPdP6JluxYM4WHZDG49Nl8gqAmA Bv/6pjK9XOTh0IjXMmBawbwZ0inbX4FQJ+z8ZQxwJMFORuzHBBMgogRE5c3MJmIfypAI zFQv2mqG7o5KqkmAsX5kHs5oiP35MabYWGCqL31IHdGNmQXDf2q3nHyWCTXwD0sp+Aay 35oKLgCF97Jv/gnQyPVfLYYwTQf4tQpryeo9ho2zkcw+ExcOPXZyiLeEKjMIWrOd+3ns kV9jPLXHcI05T4JxAfHoZCusXhLhfH4xIGEfJdkXvkOIafoBGsYpUNi2IXvvkZEADJEw ZUmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=coH0PBd9cdxKtfhZ0t9em8hbI1VNqWHp+1aL9vE4PdA=; b=mFzfXm7hisR38EStO4UDsI2H22yldZjSUv4eUsQLATieqL2/HEvQ+lkZuT9TSryB2i 8bemZo+CBW7CKah56f9GlEa6JiaT9m052hHsvejBA1I4gmlAHeZ4EZvFOUmukHRRspkz 1oD6VuXiIR2OUmI0Ydq4gfx5WODI9VK40SBaIzjMFEBPRaOZbrwkVRFjCodd72JJB7WO 4/aSGoRIFU1VCvJD7gqoKYF2+xQGeVkI4iSxFu1Ovx0NfRVSP+9x+mR8XFNkJCaiobmy a64Zu4R1u/9d3Rt9DuqUD+Q3yFOtOucow4OTbaTgHnQZYmryHcwhv/QCUW8LFih6XEsF W8PQ== X-Gm-Message-State: ACgBeo3lbvU6upqGW3pT22Z2wSQjhNrIJPMufNSTAFjacvgsn/VYEGoM Awl/ONwBNqKLBBYelW+xQwA9wrMFxjNZry94LrS2MA== X-Google-Smtp-Source: AA6agR5GnQHzzqiidah0M7wUxQK62OtvO6dP+hFUyGA9mE2E26iZD+w4fBm1j9gggHwxxi1KQ5J1fWTHUJ4vA4pIXYA= X-Received: by 2002:a2e:880a:0:b0:265:818c:d81c with SMTP id x10-20020a2e880a000000b00265818cd81cmr6151374ljh.381.1662123032831; Fri, 02 Sep 2022 05:50:32 -0700 (PDT) MIME-Version: 1.0 References: <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> In-Reply-To: From: "Thompson, David" Date: Fri, 2 Sep 2022 08:50:21 -0400 Message-ID: Subject: Re: [EXT] Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: Efraim Flashner , "Thompson, David" , zimoun , 25957@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Sep 2, 2022 at 8:44 AM Efraim Flashner wrote: > > On Fri, Sep 02, 2022 at 07:11:54AM -0400, Thompson, David wrote: > > On Fri, Sep 2, 2022 at 3:00 AM Efraim Flashner wrote: > > > > > > I took a look at the gitolite service finally and I hadn't realized > > > there wasn't a running daemon to containerize. I assumed we could do > > > something like: > > > > > > (start $~(make-forkexec-constructor/container > > > (list ...) > > > #:environment-variables > > > '("PATH=...") > > > #:mappings ...)) > > > > > > Given that's not the case then I'd need to look at gitolite itself to > > > see how it calls the other binaries it expects to be available, and if > > > wrapping it would be enough or if we would need to just propagate the > > > other packages for functionality. > > > > Gitolite simply expects tools like git to be on $PATH. It's a pretty > > naive system, there's nothing like a configure script that is > > determining the absolute file name of these tools and substituting > > those names into the built files. > > > > The executable is already wrapped so that coreutils, findutils, and > > git are on $PATH, but notably not openssh: > > > > (add-after 'install 'wrap-scripts > > (lambda* (#:key inputs outputs #:allow-other-keys) > > (let ((out (assoc-ref outputs "out")) > > (coreutils (assoc-ref inputs "coreutils")) > > (findutils (assoc-ref inputs "findutils")) > > (git (assoc-ref inputs "git"))) > > (wrap-program (string-append out "/bin/gitolite") > > `("PATH" ":" prefix > > ,(map (lambda (dir) > > (string-append dir "/bin")) > > (list out coreutils findutils git))))))) > > > > However, git and openssh are still propagated inputs. I'm going to > > move the propagated inputs to regular inputs, potentially add openssh > > to the wrapper once I remind myself what gitolite does with those > > tools, and test it all out on my server using the gitolite service. > > If that all works, we have a good starting point for adding extension > > support in the service. > > I like it. Let us know how it goes. The problem is that gitolite generates git hooks for the repositories that it manages, and those hooks invoke git, so the only way those scripts will be able to work (without input propagation) is to find a way to inject the proper PATH or find a way to replace references to things like 'git diff' with '/gnu/store/.../git diff'. I'm going to keep exploring and report back when I have something to show. - Dave From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 02 15:58:30 2022 Received: (at 25957) by debbugs.gnu.org; 2 Sep 2022 19:58:31 +0000 Received: from localhost ([127.0.0.1]:40458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUCoA-0002hk-6P for submit@debbugs.gnu.org; Fri, 02 Sep 2022 15:58:30 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:40847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUCo7-0002hV-Dl for 25957@debbugs.gnu.org; Fri, 02 Sep 2022 15:58:28 -0400 Received: by mail-lf1-f42.google.com with SMTP id bq23so4748014lfb.7 for <25957@debbugs.gnu.org>; Fri, 02 Sep 2022 12:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=KQ1Zw8Grw7BhNjWYhipUKTQhLTxtH1UoRvXr7kvStbE=; b=v3ry7E6XHsaGjKyBlfCOxjAvuhZ18wOfeRgft8efYRmL4sSHOtc/E/Sjnq+f/CQ7fd PjQJWtNZUXr5ufV8fTOIeHz/a1KIjOlms2D6rlaXQAlsxb7iE8VwcaamZnPSmPA1HVbw aEmNBgC9xifk0n6+n3j+zknoKE9nJkVd4ibr81vz/ButpoF1VEJEHMPDICVy1MObTljm bO+iag5WRF8YRlNWC5zc6FSyAn4iODBQ3NGHJStB6ce93zfHIF1F97CoyFiTbJv94yVm QibVrztVdrotDvLDLb1tYogZ/wrtskSVOjz2xzF4qctKFeqgPaJZdgDeTTPSkJ5n+SR3 lIKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=KQ1Zw8Grw7BhNjWYhipUKTQhLTxtH1UoRvXr7kvStbE=; b=g79E2PeD9MQ0zTJsKsSTMlRsV17JYm+tXun8TEYgpXeyUE2VZyIoFUPOx2Nv75mInE /MhC17zjMSM6olSjZSmpFnFU7HAdvcFS2RummR8tY5WLxl0z3WeTONVkEJC+ICRqtv8y n1q9bI3D0Rd8QioiTcXvB+QEIYoehxEhboKN5eBXlmjwDhYXk8dlUJ4qr+SRDqYj3OG9 q3BsRoyhnD0EbWcUVsh8My2MwEoithP9Isn1M7QxtjbiSN8jvvRow8Nyj5RVpTtEy10s so6GkuitLP28U49E3HgoikXsUJq6QDKaa3F6gg1IbRFUEC7hFE6oG2wc38n5XaL5TWvj iASg== X-Gm-Message-State: ACgBeo1nGViwBUMkIjoCWSIphcRBjc/Sq0O0ExEoNErr7KNj3w3dJSg9 mrjZRnPCqemL1T0g1+jbKFe+vLT6fe1gsmlWiMOGLA== X-Google-Smtp-Source: AA6agR4s6H2Yuv//nEYwaJaa8Xq6ECIkRMeRN8GkRkIq+s2oRcQp1Pdm0+1R+gbL/R/UjjGsJyp6+PiYXWrOeUFiwzE= X-Received: by 2002:a05:6512:b12:b0:492:daa9:75ea with SMTP id w18-20020a0565120b1200b00492daa975eamr14479476lfu.297.1662148701228; Fri, 02 Sep 2022 12:58:21 -0700 (PDT) MIME-Version: 1.0 References: <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> In-Reply-To: From: "Thompson, David" Date: Fri, 2 Sep 2022 15:58:09 -0400 Message-ID: Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: Efraim Flashner , "Thompson, David" , zimoun , 25957@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000e6dad605e7b7261a" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e6dad605e7b7261a Content-Type: text/plain; charset="UTF-8" On Fri, Sep 2, 2022 at 8:50 AM Thompson, David wrote: > > On Fri, Sep 2, 2022 at 8:44 AM Efraim Flashner wrote: > > > > On Fri, Sep 02, 2022 at 07:11:54AM -0400, Thompson, David wrote: > > > On Fri, Sep 2, 2022 at 3:00 AM Efraim Flashner wrote: > > > > > > > > I took a look at the gitolite service finally and I hadn't realized > > > > there wasn't a running daemon to containerize. I assumed we could do > > > > something like: > > > > > > > > (start $~(make-forkexec-constructor/container > > > > (list ...) > > > > #:environment-variables > > > > '("PATH=...") > > > > #:mappings ...)) > > > > > > > > Given that's not the case then I'd need to look at gitolite itself to > > > > see how it calls the other binaries it expects to be available, and if > > > > wrapping it would be enough or if we would need to just propagate the > > > > other packages for functionality. > > > > > > Gitolite simply expects tools like git to be on $PATH. It's a pretty > > > naive system, there's nothing like a configure script that is > > > determining the absolute file name of these tools and substituting > > > those names into the built files. > > > > > > The executable is already wrapped so that coreutils, findutils, and > > > git are on $PATH, but notably not openssh: > > > > > > (add-after 'install 'wrap-scripts > > > (lambda* (#:key inputs outputs #:allow-other-keys) > > > (let ((out (assoc-ref outputs "out")) > > > (coreutils (assoc-ref inputs "coreutils")) > > > (findutils (assoc-ref inputs "findutils")) > > > (git (assoc-ref inputs "git"))) > > > (wrap-program (string-append out "/bin/gitolite") > > > `("PATH" ":" prefix > > > ,(map (lambda (dir) > > > (string-append dir "/bin")) > > > (list out coreutils findutils git))))))) > > > > > > However, git and openssh are still propagated inputs. I'm going to > > > move the propagated inputs to regular inputs, potentially add openssh > > > to the wrapper once I remind myself what gitolite does with those > > > tools, and test it all out on my server using the gitolite service. > > > If that all works, we have a good starting point for adding extension > > > support in the service. > > > > I like it. Let us know how it goes. > > The problem is that gitolite generates git hooks for the repositories > that it manages, and those hooks invoke git, so the only way those > scripts will be able to work (without input propagation) is to find a > way to inject the proper PATH or find a way to replace references to > things like 'git diff' with '/gnu/store/.../git diff'. I'm going to > keep exploring and report back when I have something to show. After several rounds of experimentation and breaking my git server a few times, here's what I've found: * Changing git and openssh to be regular inputs and wrapping both gitolite and gitolite-shell with a $PATH that contains git works and it's very little extra code. * Trying to replace every invocation of a git command took a lot of grepping and crafting of regexps to use for substitute* and I never got to a point where the result wasn't buggy. In particular, gitolite-shell never worked properly so I couldn't push to my repos. So, I think the simple wrapper approach is the way to go. Patch attached. I tested on my git server by making changes to my gitolite configuration and pushing those changes to the special gitolite-admin repo. This causes gitolite to refresh internal configuration using a git hook, so I know that hooks can find the executables they need. That plus the 'gitolite setup' invocation made by the service activation script covers a fair amount of surface area, so I feel comfortable committing it. What do you think? Once this part is done, I'll turn my attention to the optional extensions. - Dave --000000000000e6dad605e7b7261a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-gitolite-Wrap-programs-instead-of-using-propagat.patch" Content-Disposition: attachment; filename="0001-gnu-gitolite-Wrap-programs-instead-of-using-propagat.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l7kw9jmj0 RnJvbSA0MTNmMmQyOGFhOGJlYTIyNzRiNzRjMmI1NzRmYjlmOGJmOWMxNmJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBUaG9tcHNvbiA8ZHRob21wc29uMkB3b3JjZXN0ZXIu ZWR1PgpEYXRlOiBGcmksIDIgU2VwIDIwMjIgMTQ6MzM6MDEgLTA0MDAKU3ViamVjdDogW1BBVENI XSBnbnU6IGdpdG9saXRlOiBXcmFwIHByb2dyYW1zIGluc3RlYWQgb2YgdXNpbmcgcHJvcGFnYXRl ZAogaW5wdXRzLgoKKiBnbnUvcGFja2FnZXMvdmVyc2lvbi1jb250cm9sLnNjbSAoZ2l0b2xpdGUp W2FyZ3VtZW50c106IEFkZCBnaXQgdG8gd3JhcHBlZAokUEFUSCBhbmQgYWRkaXRpb25hbGx5IHdy YXAgZ2l0b2xpdGUtc2hlbGwuCltpbnB1dHNdOiBBZGQgZ2l0IGFuZCBvcGVuc3NoLgpbcHJvcGFn YXRlZC1pbnB1dHNdOiBSZW1vdmUgaXQuCi0tLQogZ251L3BhY2thZ2VzL3ZlcnNpb24tY29udHJv bC5zY20gfCAxOCArKysrKysrKy0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlv bnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy92ZXJzaW9u LWNvbnRyb2wuc2NtIGIvZ251L3BhY2thZ2VzL3ZlcnNpb24tY29udHJvbC5zY20KaW5kZXggMTVh OTI3OGZlOC4uMWM3NzU5MzJjMCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL3ZlcnNpb24tY29u dHJvbC5zY20KKysrIGIvZ251L3BhY2thZ2VzL3ZlcnNpb24tY29udHJvbC5zY20KQEAgLTE1NzMs MTcgKzE1NzMsMTUgQEAgKGRlZmluZS1wdWJsaWMgZ2l0b2xpdGUKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoY29yZXV0aWxzIChhc3NvYy1yZWYgaW5wdXRzICJjb3JldXRpbHMiKSkKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoZmluZHV0aWxzIChhc3NvYy1yZWYgaW5wdXRzICJm aW5kdXRpbHMiKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZ2l0IChhc3NvYy1yZWYg aW5wdXRzICJnaXQiKSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAod3JhcC1wcm9ncmFtIChz dHJpbmctYXBwZW5kIG91dCAiL2Jpbi9naXRvbGl0ZSIpCi0gICAgICAgICAgICAgICAgICAgICAg ICAgIGAoIlBBVEgiICI6IiBwcmVmaXgKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAsKG1h cCAobGFtYmRhIChkaXIpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3Ry aW5nLWFwcGVuZCBkaXIgIi9iaW4iKSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAobGlzdCBvdXQgY29yZXV0aWxzIGZpbmR1dGlscyBnaXQpKSkpKSkpKSkpCisgICAgICAgICAg ICAgICAgICAgICAgICAoZm9yLWVhY2ggKGxhbWJkYSAoZmlsZS1uYW1lKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKHdyYXAtcHJvZ3JhbSAoc3RyaW5nLWFwcGVuZCBvdXQg ZmlsZS1uYW1lKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBgKCJQQVRI IiAiOiIgcHJlZml4CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLCht YXAgKGxhbWJkYSAoZGlyKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKHN0cmluZy1hcHBlbmQgZGlyICIvYmluIikpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxpc3Qgb3V0IGNvcmV1dGlscyBmaW5kdXRpbHMg Z2l0KSkpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnKCIvYmluL2dpdG9s aXRlIiAiL2Jpbi9naXRvbGl0ZS1zaGVsbCIpKSkpKSkpKQogICAgIChpbnB1dHMKLSAgICAgKGxp c3QgYmFzaC1taW5pbWFsIHBlcmwgY29yZXV0aWxzIGZpbmR1dGlscyBpbmV0dXRpbHMpKQotICAg IDs7IGdpdCBhbmQgb3BlbnNzaCBhcmUgcHJvcGFnYXRlZCBiZWNhdXNlIHRyeWluZyB0byBwYXRj aCB0aGUgc291cmNlIHZpYQotICAgIDs7IHJlZ2V4cCBtYXRjaGluZyBpcyB0b28gYnJpdHRsZSBh bmQgcHJvbmUgdG8gZmFsc2UgcG9zaXRpdmVzLgotICAgIChwcm9wYWdhdGVkLWlucHV0cwotICAg ICAobGlzdCBnaXQgb3BlbnNzaCkpCisgICAgIChsaXN0IGJhc2gtbWluaW1hbCBnaXQgcGVybCBj b3JldXRpbHMgZmluZHV0aWxzIGluZXR1dGlscyBvcGVuc3NoKSkKICAgICAoaG9tZS1wYWdlICJo dHRwczovL2dpdG9saXRlLmNvbSIpCiAgICAgKHN5bm9wc2lzICJHaXQgYWNjZXNzIGNvbnRyb2wg bGF5ZXIiKQogICAgIChkZXNjcmlwdGlvbgotLSAKMi4zNy4yCgo= --000000000000e6dad605e7b7261a-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 04 03:26:18 2022 Received: (at 25957) by debbugs.gnu.org; 4 Sep 2022 07:26:18 +0000 Received: from localhost ([127.0.0.1]:43373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUk1J-0001nZ-Ig for submit@debbugs.gnu.org; Sun, 04 Sep 2022 03:26:18 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:41957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUk1I-0001nM-0P for 25957@debbugs.gnu.org; Sun, 04 Sep 2022 03:26:16 -0400 Received: by mail-wm1-f41.google.com with SMTP id az24-20020a05600c601800b003a842e4983cso4066904wmb.0 for <25957@debbugs.gnu.org>; Sun, 04 Sep 2022 00:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date; bh=NcKcp9oy4CiKREX7qxBAeU7RYZPiY+I1iHNyEtllPbo=; b=ZFkRFP1ZEq2MdpctLLtflIsLCxxLx0GMy50C24UdtwOPqMkYZ8JLf7zK7igIEi3GmK OasMQrw/ezx3ojSODshrZ6YrIAnghy0fNMmE06CS+FkARaO2aOjrTfUxXtTXCl2rn68O WENRyibD6G8800Ny99yWMtdmF504ZyITnOWNV2HI45ouz5CQaA5bcBTTppQcZ5Iz0uXf gcLBJPU09nmU9tSLdInKV9ADM0CSVdug9bqWenna4EHFFmTtJF8Wo7ciU7OpleLjbGak 51r50FUk0FuTckEGI322BykNX27THyx5u8BdnZnd1gNvshbS5Evm/mq4U7tWelfu13kO xXgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date; bh=NcKcp9oy4CiKREX7qxBAeU7RYZPiY+I1iHNyEtllPbo=; b=tcT+RgE53xyKcJUuVXP4ZQKFSH+egDfr84/IpjcLGvmDDmmpZlEgy8HAxLKQevznq7 hGIJZQarvHUOL/E48jVFBPqV8mmFV6UrGWtTTCHL8JsbHMMPo0B2v5PYXJLmeFevXk0I euMfuHMIWNnp7m50GCQUChNVKYhBCOkBlbFT0xCpZ6nuZ8A0K57GDBvAg6ufqmrSy1+L zPNLTCmUdJoF+HP4DDGqNUuPTVw3mvH90qq5aPuAe9bsq5qjwgEBc15eRzqmpsRDfn36 Kxzh+hRXeziqDIqvx6ioMzkO42SCJYBwisqYLUFXnuj7DQmc+15Y36Fpp0mH5FkLzR3Y uqbw== X-Gm-Message-State: ACgBeo2lS/YDwWUQQ9JRQbPgr1N5DNhSwUbZz5VNJQRCKxLcaOkwOd7d muKmU1Eza8dYmRFkvRMLmR0= X-Google-Smtp-Source: AA6agR6o0nTKb2j24UTUL0DeLwURy2NvCWZR13qzSMF+mToY/wFd/7pC+FX+T8sM/Qm9l0lFFSUzWQ== X-Received: by 2002:a05:600c:512a:b0:3a8:42e4:dfe7 with SMTP id o42-20020a05600c512a00b003a842e4dfe7mr7755073wms.193.1662276370010; Sun, 04 Sep 2022 00:26:10 -0700 (PDT) Received: from localhost ([141.226.13.1]) by smtp.gmail.com with ESMTPSA id p4-20020a5d48c4000000b00225239d9265sm5395304wrs.74.2022.09.04.00.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Sep 2022 00:26:09 -0700 (PDT) Date: Sun, 4 Sep 2022 10:26:05 +0300 From: Efraim Flashner To: "Thompson, David" Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Message-ID: Mail-Followup-To: Efraim Flashner , "Thompson, David" , zimoun , 25957@debbugs.gnu.org References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZOQ06voTJckLO9TV" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --ZOQ06voTJckLO9TV Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 02, 2022 at 03:58:09PM -0400, Thompson, David wrote: > On Fri, Sep 2, 2022 at 8:50 AM Thompson, David = wrote: > > > > On Fri, Sep 2, 2022 at 8:44 AM Efraim Flashner = wrote: > > > > > > On Fri, Sep 02, 2022 at 07:11:54AM -0400, Thompson, David wrote: > > > > On Fri, Sep 2, 2022 at 3:00 AM Efraim Flashner wrote: > > > > > > > > > > I took a look at the gitolite service finally and I hadn't realiz= ed > > > > > there wasn't a running daemon to containerize. I assumed we could= do > > > > > something like: > > > > > > > > > > (start $~(make-forkexec-constructor/container > > > > > (list ...) > > > > > #:environment-variables > > > > > '("PATH=3D...") > > > > > #:mappings ...)) > > > > > > > > > > Given that's not the case then I'd need to look at gitolite itsel= f to > > > > > see how it calls the other binaries it expects to be available, a= nd if > > > > > wrapping it would be enough or if we would need to just propagate= the > > > > > other packages for functionality. > > > > > > > > Gitolite simply expects tools like git to be on $PATH. It's a pret= ty > > > > naive system, there's nothing like a configure script that is > > > > determining the absolute file name of these tools and substituting > > > > those names into the built files. > > > > > > > > The executable is already wrapped so that coreutils, findutils, and > > > > git are on $PATH, but notably not openssh: > > > > > > > > (add-after 'install 'wrap-scripts > > > > (lambda* (#:key inputs outputs #:allow-other-ke= ys) > > > > (let ((out (assoc-ref outputs "out")) > > > > (coreutils (assoc-ref inputs "coreutils= ")) > > > > (findutils (assoc-ref inputs "findutils= ")) > > > > (git (assoc-ref inputs "git"))) > > > > (wrap-program (string-append out "/bin/gito= lite") > > > > `("PATH" ":" prefix > > > > ,(map (lambda (dir) > > > > (string-append dir "/bin")) > > > > (list out coreutils findutils git= ))))))) > > > > > > > > However, git and openssh are still propagated inputs. I'm going to > > > > move the propagated inputs to regular inputs, potentially add opens= sh > > > > to the wrapper once I remind myself what gitolite does with those > > > > tools, and test it all out on my server using the gitolite service. > > > > If that all works, we have a good starting point for adding extensi= on > > > > support in the service. > > > > > > I like it. Let us know how it goes. > > > > The problem is that gitolite generates git hooks for the repositories > > that it manages, and those hooks invoke git, so the only way those > > scripts will be able to work (without input propagation) is to find a > > way to inject the proper PATH or find a way to replace references to > > things like 'git diff' with '/gnu/store/.../git diff'. I'm going to > > keep exploring and report back when I have something to show. >=20 > After several rounds of experimentation and breaking my git server a > few times, here's what I've found: >=20 > * Changing git and openssh to be regular inputs and wrapping both > gitolite and gitolite-shell with a $PATH that contains git works and > it's very little extra code. >=20 > * Trying to replace every invocation of a git command took a lot of > grepping and crafting of regexps to use for substitute* and I never > got to a point where the result wasn't buggy. In particular, > gitolite-shell never worked properly so I couldn't push to my repos. >=20 > So, I think the simple wrapper approach is the way to go. Patch > attached. I tested on my git server by making changes to my gitolite > configuration and pushing those changes to the special gitolite-admin > repo. This causes gitolite to refresh internal configuration using a > git hook, so I know that hooks can find the executables they need. > That plus the 'gitolite setup' invocation made by the service > activation script covers a fair amount of surface area, so I feel > comfortable committing it. What do you think? >=20 > Once this part is done, I'll turn my attention to the optional extensions. Overall it looks good to me. I was going to ask about inetutils and openssh since they're not wrapping the binaries but I see their paths are substituted in the 'patch-source phase. LGTM! > From 413f2d28aa8bea2274b74c2b574fb9f8bf9c16ba Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Fri, 2 Sep 2022 14:33:01 -0400 > Subject: [PATCH] gnu: gitolite: Wrap programs instead of using propagated > inputs. >=20 > * gnu/packages/version-control.scm (gitolite)[arguments]: Add git to wrap= ped > $PATH and additionally wrap gitolite-shell. > [inputs]: Add git and openssh. > [propagated-inputs]: Remove it. > --- > gnu/packages/version-control.scm | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) >=20 > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-cont= rol.scm > index 15a9278fe8..1c775932c0 100644 > --- a/gnu/packages/version-control.scm > +++ b/gnu/packages/version-control.scm > @@ -1573,17 +1573,15 @@ (define-public gitolite > (coreutils (assoc-ref inputs "coreutils")) > (findutils (assoc-ref inputs "findutils")) > (git (assoc-ref inputs "git"))) > - (wrap-program (string-append out "/bin/gitolite") > - `("PATH" ":" prefix > - ,(map (lambda (dir) > - (string-append dir "/bin")) > - (list out coreutils findutils git)))))= ))))) > + (for-each (lambda (file-name) > + (wrap-program (string-append out fil= e-name) > + `("PATH" ":" prefix > + ,(map (lambda (dir) > + (string-append dir "/bin= ")) > + (list out coreutils findut= ils git))))) > + '("/bin/gitolite" "/bin/gitolite-shell= ")))))))) > (inputs > - (list bash-minimal perl coreutils findutils inetutils)) > - ;; git and openssh are propagated because trying to patch the source= via > - ;; regexp matching is too brittle and prone to false positives. > - (propagated-inputs > - (list git openssh)) > + (list bash-minimal git perl coreutils findutils inetutils openssh)) > (home-page "https://gitolite.com") > (synopsis "Git access control layer") > (description > --=20 > 2.37.2 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --ZOQ06voTJckLO9TV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmMUUwsACgkQQarn3Mo9 g1Ef8RAAuMXGFn56TZp8H76L63LFDVLuQZi/Q9MXuDefXeiENlZZtkM5kSQJjw0f nPepnVBKNWiFyqMMTT+Dq+ag15oCZLebaYysMvUJGnTOraN1bi7vmLpqySuA5OQU Da3EKXuLbFXrOUR8X13H0/R4ZQSPBIqY3NTtmFX5R9f1qGAadbACDibZch4yJ2i6 YafXWw4N2cd/3irSMOwVtkLUO/rH96m/kgpqxay8mPrfS4PvFICCaa+7w4kl23ga pPjp0S+yjb7UUIRyUYaus0Gy/4YgGtzFVLgO7c15YNQk0JxQShdlJjwnHXv0ITGz uK2//1SlvVgwnYSZAZAW8NQ6QzGgRMc2yOOtQn//m9xlYHi4mzZhI7Z9XfGonlbc 8DDXfDzsTdTVQRGtVrgMpdZ4A23iUDYlWnTy36HIgZ0+WEqgVZoO57Bqchfe9qCW a1LPIEKGTkE0FknSU3f2YNjOQAVDieqWXyx4lVGMwNTiBYxZ0eAYyvK9IPfnK7PO UXgaXW2GDzKYBiByUvIITiWF74MX0wvE2Q5Iil3yFjp7VduJYgJxP4VwK6hoBAGm 3UzrWdArDIJG7AUNnH2Zs+zp/lrsKB+4+Pa6sed33oEyg/tF6CMVFkqjtizV561v IxA/DFGijQ0ns41Rp1B2uBy8tmMJOZ6Tf+Y9tPPzr6MkHy4E2xM= =jLTU -----END PGP SIGNATURE----- --ZOQ06voTJckLO9TV-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 04 09:26:47 2022 Received: (at 25957) by debbugs.gnu.org; 4 Sep 2022 13:26:47 +0000 Received: from localhost ([127.0.0.1]:43690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUpeB-0000cl-4T for submit@debbugs.gnu.org; Sun, 04 Sep 2022 09:26:47 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:41904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUpe9-0000cX-Hl for 25957@debbugs.gnu.org; Sun, 04 Sep 2022 09:26:46 -0400 Received: by mail-lf1-f52.google.com with SMTP id m7so9730496lfq.8 for <25957@debbugs.gnu.org>; Sun, 04 Sep 2022 06:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=Js66OQAbzo50O0oqOz1KSTAYCigCZQkokfhnuzykUWA=; b=kDFSgAivfkNE+n4/pnwaEv9JTNdff3G0UHI3vE3dxOQCtuamqtpL4Xv+zI/5BktdSp cG1Kl2KU72gCFR0Qpy4abBZ9vva+q2DOb2jY2fFPjOqWnlLPDDIOXbfX3VAQUgLicAzD BW8I+NiHlcC7NU7WheHT2SHIV5XO/XxCwO9ht94cvIUi/FiyJVjJuJ03NCWjLo8Er0u2 YyVPZ8/wm0N2uq1XegGIMuQ4U4oWWQScpJrmLGmFPo/Bou4x+5mKf6oedpyzzjQM7VTP fs+JQ8G0kQ8YsO0olKL0JrLFGp8GadLWyac7WJGjjpcmJp5Ui4N+q0ugjn10CbXMF1AK JVhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=Js66OQAbzo50O0oqOz1KSTAYCigCZQkokfhnuzykUWA=; b=Y8d/kWGbDV4BP8or3dzSP8u3w8V86h3RHDiE0ukt1ewBE8pJdTOhHMaElrUTwTdQqK o/PFug40oh8AM82rQFEKIz4bvz+FlHYdQM5gHCoxZaJL5e5q0H1luHfUE/682g6+CJXu VRPAT20JNByRkvU5SsudKinG+5CR6pJtcvY+Y0x16SBi6KTcdanaR1Dj6CNIoxs2dznG rEldU3KunCFLCfwtKwDLF4m4vEx/sZo0nVgR20mOa1kig+lv6YvDq8qRmLih+1SQHmRq GcTFop7mAJ2X4zh6JG+agKZN7jtOgAqOXpmJmVB+ItDsjxbfsvLvM546GsAMx4UNxMYT lV7g== X-Gm-Message-State: ACgBeo1UZR7O7z1uD5n/GxLYBUbbw6UaTw+VsSrR1tm4Rdwk36XwbMFr zflB2VKeli5lDGlo7pCLnAbG6pAjjYS1EMrj9vXoMg== X-Google-Smtp-Source: AA6agR6jLrqaW7iVFl8tDCghuju5xCL6MM7Od1oK05j8PRTPb82HDlEx3VDzIH98upnMZ8bkY7gEr1cqoOZWP5HMz98= X-Received: by 2002:a05:6512:b24:b0:494:70c4:c2a1 with SMTP id w36-20020a0565120b2400b0049470c4c2a1mr10268053lfu.79.1662297999461; Sun, 04 Sep 2022 06:26:39 -0700 (PDT) MIME-Version: 1.0 References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> In-Reply-To: From: "Thompson, David" Date: Sun, 4 Sep 2022 09:26:28 -0400 Message-ID: Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: Efraim Flashner , "Thompson, David" , zimoun , 25957@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Efraim, On Sun, Sep 4, 2022 at 3:26 AM Efraim Flashner wrote: > > Overall it looks good to me. I was going to ask about inetutils and > openssh since they're not wrapping the binaries but I see their paths > are substituted in the 'patch-source phase. > > LGTM! Thanks! I made one minor tweak to sort the inputs list alphabetically and pushed as commit 1aa46a7e29c5bd892219fe20fefb883d2103e29e. I also pushed a follow-up commit e4ccfcb22ad96e71ca4dfad95af5aa6229ed9869 that swaps out 'git' for 'git-minimal', saving about 75MiB in the package closure. I think, technically speaking, this bug has been resolved. There are no longer /usr/bin, /usr/sbin, etc. references in our gitolite package, so extensions should work as long as the user adds the relevant packages to their user or system profile. I will keep this bug open for the moment, though, since I haven't gotten to the final patch I said I would submit which will make those optional dependencies easy to add via the gitolite service. Stay tuned! - Dave From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 05 05:33:31 2022 Received: (at 25957) by debbugs.gnu.org; 5 Sep 2022 09:33:31 +0000 Received: from localhost ([127.0.0.1]:46443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oV8Tx-0006wA-Og for submit@debbugs.gnu.org; Mon, 05 Sep 2022 05:33:31 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:40936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oV8Tv-0006vu-OG for 25957@debbugs.gnu.org; Mon, 05 Sep 2022 05:33:28 -0400 Received: by mail-wm1-f54.google.com with SMTP id h204-20020a1c21d5000000b003a5b467c3abso7439261wmh.5 for <25957@debbugs.gnu.org>; Mon, 05 Sep 2022 02:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date; bh=9YSYo+j9MVZjO5IhDPowUzYizJ55Yq3nRaxV0SMTU7U=; b=Hy5IjHaJz0ny+l2Vb9N8ibu9ZMLFoAAuhG4cRz0r+lHl/UKE5+d+zq7+cGBSLbzTtx kt+IwQBfUl6Ndixja0Jo0TrMUztLavY/uL3B2fsPsi/O/mNIQUwsyHRvqjR0bFtW535C oi1yttGuWs1Pv1E3P+TMoO5Q8/ZHJ9XM1B3DvbptgmthNgNl/2kfDlSmk2njaNqQm+OP gJE2GaXyjzTy7E2quLkUmG+6X4XyUcb6zvmVltTaMfc4GY2a/JU+xkv904cjNlot5svC P5OX9oH+2LW7jtnlc0/zHaLZcg1QhUzrpUvG62qypshN+BmCSwf9yky3BpeIr5JKZwOq HtNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=9YSYo+j9MVZjO5IhDPowUzYizJ55Yq3nRaxV0SMTU7U=; b=iVpEyGXkgCzh0ex6DQ1EAEHDl5Xx3rYHp0Z9QB8K0TyLtH2LyV6Q3oAtOMWG/Lwbqg b2523tG+meAFwsdTaql2xsvMJQEcYF8BtvyDEjnO+ugtJmSECvB1gfADMr+Fu4pUBAvk f33c2FD/4/QYeXz2qoeSpFR45bN54hSJ9laxiKsF8wJlRRjq1+XMz1OjIUo+Q7+Pe0TV sb4b4DrThr/5CQtjyJXb/LkDR0BHAbSFVwakMETSCWIOtjDnlPvbpfoKADHq1DVQbzNa calBaCRE0IXoNsKgfzyuTKX7jyb/uZ5bPYy1UG9kVZrFYoFcnlHCgWrMXpB7ERRE8Qlp oyFQ== X-Gm-Message-State: ACgBeo1k0mVIvxiXGbFpJR2FCJ9fF/eSKdJ31uiDvl7oNhuvokrnxcKr /bngiupDPCPWnT+Wa7JnBMDRtYH5F4o= X-Google-Smtp-Source: AA6agR4QqIhDxZlEVIJn3xkHh6/vjO/ly/U+X5b+hV00WT6PklQnSK+De4DTrSoiv6YLgTXA+IPybA== X-Received: by 2002:a05:600c:5114:b0:3a5:cb1f:6bf3 with SMTP id o20-20020a05600c511400b003a5cb1f6bf3mr10307297wms.65.1662370401730; Mon, 05 Sep 2022 02:33:21 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id v64-20020a1cac43000000b003a844885f88sm10701601wme.22.2022.09.05.02.33.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 02:33:21 -0700 (PDT) From: zimoun To: "Thompson, David" , Efraim Flashner , "Thompson, David" , 25957@debbugs.gnu.org Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks In-Reply-To: References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> Date: Mon, 05 Sep 2022 10:16:06 +0200 Message-ID: <871qsqtewp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On dim., 04 sept. 2022 at 09:26, "Thompson, David" wrote: > Thanks! I made one minor tweak to sort the inputs list alphabetically > and pushed as commit 1aa46a7e29c5bd892219fe20fefb883d2103e29e. Cool! > I also pushed a follow-up commit > e4ccfcb22ad96e71ca4dfad95af5aa6229ed9869 that swaps out 'git' for > 'git-minimal', saving about 75MiB in the package closure. Neat! > I think, technically speaking, this bug has been resolved. There are > no longer /usr/bin, /usr/sbin, etc. references in our gitolite > package, so extensions should work as long as the user adds the > relevant packages to their user or system profile. I will keep this > bug open for the moment, though, since I haven't gotten to the final > patch I said I would submit which will make those optional > dependencies easy to add via the gitolite service. Stay tuned! Ok, thanks for almost closing this old bugs. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 06 09:50:46 2022 Received: (at 25957) by debbugs.gnu.org; 6 Sep 2022 13:50:46 +0000 Received: from localhost ([127.0.0.1]:50204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVYyU-0000ub-0D for submit@debbugs.gnu.org; Tue, 06 Sep 2022 09:50:46 -0400 Received: from mail-lf1-f43.google.com ([209.85.167.43]:43751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVYyP-0000uJ-Tw for 25957@debbugs.gnu.org; Tue, 06 Sep 2022 09:50:44 -0400 Received: by mail-lf1-f43.google.com with SMTP id x14so2113914lfu.10 for <25957@debbugs.gnu.org>; Tue, 06 Sep 2022 06:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=bityEsAgYTXX3EyIubCsvfxg/IUAeJE0Yj5RVR6SeD0=; b=6VJVG7alsSyq6v+LJ19vix4T9l8E9Q9oecLCapvZ+8pwURwSnubUuV979QuC+J2l5U QRU7c/6U2e06zXp4zqGYECOLY6iTYlKnP5H7eD1YdrH6rrrVfIG2B4CgwNTMJ3miWzqn R2k+3bFHUwPCgU/mhPfIpz7LEO8uAv3npASC+UnJDbnlArozdfQkB6X0/gfEvMlgXPVz YXsX9fp48BUkx7DDQAuGOLssBY1aKf/V+I2sn1k7sNoZXrCBOYnryMOZAAmcV+7E6FYv T13Fp6jYvlHJz6xM75ierxSbET3GnUpNPcfP8350l90zrK4768zzsW8l7FAjl6kPwan0 51nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=bityEsAgYTXX3EyIubCsvfxg/IUAeJE0Yj5RVR6SeD0=; b=Ya+tMATUmZcOMDjj2YEPDaAxGH5VvBYhF+zPITDYeBFix3qheBEGlt9+PMGKeIGuli POe2pZuBIDQTCIQ4q8wp65OwQMUKUpyhJu5efBA/mgFWUvA5dsFVMD3AxkHy0Bnol1PZ RPHFCSoiEL7LhFW3Bot3v5RwEfVLLwisJknOK6nqrMI3D/aQDDibzVxET7DIRYW6NqGW W+VJAQ+kYGz04DU75xF372IPsKMWKDCj3CewmKRTsWzbT9yyEQtRB9n608COjVSLiyGc Iuj2pRZ2Aa4pnLPwX2YJ5Uc5EtsgZv3ZJbVJVR0U12UA4MlVH5+Ieu5hLYPY+Q2g0+J3 adpg== X-Gm-Message-State: ACgBeo2gOrCtWko/a0q8Bs4DK+mv2OLrpKfYJyp7GMC3eoulYfEVVtJU C1D/RbXTigjwtq1q8hlcZfs29RbBeN0gGkkQwSz/7w== X-Google-Smtp-Source: AA6agR4ZncjYwqTQjqlkNOK9u4IQpHMAdarwLNknl0QFMpCkdtHohtlyIgjA/VU1o8v9rvPwMbfaSiTnP9ubgVwSAiE= X-Received: by 2002:a05:6512:1091:b0:494:9ceb:90b0 with SMTP id j17-20020a056512109100b004949ceb90b0mr7715149lfg.502.1662472235829; Tue, 06 Sep 2022 06:50:35 -0700 (PDT) MIME-Version: 1.0 References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> <871qsqtewp.fsf@gmail.com> In-Reply-To: <871qsqtewp.fsf@gmail.com> From: "Thompson, David" Date: Tue, 6 Sep 2022 09:50:24 -0400 Message-ID: Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: zimoun Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: Efraim Flashner , 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Sep 5, 2022 at 5:33 AM zimoun wrote: > > > I also pushed a follow-up commit > > e4ccfcb22ad96e71ca4dfad95af5aa6229ed9869 that swaps out 'git' for > > 'git-minimal', saving about 75MiB in the package closure. > > Neat! Unfortunately, it was so neat that it broke the system test for the gitolite service so I had to revert it. - Dave From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 06 09:26:58 2022 Received: (at 25957) by debbugs.gnu.org; 6 Oct 2022 13:26:58 +0000 Received: from localhost ([127.0.0.1]:59402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogQtu-00074s-52 for submit@debbugs.gnu.org; Thu, 06 Oct 2022 09:26:58 -0400 Received: from mail-lj1-f178.google.com ([209.85.208.178]:45869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogQtr-00074b-Qd for 25957@debbugs.gnu.org; Thu, 06 Oct 2022 09:26:57 -0400 Received: by mail-lj1-f178.google.com with SMTP id f9so2194270ljk.12 for <25957@debbugs.gnu.org>; Thu, 06 Oct 2022 06:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uCYmuAw+4wWs7QbXTqYkskCSNh1IzuAyE7AqPJQAkr4=; b=j9zG/HrLa38aN8tdR1b/s5rmBdx1Xz0BAW2qdeEueemzZorOka2/tBeqUqCro+X3eS 9rVT46Fiu5/Y6kzjgAj7BKFjkk2GZiHuYx+c5FSvOT6+azNuF+QVESjVaquT2G39mHnd SpXyMrzt4iSXwdIc9n8CLXevfNcV6TwlBhZIqoYSdLXduULL3gcaxgpWORlgXxgDHWCr M7hDDijKYoQMFTdoYwHm6CsIKU5JY75JARYyGpsPzZQg/KYIqMW2W9Ac6xVrOzgzbdHy rOT9a1WUlTiBRY7umK46jHqVQLioTJrz0MhTPk06zdJ+JDes5cOHFOTlk4QpWU9D/5/J 4V6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uCYmuAw+4wWs7QbXTqYkskCSNh1IzuAyE7AqPJQAkr4=; b=OuHPgp6FH6gRijuckbEiYEDd7ZezvTaO51E9K+Wk8kPBSRnUp62xEIEUXoxC6lR5pz ki+cIjvxIEiOwwsUrzfsl/xShneVpHuy+5oq7qA6oZlwa5cc1oUNEO18va5suyyJThGd kNqBOdPfBQD06vzXM1SkWOfAhZFvF2XdGMCeP7rtJKafsDS6kBtzKFxlDARMBuD62kcc 0dyBtRzz104Q27DS35ARhC7+r2SxzR+txdMMn39eWNi9zk4BujTpKJT6FvfTibjsXGk6 7SvS/KX8vvxg2amz6aVM/kIDWSTJjfO4RPIeeg5U+oUXuxvf/hDXYDtRBGYz99k7BVUD B3pA== X-Gm-Message-State: ACrzQf0Q3CF6fNjqOgGsLi4RhC3AVVCjV2pDuwMnM3D6dUzZSnVH8fkJ pKgzmkuUNmrPzaX0E8Dp3BL98KzQg/ivZ7rm88djZw== X-Google-Smtp-Source: AMsMyM6w39opIqhsP5cRTo+6vttbJ+5jfnXGwhWaZhMXeoQjtFWxYDIqedTNR4h4ALktezKMb4+gB0MKVImLqll8c54= X-Received: by 2002:a05:651c:1548:b0:26c:61b3:7129 with SMTP id y8-20020a05651c154800b0026c61b37129mr1635342ljp.381.1665062809688; Thu, 06 Oct 2022 06:26:49 -0700 (PDT) MIME-Version: 1.0 References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> <871qsqtewp.fsf@gmail.com> In-Reply-To: <871qsqtewp.fsf@gmail.com> From: "Thompson, David" Date: Thu, 6 Oct 2022 09:26:38 -0400 Message-ID: Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: zimoun Content-Type: multipart/mixed; boundary="0000000000004d05d505ea5da530" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: Efraim Flashner , 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000004d05d505ea5da530 Content-Type: text/plain; charset="UTF-8" Hello again Simon and Efraim, On Mon, Sep 5, 2022 at 5:33 AM zimoun wrote: > > Hi, > > On dim., 04 sept. 2022 at 09:26, "Thompson, David" wrote: > > > Thanks! I made one minor tweak to sort the inputs list alphabetically > > and pushed as commit 1aa46a7e29c5bd892219fe20fefb883d2103e29e. > > Cool! > > > I also pushed a follow-up commit > > e4ccfcb22ad96e71ca4dfad95af5aa6229ed9869 that swaps out 'git' for > > 'git-minimal', saving about 75MiB in the package closure. > > Neat! > > > I think, technically speaking, this bug has been resolved. There are > > no longer /usr/bin, /usr/sbin, etc. references in our gitolite > > package, so extensions should work as long as the user adds the > > relevant packages to their user or system profile. I will keep this > > bug open for the moment, though, since I haven't gotten to the final > > patch I said I would submit which will make those optional > > dependencies easy to add via the gitolite service. Stay tuned! > > Ok, thanks for almost closing this old bugs. :-) Some news: I have updated the gitolite package to use G-expressions. The package builds and the gitolite system test passes so I pushed that change to master a little while ago. That patch has made the (hopefully) final step in this saga easier. The attached patch introduces a 'make-gitolite' procedure that can be used to add arbitrary packages to the wrappers for the gitolite and gitolite-shell programs. The return value of this procedure can be used in the gitolite service configuration to enable the desired optional features like Redis or git-annex. The base package inputs are unchanged and the gitolite system test still passes. What do you think? - Dave --0000000000004d05d505ea5da530 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-version-control-Add-make-gitolite-procedure.patch" Content-Disposition: attachment; filename="0001-gnu-version-control-Add-make-gitolite-procedure.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8x3byzk0 RnJvbSAzZjNlMmQwMDJjYjhjNzQwMDgxZDU4ZTgzYjZlODkyMzZkMTFmMTVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBUaG9tcHNvbiA8ZHRob21wc29uMkB3b3JjZXN0ZXIu ZWR1PgpEYXRlOiBUaHUsIDYgT2N0IDIwMjIgMDg6NDU6NDggLTA0MDAKU3ViamVjdDogW1BBVENI XSBnbnU6IHZlcnNpb24tY29udHJvbDogQWRkIG1ha2UtZ2l0b2xpdGUgcHJvY2VkdXJlLgoKKiBn bnUvcGFja2FnZXMvdmVyc2lvbi1jb250cm9sLnNjbSAobWFrZS1naXRvbGl0ZSk6IE5ldyBwcm9j ZWR1cmUuCihnaXRvbGl0ZSk6IFVzZSBtYWtlLWdpdG9saXRlLgoqIGRvYy9ndWl4LnRleGkgKEdp dG9saXRlIHNlcnZpY2UpOiBEb2N1bWVudCBob3cgdG8gdXNlIG1ha2UtZ2l0b2xpdGUuCi0tLQog ZG9jL2d1aXgudGV4aSAgICAgICAgICAgICAgICAgICAgfCAxNSArKysrKysrKysrKysrKy0KIGdu dS9wYWNrYWdlcy92ZXJzaW9uLWNvbnRyb2wuc2NtIHwgMTUgKysrKysrKysrKystLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZG9jL2d1aXgudGV4aSBiL2RvYy9ndWl4LnRleGkKaW5kZXggNTIzNzExYmRmNi4uNTMzYjEy ZDczOCAxMDA2NDQKLS0tIGEvZG9jL2d1aXgudGV4aQorKysgYi9kb2MvZ3VpeC50ZXhpCkBAIC0z NTI4NSw3ICszNTI4NSwyMCBAQCBEYXRhIHR5cGUgcmVwcmVzZW50aW5nIHRoZSBjb25maWd1cmF0 aW9uIGZvciBAY29kZXtnaXRvbGl0ZS1zZXJ2aWNlLXR5cGV9LgogCiBAdGFibGUgQGFzaXMKIEBp dGVtIEBjb2Rle3BhY2thZ2V9IChkZWZhdWx0OiBAdmFye2dpdG9saXRlfSkKLUdpdG9saXRlIHBh Y2thZ2UgdG8gdXNlLgorR2l0b2xpdGUgcGFja2FnZSB0byB1c2UuICBUaGVyZSBhcmUgb3B0aW9u YWwgR2l0b2xpdGUgZGVwZW5kZW5jaWVzIHRoYXQKK2FyZSBub3QgaW5jbHVkZWQgaW4gdGhlIGRl ZmF1bHQgcGFja2FnZSwgc3VjaCBhcyBSZWRpcyBhbmQgZ2l0LWFubmV4LgorVGhlc2UgZmVhdHVy ZXMgY2FuIGJlIG1hZGUgYXZhaWxhYmxlIGJ5IHVzaW5nIHRoZSBAY29kZXttYWtlLWdpdG9saXRl fQorcHJvY2VkdXJlIGluIHRoZSBAY29kZXsoZ251IHBhY2thZ2VzIHZlcnNpb24tY29udHJvbH0p IG1vZHVsZSB0byBwcm9kdWNlCithIHZhcmlhbnQgb2YgR2l0b2xpdGUgd2l0aCB0aGUgZGVzaXJl ZCBhZGRpdGlvbmFsIGRlcGVuZGVuY2llcy4KKworVGhlIGZvbGxvd2luZyBjb2RlIHJldHVybnMg YSBwYWNrYWdlIGluIHdoaWNoIHRoZSBSZWRpcyBhbmQgZ2l0LWFubmV4Citwcm9ncmFtcyBjYW4g YmUgaW52b2tlZCBieSBHaXRvbGl0ZSdzIHNjcmlwdHM6CisKK0BleGFtcGxlCisodXNlLW1vZHVs ZXMgKGdudSBwYWNrYWdlcyBkYXRhYmFzZXMpCisgICAgICAgICAgICAgKGdudSBwYWNrYWdlcyBo YXNrZWxsLWFwcHMpKQorKG1ha2UtZ2l0b2xpdGUgKGxpc3QgcmVkaXMgZ2l0LWFubmV4KSkKK0Bl bmQgZXhhbXBsZQogCiBAaXRlbSBAY29kZXt1c2VyfSAoZGVmYXVsdDogQHZhcntnaXR9KQogVXNl ciB0byB1c2UgZm9yIEdpdG9saXRlLiAgVGhpcyB3aWxsIGJlIHVzZXIgdGhhdCB5b3UgdXNlIHdo ZW4gYWNjZXNzaW5nCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvdmVyc2lvbi1jb250cm9sLnNj bSBiL2dudS9wYWNrYWdlcy92ZXJzaW9uLWNvbnRyb2wuc2NtCmluZGV4IGJkMGFkNzBjZTguLjY4 MzU4Y2MxZDEgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy92ZXJzaW9uLWNvbnRyb2wuc2NtCisr KyBiL2dudS9wYWNrYWdlcy92ZXJzaW9uLWNvbnRyb2wuc2NtCkBAIC0xMzcsNyArMTM3LDggQEAg KGRlZmluZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB2ZXJzaW9uLWNvbnRyb2wpCiAgICM6dXNlLW1v ZHVsZSAoZ251IHBhY2thZ2VzIHRscykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMpCiAg ICM6dXNlLW1vZHVsZSAoaWNlLTkgbWF0Y2gpCi0gICM6dXNlLW1vZHVsZSAoc3JmaSBzcmZpLTEp KQorICAjOnVzZS1tb2R1bGUgKHNyZmkgc3JmaS0xKQorICAjOmV4cG9ydCAobWFrZS1naXRvbGl0 ZSkpCiAKIChkZWZpbmUtcHVibGljIGJyZWV6eQogICAocGFja2FnZQpAQCAtMTQ4Miw3ICsxNDgz LDkgQEAgKGRlZmluZS1wdWJsaWMgZ2l0LXRlc3Qtc2VxdWVuY2UKIGFsc28gd2FsayBlYWNoIHNp ZGUgb2YgYSBtZXJnZSBhbmQgdGVzdCB0aG9zZSBjaGFuZ2VzIGluZGl2aWR1YWxseS4iKQogICAg ICAgKGxpY2Vuc2UgKGxpY2Vuc2U6eDExLXN0eWxlICJmaWxlOi8vTElDRU5TRSIpKSkpKQogCi0o ZGVmaW5lLXB1YmxpYyBnaXRvbGl0ZQorKGRlZmluZSogKG1ha2UtZ2l0b2xpdGUgIzpvcHRpb25h bCAoZXh0cmEtaW5wdXRzICcoKSkpCisgICJNYWtlIGEgZ2l0b2xpdGUgcGFja2FnZSBvYmplY3Qg d2l0aCBFWFRSQS1JTlBVVFMgYWRkZWQgdG8gdGhlIGJpbmFyeQord3JhcHBlcnMsIHRvIGJlIHVz ZWQgZm9yIG9wdGlvbmFsIGdpdG9saXRlIGV4dGVuc2lvbnMuIgogICAocGFja2FnZQogICAgIChu YW1lICJnaXRvbGl0ZSIpCiAgICAgKHZlcnNpb24gIjMuNi4xMiIpCkBAIC0xNTc0LDEwICsxNTc3 LDEyIEBAIChkZWZpbmUtcHVibGljIGdpdG9saXRlCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChsaXN0ICMkb3V0cHV0CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICMkY29yZXV0aWxzCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICMkZmluZHV0aWxzCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICMkZ2l0KSkpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIyRnaXQKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIyRAZXh0cmEtaW5wdXRzKSkpKSkKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJygiL2Jpbi9naXRvbGl0ZSIgIi9iaW4vZ2l0b2xpdGUtc2hl bGwiKSkpKSkpKQogICAgIChpbnB1dHMKLSAgICAgKGxpc3QgYmFzaC1taW5pbWFsIGNvcmV1dGls cyBmaW5kdXRpbHMgZ2l0IGluZXR1dGlscyBvcGVuc3NoIHBlcmwpKQorICAgICAoYXBwZW5kIChs aXN0IGJhc2gtbWluaW1hbCBjb3JldXRpbHMgZmluZHV0aWxzIGdpdCBpbmV0dXRpbHMgb3BlbnNz aCBwZXJsKQorICAgICAgICAgICAgIGV4dHJhLWlucHV0cykpCiAgICAgKGhvbWUtcGFnZSAiaHR0 cHM6Ly9naXRvbGl0ZS5jb20iKQogICAgIChzeW5vcHNpcyAiR2l0IGFjY2VzcyBjb250cm9sIGxh eWVyIikKICAgICAoZGVzY3JpcHRpb24KQEAgLTE1ODUsNiArMTU5MCw4IEBAIChkZWZpbmUtcHVi bGljIGdpdG9saXRlCiBjb250cm9sIHRvIEdpdCByZXBvc2l0b3JpZXMuIikKICAgICAobGljZW5z ZSBsaWNlbnNlOmdwbDIpKSkKIAorKGRlZmluZS1wdWJsaWMgZ2l0b2xpdGUgKG1ha2UtZ2l0b2xp dGUpKQorCiAoZGVmaW5lLXB1YmxpYyBnaXRpbGUKICAgKHBhY2thZ2UKICAgICAobmFtZSAiZ2l0 aWxlIikKLS0gCjIuMzcuMgoK --0000000000004d05d505ea5da530-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 06 09:42:44 2022 Received: (at 25957) by debbugs.gnu.org; 6 Oct 2022 13:42:44 +0000 Received: from localhost ([127.0.0.1]:59432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogR99-0007V6-Tg for submit@debbugs.gnu.org; Thu, 06 Oct 2022 09:42:44 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:34678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogR8z-0007Ui-UQ for 25957@debbugs.gnu.org; Thu, 06 Oct 2022 09:42:42 -0400 Received: by mail-lf1-f52.google.com with SMTP id a29so2796010lfo.1 for <25957@debbugs.gnu.org>; Thu, 06 Oct 2022 06:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FPs7xWLecZLGyqW2oWGvCHaKRvXPUcbtxJ8fmrc1rF8=; b=JwQC2yacyyeaQe0ghLCfICDUC/emTYdo9KN19QYr7o0nkO6Svrve2NPuWwIqpyyhtZ oQs5ulqup85nKsrhbUVl9Nzgaoug1FfAm+YAwNlAoLCI+tSG5NU7Q6CzfCrL8rMpxWvB js3dbnWcY0x20HGwkvlopRGk60c2zvSeEXqyob6ew+G0FIwwsD81PiLK5coYdLn1yJGU JR5VJLJU1LYlLAq5JoQhT/pT9rxJ6Vk3PUhwWqxFrxPMAb2IjCLkX3pCpoE3LLxJA2c0 jiRor+POC69oQS5zgb7jj93L3IvtbcZ8zD8edddotA/O6/RNe+8ntOj4IfnLD2UUahX1 MdSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FPs7xWLecZLGyqW2oWGvCHaKRvXPUcbtxJ8fmrc1rF8=; b=6I+O92QMSap3ZHgCscWwxnVeNm5zWc8VEdO4rl4HN2BZpTfom7K4Gv9nxF5Oyc936v Ux7HofGS2gMBaCs0EbY0tnEuMbqiZPknVhsYn9D3W4FZFE/IpQSSCJW33SRbfxBGaiwR UvMbf5VMhUhyjzXgM9lnxA0EYhEXm6zVnzFkeWFzOY40I4M8zxqRs8oTmKwoYNCz+HFR jCj7J0KOHPEcnnZHWJrv0qvftrACAAZcemVLGI5dzvZeMubJ4hogZC5rvbVamO+Vsfrw dwcoPioRXfDrcPK/5P9QwDAz1nrh1JJaFeljvOp3Y08SdyqfnoB1h/6eT4EUlNIKdNQ7 oElw== X-Gm-Message-State: ACrzQf2FTNKl02bp9g3gRHM2NgxlDgHaXxQDZXOyKzO3LldxqKjZ1fx3 F/co3yB1rTcBgSitL/IEB7MLr1hi0Dcdljr249Fhfg== X-Google-Smtp-Source: AMsMyM6cI3J1DcVMCkCoqZP46mlNfY3QU5yFRPP68cZoLDsgfgEmmsX4tNu767KIFOP98vcg+sfAiDoYlZ0fOH5VdKQ= X-Received: by 2002:ac2:4c4d:0:b0:4a2:4a6a:b24e with SMTP id o13-20020ac24c4d000000b004a24a6ab24emr15739lfk.146.1665063747832; Thu, 06 Oct 2022 06:42:27 -0700 (PDT) MIME-Version: 1.0 References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> <871qsqtewp.fsf@gmail.com> In-Reply-To: From: "Thompson, David" Date: Thu, 6 Oct 2022 09:42:16 -0400 Message-ID: Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: zimoun Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: Efraim Flashner , 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I made a small mistake in the last patch and forgot to include '(gnu packages version-control)' in the 'use-modules' form in the example within the manual. I have fixed that in my local copy. - Dave From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 11:17:02 2022 Received: (at 25957) by debbugs.gnu.org; 8 Oct 2022 15:17:02 +0000 Received: from localhost ([127.0.0.1]:41204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohBZV-00042c-VS for submit@debbugs.gnu.org; Sat, 08 Oct 2022 11:17:02 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:47040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohBZQ-00040V-Um for 25957@debbugs.gnu.org; Sat, 08 Oct 2022 11:16:57 -0400 Received: by mail-wr1-f53.google.com with SMTP id bk15so11094428wrb.13 for <25957@debbugs.gnu.org>; Sat, 08 Oct 2022 08:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=At9f78lDajkQL81Ze6+GTwSl7Rc4fzR2yZBDYg3nIhU=; b=lzhJ5JBowu7uLK6T+qnrBUuigLmVOcv8Wlbrkd7AKwniOYbDPGkiZsIbMO9a1Xs+oK 5m0j9QMIA8GXBrkuxP23chhj+20psyHNyWJ+2HpXyPimoql+Cdyi4POeHfdhc/UR9ki0 VR3zWwCgX7erkhBa/bIi7p1WjiCBN0a2I0YPaeWZ/7MBWjBQOX4m5q85M4hvabeQWZdW zBRb70/BZgS6Djzlg3Ximx32OE9CxFlfGjxQmrz6LO0fOSawQgUKwlLm2qM2arL7QepF pnRiNaHQh+Rja18ABBD532+K7IXRp8Q9sVCDM90zRqELyF7y+0HxLTpUQxDSDEXQ1KFt 8tGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=At9f78lDajkQL81Ze6+GTwSl7Rc4fzR2yZBDYg3nIhU=; b=SLhj6uOsafDJKuiv8DUJmG9qzyAzpIOTrN62aIfg6paztVvTZfX6mnw/hBQLVzVCb9 no72ZTfM7p3Ltaspd+E9e09yflFv7QBPZP4ktyPUFAgA31gV6fnTs/zVJMd0C/zVd6s7 9UsKG4IisMhTREbvxyVGb/HoSjuviqgDpNUJ8PhCwTZRUrX6iNmAAU/duJdUQAQnb3wT MvnFReHZNGuw9Vgv92cJiumVxDBKg/JqTwE41Ln5HRZzB0/DcCkfoxazckDya+/ig2+1 Eeahunt0C6bDKvNLlDDdI4iJkiVyNC0mAE3xK0TyYtCuowODvrtNNPpGkoW4l/klh9Ab Qg6g== X-Gm-Message-State: ACrzQf03hqtvZMggqni/3V177ou5wRJ26ElMZ1XBGUSyi7MfQGHXc62l 3Cv0SW0z2hFlz3k3fkFcx+glajB2Xaw= X-Google-Smtp-Source: AMsMyM7ja1p1pR9tFHy60/U8BSSlyz72bLcR7qIJ/ZhD4JCoU0tXMHfegM5A7GA4FdWtPBbol5MF9w== X-Received: by 2002:a05:6000:156b:b0:22a:a83a:d349 with SMTP id 11-20020a056000156b00b0022aa83ad349mr6551516wrz.277.1665242216632; Sat, 08 Oct 2022 08:16:56 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id v132-20020a1cac8a000000b003a541d893desm5384575wme.38.2022.10.08.08.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Oct 2022 08:16:56 -0700 (PDT) From: zimoun To: "Thompson, David" Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> <871qsqtewp.fsf@gmail.com> Date: Sat, 08 Oct 2022 16:56:08 +0200 In-Reply-To: (David Thompson's message of "Thu, 6 Oct 2022 09:26:38 -0400") Message-ID: <86k05as6t3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: Efraim Flashner , 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dave, On Thu, 06 Oct 2022 at 09:26, "Thompson, David" = wrote: > Some news: I have updated the gitolite package to use G-expressions. > The package builds and the gitolite system test passes so I pushed > that change to master a little while ago. That patch has made the > (hopefully) final step in this saga easier. The attached patch > introduces a 'make-gitolite' procedure that can be used to add > arbitrary packages to the wrappers for the gitolite and gitolite-shell > programs. The return value of this procedure can be used in the > gitolite service configuration to enable the desired optional features > like Redis or git-annex. The base package inputs are unchanged and > the gitolite system test still passes. Thank you for working on this! Neat. Well, your proposal LGTM although I do not see the difference between =E2=80=99make-gitolite=E2=80=99 and a simple =E2=80=99inherent=E2=80=99 for= building a package variant. Yeah, this make-gitolite is probably more handy. I do not have a strong opinion on the matter. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 21:40:29 2022 Received: (at 25957) by debbugs.gnu.org; 9 Oct 2022 01:40:29 +0000 Received: from localhost ([127.0.0.1]:41676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohLIq-0000qp-Pp for submit@debbugs.gnu.org; Sat, 08 Oct 2022 21:40:29 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:39502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohLIp-0000qS-1i for 25957@debbugs.gnu.org; Sat, 08 Oct 2022 21:40:27 -0400 Received: by mail-lj1-f177.google.com with SMTP id bn8so9719445ljb.6 for <25957@debbugs.gnu.org>; Sat, 08 Oct 2022 18:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XdqSp77R78TkA+DRpioC/0X1bSEkSYqyY5TACDxWD/E=; b=p7LsspWBa4dzY6o5zqH5O0XgV9q4/4r4Mn6a9aZ8RU74CWyb095WRwX+U+ik/jQ4k8 GWnm2z12nEtwcTYiJKlacMGN7xgMUCPSTdTr7kBO1wQgFpT4tCkkxus96E5v096LAgde cm11UzaJW+P5xLJVgGYltQoq4nMulrtCQ/DrQZbyU46lHwOkb6t3wFm+GiAJWK2efJvo 5dNXgzZQd7BtQ0UwRqNd0d10XdFeN7V0A1+pCVPZuQaL/Bt1+I/OjmI1txGRSD1MkTM5 2UHf5CAfSC9RPMYK15fkO1YIz1g/sFMm1hW9ET/j+zNCbdLnxUI35TtTzM+8VdwSvl0D xmgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XdqSp77R78TkA+DRpioC/0X1bSEkSYqyY5TACDxWD/E=; b=F1VZsd27Er1emBtl1KQ75OJd+MbAkNb0Wo9I88K9xtfwnIDXYTS34kKqbzAcMJ0K3c VLdMQPYyxwHF/MbndmVhBY4Y2TMfUxCu+VNvB15ztLJuQN8g2dgy7DZtlz6asZ1B14jS tN/P12ouPmHc//Lhn8DjwEBP7i9y1LckJrP4GAkx1eAdNbOIqzM02oD3uwXe+J1jol4J tPOccopowreJGIUkzLhi1Mrj+BVjYJQtY+/Iu/BP2snv0XpJQ6YSrPluQyHZUcwR4U+n EeyWTUm5JP7436CxSUNvDVF6N7IQBZWi0cLSsBCXgiAUmiSMd/msDoukVKLygZ5rH+X3 YbYg== X-Gm-Message-State: ACrzQf1LWCtMecoRdo99PXEzxSl1Rq/fYZVpGreaCkG+3d3MN1FsbHtY 1uIUnCaR+t9j6NdJVA8ptGoezF1uhi/YzFLAhpXQrw== X-Google-Smtp-Source: AMsMyM5V9RudcIufV9lxuxBDyUCJQKsh2QgxhJORD04CCi4tZ8deR2HQSIKUrYJQN2h7/bCWfhQhrrub+i/isq71UbQ= X-Received: by 2002:a2e:9f12:0:b0:26e:8558:c6a5 with SMTP id u18-20020a2e9f12000000b0026e8558c6a5mr2919159ljk.135.1665279620911; Sat, 08 Oct 2022 18:40:20 -0700 (PDT) MIME-Version: 1.0 References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> <871qsqtewp.fsf@gmail.com> <86k05as6t3.fsf@gmail.com> In-Reply-To: <86k05as6t3.fsf@gmail.com> From: "Thompson, David" Date: Sat, 8 Oct 2022 21:40:09 -0400 Message-ID: Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: zimoun Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: Efraim Flashner , 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Oct 8, 2022 at 11:16 AM zimoun wrote: > > Hi Dave, > > On Thu, 06 Oct 2022 at 09:26, "Thompson, David" wrote: > > > Some news: I have updated the gitolite package to use G-expressions. > > The package builds and the gitolite system test passes so I pushed > > that change to master a little while ago. That patch has made the > > (hopefully) final step in this saga easier. The attached patch > > introduces a 'make-gitolite' procedure that can be used to add > > arbitrary packages to the wrappers for the gitolite and gitolite-shell > > programs. The return value of this procedure can be used in the > > gitolite service configuration to enable the desired optional features > > like Redis or git-annex. The base package inputs are unchanged and > > the gitolite system test still passes. > > Thank you for working on this! Neat. > > Well, your proposal LGTM although I do not see the difference between > =E2=80=99make-gitolite=E2=80=99 and a simple =E2=80=99inherent=E2=80=99 f= or building a package variant. > Yeah, this make-gitolite is probably more handy. The reason for the constructor is so that extra packages can be easily added to the gexp that calls wrap-program. It would be much harder to modify the package in this way without a helper procedure. - Dave From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 24 17:22:14 2022 Received: (at 25957) by debbugs.gnu.org; 24 Oct 2022 21:22:14 +0000 Received: from localhost ([127.0.0.1]:49648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1on4ti-0002IX-Dw for submit@debbugs.gnu.org; Mon, 24 Oct 2022 17:22:14 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:33330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1on4tV-0002Hg-DN for 25957@debbugs.gnu.org; Mon, 24 Oct 2022 17:22:03 -0400 Received: by mail-lj1-f170.google.com with SMTP id b8so7690515ljf.0 for <25957@debbugs.gnu.org>; Mon, 24 Oct 2022 14:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wlosTPTt4b9NqDuUF/RIedw6Da5Cs7G8BTcvhshYG4g=; b=jBNv+5qpHEyIlJ4XeBy0DaH/ruK6V2SKrQXynhFqviHaZ2MXpI65IvE9MmL1XvLish EKjf2t9bArqnDLvc/4crgxtVKWc8Ch3uL5rYH/jiaCFrz/iSzayTSEApAUjmpJtecm50 MmPzLP8iQEsVVyLSVkBrW9iP2eEfDNnsExZzHE82mpXtAJkJEOMo4CsCaPQJZQUi5PRJ wvycedgNbPPRlEnHHuSE8KBaspJkmWle4mdb53ZxU7R0nORtDE6WmE7BYYL6aqfpf2or H24trGAXn01vIo1bh9TogffWrwShsHsTZgv9NEN5mHT/45CLFRLcRd3TjBre40H0VSNg sl0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wlosTPTt4b9NqDuUF/RIedw6Da5Cs7G8BTcvhshYG4g=; b=Q+eawHdSv8v5XkMgZi6GESQtqVC1FrW91NWI8e3sJml76G0vnnUdEgEIrGTyyN7Aui 8VGzG1bGjHmduO2N1FbotRjCXp/P4yZtQUTmnV5WRRMxpMKsA+CVgT3BGSV5g4yHCd91 gVunlayH9N/LBcyXvQvsNw2ik2IMEkQVCyU7mgad+Mr4jMgN7WhI01h23f6SaD4qY8ZX lO5mF8uOLmBnZZRxQsjY5fW+lqpBkTFNBsD+puisOM+1EaW+n0QSldp7gv5T4nBEpdg4 X5AlLd2AKVPyrGreM5M4xL9VIu6kCY3s68/yVGYWRo22qnTQEC/Q6gNwMGS/PnaQ7OMf IbnA== X-Gm-Message-State: ACrzQf24pz7+tOtAeJ0udID7AU0zaDexsETmvXLGdbc0CH741BxF3BDy joaganMl5P+RRoViUiyl8IDlfmxAEGL4KL/XdMHOBw== X-Google-Smtp-Source: AMsMyM4C4fH9xyDwaWFvh3iaPa4K2BeHtl1jgnSgS9mHMNZpjtcZoryN0ZQq4cRmCu26HoMcA+to/94RysU3mJU3KlQ= X-Received: by 2002:a05:651c:2116:b0:277:f14:5798 with SMTP id a22-20020a05651c211600b002770f145798mr1875611ljq.42.1666646515336; Mon, 24 Oct 2022 14:21:55 -0700 (PDT) MIME-Version: 1.0 References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> <871qsqtewp.fsf@gmail.com> <86k05as6t3.fsf@gmail.com> In-Reply-To: From: "Thompson, David" Date: Mon, 24 Oct 2022 17:21:44 -0400 Message-ID: Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks To: zimoun Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957-done@debbugs.gnu.org, Efraim Flashner , 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Oct 8, 2022 at 9:40 PM Thompson, David w= rote: > > On Sat, Oct 8, 2022 at 11:16 AM zimoun wrote: > > > > Hi Dave, > > > > On Thu, 06 Oct 2022 at 09:26, "Thompson, David" wrote: > > > > > Some news: I have updated the gitolite package to use G-expressions. > > > The package builds and the gitolite system test passes so I pushed > > > that change to master a little while ago. That patch has made the > > > (hopefully) final step in this saga easier. The attached patch > > > introduces a 'make-gitolite' procedure that can be used to add > > > arbitrary packages to the wrappers for the gitolite and gitolite-shel= l > > > programs. The return value of this procedure can be used in the > > > gitolite service configuration to enable the desired optional feature= s > > > like Redis or git-annex. The base package inputs are unchanged and > > > the gitolite system test still passes. > > > > Thank you for working on this! Neat. > > > > Well, your proposal LGTM although I do not see the difference between > > =E2=80=99make-gitolite=E2=80=99 and a simple =E2=80=99inherent=E2=80=99= for building a package variant. > > Yeah, this make-gitolite is probably more handy. > > The reason for the constructor is so that extra packages can be easily > added to the gexp that calls wrap-program. It would be much harder to > modify the package in this way without a helper procedure. Pushed as commit 966118da711506b04c11fbfcac9483d59ed2d912. This bug can finally be closed! - Dave From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 25 06:23:52 2022 Received: (at 25957) by debbugs.gnu.org; 25 Oct 2022 10:23:52 +0000 Received: from localhost ([127.0.0.1]:50484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onH68-0006Ox-K6 for submit@debbugs.gnu.org; Tue, 25 Oct 2022 06:23:52 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:56319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onH67-0006Oh-13; Tue, 25 Oct 2022 06:23:51 -0400 Received: by mail-wm1-f50.google.com with SMTP id t4so7963929wmj.5; Tue, 25 Oct 2022 03:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=gkVMQtd0piCdBNzTUmqSs4IhSyvZzx8E3/ZEtfBYqG0=; b=nxBSCQi6lm3uAmai1C5caSHH1c2ggbXRzutyYLrkJK9wswezIBL/4KmoQJIKkOgv86 46/BWKUy61l0XoZHEMaxrrh3v8MKXkC5yuotaN58FMeiYIRfNKZ4IM59SDoe0IcAD9dI LZbO+Ryx9Drt5Iqrsxuf4WEdlNcZrFJSwsWCFlsLGhTSKttXPzhI69mhZit+L8KHVn7/ t5OyeT2XKuj8cVIAWfeofwlIpF8XOc/l4+qrCEPBq5J44t1tm0hvJiZVfcbgrOL2NE1g a7oT8eTkpSWvLyoS1IFZ7/jwHLYzayqbd+N5fYVzxcN4j3NEodeKffDp00CkNnbl/CaV 5rOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gkVMQtd0piCdBNzTUmqSs4IhSyvZzx8E3/ZEtfBYqG0=; b=Qel163DxomJx+q+Io1VNdUhrSmzx2FrKjbikAxbBTuvQYYz4ukIg4wehyAzS1y9ITy g7mKJbrZYsvXhVFoI+T1bpshcHATooHHdPqwo2cFTijc3npln1aA71RxifrnPKDQ0q6X 1eLQJKvaWXrwSpuhH9MHiHwiHUZhmzj9D9FqrnDmESY253OKFAIye5An7qc0vBf86nDf JkBf3/xitCCG7PkiCTNrraTpdBYnJGY2b/cqM+BDLyEIUI08YiBMsl9bNNylDwGKRc1d ZvLERqp0GI6mr3Q8KcEpNRwRG0+WCbOSK8jBGxrCnUkDusoruIP4pbZSD3qy9Z8+iXlC YA8w== X-Gm-Message-State: ACrzQf0D2mdWUBAz3PW20pwkNg7yQQHiTloi7vk9VzLWZQtLYlcgDia+ CnMtrGioVLjpF34rtu38OpohsXdacXw= X-Google-Smtp-Source: AMsMyM65C6SFfGTRqF3aeMbDAfw42MvDwYHOvETVsWes/zLKV8mAOt4d44iHtbIbcJnIREzeZsbHJw== X-Received: by 2002:a05:600c:3b88:b0:3c6:cef8:8465 with SMTP id n8-20020a05600c3b8800b003c6cef88465mr45720001wms.64.1666693424184; Tue, 25 Oct 2022 03:23:44 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id h18-20020a05600c2cb200b003c21ba7d7d6sm2209334wmc.44.2022.10.25.03.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 03:23:43 -0700 (PDT) From: zimoun To: "Thompson, David" Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks In-Reply-To: References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> <871qsqtewp.fsf@gmail.com> <86k05as6t3.fsf@gmail.com> Date: Tue, 25 Oct 2022 11:58:06 +0200 Message-ID: <86h6zs2pjl.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957-done@debbugs.gnu.org, Efraim Flashner , 25957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dave, On Mon, 24 Oct 2022 at 17:21, "Thompson, David" wrote: > Pushed as commit 966118da711506b04c11fbfcac9483d59ed2d912. This bug > can finally be closed! \o/ Awesome! Thank you! Cheers, simon From unknown Wed Aug 20 06:39:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 22 Nov 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator