GNU bug report logs - #25955
[PATCH] guix: Only attempt to build json builder if json is available.

Previous Next

Package: guix-patches;

Reported by: John Darrington <john <at> darrington.wattle.id.au>

Date: Fri, 3 Mar 2017 17:44:02 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: John Darrington <john <at> darrington.wattle.id.au>
To: Ludovic Court??s <ludo <at> gnu.org>
Cc: John Darrington <john <at> darrington.wattle.id.au>, 25955 <at> debbugs.gnu.org
Subject: bug#25955: [PATCH] guix: Only attempt to build json builder if json is available.
Date: Thu, 16 Mar 2017 18:10:37 +0100

[Message part 1 (text/plain, inline)]
On Thu, Mar 16, 2017 at 04:40:51PM +0100, Ludovic Court??s wrote:
     John Darrington <john <at> darrington.wattle.id.au> skribis:
     
     > On Mon, Mar 13, 2017 at 02:16:27PM +0100, Ludovic Court??s wrote:
     >      John Darrington <john <at> darrington.wattle.id.au> skribis:
     >      
     >      > * guix/import/stackage.scm: avoid loading the json module.
     >      > ---
     >      >  guix/import/stackage.scm | 3 ++-
     >      >  1 file changed, 2 insertions(+), 1 deletion(-)
     >      >
     >      > diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm
     >      > index 5b25adc..c8f195a 100644
     >      > --- a/guix/import/stackage.scm
     >      > +++ b/guix/import/stackage.scm
     >      > @@ -23,7 +23,6 @@
     >      >    #:use-module (srfi srfi-26)
     >      >    #:use-module (srfi srfi-34)
     >      >    #:use-module (srfi srfi-35)
     >      > -  #:use-module (guix import json)
     >      >    #:use-module (guix import hackage)
     >      >    #:use-module (guix memoization)
     >      >    #:use-module (guix packages)
     >      > @@ -31,6 +30,8 @@
     >      >    #:export (stackage->guix-package
     >      >              %stackage-updater))
     >      >  
     >      > +(module-autoload! (current-module) '(guix import json) '(json))
     >      
     >      We don???t do that for any of the other (guix import ???) modules that uses
     >
     > No.  But all the others are projected in Makefile.am by "if HAVE_GUILE_JSON" .
     
     Oh right.  Then let???s move this one under ???if HAVE_GUILE_JSON??? as well.

No. I tried that.  Unfortunately there are other modules which need this one.

J'
     
-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 8 years and 68 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.