GNU bug report logs - #25955
[PATCH] guix: Only attempt to build json builder if json is available.

Previous Next

Full log

Message #17 received at 25955 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: John Darrington <john <at> darrington.wattle.id.au>
Cc: 25955 <at> debbugs.gnu.org
Subject: Re: bug#25955: [PATCH] guix: Only attempt to build json builder if
 json is available.
Date: Thu, 16 Mar 2017 16:40:51 +0100

John Darrington <john <at> darrington.wattle.id.au> skribis:

> On Mon, Mar 13, 2017 at 02:16:27PM +0100, Ludovic Court??s wrote:
>      John Darrington <john <at> darrington.wattle.id.au> skribis:
>      
>      > * guix/import/stackage.scm: avoid loading the json module.
>      > ---
>      >  guix/import/stackage.scm | 3 ++-
>      >  1 file changed, 2 insertions(+), 1 deletion(-)
>      >
>      > diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm
>      > index 5b25adc..c8f195a 100644
>      > --- a/guix/import/stackage.scm
>      > +++ b/guix/import/stackage.scm
>      > @@ -23,7 +23,6 @@
>      >    #:use-module (srfi srfi-26)
>      >    #:use-module (srfi srfi-34)
>      >    #:use-module (srfi srfi-35)
>      > -  #:use-module (guix import json)
>      >    #:use-module (guix import hackage)
>      >    #:use-module (guix memoization)
>      >    #:use-module (guix packages)
>      > @@ -31,6 +30,8 @@
>      >    #:export (stackage->guix-package
>      >              %stackage-updater))
>      >  
>      > +(module-autoload! (current-module) '(guix import json) '(json))
>      
>      We don???t do that for any of the other (guix import ???) modules that uses
>
> No.  But all the others are projected in Makefile.am by "if HAVE_GUILE_JSON" .

Oh right.  Then let’s move this one under “if HAVE_GUILE_JSON” as well.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.