GNU bug report logs - #25939
[PATCH] gnu: neomutt: Configure with "kyotocabinet".

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25939 in the body.
You can then email your comments to 25939 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: contact.ng0 <at> cryptolab.net
To: guix-patches <at> gnu.org
Cc: ng0 <contact.ng0 <at> cryptolab.net>
Subject: [PATCH] gnu: neomutt: Configure with "kyotocabinet".
Date: Thu,  2 Mar 2017 21:11:25 +0000

From: ng0 <contact.ng0 <at> cryptolab.net>

* gnu/packages/mail.scm (neomutt)[arguments]: Add "--with-kyotocabinet"
to configure-flags.
---
 gnu/packages/mail.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index ee82a1b8b..af1763b16 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -269,6 +269,7 @@ operating systems.")
        ("gdbm" ,gdbm)
        ("lmdb" ,lmdb)
        ("tokyocabinet" ,tokyocabinet)
+       ("kyotocabinet" ,kyotocabinet)
        ("gpgme" ,gpgme)
        ("ncurses" ,ncurses)
        ("gnutls" ,gnutls)
@@ -293,6 +294,7 @@ operating systems.")
              ;; database, implies header caching
              ;; neomutt supports building multiple backends
              "--with-tokyocabinet"
+             "--with-kyotocabinet"
              "--without-qdbm"
              "--without-bdb"
              "--with-lmdb"
-- 
2.12.0

Message #8 received at 25939 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <contact.ng0 <at> cryptolab.net>
To: 25939 <at> debbugs.gnu.org
Subject: Re: bug#25939: Acknowledgement ([PATCH] gnu: neomutt: Configure with
 "kyotocabinet".)
Date: Thu, 2 Mar 2017 21:31:54 +0000

In the last patch which added tokyocabinet and its support to neomutt, I
did not know that neomutt has support for kyotocabinet which is a
separate database from tokyocabinet but kyotocabinet is the currently
developed/recommended database (by the database upstream).

Should we add this in addition or drop tokyocabinet in favor of adding
kyotocabinet ? I'm okay with just adding it.

On 17-03-02 21:13:02, GNU bug Tracking System wrote:
> Thank you for filing a new bug report with debbugs.gnu.org.
> 
> This is an automatically generated reply to let you know your message
> has been received.
> 
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
> 
> Your message has been sent to the package maintainer(s):
>  guix-patches <at> gnu.org
> 
> If you wish to submit further information on this problem, please
> send it to 25939 <at> debbugs.gnu.org.
> 
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.
> 
> -- 
> 25939: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25939
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems

Message #11 received at 25939 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: contact.ng0 <at> cryptolab.net
Cc: 25939 <at> debbugs.gnu.org
Subject: Re: bug#25939: [PATCH] gnu: neomutt: Configure with "kyotocabinet".
Date: Thu, 2 Mar 2017 17:00:40 -0500

On Thu, Mar 02, 2017 at 09:11:25PM +0000, contact.ng0 <at> cryptolab.net wrote:
> From: ng0 <contact.ng0 <at> cryptolab.net>
> 
> * gnu/packages/mail.scm (neomutt)[arguments]: Add "--with-kyotocabinet"
> to configure-flags.

So it has support for both tokyo and kyoto, and the user gets to choose?

Message #14 received at 25939 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 25939 <at> debbugs.gnu.org
Subject: Re: bug#25939: Acknowledgement ([PATCH] gnu: neomutt: Configure with
 "kyotocabinet".)
Date: Thu, 2 Mar 2017 17:01:36 -0500

On Thu, Mar 02, 2017 at 09:31:54PM +0000, ng0 wrote:
> In the last patch which added tokyocabinet and its support to neomutt, I
> did not know that neomutt has support for kyotocabinet which is a
> separate database from tokyocabinet but kyotocabinet is the currently
> developed/recommended database (by the database upstream).
> 
> Should we add this in addition or drop tokyocabinet in favor of adding
> kyotocabinet ? I'm okay with just adding it.

Sorry, I replied to the patch before seeing this message. If
tokyocabinet is unmaintained or superseded by kyotocabinet, then let's
just remove it from neomutt.

Message #17 received at 25939 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <contact.ng0 <at> cryptolab.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 25939 <at> debbugs.gnu.org
Subject: Re: bug#25939: Acknowledgement ([PATCH] gnu: neomutt: Configure with
 "kyotocabinet".)
Date: Thu, 2 Mar 2017 22:16:24 +0000

On 17-03-02 17:01:36, Leo Famulari wrote:
> On Thu, Mar 02, 2017 at 09:31:54PM +0000, ng0 wrote:
> > In the last patch which added tokyocabinet and its support to neomutt, I
> > did not know that neomutt has support for kyotocabinet which is a
> > separate database from tokyocabinet but kyotocabinet is the currently
> > developed/recommended database (by the database upstream).
> > 
> > Should we add this in addition or drop tokyocabinet in favor of adding
> > kyotocabinet ? I'm okay with just adding it.
> 
> Sorry, I replied to the patch before seeing this message. If
> tokyocabinet is unmaintained or superseded by kyotocabinet, then let's
> just remove it from neomutt.
> 
> 
> 

No problem, I've only realized it after the patch was merged in. After
all the patch includes not only the tokyodb.
I'd read the database website and leave it up to someone else as a
second opinion what's the best course of action here.
I only knew of kyotocabinet before I found tokyo and read as tokyo as
the work which happened before kyotocabinet.

Message #20 received at 25939 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 25939 <at> debbugs.gnu.org
Subject: Re: bug#25939: Acknowledgement ([PATCH] gnu: neomutt: Configure with
 "kyotocabinet".)
Date: Fri, 17 Mar 2017 12:42:02 -0400

[Message part 1 (text/plain, inline)]

ng0 <contact.ng0 <at> cryptolab.net> writes:

> On 17-03-02 17:01:36, Leo Famulari wrote:
>> On Thu, Mar 02, 2017 at 09:31:54PM +0000, ng0 wrote:
>> > In the last patch which added tokyocabinet and its support to neomutt, I
>> > did not know that neomutt has support for kyotocabinet which is a
>> > separate database from tokyocabinet but kyotocabinet is the currently
>> > developed/recommended database (by the database upstream).
>> > 
>> > Should we add this in addition or drop tokyocabinet in favor of adding
>> > kyotocabinet ? I'm okay with just adding it.
>> 
>> Sorry, I replied to the patch before seeing this message. If
>> tokyocabinet is unmaintained or superseded by kyotocabinet, then let's
>> just remove it from neomutt.
>> 
>> 
>> 
>
> No problem, I've only realized it after the patch was merged in. After
> all the patch includes not only the tokyodb.
> I'd read the database website and leave it up to someone else as a
> second opinion what's the best course of action here.
> I only knew of kyotocabinet before I found tokyo and read as tokyo as
> the work which happened before kyotocabinet.

FYI, I committed the patch a little while ago. I decided to remove
tokyocabinet, as kyotocabinet seems to be its successor. You may close
the bug if you feel it has been addressed satisfactorily.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 25939-done <at> debbugs.gnu.org (full text, mbox):

From: ng0 <contact.ng0 <at> cryptolab.net>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 25939-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#25939: Acknowledgement ([PATCH] gnu: neomutt: Configure with
 "kyotocabinet".)
Date: Fri, 17 Mar 2017 17:45:52 +0000

Kei Kebreau transcribed 2.3K bytes:
> ng0 <contact.ng0 <at> cryptolab.net> writes:
> 
> > On 17-03-02 17:01:36, Leo Famulari wrote:
> >> On Thu, Mar 02, 2017 at 09:31:54PM +0000, ng0 wrote:
> >> > In the last patch which added tokyocabinet and its support to neomutt, I
> >> > did not know that neomutt has support for kyotocabinet which is a
> >> > separate database from tokyocabinet but kyotocabinet is the currently
> >> > developed/recommended database (by the database upstream).
> >> > 
> >> > Should we add this in addition or drop tokyocabinet in favor of adding
> >> > kyotocabinet ? I'm okay with just adding it.
> >> 
> >> Sorry, I replied to the patch before seeing this message. If
> >> tokyocabinet is unmaintained or superseded by kyotocabinet, then let's
> >> just remove it from neomutt.
> >> 
> >> 
> >> 
> >
> > No problem, I've only realized it after the patch was merged in. After
> > all the patch includes not only the tokyodb.
> > I'd read the database website and leave it up to someone else as a
> > second opinion what's the best course of action here.
> > I only knew of kyotocabinet before I found tokyo and read as tokyo as
> > the work which happened before kyotocabinet.
> 
> FYI, I committed the patch a little while ago. I decided to remove
> tokyocabinet, as kyotocabinet seems to be its successor. You may close
> the bug if you feel it has been addressed satisfactorily.


I noticed it (thanks :) ). I just did not know this was still open. I
think you may close bugs (NNNNN-close <at> debbugs.gnu.org) after you have
pushed them. If there are questions, they can still be addressed in the
closed bug and reopened.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.