Subject: bug#25926: closed (Re: bug#25926: [PATCH] gnu: pugixml: Build relocatable library.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 04 Mar 2017 23:04:02 +0000

Your bug report

#25926: [PATCH] gnu: pugixml: Build relocatable library.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
25926: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25926
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#25926: [PATCH] gnu: pugixml: Build relocatable library.
From: Catonano <[email-masked]>
To: Kei Kebreau <[email-masked]>, [email-masked]
Cc: Roel Janssen <[email-masked]>, [email-masked]
Date: Sun, 5 Mar 2017 00:03:20 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

2017-03-04 23:26 GMT+01:00 Kei Kebreau <[email-masked]>:

> Roel Janssen <[email-masked]> writes:
>
> > Dear Guix,
> >
> > This patch modifies the recipe for pugixml to build a relocatable
> > library.  This fixes a compilation issue with Darktable.
> >
> > Kind regards,
> > Roel Janssen
> >
> >>>From 559b2c399f63beafe2d930cf75a71b7d575443cd Mon Sep 17 00:00:00 2001
> > From: Roel Janssen <[email-masked]>
> > Date: Thu, 2 Mar 2017 00:44:36 +0100
> > Subject: [PATCH] gnu: pugixml: Build relocatable library.
> >
> > * gnu/packages/xml.scm (pugixml): Add "-shared -fPIC" to ensure
> >   the library is relocatable.
> > ---
> >  gnu/packages/xml.scm | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> > index b91471690..30f49a8bd 100644
> > --- a/gnu/packages/xml.scm
> > +++ b/gnu/packages/xml.scm
> > @@ -752,7 +752,9 @@ the form of functions.")
> >          "0fcgggry5x5bn0zhb09ij9hb0p45nb0sv0d9fw3cm1cf62hp9n80"))))
> >      (build-system cmake-build-system)
> >      (arguments
> > -     `(#:tests? #f))                    ; no tests
> > +     `(#:configure-flags '("-DCMAKE_CXX_FLAGS=-shared -fPIC"
> > +                           "-DCMAKE_C_FLAGS=-shared -fPIC")
> > +       #:tests? #f))                    ; no tests
> >      (home-page "http://pugixml.org")
> >      (synopsis "Light-weight, simple and fast XML parser for C++ with
> XPath support")
> >      (description
>
> LGTM. Pushed to master as 52c14bb6ec6fbd532b1e03a512d133e2499186b9.
>

so this is done too, right ?

Subject: [PATCH] gnu: pugixml: Build relocatable library.
From: Roel Janssen <[email-masked]>
To: [email-masked]
Date: Thu, 02 Mar 2017 01:00:35 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Dear Guix,

This patch modifies the recipe for pugixml to build a relocatable
library.  This fixes a compilation issue with Darktable.

Kind regards,
Roel Janssen

>>From 559b2c399f63beafe2d930cf75a71b7d575443cd Mon Sep 17 00:00:00 2001
From: Roel Janssen <[email-masked]>
Date: Thu, 2 Mar 2017 00:44:36 +0100
Subject: [PATCH] gnu: pugixml: Build relocatable library.

* gnu/packages/xml.scm (pugixml): Add "-shared -fPIC" to ensure
  the library is relocatable.
---
 gnu/packages/xml.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index b91471690..30f49a8bd 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -752,7 +752,9 @@ the form of functions.")
         "0fcgggry5x5bn0zhb09ij9hb0p45nb0sv0d9fw3cm1cf62hp9n80"))))
     (build-system cmake-build-system)
     (arguments
-     `(#:tests? #f))                    ; no tests
+     `(#:configure-flags '("-DCMAKE_CXX_FLAGS=-shared -fPIC"
+                           "-DCMAKE_C_FLAGS=-shared -fPIC")
+       #:tests? #f))                    ; no tests
     (home-page "http://pugixml.org")
     (synopsis "Light-weight, simple and fast XML parser for C++ with XPath support")
     (description
-- 
2.11.0