From unknown Wed Aug 20 01:21:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25923: pkgsrc patches: improve mkostemp support Resent-From: Thomas Klausner Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 01 Mar 2017 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25923 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 25923@debbugs.gnu.org Cc: Greg Troxel X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14884001794625 (code B ref -1); Wed, 01 Mar 2017 20:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Mar 2017 20:29:39 +0000 Received: from localhost ([127.0.0.1]:34886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjAsV-0001CV-8R for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjAsT-0001CI-Ov for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjAsN-0007x3-Qc for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjAsN-0007wj-Nl for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjAsM-00077w-BJ for bug-guile@gnu.org; Wed, 01 Mar 2017 15:29:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjAsJ-0007rm-MH for bug-guile@gnu.org; Wed, 01 Mar 2017 15:29:30 -0500 Received: from danbala.ifoer.tuwien.ac.at ([128.130.168.114]:50476) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjAsJ-0007qU-FM for bug-guile@gnu.org; Wed, 01 Mar 2017 15:29:27 -0500 Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116) id 50CFCA583; Wed, 1 Mar 2017 21:29:26 +0100 (CET) Date: Wed, 1 Mar 2017 21:29:26 +0100 From: Thomas Klausner Message-ID: <20170301202926.mh7uireewfygr4zc@danbala> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="k4l7etcti2ubxtkz" Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --k4l7etcti2ubxtkz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline And the final pkgsrc patch tries to use only the flags for mkostemp that are supported on the operating system, in particular for Darwin and NetBSD. Please merge this one as well. Thanks, Thomas --k4l7etcti2ubxtkz Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch-libguile_filesys.c" $NetBSD: patch-libguile_filesys.c,v 1.3 2017/02/21 15:55:28 gdt Exp $ When using mkostemp (an interface not defined by POSIX), restrict flags to the set defined by the documentation of particular operating systems. See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 for discussion. This patch has not yet been sent upstream. --- libguile/filesys.c.orig 2016-12-15 00:03:33.000000000 +0000 +++ libguile/filesys.c @@ -1486,6 +1486,15 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1 mode_bits = scm_i_mode_bits (mode); } +#ifdef __APPLE__ + /* https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 */ + open_flags &= O_APPEND|O_SHLOCK|O_EXLOCK|O_CLOEXEC; +#endif +#ifdef __NetBSD__ + /* Restrict to list of flags documented in man page. */ + open_flags &= O_APPEND|O_DIRECT|O_SHLOCK|O_EXLOCK|O_SYNC|O_CLOEXEC; +#endif + SCM_SYSCALL (rv = mkostemp (c_tmpl, open_flags)); if (rv == -1) SCM_SYSERROR; --k4l7etcti2ubxtkz-- From unknown Wed Aug 20 01:21:32 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thomas Klausner Subject: bug#25923: closed (Re: bug#25923: pkgsrc patches: improve mkostemp support) Message-ID: References: <87efy08571.fsf@pobox.com> <20170301202926.mh7uireewfygr4zc@danbala> X-Gnu-PR-Message: they-closed 25923 X-Gnu-PR-Package: guile Reply-To: 25923@debbugs.gnu.org Date: Tue, 14 Mar 2017 11:33:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1489491182-13879-1" This is a multi-part message in MIME format... ------------=_1489491182-13879-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #25923: pkgsrc patches: improve mkostemp support which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 25923@debbugs.gnu.org. --=20 25923: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25923 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1489491182-13879-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 25923-done) by debbugs.gnu.org; 14 Mar 2017 11:32:12 +0000 Received: from localhost ([127.0.0.1]:54921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnkgW-0003Zl-8L for submit@debbugs.gnu.org; Tue, 14 Mar 2017 07:32:12 -0400 Received: from pb-sasl2.pobox.com ([64.147.108.67]:54426 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnkgU-0003Wr-1n for 25923-done@debbugs.gnu.org; Tue, 14 Mar 2017 07:32:10 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id BE01F69008; Tue, 14 Mar 2017 07:32:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=E37ycoWsUhpfax2nhtDtSsR9wm8=; b=KihhVj ItBn+vmt8ock0zB//+62keBCeUanmo/DClTfCWoVVtx+3YnDxL7CZyzO7bNI4D6n Uqq/ERcmqkNHdwhVOhF9ATvmXRw3jNcfndIZtTadKaUGARSp4ufhtRq6mwqtPgR7 dmU6J14R3nV8vDhw1AJvYjlZSwcmKnZ8br2pc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=UEJqBZtsUzzxL6A1SaM7eXgn7Vg0Q8Dp D9S3jRZigVEW6o5l/TJNZNr5bV+js6B7idckWA/Gz5WtAF8+iq3PoQ90CfqtSWYa bCj4sfUr1v/5pTxeg9ukitWIhx5tjBFqp4JCEKF45WEJT6cfpmPvDlBxevdx7BZI 9jDfxQd26BQ= Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id B774469007; Tue, 14 Mar 2017 07:32:09 -0400 (EDT) Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id C7E9069006; Tue, 14 Mar 2017 07:32:08 -0400 (EDT) From: Andy Wingo To: Thomas Klausner Subject: Re: bug#25923: pkgsrc patches: improve mkostemp support References: <20170301202926.mh7uireewfygr4zc@danbala> Date: Tue, 14 Mar 2017 12:32:02 +0100 In-Reply-To: <20170301202926.mh7uireewfygr4zc@danbala> (Thomas Klausner's message of "Wed, 1 Mar 2017 21:29:26 +0100") Message-ID: <87efy08571.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: DBFCC4AE-08A9-11E7-8487-85AB91A0D1B0-02397024!pb-sasl2.pobox.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25923-done Cc: 25923-done@debbugs.gnu.org, Greg Troxel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Wed 01 Mar 2017 21:29, Thomas Klausner writes: > --- libguile/filesys.c.orig 2016-12-15 00:03:33.000000000 +0000 > +++ libguile/filesys.c > @@ -1486,6 +1486,15 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1 > mode_bits = scm_i_mode_bits (mode); > } > > +#ifdef __APPLE__ > + /* https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 */ > + open_flags &= O_APPEND|O_SHLOCK|O_EXLOCK|O_CLOEXEC; > +#endif > +#ifdef __NetBSD__ > + /* Restrict to list of flags documented in man page. */ > + open_flags &= O_APPEND|O_DIRECT|O_SHLOCK|O_EXLOCK|O_SYNC|O_CLOEXEC; > +#endif > + > SCM_SYSCALL (rv = mkostemp (c_tmpl, open_flags)); > if (rv == -1) > SCM_SYSERROR; I believe this was fixed in 2.1.6 as well so you can drop this one too. Cheers, Andy ------------=_1489491182-13879-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Mar 2017 20:29:39 +0000 Received: from localhost ([127.0.0.1]:34886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjAsV-0001CV-8R for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjAsT-0001CI-Ov for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjAsN-0007x3-Qc for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjAsN-0007wj-Nl for submit@debbugs.gnu.org; Wed, 01 Mar 2017 15:29:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjAsM-00077w-BJ for bug-guile@gnu.org; Wed, 01 Mar 2017 15:29:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjAsJ-0007rm-MH for bug-guile@gnu.org; Wed, 01 Mar 2017 15:29:30 -0500 Received: from danbala.ifoer.tuwien.ac.at ([128.130.168.114]:50476) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjAsJ-0007qU-FM for bug-guile@gnu.org; Wed, 01 Mar 2017 15:29:27 -0500 Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116) id 50CFCA583; Wed, 1 Mar 2017 21:29:26 +0100 (CET) Date: Wed, 1 Mar 2017 21:29:26 +0100 From: Thomas Klausner To: bug-guile@gnu.org Subject: pkgsrc patches: improve mkostemp support Message-ID: <20170301202926.mh7uireewfygr4zc@danbala> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="k4l7etcti2ubxtkz" Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Greg Troxel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --k4l7etcti2ubxtkz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline And the final pkgsrc patch tries to use only the flags for mkostemp that are supported on the operating system, in particular for Darwin and NetBSD. Please merge this one as well. Thanks, Thomas --k4l7etcti2ubxtkz Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch-libguile_filesys.c" $NetBSD: patch-libguile_filesys.c,v 1.3 2017/02/21 15:55:28 gdt Exp $ When using mkostemp (an interface not defined by POSIX), restrict flags to the set defined by the documentation of particular operating systems. See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 for discussion. This patch has not yet been sent upstream. --- libguile/filesys.c.orig 2016-12-15 00:03:33.000000000 +0000 +++ libguile/filesys.c @@ -1486,6 +1486,15 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1 mode_bits = scm_i_mode_bits (mode); } +#ifdef __APPLE__ + /* https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 */ + open_flags &= O_APPEND|O_SHLOCK|O_EXLOCK|O_CLOEXEC; +#endif +#ifdef __NetBSD__ + /* Restrict to list of flags documented in man page. */ + open_flags &= O_APPEND|O_DIRECT|O_SHLOCK|O_EXLOCK|O_SYNC|O_CLOEXEC; +#endif + SCM_SYSCALL (rv = mkostemp (c_tmpl, open_flags)); if (rv == -1) SCM_SYSERROR; --k4l7etcti2ubxtkz-- ------------=_1489491182-13879-1--