From unknown Sun Aug 10 16:50:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25917 <25917@debbugs.gnu.org> To: bug#25917 <25917@debbugs.gnu.org> Subject: Status: operating-system file-system with (check? #t) but (needed-for-boot #f) pauses boot until user interaction Reply-To: bug#25917 <25917@debbugs.gnu.org> Date: Sun, 10 Aug 2025 23:50:00 +0000 retitle 25917 operating-system file-system with (check? #t) but (needed-for= -boot #f) pauses boot until user interaction reassign 25917 guix submitter 25917 Danny Milosavljevic severity 25917 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 01 11:38:57 2017 Received: (at submit) by debbugs.gnu.org; 1 Mar 2017 16:38:57 +0000 Received: from localhost ([127.0.0.1]:34640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cj7HF-00046S-4e for submit@debbugs.gnu.org; Wed, 01 Mar 2017 11:38:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cj7HD-000469-Q2 for submit@debbugs.gnu.org; Wed, 01 Mar 2017 11:38:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cj7H7-0000G2-Se for submit@debbugs.gnu.org; Wed, 01 Mar 2017 11:38:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46986) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cj7H7-0000Fw-PT for submit@debbugs.gnu.org; Wed, 01 Mar 2017 11:38:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cj7H6-0007oS-QE for bug-guix@gnu.org; Wed, 01 Mar 2017 11:38:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cj7H2-0000Df-Oq for bug-guix@gnu.org; Wed, 01 Mar 2017 11:38:48 -0500 Received: from dd1012.kasserver.com ([85.13.128.8]:55652) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cj7H2-0000Cx-Hw for bug-guix@gnu.org; Wed, 01 Mar 2017 11:38:44 -0500 Received: from localhost (77.118.20.175.wireless.dyn.drei.com [77.118.20.175]) by dd1012.kasserver.com (Postfix) with ESMTPSA id AC2E41CA080C for ; Wed, 1 Mar 2017 17:38:42 +0100 (CET) Date: Wed, 1 Mar 2017 17:38:38 +0100 From: Danny Milosavljevic To: Subject: operating-system file-system with (check? #t) but (needed-for-boot #f) pauses boot until user interaction Message-ID: <20170301173838.797d5dbc@scratchpost.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) If one has a operating-system file-system with (check? #t) but (needed-for-boot #f), the next boot after reconfiguring will boot into a Guile REPL because the initrd doesn't contain the fsck tool for that file system (because all the file-systems with (needed-for-boot #f) have been filtered out). Therefore, the normal boot process breaks. Possible fixes: - If (check? #t) but (needed-for-boot? #f), include the tool anyway, XOR - If (check? #t) but (needed-for-boot? #f), don't check anyway This can be reproduced for example by connecting an USB flash storage stick with a filesystem with a type on it that's not used in any other file-system declaration. NB: If (check? #t) and (needed-for-boot? #t), everything works fine. For all these, (mount? #t) (the default). This is on Guix master from a few minutes ago. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 11 06:21:42 2017 Received: (at 25917) by debbugs.gnu.org; 11 Mar 2017 11:21:42 +0000 Received: from localhost ([127.0.0.1]:50341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmf5h-0006bk-Ox for submit@debbugs.gnu.org; Sat, 11 Mar 2017 06:21:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmf5g-0006bY-M7 for 25917@debbugs.gnu.org; Sat, 11 Mar 2017 06:21:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmf5Y-0000Sp-G3 for 25917@debbugs.gnu.org; Sat, 11 Mar 2017 06:21:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmf5Y-0000Sl-D8; Sat, 11 Mar 2017 06:21:32 -0500 Received: from reverse-83.fdn.fr ([80.67.176.83]:35812 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cmf5W-0007Mv-S7; Sat, 11 Mar 2017 06:21:31 -0500 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: bug#25917: operating-system file-system with (check? #t) but (needed-for-boot #f) pauses boot until user interaction References: <20170301173838.797d5dbc@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 21 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sat, 11 Mar 2017 12:21:28 +0100 In-Reply-To: <20170301173838.797d5dbc@scratchpost.org> (Danny Milosavljevic's message of "Wed, 1 Mar 2017 17:38:38 +0100") Message-ID: <87wpbw83ev.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Danny, Danny Milosavljevic skribis: > If one has a operating-system file-system with (check? #t) but (needed-fo= r-boot #f), the next boot after reconfiguring will boot into a Guile REPL b= ecause the initrd doesn't contain the fsck tool for that file system (becau= se all the file-systems with (needed-for-boot #f) have been filtered out). = Therefore, the normal boot process breaks. > > Possible fixes: > - If (check? #t) but (needed-for-boot? #f), include the tool anyway, XOR > - If (check? #t) but (needed-for-boot? #f), don't check anyway I think we should do the latter. When needed-for-boot? is #f, the check is performed by the Shepherd service that takes care of the file system: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/base.scm#n291 Can you look into it? Thanks for the report! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 12 12:56:23 2017 Received: (at 25917) by debbugs.gnu.org; 12 Mar 2017 16:56:23 +0000 Received: from localhost ([127.0.0.1]:52814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn6n9-0008Gt-2C for submit@debbugs.gnu.org; Sun, 12 Mar 2017 12:56:23 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:34877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn6n6-0008Gk-Ai for 25917@debbugs.gnu.org; Sun, 12 Mar 2017 12:56:20 -0400 Received: from dayas.3.home (77.116.251.225.wireless.dyn.drei.com [77.116.251.225]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 489E41CA0621; Sun, 12 Mar 2017 17:56:17 +0100 (CET) From: Danny Milosavljevic To: 25917@debbugs.gnu.org Subject: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot. Date: Sun, 12 Mar 2017 17:56:04 +0100 Message-Id: <20170312165604.1273-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <87wpbw83ev.fsf@gnu.org> References: <87wpbw83ev.fsf@gnu.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25917 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/services/base.scm (file-system-shepherd-service): If not #:needed-for-boot, don't check filesystem even if #:check? . --- gnu/services/base.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 5298a11f6..2628b718f 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -274,6 +274,7 @@ FILE-SYSTEM." (options (file-system-options file-system)) (check? (file-system-check? file-system)) (create? (file-system-create-mount-point? file-system)) + (needed-for-boot? (file-system-needed-for-boot? file-system)) (dependencies (file-system-dependencies file-system))) (and (file-system-mount? file-system) (with-imported-modules '((gnu build file-systems) @@ -300,7 +301,7 @@ FILE-SYSTEM." (lambda () (mount-file-system `(#$device #$title #$target #$type #$flags - #$options #$check?) + #$options #$(and check? needed-for-boot?)) #:root "/")) (lambda () (setenv "PATH" $PATH))) From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 12 13:01:28 2017 Received: (at 25917) by debbugs.gnu.org; 12 Mar 2017 17:01:29 +0000 Received: from localhost ([127.0.0.1]:52820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn6s4-0008Q2-OQ for submit@debbugs.gnu.org; Sun, 12 Mar 2017 13:01:28 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:35182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn6s3-0008Pu-73 for 25917@debbugs.gnu.org; Sun, 12 Mar 2017 13:01:27 -0400 Received: from dayas.3.home (77.116.251.225.wireless.dyn.drei.com [77.116.251.225]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 055A31CA0560; Sun, 12 Mar 2017 18:01:20 +0100 (CET) From: Danny Milosavljevic To: 25917@debbugs.gnu.org Subject: [PATCH v2] services: If a filesystem is not marked as needed for boot, don't check it even if told to check it. Date: Sun, 12 Mar 2017 17:59:58 +0100 Message-Id: <20170312165958.1690-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <87wpbw83ev.fsf@gnu.org> References: <87wpbw83ev.fsf@gnu.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25917 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/services/base.scm (file-system-shepherd-service): If not #:needed-for-boot, don't check filesystem even if #:check? . --- gnu/services/base.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 5298a11f6..2628b718f 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -274,6 +274,7 @@ FILE-SYSTEM." (options (file-system-options file-system)) (check? (file-system-check? file-system)) (create? (file-system-create-mount-point? file-system)) + (needed-for-boot? (file-system-needed-for-boot? file-system)) (dependencies (file-system-dependencies file-system))) (and (file-system-mount? file-system) (with-imported-modules '((gnu build file-systems) @@ -300,7 +301,7 @@ FILE-SYSTEM." (lambda () (mount-file-system `(#$device #$title #$target #$type #$flags - #$options #$check?) + #$options #$(and check? needed-for-boot?)) #:root "/")) (lambda () (setenv "PATH" $PATH))) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 05:01:49 2017 Received: (at 25917) by debbugs.gnu.org; 13 Mar 2017 09:01:49 +0000 Received: from localhost ([127.0.0.1]:53194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnLrR-0001Hf-H7 for submit@debbugs.gnu.org; Mon, 13 Mar 2017 05:01:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnLrP-0001HS-G4 for 25917@debbugs.gnu.org; Mon, 13 Mar 2017 05:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnLrE-0006rd-AE for 25917@debbugs.gnu.org; Mon, 13 Mar 2017 05:01:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnLrE-0006rQ-72; Mon, 13 Mar 2017 05:01:36 -0400 Received: from [193.50.110.173] (port=48130 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cnLrD-0002wy-N0; Mon, 13 Mar 2017 05:01:36 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot. References: <87wpbw83ev.fsf@gnu.org> <20170312165604.1273-1-dannym@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 13 Mar 2017 10:01:32 +0100 In-Reply-To: <20170312165604.1273-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Sun, 12 Mar 2017 17:56:04 +0100") Message-ID: <878to9bleb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) Danny Milosavljevic skribis: > * gnu/services/base.scm (file-system-shepherd-service): If > not #:needed-for-boot, don't check filesystem even if #:check? . > --- > gnu/services/base.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gnu/services/base.scm b/gnu/services/base.scm > index 5298a11f6..2628b718f 100644 > --- a/gnu/services/base.scm > +++ b/gnu/services/base.scm > @@ -274,6 +274,7 @@ FILE-SYSTEM." > (options (file-system-options file-system)) > (check? (file-system-check? file-system)) > (create? (file-system-create-mount-point? file-system)) > + (needed-for-boot? (file-system-needed-for-boot? file-system)) > (dependencies (file-system-dependencies file-system))) > (and (file-system-mount? file-system) > (with-imported-modules '((gnu build file-systems) > @@ -300,7 +301,7 @@ FILE-SYSTEM." > (lambda () > (mount-file-system > `(#$device #$title #$target #$type #$flags > - #$options #$check?) > + #$options #$(and check? needed-= for-boot?)) > #:root "/")) > (lambda () > (setenv "PATH" $PATH))) One thing I don=E2=80=99t get is that, if the file system is not needed-for-boot?, then it doesn=E2=80=99t get a Shepherd service in the fir= st place. In your original message, you wrote that the problem is that =E2=80=9Cthe i= nitrd doesn't contain the fsck tool=E2=80=9D, so it=E2=80=99s a problem in linux-= initrd.scm, no? What am I missing? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 15:55:14 2017 Received: (at 25917) by debbugs.gnu.org; 13 Mar 2017 19:55:14 +0000 Received: from localhost ([127.0.0.1]:54334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnW3m-0007Mh-Hx for submit@debbugs.gnu.org; Mon, 13 Mar 2017 15:55:14 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:45872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnW3j-0007MX-Vi for 25917@debbugs.gnu.org; Mon, 13 Mar 2017 15:55:12 -0400 Received: from localhost (77.118.78.49.wireless.dyn.drei.com [77.118.78.49]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 807B81CA0560; Mon, 13 Mar 2017 20:55:09 +0100 (CET) Date: Mon, 13 Mar 2017 20:55:04 +0100 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot. Message-ID: <20170313205504.485459c8@scratchpost.org> In-Reply-To: <878to9bleb.fsf@gnu.org> References: <87wpbw83ev.fsf@gnu.org> <20170312165604.1273-1-dannym@scratchpost.org> <878to9bleb.fsf@gnu.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > One thing I don=E2=80=99t get is that, if the file system is not > needed-for-boot?, then it doesn=E2=80=99t get a Shepherd service in the f= irst > place. But what is supposed to happen to filesystems where mount? but not needed-f= or-boot? if Shepherd doesn't mount it? Does some other part mount it ? Is= it just put into fstab or something ? > In your original message, you wrote that the problem is that =E2=80=9Cthe= initrd > doesn't contain the fsck tool=E2=80=9D, so it=E2=80=99s a problem in linu= x-initrd.scm, > no? I don't know where we should fix it. If you want to reproduce it, I tested= it with this config (file-systems (cons* ... (file-system (device "NO NAME") (title 'label) (mount-point "/mnt/tmp") (type "vfat") (needed-for-boot? #f) (mount? #t) (check? #t)) %base-file-systems)) and an USB flash memory stick with name "NO NAME" (the default of the stick= :) ). The effect is if not needed-for-boot? but check? , the boot breaks because = it can't find fsck.vfat . vfat is good for testing this since it's usually the only filesystem of tha= t type on the system and so it can't be required by another filesystem entr= y and mask the problem. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 04:41:47 2017 Received: (at 25917) by debbugs.gnu.org; 14 Mar 2017 08:41:47 +0000 Received: from localhost ([127.0.0.1]:54728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cni1a-0002Kq-U2 for submit@debbugs.gnu.org; Tue, 14 Mar 2017 04:41:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cni1Z-0002Kd-Gk for 25917@debbugs.gnu.org; Tue, 14 Mar 2017 04:41:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cni1Q-0007gD-H3 for 25917@debbugs.gnu.org; Tue, 14 Mar 2017 04:41:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cni1Q-0007g2-Dj; Tue, 14 Mar 2017 04:41:36 -0400 Received: from [193.50.110.133] (port=40210 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cni1P-0005fE-Qh; Tue, 14 Mar 2017 04:41:36 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot. References: <87wpbw83ev.fsf@gnu.org> <20170312165604.1273-1-dannym@scratchpost.org> <878to9bleb.fsf@gnu.org> <20170313205504.485459c8@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 14 Mar 2017 09:41:32 +0100 In-Reply-To: <20170313205504.485459c8@scratchpost.org> (Danny Milosavljevic's message of "Mon, 13 Mar 2017 20:55:04 +0100") Message-ID: <87mvcop7wj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) Danny Milosavljevic skribis: >> One thing I don=E2=80=99t get is that, if the file system is not >> needed-for-boot?, then it doesn=E2=80=99t get a Shepherd service in the = first >> place. > > But what is supposed to happen to filesystems where mount? but not needed= -for-boot? if Shepherd doesn't mount it? Does some other part mount it ? = Is it just put into fstab or something ? Yes, it=E2=80=99s just put in fstab. The use case for this is that then yo= u can type just =E2=80=9Cmount /mnt/foo=E2=80=9D and =E2=80=98mount=E2=80=99 look= s it up in /etc/fstab and does the right thing. >> In your original message, you wrote that the problem is that =E2=80=9Cth= e initrd >> doesn't contain the fsck tool=E2=80=9D, so it=E2=80=99s a problem in lin= ux-initrd.scm, >> no? > > I don't know where we should fix it. If you want to reproduce it, I test= ed it with this config > > (file-systems (cons* ... > (file-system > (device "NO NAME") > (title 'label) > (mount-point "/mnt/tmp") > (type "vfat") > (needed-for-boot? #f) > (mount? #t) > (check? #t)) > %base-file-systems)) > > and an USB flash memory stick with name "NO NAME" (the default of the sti= ck :) ). > > The effect is if not needed-for-boot? but check? , the boot breaks becaus= e it can't find fsck.vfat . Ooh, I think that=E2=80=99s another problem, then. :-) =E2=80=98file-system-shepherd-service=E2=80=99 is bogus: it only handles ex= t2: (setenv "PATH" (string-append #$e2fsprogs "/sbin:" "/run/current-system/profile/sbin:" $PATH))) We should fix that to handle vfat, btrfs, etc., just like =E2=80=98base-ini= trd=E2=80=99 does. In fact, we should extract the =E2=80=98helper-packages=E2=80=99 thi= ng from there and factorize it between linux-initrd.scm and services/base.scm. How does that sound? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 15:18:16 2017 Received: (at 25917) by debbugs.gnu.org; 14 Mar 2017 19:18:16 +0000 Received: from localhost ([127.0.0.1]:55992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnrxY-0005Sa-22 for submit@debbugs.gnu.org; Tue, 14 Mar 2017 15:18:16 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:44651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnrxW-0005SS-Ti for 25917@debbugs.gnu.org; Tue, 14 Mar 2017 15:18:15 -0400 Received: from localhost (77.116.195.88.wireless.dyn.drei.com [77.116.195.88]) by dd1012.kasserver.com (Postfix) with ESMTPSA id CBB461CA0DA9; Tue, 14 Mar 2017 20:18:11 +0100 (CET) Date: Tue, 14 Mar 2017 20:18:09 +0100 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot. Message-ID: <20170314201809.33feb843@scratchpost.org> In-Reply-To: <87mvcop7wj.fsf@gnu.org> References: <87wpbw83ev.fsf@gnu.org> <20170312165604.1273-1-dannym@scratchpost.org> <878to9bleb.fsf@gnu.org> <20170313205504.485459c8@scratchpost.org> <87mvcop7wj.fsf@gnu.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, On Tue, 14 Mar 2017 09:41:32 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Danny Milosavljevic skribis: >=20 > >> One thing I don=E2=80=99t get is that, if the file system is not > >> needed-for-boot?, then it doesn=E2=80=99t get a Shepherd service in th= e first > >> place. =20 > > > > But what is supposed to happen to filesystems where mount? but not need= ed-for-boot? if Shepherd doesn't mount it? Does some other part mount it ?= Is it just put into fstab or something ? =20 >=20 > Yes, it=E2=80=99s just put in fstab. The use case for this is that then = you can > type just =E2=80=9Cmount /mnt/foo=E2=80=9D and =E2=80=98mount=E2=80=99 lo= oks it up in /etc/fstab and > does the right thing. >=20 > >> In your original message, you wrote that the problem is that =E2=80=9C= the initrd > >> doesn't contain the fsck tool=E2=80=9D, so it=E2=80=99s a problem in l= inux-initrd.scm, > >> no? =20 > > > > I don't know where we should fix it. If you want to reproduce it, I te= sted it with this config > > > > (file-systems (cons* ... > > (file-system > > (device "NO NAME") > > (title 'label) > > (mount-point "/mnt/tmp") > > (type "vfat") > > (needed-for-boot? #f) > > (mount? #t) > > (check? #t)) > > %base-file-systems)) > > > > and an USB flash memory stick with name "NO NAME" (the default of the s= tick :) ). > > > > The effect is if not needed-for-boot? but check? , the boot breaks beca= use it can't find fsck.vfat . =20 >=20 > Ooh, I think that=E2=80=99s another problem, then. :-) >=20 > =E2=80=98file-system-shepherd-service=E2=80=99 is bogus: it only handles = ext2: >=20 > (setenv "PATH" > (string-append > #$e2fsprogs "/sbin:" > "/run/current-system/profile/sbin:" > $PATH))) Oops... > We should fix that to handle vfat, btrfs, etc., just like =E2=80=98base-i= nitrd=E2=80=99 > does. In fact, we should extract the =E2=80=98helper-packages=E2=80=99 t= hing from > there and factorize it between linux-initrd.scm and services/base.scm. Sounds good! However, the above has (needed-for-boot? #f) and Guix still tries to check = / mount it. Why? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 16:18:51 2017 Received: (at 25917) by debbugs.gnu.org; 14 Mar 2017 20:18:51 +0000 Received: from localhost ([127.0.0.1]:56062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnsuB-0006tm-GC for submit@debbugs.gnu.org; Tue, 14 Mar 2017 16:18:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnsu9-0006tZ-AD for 25917@debbugs.gnu.org; Tue, 14 Mar 2017 16:18:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnsu0-0005Ug-BI for 25917@debbugs.gnu.org; Tue, 14 Mar 2017 16:18:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnsu0-0005Uc-88; Tue, 14 Mar 2017 16:18:40 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:51406 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cnstz-0008LF-Ge; Tue, 14 Mar 2017 16:18:39 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot. References: <87wpbw83ev.fsf@gnu.org> <20170312165604.1273-1-dannym@scratchpost.org> <878to9bleb.fsf@gnu.org> <20170313205504.485459c8@scratchpost.org> <87mvcop7wj.fsf@gnu.org> <20170314201809.33feb843@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 14 Mar 2017 21:18:37 +0100 In-Reply-To: <20170314201809.33feb843@scratchpost.org> (Danny Milosavljevic's message of "Tue, 14 Mar 2017 20:18:09 +0100") Message-ID: <87y3w7a9ya.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Danny, Danny Milosavljevic skribis: >> > (file-systems (cons* ... >> > (file-system >> > (device "NO NAME") >> > (title 'label) >> > (mount-point "/mnt/tmp") >> > (type "vfat") >> > (needed-for-boot? #f) >> > (mount? #t) >> > (check? #t)) >> > %base-file-systems)) [...] > However, the above has (needed-for-boot? #f) and Guix still tries to chec= k / mount it. Why? It has (mount? #t), that=E2=80=99s why it=E2=80=99s mounting and checking i= t. With (mount? #f), it wouldn=E2=80=99t do anything other than adding a line = in /etc/fstab. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 13:40:48 2017 Received: (at 25917) by debbugs.gnu.org; 16 Mar 2017 17:40:48 +0000 Received: from localhost ([127.0.0.1]:59190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coZOK-0005Qq-L3 for submit@debbugs.gnu.org; Thu, 16 Mar 2017 13:40:48 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:56860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coZOI-0005Qg-1Q for 25917@debbugs.gnu.org; Thu, 16 Mar 2017 13:40:47 -0400 Received: from dayas.3.home (178.113.220.108.wireless.dyn.drei.com [178.113.220.108]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 457581CA003A; Thu, 16 Mar 2017 18:40:44 +0100 (CET) From: Danny Milosavljevic To: 25917@debbugs.gnu.org, ludo@gnu.org Subject: [PATCH] file-systems: Factorize file-system-packages. Date: Thu, 16 Mar 2017 18:40:29 +0100 Message-Id: <20170316174029.1663-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.0 Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25917 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/system/linux-initrd.scm (base-initrd): Move helper-packages body to ... * gnu/system/file-systems.scm (file-system-packages): ... here. Also export it. * gnu/services/base.scm (file-system-shepherd-service): Set PATH by using file-system-packages. --- gnu/services/base.scm | 12 ++++++------ gnu/system/file-systems.scm | 26 ++++++++++++++++++++++++++ gnu/system/linux-initrd.scm | 18 +----------------- 3 files changed, 33 insertions(+), 23 deletions(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 5298a11f6..f3224aae1 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -274,7 +274,9 @@ FILE-SYSTEM." (options (file-system-options file-system)) (check? (file-system-check? file-system)) (create? (file-system-create-mount-point? file-system)) - (dependencies (file-system-dependencies file-system))) + (needed-for-boot? (file-system-needed-for-boot? file-system)) + (dependencies (file-system-dependencies file-system)) + (packages (file-system-packages (list file-system)))) (and (file-system-mount? file-system) (with-imported-modules '((gnu build file-systems) (guix build bournish)) @@ -292,11 +294,9 @@ FILE-SYSTEM." ;; Make sure fsck.ext2 & co. can be found. (dynamic-wind (lambda () - (setenv "PATH" - (string-append - #$e2fsprogs "/sbin:" - "/run/current-system/profile/sbin:" - $PATH))) + (set-path-environment-variable "PATH" + '("bin" "sbin") + '#$packages)) (lambda () (mount-file-system `(#$device #$title #$target #$type #$flags diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 7011a279d..8107722c7 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -22,6 +22,8 @@ #:use-module (guix records) #:use-module ((gnu build file-systems) #:select (string->uuid uuid->string)) + #:use-module (gnu packages linux) + #:use-module (gnu packages disk) #:re-export (string->uuid uuid->string) #:export ( @@ -65,6 +67,8 @@ file-system-mapping->bind-mount + file-system-packages + %store-mapping %network-configuration-files %network-file-mappings)) @@ -411,4 +415,26 @@ a bind mount." (writable? (string=? file "/etc/resolv.conf")))) %network-configuration-files)) +(define (file-system-type-predicate type) + (lambda (fs) + (string=? (file-system-type fs) type))) + +(define* (file-system-packages file-systems #:key (volatile-root? #f)) + `(,@(if (find (lambda (fs) + (string-prefix? "ext" (file-system-type fs))) + file-systems) + (list e2fsck/static) + '()) + ,@(if (find (lambda (fs) + (string-suffix? "fat" (file-system-type fs))) + file-systems) + (list fatfsck/static) + '()) + ,@(if (find (file-system-type-predicate "btrfs") file-systems) + (list btrfs-progs/static) + '()) + ,@(if volatile-root? + (list unionfs-fuse/static) + '()))) + ;;; file-systems.scm ends here diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm index 81c1278c0..1f1c30682 100644 --- a/gnu/system/linux-initrd.scm +++ b/gnu/system/linux-initrd.scm @@ -272,23 +272,7 @@ loaded at boot time in the order in which they appear." ,@extra-modules)) (define helper-packages - ;; Packages to be copied on the initrd. - `(,@(if (find (lambda (fs) - (string-prefix? "ext" (file-system-type fs))) - file-systems) - (list e2fsck/static) - '()) - ,@(if (find (lambda (fs) - (string-suffix? "fat" (file-system-type fs))) - file-systems) - (list fatfsck/static) - '()) - ,@(if (find (file-system-type-predicate "btrfs") file-systems) - (list btrfs-progs/static) - '()) - ,@(if volatile-root? - (list unionfs-fuse/static) - '()))) + (file-system-packages file-systems #:volatile-root? volatile-root?)) (raw-initrd file-systems #:linux linux From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 05:04:05 2017 Received: (at 25917) by debbugs.gnu.org; 17 Mar 2017 09:04:05 +0000 Received: from localhost ([127.0.0.1]:59594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1conno-0006lH-Nw for submit@debbugs.gnu.org; Fri, 17 Mar 2017 05:04:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1connn-0006ko-Rs for 25917@debbugs.gnu.org; Fri, 17 Mar 2017 05:04:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1conne-0003HA-LA for 25917@debbugs.gnu.org; Fri, 17 Mar 2017 05:03:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1conne-0003H6-Hw; Fri, 17 Mar 2017 05:03:54 -0400 Received: from [193.50.110.167] (port=37308 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1connd-00065O-Uw; Fri, 17 Mar 2017 05:03:54 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [PATCH] file-systems: Factorize file-system-packages. References: <20170316174029.1663-1-dannym@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 17 Mar 2017 10:03:52 +0100 In-Reply-To: <20170316174029.1663-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Thu, 16 Mar 2017 18:40:29 +0100") Message-ID: <87efxwi8av.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Danny, Danny Milosavljevic skribis: > * gnu/system/linux-initrd.scm (base-initrd): Move helper-packages body to= ... > * gnu/system/file-systems.scm (file-system-packages): ... here. > Also export it. > * gnu/services/base.scm (file-system-shepherd-service): Set PATH by using > file-system-packages. Exactly what we need! Could you just make it two patches: 1. introduce =E2=80=98file-system-packages=E2=80=99; 2. Use it in =E2=80=98file-system-shepherd-service=E2=80=99. > +(define (file-system-type-predicate type) > + (lambda (fs) > + (string=3D? (file-system-type fs) type))) > + > +(define* (file-system-packages file-systems #:key (volatile-root? #f)) Please add a docstring to these procedures. You can also remove the now-unused =E2=80=98file-system-type-predicate=E2= =80=99 procedure that is in =E2=80=98base-initrd=E2=80=99. OK with these changes. Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 08:20:05 2017 Received: (at 25917) by debbugs.gnu.org; 17 Mar 2017 12:20:05 +0000 Received: from localhost ([127.0.0.1]:59749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coqrU-0004xa-Tw for submit@debbugs.gnu.org; Fri, 17 Mar 2017 08:20:05 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:35394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coqrT-0004xS-8G for 25917@debbugs.gnu.org; Fri, 17 Mar 2017 08:20:03 -0400 Received: from localhost (178.113.165.41.wireless.dyn.drei.com [178.113.165.41]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 988781CA003A; Fri, 17 Mar 2017 13:20:00 +0100 (CET) Date: Fri, 17 Mar 2017 13:19:58 +0100 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: [PATCH] file-systems: Factorize file-system-packages. Message-ID: <20170317131958.734cdfba@scratchpost.org> In-Reply-To: <87efxwi8av.fsf@gnu.org> References: <20170316174029.1663-1-dannym@scratchpost.org> <87efxwi8av.fsf@gnu.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, On Fri, 17 Mar 2017 10:03:52 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > You can also remove the now-unused =E2=80=98file-system-type-predicate=E2= =80=99 > procedure that is in =E2=80=98base-initrd=E2=80=99. It's still used there (in order to determine the Linux modules). Should I = also export 'file-system-type-predicate` from file-systems.scm and use that= in 'base-initrd` ? I thought it was too special-case to be a public funct= ion. Also, it seems that the new version (which now uses `set-path-environment-v= ariable') clears the old PATH whereas the previous version prepended to it. The previous version has: (setenv "PATH" (string-append #$e2fsprogs "/sbin:" "/run/current-system/profile/sbin:" $PATH))) (What does "$" without "#" do?) The new version would have: (lambda () (set-path-environment-variable "PATH" '("bin" "sbin") '#$packages)) It works fine - however, I get a warning that PATH has been unset at bootup. Should we replicate the previous behaviour? What's up with the hard-coded "/run/current-system/profile/sbin" ? From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 05:42:40 2017 Received: (at 25917) by debbugs.gnu.org; 18 Mar 2017 09:42:40 +0000 Received: from localhost ([127.0.0.1]:33252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpAsi-0003nU-7n for submit@debbugs.gnu.org; Sat, 18 Mar 2017 05:42:40 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:38033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpAsg-0003nM-2P for 25917@debbugs.gnu.org; Sat, 18 Mar 2017 05:42:38 -0400 Received: from localhost (178.113.165.41.wireless.dyn.drei.com [178.113.165.41]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 7A4AE1CA0702; Sat, 18 Mar 2017 10:42:36 +0100 (CET) Date: Sat, 18 Mar 2017 10:42:33 +0100 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: [PATCH] file-systems: Factorize file-system-packages. Message-ID: <20170318104233.4b2612cc@scratchpost.org> In-Reply-To: <87efxwi8av.fsf@gnu.org> References: <20170316174029.1663-1-dannym@scratchpost.org> <87efxwi8av.fsf@gnu.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > > * gnu/system/linux-initrd.scm (base-initrd): Move helper-packages body to ... > > * gnu/system/file-systems.scm (file-system-packages): ... here. > > Also export it. Pushed those to master as 7208995426714c9fc3ad59cadc3cc0f52df0f018. > > * gnu/services/base.scm (file-system-shepherd-service): Set PATH by using > > file-system-packages. Will post these to the bugreport first. It also requires a change in guix/build/utils.scm in order for it not to drop the existing search path. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 07:01:00 2017 Received: (at 25917) by debbugs.gnu.org; 18 Mar 2017 11:01:00 +0000 Received: from localhost ([127.0.0.1]:33288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpC6W-0005p5-Hu for submit@debbugs.gnu.org; Sat, 18 Mar 2017 07:01:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpC6V-0005ok-AG for 25917@debbugs.gnu.org; Sat, 18 Mar 2017 07:00:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpC6M-0002vq-UL for 25917@debbugs.gnu.org; Sat, 18 Mar 2017 07:00:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpC6M-0002vm-RN; Sat, 18 Mar 2017 07:00:50 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:45404 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cpC6M-0000n0-2z; Sat, 18 Mar 2017 07:00:50 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [PATCH] file-systems: Factorize file-system-packages. References: <20170316174029.1663-1-dannym@scratchpost.org> <87efxwi8av.fsf@gnu.org> <20170317131958.734cdfba@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sat, 18 Mar 2017 12:00:47 +0100 In-Reply-To: <20170317131958.734cdfba@scratchpost.org> (Danny Milosavljevic's message of "Fri, 17 Mar 2017 13:19:58 +0100") Message-ID: <87mvcialy8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello! Danny Milosavljevic skribis: > On Fri, 17 Mar 2017 10:03:52 +0100 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> You can also remove the now-unused =E2=80=98file-system-type-predicate= =E2=80=99 >> procedure that is in =E2=80=98base-initrd=E2=80=99. > > It's still used there (in order to determine the Linux modules). Should = I also export 'file-system-type-predicate` from file-systems.scm and use th= at in 'base-initrd` ? I thought it was too special-case to be a public fun= ction. > > Also, it seems that the new version (which now uses `set-path-environment= -variable') clears the old PATH whereas the previous version prepended to i= t. > > The previous version has: > > (setenv "PATH" > (string-append > #$e2fsprogs "/sbin:" > "/run/current-system/profile/sbin:" > $PATH))) > > (What does "$" without "#" do?) #$ is synonymous for =E2=80=98ungexp=E2=80=99; $ alone has no special meani= ng, and $PATH is a regular identifier. > The new version would have: > > (lambda () > (set-path-environment-variable "PATH" > '("bin" "sbin= ") > '#$packages)) > > It works fine - however, I get a warning that PATH has been unset at boot= up. You could shut it up like this: ;; Don=E2=80=99t display the PATH settings. (with-output-to-port (%make-void-port "w") (lambda () (set-path-environment-variable =E2=80=A6))) > What's up with the hard-coded "/run/current-system/profile/sbin" ? I traced it back to 1b09031f786238b21ab10ba4c3e384ab194735df. I think you can remove it (probably the idea was that we were =E2=80=9Clikely=E2=80= =9D to find other fsck commands in /run/current-system/profile/sbin, not very reliable=E2=80=A6). HTH! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 07:04:52 2017 Received: (at 25917) by debbugs.gnu.org; 18 Mar 2017 11:04:52 +0000 Received: from localhost ([127.0.0.1]:33298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpCAG-0005vJ-AF for submit@debbugs.gnu.org; Sat, 18 Mar 2017 07:04:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpCAF-0005v7-6I for 25917@debbugs.gnu.org; Sat, 18 Mar 2017 07:04:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpCA7-0004I9-3y for 25917@debbugs.gnu.org; Sat, 18 Mar 2017 07:04:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpCA7-0004Hz-16; Sat, 18 Mar 2017 07:04:43 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:45406 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cpCA6-0006m0-CR; Sat, 18 Mar 2017 07:04:42 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [PATCH] file-systems: Factorize file-system-packages. References: <20170316174029.1663-1-dannym@scratchpost.org> <87efxwi8av.fsf@gnu.org> <20170317131958.734cdfba@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sat, 18 Mar 2017 12:04:40 +0100 In-Reply-To: <20170317131958.734cdfba@scratchpost.org> (Danny Milosavljevic's message of "Fri, 17 Mar 2017 16:02:53 +0100") Message-ID: <87inn6alrr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Danny Milosavljevic skribis: > I'd like to make the following change to guix/build/utils.scm : > > diff --git a/guix/build/utils.scm b/guix/build/utils.scm > index bc6f11415..ca6360ed4 100644 > --- a/guix/build/utils.scm > +++ b/guix/build/utils.scm > @@ -409,7 +409,8 @@ for under the directories designated by FILES. For e= xample: > #:key > (separator ":") > (type 'directory) > - pattern) > + pattern > + keep-previous-path?) > "Look for each of FILES of the given TYPE (a symbol as returned by > 'stat:type') in INPUT-DIRS. Set ENV-VAR to a SEPARATOR-separated path > accordingly. Example: > @@ -430,7 +431,13 @@ denoting file names to look for under the directorie= s designated by FILES: > (let* ((path (search-path-as-list files input-dirs > #:type type > #:pattern pattern)) > - (value (list->search-path-as-string path separator))) > + (value (list->search-path-as-string path separator)) > + (previous-path (getenv env-var)) > + (value (if (and keep-previous-path? > + previous-path > + (not (string-null? previous-path))) > + (string-append value ":" previous-path) > + value))) > (if (string-null? value) > (begin > ;; Never set ENV-VAR to an empty string because often, the emp= ty > > Would that rebuild the world, though? Yep. I don=E2=80=99t think that is needed though: we can use =E2=80=98set-path-environment-variables=E2=80=99 like your patch did to set= PATH precisely. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 10:06:41 2017 Received: (at 25917) by debbugs.gnu.org; 18 Mar 2017 14:06:41 +0000 Received: from localhost ([127.0.0.1]:34014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpF0B-0005i9-Uq for submit@debbugs.gnu.org; Sat, 18 Mar 2017 10:06:40 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:50015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpF0A-0005i1-7s for 25917@debbugs.gnu.org; Sat, 18 Mar 2017 10:06:38 -0400 Received: from dayas.3.home (178.113.146.244.wireless.dyn.drei.com [178.113.146.244]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 6D8011CA070A; Sat, 18 Mar 2017 15:06:36 +0100 (CET) From: Danny Milosavljevic To: 25917@debbugs.gnu.org, ludo@gnu.org Subject: [PATCH v2] services: file-system-shepherd-service: Make it find the fsck programs. Date: Sat, 18 Mar 2017 15:06:32 +0100 Message-Id: <20170318140632.1778-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170316174029.1663-1-dannym@scratchpost.org> References: <20170316174029.1663-1-dannym@scratchpost.org> MIME-Version: 1.0 Tags: patch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25917 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/services/base.scm (file-system-shepherd-service): Use file-system-packages. --- gnu/services/base.scm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 5298a11f6..ab5030146 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -274,7 +274,8 @@ FILE-SYSTEM." (options (file-system-options file-system)) (check? (file-system-check? file-system)) (create? (file-system-create-mount-point? file-system)) - (dependencies (file-system-dependencies file-system))) + (dependencies (file-system-dependencies file-system)) + (packages (file-system-packages (list file-system)))) (and (file-system-mount? file-system) (with-imported-modules '((gnu build file-systems) (guix build bournish)) @@ -292,11 +293,12 @@ FILE-SYSTEM." ;; Make sure fsck.ext2 & co. can be found. (dynamic-wind (lambda () - (setenv "PATH" - (string-append - #$e2fsprogs "/sbin:" - "/run/current-system/profile/sbin:" - $PATH))) + ;; Don’t display the PATH settings. + (with-output-to-port (%make-void-port "w") + (lambda () + (set-path-environment-variable "PATH" + '("bin" "sbin") + '#$packages)))) (lambda () (mount-file-system `(#$device #$title #$target #$type #$flags From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 11:44:33 2017 Received: (at 25917) by debbugs.gnu.org; 19 Mar 2017 15:44:33 +0000 Received: from localhost ([127.0.0.1]:35368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpd0T-0005tU-B2 for submit@debbugs.gnu.org; Sun, 19 Mar 2017 11:44:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpd0R-0005tH-OV for 25917@debbugs.gnu.org; Sun, 19 Mar 2017 11:44:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpd0J-0006ub-CV for 25917@debbugs.gnu.org; Sun, 19 Mar 2017 11:44:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpd0J-0006uV-9a; Sun, 19 Mar 2017 11:44:23 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:46526 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cpd0I-0007GM-Li; Sun, 19 Mar 2017 11:44:23 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [PATCH v2] services: file-system-shepherd-service: Make it find the fsck programs. References: <20170316174029.1663-1-dannym@scratchpost.org> <20170318140632.1778-1-dannym@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sun, 19 Mar 2017 16:44:18 +0100 In-Reply-To: <20170318140632.1778-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Sat, 18 Mar 2017 15:06:32 +0100") Message-ID: <87pohd46gd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25917 Cc: 25917@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Danny Milosavljevic skribis: > * gnu/services/base.scm (file-system-shepherd-service): Use > file-system-packages. Please add a =E2=80=9CFixes =E2=80=A6=E2=80=9D line in the commit message. = Other than that, if =E2=80=9Cmake check-system TESTS=3Dbasic=E2=80=9D passes, please push! Thank you, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 22 19:34:29 2017 Received: (at 25917-done) by debbugs.gnu.org; 22 Apr 2017 23:34:29 +0000 Received: from localhost ([127.0.0.1]:34888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d24Xs-00087l-PA for submit@debbugs.gnu.org; Sat, 22 Apr 2017 19:34:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d24Xr-00087X-Vd for 25917-done@debbugs.gnu.org; Sat, 22 Apr 2017 19:34:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d24Xi-0003vz-SM for 25917-done@debbugs.gnu.org; Sat, 22 Apr 2017 19:34:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d24Xi-0003vt-OX; Sat, 22 Apr 2017 19:34:18 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:55598 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d24Xi-0008J4-79; Sat, 22 Apr 2017 19:34:18 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: bug#25917: [PATCH v2] services: file-system-shepherd-service: Make it find the fsck programs. References: <20170316174029.1663-1-dannym@scratchpost.org> <20170318140632.1778-1-dannym@scratchpost.org> Date: Sun, 23 Apr 2017 01:34:15 +0200 In-Reply-To: <20170318140632.1778-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Sat, 18 Mar 2017 15:06:32 +0100") Message-ID: <87h91gf24o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25917-done Cc: 25917-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Danny Milosavljevic skribis: > * gnu/services/base.scm (file-system-shepherd-service): Use > file-system-packages. That was pushed as 26e34e1e1288d657e92372efb6edc95c0e299247. Closing. Ludo=E2=80=99. From unknown Sun Aug 10 16:50:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 21 May 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator