GNU bug report logs - #25916
[PATCH] gnu: mumble: Make builds bit-reproducible.

Previous Next

Full log

View this message in rfc822 format

From: Kei Kebreau <kei <at> openmailbox.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 25916 <at> debbugs.gnu.org
Subject: bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible.
Date: Wed, 01 Mar 2017 12:20:41 -0500

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Kei Kebreau <kei <at> openmailbox.org> writes:
>
>> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
>> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.
>
> Thanks a lot for this! The patch LGTM, but FYI won't be necessary once
> 'core-updates' is merged. See this commit, which backports a gcc7 patch.
>
> d71d6fe85c4db778be6a2081cbbec6a3a494e4f9
>

Yay, what a useful patch!

Aren't we pretty close to merging core-updates? If that's the case, I
won't worry about pushing this to master.

>> ---
>>  gnu/packages/telephony.scm | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
>> index 87261825c..4ff2acd25 100644
>> --- a/gnu/packages/telephony.scm
>> +++ b/gnu/packages/telephony.scm
>> @@ -330,6 +330,12 @@ address of one of the participants.")
>>                (modules '((guix build utils)))
>>                (snippet
>>                 `(begin
>> +                  ;; Remove timestamps for reproducibility.
>> +                  (substitute* "src/Version.h"
>> +                    (("\"Compiled \" __DATE__ \" \" __TIME__") "\"\""))
>> +                  (substitute* "src/mumble/VersionCheck.cpp"
>> +                    (("^.*__DATE__.*$") "")
>> +                    (("^.*__TIME__.*$") ""))
>>                    ;; Remove bundled software.
>>                    (for-each delete-file-recursively '("3rdparty"
>>                                                        "speex"
>> -- 
>> 2.12.0

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.