GNU bug report logs - #2591
Custom should warn if 'other is not the last in a choice

Previous Next

Package: emacs;

Reported by: rms <at> gnu.org

Date: Sat, 7 Mar 2009 04:05:13 UTC

Severity: normal

Merged with 65852

Found in version 30.0.50

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 2591 <at> debbugs.gnu.org
Cc: rms <at> gnu.org
Subject: bug#2591: Custom should warn if 'other is not the last in a choice
Date: Tue, 3 Oct 2023 19:21:26 -0300

close 2591 30.1
quit


Richard M Stallman <rms <at> gnu.org> writes:

> [ resent from
> http://lists.gnu.org/archive/html/emacs-devel/2009-03/msg00002.html ]
>
> Regarding this change,
>
>        :group 'find-file
>        :version "23.1"
>     -  :type '(choice (other :tag "Always" t)
>     -         (const :tag "After completion" after-completion)
>     -         (const :tag "Never" nil)))
>     +  :type '(choice (const :tag "After completion" after-completion)
>     +         (const :tag "Never" nil)
>     +         (other :tag "Always" t)))
>
> perhaps compiling defcustom should give an error if :other appears
> other than last.

commit f8ea47ebf45c5ea0cd788667f7bdb805f42e08e0 introduced many checks
for defcustom, including this.  See also Bug#65852

It's my conclusion that this Bug Report can be closed.  Feel free to
reopen if I'm mistaken.
This bug report was last modified 1 year and 225 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.