From unknown Sun Jun 22 08:02:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25908: [PATCH, WIP] Add godot. Resent-From: Christopher Allan Webber Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Mar 2017 04:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25908 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 25908@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14883436024452 (code B ref -1); Wed, 01 Mar 2017 04:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Mar 2017 04:46:42 +0000 Received: from localhost ([127.0.0.1]:60816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciw9r-00019Z-6y for submit@debbugs.gnu.org; Tue, 28 Feb 2017 23:46:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciw9p-00019J-Ou for submit@debbugs.gnu.org; Tue, 28 Feb 2017 23:46:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciw9j-0001Eb-3N for submit@debbugs.gnu.org; Tue, 28 Feb 2017 23:46:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ciw9i-0001EQ-Vz for submit@debbugs.gnu.org; Tue, 28 Feb 2017 23:46:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciw9h-0001bx-3s for guix-patches@gnu.org; Tue, 28 Feb 2017 23:46:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciw9d-0001BJ-F1 for guix-patches@gnu.org; Tue, 28 Feb 2017 23:46:25 -0500 Received: from dustycloud.org ([50.116.34.160]:38600) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ciw9d-0001B5-8i for guix-patches@gnu.org; Tue, 28 Feb 2017 23:46:21 -0500 Received: from oolong (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 315602664C for ; Tue, 28 Feb 2017 23:46:17 -0500 (EST) User-agent: mu4e 0.9.18; emacs 25.1.1 From: Christopher Allan Webber Date: Tue, 28 Feb 2017 22:46:16 -0600 Message-ID: <87mvd5r4dj.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --=-=-= Content-Type: text/plain This is still WIP, and unfortunately it doesn't work. Here's the error I got: from ./drivers/pulseaudio/audio_driver_pulseaudio.h:36, from platform/x11/os_x11.h:46, from platform/x11/godot_x11.cpp:30: /gnu/store/iwgi9001dmmihrjg4rqhd6pa6788prjw-glibc-2.24/include/bits/local_lim.h:38:26: fatal error: linux/limits.h: No such file or directory #include I also get this if I try to build it outside the package, from a git checkout of Godot. I don't know why I'm experiencing this; I added linux-libre-headers as an input. It seems that I'm not the first one to experience this with Guix packages... I ran across these: https://lists.gnu.org/archive/html/help-guix/2016-06/msg00130.html (I don't think I need to include gcc-toolchain though) https://gnunet.org/bot/log/guix/2016-07-27 https://gnunet.org/bot/log/guix/2016-08-03 looks like jlicht eventually found a solution, and lfam said jlicht: Have you tried setting -I in #:make-flags or #:configure-flags? ... not sure how that helps with scons :) Other potential issues: - bundles a number of packages (can they be easily unbundled?) - license field should probably reflect bundled packages - very badly snarfs a whole bunch of phases code from aria-maestosa, which itself suggests refactoring into a scons-build-system... Nonetheless, uh, maybe it's a good starting point! --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-Add-godot.patch Content-Transfer-Encoding: quoted-printable >From 8fe2eb621c0cc4556c112b0bd42714200f1332b2 Mon Sep 17 00:00:00 2001 From: Christopher Allan Webber Date: Tue, 28 Feb 2017 22:39:38 -0600 Subject: [PATCH] gnu: Add godot. * gnu/packages/game-development.scm (godot): New variable. --- gnu/packages/game-development.scm | 69 +++++++++++++++++++++++++++++++++= ++++++ 1 file changed, 69 insertions(+) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-develo= pment.scm index 619c2f1bc..2f03041b3 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -8,6 +8,7 @@ ;;; Copyright =C2=A9 2016 Kei Kebreau ;;; Copyright =C2=A9 2016 Ricardo Wurmus ;;; Copyright =C2=A9 2016 Julian Graham +;;; Copyright =C2=A9 2017 Christopher Allan Webber ;;; ;;; This file is part of GNU Guix. ;;; @@ -60,6 +61,7 @@ #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages sdl) + #:use-module (gnu packages tls) #:use-module (gnu packages pkg-config) #:use-module (gnu packages xiph) #:use-module (gnu packages lua) @@ -619,3 +621,70 @@ to create fully featured games and multimedia progra= ms in the python language.") license:psfl license:public-domain license:lgpl2.1+)))) + +(define-public godot + (package + (name "godot") + (version "2.1.2") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/godotengine/godot/archive/" + version "-stable.tar.gz")) + (sha256 + (base32 + "16ml6kf338qqiazc2swvla89zapg41qc1i00x25r1jpq94a17cr9"))= )) + (build-system gnu-build-system) + (arguments + `(#:phases + ;; TODO: This is copy-pasta'ed from aria-maestosa :) + ;; TODO: Add scons-build-system and use it here. + (modify-phases %standard-phases + (delete 'configure) + (add-after 'unpack 'scons-propagate-environment + (lambda _ + ;; By design, SCons does not, by default, propagate + ;; environment variables to subprocesses. See: + ;; + ;; Here, we modify the SConstruct file to arrange for + ;; environment variables to be propagated. + (substitute* "SConstruct" + (("env =3D Environment\\(\\)") + "env =3D Environment(ENV=3Dos.environ)") + ;; Scons errors out when copying subdirectories from Reso= urces, + ;; so we move them instead. + (("Copy") "Move") + ;; We move the "score" and "Documentation" directories at= once, + ;; so we have to ignore files contained therein. + (("if \".svn\" in file" line) + (string-append line + " or \"score/\" in file" + " or \"Documentation/\" in file"))) + #t)) + (replace 'build (lambda _ (zero? (system* "scons" "platform=3Dx= 11")))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (and + (zero? (system* "scons" + (string-append "prefix=3D" out) + "install"))))))))) + (native-inputs `(("pkg-config" ,pkg-config) + ("scons" ,scons))) + (inputs `(("libx11" ,libx11) + ("libxcursor" ,libxcursor) + ("libxinerama" ,libxinerama) + ("linux-libre-headers" ,linux-libre-headers) + ("mesa" ,mesa) + ("mesa-headers" ,mesa-headers) + ("glu" ,glu) + ("pulseaudio" ,pulseaudio) + ("freetype" ,freetype) + ("openssl" ,openssl) + ("libxrandr" ,libxrandr))) + (home-page "https://godotengine.org/") + (synopsis "Advanced 2d and 3d game engine") + (description "Godot is a 2d and 3d game engine which with a powerful +visual interface.") + ;; TODO: Maybe list bundled libs + (license license:expat))) --=20 2.11.0 --=-=-=-- From unknown Sun Jun 22 08:02:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25908: [PATCH, WIP] Add godot. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Mar 2017 09:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25908 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Allan Webber Cc: 25908@debbugs.gnu.org Received: via spool by 25908-submit@debbugs.gnu.org id=B25908.148948370720323 (code B ref 25908); Tue, 14 Mar 2017 09:29:02 +0000 Received: (at 25908) by debbugs.gnu.org; 14 Mar 2017 09:28:27 +0000 Received: from localhost ([127.0.0.1]:54842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnikl-0005Hj-2u for submit@debbugs.gnu.org; Tue, 14 Mar 2017 05:28:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnikj-0005HV-Hd for 25908@debbugs.gnu.org; Tue, 14 Mar 2017 05:28:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnika-0003jv-C2 for 25908@debbugs.gnu.org; Tue, 14 Mar 2017 05:28:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnika-0003jk-9A; Tue, 14 Mar 2017 05:28:16 -0400 Received: from [193.50.110.133] (port=44648 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cnikZ-00008t-MP; Tue, 14 Mar 2017 05:28:16 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87mvd5r4dj.fsf@dustycloud.org> Date: Tue, 14 Mar 2017 10:28:13 +0100 In-Reply-To: <87mvd5r4dj.fsf@dustycloud.org> (Christopher Allan Webber's message of "Tue, 28 Feb 2017 22:46:16 -0600") Message-ID: <87tw6wnr6a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) Hi Chris! Christopher Allan Webber skribis: > This is still WIP, and unfortunately it doesn't work. Here's the error > I got: > > from ./drivers/pulseaudio/audio_driver_pulseaudio.h:36, > from platform/x11/os_x11.h:46, > from platform/x11/godot_x11.cpp:30: > /gnu/store/iwgi9001dmmihrjg4rqhd6pa6788prjw-glibc-2.24/include/bits/loc= al_lim.h:38:26: fatal error: linux/limits.h: No such file or directory > #include This is because, by default, SCons unsets environment variables (!), in this case C_INCLUDE_PATH. However: > + ;; By design, SCons does not, by default, propagate > + ;; environment variables to subprocesses. See: > + ;; > + ;; Here, we modify the SConstruct file to arrange for > + ;; environment variables to be propagated. > + (substitute* "SConstruct" > + (("env =3D Environment\\(\\)") > + "env =3D Environment(ENV=3Dos.environ)") this should definitely take care of that. Could it be that the regexp doesn=E2=80=99t match or something? HTH! Ludo=E2=80=99. From unknown Sun Jun 22 08:02:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25908: [PATCH, WIP] Add godot. Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Mar 2017 17:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25908 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: Christopher Allan Webber , 25908@debbugs.gnu.org Received: via spool by 25908-submit@debbugs.gnu.org id=B25908.148985641614058 (code B ref 25908); Sat, 18 Mar 2017 17:01:01 +0000 Received: (at 25908) by debbugs.gnu.org; 18 Mar 2017 17:00:16 +0000 Received: from localhost ([127.0.0.1]:34188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpHiB-0003eg-Rr for submit@debbugs.gnu.org; Sat, 18 Mar 2017 13:00:16 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:60473 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpHi9-0003eX-Bw for 25908@debbugs.gnu.org; Sat, 18 Mar 2017 13:00:13 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id 3D53B50B78E; Sat, 18 Mar 2017 18:00:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489856412; bh=vuyWS3XUKgQHj13NYu6FUlGRqYvP17L51isa8Fuz9o0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=wmCgHgtTiKJ10VQj95z4tqBO8XQj2sGuFrM488mx/8jAtn9RUCeNHAjR1XeUHKd1O Q1uT6DYTj0aqmLIhzyA875Zju0MY95q2MZwJXTFWRKqA5crPey6ahbuadlCIQpWn1R tIQyvXnuV+eeCvKteFuh0UomLz4SNaI0LY9vB4nc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR003 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1489856411; bh=vuyWS3XUKgQHj13NYu6FUlGRqYvP17L51isa8Fuz9o0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ObhlsIkt7haP8jkmO0VmWJgaEB+SPhTmzLPmhX+GsCZSp56Q6mI+sKbgCfKysg/F/ +v4VzSiYFMNp+jRJyX3oNz+bqK3Ac77xl+bKsqeJefR1hQuMp+QDi4Jk6SpuDlrDjQ 37DFfwofAMjTxdgIMhgA0XuxNeFHQ8eYHAEm4Fos= References: <87mvd5r4dj.fsf@dustycloud.org> <87tw6wnr6a.fsf@gnu.org> Date: Sat, 18 Mar 2017 12:59:56 -0400 In-Reply-To: <87tw6wnr6a.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 14 Mar 2017 10:28:13 +0100") Message-ID: <87k27m5xmb.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi Chris! > > Christopher Allan Webber skribis: > >> This is still WIP, and unfortunately it doesn't work. Here's the error >> I got: >> >> from ./drivers/pulseaudio/audio_driver_pulseaudio.h:36, >> from platform/x11/os_x11.h:46, >> from platform/x11/godot_x11.cpp:30: >> /gnu/store/iwgi9001dmmihrjg4rqhd6pa6788prjw-glibc-2.24/include/bits/lo= cal_lim.h:38:26: fatal error: linux/limits.h: No such file or directory >> #include > > This is because, by default, SCons unsets environment variables (!), in > this case C_INCLUDE_PATH. > > However: > >> + ;; By design, SCons does not, by default, propagate >> + ;; environment variables to subprocesses. See: >> + ;; >> + ;; Here, we modify the SConstruct file to arrange for >> + ;; environment variables to be propagated. >> + (substitute* "SConstruct" >> + (("env =3D Environment\\(\\)") >> + "env =3D Environment(ENV=3Dos.environ)") > > this should definitely take care of that. > > Could it be that the regexp doesn=E2=80=99t match or something? > > HTH! > > Ludo=E2=80=99. Ah, the crucial clue! I replaced the above regexp with the following: (substitute* "SConstruct" (("env_base =3D Environment\\(tools=3Dcustom_tools\\)") "env_base =3D Environment(ENV=3Dos.environ)")) Though I don't know what the meaning of "tools=3Dcustom_tools" is, this substitution let me complete the build phase without an issue. Just two other things: Throughout the build I saw "-Ithirdparty/glew" as a CFLAG. Is this necessary for a successful build or can we use our own copy of glew? Is there a check target for this build system? If not we can just leave a #:tests? #f with a note in the arguments section. Thanks for the help, Ludovic! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljNZ4wACgkQ5qXuPBlG eg1nmg/+Icw2Lt+Ymtdqk3WrFAUniMe4Hip0Ly4ku2kV6NoQgBUchd1D9z4+IKX9 cAQsmK+YBMoXwWW3p5syvpOeabAJWrsGo2Z/sUAb4huNhmixsipc2sHsCbe/7hMG PNwaE7GZsl6xtd6+MbPqBJL9RO0p8jbrd1zhDBb35PAgJM+dpbsagTDgt55w1HkT 29zSNi6En9JuN1ZsSIlSDV9353Ghif6pVNeq+HPmaWFVOIqmz3AyvO+fP8WMupao PBVjhxA6epyZ7R6VzcMQfVvy6hrhxKWW3yUiK4waguXZiaGdslWG+SplrG1gKg7H pefUyLluKHbz2X6qIcp4+GfWFQuzOSzNTsrNc2KUgL1u0eJbi0oHUycmMidIqyiH VirdYwfTTFKroJlVLKNSB87rS1e99jFY64Se1MR+vMiYeMS+ttpXXlamQ13Dlxf4 yQA+roBOpRYy4bGWmLxfK6Jv6Lq61PDiT0EUUN31CQ0ShFpP5PTD3uy0nAfmIgK1 vsasaRWeHcdM0/tSBK1h0kq/Hf/+3CWvJmC9mGVVSlHzgbdlsiU4WqaoyXC2D1w+ qhIljxLYG9vl8fXOYy5sNz9eIc3DTzw6grsqAw7pF7J9Z0PJRXlBHcg25zQg/zrV Wl3POr/mTwwc0P5kXtpA31ENRcbMZ4NCzAfi+BfcG8gVYqoZWEk= =Tdcl -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 08:02:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25908: [PATCH, WIP] Add godot. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Mar 2017 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25908 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kei Kebreau Cc: Christopher Allan Webber , 25908@debbugs.gnu.org Received: via spool by 25908-submit@debbugs.gnu.org id=B25908.148993870623328 (code B ref 25908); Sun, 19 Mar 2017 15:52:01 +0000 Received: (at 25908) by debbugs.gnu.org; 19 Mar 2017 15:51:46 +0000 Received: from localhost ([127.0.0.1]:35372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpd7S-00064C-4O for submit@debbugs.gnu.org; Sun, 19 Mar 2017 11:51:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpd7Q-00063y-0m for 25908@debbugs.gnu.org; Sun, 19 Mar 2017 11:51:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpd7F-0000sL-TI for 25908@debbugs.gnu.org; Sun, 19 Mar 2017 11:51:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpd7F-0000sH-Pj; Sun, 19 Mar 2017 11:51:33 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:46530 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cpd7F-0007p5-1e; Sun, 19 Mar 2017 11:51:33 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87mvd5r4dj.fsf@dustycloud.org> <87tw6wnr6a.fsf@gnu.org> <87k27m5xmb.fsf@openmailbox.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?UTF-8?Q?Vent=C3=B4se?= an 225 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sun, 19 Mar 2017 16:51:30 +0100 In-Reply-To: <87k27m5xmb.fsf@openmailbox.org> (Kei Kebreau's message of "Sat, 18 Mar 2017 12:59:56 -0400") Message-ID: <87fui9464d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Kei, Kei Kebreau skribis: > Ah, the crucial clue! I replaced the above regexp with the following: > > (substitute* "SConstruct" > (("env_base =3D Environment\\(tools=3Dcustom_tools\\)") > "env_base =3D Environment(ENV=3Dos.environ)")) > > Though I don't know what the meaning of "tools=3Dcustom_tools" is, this > substitution let me complete the build phase without an issue. In doubt, I=E2=80=99d keep =E2=80=9Ctools=3Dcustom_tools=E2=80=9D in additi= on to =E2=80=9CENV=3Dos.environ=E2=80=9D. :-) > Just two other things: > > Throughout the build I saw "-Ithirdparty/glew" as a CFLAG. Is this > necessary for a successful build or can we use our own copy of glew? Maybe you could (delete-file-recursively "thirdparty") from the snippet to be sure. > Is there a check target for this build system? If not we can just leave > a #:tests? #f with a note in the arguments section. AFAIK SCons does not standardize anything when it comes to running tests. I think =E2=80=98scons --help=E2=80=99 lists all the supported targ= ets, so you could check if there=E2=80=99s a =E2=80=9Ctest=E2=80=9D target or something= like that. HTH! Ludo=E2=80=99. From unknown Sun Jun 22 08:02:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25908: [PATCH, WIP] Add godot. Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Mar 2017 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25908 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: Christopher Allan Webber , 25908@debbugs.gnu.org Received: via spool by 25908-submit@debbugs.gnu.org id=B25908.1490462938595 (code B ref 25908); Sat, 25 Mar 2017 17:29:02 +0000 Received: (at 25908) by debbugs.gnu.org; 25 Mar 2017 17:28:58 +0000 Received: from localhost ([127.0.0.1]:44561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crpUn-00009X-P7 for submit@debbugs.gnu.org; Sat, 25 Mar 2017 13:28:57 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:33607 helo=mail.openmailbox.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crpUl-00009M-Oc for 25908@debbugs.gnu.org; Sat, 25 Mar 2017 13:28:56 -0400 Received: by mail.openmailbox.org (Postfix, from userid 20002) id A5088513B24; Sat, 25 Mar 2017 18:28:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1490462934; bh=lYMNmk2OKbPrLHv8J5NZ/U6UDTikOMxCyfr8mEYMx+4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fjCXEqWB6IfTsPwRVy1fi7hzzmvx4qmXQXI9eIrfUqjcecdy2Xbt0goxQOfeRQi3F 8u1k2f8TWddrSRJloj++KTY9wIRAp8tfoq1jW6Bs+EyuWnf9tv7uuqaDEBbzpLm3iX pdah9HcQ8D5jKl/7gpU8m2OrKHGhbhGrYtOd8KoI= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ZDZR002 X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=NO_RECEIVED,NO_RELAYS, T_DKIM_INVALID autolearn=disabled version=3.4.0 From: Kei Kebreau DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1490462933; bh=lYMNmk2OKbPrLHv8J5NZ/U6UDTikOMxCyfr8mEYMx+4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IQb4wpWqRS4LvetJnAXK73gUGMShSrbXpw/Vap+wmh9pYNdqzGxJ0RUAr9rj8cLH5 1AHs/Ztg7BkkEdKWhO56rElaT7NaI/R5TxqVA4JWx2hXuJTiyVhMDg4IdbxAiEPZrh FNaXjO1wT4fweviEQp42iUh5zEKhagZU+ddsrLm0= References: <87mvd5r4dj.fsf@dustycloud.org> <87tw6wnr6a.fsf@gnu.org> <87k27m5xmb.fsf@openmailbox.org> <87fui9464d.fsf@gnu.org> Date: Sat, 25 Mar 2017 13:28:38 -0400 In-Reply-To: <87fui9464d.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 19 Mar 2017 16:51:30 +0100") Message-ID: <87bmsp2rll.fsf@openmailbox.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi Kei, > > Kei Kebreau skribis: > >> Ah, the crucial clue! I replaced the above regexp with the following: >> >> (substitute* "SConstruct" >> (("env_base =3D Environment\\(tools=3Dcustom_tools\\)") >> "env_base =3D Environment(ENV=3Dos.environ)")) >> >> Though I don't know what the meaning of "tools=3Dcustom_tools" is, this >> substitution let me complete the build phase without an issue. > > In doubt, I=E2=80=99d keep =E2=80=9Ctools=3Dcustom_tools=E2=80=9D in addi= tion to > =E2=80=9CENV=3Dos.environ=E2=80=9D. :-) > Okay. I figured out how this works and kept both. >> Just two other things: >> >> Throughout the build I saw "-Ithirdparty/glew" as a CFLAG. Is this >> necessary for a successful build or can we use our own copy of glew? > > Maybe you could (delete-file-recursively "thirdparty") from the snippet > to be sure. > It seems like these libraries will be quite difficult to unbundle. The build system has targets that depend on files specifically found in the "thirdparty" directory. >> Is there a check target for this build system? If not we can just leave >> a #:tests? #f with a note in the arguments section. > > AFAIK SCons does not standardize anything when it comes to running > tests. I think =E2=80=98scons --help=E2=80=99 lists all the supported ta= rgets, so you > could check if there=E2=80=99s a =E2=80=9Ctest=E2=80=9D target or somethi= ng like that. > There doesn't seem to be tests in the Godot's build system. > HTH! > > Ludo=E2=80=99. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljWqMYACgkQ5qXuPBlG eg3H6g//Sj11esvxa/y1/aMJaMIAwTCjX6afm1sp/hrxH1YmQ0SNClM42QDzo5Ti yq8hbI4Mph/8l+ByJetZf0w/QfQRhpWElnOVQjgO2HKEULHK2mqxiWDgr064urkv wym4PvEbOr9X+OV1CeLdPkqlvuQBWKv4wIJt5GVz+qFffzDG5QdJlyj9/SJzYWol VhlNcEdbJkKSjIFmA4kPQnTV06EhD7yGJ3GG9zRq8m9VquHRIUKyFLyiCWM4mT7t 3p6Y3Qtda9l6vqlIJ/ynJGqqvcTOvjSzN9P5aM+HhiyFjXH4jCKGFf3FypbYz+/O OjpRpe6psh2vB7NTl9jBUGKNqR/7QgQV1BkRGFEyhyIVFJ+cUVpwqsfO1xJ8tPcf gGpny0s4Ji14naTe0I6n30H25ulDJ5GHozsRJmO0QC/2pFLcwRjrOTIcOCkOFaur qVDlbehLr6dwu1M7/OsaZoO292+NTlX/0PJ7wH5H8xKJQxfgiTgA9uDdyYeIJZ90 PgOEufyHx6oMK354cuCf6KONKjeIGPufzz6QWxKRt1ODqzUTCDZwuxGmLtvjl+Vd 2knsFWMa14573iahN3hFow0VUrBvUhcxno7IPKYvt/cqm2+9cB5inK9pCGgJ1rK/ PWAGpdwOQE3x21X2xUiie4d+eLiGqN6XJu0U5w74LUQcEHhipcU= =Bdig -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 08:02:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25908: [PATCH, WIP] Add godot. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Mar 2017 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25908 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kei Kebreau Cc: Christopher Allan Webber , 25908@debbugs.gnu.org Received: via spool by 25908-submit@debbugs.gnu.org id=B25908.14904640822372 (code B ref 25908); Sat, 25 Mar 2017 17:48:02 +0000 Received: (at 25908) by debbugs.gnu.org; 25 Mar 2017 17:48:02 +0000 Received: from localhost ([127.0.0.1]:44570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crpnF-0000c9-OB for submit@debbugs.gnu.org; Sat, 25 Mar 2017 13:48:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crpnE-0000bv-56 for 25908@debbugs.gnu.org; Sat, 25 Mar 2017 13:48:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crpn7-0007ag-VD for 25908@debbugs.gnu.org; Sat, 25 Mar 2017 13:47:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crpn2-0007Xj-SV; Sat, 25 Mar 2017 13:47:48 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:33588 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1crpn2-0003Jm-86; Sat, 25 Mar 2017 13:47:48 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87mvd5r4dj.fsf@dustycloud.org> <87tw6wnr6a.fsf@gnu.org> <87k27m5xmb.fsf@openmailbox.org> <87fui9464d.fsf@gnu.org> <87bmsp2rll.fsf@openmailbox.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 Germinal an 225 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sat, 25 Mar 2017 18:47:46 +0100 In-Reply-To: <87bmsp2rll.fsf@openmailbox.org> (Kei Kebreau's message of "Sat, 25 Mar 2017 13:28:38 -0400") Message-ID: <87zig9uu2l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Kei, Kei Kebreau skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >>> Just two other things: >>> >>> Throughout the build I saw "-Ithirdparty/glew" as a CFLAG. Is this >>> necessary for a successful build or can we use our own copy of glew? >> >> Maybe you could (delete-file-recursively "thirdparty") from the snippet >> to be sure. >> > > It seems like these libraries will be quite difficult to unbundle. The > build system has targets that depend on files specifically found in the > "thirdparty" directory. As a first step, you could remove (in the snippet) those that can easily be avoided, and document work that remains to be done in a comment. Though yeah, we=E2=80=99ll have to find out how to modify =E2=80=98SConscri= pt=E2=80=99 & co. to remove the dependencies on bundled libs. >>> Is there a check target for this build system? If not we can just leave >>> a #:tests? #f with a note in the arguments section. >> >> AFAIK SCons does not standardize anything when it comes to running >> tests. I think =E2=80=98scons --help=E2=80=99 lists all the supported t= argets, so you >> could check if there=E2=80=99s a =E2=80=9Ctest=E2=80=9D target or someth= ing like that. >> > > There doesn't seem to be tests in the Godot's build system. Simpler! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 08 11:44:56 2017 Received: (at control) by debbugs.gnu.org; 8 Sep 2017 15:44:57 +0000 Received: from localhost ([127.0.0.1]:56151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqLSi-0005RN-NU for submit@debbugs.gnu.org; Fri, 08 Sep 2017 11:44:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqLSh-0005R8-39 for control@debbugs.gnu.org; Fri, 08 Sep 2017 11:44:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqLSY-0005yy-53 for control@debbugs.gnu.org; Fri, 08 Sep 2017 11:44:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqLSY-0005yq-18 for control@debbugs.gnu.org; Fri, 08 Sep 2017 11:44:46 -0400 Received: from [193.50.110.231] (port=41750 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dqLSX-0005Pv-HM for control@debbugs.gnu.org; Fri, 08 Sep 2017 11:44:45 -0400 Date: Fri, 08 Sep 2017 17:44:44 +0200 Message-Id: <87ingt9our.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #28380 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 28380 25908 From unknown Sun Jun 22 08:02:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Allan Webber Subject: bug#25908: closed (Re: [bug#28380] [PATCH] gnu: Add godot.) Message-ID: References: <87tw05a4n4.fsf@gnu.org> <87mvd5r4dj.fsf@dustycloud.org> X-Gnu-PR-Message: they-closed 25908 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 25908@debbugs.gnu.org Date: Thu, 14 Sep 2017 11:43:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1505389383-15587-1" This is a multi-part message in MIME format... ------------=_1505389383-15587-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #25908: [PATCH, WIP] Add godot. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 25908@debbugs.gnu.org. --=20 25908: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25908 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1505389383-15587-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 25908-done) by debbugs.gnu.org; 14 Sep 2017 11:42:13 +0000 Received: from localhost ([127.0.0.1]:39762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsSX7-000422-JT for submit@debbugs.gnu.org; Thu, 14 Sep 2017 07:42:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsSX5-00041g-9i for 25908-done@debbugs.gnu.org; Thu, 14 Sep 2017 07:42:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsSWz-0004aU-9S for 25908-done@debbugs.gnu.org; Thu, 14 Sep 2017 07:42:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsSWp-0004JR-7c; Thu, 14 Sep 2017 07:41:55 -0400 Received: from [193.50.110.249] (port=37748 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dsSWo-0007Mj-Nt; Thu, 14 Sep 2017 07:41:55 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Peter Mikkelsen Subject: Re: [bug#28380] [PATCH] gnu: Add godot. References: <20170907115947.19777-1-petermikkelsen10@gmail.com> <87efrh9otf.fsf@gnu.org> Date: Thu, 14 Sep 2017 13:41:51 +0200 In-Reply-To: (Peter Mikkelsen's message of "Fri, 8 Sep 2017 18:13:37 +0200") Message-ID: <87tw05a4n4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25908-done Cc: 25908-done@debbugs.gnu.org, 28380-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Peter Mikkelsen skribis: > I got some inspiration from that one, and afaik bug 25908 was never > completed. I guess you can see my patch as a completed version, co-author= ed > by Chris :) It builds and installs, and i have unbundled as much as > possible right now. > > Hope that helps! It does! I=E2=80=99m committing it with the cosmetic changes below. Note that it =E2=80=9Ccalls home=E2=80=9D to retrieve templates from godote= ngine.org and github.com. I suppose that=E2=80=99s expected but that wasn=E2=80=99t clea= r when I clicked on the browsing thing. Thanks! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index e04c11d7d..5633456d4 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1118,7 +1118,10 @@ their own original games.") ("pulseaudio" ,pulseaudio) ("python2" ,python-2))) (home-page "https://godotengine.org/") - (synopsis "Advanced 2d and 3d game engine") - (description "Godot is an advanced, feature-packed, multi-platform -2D and 3D open source game engine.") + (synopsis "Advanced 2D and 3D game engine") + (description + "Godot is an advanced multi-platform game engine written in C++. If +features design tools such as a visual editor, can import 3D models and +provide high-quality 3D rendering, it contains an animation editor, and can be +scripted in a Python-like language.") (license license:expat))) --=-=-=-- ------------=_1505389383-15587-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Mar 2017 04:46:42 +0000 Received: from localhost ([127.0.0.1]:60816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciw9r-00019Z-6y for submit@debbugs.gnu.org; Tue, 28 Feb 2017 23:46:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciw9p-00019J-Ou for submit@debbugs.gnu.org; Tue, 28 Feb 2017 23:46:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciw9j-0001Eb-3N for submit@debbugs.gnu.org; Tue, 28 Feb 2017 23:46:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ciw9i-0001EQ-Vz for submit@debbugs.gnu.org; Tue, 28 Feb 2017 23:46:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciw9h-0001bx-3s for guix-patches@gnu.org; Tue, 28 Feb 2017 23:46:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciw9d-0001BJ-F1 for guix-patches@gnu.org; Tue, 28 Feb 2017 23:46:25 -0500 Received: from dustycloud.org ([50.116.34.160]:38600) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ciw9d-0001B5-8i for guix-patches@gnu.org; Tue, 28 Feb 2017 23:46:21 -0500 Received: from oolong (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 315602664C for ; Tue, 28 Feb 2017 23:46:17 -0500 (EST) User-agent: mu4e 0.9.18; emacs 25.1.1 From: Christopher Allan Webber To: guix-patches@gnu.org Subject: [PATCH, WIP] Add godot. Date: Tue, 28 Feb 2017 22:46:16 -0600 Message-ID: <87mvd5r4dj.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --=-=-= Content-Type: text/plain This is still WIP, and unfortunately it doesn't work. Here's the error I got: from ./drivers/pulseaudio/audio_driver_pulseaudio.h:36, from platform/x11/os_x11.h:46, from platform/x11/godot_x11.cpp:30: /gnu/store/iwgi9001dmmihrjg4rqhd6pa6788prjw-glibc-2.24/include/bits/local_lim.h:38:26: fatal error: linux/limits.h: No such file or directory #include I also get this if I try to build it outside the package, from a git checkout of Godot. I don't know why I'm experiencing this; I added linux-libre-headers as an input. It seems that I'm not the first one to experience this with Guix packages... I ran across these: https://lists.gnu.org/archive/html/help-guix/2016-06/msg00130.html (I don't think I need to include gcc-toolchain though) https://gnunet.org/bot/log/guix/2016-07-27 https://gnunet.org/bot/log/guix/2016-08-03 looks like jlicht eventually found a solution, and lfam said jlicht: Have you tried setting -I in #:make-flags or #:configure-flags? ... not sure how that helps with scons :) Other potential issues: - bundles a number of packages (can they be easily unbundled?) - license field should probably reflect bundled packages - very badly snarfs a whole bunch of phases code from aria-maestosa, which itself suggests refactoring into a scons-build-system... Nonetheless, uh, maybe it's a good starting point! --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-Add-godot.patch Content-Transfer-Encoding: quoted-printable >From 8fe2eb621c0cc4556c112b0bd42714200f1332b2 Mon Sep 17 00:00:00 2001 From: Christopher Allan Webber Date: Tue, 28 Feb 2017 22:39:38 -0600 Subject: [PATCH] gnu: Add godot. * gnu/packages/game-development.scm (godot): New variable. --- gnu/packages/game-development.scm | 69 +++++++++++++++++++++++++++++++++= ++++++ 1 file changed, 69 insertions(+) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-develo= pment.scm index 619c2f1bc..2f03041b3 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -8,6 +8,7 @@ ;;; Copyright =C2=A9 2016 Kei Kebreau ;;; Copyright =C2=A9 2016 Ricardo Wurmus ;;; Copyright =C2=A9 2016 Julian Graham +;;; Copyright =C2=A9 2017 Christopher Allan Webber ;;; ;;; This file is part of GNU Guix. ;;; @@ -60,6 +61,7 @@ #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages sdl) + #:use-module (gnu packages tls) #:use-module (gnu packages pkg-config) #:use-module (gnu packages xiph) #:use-module (gnu packages lua) @@ -619,3 +621,70 @@ to create fully featured games and multimedia progra= ms in the python language.") license:psfl license:public-domain license:lgpl2.1+)))) + +(define-public godot + (package + (name "godot") + (version "2.1.2") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/godotengine/godot/archive/" + version "-stable.tar.gz")) + (sha256 + (base32 + "16ml6kf338qqiazc2swvla89zapg41qc1i00x25r1jpq94a17cr9"))= )) + (build-system gnu-build-system) + (arguments + `(#:phases + ;; TODO: This is copy-pasta'ed from aria-maestosa :) + ;; TODO: Add scons-build-system and use it here. + (modify-phases %standard-phases + (delete 'configure) + (add-after 'unpack 'scons-propagate-environment + (lambda _ + ;; By design, SCons does not, by default, propagate + ;; environment variables to subprocesses. See: + ;; + ;; Here, we modify the SConstruct file to arrange for + ;; environment variables to be propagated. + (substitute* "SConstruct" + (("env =3D Environment\\(\\)") + "env =3D Environment(ENV=3Dos.environ)") + ;; Scons errors out when copying subdirectories from Reso= urces, + ;; so we move them instead. + (("Copy") "Move") + ;; We move the "score" and "Documentation" directories at= once, + ;; so we have to ignore files contained therein. + (("if \".svn\" in file" line) + (string-append line + " or \"score/\" in file" + " or \"Documentation/\" in file"))) + #t)) + (replace 'build (lambda _ (zero? (system* "scons" "platform=3Dx= 11")))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (and + (zero? (system* "scons" + (string-append "prefix=3D" out) + "install"))))))))) + (native-inputs `(("pkg-config" ,pkg-config) + ("scons" ,scons))) + (inputs `(("libx11" ,libx11) + ("libxcursor" ,libxcursor) + ("libxinerama" ,libxinerama) + ("linux-libre-headers" ,linux-libre-headers) + ("mesa" ,mesa) + ("mesa-headers" ,mesa-headers) + ("glu" ,glu) + ("pulseaudio" ,pulseaudio) + ("freetype" ,freetype) + ("openssl" ,openssl) + ("libxrandr" ,libxrandr))) + (home-page "https://godotengine.org/") + (synopsis "Advanced 2d and 3d game engine") + (description "Godot is a 2d and 3d game engine which with a powerful +visual interface.") + ;; TODO: Maybe list bundled libs + (license license:expat))) --=20 2.11.0 --=-=-=-- ------------=_1505389383-15587-1-- From unknown Sun Jun 22 08:02:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Peter Mikkelsen Subject: bug#28380: closed (Re: [bug#28380] [PATCH] gnu: Add godot.) Message-ID: References: <87tw05a4n4.fsf@gnu.org> <20170907115947.19777-1-petermikkelsen10@gmail.com> X-Gnu-PR-Message: they-closed 28380 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 28380@debbugs.gnu.org Date: Thu, 14 Sep 2017 11:43:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1505389383-15587-3" This is a multi-part message in MIME format... ------------=_1505389383-15587-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #25908: [PATCH] gnu: Add godot. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28380@debbugs.gnu.org. --=20 25908: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25908 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1505389383-15587-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 25908-done) by debbugs.gnu.org; 14 Sep 2017 11:42:13 +0000 Received: from localhost ([127.0.0.1]:39762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsSX7-000422-JT for submit@debbugs.gnu.org; Thu, 14 Sep 2017 07:42:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsSX5-00041g-9i for 25908-done@debbugs.gnu.org; Thu, 14 Sep 2017 07:42:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsSWz-0004aU-9S for 25908-done@debbugs.gnu.org; Thu, 14 Sep 2017 07:42:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsSWp-0004JR-7c; Thu, 14 Sep 2017 07:41:55 -0400 Received: from [193.50.110.249] (port=37748 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dsSWo-0007Mj-Nt; Thu, 14 Sep 2017 07:41:55 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Peter Mikkelsen Subject: Re: [bug#28380] [PATCH] gnu: Add godot. References: <20170907115947.19777-1-petermikkelsen10@gmail.com> <87efrh9otf.fsf@gnu.org> Date: Thu, 14 Sep 2017 13:41:51 +0200 In-Reply-To: (Peter Mikkelsen's message of "Fri, 8 Sep 2017 18:13:37 +0200") Message-ID: <87tw05a4n4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25908-done Cc: 25908-done@debbugs.gnu.org, 28380-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Peter Mikkelsen skribis: > I got some inspiration from that one, and afaik bug 25908 was never > completed. I guess you can see my patch as a completed version, co-author= ed > by Chris :) It builds and installs, and i have unbundled as much as > possible right now. > > Hope that helps! It does! I=E2=80=99m committing it with the cosmetic changes below. Note that it =E2=80=9Ccalls home=E2=80=9D to retrieve templates from godote= ngine.org and github.com. I suppose that=E2=80=99s expected but that wasn=E2=80=99t clea= r when I clicked on the browsing thing. Thanks! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index e04c11d7d..5633456d4 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1118,7 +1118,10 @@ their own original games.") ("pulseaudio" ,pulseaudio) ("python2" ,python-2))) (home-page "https://godotengine.org/") - (synopsis "Advanced 2d and 3d game engine") - (description "Godot is an advanced, feature-packed, multi-platform -2D and 3D open source game engine.") + (synopsis "Advanced 2D and 3D game engine") + (description + "Godot is an advanced multi-platform game engine written in C++. If +features design tools such as a visual editor, can import 3D models and +provide high-quality 3D rendering, it contains an animation editor, and can be +scripted in a Python-like language.") (license license:expat))) --=-=-=-- ------------=_1505389383-15587-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Sep 2017 12:00:25 +0000 Received: from localhost ([127.0.0.1]:53896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpvTo-0003nW-TJ for submit@debbugs.gnu.org; Thu, 07 Sep 2017 08:00:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpvTn-0003nL-Si for submit@debbugs.gnu.org; Thu, 07 Sep 2017 08:00:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpvTZ-0003qE-1i for submit@debbugs.gnu.org; Thu, 07 Sep 2017 08:00:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33805) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpvTY-0003q7-Ub for submit@debbugs.gnu.org; Thu, 07 Sep 2017 08:00:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpvTT-00038t-Eb for guix-patches@gnu.org; Thu, 07 Sep 2017 08:00:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpvTO-0003lm-Bv for guix-patches@gnu.org; Thu, 07 Sep 2017 07:59:59 -0400 Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]:33159) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dpvTO-0003lR-0w for guix-patches@gnu.org; Thu, 07 Sep 2017 07:59:54 -0400 Received: by mail-lf0-x22a.google.com with SMTP id c80so1932659lfh.0 for ; Thu, 07 Sep 2017 04:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vDVmwKtiGo+z0W9J7xSMhk8HqLphFFds0kgPNOWyWlk=; b=S663bP38EHi1fgeq6DPoIqxgVgzdcpHCljQDKHLl0TH/8AOJgEl4pZJ/boqjURsVZw oXZ/uz/Yy8wFylw81NPHrE3oWzinnMuTsIY4Yxq9KS/nPodX1qCHNti1Bh6W/m+jeblb 3ElEf8M4b7jphyc19a+M2iAWIEL/lyF66Lg710Wge/6r3i6mIsjKtVLFCxtg9fdsHLaz wMXNy3H6F4j46qtdPzvveLxOFuSMqwaRi/S91+5IlAjXJ2EMuTUX9zj1phKFbibPSDZ0 DwpGtDTS7/usnIjdQ4ETs8GiFZyboOJvJtSbCWVdXA3tYfKuz4M+5xevU2AIIhWpG0Sp DzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vDVmwKtiGo+z0W9J7xSMhk8HqLphFFds0kgPNOWyWlk=; b=KA46Q7UCQGFfYx/3S8LYDMLDTOLta+ulNVHOx1qccDB4rKHZK2ntbujx5APl/p6UXJ 2lx2rY0R3kZ33JsmW2VfJWNXcGtrA4viOKG1KaRaIxeJcinLeguK3Xym/CMFokKbJuYr 3WDTNfunvQJgKrDkhNU5g81uG+UShX1dHeC9TkX9D8MganF8xJ15eNx+mWxgJZNbQdPC hLAsZIJ1rA5tauwmugQvPbo6yrk9PVe2lQ98nK5Hvn6BZzY/UhrzRiLElBnZsn0MXo1T BuaL2TpWCRricX1Fy1Fcs/vatE59AdykSzHCt5I3lTFoL7lsjGkBUpqfkwZ/l7hSukUP ystw== X-Gm-Message-State: AHPjjUhs8fnXwp54d8sTsfHZxpshhButTKc79WQo7Mpxl07JiEXywhWv KnhQoxyROf4j82iLekc= X-Google-Smtp-Source: AOwi7QBVLny6F3ZnlePpubJI7nfoES1iyZ14YWNW5gtRKcgEm2cvIBpxqVMISsrqDeCAUogLqtSRmQ== X-Received: by 10.25.23.105 with SMTP id n102mr912304lfi.252.1504785590991; Thu, 07 Sep 2017 04:59:50 -0700 (PDT) Received: from localhost.localdomain (0x3e2c86e6.mobile.telia.dk. [62.44.134.230]) by smtp.gmail.com with ESMTPSA id b202sm364746lfg.80.2017.09.07.04.59.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Sep 2017 04:59:50 -0700 (PDT) From: Peter Mikkelsen To: guix-patches@gnu.org Subject: [PATCH] gnu: Add godot. Date: Thu, 7 Sep 2017 13:59:47 +0200 Message-Id: <20170907115947.19777-1-petermikkelsen10@gmail.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit Cc: Peter Mikkelsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/game-development.scm (godot): New variable. --- gnu/packages/game-development.scm | 105 +++++++++++++++++++++++++++++++++++++- 1 file changed, 104 insertions(+), 1 deletion(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index c8869a494..e04c11d7d 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -10,6 +10,7 @@ ;;; Copyright © 2016, 2017 Julian Graham ;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; Copyright © 2017 Manolis Fragkiskos Ragkousis +;;; Copyright © 2017 Peter Mikkelsen ;;; ;;; This file is part of GNU Guix. ;;; @@ -73,7 +74,8 @@ #:use-module (gnu packages xiph) #:use-module (gnu packages lua) #:use-module (gnu packages mp3) - #:use-module (gnu packages xml)) + #:use-module (gnu packages xml) + #:use-module (gnu packages tls)) [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [208.118.235.92 listed in wl.mailspike.net] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (petermikkelsen10[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (petermikkelsen10[at]gmail.com) 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders * gnu/packages/game-development.scm (godot): New variable. --- gnu/packages/game-development.scm | 105 +++++++++++++++++++++++++++++++++++++- 1 file changed, 104 insertions(+), 1 deletion(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index c8869a494..e04c11d7d 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -10,6 +10,7 @@ ;;; Copyright © 2016, 2017 Julian Graham ;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; Copyright © 2017 Manolis Fragkiskos Ragkousis +;;; Copyright © 2017 Peter Mikkelsen ;;; ;;; This file is part of GNU Guix. ;;; @@ -73,7 +74,8 @@ #:use-module (gnu packages xiph) #:use-module (gnu packages lua) #:use-module (gnu packages mp3) - #:use-module (gnu packages xml)) + #:use-module (gnu packages xml) + #:use-module (gnu packages tls)) (define-public bullet (package @@ -1019,3 +1021,104 @@ with its own editor, called OpenMW-CS which allows the user to edit or create their own original games.") (home-page "https://openmw.org") (license license:gpl3))) + +(define-public godot + (package + (name "godot") + (version "2.1.4") + (source (origin + (method url-fetch) + (uri + (string-append "https://github.com/godotengine/godot/archive/" + version "-stable.tar.gz")) + (file-name (string-append name "-" version)) + (sha256 + (base32 "1mz89nafc1m7srbqvy7iagxrxmqvf5hbqi7i0lwaapkx6q0kpkq7")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; There are no tests + #:phases + (modify-phases %standard-phases + (delete 'configure) + (add-after 'unpack 'scons-use-env + (lambda _ + ;; Scons does not use the environment variables by default, + ;; but this substitution makes it do so. + (substitute* "SConstruct" + (("env_base = Environment\\(tools=custom_tools\\)") + (string-append + "env_base = Environment(tools=custom_tools)\n" + "env_base = Environment(ENV=os.environ)"))) + #t)) + (replace 'build + (lambda _ + (zero? (system* + "scons" + "platform=x11" + ;; Avoid using many of the bundled libs. + ;; Note: These options can be found in the SConstruct file. + "builtin_freetype=no" + "builtin_glew=no" + "builtin_libmpdec=no" + "builtin_libogg=no" + "builtin_libpng=no" + "builtin_libtheora=no" + "builtin_libvorbis=no" + "builtin_libwebp=no" + "builtin_openssl=no" + "builtin_opus=no" + "builtin_zlib=no")))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin"))) + (with-directory-excursion "bin" + (if (file-exists? "godot.x11.tools.64") + (rename-file "godot.x11.tools.64" "godot") + (rename-file "godot.x11.tools.32" "godot")) + (install-file "godot" bin))))) + (add-after 'install 'install-godot-desktop + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (desktop (string-append out "/share/applications")) + (icon-dir (string-append out "/share/pixmaps"))) + (mkdir-p desktop) + (mkdir-p icon-dir) + (rename-file "icon.png" "godot.png") + (install-file "godot.png" icon-dir) + (with-output-to-file + (string-append desktop "/godot.desktop") + (lambda _ + (format #t + "[Desktop Entry]~@ + Name=godot~@ + Comment=The godot game engine~@ + Exec=~a/bin/godot~@ + TryExec=~@*~a/bin/godot~@ + Icon=godot~@ + Type=Application~%" + out))) + #t)))))) + (native-inputs `(("pkg-config" ,pkg-config) + ("scons" ,scons))) + (inputs `(("alsa-lib" ,alsa-lib) + ("freetype" ,freetype) + ("glew" ,glew) + ("glu" ,glu) + ("libtheora" ,libtheora) + ("libvorbis" ,libvorbis) + ("libwebp" ,libwebp) + ("libx11" ,libx11) + ("libxcursor" ,libxcursor) + ("libxinerama" ,libxinerama) + ("libxrandr" ,libxrandr) + ("mesa" ,mesa) + ("openssl" ,openssl) + ("opusfile" ,opusfile) + ("pulseaudio" ,pulseaudio) + ("python2" ,python-2))) + (home-page "https://godotengine.org/") + (synopsis "Advanced 2d and 3d game engine") + (description "Godot is an advanced, feature-packed, multi-platform +2D and 3D open source game engine.") + (license license:expat))) -- 2.14.1 ------------=_1505389383-15587-3--