GNU bug report logs - #25875
26.0.50; Hang logging out of MS-Windows

Previous Next

Full log

View this message in rfc822 format

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rcopley <at> gmail.com, 25875 <at> debbugs.gnu.org
Subject: bug#25875: 26.0.50; Hang logging out of MS-Windows
Date: Sun, 26 Feb 2017 18:38:19 -0500

On 2/26/2017 2:25 PM, Eli Zaretskii wrote:
>> Cc: rcopley <at> gmail.com, 25875 <at> debbugs.gnu.org
>> From: Ken Brown <kbrown <at> cornell.edu>
>> Date: Sun, 26 Feb 2017 13:58:23 -0500
>>
>>> I think the problem in this particular scenario is not that the input
>>> thread sleeps too long, it's that whenever it finishes sleeping and
>>> returns, Emacs will be killed, so the WM_ENDSESSION message that was
>>> posted to the main thread will never have a chance to be processed,
>>> and thus orderly shutdown will never happen.
>>>
>>> That is why I thought about using SendMessageTimeout in the main
>>> thread: what we really want is to cause the main thread to wake up and
>>> process the WM_ENDSESSION message.  Right?
>>
>> Yes, that would obviously be better.
>
> OK.  Can you propose a patch that Richard could try?

Here's a quick and dirty attempt.  If I haven't made a mistake, it 
replaces every relevant call to SendMessage by a call to 
SendMessageTimeout with a 100ms timeout.

--- a/src/w32term.c
+++ b/src/w32term.c
@@ -537,6 +537,15 @@ x_update_begin (struct frame *f)
 }


+#undef SendMessage
+#define SendMessage DebugSendMessage
+
+static LRESULT WINAPI
+DebugSendMessage (HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam)
+{
+  return SendMessageTimeoutA (hWnd, Msg, wParam, lParam, 0, 100, NULL);
+}
+
 /* Start update of window W.  */

 static void

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.