From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 02:40:43 2017 Received: (at submit) by debbugs.gnu.org; 24 Feb 2017 07:40:43 +0000 Received: from localhost ([127.0.0.1]:53482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chAUc-0007mr-MD for submit@debbugs.gnu.org; Fri, 24 Feb 2017 02:40:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chAUa-0007mS-5p for submit@debbugs.gnu.org; Fri, 24 Feb 2017 02:40:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chAUT-0003bq-9k for submit@debbugs.gnu.org; Fri, 24 Feb 2017 02:40:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1chAUT-0003bl-6p for submit@debbugs.gnu.org; Fri, 24 Feb 2017 02:40:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chAUR-0003WX-14 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2017 02:40:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chAUN-0003a5-R1 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2017 02:40:31 -0500 Received: from gproxy6-pub.mail.unifiedlayer.com ([67.222.39.168]:36394) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1chAUN-0003ZG-97 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2017 02:40:27 -0500 Received: (qmail 11678 invoked by uid 0); 24 Feb 2017 07:40:21 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy6.mail.unifiedlayer.com with SMTP; 24 Feb 2017 07:40:21 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id oXgD1u0052f2jeq01XgGvb; Fri, 24 Feb 2017 00:40:21 -0700 X-Authority-Analysis: v=2.1 cv=H5NInYoi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=NaBNEV6Y9MUdQ3FXzMEA:9 a=-XL8AwQlDxE18p5y:21 a=v-UMwd5F5iItqpYD:21 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oE6yLrgv8XLTEJZumsCDQTgvJWZu1I1Tl6idIp29L0M=; b=NE3mcz6Cbqy+6w1qn/AWeabc3M mNSsTULDanCw9Qh7vDALqRpwrNx2CsgL1CvpvQKYDCV12MJvCjy8RXiQEwfqT6wnzoURBU/etlDCG P7XCGkTpQYhMc5QFBquGnrlsz; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:37034 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1chAU8-0003jF-R3; Fri, 24 Feb 2017 00:40:12 -0700 From: Tom Tromey To: bug-gnu-emacs@gnu.org Subject: 25.1.91; js.el should use font-lock-doc-face X-Attribution: Tom Date: Fri, 24 Feb 2017 00:40:12 -0700 Message-ID: <87d1e8vxyb.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1chAU8-0003jF-R3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:37034 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I think js-mode should recognize "/**"-style jsdoc comments and fontify them using font-lock-doc-face. Some other programming modes do this already. Tom In GNU Emacs 25.1.91.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.7) of 2017-02-02 built on bapiya Repository revision: 7e02a477bbcabb4e65aeecade79b67357c0b9dae Windowing system distributor 'Fedora Project', version 11.0.11901000 System Description: Fedora release 25 (Twenty Five) Configured using: 'configure --prefix=/home/tromey/Emacs/install/ --with-modules' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t diff-auto-refine-mode: t flyspell-mode: t which-function-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t Recent messages: Saving Gnus registry (size 13198) to ~/.gnus.registry.eieio...done Saving file /home/tromey/.newsrc... Wrote /home/tromey/.newsrc Saving /home/tromey/.newsrc.eld... Saving file /home/tromey/.newsrc.eld... Wrote /home/tromey/.newsrc.eld Saving /home/tromey/.newsrc.eld...done scroll-down-command: Beginning of buffer Making completion list... Type C-x 1 to delete the help window. Load-path shadows: /home/tromey/.emacs.d/elpa/debbugs-0.12/debbugs-gnu hides /home/tromey/.emacs.d/elpa/debbugs-0.6/debbugs-gnu /home/tromey/.emacs.d/elpa/debbugs-0.12/debbugs hides /home/tromey/.emacs.d/elpa/debbugs-0.6/debbugs /home/tromey/.emacs.d/elpa/debbugs-0.12/debbugs-pkg hides /home/tromey/.emacs.d/elpa/debbugs-0.6/debbugs-pkg /home/tromey/.emacs.d/elpa/debbugs-0.12/debbugs-autoloads hides /home/tromey/.emacs.d/elpa/debbugs-0.6/debbugs-autoloads /home/tromey/.emacs.d/elpa/debbugs-0.12/debbugs-org hides /home/tromey/.emacs.d/elpa/debbugs-0.6/debbugs-org /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.1.91/lisp/play/bubbles /home/tromey/.emacs.d/elpa/soap-client-3.1.1/soap-inspect hides /home/tromey/Emacs/install/share/emacs/25.1.91/lisp/net/soap-inspect /home/tromey/.emacs.d/elpa/soap-client-3.1.1/soap-client hides /home/tromey/Emacs/install/share/emacs/25.1.91/lisp/net/soap-client Features: (cmake-mode pcmpl-unix pcmpl-gnu autoconf autoconf-mode tramp-cache markdown-mode ffap dired-aux nndoc gnus-dup debbugs-gnu debbugs soap-client rng-xsd rng-dt rng-util xsd-regexp autoload tar-mode cus-edit highlight-refontification tabify man shadow emacsbug conf-mode two-column iso-transl perl-mode sh-script executable cal-move nnregistry python tramp-sh tramp tramp-compat tramp-loaddefs trampver ucs-normalize make-mode etags cursor-sensor mhtml-mode org-bullets org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs gnus-fun gnus-draft noutline outline ido skeleton css-mode smie eww url-queue trace find-dired descr-text gdb-shell lisp-mnt url-handlers url-http url-gw url-auth lex edebug debug m4-mode bbdb-sc supercite regi xref project log-edit js json map sgml-mode flow-fill gnus-html xml url-cache mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf eieio-opt speedbar sb-image ezimage dframe find-func whitespace tcl log-view pcvs-util vc-annotate term/xterm xterm smerge-mode goto-addr shell find-file idutils derived bug-reference cc-mode cc-fonts cc-guess cc-menus cc-cmds jka-compr mailalias mail-hist nnir sort gnus-cite smiley shr-color url-util url-parse url-vars shr dom subr-x browse-url mm-archive gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-mua bbdb-com crm network-stream nsm starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-compat eieio-base gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader bbdb-message sendmail mail-extr message idna dired rfc822 mml mml-sec epg mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader gud dwarf-mode copyright dabbrev misearch multi-isearch vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs add-log rx vc-git diff-mode easy-mmode rust-mode flyspell ispell diminish edmacro kmacro projectile grep compile ibuf-ext ibuffer dash appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu minimap autorevert filenotify cus-start cus-load status erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec auth-source eieio gnus-util mm-util help-fns mail-prsvr password-cache thingatpt pp warnings advice vc-dir ewoc vc vc-dispatcher cc-styles cc-align cc-engine cc-vars cc-defs bbdb bbdb-site timezone ange-ftp comint ansi-color ring server savehist finder-inf dwarf-mode-autoloads gdb-shell-autoloads eieio-core lisppaste-autoloads pydoc-info-autoloads info-look cl-seq cl-macs cl weblogger-autoloads info package epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib bbdb-loaddefs time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 3390375 558178) (symbols 48 149617 336) (miscs 40 38197 18258) (strings 32 612251 197376) (string-bytes 1 18927351) (vectors 16 139866) (vector-slots 8 3014610 102546) (floats 8 3855 1441) (intervals 56 439788 4203) (buffers 976 532)) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 05:58:20 2017 Received: (at 25858) by debbugs.gnu.org; 24 Feb 2017 10:58:20 +0000 Received: from localhost ([127.0.0.1]:53576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chDZs-0005a5-Nz for submit@debbugs.gnu.org; Fri, 24 Feb 2017 05:58:20 -0500 Received: from mail-wr0-f180.google.com ([209.85.128.180]:33317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chDZq-0005Zs-5H for 25858@debbugs.gnu.org; Fri, 24 Feb 2017 05:58:18 -0500 Received: by mail-wr0-f180.google.com with SMTP id u47so10676572wrb.0 for <25858@debbugs.gnu.org>; Fri, 24 Feb 2017 02:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=q+yx9JAhIFR/QPL5JLpzXC7aFCkeg4fuSkbZLPsHU0g=; b=ZEIRlZ+Ih7I9jHT9rGQxLPK+9QRgkFflYtFlWB3y5sce3+1pmqHKtla0pzljTsYuvc i0VR4HxYvFZanrGdcLmdI4jwIoFguTvkpl7Xp6fGo14L3eNzDeHDRv24QtpgmVfuNHxv VJKyd5aqvlXvIdnJ3PTldZjW9oF+HvXaOKDdxes6EsUK4VIdbspVWhoPCrTQUeA8DTQd 12o2BBC+lImzZNdqTA3yDkdx2lWTAOC8fT2TyFlQIF8FsyuS1Dcu7l3vt0IgLQ9VYmP3 gi3bIFlP86RehzKQmYI8tQ/8lbtvjELdNUQj+c2FhEswXksM+X9T1lsGnpjdAkGdRi4y 9jlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q+yx9JAhIFR/QPL5JLpzXC7aFCkeg4fuSkbZLPsHU0g=; b=LqGkK64UDnWAZdDNeZdw9363W3vcMGN1mbzXORq10iRoPlx/4BM+kKVyx40GI/nMWh VqKn0rkRsmX1IJqA3rh2Bi/Wh/Iw+BUUD99CD6akH8LmfMZuWeBSwNazLms8AyKwe6G2 IDnqx46N48NuDYBNlZ/ZnmYQgUthgNOam4MymPwIpPGOQVGglhDMRw+SoS5UtXHHWTKf ltDJSL2Fob7Fp35D2qKWnGT7977rwDjSpYNN8sMtn93+GG6/IVL6a1bN8XLDG1LDNVB+ 6JEegrKayy4VdOubH8RGgGnJKeNquWA/hJ4NSmTUPDaPIk+jHpTEcrLy5C5YFVThc9+5 J/eA== X-Gm-Message-State: AMke39lmoneFV0NSm9iilKXY5bdDRowlV7FSxy6GOnvmtpwBQq20Xb3H5ZX6sDaKCNHi0w== X-Received: by 10.223.176.70 with SMTP id g6mr1907371wra.12.1487933892197; Fri, 24 Feb 2017 02:58:12 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id w17sm9907098wra.28.2017.02.24.02.58.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Feb 2017 02:58:11 -0800 (PST) Subject: Re: bug#25858: 25.1.91; js.el should use font-lock-doc-face To: Tom Tromey , 25858@debbugs.gnu.org References: <87d1e8vxyb.fsf@tromey.com> From: Dmitry Gutov Message-ID: Date: Fri, 24 Feb 2017 12:58:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87d1e8vxyb.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 25858 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) On 24.02.2017 09:40, Tom Tromey wrote: > > I think js-mode should recognize "/**"-style jsdoc comments and fontify > them using font-lock-doc-face. Some other programming modes do this > already. Agreed. An implementation like Python's should work well, I think. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 12:28:44 2017 Received: (at 25858) by debbugs.gnu.org; 25 Feb 2017 17:28:44 +0000 Received: from localhost ([127.0.0.1]:55950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chg9E-0003oP-FH for submit@debbugs.gnu.org; Sat, 25 Feb 2017 12:28:44 -0500 Received: from gproxy8-pub.mail.unifiedlayer.com ([67.222.33.93]:38340) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1chg9C-0003oB-QJ for 25858@debbugs.gnu.org; Sat, 25 Feb 2017 12:28:43 -0500 Received: (qmail 23359 invoked by uid 0); 25 Feb 2017 17:28:34 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy8.mail.unifiedlayer.com with SMTP; 25 Feb 2017 17:28:34 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id p5UV1u01T2f2jeq015UYWz; Sat, 25 Feb 2017 10:28:34 -0700 X-Authority-Analysis: v=2.1 cv=H5NInYoi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=vaJtXVxTAAAA:8 a=9GPtz0nih86XkTCqSTkA:9 a=zstS-IiYAAAA:8 a=4mfU5Zsja8ni8F5c4wAA:9 a=hCt-GehETBxEYQOojhlW:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zKMB+God8pXUpsU7+xEA1W1wl+5PDuSZpt91ouorYco=; b=BCEdIF/53qtzjZ6X7PRPvuBvKg tXcooRt4ainDGF33S0hpi9wGBJGrktW3+CA+GJJbv1+O5+5h+3SCIaLK+ovIY1mfDqb09SEQ2bx0f Z0S4KhVpGrAa4hSNsW9lUvpWZ; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:39146 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1chg8z-00083T-Ot; Sat, 25 Feb 2017 10:28:29 -0700 From: Tom Tromey To: Dmitry Gutov Subject: Re: bug#25858: 25.1.91; js.el should use font-lock-doc-face References: <87d1e8vxyb.fsf@tromey.com> X-Attribution: Tom Date: Sat, 25 Feb 2017 10:28:28 -0700 In-Reply-To: (Dmitry Gutov's message of "Fri, 24 Feb 2017 12:58:09 +0200") Message-ID: <878touuqmb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1chg8z-00083T-Ot X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:39146 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 25858 Cc: Tom Tromey , 25858@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain >>>>> "Dmitry" == Dmitry Gutov writes: Dmitry> Agreed. An implementation like Python's should work well, I think. How's this? Tom --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=P Content-Description: patch commit d825891eaf1480fe82d4f5c51b2a921dda6e9cf7 Author: Tom Tromey Date: Sat Feb 25 10:27:48 2017 -0700 Use font-lock-doc-face in js-mode Bug#25858: * lisp/progmodes/js.el (js-font-lock-syntactic-face-function): New defun. (js-mode): Use it. * test/lisp/progmodes/js-tests.el (js-mode-doc-comment-face): New test. diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index 65325a8..aed42a8 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -1687,6 +1687,16 @@ js--font-lock-keywords js--font-lock-keywords-3) "Font lock keywords for `js-mode'. See `font-lock-keywords'.") +(defun js-font-lock-syntactic-face-function (state) + "Return syntactic face given STATE." + (if (nth 3 state) + font-lock-string-face + (if (save-excursion + (goto-char (nth 8 state)) + (looking-at "/\\*\\*")) + font-lock-doc-face + font-lock-comment-face))) + (defconst js--syntax-propertize-regexp-regexp (rx ;; Start of regexp. @@ -3828,7 +3838,10 @@ js-mode (setq-local beginning-of-defun-function #'js-beginning-of-defun) (setq-local end-of-defun-function #'js-end-of-defun) (setq-local open-paren-in-column-0-is-defun-start nil) - (setq-local font-lock-defaults (list js--font-lock-keywords)) + (setq-local font-lock-defaults + (list js--font-lock-keywords nil nil nil nil + '(font-lock-syntactic-face-function + . js-font-lock-syntactic-face-function))) (setq-local syntax-propertize-function #'js-syntax-propertize) (setq-local prettify-symbols-alist js--prettify-symbols-alist) diff --git a/test/lisp/progmodes/js-tests.el b/test/lisp/progmodes/js-tests.el index 07e659a..e030675 100644 --- a/test/lisp/progmodes/js-tests.el +++ b/test/lisp/progmodes/js-tests.el @@ -128,6 +128,18 @@ ;; Any success is ok here. (should t))) +(ert-deftest js-mode-doc-comment-face () + (dolist (test '(("/*" "*/" font-lock-comment-face) + ("//" "\n" font-lock-comment-face) + ("/**" "*/" font-lock-doc-face) + ("\"" "\"" font-lock-string-face))) + (with-temp-buffer + (js-mode) + (insert (car test) " he") + (save-excursion (insert "llo " (cadr test))) + (font-lock-ensure) + (should (eq (get-text-property (point) 'face) (caddr test)))))) + (provide 'js-tests) ;;; js-tests.el ends here --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 14:54:55 2017 Received: (at 25858) by debbugs.gnu.org; 25 Feb 2017 19:54:55 +0000 Received: from localhost ([127.0.0.1]:56046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chiQh-0002O7-Bm for submit@debbugs.gnu.org; Sat, 25 Feb 2017 14:54:55 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chiQg-0002Nv-2g for 25858@debbugs.gnu.org; Sat, 25 Feb 2017 14:54:54 -0500 Received: by mail-wm0-f47.google.com with SMTP id v77so36231094wmv.1 for <25858@debbugs.gnu.org>; Sat, 25 Feb 2017 11:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hAFJxoE/x6HoLCqj2AEttr/8Tt68fdx4/Epaq6Soq68=; b=aCxbc8qz4ebFDX316mrl2v+BS7eeTN0n8CJhpUodmIljTg9rK9IngGeXqwnFnW9xad K5oueRHVTvD+8SkJqbclqLOUX0QT+MmCMQzZDWhjV05ZnEe+eOw5eNdnSi3V/7sU4bZP 055XYYncIrEc4ArVU0QBQI5JUa7lQ3EL9h1/WHBX39tCoOkTaXsErwN2FeAn2NSkvfx5 h0aHr3RoAGfKW1x1+0mOZE2pgcX+clKQVZmUDW17SwgyeFweAT0JYDUmxR6fnCkh7Zwu gzgGaSXTAryH0qi3o4h+/17aXgb9G7Yo5VdyzDRGrQRfIQB9J3ELzLyTIqi5AHeSmgo6 nHSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hAFJxoE/x6HoLCqj2AEttr/8Tt68fdx4/Epaq6Soq68=; b=j0qhqdDz+oPwhXcpcRYeP377D2bwm0FF9r5HzSkhr/+nH1Y4Dy/BXOVOtPgLkOGfyn VQ5eaDh6z4CBb1//cEvotURSCFV3ENdvRMXArc0CUH62rGcVDt/4f1ins58ro9MgMBCi ZHipMOizKWN4ET3RH/3mxXIyWH68HvbplacDC9A+5+5Ysbld66wBVJl2k47h2ACxjDHJ eUI8H47snzhDa/2fMee3zriF8QzkSg52R4QitpqhfU4GMziT6RcaWOWaZ3Mhb1Nswe/U reL5DQZ5Xges4S1MwRxjexlygVrxAOhz+t8QqKxnCY/hY6kf6Cpc1kGISqjWTj1nqAXj FLNg== X-Gm-Message-State: AMke39lduM9o8C7h8EzBWyiidumtQoB9uuiF0rW4NmgfsBdJzIv+X2wUPHDLVmXpMMLZ4w== X-Received: by 10.28.23.140 with SMTP id 134mr5793532wmx.23.1488052488083; Sat, 25 Feb 2017 11:54:48 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id r5sm15491236wra.25.2017.02.25.11.54.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Feb 2017 11:54:47 -0800 (PST) Subject: Re: bug#25858: 25.1.91; js.el should use font-lock-doc-face To: Tom Tromey References: <87d1e8vxyb.fsf@tromey.com> <878touuqmb.fsf@tromey.com> From: Dmitry Gutov Message-ID: Date: Sat, 25 Feb 2017 21:54:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <878touuqmb.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25858 Cc: 25858@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 25.02.2017 19:28, Tom Tromey wrote: > How's this? Good, thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 16:05:05 2017 Received: (at 25858-done) by debbugs.gnu.org; 25 Feb 2017 21:05:05 +0000 Received: from localhost ([127.0.0.1]:56071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chjWb-00047r-GI for submit@debbugs.gnu.org; Sat, 25 Feb 2017 16:05:05 -0500 Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:35096) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1chjWY-00047I-Uu for 25858-done@debbugs.gnu.org; Sat, 25 Feb 2017 16:05:03 -0500 Received: (qmail 29615 invoked by uid 0); 25 Feb 2017 21:04:48 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy7.mail.unifiedlayer.com with SMTP; 25 Feb 2017 21:04:48 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id p94k1u00x2f2jeq0194n1j; Sat, 25 Feb 2017 14:04:48 -0700 X-Authority-Analysis: v=2.1 cv=U+QBU4bu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=1hdqK-4IYftUmVsOWL0A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XSNaofVCdyp2MQ0OfMfUewwk/yfb/KKqs8YzWNYB+uo=; b=BoppTdB1DVLmv3uC9U4PIJLopW 0vY/sTn0CTHpvk8C+ymvd0jZJIO/YwF6cxY70x7O2D2xJ6MyHd73HcKtGIstfhJE3rd6urVu0c69T F4s8Grt+WhYihWKKCn18lBIYL; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:41366 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1chjWG-0007kK-Gk; Sat, 25 Feb 2017 14:04:44 -0700 From: Tom Tromey To: 25858-done@debbugs.gnu.org Subject: done X-Attribution: Tom Date: Sat, 25 Feb 2017 14:04:43 -0700 Message-ID: <87o9xqt21g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1chjWG-0007kK-Gk X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:41366 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 25858-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Patch checked in. Tom From unknown Sun Jun 22 11:39:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 26 Mar 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator