GNU bug report logs - #2585
23.0.90; read-file-name with dialog

Previous Next

Package: emacs;

Reported by: MJ <mj54590 <at> gmail.com>

Date: Fri, 6 Mar 2009 18:50:03 UTC

Severity: normal

Done: Jason Rumney <jasonr <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #30 received at 2585-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jason Rumney <jasonr <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: MJ <mj54590 <at> gmail.com>, 2585-done <at> debbugs.gnu.org
Subject: Re: bug#2585: 23.0.90; read-file-name with dialog
Date: Mon, 09 Mar 2009 21:31:41 +0800
Stefan Monnier wrote:
>>> ;; If DIR contains a file name, split it.
>>> (let ((file (file-name-nondirectory dir)))
>>> (when (and default-filename (not (zerop (length file))))
>>> (setq default-filename file)
>>> (setq dir (file-name-directory dir)))
>>>
>>> The third line makes more sense to me as:
>>>
>>> (when (and (not default-filename) (not (zerop (length file))))
>>>       
>> That seems right to me.  Stefan, you were the one who rewrote
>> read-file-name; could you verify this?
>>     
>
> Yes, it looks right,
>   

OK, I've checked that change in.




This bug report was last modified 16 years and 136 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.