GNU bug report logs - #2585
23.0.90; read-file-name with dialog

Previous Next

Full log

View this message in rfc822 format

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Stefan Monnier  <monnier <at> iro.umontreal.ca>
Cc: Jason Rumney <jasonr <at> gnu.org>, MJ <mj54590 <at> gmail.com>,
        2585 <at> debbugs.gnu.org
Subject: bug#2585: 23.0.90; read-file-name with dialog
Date: Sun, 08 Mar 2009 16:05:45 -0400

> Whoever did the conversion of read-file-name from C to lisp probably 
> knows what was meant by this, by my naive impression is that the 
> following logic is a mistake:
>
>   ;; If DIR contains a file name, split it.
>   (let ((file (file-name-nondirectory dir)))
>     (when (and default-filename (not (zerop (length file))))
>       (setq default-filename file)
>       (setq dir (file-name-directory dir)))
>
> The third line makes more sense to me as:
>
>  (when (and (not default-filename) (not (zerop (length file))))
>
> ie. if default-filename is specified, then the splitting should NOT be
> done.

That seems right to me.  Stefan, you were the one who rewrote
read-file-name; could you verify this?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.