GNU bug report logs - #2585
23.0.90; read-file-name with dialog

Previous Next

Package: emacs;

Reported by: MJ <mj54590 <at> gmail.com>

Date: Fri, 6 Mar 2009 18:50:03 UTC

Severity: normal

Done: Jason Rumney <jasonr <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jason Rumney <jasonr <at> gnu.org>
To: MJ <mj54590 <at> gmail.com>, 2585 <at> debbugs.gnu.org
Cc: emacs-pretest-bug <at> gnu.org
Subject: Re: bug#2585: 23.0.90; read-file-name with dialog
Date: Sat, 07 Mar 2009 15:50:25 +0800

Whoever did the conversion of read-file-name from C to lisp probably 
knows what was meant by this, by my naive impression is that the 
following logic is a mistake:

                 ;; If DIR contains a file name, split it.
                 (let ((file (file-name-nondirectory dir)))
                   (when (and default-filename (not (zerop (length file))))
                     (setq default-filename file)
                     (setq dir (file-name-directory dir)))


The third line makes more sense to me as:

        (when (and (not default-filename) (not (zerop (length file))))


ie. if default-filename is specified, then the splitting should NOT be done.
This bug report was last modified 16 years and 136 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.