From mjchan.inbox@gmail.com Fri Mar 6 10:41:27 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 6 Mar 2009 18:41:28 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n26IfOx7002375 for ; Fri, 6 Mar 2009 10:41:25 -0800 Received: from mx10.gnu.org ([199.232.76.166]:53381) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Lfez5-00043D-TQ for emacs-pretest-bug@gnu.org; Fri, 06 Mar 2009 13:41:24 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Lfez1-0005xN-Ux for emacs-pretest-bug@gnu.org; Fri, 06 Mar 2009 13:41:23 -0500 Received: from rv-out-0708.google.com ([209.85.198.245]:38477) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lfez1-0005wr-IW for emacs-pretest-bug@gnu.org; Fri, 06 Mar 2009 13:41:19 -0500 Received: by rv-out-0708.google.com with SMTP id f25so732303rvb.6 for ; Fri, 06 Mar 2009 10:41:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:mime-version :content-type:content-transfer-encoding:message-id:date:from:to :subject:x-signature:x-spam-processed:x-mdremoteip:x-return-path :x-mdaemon-deliver-to; bh=oZSXEa9hppbe8F6klqlwaHIVzpBI1ddvt4zLTUeLZ+A=; b=ugriuZ+phIrtnfkW/NKRLTfESkP+84jM36rzPnEeQvltaR79OZKdcNA/puJiMAb/DB uD1ZGevTuqm1aT238CKv/PChHy/MjsQ4q6nhZjxuIo0doAxjjXheWLC4GoiR084yNWWP sDpfD1Fsrab3A7Cir+eM6meq5GvhCjP3sFT0w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:mime-version:content-type:content-transfer-encoding :message-id:date:from:to:subject:x-signature:x-spam-processed :x-mdremoteip:x-return-path:x-mdaemon-deliver-to; b=Fx4+lSx9gu0L5hraS8QqLUdVMBuNQjltZ2ez7zKZlvDgELntj0eleVpx3Egfqvup8r /t2xGpFZ4FqBmAnRyVDRNSUGRH1VAuVQHLE1smK9edZ5ykxiB6GYUN7eFa9SWL1Q0HBX hj8ZOjju+6YkS/0o6A0S4PJwE4TJhwSPC7IhE= Received: by 10.114.81.1 with SMTP id e1mr1669747wab.212.1236364877606; Fri, 06 Mar 2009 10:41:17 -0800 (PST) Received: from greenplace.page.us (c-68-33-70-96.hsd1.md.comcast.net [68.33.70.96]) by mx.google.com with ESMTPS id z15sm3830985pod.0.2009.03.06.10.41.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 06 Mar 2009 10:41:16 -0800 (PST) Sender: MJ Chan Received: from T42 ([127.0.0.1]) by local (greenplace.page.us [127.0.0.1]) (MDaemon.PRO.v6.8.5.R) with ESMTP id 16-md50000000001.tmp for ; Fri, 06 Mar 2009 13:41:10 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18865.28230.516000.264948@MJ.T42.T42> Date: Fri, 6 Mar 2009 13:41:10 -0500 From: MJ To: emacs-pretest-bug@gnu.org Subject: 23.0.90; read-file-name with dialog X-Signature: mjchan 1548f55a6ed0d5c35ad11818fc49c2b2 X-MDRemoteIP: 127.0.0.1 X-Return-Path: mjchan.inbox@gmail.com X-MDaemon-Deliver-To: emacs-pretest-bug@gnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) When read-file-name is called and uses windows dialog to read a file name, the 'dir' parameter has to be ended with '/'. It it does not, the last part of the path name is used as the filename while the default directory is the stripped 'dir' without last part. This does not happen in Emacs 22. In minibuffer, there is comment that says: ;; If DIR contains a file name, split it. I'm not sure if that is the right thing to do. At least, it breaks the compatibility with previous Emacs version. Is this an intended change? Thanks. -- In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600) of 2009-02-22 on T42 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --cflags -I../../GnuWin32/include' From jasonrumney@gmail.com Fri Mar 6 23:51:05 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 7 Mar 2009 07:51:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n277p2dZ016630 for ; Fri, 6 Mar 2009 23:51:03 -0800 Received: from mx10.gnu.org ([199.232.76.166]:57938) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LfrJF-0004St-An for emacs-pretest-bug@gnu.org; Sat, 07 Mar 2009 02:51:01 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LfrJE-000732-CG for emacs-pretest-bug@gnu.org; Sat, 07 Mar 2009 02:51:00 -0500 Received: from mx20.gnu.org ([199.232.41.8]:40677) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LfrJE-00072x-3j for emacs-pretest-bug@gnu.org; Sat, 07 Mar 2009 02:51:00 -0500 Received: from ti-out-0910.google.com ([209.85.142.189]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LfrJC-0006vA-Di for emacs-pretest-bug@gnu.org; Sat, 07 Mar 2009 02:50:58 -0500 Received: by ti-out-0910.google.com with SMTP id j3so388150tid.10 for ; Fri, 06 Mar 2009 23:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=yjb4008kyFr8sY7FQfj/M0V8jr6IltMacp9Zhp8yVLM=; b=uvemFGYlqYBavsyYqjGxuD+95ME17LbpEI/iwqvM+GOERSa06TPUXXnRhHuqPNRg5z K7Gy/PUeQDrqLevxlEfIMvc1tKmApxLela8cjOreVJsiP5by8v1MawNYBSf87RN8c1XK fzj7W59AKq6IdgYFuBuYQXMMA0Wqg3qcFcqhg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=uPY2BIVqW7vYz86YFmGFIWUg6gfNF88qBuLA4b1BhCua7n4T2me9B7102yqzSlrlpk 8RE39bFoGY/K3ddhfQI4Ov/DRq1zIY9Ue58rmGFVKxlPiEkHCK3VnMKpdERyU4+FQ7KZ 7zkSKUIxxCrU8uBl/vfp4cdMtGBmeoz5QfgJI= Received: by 10.110.40.8 with SMTP id n8mr5074301tin.28.1236412255297; Fri, 06 Mar 2009 23:50:55 -0800 (PST) Received: from ?192.168.249.26? ([118.100.161.108]) by mx.google.com with ESMTPS id j5sm202863tid.21.2009.03.06.23.50.52 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 06 Mar 2009 23:50:54 -0800 (PST) Sender: Jason Rumney Message-ID: <49B22741.3000502@gnu.org> Date: Sat, 07 Mar 2009 15:50:25 +0800 From: Jason Rumney User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: MJ , 2585@debbugs.gnu.org CC: emacs-pretest-bug@gnu.org Subject: Re: bug#2585: 23.0.90; read-file-name with dialog References: <18865.28230.516000.264948@MJ.T42.T42> In-Reply-To: <18865.28230.516000.264948@MJ.T42.T42> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Whoever did the conversion of read-file-name from C to lisp probably knows what was meant by this, by my naive impression is that the following logic is a mistake: ;; If DIR contains a file name, split it. (let ((file (file-name-nondirectory dir))) (when (and default-filename (not (zerop (length file)))) (setq default-filename file) (setq dir (file-name-directory dir))) The third line makes more sense to me as: (when (and (not default-filename) (not (zerop (length file)))) ie. if default-filename is specified, then the splitting should NOT be done. From cyd@stupidchicken.com Sun Mar 8 13:04:36 2009 Received: (at 2585) by emacsbugs.donarmstrong.com; 8 Mar 2009 20:04:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n28K4XLY012654 for <2585@emacsbugs.donarmstrong.com>; Sun, 8 Mar 2009 13:04:34 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 2C02357E205; Sun, 8 Mar 2009 16:05:45 -0400 (EDT) From: Chong Yidong To: Stefan Monnier Cc: Jason Rumney , MJ , 2585@debbugs.gnu.org Subject: Re: bug#2585: 23.0.90; read-file-name with dialog Date: Sun, 08 Mar 2009 16:05:45 -0400 Message-ID: <87fxhnok4m.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Whoever did the conversion of read-file-name from C to lisp probably > knows what was meant by this, by my naive impression is that the > following logic is a mistake: > > ;; If DIR contains a file name, split it. > (let ((file (file-name-nondirectory dir))) > (when (and default-filename (not (zerop (length file)))) > (setq default-filename file) > (setq dir (file-name-directory dir))) > > The third line makes more sense to me as: > > (when (and (not default-filename) (not (zerop (length file)))) > > ie. if default-filename is specified, then the splitting should NOT be > done. That seems right to me. Stefan, you were the one who rewrote read-file-name; could you verify this? From monnier@iro.umontreal.ca Sun Mar 8 13:24:50 2009 Received: (at 2585) by emacsbugs.donarmstrong.com; 8 Mar 2009 20:24:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n28KOlkT018630 for <2585@emacsbugs.donarmstrong.com>; Sun, 8 Mar 2009 13:24:49 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap4EAMjFs0lLd/DG/2dsb2JhbACBTdEchAUGhCE X-IronPort-AV: E=Sophos;i="4.38,325,1233550800"; d="scan'208";a="34866037" Received: from 75-119-240-198.dsl.teksavvy.com (HELO ceviche.home) ([75.119.240.198]) by ironport2-out.teksavvy.com with ESMTP; 08 Mar 2009 16:24:42 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 61AFDB403E; Sun, 8 Mar 2009 16:24:44 -0400 (EDT) From: Stefan Monnier To: Chong Yidong Cc: Jason Rumney , MJ , 2585@debbugs.gnu.org Subject: Re: bug#2585: 23.0.90; read-file-name with dialog Message-ID: References: <87fxhnok4m.fsf@cyd.mit.edu> Date: Sun, 08 Mar 2009 16:24:44 -0400 In-Reply-To: <87fxhnok4m.fsf@cyd.mit.edu> (Chong Yidong's message of "Sun, 08 Mar 2009 16:05:45 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Whoever did the conversion of read-file-name from C to lisp probably >> knows what was meant by this, by my naive impression is that the >> following logic is a mistake: >> >> ;; If DIR contains a file name, split it. >> (let ((file (file-name-nondirectory dir))) >> (when (and default-filename (not (zerop (length file)))) >> (setq default-filename file) >> (setq dir (file-name-directory dir))) >> >> The third line makes more sense to me as: >> >> (when (and (not default-filename) (not (zerop (length file)))) >> >> ie. if default-filename is specified, then the splitting should NOT be >> done. > That seems right to me. Stefan, you were the one who rewrote > read-file-name; could you verify this? Yes, it looks right, Stefan From jasonrumney@gmail.com Mon Mar 9 06:32:17 2009 Received: (at 2585-done) by emacsbugs.donarmstrong.com; 9 Mar 2009 13:32:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.184]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n29DWE9k029891 for <2585-done@emacsbugs.donarmstrong.com>; Mon, 9 Mar 2009 06:32:15 -0700 Received: by ti-out-0910.google.com with SMTP id 28so1130498tif.1 for <2585-done@emacsbugs.donarmstrong.com>; Mon, 09 Mar 2009 06:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Ey0bIXetpen34doDGzMOcVFjCbUTMmruhZinHoZGLVQ=; b=oSbyo4nNLyiI13bwKPUyMytHSwG4fkWRXEu+cEOuMfuHGUKlNhAdfrIQ5FwC2NLETd J7ycTSZg/kqKKteLgQr5VR2kbNV/1avgjTqIIM163OuXxl5Ju8XJRffnU63UIU4nPVm/ Ck/iUWGwo2V5mtn+jGEDVmmMkrJEXxGlj+fnM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=Z4e8K9B9uh6XBaKhta3xJiYbLOJD2IT74cYtllnl99lHJLRw7H/EJHJifef5XwctvX LVbtT+VJNdOdW8QC4is/l+WyfVgHvroloYIqOmKAcqI4lGXerbF8S3ds2AgyRNH+rm1+ T2YOfDRaRkWCMKSKrzWI8mrge/tt/cr+xkp5s= Received: by 10.110.42.1 with SMTP id p1mr9173738tip.18.1236605532116; Mon, 09 Mar 2009 06:32:12 -0700 (PDT) Received: from ?192.168.249.26? ([118.100.161.108]) by mx.google.com with ESMTPS id 25sm804363tif.12.2009.03.09.06.32.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 09 Mar 2009 06:32:11 -0700 (PDT) Sender: Jason Rumney Message-ID: <49B51A3D.7040101@gnu.org> Date: Mon, 09 Mar 2009 21:31:41 +0800 From: Jason Rumney User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Stefan Monnier CC: MJ , 2585-done@debbugs.gnu.org Subject: Re: bug#2585: 23.0.90; read-file-name with dialog References: <87fxhnok4m.fsf@cyd.mit.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Stefan Monnier wrote: >>> ;; If DIR contains a file name, split it. >>> (let ((file (file-name-nondirectory dir))) >>> (when (and default-filename (not (zerop (length file)))) >>> (setq default-filename file) >>> (setq dir (file-name-directory dir))) >>> >>> The third line makes more sense to me as: >>> >>> (when (and (not default-filename) (not (zerop (length file)))) >>> >> That seems right to me. Stefan, you were the one who rewrote >> read-file-name; could you verify this? >> > > Yes, it looks right, > OK, I've checked that change in. From unknown Sat Aug 16 11:09:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Apr 2009 14:24:09 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator