From unknown Thu Aug 14 20:55:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25839 <25839@debbugs.gnu.org> To: bug#25839 <25839@debbugs.gnu.org> Subject: Status: 26.0.50; Bug in gnus-registry-article-marks-to-chars Reply-To: bug#25839 <25839@debbugs.gnu.org> Date: Fri, 15 Aug 2025 03:55:08 +0000 retitle 25839 26.0.50; Bug in gnus-registry-article-marks-to-chars reassign 25839 emacs submitter 25839 Eric Abrahamsen severity 25839 normal tag 25839 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 12:23:38 2017 Received: (at submit) by debbugs.gnu.org; 22 Feb 2017 17:23:38 +0000 Received: from localhost ([127.0.0.1]:51466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgadc-00048R-Jl for submit@debbugs.gnu.org; Wed, 22 Feb 2017 12:23:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgadb-00048F-Gr for submit@debbugs.gnu.org; Wed, 22 Feb 2017 12:23:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgadV-0003SA-DF for submit@debbugs.gnu.org; Wed, 22 Feb 2017 12:23:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42329) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgadV-0003S2-9H for submit@debbugs.gnu.org; Wed, 22 Feb 2017 12:23:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgadU-0007mU-42 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:23:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgadR-0003Qt-08 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:23:28 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:59965) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgadQ-0003P3-QQ for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2017 12:23:24 -0500 Received: from localhost (71-212-6-137.tukw.qwest.net [71.212.6.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 43B3BBE5F7 for ; Wed, 22 Feb 2017 17:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1487784197; bh=X4smDS/Zp7DrDr7SlGwzatPvhmLMi71ET2SJ7o/6PRU=; h=From:To:Subject:Date:From; b=fHdq/m8jEjdkfK74tt7rXWGNymiqw5hnLw0WaEEQSmDl9EG1n3LNXa293ZjwD1nuE 8Bn8j7AUfp/riVNA6ZqY6j69KNL9Alx8ewPBvLC6xEvbkmFQ+KpfB1aoMYnrifmmTg QxPgaOFK5QiGAmOrWiZVIHZqhT2GO982cq2tFDZU= From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Bug in gnus-registry-article-marks-to-chars Date: Wed, 22 Feb 2017 09:23:16 -0800 Message-ID: <87a89edtrv.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain The current implementation of gnus-registry-article-marks-to-chars errors out because it tries to use mapconcat on a list of characters. I've attached a patch that extracts the characters first and then uses the mapconcat with char-to-string. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Use-char-to-string-in-gnus-registry-article-marks-to.patch >From b05ff977a349688fc006fac399b0f29516f0ecef Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Wed, 22 Feb 2017 09:21:53 -0800 Subject: [PATCH] Use char-to-string in gnus-registry-article-marks-to-chars * lisp/gnus/gnus-registry.el (gnus-registry-article-marks-to-chars): Otherwise it was running a list of characters through mapconcat, which produced an error. --- lisp/gnus/gnus-registry.el | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lisp/gnus/gnus-registry.el b/lisp/gnus/gnus-registry.el index f728b19111..8229927176 100644 --- a/lisp/gnus/gnus-registry.el +++ b/lisp/gnus/gnus-registry.el @@ -967,13 +967,15 @@ 'gnus-registry-user-format-function-M (defun gnus-registry-article-marks-to-chars (headers) "Show the marks for an article by the :char property." (let* ((id (mail-header-message-id headers)) - (marks (when id (gnus-registry-get-id-key id 'mark)))) - (mapconcat (lambda (mark) - (plist-get - (cdr-safe - (assoc mark gnus-registry-marks)) - :char)) - marks ""))) + (marks (when id (gnus-registry-get-id-key id 'mark))) + (mark-chars + (delq nil (mapcar (lambda (mark) + (plist-get + (cdr-safe + (assoc mark gnus-registry-marks)) + :char)) + marks)))) + (mapconcat #'char-to-string mark-chars ""))) ;; use like this: ;; (defalias 'gnus-user-format-function-M 'gnus-registry-article-marks-to-names) -- 2.11.1 --=-=-= Content-Type: text/plain In GNU Emacs 26.0.50 (build 28, x86_64-unknown-linux-gnu, GTK+ Version 3.22.8) of 2017-02-19 built on clem Repository revision: c8d14cfc6c2d19077d137c7e917fbb4f104de222 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 13:16:17 2017 Received: (at 25839) by debbugs.gnu.org; 22 Feb 2017 18:16:17 +0000 Received: from localhost ([127.0.0.1]:51495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgbSb-0005Jy-Lc for submit@debbugs.gnu.org; Wed, 22 Feb 2017 13:16:17 -0500 Received: from mail-ot0-f176.google.com ([74.125.82.176]:32808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgbSa-0005Jl-Qp for 25839@debbugs.gnu.org; Wed, 22 Feb 2017 13:16:17 -0500 Received: by mail-ot0-f176.google.com with SMTP id k4so8011495otc.0 for <25839@debbugs.gnu.org>; Wed, 22 Feb 2017 10:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=enQ2b7e6LY4ZcgP4Njxahzs9OcgSEkNt2dOdVyz2xK0=; b=q8NoP0uqMU1rszDbqZb5lYY4F35/6+MK3ruR4mBonXodljFYtV9C9abeVTHrX5Xrfd m20a9oBmTIqPiHWu3QvR/QhCyc0ap3LIV7YTmAyxGA2pE37G2h+puE7ibJlivkMV9uAa JtsR2cHRoU7ktsd6ywNFGqjAAzZ3cB1jReghnD6/p5DMdWFRGA9gOOPp5gXyF4Muy4Rl acQHhUHrf3VKdvQlbHeY++DJusZT32Qbr12/ng9Qdn1OLud4jO2BzGKsGEm3PrOKmjb7 tKDBPNSoALOf/tnk7KhumzWweMV/FdwxHhkiJNnx5kaGMSb6ddrY+etqxpnOJMIqwaN5 QoHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=enQ2b7e6LY4ZcgP4Njxahzs9OcgSEkNt2dOdVyz2xK0=; b=U1y4mVxIL+Xd82r/xwpkmQWk1IuT1LWbc+YwKHtnJ0wr6sLgdB3C+e9mcc7h8r+f7G v/nx93BCTIP345/l7qODNN6zHqQ6XgU6NHzuUHtybX2N1X8P5JORFjVXTtu9nOFD+O07 3oXub2qX6ugtao/KK9BySVUEWVce9xQz0NkwRy3k0vjesW0S3NalKhkQjiLBggxcGyOt gr9Jo+/Op/gT9VbVIFKsxKJBiq5+ETdLQCUG7iphbJIa1xIFRSrgWA7qDkcb6yBT+emg A6SZt0tSXDV3Ulhn/lV9E3eaGDIXImOjBpZ5aGixQ9d41SoOCIGwrpYPqxv4C56aPzQ0 C5rg== X-Gm-Message-State: AMke39nDPiSJSama05/znI6QOI02fGxlD+QUZeslqosqb1CKW2v4RyCBqD3GhAqVxg62l6hfq3Dq7YnFAFZ1hQ== X-Received: by 10.157.68.216 with SMTP id p24mr4918834otg.55.1487787371174; Wed, 22 Feb 2017 10:16:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.35.87 with HTTP; Wed, 22 Feb 2017 10:16:10 -0800 (PST) In-Reply-To: <87a89edtrv.fsf@ericabrahamsen.net> References: <87a89edtrv.fsf@ericabrahamsen.net> From: Noam Postavsky Date: Wed, 22 Feb 2017 13:16:10 -0500 X-Google-Sender-Auth: fzclhWndsAN_l--r8E0RmXjscK4 Message-ID: Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars To: Eric Abrahamsen Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25839 Cc: 25839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Wed, Feb 22, 2017 at 12:23 PM, Eric Abrahamsen wrote: > > The current implementation of gnus-registry-article-marks-to-chars > errors out because it tries to use mapconcat on a list of characters. > I've attached a patch that extracts the characters first and then uses > the mapconcat with char-to-string. > > + (mapconcat #'char-to-string mark-chars ""))) AFAIK, this should be the same as (apply #'string mark-chars). From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 13:34:06 2017 Received: (at 25839) by debbugs.gnu.org; 22 Feb 2017 18:34:06 +0000 Received: from localhost ([127.0.0.1]:51501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgbjq-0005iw-7L for submit@debbugs.gnu.org; Wed, 22 Feb 2017 13:34:06 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:50233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgbjp-0005ip-6p for 25839@debbugs.gnu.org; Wed, 22 Feb 2017 13:34:05 -0500 Received: from localhost (71-212-6-137.tukw.qwest.net [71.212.6.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 6F138BE5F7; Wed, 22 Feb 2017 18:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1487788444; bh=oacl4LvZZ2E/vuFMaTSIluvtlgUreHXkhbPm43qrBCs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ihQQmtRoBbqnnNsKVoAaGE1EEJIFGJzT1A7poCylua59IjwyMPHIhkg97kzMbaxc7 RnWawz9T6++bqYHL06Zs1dk40bVf9JGGLc7J2A3BVIxlWD/WnnPktpT5/2mTuZPFUd tPE/s13Wx0htqieeEzfw/oayMsbIMoYZyMCpTlwo= From: Eric Abrahamsen To: Noam Postavsky Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars References: <87a89edtrv.fsf@ericabrahamsen.net> Date: Wed, 22 Feb 2017 10:34:03 -0800 In-Reply-To: (Noam Postavsky's message of "Wed, 22 Feb 2017 13:16:10 -0500") Message-ID: <8760k2dqhw.fsf@ericabrahamsen.net> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/26.0 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25839 Cc: Eric Abrahamsen , 25839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 02/22/17 13:16 PM, Noam Postavsky wrote: > On Wed, Feb 22, 2017 at 12:23 PM, Eric Abrahamsen > wrote: >> >> The current implementation of gnus-registry-article-marks-to-chars >> errors out because it tries to use mapconcat on a list of characters. >> I've attached a patch that extracts the characters first and then uses >> the mapconcat with char-to-string. >> > >> + (mapconcat #'char-to-string mark-chars ""))) > > AFAIK, this should be the same as (apply #'string mark-chars). Good point! Let me stare at this a bit longer, and post another patch. E From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 13:53:37 2017 Received: (at 25839) by debbugs.gnu.org; 22 Feb 2017 18:53:37 +0000 Received: from localhost ([127.0.0.1]:51505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgc2i-000696-RR for submit@debbugs.gnu.org; Wed, 22 Feb 2017 13:53:36 -0500 Received: from mail-ot0-f179.google.com ([74.125.82.179]:35112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgc2h-00068u-JK for 25839@debbugs.gnu.org; Wed, 22 Feb 2017 13:53:35 -0500 Received: by mail-ot0-f179.google.com with SMTP id w44so8686524otw.2 for <25839@debbugs.gnu.org>; Wed, 22 Feb 2017 10:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=LwbI7xCMW9uX41oPZcyYnemYTA3/tTw8RUDgBhTVzGQ=; b=D/DDK+ewAUWOAQu3QxQaFDFmeiDcZfMHRnBy2qge0k+zpjxj8nR0W59Dl2t8niR9AO dgdhFkCzxfp+XUi7lWFXiHcQh73MLCIs3gpwcNm/Q3W7cfKWjO6WoR7PQHtg7IMhr8Ym XM+WAbXAq0WQTPvw3vbaU6jLSxYGNWR8kKMVbrXWgHLcWf73A7zK/j6MrDyBC7gzuNQO Ct3T2yymNYbHL6ye7GIX2jU/axAzWmDx0ECNQFBgTgI/0wydjm9AUBqCd5g6mY2COK8V KD8yReQCfVJ9legMFB2+1qde/oawJRL6Smw9uaV9epP7nqxLZKeWuu0alzDyPkOru1EB fhGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=LwbI7xCMW9uX41oPZcyYnemYTA3/tTw8RUDgBhTVzGQ=; b=UDWqow2QdS6x+rMdV9yNDDl4pMfS8yhHoKiCLmnRPYB3hXI09Q11IZFiO1VW/WJyST IYWt4YqmJiZ0z6bkletlaYyQHh5XjCR7YWozjApfhsRD+0XE7m09owmR41B5WeBHqVqA GE4bt1l7cbYhfuGj7uSf35sVFITlQ0aHLiBwyPYCcxFQQo9p88B2SFLPZK+7cGfc5eKs 5J2/QRbD9ZGuDrAJbsoue1IFpe8XokdCTFeZxglSXMUDlr/Otw+A1TQxoHlq2AVx/taI oBJ4P8NtZO0nBr/dTdem8daAENKVFZa72mjm8vOcxJ2A5C9P/Pul3XKtwROTWVnPUkq7 G4wQ== X-Gm-Message-State: AMke39lDk3mY3ruJjLjAsxtb71sLKm9t8/W2SWw2GD1FhzKZ/HnBfC3hqc2nw326NBNPRI8TWhni+6s1vey5ew== X-Received: by 10.157.29.100 with SMTP id m91mr20246563otm.6.1487789609888; Wed, 22 Feb 2017 10:53:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.35.87 with HTTP; Wed, 22 Feb 2017 10:53:29 -0800 (PST) In-Reply-To: <8760k2dqhw.fsf@ericabrahamsen.net> References: <87a89edtrv.fsf@ericabrahamsen.net> <8760k2dqhw.fsf@ericabrahamsen.net> From: Noam Postavsky Date: Wed, 22 Feb 2017 13:53:29 -0500 X-Google-Sender-Auth: 4aaigq3wGpga4fOYti1LflIDwyg Message-ID: Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars To: Eric Abrahamsen Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25839 Cc: 25839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Wed, Feb 22, 2017 at 1:34 PM, Eric Abrahamsen wrote: > > On 02/22/17 13:16 PM, Noam Postavsky wrote: >> On Wed, Feb 22, 2017 at 12:23 PM, Eric Abrahamsen >> wrote: >>> >>> The current implementation of gnus-registry-article-marks-to-chars >>> errors out because it tries to use mapconcat on a list of characters. >>> I've attached a patch that extracts the characters first and then uses >>> the mapconcat with char-to-string. >>> >> >>> + (mapconcat #'char-to-string mark-chars ""))) >> >> AFAIK, this should be the same as (apply #'string mark-chars). > > Good point! Let me stare at this a bit longer, and post another patch. > Or actually even simpler: (concat mark-chars) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 22:16:58 2017 Received: (at 25839) by debbugs.gnu.org; 23 Feb 2017 03:16:58 +0000 Received: from localhost ([127.0.0.1]:51823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgjtq-0006TD-7t for submit@debbugs.gnu.org; Wed, 22 Feb 2017 22:16:58 -0500 Received: from mail-it0-f44.google.com ([209.85.214.44]:35161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgjto-0006Nu-2d; Wed, 22 Feb 2017 22:16:56 -0500 Received: by mail-it0-f44.google.com with SMTP id 203so160668431ith.0; Wed, 22 Feb 2017 19:16:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XEz4GcUvhJH+Hg0G03Xt96ZULJzk6IHPVfCwhkH3RYc=; b=gcx4tyQUaNiJvsadoTia6mXpiRPoDHue4na4I6i2u2KJ032UA3/rTPwJ0c4NL6pQAc UvYJituxmTd1BD77mKliKiRtJ8FytLfhTaUHoZnxwpSZNr8ZojvhsVzmlKHSk7QyL3SY zBDNlGnOg1kfzMxzYuN1yd3jJwXc+2OKPyW9bJE0jyCrmFFLetEQnTyKyIpB+Nb0BcCp /dreujqQkNtqRTlKPHiG70BhWejUkixpZYVpS/zZ4DNAykCovX/snRErGvAcI11aRVEy EeD/J75Sn2PL4FXmAl4whQ0ZjEbZ2aMK4K8e5jYEC54vgGi9PEn7vFeUbO+zWgOKE5VX Xlkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=XEz4GcUvhJH+Hg0G03Xt96ZULJzk6IHPVfCwhkH3RYc=; b=MVYAevQhwhHiMLEg3z440ppyW9jz3VaAOY6zEv5tAKS0Kj6sfICf17deglohNsvFXc c9Zz/bM5UKULacwWyFtewflYy1Ke24FZJF+NgDXglyCJmHNJo6GHKjiYNocKho0Apfdd 5957kf5s+6M1xNULxdiBxXx/BQnCJbM9HqrB7YK+yUPIyIRG9tM4juEYUHIug+rWqIph 7xa//esvofP0v9n7t6c+uY8//Z8Yskqu3EbgTkKIbo6ZktK1bT2jIOaJkvVHvAt62xHz D2KTfLNlxdQlf8RlYpx1a5O1pk2nhKN3U1Tm43YP7PspXR4SdnbXbuIPCNg5nzRFKBn+ An9g== X-Gm-Message-State: AMke39m/EBgJJW7XXxMLIVTaFBBxfGZdGydD4Elyv8KznxMJa5aESapioigZE7QDGV0Sqw== X-Received: by 10.107.164.147 with SMTP id d19mr28201991ioj.79.1487819810541; Wed, 22 Feb 2017 19:16:50 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p68sm466679iop.8.2017.02.22.19.16.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Feb 2017 19:16:49 -0800 (PST) From: npostavs@users.sourceforge.net To: Eric Abrahamsen Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars References: <87a89edtrv.fsf@ericabrahamsen.net> <8760k2dqhw.fsf@ericabrahamsen.net> Date: Wed, 22 Feb 2017 22:18:02 -0500 In-Reply-To: (Noam Postavsky's message of "Wed, 22 Feb 2017 13:53:29 -0500") Message-ID: <87r32pfvdh.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25839 Cc: 25839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain tags 25839 patch quit Forwarding message to list. --=-=-= Content-Type: message/rfc822 Content-Disposition: inline Delivered-To: npostavs@gmail.com Received: by 10.157.11.3 with SMTP id a3csp1076906ota; Wed, 22 Feb 2017 17:28:32 -0800 (PST) X-Received: by 10.107.181.10 with SMTP id e10mr26625223iof.156.1487813312818; Wed, 22 Feb 2017 17:28:32 -0800 (PST) Return-Path: Received: from mx.sourceforge.net (mx.sourceforge.net. [216.34.181.68]) by mx.google.com with ESMTPS id h202si3283047ita.24.2017.02.22.17.28.32 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 22 Feb 2017 17:28:32 -0800 (PST) Received-SPF: fail (google.com: domain of eric@ericabrahamsen.net does not designate 216.34.181.68 as permitted sender) client-ip=216.34.181.68; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@sourceforge.net; dkim=pass (test mode) header.i=@sf.net; dkim=pass header.i=@mail.ericabrahamsen.net; spf=fail (google.com: domain of eric@ericabrahamsen.net does not designate 216.34.181.68 as permitted sender) smtp.mailfrom=eric@ericabrahamsen.net; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ericabrahamsen.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:To:From; bh=5brBZHUhoa5MHnPCcgTS9vishR81SfEzVFtu1g9zChY=; b=k0jsDxqEPpTDwp7ZRZ0PRZxieCZNH+qpsV6bNihRPn4HR2XklAJvYTP7jO2QstsRarNY22xxlTVYZVgRLisbGWipMTAc0LC3Wlbmv1FORvupFJpiGgR1KfbTVmbAriNn6ksBB9vc0Q1OPYQhAcUKktmxcQWPrF4rYi137xY0iVI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:To:From; bh=5brBZHUhoa5MHnPCcgTS9vishR81SfEzVFtu1g9zChY=; b=ZWxGXa+O18gVgsUt5vx20hSqUVz/iOKNwvupjznMtcqJD05v2jitxbon5ma12lxc1A9Wt2AXjfE0RhK+OqTuFvgIxTptvQlVTTdWJ3PRU1IhJF7A/U8070JMc///4rR4vasUR3NoT0lLcTCw2C0iQyhxrtHgM6zomJSeMfPuoWk=; Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of ericabrahamsen.net designates 50.56.99.223 as permitted sender) client-ip=50.56.99.223; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net; Received: from mail.ericabrahamsen.net ([50.56.99.223]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1cgiCs-00005q-5f for npostavs@users.sourceforge.net; Thu, 23 Feb 2017 01:28:32 +0000 Received: from localhost (unknown [162.208.42.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D4573BE5F7 for ; Thu, 23 Feb 2017 01:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1487813305; bh=5brBZHUhoa5MHnPCcgTS9vishR81SfEzVFtu1g9zChY=; h=From:To:Subject:References:Date:In-Reply-To:From; b=NyyPBVVzVxZMqOQLbIW4tjHm+WlmzogGeflxrKCcXtVUIB5+f3dbaqr8P9j9SIqAP sNKuna0O54xgro5H8iJgMbhvVLM/tCG1aV81uehsiUOmq+RrF7qzPj0w+hIL54DaoQ WcdDqJ+yRv0+X8MZHWDrvJYLRpOdOdj0kHwcU4E8= From: Eric Abrahamsen To: Noam Postavsky Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars References: <87a89edtrv.fsf@ericabrahamsen.net> <8760k2dqhw.fsf@ericabrahamsen.net> Date: Wed, 22 Feb 2017 17:28:24 -0800 In-Reply-To: (Noam Postavsky's message of "Wed, 22 Feb 2017 13:53:29 -0500") Message-ID: <87fuj5vgp3.fsf@pellet> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1cgiCs-00005q-5f MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="====-=-=" --====-=-= Content-Type: text/plain Content-Disposition: inline On 02/22/17 13:53 PM, Noam Postavsky wrote: > On Wed, Feb 22, 2017 at 1:34 PM, Eric Abrahamsen > wrote: >> >> On 02/22/17 13:16 PM, Noam Postavsky wrote: >>> On Wed, Feb 22, 2017 at 12:23 PM, Eric Abrahamsen >>> wrote: >>>> >>>> The current implementation of gnus-registry-article-marks-to-chars >>>> errors out because it tries to use mapconcat on a list of characters. >>>> I've attached a patch that extracts the characters first and then uses >>>> the mapconcat with char-to-string. >>>> >>> >>>> + (mapconcat #'char-to-string mark-chars ""))) >>> >>> AFAIK, this should be the same as (apply #'string mark-chars). >> >> Good point! Let me stare at this a bit longer, and post another patch. >> > > Or actually even simpler: (concat mark-chars) Very nice! Here's another one. --====-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Don-t-use-mapconcat-with-chars-in-gnus-registry-mark.patch >From 2f2c368ba872478476cee1d1b6e121480ec64cfc Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Wed, 22 Feb 2017 17:26:11 -0800 Subject: [PATCH] Don't use mapconcat with chars in gnus registry marks * lisp/gnus/gnus-registry.el (gnus-registry-article-marks-to-chars): Instead, use a plain concat, which will create a string out of a list of chars. --- lisp/gnus/gnus-registry.el | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lisp/gnus/gnus-registry.el b/lisp/gnus/gnus-registry.el index f728b19111..51f6459d2f 100644 --- a/lisp/gnus/gnus-registry.el +++ b/lisp/gnus/gnus-registry.el @@ -968,12 +968,13 @@ gnus-registry-article-marks-to-chars "Show the marks for an article by the :char property." (let* ((id (mail-header-message-id headers)) (marks (when id (gnus-registry-get-id-key id 'mark)))) - (mapconcat (lambda (mark) - (plist-get - (cdr-safe - (assoc mark gnus-registry-marks)) - :char)) - marks ""))) + (concat (delq nil + (mapcar + (lambda (m) + (plist-get + (cdr-safe (assoc m gnus-registry-marks)) + :char)) + marks))))) ;; use like this: ;; (defalias 'gnus-user-format-function-M 'gnus-registry-article-marks-to-names) -- 2.11.1 --====-=-=-- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 22:00:21 2017 Received: (at 25839) by debbugs.gnu.org; 1 Mar 2017 03:00:21 +0000 Received: from localhost ([127.0.0.1]:60759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciuV2-0003Vj-VH for submit@debbugs.gnu.org; Tue, 28 Feb 2017 22:00:21 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:33225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciuV0-0003VR-7z; Tue, 28 Feb 2017 22:00:19 -0500 Received: by mail-it0-f67.google.com with SMTP id 68so3634089itg.0; Tue, 28 Feb 2017 19:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=L7EycwgBpS87PBQ7vDdeNTEnqltBzDtaEyWZI/eMgUg=; b=owAcU+W1DkCIBwX3Cb5lHy/psr8QGOMW6EG8eZDY4fPm0B6ZwyU8MeVF1LoRK2kmp5 Carf/iEz67joUc09RJPDQLOxE64qBbEjqYJCCqZOQKLyzaVuE3zM0q2LnY9+g8gFRbkf 8geBB1b5wTW4UroPUYiguLXYIgfYjAhc32dTWT6ViYVbaE2simrsR096yuKlhdDaYmqo okUuhxh9hDgigntcat8M27xvAryhzERC+4szNUu8+pXDKr/VQmLsXk3nDIjKV9giAqNI gDIJz9S0Od2wokUYhORZwZxF06pU5UJdTQSjPp3YWlBaf4QqOb4Twl1NyaGOJOpWl0Ka cqZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=L7EycwgBpS87PBQ7vDdeNTEnqltBzDtaEyWZI/eMgUg=; b=a29qSvpcSc/JoS2HAkutRhjHLLi+4bEH8cR2O4WlTi5nocDams9jLIwOdIsVZo0KZ2 kIVf7nSCeQeJitzBXLUfqLhr0vkcYlOHlQ8vnv+8f0RzfHySuZjUDRFZXOR0HkwZftbJ oz0dv4och+yw3rmVER03CEb2EsjpG3sBH1ccRaRKZkY+SGrMQjh+gnGlBXTC18TuUa7U vGKBVtGS8es/toOPPYPKlXiGRnEUveJbExq4rqTDK9VSocOoGzNDx2meewqdeSlg6Yfy qnbkrRmcJD1XNY+htFu0STzGt3iDPgnX4jK3OnMqmK9GYK/dJu1dGLJ5+yC5o27TC/8h lYFQ== X-Gm-Message-State: AMke39nvH5rgsBU8RAW8q3b7/4R6lVHH4SjTbRIH6QZ7AqWiElWUAB+K/RbTJVTYrfpW4w== X-Received: by 10.36.30.11 with SMTP id 11mr2221124itt.54.1488337212423; Tue, 28 Feb 2017 19:00:12 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id a128sm1625290itg.22.2017.02.28.19.00.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Feb 2017 19:00:11 -0800 (PST) From: npostavs@users.sourceforge.net To: Eric Abrahamsen Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars References: <87a89edtrv.fsf@ericabrahamsen.net> <8760k2dqhw.fsf@ericabrahamsen.net> <87r32pfvdh.fsf@users.sourceforge.net> Date: Tue, 28 Feb 2017 22:01:24 -0500 In-Reply-To: <87r32pfvdh.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Wed, 22 Feb 2017 22:18:02 -0500") Message-ID: <87inntd7jv.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25839 Cc: 25839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 25839 fixed close 25839 26.1 quit > From: Eric Abrahamsen > Date: Wed, 22 Feb 2017 17:26:11 -0800 > Subject: [PATCH] Don't use mapconcat with chars in gnus registry marks Pushed to master [1: 16e304f38e]. 1: 2017-02-28 21:57:07 -0500 16e304f38e57a9a31f1468ba6ebcb8a71efd253d Don't use mapconcat with chars in gnus registry marks (Bug#25839) From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 15:25:32 2017 Received: (at 25839) by debbugs.gnu.org; 14 Mar 2017 19:25:32 +0000 Received: from localhost ([127.0.0.1]:56000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cns4a-0005dM-2Q for submit@debbugs.gnu.org; Tue, 14 Mar 2017 15:25:32 -0400 Received: from mail-pg0-f43.google.com ([74.125.83.43]:35796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cns4Y-0005d8-E8 for 25839@debbugs.gnu.org; Tue, 14 Mar 2017 15:25:30 -0400 Received: by mail-pg0-f43.google.com with SMTP id b129so95029261pgc.2 for <25839@debbugs.gnu.org>; Tue, 14 Mar 2017 12:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=NmibkSFK7FrXj6Q1jyVPM36BITn/ogdd2fBLTvLRJSY=; b=GLHn3RXImlVHYtYxs1rIipDCIqs9ZzGfVpU4RCK861P9Fji0xwkOCt/Jnb5OpVq/RW 7SxL+bWk0a4uFVr+zc+mNezKVnG8xWF/Z+1O1fuZOOXWRFMh3gBvNE9ZaYbe/vBxhpU0 jxGfdPxLfPQmkuqZ/SgqyoPuubgcOZc/vJ9Ak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=NmibkSFK7FrXj6Q1jyVPM36BITn/ogdd2fBLTvLRJSY=; b=l5DO+6CpzXdYzD/A1d/8w3diQD6vC4T1yGrB5aJJuTJ6LW3MRjsIt6tVVPT1+Ib7pD ujmxtkcRj+Exq5Kk3xX8e/IsTW9Lh3OtLmAtohkoo8vJXUJfsGipViknqlOTy+468Q7B CMuINmT/QM/E+GjadJVq1VkAL5qEICqGU7uLxf4owwwixDU1g8DMGJuiHstWlFKMxmDI DhtAPgk7etC8FHbWnKH5XpNLDSNNuF6p+LTaTAyiv037Ujy0L5ET0xcnCBIJnzYWLddf sYLDKrFf6HAku45zKuF85oTx73qzdX7tpSiQvVSPyqZGOfrDrcPKg/+v6EAfL7mJcQoE SQ9w== X-Gm-Message-State: AMke39lr53m5KKpmv8n6sSlXswHUD6mantllEs8pjpPK9QGy+hmqpBOx0Y9FsG8CleeVag== X-Received: by 10.99.138.202 with SMTP id y193mr44998562pgd.60.1489519524906; Tue, 14 Mar 2017 12:25:24 -0700 (PDT) Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id p77sm40005368pfj.99.2017.03.14.12.25.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Mar 2017 12:25:24 -0700 (PDT) From: Ted Zlatanov To: npostavs@users.sourceforge.net Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87a89edtrv.fsf@ericabrahamsen.net> <8760k2dqhw.fsf@ericabrahamsen.net> <87r32pfvdh.fsf@users.sourceforge.net> <87inntd7jv.fsf@users.sourceforge.net> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 14 Mar 2017 15:25:22 -0400 In-Reply-To: <87inntd7jv.fsf@users.sourceforge.net> (npostavs's message of "Tue, 28 Feb 2017 22:01:24 -0500") Message-ID: <87r31zek4d.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 25839 Cc: Eric Abrahamsen , 25839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On Tue, 28 Feb 2017 22:01:24 -0500 npostavs@users.sourceforge.net wrote: n> tags 25839 fixed n> close 25839 26.1 n> quit >> From: Eric Abrahamsen >> Date: Wed, 22 Feb 2017 17:26:11 -0800 >> Subject: [PATCH] Don't use mapconcat with chars in gnus registry marks n> Pushed to master [1: 16e304f38e]. n> 1: 2017-02-28 21:57:07 -0500 16e304f38e57a9a31f1468ba6ebcb8a71efd253d n> Don't use mapconcat with chars in gnus registry marks (Bug#25839) That's so much better :) Thanks! Ted From unknown Thu Aug 14 20:55:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Apr 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator