From unknown Tue Aug 19 02:56:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25828: 25.1; remaining errors from shr calling set-window-buffer-p in dedicated window Resent-From: David Bremner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Feb 2017 11:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25828 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25828@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148767691018176 (code B ref -1); Tue, 21 Feb 2017 11:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2017 11:35:10 +0000 Received: from localhost ([127.0.0.1]:48239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cg8ir-0004j5-LA for submit@debbugs.gnu.org; Tue, 21 Feb 2017 06:35:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cg8io-0004iW-1q for submit@debbugs.gnu.org; Tue, 21 Feb 2017 06:35:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cg8if-0007R2-NO for submit@debbugs.gnu.org; Tue, 21 Feb 2017 06:35:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43320) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cg8if-0007Qy-Ip for submit@debbugs.gnu.org; Tue, 21 Feb 2017 06:34:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cg8ib-0004qO-UK for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2017 06:34:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cg8iY-0007PR-HH for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2017 06:34:53 -0500 Received: from fethera.tethera.net ([198.245.60.197]:56544) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cg8iY-0007O6-AG for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2017 06:34:50 -0500 Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1cg8hp-0000xR-Hv for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2017 06:34:05 -0500 Received: (nullmailer pid 22562 invoked by uid 1000); Tue, 21 Feb 2017 11:34:41 -0000 From: David Bremner Date: Tue, 21 Feb 2017 07:34:39 -0400 Message-ID: <8760k36als.fsf@tethera.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain In https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24950 I reported an error resulting from shr calling set-window-buffer-p in a dedicated window. Eli provided a patch for that, which works great for that code path. Unfortunately there are at least two more places in the shr code with the same issue. A notmuch user reported crashes rendering html on one of those other code paths. I have not produced a recipe for duplicating the problem without notmuch, but copying Eli's patch into these other two code paths fixes the problem. I have attached the diff against emacs-25.2-rc1-14-gec4226d810. Both added calls to set-window-dedicated-p are inside save-window-excursion. It occurs to me that maybe save-window-excursion should call set-window-dedicated-p, but I don't know the full implications. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=shr-diff.diff Content-Transfer-Encoding: quoted-printable diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 6c35a33c9c..2bc37c64bd 100644 =2D-- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1993,6 +1993,9 @@ shr-pixel-buffer-width (if (get-buffer-window) (car (window-text-pixel-size nil (point-min) (point-max))) (save-window-excursion + ;; Avoid errors if the selected window is a dedicated one, + ;; and they just want to insert a document into it. + (set-window-dedicated-p nil nil) (set-window-buffer nil (current-buffer)) (car (window-text-pixel-size nil (point-min) (point-max))))))) =20 @@ -2036,6 +2039,9 @@ shr-render-td-1 (shr-indentation 0)) (shr-descend dom)) (save-window-excursion + ;; Avoid errors if the selected window is a dedicated one, + ;; and they just want to insert a document into it. + (set-window-dedicated-p nil nil) (set-window-buffer nil (current-buffer)) (unless fill (setq natural-width --=-=-= Content-Type: text/plain Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs25-Fs4LPA/emacs25-25.1+1=. -fstack-protector-strong -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_CA.UTF-8 locale-coding-system: utf-8-unix Major mode: notmuch-show Minor modes in effect: TeX-PDF-mode: t magit-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t diff-auto-refine-mode: t tracking-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t visual-line-mode: t transient-mark-mode: t Recent messages: next-line: End of buffer [8 times] Mark set [3 times] Sending... Mark set [2 times] Sending via mail... Mark set Doing Fcc... Sending...done c 0 is undefined Stashed: id:87y40kw3f2.fsf@tethera.net Load-path shadows: /usr/share/emacs/25.1/site-lisp/elpa/jabber-0.8.92/fsm hides /usr/share/emacs/25.1/site-lisp/elpa/fsm-0.2.1/fsm /usr/share/emacs/25.1/site-lisp/elpa/magit-2.9.0/magit-popup hides /usr/share/emacs/25.1/site-lisp/elpa/magit-popup-2.9.0/magit-popup /usr/share/org-mode/lisp/htmlize hides /usr/share/emacs25/site-lisp/emacs-goodies-el/htmlize /home/bremner/.emacs.d/elpa/csv-mode-1.5/csv-mode hides /usr/share/emacs25/site-lisp/emacs-goodies-el/csv-mode /usr/share/emacs25/site-lisp/emacs-goodies-el/all hides /usr/share/emacs/25.1/site-lisp/elpa/company-0.8.12/all /usr/share/emacs25/site-lisp/cmake-data/cmake-mode hides /usr/share/emacs/site-lisp/cmake-mode /usr/share/emacs/25.1/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup /usr/share/emacs25/site-lisp/flim/hex-util hides /usr/share/emacs/25.1/lisp/hex-util /usr/share/emacs25/site-lisp/flim/md4 hides /usr/share/emacs/25.1/lisp/md4 /usr/share/emacs/site-lisp/rst hides /usr/share/emacs/25.1/lisp/textmodes/rst /usr/share/emacs25/site-lisp/org-mode/ob-table hides /usr/share/emacs/25.1/lisp/org/ob-table /usr/share/emacs25/site-lisp/org-mode/ob-mscgen hides /usr/share/emacs/25.1/lisp/org/ob-mscgen /usr/share/emacs25/site-lisp/org-mode/org-rmail hides /usr/share/emacs/25.1/lisp/org/org-rmail /usr/share/emacs25/site-lisp/org-mode/org-pcomplete hides /usr/share/emacs/25.1/lisp/org/org-pcomplete /usr/share/emacs25/site-lisp/org-mode/org-clock hides /usr/share/emacs/25.1/lisp/org/org-clock /usr/share/emacs25/site-lisp/org-mode/ox-beamer hides /usr/share/emacs/25.1/lisp/org/ox-beamer /usr/share/emacs25/site-lisp/org-mode/ob-sass hides /usr/share/emacs/25.1/lisp/org/ob-sass /usr/share/emacs25/site-lisp/org-mode/ob-fortran hides /usr/share/emacs/25.1/lisp/org/ob-fortran /usr/share/emacs25/site-lisp/org-mode/org-macs hides /usr/share/emacs/25.1/lisp/org/org-macs /usr/share/emacs25/site-lisp/org-mode/org-entities hides /usr/share/emacs/25.1/lisp/org/org-entities /usr/share/emacs25/site-lisp/org-mode/org-capture hides /usr/share/emacs/25.1/lisp/org/org-capture /usr/share/emacs25/site-lisp/org-mode/ob-lilypond hides /usr/share/emacs/25.1/lisp/org/ob-lilypond /usr/share/emacs25/site-lisp/org-mode/org-info hides /usr/share/emacs/25.1/lisp/org/org-info /usr/share/emacs25/site-lisp/org-mode/org-bbdb hides /usr/share/emacs/25.1/lisp/org/org-bbdb /usr/share/emacs25/site-lisp/org-mode/ob-js hides /usr/share/emacs/25.1/lisp/org/ob-js /usr/share/emacs25/site-lisp/org-mode/ob-dot hides /usr/share/emacs/25.1/lisp/org/ob-dot /usr/share/emacs25/site-lisp/org-mode/ob-ledger hides /usr/share/emacs/25.1/lisp/org/ob-ledger /usr/share/emacs25/site-lisp/org-mode/ox-md hides /usr/share/emacs/25.1/lisp/org/ox-md /usr/share/emacs25/site-lisp/org-mode/org-docview hides /usr/share/emacs/25.1/lisp/org/org-docview /usr/share/emacs25/site-lisp/org-mode/ob-plantuml hides /usr/share/emacs/25.1/lisp/org/ob-plantuml /usr/share/emacs25/site-lisp/org-mode/ob-awk hides /usr/share/emacs/25.1/lisp/org/ob-awk /usr/share/emacs25/site-lisp/org-mode/ob-clojure hides /usr/share/emacs/25.1/lisp/org/ob-clojure /usr/share/emacs25/site-lisp/org-mode/ob-screen hides /usr/share/emacs/25.1/lisp/org/ob-screen /usr/share/emacs25/site-lisp/org-mode/ob-eval hides /usr/share/emacs/25.1/lisp/org/ob-eval /usr/share/emacs25/site-lisp/org-mode/org-ctags hides /usr/share/emacs/25.1/lisp/org/org-ctags /usr/share/emacs25/site-lisp/org-mode/org-attach hides /usr/share/emacs/25.1/lisp/org/org-attach /usr/share/emacs25/site-lisp/org-mode/org-plot hides /usr/share/emacs/25.1/lisp/org/org-plot /usr/share/emacs25/site-lisp/org-mode/org-id hides /usr/share/emacs/25.1/lisp/org/org-id /usr/share/emacs25/site-lisp/org-mode/ob-gnuplot hides /usr/share/emacs/25.1/lisp/org/ob-gnuplot /usr/share/emacs25/site-lisp/org-mode/ob-emacs-lisp hides /usr/share/emacs/25.1/lisp/org/ob-emacs-lisp /usr/share/emacs25/site-lisp/org-mode/ob-makefile hides /usr/share/emacs/25.1/lisp/org/ob-makefile /usr/share/emacs25/site-lisp/org-mode/ob-maxima hides /usr/share/emacs/25.1/lisp/org/ob-maxima /usr/share/emacs25/site-lisp/org-mode/org-timer hides /usr/share/emacs/25.1/lisp/org/org-timer /usr/share/emacs25/site-lisp/org-mode/ox-odt hides /usr/share/emacs/25.1/lisp/org/ox-odt /usr/share/emacs25/site-lisp/org-mode/org-mouse hides /usr/share/emacs/25.1/lisp/org/org-mouse /usr/share/emacs25/site-lisp/org-mode/org-agenda hides /usr/share/emacs/25.1/lisp/org/org-agenda /usr/share/emacs25/site-lisp/org-mode/org-install hides /usr/share/emacs/25.1/lisp/org/org-install /usr/share/emacs25/site-lisp/org-mode/org-bibtex hides /usr/share/emacs/25.1/lisp/org/org-bibtex /usr/share/emacs25/site-lisp/org-mode/ob-scala hides /usr/share/emacs/25.1/lisp/org/ob-scala /usr/share/emacs25/site-lisp/org-mode/ob-haskell hides /usr/share/emacs/25.1/lisp/org/ob-haskell /usr/share/emacs25/site-lisp/org-mode/org-table hides /usr/share/emacs/25.1/lisp/org/org-table /usr/share/emacs25/site-lisp/org-mode/ob-ditaa hides /usr/share/emacs/25.1/lisp/org/ob-ditaa /usr/share/emacs25/site-lisp/org-mode/org-gnus hides /usr/share/emacs/25.1/lisp/org/org-gnus /usr/share/emacs25/site-lisp/org-mode/org-eshell hides /usr/share/emacs/25.1/lisp/org/org-eshell /usr/share/emacs25/site-lisp/org-mode/ob-picolisp hides /usr/share/emacs/25.1/lisp/org/ob-picolisp /usr/share/emacs25/site-lisp/org-mode/org-mhe hides /usr/share/emacs/25.1/lisp/org/org-mhe /usr/share/emacs25/site-lisp/org-mode/ox-texinfo hides /usr/share/emacs/25.1/lisp/org/ox-texinfo /usr/share/emacs25/site-lisp/org-mode/ob-keys hides /usr/share/emacs/25.1/lisp/org/ob-keys /usr/share/emacs25/site-lisp/org-mode/ob-octave hides /usr/share/emacs/25.1/lisp/org/ob-octave /usr/share/emacs25/site-lisp/org-mode/org-protocol hides /usr/share/emacs/25.1/lisp/org/org-protocol /usr/share/emacs25/site-lisp/org-mode/org-datetree hides /usr/share/emacs/25.1/lisp/org/org-datetree /usr/share/emacs25/site-lisp/org-mode/ob-core hides /usr/share/emacs/25.1/lisp/org/ob-core /usr/share/emacs25/site-lisp/org-mode/ob-lob hides /usr/share/emacs/25.1/lisp/org/ob-lob /usr/share/emacs25/site-lisp/org-mode/ob-latex hides /usr/share/emacs/25.1/lisp/org/ob-latex /usr/share/emacs25/site-lisp/org-mode/org-footnote hides /usr/share/emacs/25.1/lisp/org/org-footnote /usr/share/emacs25/site-lisp/org-mode/org-w3m hides /usr/share/emacs/25.1/lisp/org/org-w3m /usr/share/emacs25/site-lisp/org-mode/org-archive hides /usr/share/emacs/25.1/lisp/org/org-archive /usr/share/emacs25/site-lisp/org-mode/org-faces hides /usr/share/emacs/25.1/lisp/org/org-faces /usr/share/emacs25/site-lisp/org-mode/org-list hides /usr/share/emacs/25.1/lisp/org/org-list /usr/share/emacs25/site-lisp/org-mode/ob-comint hides /usr/share/emacs/25.1/lisp/org/ob-comint /usr/share/emacs25/site-lisp/org-mode/org-indent hides /usr/share/emacs/25.1/lisp/org/org-indent /usr/share/emacs25/site-lisp/org-mode/ob-org hides /usr/share/emacs/25.1/lisp/org/ob-org /usr/share/emacs25/site-lisp/org-mode/org-inlinetask hides /usr/share/emacs/25.1/lisp/org/org-inlinetask /usr/share/emacs25/site-lisp/org-mode/org-compat hides /usr/share/emacs/25.1/lisp/org/org-compat /usr/share/emacs25/site-lisp/org-mode/ob-io hides /usr/share/emacs/25.1/lisp/org/ob-io /usr/share/emacs25/site-lisp/org-mode/org-mobile hides /usr/share/emacs/25.1/lisp/org/org-mobile /usr/share/emacs25/site-lisp/org-mode/ob-scheme hides /usr/share/emacs/25.1/lisp/org/ob-scheme /usr/share/emacs25/site-lisp/org-mode/ob-python hides /usr/share/emacs/25.1/lisp/org/ob-python /usr/share/emacs25/site-lisp/org-mode/ox-html hides /usr/share/emacs/25.1/lisp/org/ox-html /usr/share/emacs25/site-lisp/org-mode/ob-java hides /usr/share/emacs/25.1/lisp/org/ob-java /usr/share/emacs25/site-lisp/org-mode/org-colview hides /usr/share/emacs/25.1/lisp/org/org-colview /usr/share/emacs25/site-lisp/org-mode/ob-ruby hides /usr/share/emacs/25.1/lisp/org/ob-ruby /usr/share/emacs25/site-lisp/org-mode/ox-latex hides /usr/share/emacs/25.1/lisp/org/ox-latex /usr/share/emacs25/site-lisp/org-mode/ox hides /usr/share/emacs/25.1/lisp/org/ox /usr/share/emacs25/site-lisp/org-mode/ob-ref hides /usr/share/emacs/25.1/lisp/org/ob-ref /usr/share/emacs25/site-lisp/org-mode/org-macro hides /usr/share/emacs/25.1/lisp/org/org-macro /usr/share/emacs25/site-lisp/org-mode/org hides /usr/share/emacs/25.1/lisp/org/org /usr/share/emacs25/site-lisp/org-mode/ob-css hides /usr/share/emacs/25.1/lisp/org/ob-css /usr/share/emacs25/site-lisp/org-mode/ob-shen hides /usr/share/emacs/25.1/lisp/org/ob-shen /usr/share/emacs25/site-lisp/org-mode/org-irc hides /usr/share/emacs/25.1/lisp/org/org-irc /usr/share/emacs25/site-lisp/org-mode/ob-sql hides /usr/share/emacs/25.1/lisp/org/ob-sql /usr/share/emacs25/site-lisp/org-mode/org-element hides /usr/share/emacs/25.1/lisp/org/org-element /usr/share/emacs25/site-lisp/org-mode/ob hides /usr/share/emacs/25.1/lisp/org/ob /usr/share/emacs25/site-lisp/org-mode/ob-sqlite hides /usr/share/emacs/25.1/lisp/org/ob-sqlite /usr/share/emacs25/site-lisp/org-mode/ox-publish hides /usr/share/emacs/25.1/lisp/org/ox-publish /usr/share/emacs25/site-lisp/org-mode/ob-tangle hides /usr/share/emacs/25.1/lisp/org/ob-tangle /usr/share/emacs25/site-lisp/org-mode/ob-lisp hides /usr/share/emacs/25.1/lisp/org/ob-lisp /usr/share/emacs25/site-lisp/org-mode/ob-exp hides /usr/share/emacs/25.1/lisp/org/ob-exp /usr/share/emacs25/site-lisp/org-mode/org-crypt hides /usr/share/emacs/25.1/lisp/org/org-crypt /usr/share/emacs25/site-lisp/org-mode/ob-perl hides /usr/share/emacs/25.1/lisp/org/ob-perl /usr/share/emacs25/site-lisp/org-mode/org-src hides /usr/share/emacs/25.1/lisp/org/org-src /usr/share/emacs25/site-lisp/org-mode/ox-icalendar hides /usr/share/emacs/25.1/lisp/org/ox-icalendar /usr/share/emacs25/site-lisp/org-mode/org-loaddefs hides /usr/share/emacs/25.1/lisp/org/org-loaddefs /usr/share/emacs25/site-lisp/org-mode/ob-ocaml hides /usr/share/emacs/25.1/lisp/org/ob-ocaml /usr/share/emacs25/site-lisp/org-mode/ox-ascii hides /usr/share/emacs/25.1/lisp/org/ox-ascii /usr/share/emacs25/site-lisp/org-mode/ob-R hides /usr/share/emacs/25.1/lisp/org/ob-R /usr/share/emacs25/site-lisp/org-mode/ob-C hides /usr/share/emacs/25.1/lisp/org/ob-C /usr/share/emacs25/site-lisp/org-mode/org-version hides /usr/share/emacs/25.1/lisp/org/org-version /usr/share/emacs25/site-lisp/org-mode/ob-asymptote hides /usr/share/emacs/25.1/lisp/org/ob-asymptote /usr/share/emacs25/site-lisp/org-mode/org-habit hides /usr/share/emacs/25.1/lisp/org/org-habit /usr/share/emacs25/site-lisp/org-mode/ob-matlab hides /usr/share/emacs/25.1/lisp/org/ob-matlab /usr/share/emacs25/site-lisp/org-mode/ox-org hides /usr/share/emacs/25.1/lisp/org/ox-org /usr/share/emacs25/site-lisp/org-mode/ox-man hides /usr/share/emacs/25.1/lisp/org/ox-man /usr/share/emacs25/site-lisp/org-mode/ob-calc hides /usr/share/emacs/25.1/lisp/org/ob-calc /usr/share/emacs25/site-lisp/org-mode/org-feed hides /usr/share/emacs/25.1/lisp/org/org-feed /usr/share/emacs25/site-lisp/flim/sasl-cram hides /usr/share/emacs/25.1/lisp/net/sasl-cram /usr/share/emacs25/site-lisp/flim/sasl hides /usr/share/emacs/25.1/lisp/net/sasl /usr/share/emacs25/site-lisp/flim/sasl-digest hides /usr/share/emacs/25.1/lisp/net/sasl-digest /usr/share/emacs25/site-lisp/flim/sasl-ntlm hides /usr/share/emacs/25.1/lisp/net/sasl-ntlm /usr/share/emacs25/site-lisp/flim/hmac-def hides /usr/share/emacs/25.1/lisp/net/hmac-def /usr/share/emacs25/site-lisp/flim/hmac-md5 hides /usr/share/emacs/25.1/lisp/net/hmac-md5 /usr/share/emacs25/site-lisp/flim/ntlm hides /usr/share/emacs/25.1/lisp/net/ntlm /usr/share/emacs/25.1/site-lisp/elpa/let-alist-1.0.4/let-alist hides /usr/share/emacs/25.1/lisp/emacs-lisp/let-alist /usr/share/emacs/25.1/site-lisp/elpa/seq-2.19/seq hides /usr/share/emacs/25.1/lisp/emacs-lisp/seq /usr/share/emacs25/site-lisp/auctex/prv-emacs hides /usr/share/emacs/site-lisp/auctex/prv-emacs /usr/share/emacs25/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl /usr/share/emacs25/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style /usr/share/emacs25/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex /usr/share/emacs25/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik /usr/share/emacs25/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar /usr/share/emacs25/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex /usr/share/emacs25/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en /usr/share/emacs25/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp /usr/share/emacs25/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font /usr/share/emacs25/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf /usr/share/emacs25/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite /usr/share/emacs25/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info /usr/share/emacs25/site-lisp/auctex/plain-tex hides /usr/share/emacs/site-lisp/auctex/plain-tex /usr/share/emacs25/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp /usr/share/emacs25/site-lisp/auctex/preview hides /usr/share/emacs/site-lisp/auctex/preview /usr/share/emacs25/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context /usr/share/emacs25/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold /usr/share/emacs25/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt /usr/share/emacs25/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x /usr/share/emacs25/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex Features: (shadow emacsbug browse-kill-ring pcmpl-unix pcmpl-gnu debian-bug debian-changelog-mode calccomp calc-arith calc-misc calc-map calc-stat calc-vec calc-aent dired-aux texmathp preview prv-emacs tex-buf font-latex latex tex-style tex dbus xml tex-mode latexenc bookmark pp org-capture gnus-art mm-uu mml2015 gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader inline url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf rst derived disp-table org-colview calc-undo calc-alg calc-ext calc-menu calc calc-loaddefs calc-macs org-table filecache network-stream nsm starttls racket-mode racket-bug-report racket-collection tq racket-profile racket-imenu imenu racket-edit hideshow racket-complete racket-repl ido racket-common racket-indent racket-font-lock racket-util racket-keywords-and-builtins racket-custom parse-time qp tabify ledger-mode ledger-check ledger-schedule ledger-xact ledger-texi ledger-test ledger-sort ledger-report ledger-reconcile ledger-post ledger-occur ledger-init ledger-fontify ledger-state ledger-navigate ledger-fonts ledger-exec ledger-context ledger-complete ledger-commodities esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-groups eshell esh-module esh-mode esh-arg esh-util cus-edit cus-start cus-load ledger-regex debug eieio-opt speedbar sb-image ezimage dframe cal-move markdown-mode make-mode message-templ sh-script smie executable grep magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert autorevert filenotify magit-process magit-margin magit-mode magit-git magit-section magit-utils magit-popup git-commit log-edit pcvs-util add-log with-editor async-bytecomp async tramp-sh whitespace compile misearch multi-isearch cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs org-clock view cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays hol-loaddefs cal-iso vc-git org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view jka-compr image-mode org-bibtex bibtex org-bbdb org-w3m org-agenda mm-archive url-util url-parse url-vars shr-color shr dom subr-x browse-url sendmail sort company-files company-oddmuse company-keywords company-etags etags xref project company-gtags company-dabbrev-code company-dabbrev company-capf company-cmake company-ropemacs company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-bbdb company mail-extr edmacro kmacro notmuch-jump notmuch hl-line notmuch-message notmuch-hello wid-edit notmuch-tree notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj notmuch-query goto-addr icalendar diary-lib diary-loaddefs notmuch-tag crm notmuch-lib notmuch-version notmuch-compat cl message dired rfc822 mml mailabbrev mail-utils gmm-utils mailheader mm-view mml-smime mml-sec epg smime dig mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 ietf-drums cursor-sensor minibuffer-complete-cycle server indirect-region tempo org-notmuch org-element avl-tree org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint tramp tramp-compat auth-source cl-seq eieio eieio-core cl-macs gnus-util time-date mm-util help-fns mail-prsvr password-cache tramp-loaddefs trampver shell pcomplete comint ansi-color ob-core ob-eval org-compat org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs rx vc vc-dispatcher circe-color-nicks color circe-chanop circe advice diff-mode lui-irc-colors irc make-tls-process tls gnutls lcs lui-format lui tracking shorten thingatpt paren flyspell ispell ring circe-compat finder-inf muse-autoloads package epg-config seq seq-25 byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib debian-el debian-el-loaddefs s ucs-normalize org-install haskell-mode-autoloads emacs-goodies-el emacs-goodies-custom emacs-goodies-loaddefs easy-mmode dpkg-dev-el dpkg-dev-el-loaddefs dash-functional dash preview-latex tex-site auto-loads mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 3519340 235888) (symbols 48 64348 2) (miscs 40 46989 3711) (strings 32 313297 125973) (string-bytes 1 12186097) (vectors 16 118270) (vector-slots 8 2459973 123628) (floats 8 5420 3349) (intervals 56 309816 4143) (buffers 976 335)) --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAlisJc8ACgkQ8gKXHaSn niz6Zgv+PAet9oSFlagNefA+2cQZD1LfpDq8ex32/jQgIopXDaUmQMcA4jGNK37y VMovkxwUnuK99eqx+rT5Z+nowlE1AXztK6sgFF/zGjGz8iHR0MfEycpV83ZwrRVD KAF7fW/fiYejTjWmO1MJFmFF4V8r8p+T33wJ8vbwyrL5jdJDHYQtmiMmCkKlCdRj hWFo+kQMj5wDYXypEC8VrW18afMPVCDAJdf8mXpDNkf7hrfCkbOr8pC7ZPzZhqgR oe5zGCuGnss+BX+oFPOSohrIKAGlFqWE5qfqzqLALThouYLi+7m6lLb4h196Ndu3 7fV6HA0OXOGAzjbNe3cxiVCBw9zyE05ZOmn/Ydp8lkq7o1EvZxlAl8gi2ipn4l3U CnD2wRN/OWGSu30bMsMsl/a/8IsxYMhAIH4h7zlzJSpcHZYqZ0ckJBoOmcIcR+oq D6xbbqLR5KdN+diaWrmSvNQA+Ba3+cebmfNRds4DrVWjxK1AS7UciOk5uYSi/t1e OB/rUc/9 =Apw9 -----END PGP SIGNATURE----- --==-=-=-- From unknown Tue Aug 19 02:56:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25828: 25.1; remaining errors from shr calling set-window-buffer-p in dedicated window Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Feb 2017 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25828 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: David Bremner , Lars Ingebrigtsen Cc: 25828@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 25828-submit@debbugs.gnu.org id=B25828.148801125916961 (code B ref 25828); Sat, 25 Feb 2017 08:28:02 +0000 Received: (at 25828) by debbugs.gnu.org; 25 Feb 2017 08:27:39 +0000 Received: from localhost ([127.0.0.1]:55137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chXha-0004PV-Ml for submit@debbugs.gnu.org; Sat, 25 Feb 2017 03:27:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chXhZ-0004PI-36 for 25828@debbugs.gnu.org; Sat, 25 Feb 2017 03:27:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chXhP-0002e9-2Z for 25828@debbugs.gnu.org; Sat, 25 Feb 2017 03:27:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chXhO-0002e3-TP; Sat, 25 Feb 2017 03:27:26 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2884 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1chXhO-0004x6-1X; Sat, 25 Feb 2017 03:27:26 -0500 Date: Sat, 25 Feb 2017 10:27:02 +0200 Message-Id: <83d1e6smjt.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <8760k36als.fsf@tethera.net> (message from David Bremner on Tue, 21 Feb 2017 07:34:39 -0400) References: <8760k36als.fsf@tethera.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: David Bremner > Date: Tue, 21 Feb 2017 07:34:39 -0400 > > In https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24950 I reported an > error resulting from shr calling set-window-buffer-p in a dedicated > window. Eli provided a patch for that, which works great for that code > path. Unfortunately there are at least two more places in the shr code > with the same issue. A notmuch user reported crashes rendering html on > one of those other code paths. I have not produced a recipe for > duplicating the problem without notmuch, but copying Eli's patch into > these other two code paths fixes the problem. I have attached the diff > against emacs-25.2-rc1-14-gec4226d810. Both added calls to > set-window-dedicated-p are inside save-window-excursion. It occurs to > me that maybe save-window-excursion should call set-window-dedicated-p, > but I don't know the full implications. > > diff --git a/lisp/net/shr.el b/lisp/net/shr.el > index 6c35a33c9c..2bc37c64bd 100644 > --- a/lisp/net/shr.el > +++ b/lisp/net/shr.el > @@ -1993,6 +1993,9 @@ shr-pixel-buffer-width > (if (get-buffer-window) > (car (window-text-pixel-size nil (point-min) (point-max))) > (save-window-excursion > + ;; Avoid errors if the selected window is a dedicated one, > + ;; and they just want to insert a document into it. > + (set-window-dedicated-p nil nil) > (set-window-buffer nil (current-buffer)) > (car (window-text-pixel-size nil (point-min) (point-max))))))) > > @@ -2036,6 +2039,9 @@ shr-render-td-1 > (shr-indentation 0)) > (shr-descend dom)) > (save-window-excursion > + ;; Avoid errors if the selected window is a dedicated one, > + ;; and they just want to insert a document into it. > + (set-window-dedicated-p nil nil) > (set-window-buffer nil (current-buffer)) > (unless fill > (setq natural-width Lars, any objections to pushing this? From unknown Tue Aug 19 02:56:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: David Bremner Subject: bug#25828: closed (Re: bug#25828: 25.1; remaining errors from shr calling set-window-buffer-p in dedicated window) Message-ID: References: <83a891l4ut.fsf@gnu.org> <8760k36als.fsf@tethera.net> X-Gnu-PR-Message: they-closed 25828 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 25828@debbugs.gnu.org Date: Sat, 04 Mar 2017 10:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1488622922-5365-1" This is a multi-part message in MIME format... ------------=_1488622922-5365-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #25828: 25.1; remaining errors from shr calling set-window-buffer-p in dedi= cated window which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 25828@debbugs.gnu.org. --=20 25828: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25828 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1488622922-5365-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 25828-done) by debbugs.gnu.org; 4 Mar 2017 10:21:53 +0000 Received: from localhost ([127.0.0.1]:39145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck6oz-0001OC-6A for submit@debbugs.gnu.org; Sat, 04 Mar 2017 05:21:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ck6oy-0001O1-Dp for 25828-done@debbugs.gnu.org; Sat, 04 Mar 2017 05:21:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ck6oq-0005g4-4h for 25828-done@debbugs.gnu.org; Sat, 04 Mar 2017 05:21:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ck6oq-0005fv-16; Sat, 04 Mar 2017 05:21:44 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3661 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ck6op-00048A-8t; Sat, 04 Mar 2017 05:21:43 -0500 Date: Sat, 04 Mar 2017 12:21:30 +0200 Message-Id: <83a891l4ut.fsf@gnu.org> From: Eli Zaretskii To: larsi@gnus.org In-reply-to: <83d1e6smjt.fsf@gnu.org> (message from Eli Zaretskii on Sat, 25 Feb 2017 10:27:02 +0200) Subject: Re: bug#25828: 25.1; remaining errors from shr calling set-window-buffer-p in dedicated window References: <8760k36als.fsf@tethera.net> <83d1e6smjt.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25828-done Cc: david@tethera.net, 25828-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sat, 25 Feb 2017 10:27:02 +0200 > From: Eli Zaretskii > Cc: 25828@debbugs.gnu.org > > Lars, any objections to pushing this? No further comments, so I pushed these changes to the master branch, and I'm marking this bug done. ------------=_1488622922-5365-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Feb 2017 11:35:10 +0000 Received: from localhost ([127.0.0.1]:48239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cg8ir-0004j5-LA for submit@debbugs.gnu.org; Tue, 21 Feb 2017 06:35:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cg8io-0004iW-1q for submit@debbugs.gnu.org; Tue, 21 Feb 2017 06:35:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cg8if-0007R2-NO for submit@debbugs.gnu.org; Tue, 21 Feb 2017 06:35:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43320) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cg8if-0007Qy-Ip for submit@debbugs.gnu.org; Tue, 21 Feb 2017 06:34:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cg8ib-0004qO-UK for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2017 06:34:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cg8iY-0007PR-HH for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2017 06:34:53 -0500 Received: from fethera.tethera.net ([198.245.60.197]:56544) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cg8iY-0007O6-AG for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2017 06:34:50 -0500 Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1cg8hp-0000xR-Hv for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2017 06:34:05 -0500 Received: (nullmailer pid 22562 invoked by uid 1000); Tue, 21 Feb 2017 11:34:41 -0000 From: David Bremner To: bug-gnu-emacs@gnu.org Subject: 25.1; remaining errors from shr calling set-window-buffer-p in dedicated window Date: Tue, 21 Feb 2017 07:34:39 -0400 Message-ID: <8760k36als.fsf@tethera.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain In https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24950 I reported an error resulting from shr calling set-window-buffer-p in a dedicated window. Eli provided a patch for that, which works great for that code path. Unfortunately there are at least two more places in the shr code with the same issue. A notmuch user reported crashes rendering html on one of those other code paths. I have not produced a recipe for duplicating the problem without notmuch, but copying Eli's patch into these other two code paths fixes the problem. I have attached the diff against emacs-25.2-rc1-14-gec4226d810. Both added calls to set-window-dedicated-p are inside save-window-excursion. It occurs to me that maybe save-window-excursion should call set-window-dedicated-p, but I don't know the full implications. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=shr-diff.diff Content-Transfer-Encoding: quoted-printable diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 6c35a33c9c..2bc37c64bd 100644 =2D-- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1993,6 +1993,9 @@ shr-pixel-buffer-width (if (get-buffer-window) (car (window-text-pixel-size nil (point-min) (point-max))) (save-window-excursion + ;; Avoid errors if the selected window is a dedicated one, + ;; and they just want to insert a document into it. + (set-window-dedicated-p nil nil) (set-window-buffer nil (current-buffer)) (car (window-text-pixel-size nil (point-min) (point-max))))))) =20 @@ -2036,6 +2039,9 @@ shr-render-td-1 (shr-indentation 0)) (shr-descend dom)) (save-window-excursion + ;; Avoid errors if the selected window is a dedicated one, + ;; and they just want to insert a document into it. + (set-window-dedicated-p nil nil) (set-window-buffer nil (current-buffer)) (unless fill (setq natural-width --=-=-= Content-Type: text/plain Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs25-Fs4LPA/emacs25-25.1+1=. -fstack-protector-strong -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_CA.UTF-8 locale-coding-system: utf-8-unix Major mode: notmuch-show Minor modes in effect: TeX-PDF-mode: t magit-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t diff-auto-refine-mode: t tracking-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t visual-line-mode: t transient-mark-mode: t Recent messages: next-line: End of buffer [8 times] Mark set [3 times] Sending... Mark set [2 times] Sending via mail... Mark set Doing Fcc... Sending...done c 0 is undefined Stashed: id:87y40kw3f2.fsf@tethera.net Load-path shadows: /usr/share/emacs/25.1/site-lisp/elpa/jabber-0.8.92/fsm hides /usr/share/emacs/25.1/site-lisp/elpa/fsm-0.2.1/fsm /usr/share/emacs/25.1/site-lisp/elpa/magit-2.9.0/magit-popup hides /usr/share/emacs/25.1/site-lisp/elpa/magit-popup-2.9.0/magit-popup /usr/share/org-mode/lisp/htmlize hides /usr/share/emacs25/site-lisp/emacs-goodies-el/htmlize /home/bremner/.emacs.d/elpa/csv-mode-1.5/csv-mode hides /usr/share/emacs25/site-lisp/emacs-goodies-el/csv-mode /usr/share/emacs25/site-lisp/emacs-goodies-el/all hides /usr/share/emacs/25.1/site-lisp/elpa/company-0.8.12/all /usr/share/emacs25/site-lisp/cmake-data/cmake-mode hides /usr/share/emacs/site-lisp/cmake-mode /usr/share/emacs/25.1/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup /usr/share/emacs25/site-lisp/flim/hex-util hides /usr/share/emacs/25.1/lisp/hex-util /usr/share/emacs25/site-lisp/flim/md4 hides /usr/share/emacs/25.1/lisp/md4 /usr/share/emacs/site-lisp/rst hides /usr/share/emacs/25.1/lisp/textmodes/rst /usr/share/emacs25/site-lisp/org-mode/ob-table hides /usr/share/emacs/25.1/lisp/org/ob-table /usr/share/emacs25/site-lisp/org-mode/ob-mscgen hides /usr/share/emacs/25.1/lisp/org/ob-mscgen /usr/share/emacs25/site-lisp/org-mode/org-rmail hides /usr/share/emacs/25.1/lisp/org/org-rmail /usr/share/emacs25/site-lisp/org-mode/org-pcomplete hides /usr/share/emacs/25.1/lisp/org/org-pcomplete /usr/share/emacs25/site-lisp/org-mode/org-clock hides /usr/share/emacs/25.1/lisp/org/org-clock /usr/share/emacs25/site-lisp/org-mode/ox-beamer hides /usr/share/emacs/25.1/lisp/org/ox-beamer /usr/share/emacs25/site-lisp/org-mode/ob-sass hides /usr/share/emacs/25.1/lisp/org/ob-sass /usr/share/emacs25/site-lisp/org-mode/ob-fortran hides /usr/share/emacs/25.1/lisp/org/ob-fortran /usr/share/emacs25/site-lisp/org-mode/org-macs hides /usr/share/emacs/25.1/lisp/org/org-macs /usr/share/emacs25/site-lisp/org-mode/org-entities hides /usr/share/emacs/25.1/lisp/org/org-entities /usr/share/emacs25/site-lisp/org-mode/org-capture hides /usr/share/emacs/25.1/lisp/org/org-capture /usr/share/emacs25/site-lisp/org-mode/ob-lilypond hides /usr/share/emacs/25.1/lisp/org/ob-lilypond /usr/share/emacs25/site-lisp/org-mode/org-info hides /usr/share/emacs/25.1/lisp/org/org-info /usr/share/emacs25/site-lisp/org-mode/org-bbdb hides /usr/share/emacs/25.1/lisp/org/org-bbdb /usr/share/emacs25/site-lisp/org-mode/ob-js hides /usr/share/emacs/25.1/lisp/org/ob-js /usr/share/emacs25/site-lisp/org-mode/ob-dot hides /usr/share/emacs/25.1/lisp/org/ob-dot /usr/share/emacs25/site-lisp/org-mode/ob-ledger hides /usr/share/emacs/25.1/lisp/org/ob-ledger /usr/share/emacs25/site-lisp/org-mode/ox-md hides /usr/share/emacs/25.1/lisp/org/ox-md /usr/share/emacs25/site-lisp/org-mode/org-docview hides /usr/share/emacs/25.1/lisp/org/org-docview /usr/share/emacs25/site-lisp/org-mode/ob-plantuml hides /usr/share/emacs/25.1/lisp/org/ob-plantuml /usr/share/emacs25/site-lisp/org-mode/ob-awk hides /usr/share/emacs/25.1/lisp/org/ob-awk /usr/share/emacs25/site-lisp/org-mode/ob-clojure hides /usr/share/emacs/25.1/lisp/org/ob-clojure /usr/share/emacs25/site-lisp/org-mode/ob-screen hides /usr/share/emacs/25.1/lisp/org/ob-screen /usr/share/emacs25/site-lisp/org-mode/ob-eval hides /usr/share/emacs/25.1/lisp/org/ob-eval /usr/share/emacs25/site-lisp/org-mode/org-ctags hides /usr/share/emacs/25.1/lisp/org/org-ctags /usr/share/emacs25/site-lisp/org-mode/org-attach hides /usr/share/emacs/25.1/lisp/org/org-attach /usr/share/emacs25/site-lisp/org-mode/org-plot hides /usr/share/emacs/25.1/lisp/org/org-plot /usr/share/emacs25/site-lisp/org-mode/org-id hides /usr/share/emacs/25.1/lisp/org/org-id /usr/share/emacs25/site-lisp/org-mode/ob-gnuplot hides /usr/share/emacs/25.1/lisp/org/ob-gnuplot /usr/share/emacs25/site-lisp/org-mode/ob-emacs-lisp hides /usr/share/emacs/25.1/lisp/org/ob-emacs-lisp /usr/share/emacs25/site-lisp/org-mode/ob-makefile hides /usr/share/emacs/25.1/lisp/org/ob-makefile /usr/share/emacs25/site-lisp/org-mode/ob-maxima hides /usr/share/emacs/25.1/lisp/org/ob-maxima /usr/share/emacs25/site-lisp/org-mode/org-timer hides /usr/share/emacs/25.1/lisp/org/org-timer /usr/share/emacs25/site-lisp/org-mode/ox-odt hides /usr/share/emacs/25.1/lisp/org/ox-odt /usr/share/emacs25/site-lisp/org-mode/org-mouse hides /usr/share/emacs/25.1/lisp/org/org-mouse /usr/share/emacs25/site-lisp/org-mode/org-agenda hides /usr/share/emacs/25.1/lisp/org/org-agenda /usr/share/emacs25/site-lisp/org-mode/org-install hides /usr/share/emacs/25.1/lisp/org/org-install /usr/share/emacs25/site-lisp/org-mode/org-bibtex hides /usr/share/emacs/25.1/lisp/org/org-bibtex /usr/share/emacs25/site-lisp/org-mode/ob-scala hides /usr/share/emacs/25.1/lisp/org/ob-scala /usr/share/emacs25/site-lisp/org-mode/ob-haskell hides /usr/share/emacs/25.1/lisp/org/ob-haskell /usr/share/emacs25/site-lisp/org-mode/org-table hides /usr/share/emacs/25.1/lisp/org/org-table /usr/share/emacs25/site-lisp/org-mode/ob-ditaa hides /usr/share/emacs/25.1/lisp/org/ob-ditaa /usr/share/emacs25/site-lisp/org-mode/org-gnus hides /usr/share/emacs/25.1/lisp/org/org-gnus /usr/share/emacs25/site-lisp/org-mode/org-eshell hides /usr/share/emacs/25.1/lisp/org/org-eshell /usr/share/emacs25/site-lisp/org-mode/ob-picolisp hides /usr/share/emacs/25.1/lisp/org/ob-picolisp /usr/share/emacs25/site-lisp/org-mode/org-mhe hides /usr/share/emacs/25.1/lisp/org/org-mhe /usr/share/emacs25/site-lisp/org-mode/ox-texinfo hides /usr/share/emacs/25.1/lisp/org/ox-texinfo /usr/share/emacs25/site-lisp/org-mode/ob-keys hides /usr/share/emacs/25.1/lisp/org/ob-keys /usr/share/emacs25/site-lisp/org-mode/ob-octave hides /usr/share/emacs/25.1/lisp/org/ob-octave /usr/share/emacs25/site-lisp/org-mode/org-protocol hides /usr/share/emacs/25.1/lisp/org/org-protocol /usr/share/emacs25/site-lisp/org-mode/org-datetree hides /usr/share/emacs/25.1/lisp/org/org-datetree /usr/share/emacs25/site-lisp/org-mode/ob-core hides /usr/share/emacs/25.1/lisp/org/ob-core /usr/share/emacs25/site-lisp/org-mode/ob-lob hides /usr/share/emacs/25.1/lisp/org/ob-lob /usr/share/emacs25/site-lisp/org-mode/ob-latex hides /usr/share/emacs/25.1/lisp/org/ob-latex /usr/share/emacs25/site-lisp/org-mode/org-footnote hides /usr/share/emacs/25.1/lisp/org/org-footnote /usr/share/emacs25/site-lisp/org-mode/org-w3m hides /usr/share/emacs/25.1/lisp/org/org-w3m /usr/share/emacs25/site-lisp/org-mode/org-archive hides /usr/share/emacs/25.1/lisp/org/org-archive /usr/share/emacs25/site-lisp/org-mode/org-faces hides /usr/share/emacs/25.1/lisp/org/org-faces /usr/share/emacs25/site-lisp/org-mode/org-list hides /usr/share/emacs/25.1/lisp/org/org-list /usr/share/emacs25/site-lisp/org-mode/ob-comint hides /usr/share/emacs/25.1/lisp/org/ob-comint /usr/share/emacs25/site-lisp/org-mode/org-indent hides /usr/share/emacs/25.1/lisp/org/org-indent /usr/share/emacs25/site-lisp/org-mode/ob-org hides /usr/share/emacs/25.1/lisp/org/ob-org /usr/share/emacs25/site-lisp/org-mode/org-inlinetask hides /usr/share/emacs/25.1/lisp/org/org-inlinetask /usr/share/emacs25/site-lisp/org-mode/org-compat hides /usr/share/emacs/25.1/lisp/org/org-compat /usr/share/emacs25/site-lisp/org-mode/ob-io hides /usr/share/emacs/25.1/lisp/org/ob-io /usr/share/emacs25/site-lisp/org-mode/org-mobile hides /usr/share/emacs/25.1/lisp/org/org-mobile /usr/share/emacs25/site-lisp/org-mode/ob-scheme hides /usr/share/emacs/25.1/lisp/org/ob-scheme /usr/share/emacs25/site-lisp/org-mode/ob-python hides /usr/share/emacs/25.1/lisp/org/ob-python /usr/share/emacs25/site-lisp/org-mode/ox-html hides /usr/share/emacs/25.1/lisp/org/ox-html /usr/share/emacs25/site-lisp/org-mode/ob-java hides /usr/share/emacs/25.1/lisp/org/ob-java /usr/share/emacs25/site-lisp/org-mode/org-colview hides /usr/share/emacs/25.1/lisp/org/org-colview /usr/share/emacs25/site-lisp/org-mode/ob-ruby hides /usr/share/emacs/25.1/lisp/org/ob-ruby /usr/share/emacs25/site-lisp/org-mode/ox-latex hides /usr/share/emacs/25.1/lisp/org/ox-latex /usr/share/emacs25/site-lisp/org-mode/ox hides /usr/share/emacs/25.1/lisp/org/ox /usr/share/emacs25/site-lisp/org-mode/ob-ref hides /usr/share/emacs/25.1/lisp/org/ob-ref /usr/share/emacs25/site-lisp/org-mode/org-macro hides /usr/share/emacs/25.1/lisp/org/org-macro /usr/share/emacs25/site-lisp/org-mode/org hides /usr/share/emacs/25.1/lisp/org/org /usr/share/emacs25/site-lisp/org-mode/ob-css hides /usr/share/emacs/25.1/lisp/org/ob-css /usr/share/emacs25/site-lisp/org-mode/ob-shen hides /usr/share/emacs/25.1/lisp/org/ob-shen /usr/share/emacs25/site-lisp/org-mode/org-irc hides /usr/share/emacs/25.1/lisp/org/org-irc /usr/share/emacs25/site-lisp/org-mode/ob-sql hides /usr/share/emacs/25.1/lisp/org/ob-sql /usr/share/emacs25/site-lisp/org-mode/org-element hides /usr/share/emacs/25.1/lisp/org/org-element /usr/share/emacs25/site-lisp/org-mode/ob hides /usr/share/emacs/25.1/lisp/org/ob /usr/share/emacs25/site-lisp/org-mode/ob-sqlite hides /usr/share/emacs/25.1/lisp/org/ob-sqlite /usr/share/emacs25/site-lisp/org-mode/ox-publish hides /usr/share/emacs/25.1/lisp/org/ox-publish /usr/share/emacs25/site-lisp/org-mode/ob-tangle hides /usr/share/emacs/25.1/lisp/org/ob-tangle /usr/share/emacs25/site-lisp/org-mode/ob-lisp hides /usr/share/emacs/25.1/lisp/org/ob-lisp /usr/share/emacs25/site-lisp/org-mode/ob-exp hides /usr/share/emacs/25.1/lisp/org/ob-exp /usr/share/emacs25/site-lisp/org-mode/org-crypt hides /usr/share/emacs/25.1/lisp/org/org-crypt /usr/share/emacs25/site-lisp/org-mode/ob-perl hides /usr/share/emacs/25.1/lisp/org/ob-perl /usr/share/emacs25/site-lisp/org-mode/org-src hides /usr/share/emacs/25.1/lisp/org/org-src /usr/share/emacs25/site-lisp/org-mode/ox-icalendar hides /usr/share/emacs/25.1/lisp/org/ox-icalendar /usr/share/emacs25/site-lisp/org-mode/org-loaddefs hides /usr/share/emacs/25.1/lisp/org/org-loaddefs /usr/share/emacs25/site-lisp/org-mode/ob-ocaml hides /usr/share/emacs/25.1/lisp/org/ob-ocaml /usr/share/emacs25/site-lisp/org-mode/ox-ascii hides /usr/share/emacs/25.1/lisp/org/ox-ascii /usr/share/emacs25/site-lisp/org-mode/ob-R hides /usr/share/emacs/25.1/lisp/org/ob-R /usr/share/emacs25/site-lisp/org-mode/ob-C hides /usr/share/emacs/25.1/lisp/org/ob-C /usr/share/emacs25/site-lisp/org-mode/org-version hides /usr/share/emacs/25.1/lisp/org/org-version /usr/share/emacs25/site-lisp/org-mode/ob-asymptote hides /usr/share/emacs/25.1/lisp/org/ob-asymptote /usr/share/emacs25/site-lisp/org-mode/org-habit hides /usr/share/emacs/25.1/lisp/org/org-habit /usr/share/emacs25/site-lisp/org-mode/ob-matlab hides /usr/share/emacs/25.1/lisp/org/ob-matlab /usr/share/emacs25/site-lisp/org-mode/ox-org hides /usr/share/emacs/25.1/lisp/org/ox-org /usr/share/emacs25/site-lisp/org-mode/ox-man hides /usr/share/emacs/25.1/lisp/org/ox-man /usr/share/emacs25/site-lisp/org-mode/ob-calc hides /usr/share/emacs/25.1/lisp/org/ob-calc /usr/share/emacs25/site-lisp/org-mode/org-feed hides /usr/share/emacs/25.1/lisp/org/org-feed /usr/share/emacs25/site-lisp/flim/sasl-cram hides /usr/share/emacs/25.1/lisp/net/sasl-cram /usr/share/emacs25/site-lisp/flim/sasl hides /usr/share/emacs/25.1/lisp/net/sasl /usr/share/emacs25/site-lisp/flim/sasl-digest hides /usr/share/emacs/25.1/lisp/net/sasl-digest /usr/share/emacs25/site-lisp/flim/sasl-ntlm hides /usr/share/emacs/25.1/lisp/net/sasl-ntlm /usr/share/emacs25/site-lisp/flim/hmac-def hides /usr/share/emacs/25.1/lisp/net/hmac-def /usr/share/emacs25/site-lisp/flim/hmac-md5 hides /usr/share/emacs/25.1/lisp/net/hmac-md5 /usr/share/emacs25/site-lisp/flim/ntlm hides /usr/share/emacs/25.1/lisp/net/ntlm /usr/share/emacs/25.1/site-lisp/elpa/let-alist-1.0.4/let-alist hides /usr/share/emacs/25.1/lisp/emacs-lisp/let-alist /usr/share/emacs/25.1/site-lisp/elpa/seq-2.19/seq hides /usr/share/emacs/25.1/lisp/emacs-lisp/seq /usr/share/emacs25/site-lisp/auctex/prv-emacs hides /usr/share/emacs/site-lisp/auctex/prv-emacs /usr/share/emacs25/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl /usr/share/emacs25/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style /usr/share/emacs25/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex /usr/share/emacs25/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik /usr/share/emacs25/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar /usr/share/emacs25/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex /usr/share/emacs25/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en /usr/share/emacs25/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp /usr/share/emacs25/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font /usr/share/emacs25/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf /usr/share/emacs25/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite /usr/share/emacs25/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info /usr/share/emacs25/site-lisp/auctex/plain-tex hides /usr/share/emacs/site-lisp/auctex/plain-tex /usr/share/emacs25/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp /usr/share/emacs25/site-lisp/auctex/preview hides /usr/share/emacs/site-lisp/auctex/preview /usr/share/emacs25/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context /usr/share/emacs25/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold /usr/share/emacs25/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt /usr/share/emacs25/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x /usr/share/emacs25/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex Features: (shadow emacsbug browse-kill-ring pcmpl-unix pcmpl-gnu debian-bug debian-changelog-mode calccomp calc-arith calc-misc calc-map calc-stat calc-vec calc-aent dired-aux texmathp preview prv-emacs tex-buf font-latex latex tex-style tex dbus xml tex-mode latexenc bookmark pp org-capture gnus-art mm-uu mml2015 gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader inline url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf rst derived disp-table org-colview calc-undo calc-alg calc-ext calc-menu calc calc-loaddefs calc-macs org-table filecache network-stream nsm starttls racket-mode racket-bug-report racket-collection tq racket-profile racket-imenu imenu racket-edit hideshow racket-complete racket-repl ido racket-common racket-indent racket-font-lock racket-util racket-keywords-and-builtins racket-custom parse-time qp tabify ledger-mode ledger-check ledger-schedule ledger-xact ledger-texi ledger-test ledger-sort ledger-report ledger-reconcile ledger-post ledger-occur ledger-init ledger-fontify ledger-state ledger-navigate ledger-fonts ledger-exec ledger-context ledger-complete ledger-commodities esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-groups eshell esh-module esh-mode esh-arg esh-util cus-edit cus-start cus-load ledger-regex debug eieio-opt speedbar sb-image ezimage dframe cal-move markdown-mode make-mode message-templ sh-script smie executable grep magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert autorevert filenotify magit-process magit-margin magit-mode magit-git magit-section magit-utils magit-popup git-commit log-edit pcvs-util add-log with-editor async-bytecomp async tramp-sh whitespace compile misearch multi-isearch cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs org-clock view cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays hol-loaddefs cal-iso vc-git org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view jka-compr image-mode org-bibtex bibtex org-bbdb org-w3m org-agenda mm-archive url-util url-parse url-vars shr-color shr dom subr-x browse-url sendmail sort company-files company-oddmuse company-keywords company-etags etags xref project company-gtags company-dabbrev-code company-dabbrev company-capf company-cmake company-ropemacs company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-bbdb company mail-extr edmacro kmacro notmuch-jump notmuch hl-line notmuch-message notmuch-hello wid-edit notmuch-tree notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj notmuch-query goto-addr icalendar diary-lib diary-loaddefs notmuch-tag crm notmuch-lib notmuch-version notmuch-compat cl message dired rfc822 mml mailabbrev mail-utils gmm-utils mailheader mm-view mml-smime mml-sec epg smime dig mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 ietf-drums cursor-sensor minibuffer-complete-cycle server indirect-region tempo org-notmuch org-element avl-tree org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint tramp tramp-compat auth-source cl-seq eieio eieio-core cl-macs gnus-util time-date mm-util help-fns mail-prsvr password-cache tramp-loaddefs trampver shell pcomplete comint ansi-color ob-core ob-eval org-compat org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs rx vc vc-dispatcher circe-color-nicks color circe-chanop circe advice diff-mode lui-irc-colors irc make-tls-process tls gnutls lcs lui-format lui tracking shorten thingatpt paren flyspell ispell ring circe-compat finder-inf muse-autoloads package epg-config seq seq-25 byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib debian-el debian-el-loaddefs s ucs-normalize org-install haskell-mode-autoloads emacs-goodies-el emacs-goodies-custom emacs-goodies-loaddefs easy-mmode dpkg-dev-el dpkg-dev-el-loaddefs dash-functional dash preview-latex tex-site auto-loads mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 3519340 235888) (symbols 48 64348 2) (miscs 40 46989 3711) (strings 32 313297 125973) (string-bytes 1 12186097) (vectors 16 118270) (vector-slots 8 2459973 123628) (floats 8 5420 3349) (intervals 56 309816 4143) (buffers 976 335)) --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAlisJc8ACgkQ8gKXHaSn niz6Zgv+PAet9oSFlagNefA+2cQZD1LfpDq8ex32/jQgIopXDaUmQMcA4jGNK37y VMovkxwUnuK99eqx+rT5Z+nowlE1AXztK6sgFF/zGjGz8iHR0MfEycpV83ZwrRVD KAF7fW/fiYejTjWmO1MJFmFF4V8r8p+T33wJ8vbwyrL5jdJDHYQtmiMmCkKlCdRj hWFo+kQMj5wDYXypEC8VrW18afMPVCDAJdf8mXpDNkf7hrfCkbOr8pC7ZPzZhqgR oe5zGCuGnss+BX+oFPOSohrIKAGlFqWE5qfqzqLALThouYLi+7m6lLb4h196Ndu3 7fV6HA0OXOGAzjbNe3cxiVCBw9zyE05ZOmn/Ydp8lkq7o1EvZxlAl8gi2ipn4l3U CnD2wRN/OWGSu30bMsMsl/a/8IsxYMhAIH4h7zlzJSpcHZYqZ0ckJBoOmcIcR+oq D6xbbqLR5KdN+diaWrmSvNQA+Ba3+cebmfNRds4DrVWjxK1AS7UciOk5uYSi/t1e OB/rUc/9 =Apw9 -----END PGP SIGNATURE----- --==-=-=-- ------------=_1488622922-5365-1-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 12 09:15:49 2017 Received: (at control) by debbugs.gnu.org; 12 Nov 2017 14:15:49 +0000 Received: from localhost ([127.0.0.1]:36205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDt37-0001F0-1D for submit@debbugs.gnu.org; Sun, 12 Nov 2017 09:15:49 -0500 Received: from mail-it0-f49.google.com ([209.85.214.49]:40376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDt34-0001Ej-Rt; Sun, 12 Nov 2017 09:15:47 -0500 Received: by mail-it0-f49.google.com with SMTP id 72so6498063itl.5; Sun, 12 Nov 2017 06:15:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QJb6sEGbN9lqtwF3JfYO0o+EAzpl3MhAsEZl7XOL3xQ=; b=OMI0UeiP14XWNIL5VF0Vu+zEMN2or/DyOBJBbmVxHA+ZEu/h98iCl0l2bOcv1DIrnG xnVBiYzCsaVzJobn2pfZmbCqxkydVSxwve3j/9/k63WlS6s8Zf6Z0dcqEnz/NgHxgcJ4 Il/jKRD9+MSNQo9YwXKIJAZgrh08IZqqVmXzoGgsNFHBps/9yWXEZmXCvNNK+DmRexfp sVQq1hOjrmfv+EsJGJIacjjxzFZZKHFC+uEy9Cfcjiaweio207LMtU6wGzuN1UTk3tHC O7LVPWj0Jffi/+tag+Q7Nogp3GCcxey7zr+xzslvS825Ry5VprBgDuAJuw7zTilHupEK s3BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=QJb6sEGbN9lqtwF3JfYO0o+EAzpl3MhAsEZl7XOL3xQ=; b=gPaIWBpMBKQxREvDl8TY70a69Qg/tHEuq7xyr1b7Fqlome/HybHmPTgowOO8bZBz7r P9UOgvWY3qQgKJ1fQLdcuiG8Gj6yjpaImpBFhQxH9fAHE0HexUAOJtEpGmaiq0OVPbig 2Sin9BaYY7tqBGeqWqbqod09OU0cGgMWTtE2eMd28JeUe9ZCPOKxWnfWQDpBfygKIQL/ U6+w5Osm7IowtPdFyT+GUN7I5gft2cwkuKOsPIEo1Sh7ph52N8FVhnEymv9H9MLRBzUf kgWkt5rOXuMI4lSDJl+geyk+V9KWXcxLWTz16I2PVhTHQavqR0tDR/dm2d49242Btsqd PjOg== X-Gm-Message-State: AJaThX5cP2uV3u0OzRK4/fGDV3tyQu/b/+Bq6ODUCw1V2zXXx+QWo5r2 OBU3Izpa9JTjsJ+D8XidDGeKvQ== X-Google-Smtp-Source: AGs4zMa6yHKWFzDqiVTkFTSXYTh+3W+FKk1Cb89k3n5/iDD7tZ5UKmipskO7YvTuflJjg/2APihGmw== X-Received: by 10.36.148.19 with SMTP id j19mr7720348ite.51.1510496140806; Sun, 12 Nov 2017 06:15:40 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 194sm3350478ito.20.2017.11.12.06.15.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Nov 2017 06:15:39 -0800 (PST) From: Noam Postavsky To: David Bremner Subject: Re: bug#29273: 25.2; backtrace inserting HTML table into dedicated buffer References: <87o9o7bno5.fsf@tethera.net> Date: Sun, 12 Nov 2017 09:15:38 -0500 In-Reply-To: <87o9o7bno5.fsf@tethera.net> (David Bremner's message of "Sun, 12 Nov 2017 10:02:18 -0400") Message-ID: <878tfb37n9.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: control Cc: 29273@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) tags 29273 fixed close 29273 26.1 unarchive 25828 merge 29273 25828 quit David Bremner writes: > - to reproduce in emacs -Q, evaluate the following forms in a buffer > > (set-window-dedicated-p (selected-window) t) > (shr-insert-document > '(html > (head nil) > (body nil > (table nil > (tr nil > (td nil > "hello world!")))))) > > - this should just insert " hello world!" into the buffer, but it > complains about the dedicated window and stops with backtrace. > > - according to a notmuch user report, this is also reproducible in newer > emacs, namely > > * c3ff6712ad - (HEAD, origin/emacs-25) * lisp/net/tls.el (tls-program): > Fix :version (do not merge to master). (2017-09-14 > 16:38:29 -0400) > Emacs version is reported as 25.3.50.1. > > - There were similar bugs reported and fixed previously: 24950, 25828 I can reproduce on emacs-25, but not on emacs-26, so I believe this is a dup of 25828.