From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 12:46:25 2017 Received: (at submit) by debbugs.gnu.org; 18 Feb 2017 17:46:25 +0000 Received: from localhost ([127.0.0.1]:45255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf95V-0002Gy-JI for submit@debbugs.gnu.org; Sat, 18 Feb 2017 12:46:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf95T-0002Gj-9G for submit@debbugs.gnu.org; Sat, 18 Feb 2017 12:46:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf95M-0008Bz-Qv for submit@debbugs.gnu.org; Sat, 18 Feb 2017 12:46:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cf95M-0008Bv-NP for submit@debbugs.gnu.org; Sat, 18 Feb 2017 12:46:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf95L-0002Yv-Jh for bug-guile@gnu.org; Sat, 18 Feb 2017 12:46:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf95I-00089h-HX for bug-guile@gnu.org; Sat, 18 Feb 2017 12:46:15 -0500 Received: from mail-pg0-x231.google.com ([2607:f8b0:400e:c05::231]:35086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cf95I-00089U-7v for bug-guile@gnu.org; Sat, 18 Feb 2017 12:46:12 -0500 Received: by mail-pg0-x231.google.com with SMTP id b129so2911209pgc.2 for ; Sat, 18 Feb 2017 09:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:to; bh=+0jtwY6etoDTKOjzblwQYLJqRYZaIrzg/Ef6MUfj44w=; b=W3dEdqnUBDRuC57G71EpOX0IY1NhggxzdVj42BzYtj3XBGC96sguD+LK76hgDnduqX amaWVHq9ZcVz/X3LtbcQ7IwMb9nkuTAlVZWhsx5kt30h042TduyjE7WDvWB+Z8Mo4xxz vYB9vbxFrzmKk1qJIJ1Zh7Pu2H4nD6E9P63642VNnVMrYoqCeqS70ZYt0NtPQ58scFLc ye/gqSY0bY9MTGOFcPoGAzlsElMk8CYf9exJKaXef+y/u0OLei9Rnq7M2Gl3aSZXmIEX gXfPpof7MId5NcqbZDywEtYgbYU7VFu8q1X6ikhAnlzOhKiqCuXnSJF8Mq9LxvgfBab7 UYnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=+0jtwY6etoDTKOjzblwQYLJqRYZaIrzg/Ef6MUfj44w=; b=dhcqWWG1kzD/K+hlX7I+vlVp2ChIgcobimbipSrbcJqqRJyXH7hnr38lJ9H2h1bJxp cye3nmtHkQVqFDu5eflQVsI0B1nqaVJetXLBVqWn+KsDoULLM9r/yXpUGBWpn2JUJY8X I//gujNSCJQrvd0jZAEpI2LEiMUKHu4oyGEx99bdjrthRowogj727mFHnkX+JRpf5jy2 iyrZKlhmJ9W/TFU+fPti4wEUWMtureYZDbOERvDSo6cMhzdWyyEHbRhcKe5tXJ16PFaN yU2tP3/BetXMu3/+meL1adHpyATTXEOg4cg4atcoG2iesnkKItW+UoDsqO/w6MkRnC78 5LBg== X-Gm-Message-State: AMke39mLpskwVCJpqZPC/yLlPSN57y39F6TbAAznMshtFRHo3o9+mKyy/CbLCcS9jO5YqA== X-Received: by 10.98.198.199 with SMTP id x68mr16171062pfk.87.1487439970770; Sat, 18 Feb 2017 09:46:10 -0800 (PST) Received: from nautilus.championbroadband.com (216-165-246-244.championbroadband.com. [216.165.246.244]) by smtp.gmail.com with ESMTPSA id q26sm2865559pfg.47.2017.02.18.09.46.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Feb 2017 09:46:09 -0800 (PST) From: Matt Wette Content-Type: multipart/alternative; boundary="Apple-Mail=_13E92D88-44DC-4AEE-BFED-7E91847C6064" Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: [PATCH] use of abs() in numbers.c: should be labs() Message-Id: <90F3BCE0-765F-43F6-B3ED-7B339EF9B2F0@gmail.com> Date: Sat, 18 Feb 2017 09:46:07 -0800 To: bug-guile@gnu.org X-Mailer: Apple Mail (2.3259) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --Apple-Mail=_13E92D88-44DC-4AEE-BFED-7E91847C6064 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii In libguile/numbers.c abs() is used for long argument where labs() = should be used. =20 A patch is included below for guile-2.1.7. /* Returns log(n/d), for exact non-zero integers n and d */ static SCM log_of_fraction (SCM n, SCM d) { long n_size =3D scm_to_long (scm_integer_length (n)); long d_size =3D scm_to_long (scm_integer_length (d)); if (abs (n_size - d_size) > 1) return (scm_difference (log_of_exact_integer (n), log_of_exact_integer (d))); --- libguile/numbers.c.orig 2017-02-18 08:29:52.000000000 -0800 +++ libguile/numbers.c 2017-02-18 08:30:23.000000000 -0800 @@ -9951,7 +9951,7 @@ long n_size =3D scm_to_long (scm_integer_length (n)); long d_size =3D scm_to_long (scm_integer_length (d)); =20 - if (abs (n_size - d_size) > 1) + if (labs (n_size - d_size) > 1) return (scm_difference (log_of_exact_integer (n), log_of_exact_integer (d))); else if (scm_is_false (scm_negative_p (n))) --Apple-Mail=_13E92D88-44DC-4AEE-BFED-7E91847C6064 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii In = libguile/numbers.c abs() is used for long argument where labs() should = be used.  
A patch is included below for guile-2.1.7.

/* Returns = log(n/d), for exact non-zero integers n and d */
static SCM
log_of_fraction = (SCM n, SCM d)
{
  long n_size =3D scm_to_long = (scm_integer_length (n));
  long d_size = =3D scm_to_long (scm_integer_length (d));

  if (abs = (n_size - d_size) > 1)
    = return (scm_difference (log_of_exact_integer = (n),
          =                   = log_of_exact_integer (d)));


--- = libguile/numbers.c.orig 2017-02-18 08:29:52.000000000 = -0800
+++ libguile/numbers.c 2017-02-18 08:30:23.000000000 = -0800
@@ -9951,7 +9951,7 @@
   long n_size =3D = scm_to_long (scm_integer_length (n));
   long d_size =3D = scm_to_long (scm_integer_length (d));
 
-  if (abs = (n_size - d_size) > 1)
+  if (labs (n_size - d_size) > = 1)
     return (scm_difference = (log_of_exact_integer (n),
    =  log_of_exact_integer (d)));
   else if (scm_is_false = (scm_negative_p (n)))

= --Apple-Mail=_13E92D88-44DC-4AEE-BFED-7E91847C6064-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 16:13:22 2017 Received: (at 25786-done) by debbugs.gnu.org; 21 Feb 2017 21:13:22 +0000 Received: from localhost ([127.0.0.1]:49310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgHkQ-0006kz-6Y for submit@debbugs.gnu.org; Tue, 21 Feb 2017 16:13:22 -0500 Received: from pb-sasl2.pobox.com ([64.147.108.67]:52406 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgHkO-0006kr-BX for 25786-done@debbugs.gnu.org; Tue, 21 Feb 2017 16:13:20 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 5F86A60FA7; Tue, 21 Feb 2017 16:13:20 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=0+gB15d1DIXNt0TYad3ghuCmTuc=; b=hpcQGI QoKgdmAUtnP840ldvWDoBcFJ+h6nFpBwTbGBkGsXNJpIVsHIYEvQHDSa1oPHd7EE pYz49+7/517RlkA9m9wBdNi4xAuxrQRQiA31JkHHrMET9/eXgNXiesELdCJceFPe cz8dTcY/2c81/HtaGR5OTrFF+t7veFUal0zbA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=KKrHyvpjoqbQD2JPy+bYmSqckYXnwIdj DvuSHmLsnw6GPPfgYn3eES/cyPj1yIA+XyVsnrbdJFY8cQYbXa+ZU2qsxjqqlJJd inPDF7RXr3TXe4uuJRTaE91jhRFpJisWp3etcAx5eTvW94yTUAHmrm9/jnfhCjAw nV0HNjwWJ4o= Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 5724560FA6; Tue, 21 Feb 2017 16:13:20 -0500 (EST) Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 4C20F60FA4; Tue, 21 Feb 2017 16:13:19 -0500 (EST) From: Andy Wingo To: Matt Wette Subject: Re: bug#25786: [PATCH] use of abs() in numbers.c: should be labs() References: <90F3BCE0-765F-43F6-B3ED-7B339EF9B2F0@gmail.com> Date: Tue, 21 Feb 2017 22:13:11 +0100 In-Reply-To: <90F3BCE0-765F-43F6-B3ED-7B339EF9B2F0@gmail.com> (Matt Wette's message of "Sat, 18 Feb 2017 09:46:07 -0800") Message-ID: <87mvdfxn6g.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 91D1DE12-F87A-11E6-BA83-6141F2301B6D-02397024!pb-sasl2.pobox.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25786-done Cc: 25786-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Sat 18 Feb 2017 18:46, Matt Wette writes: > In libguile/numbers.c abs() is used for long argument where labs() should be used. > A patch is included below for guile-2.1.7. Applied. Thank you! Andy From unknown Fri Jun 20 07:22:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Mar 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator