From unknown Mon Jun 16 23:41:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25784 <25784@debbugs.gnu.org> To: bug#25784 <25784@debbugs.gnu.org> Subject: Status: 25.2; mouse-1 binding in debbugs-gnu.el Reply-To: bug#25784 <25784@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:41:37 +0000 retitle 25784 25.2; mouse-1 binding in debbugs-gnu.el reassign 25784 emacs submitter 25784 charles@aurox.ch (Charles A. Roelli) severity 25784 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 06:20:34 2017 Received: (at submit) by debbugs.gnu.org; 18 Feb 2017 11:20:34 +0000 Received: from localhost ([127.0.0.1]:44225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf342-0006QA-JO for submit@debbugs.gnu.org; Sat, 18 Feb 2017 06:20:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf33x-0006Pu-KM for submit@debbugs.gnu.org; Sat, 18 Feb 2017 06:20:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf33o-00024N-JG for submit@debbugs.gnu.org; Sat, 18 Feb 2017 06:20:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cf33o-00024H-GQ for submit@debbugs.gnu.org; Sat, 18 Feb 2017 06:20:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf33k-0001Yi-Gf for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:20:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf33f-0001wo-Vs for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:20:12 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:51708) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cf33f-0001tn-Nh for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:20:07 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 91DF022367 for ; Sat, 18 Feb 2017 11:17:03 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-type:content-type:mime-version:message-id:date:date :subject:subject:to:from:from; s=dkim; t=1487416622; x= 1488280623; bh=xazz/vZKkBO553bc/ENFX5GBa9V9k51bz9k/Bf63l/w=; b=d 4Xk4nzBElKzzlymURgy/042qyjeHN9JaXIoduENA+W03cZZhbA6dvxhzcHjPGdmz JHaZvbxocUxx3+zX+uf4Qf2jIUt7kniRpFBPpHZtmeBSDa9ywaWp4W3eGUpifuUX pNeDoVyyYDRH/bRqoMo/hGc2iSWY9vy0ZjufATEnbs= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id d5Ea2n2ayueZ for ; Sat, 18 Feb 2017 11:17:02 +0000 (UTC) Received: from gray (54.4.4.85.dynamic.wline.res.cust.swisscom.ch [85.4.4.54]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 2C2A42234F for ; Sat, 18 Feb 2017 11:17:01 +0000 (UTC) From: charles@aurox.ch (Charles A. Roelli) To: bug-gnu-emacs@gnu.org Subject: 25.2; mouse-1 binding in debbugs-gnu.el Date: Sat, 18 Feb 2017 12:20:02 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) `mouse-1' is bound in debbugs-gnu.el, which means that a nil value of `mouse-1-click-follows-link' is not respected. The following patch is needed: --- debbugs-0.12/debbugs-gnu.el.~2~ 2017-02-17 17:54:15.000000000 +0100 +++ debbugs-0.12/debbugs-gnu.el 2017-02-18 12:07:56.000000000 +0100 @@ -909,7 +909,6 @@ (menu-map (make-sparse-keymap))) (set-keymap-parent map tabulated-list-mode-map) (define-key map "\r" 'debbugs-gnu-select-report) - (define-key map [mouse-1] 'debbugs-gnu-select-report) (define-key map [mouse-2] 'debbugs-gnu-select-report) (define-key map "g" 'debbugs-gnu-rescan) (define-key map "R" 'debbugs-gnu-show-all-blocking-reports) @@ -1587,7 +1586,6 @@ (let ((map (make-sparse-keymap))) (set-keymap-parent map tabulated-list-mode-map) (define-key map "\r" 'debbugs-gnu-select-usertag) - (define-key map [mouse-1] 'debbugs-gnu-select-usertag) (define-key map [mouse-2] 'debbugs-gnu-select-usertag) map)) There already was a ChangeLog entry to this effect in the past: 2012-12-23 Lars Ingebrigtsen Don't explicitly bind mouse-1. As Michael Heerdegen says: However, also binding mouse-1 is not necessary. Depending on the setting of `mouse-1-click-follows-link', which is non-nil by default, mouse-1 already follows links - see its doc. We should leave it up to the user if he wants to use mouse-1 for following or not. But the change does not seem to have been made, or maybe it was reverted at some point. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 08:44:05 2017 Received: (at 25784) by debbugs.gnu.org; 18 Feb 2017 13:44:05 +0000 Received: from localhost ([127.0.0.1]:44361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf5Iv-0003Go-SL for submit@debbugs.gnu.org; Sat, 18 Feb 2017 08:44:05 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:44132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf5Iq-0003GZ-V8 for 25784@debbugs.gnu.org; Sat, 18 Feb 2017 08:44:00 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3vQWMH5fzVz3hlwL; Sat, 18 Feb 2017 14:43:55 +0100 (CET) Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3vQWMG2s9Jzvkdq; Sat, 18 Feb 2017 14:43:54 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id QzMLxSEZtvax; Sat, 18 Feb 2017 14:43:50 +0100 (CET) X-Auth-Info: zRky8b0O5cax5gZxqoZT/zHgnuHmaaMuJSZTmUR5xqIjYiEt6AKzzbGH33KklGyb Received: from igel.home (ppp-88-217-3-200.dynamic.mnet-online.de [88.217.3.200]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 18 Feb 2017 14:43:50 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 3C6C22C3E4D; Sat, 18 Feb 2017 14:43:49 +0100 (CET) From: Andreas Schwab To: charles@aurox.ch (Charles A. Roelli) Subject: Re: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el References: X-Yow: I brought my BOWLING BALL - and some DRUGS!! Date: Sat, 18 Feb 2017 14:43:49 +0100 In-Reply-To: (Charles A. Roelli's message of "Sat, 18 Feb 2017 12:20:02 +0100") Message-ID: <87k28npqay.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25784 Cc: 25784@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Feb 18 2017, charles@aurox.ch (Charles A. Roelli) wrote: > There already was a ChangeLog entry to this effect in the past: > > 2012-12-23 Lars Ingebrigtsen > > Don't explicitly bind mouse-1. > > As Michael Heerdegen says: > > However, also binding mouse-1 is not necessary. Depending on the > setting of `mouse-1-click-follows-link', which is non-nil by default, > mouse-1 already follows links - see its doc. We should leave it up to > the user if he wants to use mouse-1 for following or not. > > But the change does not seem to have been made, or maybe it was reverted > at some point. This commit only changed debbugs-gnu-widget-map, not the other occurrences. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 06:22:52 2017 Received: (at 25784) by debbugs.gnu.org; 19 Feb 2017 11:22:52 +0000 Received: from localhost ([127.0.0.1]:45615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfPZs-0004Lz-4J for submit@debbugs.gnu.org; Sun, 19 Feb 2017 06:22:52 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:46316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfPZq-0004Lj-3a for 25784@debbugs.gnu.org; Sun, 19 Feb 2017 06:22:50 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 07AE722369 for <25784@debbugs.gnu.org>; Sun, 19 Feb 2017 11:19:44 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-type:content-type:mime-version:message-id:in-reply-to :date:date:references:subject:subject:to:from:from; s=dkim; t= 1487503182; x=1488367183; bh=oKzTUIGp+V02fiZscSJQs2PFF8+xUUEA0ff FJnHlGx4=; b=IKbTH2aj39fowjP95KVMlajxQGmbpuDAw+U9meyVnmS4bh7I3Ud q6G1KaSsMncVKAbo1t26/vdofQoTejHkk4sNxwZ/IUhYeYlzu8B9QgdwZCjgxp5b QPRdM3FltMmBhAnSxeeXklesvDuzA8xKdBlvOPHzfyK8H6MVlJJrmfVk= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id USzCSmy0K5uj for <25784@debbugs.gnu.org>; Sun, 19 Feb 2017 11:19:42 +0000 (UTC) Received: from gray (54.4.4.85.dynamic.wline.res.cust.swisscom.ch [85.4.4.54]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 707472233E; Sun, 19 Feb 2017 11:19:42 +0000 (UTC) From: charles@aurox.ch (Charles A. Roelli) To: Andreas Schwab Subject: Re: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el References: <87k28npqay.fsf@linux-m68k.org> Date: Sun, 19 Feb 2017 12:22:44 +0100 In-Reply-To: <87k28npqay.fsf@linux-m68k.org> (Andreas Schwab's message of "Sat, 18 Feb 2017 14:43:49 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25784 Cc: 25784@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Sat, Feb 18 2017 at 02:43:49 pm, Andreas Schwab wrote: > This commit only changed debbugs-gnu-widget-map, not the other > occurrences. Thanks for pointing that out. The other occurrences should be changed too. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 03:16:50 2017 Received: (at 25784-done) by debbugs.gnu.org; 20 Feb 2017 08:16:50 +0000 Received: from localhost ([127.0.0.1]:46812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfj9O-0000AE-0q for submit@debbugs.gnu.org; Mon, 20 Feb 2017 03:16:50 -0500 Received: from mout.gmx.net ([212.227.17.22]:58996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfj9M-0000A1-1y for 25784-done@debbugs.gnu.org; Mon, 20 Feb 2017 03:16:48 -0500 Received: from detlef.gmx.de ([93.197.204.90]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lg1QN-1bzVdg4BB5-00pdMm; Mon, 20 Feb 2017 09:16:28 +0100 From: Michael Albinus To: charles@aurox.ch (Charles A. Roelli) Subject: Re: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el References: <87k28npqay.fsf@linux-m68k.org> Date: Mon, 20 Feb 2017 09:16:26 +0100 In-Reply-To: (Charles A. Roelli's message of "Sun, 19 Feb 2017 12:22:44 +0100") Message-ID: <87d1eds2ed.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:+ozYS8e1RpnuO2w4cXkZqpxMjc9R3OrkSZA/VwJHNHjKKurck5x U0S/4cG/VO/nQ6d3/JfzTmhewRa84kZ6rmQ4I7K6iWxRYNePV2YDN9pJ+fRyyAqPRoQBsWo fP3oUCyJemTiz5lctY6PwofMEx9aTH25x8S3klaFEdzMUix5sA/tMiLWbF4UJDwc+40OnMF Zc3Rq5bbE5dPMU8i9JA/Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:tkJi1FBLGGw=:mC6/SiCORlLVkA7d08/jtm rBeSNhx5kE6MKLX9ISXSMD6PgMWWLK1WWUUZFowWRlB6oCPpTVSOfY2/Zc6Ppq5vC86y0AqsB kw5AP0QJ1bg9+kI4eFFPQ1ppmulJCytGEUACv8mgEsj+cc2dSBYQpT7fBRgKix56L2+s2GJZS 97MkhCYX2xW8iqSJGHoOtAbiHV+S9fmQagZZZM/dhElufxLraVhB0jn3EYS8YASiXFWaLVKQY ZYAh4fJ/HeJ6fp8uDbCt7lwMrZNEKuqOBRr8KzwsxJ/bGApKZQrYA+Z7u3UYbPwKuFS2Of6Ow WfbB1D/aYZmIRPeARdQcEP7M5ylepByrQfBwNGqyf4cKYNM7iduIJpN6VU2k3DQP2Vbhsh3q8 cKiEc/nfpHcSzE09AkWcuHb679nc71ion+VPXw15ygoI6om9MLFSymQaDxanjFuj6G+U3Zj2M gCYusQg53DXdOre7GrLCETWO3tSfqffhEsGCqD1ZdiMvp/R5TrtGR9JjCBHlbeH+4nHo2L2GV bxwBztIg2624d2wW6fT0ehIKDM9iatD7ommhGzNDZmji1TzRhqnHMhfgwGlzyFhfHqMH2Kt1s 2s0p50Kebv0GBREoJragAtLcubZDMFi0gdy0tKdOGAX0kOleGREWfbkblnqSjnyQmE/wHmoqH zzsjUlgjf8AO11duyJdV+p2sut4A8QP0XMealMfzipmwNnsMvXh7+5GHUHJ6q2GUFECpAY3Ie xg5iEb2JrBMZitUAKqhUfHRa75ZqO5qBG5Uyv72Bf3mTIS8a+0Cgzx0FlgtarPumPDFebgQNB I8/+1NejE5Out6JGXzlfeOwf0XuHH1xA19DTj5Pr0iuS5WVmExs45sq/sOhxtU1wgETsIPnya hZbXc90Az2FindQmdkjtfUrRfP7GQYKBP2lBvIY4ieJ62s1IWfbW2oScPb+wujpUrC60zclYS p8Jx27hwOEQFq1Yn8xGLmKgWhbTKdoyn92jJS656nrP83H4gk/aVfoqfT3v87EhxBzwhD2PB3 gHoNDBRYBq26BKWWangkQ4M= X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: 25784-done Cc: Andreas Schwab , 25784-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) charles@aurox.ch (Charles A. Roelli) writes: Hi Charles, >> This commit only changed debbugs-gnu-widget-map, not the other >> occurrences. > > Thanks for pointing that out. The other occurrences should be changed > too. I've applied your patch, extended to the other occurences. debbugs version is increased to 0.14, shall appear soon. Thanks for your report, and best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 03:56:07 2017 Received: (at 25784-done) by debbugs.gnu.org; 20 Feb 2017 08:56:07 +0000 Received: from localhost ([127.0.0.1]:46850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfjlP-00013u-Ed for submit@debbugs.gnu.org; Mon, 20 Feb 2017 03:56:07 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:46880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfjlN-00013P-78 for 25784-done@debbugs.gnu.org; Mon, 20 Feb 2017 03:56:05 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 4B91922366 for <25784-done@debbugs.gnu.org>; Mon, 20 Feb 2017 08:52:58 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-type:content-type:mime-version:message-id:in-reply-to :date:date:references:subject:subject:to:from:from; s=dkim; t= 1487580776; x=1488444777; bh=DIrD6q+7C8Ov5w+FVXCHzVNZZp8w9JqlFBx jsjNWjQI=; b=jprTwxhSvDLXgPtZPxeY5BZIiblOEfL6oJM33h1toeTjNWT6WZn Ubxxzk9LyIt62dH+w8EIrWDiWH5q1vGKSCLfvTVToGHs4vGbqBJ8oMJRgSv/XK7x bi5+UdH58dNX2VhFrPT1+Z9Ri3ToXTVnrIs8ktfzZKTCTsl7/cJ+a2uY= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BXwDgPJ-Y2Ex for <25784-done@debbugs.gnu.org>; Mon, 20 Feb 2017 08:52:56 +0000 (UTC) Received: from gray (54.4.4.85.dynamic.wline.res.cust.swisscom.ch [85.4.4.54]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 96FDB22357; Mon, 20 Feb 2017 08:52:53 +0000 (UTC) From: charles@aurox.ch (Charles A. Roelli) To: Michael Albinus Subject: Re: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el References: <87k28npqay.fsf@linux-m68k.org> <87d1eds2ed.fsf@detlef> Date: Mon, 20 Feb 2017 09:55:53 +0100 In-Reply-To: <87d1eds2ed.fsf@detlef> (Michael Albinus's message of "Mon, 20 Feb 2017 09:16:26 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25784-done Cc: Andreas Schwab , 25784-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Thanks for looking into this, Michael. I realize now that this change only makes sense if mouse-2 sets point when clicked, as it does in Gnus. I think what follows is the correct way to do it, and it works as expected. --- debbugs-0.12/debbugs-gnu.el.~1~ 2016-10-31 22:02:05.000000000 +0100 +++ debbugs-0.12/debbugs-gnu.el 2017-02-19 12:56:02.000000000 +0100 @@ -909,7 +909,6 @@ (menu-map (make-sparse-keymap))) (set-keymap-parent map tabulated-list-mode-map) (define-key map "\r" 'debbugs-gnu-select-report) - (define-key map [mouse-1] 'debbugs-gnu-select-report) (define-key map [mouse-2] 'debbugs-gnu-select-report) (define-key map "g" 'debbugs-gnu-rescan) (define-key map "R" 'debbugs-gnu-show-all-blocking-reports) @@ -1347,9 +1346,10 @@ (format "Re: bug#%d: %s" id (cdr (assq 'subject status)))) (debbugs-gnu-summary-mode 1))) -(defun debbugs-gnu-select-report () +(defun debbugs-gnu-select-report (&optional event) "Select the report on the current line." - (interactive) + (interactive "e") + (when event (mouse-set-point event)) ;; We open the report messages. (let* ((status (debbugs-gnu-current-status)) (id (cdr (assq 'id status))) @@ -1587,7 +1587,6 @@ (let ((map (make-sparse-keymap))) (set-keymap-parent map tabulated-list-mode-map) (define-key map "\r" 'debbugs-gnu-select-usertag) - (define-key map [mouse-1] 'debbugs-gnu-select-usertag) (define-key map [mouse-2] 'debbugs-gnu-select-usertag) map)) @@ -1665,9 +1664,10 @@ (set-buffer-modified-p nil) (goto-char (point-min))))) -(defun debbugs-gnu-select-usertag () +(defun debbugs-gnu-select-usertag (&optional event) "Select the user tag on the current line." - (interactive) + (interactive "e") + (when event (mouse-set-point event)) ;; We open the bug reports. (let ((args (get-text-property (line-beginning-position) 'tabulated-list-id))) (when args (apply 'debbugs-gnu args)))) From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 07:33:02 2017 Received: (at 25784-done) by debbugs.gnu.org; 20 Feb 2017 12:33:03 +0000 Received: from localhost ([127.0.0.1]:46934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfn9K-00007A-JU for submit@debbugs.gnu.org; Mon, 20 Feb 2017 07:33:02 -0500 Received: from mout.gmx.net ([212.227.17.21]:55251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfn9J-00006c-2n for 25784-done@debbugs.gnu.org; Mon, 20 Feb 2017 07:33:01 -0500 Received: from detlef.gmx.de ([93.197.204.90]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M03qC-1cMtmM0Ncy-00uEjx; Mon, 20 Feb 2017 13:32:46 +0100 From: Michael Albinus To: charles@aurox.ch (Charles A. Roelli) Subject: Re: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el References: <87k28npqay.fsf@linux-m68k.org> <87d1eds2ed.fsf@detlef> Date: Mon, 20 Feb 2017 13:32:43 +0100 In-Reply-To: (Charles A. Roelli's message of "Mon, 20 Feb 2017 09:55:53 +0100") Message-ID: <878tp1m49g.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:0INlkOTPZzvtJBPBgx+3kjqtKMuMJjuT7Bc205RFz33XLzXPZjp mPo+UFlc4bJjuunBxkmlTTCt/uorRLb+17dnVg6dkhSScDPyGELQQ3TojyZQaKWG4wSR5iU i/F5kdcCCCDsFAEVDbHHr+hXD9nXg/GVLYf09G4QmrDwO2C1OWB2uajI8bSp7aeUBAR6pF/ KccxeBqqIJgd2vmIa/FMQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ypDYT2Gn+N4=:JtnvSkFXcHyPw92s5ZTx30 xlvbNxzP9u3uTe95tM10/YipRNINPeRMZNFcyPmztWH4fyQPzLYWATTM/xdQXbd2F7bSVnEf9 R2o3YyWuW/EgvgvY0RHKiC7XXarCo06qJYDwbQYekbRYBfEjC4JJ0L5Ju0UB5U/CG5OXphz7R wyH0HbdzYnHRGfYjZivRB57Gd7SjlYcIHv/fQpjk4KvYPZlNSgqUz0zHCRuibpBqCxJqT9AfP EGNwin3I+ZiF8g7AlkvwjWLDqZ4NvrNLGATv9PgX7sT6/Z6+3H+j+ue/J3x46lO/p2pbMBxyb 96NP2/S1iy0hnAlbEWN3C8psbE4J/BG5lkgc+2Z0TCs01BzyyKB5j1Kh/CDNGUx5IkQ4b1LVT OtutfV8pDAlFXyg3nfhOJMuSVTqddnV0HxehGjitbX7ZauIlTdn4PJJ9UdyCA6uD3wAS5gJ8U N13MlHEayXsNtJBa3bC2+/0mmWhCVHxhwm7Y5KvTtMGadw3GrHkVwWQKvKyGimg+dWDNkaW4y RSuxfP7/0IsaXRp7xy96O1T3rjlZa1mghnxhHSOJXs0RfZz08MwfVXYWJ44hEe1B2560wrdUq MZS+lb5KyuBDCMj7jC6jaEnni4VZ5vVDEbFg86bbRMmBzDkeUKTWW1BVHchMnbfX/HRq+CJVo JE6en4iFUhJZ+6rLipHHxI4zpuBTJNObJOpYnJNykyfW2oyIlGdobrle+qsbfBpavvYB4p6N8 Xwohox8rDhqOsOAzSIJ6LDRRflnGvPSVTDvt81aJpGV9upmCnzMLEci4dlZYG84LP6kMawWp2 +xhFgpP X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25784-done Cc: Andreas Schwab , 25784-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) charles@aurox.ch (Charles A. Roelli) writes: Hi Charles, > I realize now that this change only makes sense if mouse-2 sets point > when clicked, as it does in Gnus. Good catch! > I think what follows is the correct way to do it, and it works as > expected. This patch works for using the mouse, but there are problems when you enter a bug report via RET or menu -> . I've applied the following patch to the repository: --8<---------------cut here---------------start------------->8--- diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el index f814642..eb94679 100644 --- a/packages/debbugs/debbugs-gnu.el +++ b/packages/debbugs/debbugs-gnu.el @@ -1350,6 +1350,7 @@ MERGED is the list of bugs merged with this one." (defun debbugs-gnu-select-report () "Select the report on the current line." (interactive) + (when (mouse-event-p last-input-event) (mouse-set-point last-input-event)) ;; We open the report messages. (let* ((status (debbugs-gnu-current-status)) (id (cdr (assq 'id status))) @@ -1673,6 +1674,7 @@ The following commands are available: (defun debbugs-gnu-select-usertag () "Select the user tag on the current line." (interactive) + (when (mouse-event-p last-input-event) (mouse-set-point last-input-event)) ;; We open the bug reports. (let ((args (get-text-property (line-beginning-position) 'tabulated-list-id))) (when args (apply 'debbugs-gnu args)))) --8<---------------cut here---------------end--------------->8--- Will appear with the next debbugs version 0.15. I've not decided yet, when to release. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 14:40:27 2017 Received: (at 25784-done) by debbugs.gnu.org; 20 Feb 2017 19:40:27 +0000 Received: from localhost ([127.0.0.1]:47808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cftox-00040L-MT for submit@debbugs.gnu.org; Mon, 20 Feb 2017 14:40:27 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:47276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cftow-000401-8b for 25784-done@debbugs.gnu.org; Mon, 20 Feb 2017 14:40:26 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id D5BAB22366 for <25784-done@debbugs.gnu.org>; Mon, 20 Feb 2017 19:37:18 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-type:content-type:mime-version:message-id:in-reply-to :date:date:references:subject:subject:to:from:from; s=dkim; t= 1487619437; x=1488483438; bh=XuE2deaXUWgxbkomXMb868ZzmANK1HpTY0t NZzZ2X70=; b=PuVqXN/TOe/6zO9afAMWEJ94eIpuuC9H3xLzNx/2lVEK2i1zoT6 poZsgvmKj+ngMC+uSTEQx3CkqqrBaTQsCcwDqBP/KyO136cz2kuvzAnMLisLL/oh gzujkKKKW93hFomMS/OhOZFNxDr5f+S0/W3TKD3x/p5kmlUFXRXYACz4= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xCK6CT8BNU5R for <25784-done@debbugs.gnu.org>; Mon, 20 Feb 2017 19:37:17 +0000 (UTC) Received: from gray (54.4.4.85.dynamic.wline.res.cust.swisscom.ch [85.4.4.54]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 657CE2233E; Mon, 20 Feb 2017 19:37:16 +0000 (UTC) From: charles@aurox.ch (Charles A. Roelli) To: Michael Albinus Subject: Re: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el References: <87k28npqay.fsf@linux-m68k.org> <87d1eds2ed.fsf@detlef> <878tp1m49g.fsf@detlef> Date: Mon, 20 Feb 2017 20:40:18 +0100 In-Reply-To: <878tp1m49g.fsf@detlef> (Michael Albinus's message of "Mon, 20 Feb 2017 13:32:43 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25784-done Cc: Andreas Schwab , 25784-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Thanks Michael, this looks good to me. From unknown Mon Jun 16 23:41:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 21 Mar 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator