GNU bug report logs - #25778
25.1; [PATCH] Drastically simplify xdg-open check

Previous Next

Full log

View this message in rfc822 format

From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
To: 25778 <at> debbugs.gnu.org
Subject: bug#25778: 25.1; [PATCH] Drastically simplify xdg-open check
Date: Fri, 17 Feb 2017 19:16:48 +0100

[Message part 1 (text/plain, inline)]

A user on #emacs brought it to my attention that the xdg-open detection
for browse-url is more complex than it should be and fails detecting
their Linux desktop.  Looking at the definition of
`browse-url-can-use-xdg-open' reveals that it replicates the desktop
environment check as done by `xdg-open` (which is done to detect the
DE-specific default browser setting, not to prevent people not using a
popular desktop environment from using xdg-open).  As enumerating all
possible kinds of Linux desktop is a futile endeavor, I've completely
eliminated this check from it so that the only ones left are whether
we're in a graphical session (by checking $DISPLAY) and whether
`xdg-open` has been found on $PATH.

[0001-Drastically-simplify-check-for-xdg-open.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.