GNU bug report logs - #25777
25.1; [PATCH] `rectangle--pos-cols' should not move point

Previous Next

Full log

View this message in rfc822 format

From: npostavs <at> users.sourceforge.net
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 25777 <at> debbugs.gnu.org
Subject: bug#25777: 25.1; [PATCH] `rectangle--pos-cols' should not move point
Date: Mon, 27 Feb 2017 23:57:50 -0500

Drew Adams <drew.adams <at> oracle.com> writes:

> I think it's great that a function such as `rectangle--pos-cols'
> was added.  (But it has no business being considered "internal".)
>
> Do you really think that a function whose only purpose is
> to let you know what the rectangle columns are should move
> point and leave it in a position that is not one of the
> rectangle corners?

After looking over this thread again, I conclude we got totally
side-tracked on the question of whether this is a regression or not.
That's just a distraction.

I think it's reasonable to make rectangle--pos-cols preserve point.
Could you update your patch to

1. Use a single save-excursion around the whole body, instead of adding
several.

2. Rename rectangle--pos-cols to rectangle-pos-cols.

3. Add a docstring to rectangle-pos-cols.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.