From unknown Sat Jun 21 10:41:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25765: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is a lambda. Resent-From: Hong Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Feb 2017 21:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25765 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 25765@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14872806559329 (code B ref -1); Thu, 16 Feb 2017 21:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Feb 2017 21:30:55 +0000 Received: from localhost ([127.0.0.1]:42685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceTdf-0002QP-6E for submit@debbugs.gnu.org; Thu, 16 Feb 2017 16:30:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceTdc-0002QA-TT for submit@debbugs.gnu.org; Thu, 16 Feb 2017 16:30:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceTdW-0000fE-Fw for submit@debbugs.gnu.org; Thu, 16 Feb 2017 16:30:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38577) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ceTdV-0000ex-Vb for submit@debbugs.gnu.org; Thu, 16 Feb 2017 16:30:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceTdU-0003kU-S9 for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:30:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceTdP-0000ca-VG for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:30:44 -0500 Received: from sender-of-o52.zoho.com ([135.84.80.217]:21307) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ceTdP-0000c7-Dk for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2017 16:30:39 -0500 Received: from localhost (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1487280635737696.3607244342126; Thu, 16 Feb 2017 13:30:35 -0800 (PST) From: Hong Xu Date: Thu, 16 Feb 2017 13:30:26 -0800 Message-Id: <20170216213026.5591-1-hong@topbug.net> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * flyspell.el (flyspell-auto-correct-word, flyspell-word): Quote flyspell-generic-check-word-predicate when applying fboundp on it. This avoids (wrong-type-argument symbolp) when flyspell-generic-check-word-predicate is a lambda. --- lisp/textmodes/flyspell.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el index f7683d967905..f05624b55194 100644 --- a/lisp/textmodes/flyspell.el +++ b/lisp/textmodes/flyspell.el @@ -1097,8 +1097,8 @@ flyspell-word (flyspell-word (flyspell-get-word following)) start end poss word ispell-filter) (if (or (eq flyspell-word nil) - (and (fboundp flyspell-generic-check-word-predicate) - (not (funcall flyspell-generic-check-word-predicate)))) + (and (fboundp 'flyspell-generic-check-word-predicate) + (not (funcall flyspell-generic-check-word-predicate)))) t (progn ;; destructure return flyspell-word info list. @@ -1914,7 +1914,7 @@ flyspell-auto-correct-word ;; invoke the original binding of M-TAB, if that was recorded. (if (and (local-variable-p 'flyspell--prev-meta-tab-binding) (commandp flyspell--prev-meta-tab-binding t) - (fboundp flyspell-generic-check-word-predicate) + (fboundp 'flyspell-generic-check-word-predicate) (not (funcall flyspell-generic-check-word-predicate)) (equal (where-is-internal 'flyspell-auto-correct-word nil t) [?\M-\t])) -- 2.11.0 From unknown Sat Jun 21 10:41:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25765: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is a lambda. Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Feb 2017 21:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25765 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Hong Xu Cc: 25765@debbugs.gnu.org Received: via spool by 25765-submit@debbugs.gnu.org id=B25765.14872810169862 (code B ref 25765); Thu, 16 Feb 2017 21:37:02 +0000 Received: (at 25765) by debbugs.gnu.org; 16 Feb 2017 21:36:56 +0000 Received: from localhost ([127.0.0.1]:42690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceTjU-0002Z0-2T for submit@debbugs.gnu.org; Thu, 16 Feb 2017 16:36:56 -0500 Received: from mail-ot0-f182.google.com ([74.125.82.182]:33691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceTjS-0002Yo-Op for 25765@debbugs.gnu.org; Thu, 16 Feb 2017 16:36:55 -0500 Received: by mail-ot0-f182.google.com with SMTP id k4so3905otc.0 for <25765@debbugs.gnu.org>; Thu, 16 Feb 2017 13:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=zkjqBEtTzUBYJOST2VCtcfr3rgrdelK3TsUr/CoBs2E=; b=M1hzIE0b9iPNMXAGDFQoB2UCIIUXsDzM7LeVFiiuyfmhQHpCld5KWYiZT51YuS8Rte EqD3VhH6L9KCeQHp3DVhfuUb/K/44ZlvFqH3hYz0YgTfgbSq/kpro45TuR0M/aCUaE06 8CyMejXi7MCtYW/fBxov1NBvbe4fiEtq9G79a5cBkHDtjTS4BdjWnEbJoaj0WBOlJInZ sny2ZRnNOpqR9TTPONrWDv2siokSH78SLXXFWc2MvlVDLFgOSXgkh/vwtjFMG52cBVlx mCFAsnpliqrprwqDDpW75tkLmYvyBOCg2I7OvhmUJQsdJTEoGl8uPWvVKYLtb0QzlSzL ENFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=zkjqBEtTzUBYJOST2VCtcfr3rgrdelK3TsUr/CoBs2E=; b=KY6qytkpUkDhPhgcnM/oqJsX1CEerDNif07liYd5N//eigDxTEAx09F1e4tRnOaQI1 lcNDHtHk5C9aVK1z7udSZHoYI/PgoKCz6ua33BES3la1ODZbYcRg1EVryA5rogUHnfsM apaa5GkSyVup1tK8HmYJ7LSoLJK7HiecG5WiHvpPvdR6vsfHUUFgMMDkx+NvMATqNs1G mTWbiSMMJSYoJvVyKw2XuoIBtGkEw3QTrK7gPIsD0u168bHJlOFAKbcExb2j7oITKlev seVND9ZPuznKKT3j6NJZKzO9dYRz25F1Vt2v42zqFoSZtTH7aO9vVDnBFPqrRq+mNtfa 9njQ== X-Gm-Message-State: AMke39knbYAN3OVQk10M4R3jlID1w4nQs4CvI8jwr2udCzmhCG2atdbchYA0a28PSWHv9GVcn4XVFk5Bp3jocA== X-Received: by 10.157.14.85 with SMTP id n21mr2815575otd.244.1487281008943; Thu, 16 Feb 2017 13:36:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.11.21 with HTTP; Thu, 16 Feb 2017 13:36:48 -0800 (PST) In-Reply-To: <20170216213026.5591-1-hong@topbug.net> References: <20170216213026.5591-1-hong@topbug.net> From: Noam Postavsky Date: Thu, 16 Feb 2017 16:36:48 -0500 X-Google-Sender-Auth: tQ3hpy79RTB-_1LBBdh67zaHnUw Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Thu, Feb 16, 2017 at 4:30 PM, Hong Xu wrote: > - (and (fboundp flyspell-generic-check-word-predicate) > - (not (funcall flyspell-generic-check-word-predicate)))) > + (and (fboundp 'flyspell-generic-check-word-predicate) > + (not (funcall flyspell-generic-check-word-predicate)))) > - (fboundp flyspell-generic-check-word-predicate) > + (fboundp 'flyspell-generic-check-word-predicate) I don't think that's the right fix, rather the fboundp should be replaced with functionp. From unknown Sat Jun 21 10:41:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25765: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is a lambda. Resent-From: Hong Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Feb 2017 22:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25765 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 25765@debbugs.gnu.org Received: via spool by 25765-submit@debbugs.gnu.org id=B25765.148728259412173 (code B ref 25765); Thu, 16 Feb 2017 22:04:02 +0000 Received: (at 25765) by debbugs.gnu.org; 16 Feb 2017 22:03:14 +0000 Received: from localhost ([127.0.0.1]:42702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceU8v-0003AH-OO for submit@debbugs.gnu.org; Thu, 16 Feb 2017 17:03:14 -0500 Received: from sender-of-o52.zoho.com ([135.84.80.217]:21354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceU8t-0003A6-EF for 25765@debbugs.gnu.org; Thu, 16 Feb 2017 17:03:12 -0500 Received: from localhost (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 148728258183412.66928469101913; Thu, 16 Feb 2017 14:03:01 -0800 (PST) References: <20170216213026.5591-1-hong@topbug.net> User-agent: mu4e 0.9.19; emacs 25.2.4 From: Hong Xu In-reply-to: Date: Thu, 16 Feb 2017 14:03:00 -0800 Message-ID: <877f4pg5ez.fsf@topbug.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Zoho-Virus-Status: 1 X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain On 2017-02-16 Thu 13:36 GMT-0800, Noam Postavsky wrote: > On Thu, Feb 16, 2017 at 4:30 PM, Hong Xu wrote: > > I don't think that's the right fix, rather the fboundp should be > replaced with functionp. I agree. I've attached a new version of this patch. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Avoid-errors-when-flyspell-generic-check-word-predic.patch Content-Transfer-Encoding: quoted-printable From=203011a0c7ce7ce2c505b663743c79915b18fd0404 Mon Sep 17 00:00:00 2001 From: Hong Xu Date: Thu, 16 Feb 2017 13:28:56 -0800 Subject: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is= a lambda. * flyspell.el (flyspell-auto-correct-word, flyspell-word): Apply functionp instead of fboundp on flyspell-generic-check-word-predicate. This avoids (wrong-type-argument symbolp) when flyspell-generic-check-word-predicate is a lambda. =2D-- lisp/textmodes/flyspell.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el index f7683d967905..fecfd2fc3ecb 100644 =2D-- a/lisp/textmodes/flyspell.el +++ b/lisp/textmodes/flyspell.el @@ -1097,8 +1097,8 @@ flyspell-word (flyspell-word (flyspell-get-word following)) start end poss word ispell-filter) (if (or (eq flyspell-word nil) =2D (and (fboundp flyspell-generic-check-word-predicate) =2D (not (funcall flyspell-generic-check-word-predicate)))) + (and (functionp flyspell-generic-check-word-predicate) + (not (funcall flyspell-generic-check-word-predicate)))) t (progn ;; destructure return flyspell-word info list. @@ -1914,7 +1914,7 @@ flyspell-auto-correct-word ;; invoke the original binding of M-TAB, if that was recorded. (if (and (local-variable-p 'flyspell--prev-meta-tab-binding) (commandp flyspell--prev-meta-tab-binding t) =2D (fboundp flyspell-generic-check-word-predicate) + (functionp flyspell-generic-check-word-predicate) (not (funcall flyspell-generic-check-word-predicate)) (equal (where-is-internal 'flyspell-auto-correct-word nil t) [?\M-\t])) =2D-=20 2.11.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEExhpJYaW1K1QSOB5eJmx9M4IvhHgFAlimIZQACgkQJmx9M4Iv hHhz2Q//VT8E1Qu+H3qEJc+0IU+EHTKdICO80u9reu3tzVrdyaU6NpowJg7lWY/r HmapTkxMaEPS/Qh6GJ8xz6uXe7lr3TSMg0nuSfaN4rNI60KbXSRtMtTbmjV5/2Tw TjSgARUJSVTRiW2Kq/UxYnA7hHZ0YYHl2kUNH36vSL4Zo4uWOaj4unrF6OrKwkyC ziVrU/++SaUQ/UQgp3ZZW1OKvk55ejExNNVwQGMlzQvoRf66lVqqIoZPyhRIk+12 ZXm5WHSPtybFcSDgx+KVZPnzMOt8DCDDygNe16qId/+R+QVs8Qdpfz4GcMN1p9Jz 83zOJg9AAJHYuxfj4OWjX2g54rqsODyFPomnNyzaoK0c/TNmQrNndthEmsS+lJoT kBEMQEbp2T+yWd0Y5Va9ZsOqbALKCQtH9bXkB4S8gxeea/rgtmcTNfoZQL+Ae8YO 2H0OQZ9IdhrHNpEhx4rppmfWqYNO5EYWKmsfKOYaZ2DcTyoxE1TIKf7sZyLuTM6T etOJBvnp7KZz/X91oUOiS0bCCu8niydLmc+T+VgaCTGjSzPsuLaIVDfw0A1uaCYn TQKmyPPJvvVnO9fhK7b3DupoJOgKpZMcX+iEuKmd39H8h04ittPIZTa1Nxe+CVgZ WfV1NgaI6WJsIbQ6PQ7A0+64lR4tweOOorqkBrZTgtlPnOGCevs= =zWe1 -----END PGP SIGNATURE----- --==-=-=-- From unknown Sat Jun 21 10:41:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25765: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is a lambda. Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2017 02:56:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25765 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Hong Xu Cc: 25765@debbugs.gnu.org Received: via spool by 25765-submit@debbugs.gnu.org id=B25765.14873865205350 (code B ref 25765); Sat, 18 Feb 2017 02:56:03 +0000 Received: (at 25765) by debbugs.gnu.org; 18 Feb 2017 02:55:20 +0000 Received: from localhost ([127.0.0.1]:44006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cevBA-0001O9-0h for submit@debbugs.gnu.org; Fri, 17 Feb 2017 21:55:20 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:36394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cevB7-0001Np-PM; Fri, 17 Feb 2017 21:55:18 -0500 Received: by mail-io0-f194.google.com with SMTP id q20so721544ioi.3; Fri, 17 Feb 2017 18:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/p/Ca7HVlhoNGWCFLE0ObykFXub99rRxBXgYzRVc2YY=; b=rr3mnt90wWkhFEJGNE/6h4dpxXfeTY34bqEW6r0Lwco+Bl2pyFmax1xNQ/1g+6xS3F koutRMKX5VREwgW+PsMzIgy4+SbZspJNeeA0h+PdRMtYSJ7wwxjHQegBxa9rn2Cpal6p MCVy5I8wr8K2LM+3t/KIlNMa81b3hefIgvJ/XGwapVh9YFF8z0QvenoxTtt1/BpLtdHJ q8WfYIFSZOJUx+ay7bjQQtRoIix+dyAIpQL+fHeeD4fHJw1SlqTUN3mXlvCYrBIPz86J FlQx+6XNP4fulbbI/ZEXHvB3fKUlGD4CM1hjz8twaIQQtNqFJzYtYBDocqH8bYcaV3QR u7vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/p/Ca7HVlhoNGWCFLE0ObykFXub99rRxBXgYzRVc2YY=; b=YRyS7IlWIvdnpqoNBmbU8eN3a7xQ0yg0E8iFipRDmF6HOPyV6VmzwvM89+h9TI8JvD T9f3NustJihkh89yRHmkv0LkJe9rtQcBqeWs1kjmvMbpFXF2jCwfQsHYbNRkU4M24sUn dMkLbx8skWMt1S4yts4NhF8fkwJSHQG0hZLNYou7W4DAGu0Tyuafk8CkNzlXe3nV6Eg2 lfeds35nvpKrqjv/YEnIH0YMCjj8lSf/36ExKgihPGyITHsGwL0bcFhzh3uINdsTLeF7 hWlolVyP4XveGhSnPG5bWAH/xGu+YwajmS7yHBLiS2qX7/DAe+BXwTyKZNMrdGEgXmx6 u6xQ== X-Gm-Message-State: AMke39n20Va0ecw5uh84RBezFGz3AB7UMp4id524X4vbQOVNwQx0UHMzixOfBfMWrveUqA== X-Received: by 10.107.59.148 with SMTP id i142mr10915732ioa.84.1487386512174; Fri, 17 Feb 2017 18:55:12 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id d128sm1482708ite.23.2017.02.17.18.55.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Feb 2017 18:55:11 -0800 (PST) From: npostavs@users.sourceforge.net References: <20170216213026.5591-1-hong@topbug.net> <877f4pg5ez.fsf@topbug.net> Date: Fri, 17 Feb 2017 21:56:22 -0500 In-Reply-To: <877f4pg5ez.fsf@topbug.net> (Hong Xu's message of "Thu, 16 Feb 2017 14:03:00 -0800") Message-ID: <87y3x4jjft.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) tags 25765 fixed close 25765 26.1 # With this patch, new checks can be added via add-function close 3425 26.1 quit Hong Xu writes: > On 2017-02-16 Thu 13:36 GMT-0800, Noam Postavsky wrote: > >> On Thu, Feb 16, 2017 at 4:30 PM, Hong Xu wrote: >> >> I don't think that's the right fix, rather the fboundp should be >> replaced with functionp. > > I agree. I've attached a new version of this patch. > Thanks, pushed to master [1: a83b66923c]. 1: 2017-02-17 21:50:46 -0500 a83b66923cfb71bb477d7a1f426f7426f91917da Avoid errors when flyspell-generic-check-word-predicate is a lambda. From unknown Sat Jun 21 10:41:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25765: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is a lambda. Resent-From: Hong Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2017 03:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25765 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: npostavs@users.sourceforge.net Cc: 25765@debbugs.gnu.org Received: via spool by 25765-submit@debbugs.gnu.org id=B25765.148738848714947 (code B ref 25765); Sat, 18 Feb 2017 03:29:02 +0000 Received: (at 25765) by debbugs.gnu.org; 18 Feb 2017 03:28:07 +0000 Received: from localhost ([127.0.0.1]:44027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cevgt-0003t0-DD for submit@debbugs.gnu.org; Fri, 17 Feb 2017 22:28:07 -0500 Received: from sender-of-o52.zoho.com ([135.84.80.217]:21323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cevgr-0003sr-AS for 25765@debbugs.gnu.org; Fri, 17 Feb 2017 22:28:05 -0500 Received: from [10.0.0.15] (c-73-189-92-90.hsd1.ca.comcast.net [73.189.92.90]) by mx.zohomail.com with SMTPS id 1487388475216750.4207891333614; Fri, 17 Feb 2017 19:27:55 -0800 (PST) References: <20170216213026.5591-1-hong@topbug.net> <877f4pg5ez.fsf@topbug.net> <87y3x4jjft.fsf@users.sourceforge.net> From: Hong Xu Message-ID: <1de355f9-15ec-d6e7-a532-99075a5e6424@topbug.net> Date: Fri, 17 Feb 2017 19:27:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <87y3x4jjft.fsf@users.sourceforge.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2oWo6brP4GWjQVM65tXODDRWVj5pEkDfl" X-Zoho-Virus-Status: 1 X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2oWo6brP4GWjQVM65tXODDRWVj5pEkDfl Content-Type: multipart/mixed; boundary="ts7JLPu73GfTH3q2JTfnHNg8tTG5AFKbt"; protected-headers="v1" From: Hong Xu To: npostavs@users.sourceforge.net Cc: 25765@debbugs.gnu.org Message-ID: <1de355f9-15ec-d6e7-a532-99075a5e6424@topbug.net> Subject: Re: bug#25765: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is a lambda. References: <20170216213026.5591-1-hong@topbug.net> <877f4pg5ez.fsf@topbug.net> <87y3x4jjft.fsf@users.sourceforge.net> In-Reply-To: <87y3x4jjft.fsf@users.sourceforge.net> --ts7JLPu73GfTH3q2JTfnHNg8tTG5AFKbt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/17/2017 06:56 PM, npostavs@users.sourceforge.net wrote: > tags 25765 fixed > close 25765 26.1 > # With this patch, new checks can be added via add-function > close 3425 26.1 > quit >=20 > Hong Xu writes: >=20 >> On 2017-02-16 Thu 13:36 GMT-0800, Noam Postavsky wrote: >> >>> On Thu, Feb 16, 2017 at 4:30 PM, Hong Xu wrote: >>> >>> I don't think that's the right fix, rather the fboundp should be >>> replaced with functionp. >> >> I agree. I've attached a new version of this patch. >> >=20 > Thanks, pushed to master [1: a83b66923c]. >=20 > 1: 2017-02-17 21:50:46 -0500 a83b66923cfb71bb477d7a1f426f7426f91917da > Avoid errors when flyspell-generic-check-word-predicate is a lambda. >=20 Is it possible to back port this fix to the emacs-25 branch? Looks like this bug was introduced in 6d11f6ed9a1afa6f3903fffeb58159beedeb1d14 which is new in Emacs 25. --ts7JLPu73GfTH3q2JTfnHNg8tTG5AFKbt-- --2oWo6brP4GWjQVM65tXODDRWVj5pEkDfl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEExhpJYaW1K1QSOB5eJmx9M4IvhHgFAlinvzkACgkQJmx9M4Iv hHiNSRAAsDWu8CWubiezApEc1LEJOTsR8BbWNE7TnUYFle7YLC70Yo9e+68rpRiE LOEi+rxmiIjrOYhIIJHW5JVpAMBm63nznh04qN1fxUTmjiwrlSCpaw09c+2dJNl6 Azwj5qFgi1tx0wlX520Y+CxQpfiuj4wtSK/KUeDHFbvNoPYVqTvV6jSwsG7cq5cy FZh4j09Ih9lf9S5Neu/fQj+EyqqdCLjyrmtDF2ywDeWebucD6oH25LUgxQT7p8Ib nVh59aGWIQjbVBMnktG3qDdkbMyT1q8xFjBBOhAbmEFv/l7Vat+m1SwiMQqRBC1c pwH6Xpam7sYt0ZD9HAy5I8EyY4sIho0OJSsNT9gdQvfWfjgR/2JH9tPwNr4b87Qd oh7PIAHcNtB7ImYcmPuexbjmvFbSeq3jQLqrRwTkgpTT13atbLh/tmAHM9Ma46Ot soAGTlQl2D0yOH0389BrqaEYElJVgCRu+YCMhQjUTnfkYrJHp7tdiSMifl1mzTlq 8NdIsUdQyIaEImOODGkVlELxEjhp7CHAlSaeLbHUG3z+qkTtnTDt9zax1FOlCP+z WdFjAIr7vzpHlmH7ch6DiQ8AlqjHDXNUeKtewxg5fky3lXdhwrpORgbk+XRdzBNm GuOVW0rIdrI6wdE1rjwtGzl4Mco2kzQG8DPWHQX+tvFM1yi1/c4= =MeRN -----END PGP SIGNATURE----- --2oWo6brP4GWjQVM65tXODDRWVj5pEkDfl-- From unknown Sat Jun 21 10:41:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25765: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is a lambda. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2017 08:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25765 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Hong Xu Cc: 25765@debbugs.gnu.org, npostavs@users.sourceforge.net Reply-To: Eli Zaretskii Received: via spool by 25765-submit@debbugs.gnu.org id=B25765.14874061858727 (code B ref 25765); Sat, 18 Feb 2017 08:24:01 +0000 Received: (at 25765) by debbugs.gnu.org; 18 Feb 2017 08:23:05 +0000 Received: from localhost ([127.0.0.1]:44122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf0IL-0002Gg-2F for submit@debbugs.gnu.org; Sat, 18 Feb 2017 03:23:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf0IJ-0002G1-Ow for 25765@debbugs.gnu.org; Sat, 18 Feb 2017 03:23:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf0IA-00017Z-QB for 25765@debbugs.gnu.org; Sat, 18 Feb 2017 03:22:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf0IA-00017V-MZ; Sat, 18 Feb 2017 03:22:54 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4552 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cf0I9-0001h0-Rz; Sat, 18 Feb 2017 03:22:54 -0500 Date: Sat, 18 Feb 2017 10:23:23 +0200 Message-Id: <83k28nrjpg.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <1de355f9-15ec-d6e7-a532-99075a5e6424@topbug.net> (message from Hong Xu on Fri, 17 Feb 2017 19:27:50 -0800) References: <20170216213026.5591-1-hong@topbug.net> <877f4pg5ez.fsf@topbug.net> <87y3x4jjft.fsf@users.sourceforge.net> <1de355f9-15ec-d6e7-a532-99075a5e6424@topbug.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Hong Xu > Date: Fri, 17 Feb 2017 19:27:50 -0800 > Cc: 25765@debbugs.gnu.org > > > 1: 2017-02-17 21:50:46 -0500 a83b66923cfb71bb477d7a1f426f7426f91917da > > Avoid errors when flyspell-generic-check-word-predicate is a lambda. > > > > Is it possible to back port this fix to the emacs-25 branch? Looks like > this bug was introduced in 6d11f6ed9a1afa6f3903fffeb58159beedeb1d14 > which is new in Emacs 25. Sorry, no. It's too late for that: the emacs-25 branch is in deep freeze now. From unknown Sat Jun 21 10:41:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25765: [PATCH] Avoid errors when flyspell-generic-check-word-predicate is a lambda. Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2017 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25765 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Eli Zaretskii Cc: 25765@debbugs.gnu.org, Hong Xu Received: via spool by 25765-submit@debbugs.gnu.org id=B25765.148742481511656 (code B ref 25765); Sat, 18 Feb 2017 13:34:01 +0000 Received: (at 25765) by debbugs.gnu.org; 18 Feb 2017 13:33:35 +0000 Received: from localhost ([127.0.0.1]:44343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf58p-00031w-Dn for submit@debbugs.gnu.org; Sat, 18 Feb 2017 08:33:35 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:33058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf58o-00031j-34 for 25765@debbugs.gnu.org; Sat, 18 Feb 2017 08:33:34 -0500 Received: by mail-it0-f66.google.com with SMTP id e137so6210880itc.0 for <25765@debbugs.gnu.org>; Sat, 18 Feb 2017 05:33:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=t/56LWYCZK4W/R+hALmkYI1CvxgpVi6aw7IJjCPMBuQ=; b=A5FHGi7VBJ6yBockHkHmDRaOs8p6fxB3by/Fx+yPd6WLps6k5wnD5Y18Xs/+0H0Oi3 ao5MasJDuLPk6DDDav7FkC22nBXt3GPMmL2cjp9NgCloDd7owul1SL7s4LME+2WuIF5p W+OujKM49mte8r7WiuEZFdlgbcXO22Uj15MAwf97u40UutUi9rIccGE0Ql7jw87sENif Uh8JeTFMqzxmH5FnGgbHg89C964hKDnZdft8pdVcyVH8xQiJ9Hg9JNQte7toYJVh5V6t OkM1pPYW5sILFNtYv2QwhrRXpCfXcFy7Ir/cmF5vcqHb/MlA4ZE/zRHsUqNUsZoOJnaR 8f+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=t/56LWYCZK4W/R+hALmkYI1CvxgpVi6aw7IJjCPMBuQ=; b=Tm6SXzZzpnNDIboFXhXxVdKFNxx60mAt3hPskpqxm6vRQRtb00AyhQ4N5cVRojgqqE lZvhOiIPgZsnMwN9zUeA/ANt+svCSQ4n2XcccX22iOGxF2ffYH2EYRGGhPugwxWcBT7E 9M3ZMM/aiHnsVCLjvNBHrVlm99ZsZjUicPhbFrOJgB2sfDCbovzE6SedHCB9hhDQ20bu XaBzVHDYIL+isp6jA5nWsBWmQH/k6k9adD4QvJCWwSyXvSHTknJkmCItTZGTYZ2Ny5Vo 0Ga74PPHiJBvC4qArMkJGfYND10kI2AKLadnh6QyyvEeI7tYgawDD0ZvizXbTielG8A9 J+WQ== X-Gm-Message-State: AMke39kBSLLpxzFG7z6PQCQpwDRCShDJlzqzOykpiXVN9QXdckQcdnzG87zXP5I8pyeUTA== X-Received: by 10.36.241.15 with SMTP id c15mr10088421iti.77.1487424808411; Sat, 18 Feb 2017 05:33:28 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id x128sm2218132ite.11.2017.02.18.05.33.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Feb 2017 05:33:27 -0800 (PST) From: npostavs@users.sourceforge.net References: <20170216213026.5591-1-hong@topbug.net> <877f4pg5ez.fsf@topbug.net> <87y3x4jjft.fsf@users.sourceforge.net> <1de355f9-15ec-d6e7-a532-99075a5e6424@topbug.net> <83k28nrjpg.fsf@gnu.org> Date: Sat, 18 Feb 2017 08:34:39 -0500 In-Reply-To: <83k28nrjpg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Feb 2017 10:23:23 +0200") Message-ID: <87vas7k4gg.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Eli Zaretskii writes: >> >> Is it possible to back port this fix to the emacs-25 branch? Looks like >> this bug was introduced in 6d11f6ed9a1afa6f3903fffeb58159beedeb1d14 >> which is new in Emacs 25. > > Sorry, no. It's too late for that: the emacs-25 branch is in deep > freeze now. Also, only the instance in `flyspell-auto-correct-word' was introduced in Emacs 25; the other case in `flyspell-word' goes back to the original revision of flyspell.el in 1998 [1: 60371a2e3d], when the variable was still called `flyspell-generic-check-word-p'. 1: 1998-06-26 01:24:05 +0000 60371a2e3d30618c3f65a5d1c83a9e4c99ee95a2 Initial revision