Subject: bug#25746: python-pykka

From: ng0 <[email-masked]>
Date: Sat, 18 Feb 2017 20:20:51 +0000

On 17-02-18 14:24:40, Ricardo Wurmus wrote:
> 
> ng0 <[email-masked]> writes:
> 
> >>From 5f04445d95ac22a98eb80038f6e087218f3cf369 Mon Sep 17 00:00:00 2001
> > From: ng0 <[email-masked]>
> > Date: Mon, 17 Oct 2016 10:30:58 +0000
> > Subject: [PATCH] gnu: Add python-pykka.
> >
> > * gnu/packages/python.scm (python-pykka): New variable.
> > ---
> >  gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 3e59b5892..875149b74 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -2614,6 +2614,32 @@ somewhat intelligeble.")
> >  (define-public python2-pyjwt
> >    (package-with-python2 python-pyjwt))
> >  
> > +(define-public python-pykka
> > +  (package
> > +    (name "python-pykka")
> > +    (version "1.2.1")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (pypi-uri "Pykka" version))
> > +       (sha256
> > +        (base32
> > +         "049w3r0mdnnw7xv19jiq7rvls9k7xs73x05b4qs5d6z4vvmgyiz8"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:tests? #f)) ; Testsuite fails for unspecified reasons.
> 
> It would be nice to have some more details here and a FIXME, so that
> dedicated folks could fix this in the future.

I think it's safe to use a git checkout. No new features are being
added, it's being used in mopydi so an community of interest keeps it
alive, and one of the commits which happened this year - the first ones
after 2 years pause - looks like it fixes tests.
I'll give it a try.

> > +    (home-page "https://www.pykka.org/")
> > +    (synopsis "Pykka is a Python implementation of the actor model")
> > +    (description
> > +     "Pykka is a Python implementation of the actor model.
> > +The actor model introduces some simple rules to control the sharing
> > +of state and cooperation between execution units, which makes it
> > +easier to build concurrent applications.")
> > +    (license license:asl2.0)))
> > +
> > +(define-public python2-pykka
> > +  (package-with-python2 python-pykka))
> > +
> 
> Other than that the patch looks fine to me.  Could you provide a more
> detailed explanation about the test failures?  Do all tests fail or just
> some?  Any idea why they might fail?  Do they only fail when built by
> Guix or also when building outside of a container?
> 
> -- 
> Ricardo
> 
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
> 

-- 
ng0 -- https://www.inventati.org/patternsinthechaos/