From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 07:39:06 2017 Received: (at submit) by debbugs.gnu.org; 15 Feb 2017 12:39:06 +0000 Received: from localhost ([127.0.0.1]:40566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdyrR-0001lo-Be for submit@debbugs.gnu.org; Wed, 15 Feb 2017 07:39:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdyrO-0001lK-AR for submit@debbugs.gnu.org; Wed, 15 Feb 2017 07:39:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdyrG-0001Po-Qa for submit@debbugs.gnu.org; Wed, 15 Feb 2017 07:38:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39087) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cdyrG-0001Pk-Me for submit@debbugs.gnu.org; Wed, 15 Feb 2017 07:38:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdyrE-0006eV-5N for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2017 07:38:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdyrB-0001O4-0G for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2017 07:38:52 -0500 Received: from gproxy5-pub.mail.unifiedlayer.com ([67.222.38.55]:36356) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cdyrA-0001K5-DN for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2017 07:38:48 -0500 Received: (qmail 1262 invoked by uid 0); 15 Feb 2017 12:38:20 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy5.mail.unifiedlayer.com with SMTP; 15 Feb 2017 12:38:20 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id l0eD1u00F2f2jeq010eGnX; Wed, 15 Feb 2017 05:38:20 -0700 X-Authority-Analysis: v=2.1 cv=WOnsABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=_NpvBJfKvnEJmQqnAQMA:9 a=zstS-IiYAAAA:8 a=InLSWUeIaYrVHlJ8b3kA:9 a=VDEtfpoToLGKPWCa6wMA:9 a=ovvi8dDwEox7_VyI:21 a=Uvb9elCZNY_RHsGv:21 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AViAvTbPMHBPUdLilcj0RFbWFTuCiu2wnjse4f3GCuI=; b=G1c3B/67Nkt5PGiakdSmzRz/IF kQjv+OXy1ldDfxJx0M5smJ5M9tzK4BKCfi0S/KZZmWeYJYT5aR703tFt2h6/Xdfiq3ZOiW6Y6Gd1q ng/0x/VwYRArWc7UqsA8lhEgV; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:36712 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cdyqa-00073J-Uk; Wed, 15 Feb 2017 05:38:13 -0700 From: Tom Tromey To: bug-gnu-emacs@gnu.org Subject: 25.1.91; vc-git-log-{incoming,outgoing} fixes X-Attribution: Tom Date: Wed, 15 Feb 2017 05:38:04 -0700 Message-ID: <87tw7vy6hf.fsf@tromey.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1cdyqa-00073J-Uk X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:36712 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) --=-=-= Content-Type: text/plain Yesterday I discovered the useful vc-log-outgoing command. It isn't conveniently bound in vc-dir mode, so I added a binding. But then I discovered a couple of bugs in the git back end; and then later discovered that the same bugs affect vc-git-log-incoming. First, vc-git-log-incoming and vc-git-log-outgoing can be called with a nil value for remote-location. In this case nothing shows up in the log. Changing the code to treat nil the same as the empty string makes the commands show the data I would expect. Next, these commands move point to the end of the new buffer. However, that is weird, because then the buffer is shrunk to fit; for me this ends up making it look like I have just a single outgoing patch, even when I have several. Changing these functions to pass 'async to vc-git-command fixes this. Finally, vc-git-log-view-mode only sets truncate-lines in some situations; I have changed it to also set it for log-outgoing and log-incoming, which makes the output of these commands more closely resemble the output of vc-print-log. Tom --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=P Content-Description: patch commit 08468554243b048ce408ff7b4fd8543abecaa4c5 Author: Tom Tromey Date: Wed Feb 15 05:12:18 2017 -0700 vc-log-outgoing fixes for git; add binding to vc-dir * lisp/vc/vc-dir.el (vc-dir-mode-map): Bind "O" to vc-log-outgoing. * lisp/vc/vc-git.el (vc-git-log-outgoing, vc-git-log-incoming): Handle remote-location being nil. Use 'async. (vc-git-log-view-mode): Also truncate lines for log-outgoing and log-incoming. more diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el index 5374f1c..532bad1 100644 --- a/lisp/vc/vc-dir.el +++ b/lisp/vc/vc-dir.el @@ -255,6 +255,7 @@ vc-dir-mode-map (define-key map "l" 'vc-print-log) ;; C-x v l (define-key map "L" 'vc-print-root-log) ;; C-x v L (define-key map "I" 'vc-log-incoming) ;; C-x v I + (define-key map "O" 'vc-log-outgoing) ;; C-x v O ;; More confusing than helpful, probably ;;(define-key map "R" 'vc-revert) ;; u is taken by vc-dir-unmark. ;;(define-key map "A" 'vc-annotate) ;; g is taken by revert-buffer diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 0c11a7f..be471c3 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -972,12 +972,12 @@ vc-git-print-log (defun vc-git-log-outgoing (buffer remote-location) (interactive) (vc-git-command - buffer 0 nil + buffer 'async nil "log" "--no-color" "--graph" "--decorate" "--date=short" (format "--pretty=tformat:%s" (car vc-git-root-log-format)) "--abbrev-commit" - (concat (if (string= remote-location "") + (concat (if (or (not remote-location) (string= remote-location "")) "@{upstream}" remote-location) "..HEAD"))) @@ -986,12 +986,12 @@ vc-git-log-incoming (interactive) (vc-git-command nil 0 nil "fetch") (vc-git-command - buffer 0 nil + buffer 'async nil "log" "--no-color" "--graph" "--decorate" "--date=short" (format "--pretty=tformat:%s" (car vc-git-root-log-format)) "--abbrev-commit" - (concat "HEAD.." (if (string= remote-location "") + (concat "HEAD.." (if (or (not remote-location) (string= remote-location "")) "@{upstream}" remote-location)))) @@ -1011,7 +1011,7 @@ vc-git-log-view-mode (cadr vc-git-root-log-format) "^commit *\\([0-9a-z]+\\)")) ;; Allow expanding short log entries. - (when (eq vc-log-view-type 'short) + (when (memq vc-log-view-type '(short log-outgoing log-incoming)) (setq truncate-lines t) (set (make-local-variable 'log-view-expanded-log-entry-function) 'vc-git-expanded-log-entry)) --=-=-= Content-Type: text/plain In GNU Emacs 25.1.91.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.7) of 2017-02-02 built on bapiya Repository revision: 7e02a477bbcabb4e65aeecade79b67357c0b9dae Windowing system distributor 'Fedora Project', version 11.0.11901000 System Description: Fedora release 25 (Twenty Five) Configured using: 'configure --prefix=/home/tromey/Emacs/install/ --with-modules' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t diff-auto-refine-mode: t flyspell-mode: t which-function-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t Recent messages: Running git --no-pager diff-index --relative -z -M HEAD -- lisp/vc/vc-git.el in background... done Running git --no-pager ls-files -z -c -s -- lisp/vc/vc-git.el in background... done Running git --no-pager log --no-color --graph --decorate --date=short --... --abbrev-commit -n 2000 -- ./ in background... done Finding changes in /home/tromey/Emacs/trunk/... Running git --no-pager diff-tree --exit-code -p 18... 0846855 -- ./...OK = 1 Running git --no-pager log 0846855 -1 -- . in foreground... Running git --no-pager log 0846855 -1 -- ....OK = 0 Finding changes in /home/tromey/Emacs/trunk/... Running git --no-pager diff-tree --exit-code -p 18... 0846855 -- ./...OK = 1 C-x C-g is undefined Load-path shadows: /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.1.91/lisp/play/bubbles Features: (highlight-refontification tabify man shadow emacsbug conf-mode two-column iso-transl perl-mode sh-script executable cal-move nnregistry python tramp-sh tramp tramp-compat tramp-loaddefs trampver ucs-normalize make-mode etags cursor-sensor mhtml-mode org-bullets org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs gnus-fun gnus-draft noutline outline ido skeleton css-mode smie eww url-queue trace find-dired descr-text gdb-shell lisp-mnt url-handlers url-http url-gw url-auth lex edebug debug m4-mode bbdb-sc supercite regi xref project log-edit js json map sgml-mode flow-fill gnus-html xml url-cache mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf eieio-opt speedbar sb-image ezimage dframe find-func whitespace tcl log-view pcvs-util vc-annotate term/xterm xterm smerge-mode goto-addr shell find-file idutils derived bug-reference cc-mode cc-fonts cc-guess cc-menus cc-cmds jka-compr mailalias mail-hist nnir sort gnus-cite smiley shr-color url-util url-parse url-vars shr dom subr-x browse-url mm-archive gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-mua bbdb-com crm network-stream nsm starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-compat eieio-base gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader bbdb-message sendmail mail-extr message idna dired rfc822 mml mml-sec epg mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader gud dwarf-mode copyright dabbrev misearch multi-isearch vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs add-log rx vc-git diff-mode easy-mmode rust-mode flyspell ispell diminish edmacro kmacro projectile grep compile ibuf-ext ibuffer dash appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu minimap autorevert filenotify cus-start cus-load status erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec auth-source eieio gnus-util mm-util help-fns mail-prsvr password-cache thingatpt pp warnings advice vc-dir ewoc vc vc-dispatcher cc-styles cc-align cc-engine cc-vars cc-defs bbdb bbdb-site timezone ange-ftp comint ansi-color ring server savehist finder-inf dwarf-mode-autoloads gdb-shell-autoloads eieio-core lisppaste-autoloads pydoc-info-autoloads info-look cl-seq cl-macs cl weblogger-autoloads info package epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib bbdb-loaddefs time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 2750314 537335) (symbols 48 139907 709) (miscs 40 34395 10086) (strings 32 583581 192504) (string-bytes 1 17328869) (vectors 16 139544) (vector-slots 8 2879816 108437) (floats 8 950 1483) (intervals 56 342103 9442) (buffers 976 380)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 05:49:01 2017 Received: (at 25737) by debbugs.gnu.org; 16 Feb 2017 10:49:01 +0000 Received: from localhost ([127.0.0.1]:41728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceJcS-0002R3-SR for submit@debbugs.gnu.org; Thu, 16 Feb 2017 05:49:01 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:36783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceJcR-0002Qq-4u for 25737@debbugs.gnu.org; Thu, 16 Feb 2017 05:48:59 -0500 Received: by mail-wm0-f53.google.com with SMTP id c85so63080378wmi.1 for <25737@debbugs.gnu.org>; Thu, 16 Feb 2017 02:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/k79W/TfN59AwkyzS9przEeF3Bz6XBfK6VL+9OveehM=; b=M0H+YxUmiiyJ6GtTgxuXtkuCfyPj2ETGvjKknRm5O7b2xa7lRWuUNoJbn3UwL/mKBq iQIRHxsW33TlwQPEz769X4B1KqYYk5QeoGwGvzIaKRNH2mLDlPhOy3OSwGPifrFFak4W 9he3nHfcciUGX+lANg6yQvQK8nQmFtUQJgHNfqKpxtIoWGhtpYY8ABRUKJaDsybHJn13 MXz5XoEifxg9wXVpciZ0Rk45p/cmfxyYawozc+WP0ERGAujYciKdgSnIIjQLF8EQx6Ii vXh7s11QswaH+2x1d9R2RZsdOulF080V1RUTPj3x8cDiyOIhkm2EL2yt1t2DhnCVIPkT b8tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/k79W/TfN59AwkyzS9przEeF3Bz6XBfK6VL+9OveehM=; b=R7BYMWRwFSbZg/j0IWtAMzaW0Zftv3iRz3l8fLhU9xt7NOSwQ9R1RS4e9x+FNAKQWO YYXExNbuicOpjB+odH44Mlaa1iZ0/ldlJzKmuSPwoEI5x1YjsQly8L7osHXMm+ZiaSGQ IgWiNhAOzrU9NJRY0z35gO2UvrbBXpPYEvicS4fcTV3MAGngoT5ocTdsZm9ScNrw1Q7x Id3wTAIU5EkUPcEj16S4MpJwTJ17OChoSWpQ1SZpLDDA2yomUfFpthQEowBR3dyTOXyp 5JwhsSXrKcBKb7u7cA0+OAuuUfKzWKqcVKZ9qpNm7iLtwWIEN0DdsnstOW38UND0M2TE BwWQ== X-Gm-Message-State: AMke39m7VgvJnAQSCHvb/DA+oB08DnWDpsjbqxJF6bPfdEj7zLmv6htnqnk9PlSJm69rLQ== X-Received: by 10.28.209.202 with SMTP id i193mr1981335wmg.20.1487242132986; Thu, 16 Feb 2017 02:48:52 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id l37sm8494303wrc.41.2017.02.16.02.48.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 02:48:52 -0800 (PST) Subject: Re: bug#25737: 25.1.91; vc-git-log-{incoming,outgoing} fixes To: Tom Tromey , 25737@debbugs.gnu.org References: <87tw7vy6hf.fsf@tromey.com> From: Dmitry Gutov Message-ID: Date: Thu, 16 Feb 2017 12:48:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87tw7vy6hf.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25737 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 15.02.2017 14:38, Tom Tromey wrote: > > Yesterday I discovered the useful vc-log-outgoing command. It isn't > conveniently bound in vc-dir mode, so I added a binding. But then I > discovered a couple of bugs in the git back end; and then later > discovered that the same bugs affect vc-git-log-incoming. Thanks. > First, vc-git-log-incoming and vc-git-log-outgoing can be called with a > nil value for remote-location. In this case nothing shows up in the > log. Changing the code to treat nil the same as the empty string makes > the commands show the data I would expect. Do you know when they get called with ""? Should we maybe just change the callers to always use one or the other value? > Next, these commands move point to the end of the new buffer. However, > that is weird, because then the buffer is shrunk to fit; for me this > ends up making it look like I have just a single outgoing patch, even > when I have several. Any ideas why that happens? I can see point ending up at eob when the call is synchronous, but that doesn't affect the shrinking behavior much (e.g. I have 13 lines, the window shrinks correctly but hides the first line because the cursor is after the last line, and it has to be visible). I've only tested this in vc-log-incoming, however. > Changing these functions to pass 'async to > vc-git-command fixes this. I don't mind, but it would be great to know the underlying reasons for the problems. And we have a somewhat similar bug with vc-print-root-log, too (point jumps to the end when the log is small enough or something). > Finally, vc-git-log-view-mode only sets truncate-lines in some > situations; I have changed it to also set it for log-outgoing and > log-incoming, which makes the output of these commands more closely > resemble the output of vc-print-log. Sounds good. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 23:01:56 2017 Received: (at 25737) by debbugs.gnu.org; 17 Feb 2017 04:01:56 +0000 Received: from localhost ([127.0.0.1]:42911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceZk3-0001Us-Vd for submit@debbugs.gnu.org; Thu, 16 Feb 2017 23:01:56 -0500 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:58487 helo=gproxy9.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceZk1-0001Uf-Au for 25737@debbugs.gnu.org; Thu, 16 Feb 2017 23:01:54 -0500 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id 06C7D1E081E for <25737@debbugs.gnu.org>; Thu, 16 Feb 2017 21:01:43 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id lg1f1u00j2f2jeq01g1iB2; Thu, 16 Feb 2017 21:01:42 -0700 X-Authority-Analysis: v=2.1 cv=U+QBU4bu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=vaJtXVxTAAAA:8 a=Iz3CGIO2A74E76TfbT8A:9 a=hCt-GehETBxEYQOojhlW:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=t7Af538LxPPk/FHVk4E5+yRfIbP5zOm3n2IHL41PWPE=; b=XXpqoIg3bPSPFaMbHrPsmNHPhm KucL/F+L8REJMqk8Y9BsgPHJvekE5Im9w428cO8TQsJ3JFzOlGDRJRWoLeWjWt11RfpxijiCYXEH1 VCuZQ2YCOoVkvh9BHVQwF+n3O; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:47362 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1ceZjl-00074B-QS; Thu, 16 Feb 2017 21:01:37 -0700 From: Tom Tromey To: Dmitry Gutov Subject: Re: bug#25737: 25.1.91; vc-git-log-{incoming,outgoing} fixes References: <87tw7vy6hf.fsf@tromey.com> X-Attribution: Tom Date: Thu, 16 Feb 2017 21:01:34 -0700 In-Reply-To: (Dmitry Gutov's message of "Thu, 16 Feb 2017 12:48:51 +0200") Message-ID: <87poihxy75.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1ceZjl-00074B-QS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:47362 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 25737 Cc: Tom Tromey , 25737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >>>>> "Dmitry" == Dmitry Gutov writes: >> First, vc-git-log-incoming and vc-git-log-outgoing can be called with a >> nil value for remote-location. In this case nothing shows up in the >> log. Changing the code to treat nil the same as the empty string makes >> the commands show the data I would expect. Dmitry> Do you know when they get called with ""? vc-log-outgoing does: (interactive (when current-prefix-arg (list (read-string "Remote location (empty for default): ")))) So a prefix argument followed by pressing enter. Dmitry> Should we maybe just change the callers to always use one or the other Dmitry> value? Seems reasonable, I'll change vc-log-outgoing. >> Next, these commands move point to the end of the new buffer. However, >> that is weird, because then the buffer is shrunk to fit; for me this >> ends up making it look like I have just a single outgoing patch, even >> when I have several. Dmitry> Any ideas why that happens? I can see point ending up at eob when the Dmitry> call is synchronous, but that doesn't affect the shrinking behavior Dmitry> much (e.g. I have 13 lines, the window shrinks correctly but hides the Dmitry> first line because the cursor is after the last line, and it has to be Dmitry> visible). Dmitry> I've only tested this in vc-log-incoming, however. There are two pieces. As you say, point ends up at eob due to vc-do-command using process-file in the synchronous case; whereas for the async case, vc-process-filter uses save-excursion. The other behavior seems to be a problem in shrink-window-if-larger-than-buffer. I can reproduce it easily just with any buffer by moving point to the end. I didn't debug this any further than finding that. Tom From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 23:05:24 2017 Received: (at 25737) by debbugs.gnu.org; 17 Feb 2017 04:05:24 +0000 Received: from localhost ([127.0.0.1]:42915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceZnQ-0001Zp-HH for submit@debbugs.gnu.org; Thu, 16 Feb 2017 23:05:24 -0500 Received: from gproxy3-pub.mail.unifiedlayer.com ([69.89.30.42]:50021) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1ceZnN-0001Zb-PF for 25737@debbugs.gnu.org; Thu, 16 Feb 2017 23:05:22 -0500 Received: (qmail 20529 invoked by uid 0); 17 Feb 2017 04:05:09 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy3.mail.unifiedlayer.com with SMTP; 17 Feb 2017 04:05:09 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id lg551u00r2f2jeq01g58eX; Thu, 16 Feb 2017 21:05:09 -0700 X-Authority-Analysis: v=2.1 cv=WOnsABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=JwN7LXIaEhCnP4tFmLIA:9 a=zstS-IiYAAAA:8 a=UzXKR7sjjw8ZPaIhONkA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=USe5DwwubMhhkuiGe0654i+zxMdnwafAr9LtYouUlkw=; b=jRl88LJZ2mHWXVtUWZrXFoAU10 ShNMQHsfPwG0CnxuKtst+SHgnOUbRRmQT+C4PzuQyY4hLqu0kpeq5IgSzrvsn0cloNLVOQdKO0EIW XYwwWcgN0u79wtVWj1Sj/EBsc; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:47374 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1ceZn7-0001j5-Gp; Thu, 16 Feb 2017 21:05:05 -0700 From: Tom Tromey To: Dmitry Gutov Subject: Re: bug#25737: 25.1.91; vc-git-log-{incoming,outgoing} fixes References: <87tw7vy6hf.fsf@tromey.com> X-Attribution: Tom Date: Thu, 16 Feb 2017 21:05:04 -0700 In-Reply-To: (Dmitry Gutov's message of "Thu, 16 Feb 2017 12:48:51 +0200") Message-ID: <87lgt5xy1b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1ceZn7-0001j5-Gp X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:47374 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 25737 Cc: Tom Tromey , 25737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) --=-=-= Content-Type: text/plain Here's an updated patch. Tom --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=P Content-Description: updated patch commit 6427cf681a635b0a60c1b923b92ece4348eff250 Author: Tom Tromey Date: Wed Feb 15 05:12:18 2017 -0700 vc-log-outgoing fixes for git; add binding to vc-dir * lisp/vc/vc-dir.el (vc-dir-mode-map): Bind "O" to vc-log-outgoing. * lisp/vc/vc-git.el (vc-git-log-outgoing, vc-git-log-incoming): Use async execution. (vc-git-log-view-mode): Also truncate lines for log-outgoing and log-incoming. * lisp/vc/vc.el (vc-log-incoming, vc-log-outgoing): Don't pass nil as remote-location argument. diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el index 5374f1c..532bad1 100644 --- a/lisp/vc/vc-dir.el +++ b/lisp/vc/vc-dir.el @@ -255,6 +255,7 @@ vc-dir-mode-map (define-key map "l" 'vc-print-log) ;; C-x v l (define-key map "L" 'vc-print-root-log) ;; C-x v L (define-key map "I" 'vc-log-incoming) ;; C-x v I + (define-key map "O" 'vc-log-outgoing) ;; C-x v O ;; More confusing than helpful, probably ;;(define-key map "R" 'vc-revert) ;; u is taken by vc-dir-unmark. ;;(define-key map "A" 'vc-annotate) ;; g is taken by revert-buffer diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 0c11a7f..3546a17 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -972,7 +972,7 @@ vc-git-print-log (defun vc-git-log-outgoing (buffer remote-location) (interactive) (vc-git-command - buffer 0 nil + buffer 'async nil "log" "--no-color" "--graph" "--decorate" "--date=short" (format "--pretty=tformat:%s" (car vc-git-root-log-format)) @@ -986,7 +986,7 @@ vc-git-log-incoming (interactive) (vc-git-command nil 0 nil "fetch") (vc-git-command - buffer 0 nil + buffer 'async nil "log" "--no-color" "--graph" "--decorate" "--date=short" (format "--pretty=tformat:%s" (car vc-git-root-log-format)) @@ -1011,7 +1011,7 @@ vc-git-log-view-mode (cadr vc-git-root-log-format) "^commit *\\([0-9a-z]+\\)")) ;; Allow expanding short log entries. - (when (eq vc-log-view-type 'short) + (when (memq vc-log-view-type '(short log-outgoing log-incoming)) (setq truncate-lines t) (set (make-local-variable 'log-view-expanded-log-entry-function) 'vc-git-expanded-log-entry)) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 80166f6..23b8980 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2404,8 +2404,8 @@ vc-log-incoming (let ((backend (vc-deduce-backend))) (unless backend (error "Buffer is not version controlled")) - (vc-incoming-outgoing-internal backend remote-location "*vc-incoming*" - 'log-incoming))) + (vc-incoming-outgoing-internal backend (or remote-location "") + "*vc-incoming*" 'log-incoming))) ;;;###autoload (defun vc-log-outgoing (&optional remote-location) @@ -2417,8 +2417,8 @@ vc-log-outgoing (let ((backend (vc-deduce-backend))) (unless backend (error "Buffer is not version controlled")) - (vc-incoming-outgoing-internal backend remote-location "*vc-outgoing*" - 'log-outgoing))) + (vc-incoming-outgoing-internal backend (or remote-location "") + "*vc-outgoing*" 'log-outgoing))) ;;;###autoload (defun vc-region-history (from to) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 20:53:33 2017 Received: (at 25737) by debbugs.gnu.org; 20 Feb 2017 01:53:33 +0000 Received: from localhost ([127.0.0.1]:46689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfdAT-0008HT-E0 for submit@debbugs.gnu.org; Sun, 19 Feb 2017 20:53:33 -0500 Received: from mail-wr0-f176.google.com ([209.85.128.176]:36826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfdAS-0008HG-4k for 25737@debbugs.gnu.org; Sun, 19 Feb 2017 20:53:32 -0500 Received: by mail-wr0-f176.google.com with SMTP id 89so51385329wrr.3 for <25737@debbugs.gnu.org>; Sun, 19 Feb 2017 17:53:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CLbNC+CUSMJDoIsYWaTFQZZg1UjapeKx0K88PuXQYzE=; b=JsNIAVoFH0VtQG8zheXVqo7g6iabZU6T4egyDEVqGeUEnabjuZZU5dSs4hUYIW680f h136LcWSajvSY1CYpjtCXknhBOJf1B46Rf7D9b2Qki2skOa6eZHBz9dlEo5CEnUeVi93 LgRl1ZaGDE+HXV/L2svcDUjiZ2VvDppMJ63eozy9k2HHjfsibi+JPPRxPyLzzpkkMzD0 G3u5DECeIKKLP+9vY+KLIqIBSdGj9yZePaijXgyOiCpAq2/tL6tDeXIVWJgvvAkjJQCv pg89sCWvQeAVUWQxBJFIFPFisGHAOwPkqdJYzGUqA+KVEQb+QUYq0cuf+m1wDBYpxIhd I2Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CLbNC+CUSMJDoIsYWaTFQZZg1UjapeKx0K88PuXQYzE=; b=RA8wP9cBYvHLdiySjUudgpNqqljJRZQbbzi79QFX+nQkcCZMYun9ySBIAyr7PruLLv K/9NZIJORwFL426IJH6pfuBsUEgr8m6ZjcJrTK0CBhM5Jg6d35Yngl5RLFlpGr6EknKV 01UzBfvOsMPGzJuGqecOEfdUcEdP0cwKfqjtaY2gqwai+DP1vbZVUWceIX9sLzsq7/AX kIynLve4Vrzlx2F8En0H8zuaUMRdhIlPuyk03KI8Xa6NQjl7cAdImLmitTKvAmmH3Fw8 kMl6g5R8yYllcwfpZzYZRM2FhaYLtFPnS5KVbstgl2NVxOvWky/zthHRNLCDNK/6LeGv THvQ== X-Gm-Message-State: AMke39mvkR44pAWRTWIoM03H0TLV1sXKreHnU2PVGsfPcsMQEfCWH/VoOcENR6BGXh3MVw== X-Received: by 10.223.167.66 with SMTP id e2mr13378776wrd.48.1487555606399; Sun, 19 Feb 2017 17:53:26 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id q16sm22659109wra.69.2017.02.19.17.53.25 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sun, 19 Feb 2017 17:53:25 -0800 (PST) Subject: Re: bug#25737: 25.1.91; vc-git-log-{incoming,outgoing} fixes To: Tom Tromey References: <87tw7vy6hf.fsf@tromey.com> <87poihxy75.fsf@tromey.com> From: Dmitry Gutov Message-ID: <4da6d3e1-a57d-dad9-55db-e4549cf0d280@yandex.ru> Date: Mon, 20 Feb 2017 03:53:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87poihxy75.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 25737 Cc: 25737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On 17.02.2017 06:01, Tom Tromey wrote: > Dmitry> Do you know when they get called with ""? > > vc-log-outgoing does: > > (interactive > (when current-prefix-arg > (list (read-string "Remote location (empty for default): ")))) > > So a prefix argument followed by pressing enter. > > Dmitry> Should we maybe just change the callers to always use one or the other > Dmitry> value? > > Seems reasonable, I'll change vc-log-outgoing. Thanks. > As you say, point ends up at eob due to vc-do-command using process-file > in the synchronous case; whereas for the async case, vc-process-filter > uses save-excursion. Yes, and it's a problem we need to fix either way. > The other behavior seems to be a problem in > shrink-window-if-larger-than-buffer. I can reproduce it easily just > with any buffer by moving point to the end. I didn't debug this any > further than finding that. Might want to look into that sometime. I've tried that in different configurations, and 'M-x shrink-window-if-larger-than-buffer' doesn't do anything if the buffer is longer than the current window height. If it's shorter, the window gets shrunk appropriately, with only the off-by-one scrolling problem. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 20:54:08 2017 Received: (at 25737) by debbugs.gnu.org; 20 Feb 2017 01:54:08 +0000 Received: from localhost ([127.0.0.1]:46693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfdB2-0008Ig-Lo for submit@debbugs.gnu.org; Sun, 19 Feb 2017 20:54:08 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfdB0-0008I5-MN for 25737@debbugs.gnu.org; Sun, 19 Feb 2017 20:54:07 -0500 Received: by mail-wm0-f67.google.com with SMTP id u63so11838750wmu.2 for <25737@debbugs.gnu.org>; Sun, 19 Feb 2017 17:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VSeha9jBNT7wfMXEJp7L3n53QaAzU8dBvAOKVPWnQt8=; b=sjlZge7SLSSHY840QbpwMAy6d7gVB2ZuaCQE1Zn74GNW4CG7QgqUG6kwcphRNadHos ZZ7X4hrnYd8gG0aJOJ7ebZNq0CsT2iHlQzRnopv1Uh0iA8ucknwy19VWPUV1vAf5Y5WW /ctN6+KTd8GiuOZY9g2/xjSvLkZvYYIBMWGZzDVgAyTySSp4uhfeylzf8N7T6ix0IcEs ynutol8piZVIBNZ+i9V27QltnkNsFsKjsilStrBIR6VxREs/C4EQNuAJd0wAUJIomKP8 +qQ7VJVa8GTEvdF63R9hrFSYulYyUFYzeYsln/+5CfBV5Ze8sZq0lmZdwHHeAOgIx6hP az3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VSeha9jBNT7wfMXEJp7L3n53QaAzU8dBvAOKVPWnQt8=; b=cf89iotPlAnPapQqrrO1ZdZZDR5mFxpKMN2U1GFfmsp4OgF2rApx0ILx5ElnJGdNLH yFt15zmuzOs4k+b46d2yo6e7ollEPMfsGcuVVGmyPcbPXtkujLeTVnAEdVBpW0MIgxJO 5m2dHQ+eZrjfkoZlBQoa3fgwbUokoa/Bjw5OW28efw/Y3BxJFFnVCY2oJP1sWdoODh+l p98V/Zzeob5/beG/9Go/pb4aQtY602WMEhXTZLYo5TZPjfHjFo2XM0TTTPeYEGxlFGnP sNLkk0oYBApGeYcERElujQCNCsohcv1dZk3GfGaxRZgQiOzDVT390RbpOoI2DEno0EoY j0Iw== X-Gm-Message-State: AMke39kazd/0tXex7ba2UUMdgWLVZETyyzjPxjPlbKk+O14hQ9Der6QIfWsZuLRtcSKMHg== X-Received: by 10.28.71.220 with SMTP id m89mr14765051wmi.120.1487555640572; Sun, 19 Feb 2017 17:54:00 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id k195sm11450125wmd.7.2017.02.19.17.53.59 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sun, 19 Feb 2017 17:54:00 -0800 (PST) Subject: Re: bug#25737: 25.1.91; vc-git-log-{incoming,outgoing} fixes To: Tom Tromey References: <87tw7vy6hf.fsf@tromey.com> <87lgt5xy1b.fsf@tromey.com> From: Dmitry Gutov Message-ID: <4b2ebc9d-3a7d-f470-a871-ec3524a7e76b@yandex.ru> Date: Mon, 20 Feb 2017 03:53:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87lgt5xy1b.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25737 Cc: 25737@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On 17.02.2017 06:05, Tom Tromey wrote: > Here's an updated patch. Thanks. Please go ahead and install. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 23:03:40 2017 Received: (at 25737-done) by debbugs.gnu.org; 25 Feb 2017 04:03:40 +0000 Received: from localhost ([127.0.0.1]:55065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chTa8-0005Ao-AJ for submit@debbugs.gnu.org; Fri, 24 Feb 2017 23:03:40 -0500 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:60316 helo=gproxy9.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chTa6-0005Aa-AV for 25737-done@debbugs.gnu.org; Fri, 24 Feb 2017 23:03:38 -0500 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id A0D231E0E82 for <25737-done@debbugs.gnu.org>; Fri, 24 Feb 2017 21:03:32 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id os3V1u00T2f2jeq01s3YVQ; Fri, 24 Feb 2017 21:03:32 -0700 X-Authority-Analysis: v=2.1 cv=GtPRpCFC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=EFAK1vgnjBJ6Hpupy2MA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JbUA5w1sC8osch51ofxVHoHdnLz2qT61h6F6l3fefsk=; b=afoJs1OWcxMl0bEIB7DcJGQ16K 6T72mBPN7jFkpqWgSQmjjqDV8FkzPUBpbAfTolPOxdXgCpXwxOTF+VvobuFs7AXiXzh/zk+5QlCHV bYoM47ChUughBWbLVMXk54pqk; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:38982 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1chTZw-0004NA-Vn; Fri, 24 Feb 2017 21:03:29 -0700 From: Tom Tromey To: 25737-done@debbugs.gnu.org Subject: done X-Attribution: Tom Date: Fri, 24 Feb 2017 21:03:27 -0700 Message-ID: <87d1e6vrw0.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1chTZw-0004NA-Vn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:38982 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 25737-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) This is checked in. Tom From unknown Sat Aug 16 21:12:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 Mar 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator