Subject: bug#25733: [PATCH 12/18] gnu: Add python-docutils-0.11.

From: ng0 <[email-masked]>
Date: Sat, 18 Feb 2017 15:31:17 +0000

On 17-02-18 13:21:54, Ricardo Wurmus wrote:
> 
> [email-masked] writes:
> 
> > From: ng0 <[email-masked]>
> >
> > * gnu/packages/python.scm (python-docutils-0.11): New variable.
> > ---
> 
> […]
> 
> > +;; kallithea-0.3.2 needs this
> 
> I wonder: does Kallithea *really* need these particular versions or does
> it just have overly strict version checks?
> 
> > +(define-public python-docutils-0.11
> > +  (package
> > +    (inherit python-docutils)
> > +    (version "0.11")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (pypi-uri "docutils" version))
> > +       (sha256
> > +        (base32
> > +         "1jbybs5a396nrjy9m13pgvsxdwaj7jw7nsawkhl4fi1nvxm1dx4s"))))))
> 
> Okay.
> 
> > +(define-public python2-docutils-0.11
> > +  (package-with-python2 python-docutils-0.11))
> > +
> 
> Much better!  But: I’d rather not add the Python 2 variant unless it’s
> really needed.  If Kallithea really just needs the Python 2 variant,
> then please do not add the Python 3 variant.  The same comment applies
> to all other patches in this series that add variants like this.
> 
> -- 
> Ricardo
> 
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
> 

Thanks for your review, I'll send updates soon.
I think the weird constructions of some python2 variants originated in
the fact that the branch is too old to remember why I did it ;)

So here's my idea: I'll send an email upstream and ask about the
restrictions and if we could simply use a newer version, current one,
etc etc. I have not been following kallithea development since I packaged
this, but I know there has been no new release. These patches just reflect
what I tested, and I didn't even get to kallithea itself
afaik because I still needed dependencies for running tests.

Does this sound appropriate for you?
-- 
ng0 -- https://www.inventati.org/patternsinthechaos/