Subject: bug#25733: [PATCH 06/18] gnu: Add python-dulwich-0.9.9.

From: Ricardo Wurmus <[email-masked]>
Date: Sat, 18 Feb 2017 13:08:33 +0100

[email-masked] writes:

> From: ng0 <[email-masked]>
>
> * gnu/packages/python.scm (python-dulwich-0.9.9): New variable.
> ---
>  gnu/packages/python.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index ba2ff596c..c603d0778 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -796,6 +796,31 @@ available in pure Python.")
>      (inherit (package-with-python2
>                (strip-python2-variant python-dulwich)))))
>
> +;; kallithea-0.3.2 needs dulwich-0.9.9
> +(define-public python-dulwich-0.9.9
> +  (package
> +    (inherit python-dulwich)
> +    (name "python-dulwich-0.9.9")

The version number should not be part of the name.  The name should be
inherited.

> +    (version "0.9.9")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://dulwich.io/releases/dulwich-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "15l45063rpb5jn2c5b4x82fcjdg7p1bxnj9jh810032diln7ckh8"))))
> +    (build-system python-build-system)

You don’t need to override the “build-system” field.

> +    (inputs
> +     `(("python-mock" ,python-mock)
> +       ("python-gevent" ,python-gevent)
> +       ("python-geventhttpclient" ,python-geventhttpclient)
> +       ("python-fastimport" ,python-fastimport)))))

Why can’t you reuse the inputs (which should be propagated inputs) from
the “python-dulwich” package?

> +(define-public python2-dulwich-0.9.9
> +  (package
> +    (inherit (package-with-python2
> +              (strip-python2-variant python-dulwich-0.9.9)))))
> +

Is the variant for Python 2 needed at all?  I’d rather not add it unless
a package depends on it.

Additionally, the same question as before applies: why use
“strip-python2-variant” here?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net