Subject: Re: bug#25733: [PATCH 05/18] gnu: Add python2-mysql-python.

From: Ricardo Wurmus <[email-masked]>
Date: Sat, 18 Feb 2017 13:05:55 +0100

[email-masked] writes:

> From: ng0 <[email-masked]>
>
> * gnu/packages/python.scm (python2-mysql-python): New variable.
> ---
>  gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index aaa6ba111..ba2ff596c 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3801,6 +3801,34 @@ toolkits.")
>           ,@(fold alist-delete (package-propagated-inputs matplotlib)
>                   '("python-pycairo" "python-pygobject" "python-tkinter")))))))
>
> +(define-public python2-mysql-python
> +  (package
> +    (name "python2-mysql-python")
> +    (version "1.2.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "MySQL-python" version ".zip"))
> +       (sha256
> +        (base32
> +         "0x0c2jg0bb3pp84njaqiic050qkyd7ymwhfvhipnimg58yv40441"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f ;Tests require a running mysqld at /run/mysqld/mysqld.sock
> +       #:python ,python-2)) ;Application is python2 only

“Python 2 only”

> +    (inputs
> +     `(("unzip" ,unzip)

This is a native input.

[…]
> +       ("python2-sphinx" ,python2-sphinx)
> +       ("python2-nose" ,python2-nose)))

Are these only needed at test time or also at runtime?  If they are
needed at runtime they should be propagated.

> +    (home-page "https://github.com/farcepest/MySQLdb1")
> +    (synopsis "Python interface to MySQL")
> +    (description "MySQLdb is an interface to the popular MySQL
> +database server for Python.")
> +    (license license:gpl3)))

This doesn’t look right.

“_mysql.c” is licensed under GPLv2+.  I don’t see any mention of the
GPLv3.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net