Subject: Re: bug#25733: [PATCH 02/18] gnu: Add python-fastimport.

From: Ricardo Wurmus <[email-masked]>
Date: Sat, 18 Feb 2017 12:47:16 +0100

[email-masked] writes:

> From: ng0 <[email-masked]>
>
> * gnu/packages/python.scm (python-fastimport): New variable.
> ---
>  gnu/packages/python.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 8b6e55d0b..4019cc01b 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -1573,6 +1573,31 @@ software.")
>  (define-public python2-extras
>    (package-with-python2 python-extras))
>  
> +(define-public python-fastimport
> +  (package
> +    (name "python-fastimport")
> +    (version "0.9.6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "fastimport" version))
> +       (sha256
> +        (base32
> +         "1aqjsin4rmqm7ln4j0p73fzxifws6c6ikgyhav7r137m2ixsxl43"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f)) ; No tests
> +    (home-page "htps://github.com/jelmer/python-fastimport")

https ‐------------^

> +    (synopsis "VCS fastimport/fastexport parser")

I don’t know what this means.  Please try to make it clearer.

> +    (description
> +     "Library for parsing the fastimport VCS serialization format.")

Please use full sentences in descriptions and expand abbreviations.  Use
“@dfn{Very Cool System} (VCS)” for bonus points :)

> +    (license license:gpl2+)))
> +
> +(define-public python2-fastimport
> +  (package
> +    (inherit (package-with-python2
> +              (strip-python2-variant python-fastimport)))))
> +

This doesn’t look correct.  I think a plain “package-with-python2”
package would be sufficient here.  Let’s fight cargo computing by only
writing code that needs to be there :)

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net