Subject: Re: bug#25723: [PATCH] gnu: Add python-cycler.

From: Ricardo Wurmus <[email-masked]>
Date: Fri, 17 Feb 2017 18:38:43 +0100

Marius Bakke <[email-masked]> writes:

> This is required for recent versions of matplotlib.
>
> * gnu/packages/python.scm (python-cycler, python2-cycler): New variables.
> ---
>  gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 22a4c590b..5ebca3b6a 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3601,6 +3601,37 @@ transcendental functions).")
>  (define-public python2-numexpr
>    (package-with-python2 python-numexpr))
>
> +(define-public python-cycler
> +  (package
> +    (name "python-cycler")
> +    (version "0.10.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "cycler" version))
> +              (sha256
> +               (base32
> +                "1n69n23fak1gjxlrbhqisi2b9pv3ckrfj98llx3p53953082syyd"))))
> +    (build-system python-build-system)
> +    (arguments
> +     ;; XXX: The current version requires 'coveralls' which we don't have.
> +     ;; Enable this for the next release which uses 'python-pytest'.
> +     '(#:tests? #f))
> +    (propagated-inputs
> +     `(("python-six" ,python-six)))

Is python-six really required at runtime?  Since you offer a variant for
Python 2, should python-six only be used with one of these variants?

> +    (home-page "http://matplotlib.org/cycler/")
> +    (synopsis "Composable kwarg iterator")

I assume that “kwarg” is a generally known term in Python, but maybe it
is not.  Could this be replaced with “keyword argument”?

> +    (description
> +     "When using @code{matplotlib} and plotting more than one line, it is
> +common to want to be able to cycle over one or more artist styles; but the
> +plotting logic can quickly become involved.
> +
> +To address this and enable easy cycling over arbitrary @code{kwargs}, the
> +@code{Cycler} class was developed.")

I would remove the empty line.

> +    (license license:bsd-3)))
> +
> +(define-public python2-cycler
> +  (package-with-python2 python-cycler))
> +

See question above about python-six.
Other than that it looks good to me.  Thank you!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net