From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: 25.1.91; vc-retrieve-tag does not offer branch namd completion Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Feb 2017 23:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25710@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148702752518881 (code B ref -1); Mon, 13 Feb 2017 23:13:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Feb 2017 23:12:05 +0000 Received: from localhost ([127.0.0.1]:38965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdPmu-0004uT-GB for submit@debbugs.gnu.org; Mon, 13 Feb 2017 18:12:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdPmt-0004u0-2u for submit@debbugs.gnu.org; Mon, 13 Feb 2017 18:12:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdPmm-0007EW-BN for submit@debbugs.gnu.org; Mon, 13 Feb 2017 18:11:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40698) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cdPmm-0007ES-84 for submit@debbugs.gnu.org; Mon, 13 Feb 2017 18:11:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdPmk-0006Nw-CX for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2017 18:11:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdPmf-0007D3-89 for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2017 18:11:54 -0500 Received: from gproxy5-pub.mail.unifiedlayer.com ([67.222.38.55]:55854) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cdPme-0007Ae-Jw for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2017 18:11:49 -0500 Received: (qmail 19454 invoked by uid 0); 13 Feb 2017 23:11:24 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy5.mail.unifiedlayer.com with SMTP; 13 Feb 2017 23:11:24 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id kPBM1u00M2f2jeq01PBQS8; Mon, 13 Feb 2017 16:11:24 -0700 X-Authority-Analysis: v=2.1 cv=U+QBU4bu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=VDEtfpoToLGKPWCa6wMA:9 a=ZwMx_zFQFeL-pxlL:21 a=b-MjDQkyKIvGUE_F:21 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=B1dH/G90U8mo3uUJPgG7X9lvL8/PeIXpcA+QqV7c0XQ=; b=XXA5QQCbyo5dvhEgdy6s+BHP16 0lQWdXJ4s25oCBUsVniTgpD4EqxaiuGvqAqMWqAgqx3Kpn/ZR2sLIRln3R8IkG02sncs7Qh9DrH8a SM127d0c2LlbTDLGNr4w+UyOU; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:60600 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cdPmD-0005tJ-4x; Mon, 13 Feb 2017 16:11:21 -0700 From: Tom Tromey X-Attribution: Tom Date: Mon, 13 Feb 2017 16:11:16 -0700 Message-ID: <87a89p1yaz.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1cdPmD-0005tJ-4x X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:60600 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.5 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) Today I tried vc-retrieve-tag in a git project. I was hoping it would offer branch names for completion, but it did not. This seems reasonably easy to do as vc-git can already compute the list of local branch names. Tom In GNU Emacs 25.1.91.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.7) of 2017-02-02 built on bapiya Repository revision: 7e02a477bbcabb4e65aeecade79b67357c0b9dae Windowing system distributor 'Fedora Project', version 11.0.11901000 System Description: Fedora release 25 (Twenty Five) Configured using: 'configure --prefix=/home/tromey/Emacs/install/ --with-modules' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: VC dir Minor modes in effect: vc-parent-buffer: *vc-dir* shell-dirtrack-mode: t diff-auto-refine-mode: t which-function-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent messages: Saving file /home/tromey/.gitconfig... Wrote /home/tromey/.gitconfig user-error: Node has no Next C-z C-g is undefined Mark saved where search started Quit ~/.emacs and /home/tromey/DotEmacs/.emacs are the same file Quit C-c C-g is undefined Mark saved where search started Load-path shadows: /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.1.91/lisp/play/bubbles Features: (highlight-refontification tabify man shadow emacsbug conf-mode two-column iso-transl perl-mode sh-script executable cal-move nnregistry python tramp-sh tramp tramp-compat tramp-loaddefs trampver ucs-normalize make-mode etags cursor-sensor mhtml-mode org-bullets org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs gnus-fun gnus-draft noutline outline ido skeleton css-mode smie eww url-queue trace find-dired descr-text gdb-shell lisp-mnt url-handlers url-http url-gw url-auth lex edebug debug m4-mode bbdb-sc supercite regi xref project log-edit js json map sgml-mode flow-fill gnus-html xml url-cache mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf eieio-opt speedbar sb-image ezimage dframe find-func whitespace tcl log-view pcvs-util vc-annotate term/xterm xterm smerge-mode goto-addr shell find-file idutils derived bug-reference cc-mode cc-fonts cc-guess cc-menus cc-cmds jka-compr mailalias mail-hist nnir sort gnus-cite smiley shr-color url-util url-parse url-vars shr dom subr-x browse-url mm-archive gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-mua bbdb-com crm network-stream nsm starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-compat eieio-base gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader bbdb-message sendmail mail-extr message idna dired rfc822 mml mml-sec epg mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader gud dwarf-mode copyright dabbrev misearch multi-isearch vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs add-log rx vc-git diff-mode easy-mmode rust-mode flyspell ispell diminish edmacro kmacro projectile grep compile ibuf-ext ibuffer dash appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu minimap autorevert filenotify cus-start cus-load status erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec auth-source eieio gnus-util mm-util help-fns mail-prsvr password-cache thingatpt pp warnings advice vc-dir ewoc vc vc-dispatcher cc-styles cc-align cc-engine cc-vars cc-defs bbdb bbdb-site timezone ange-ftp comint ansi-color ring server savehist finder-inf dwarf-mode-autoloads gdb-shell-autoloads eieio-core lisppaste-autoloads pydoc-info-autoloads info-look cl-seq cl-macs cl weblogger-autoloads info package epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib bbdb-loaddefs time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 2705425 530649) (symbols 48 139797 578) (miscs 40 33520 10538) (strings 32 580869 184893) (string-bytes 1 16243491) (vectors 16 139145) (vector-slots 8 2872386 85886) (floats 8 936 1276) (intervals 56 339189 2699) (buffers 976 354)) From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2017 03:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.14870420167449 (code B ref 25710); Tue, 14 Feb 2017 03:14:02 +0000 Received: (at 25710) by debbugs.gnu.org; 14 Feb 2017 03:13:36 +0000 Received: from localhost ([127.0.0.1]:39107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdTYe-0001w4-4K for submit@debbugs.gnu.org; Mon, 13 Feb 2017 22:13:36 -0500 Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:58907) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cdTYb-0001vq-F6 for 25710@debbugs.gnu.org; Mon, 13 Feb 2017 22:13:34 -0500 Received: (qmail 8904 invoked by uid 0); 14 Feb 2017 03:13:20 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy7.mail.unifiedlayer.com with SMTP; 14 Feb 2017 03:13:20 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id kTDF1u00S2f2jeq01TDJia; Mon, 13 Feb 2017 20:13:20 -0700 X-Authority-Analysis: v=2.1 cv=Pets2ERd c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=zstS-IiYAAAA:8 a=K1d-9lO3UrtuwqjMNcIA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fgvbvcWSeXDHLagd8UFzqZ/4uF407QM0v4VQdJyVJuQ=; b=V+Yjfnbt9n+pNZKdtLhNv1BUUI jQOEyGpj51/EnMNH+Y+EShbBn65tPGJrRZ3Cy+HqY5zqiDdJvB1wPy7/JtnUMpz6GPQBKF903LHip 9IUjW+CCv1uBpYavZmO62EM2q; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:33302 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cdTYJ-0001Q8-6x; Mon, 13 Feb 2017 20:13:15 -0700 From: Tom Tromey References: <87a89p1yaz.fsf@tromey.com> X-Attribution: Tom Date: Mon, 13 Feb 2017 20:13:14 -0700 In-Reply-To: (GNU bug Tracking System's message of "Mon, 13 Feb 2017 23:13:02 +0000") Message-ID: <87r331zcqd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1cdTYJ-0001Q8-6x X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:33302 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) This patch seems to work for me. Tom commit ead2e9319b5676d2c637474d12d1c4d10fe7167f Author: Tom Tromey Date: Mon Feb 13 20:11:14 2017 -0700 Add completion for branch switches in git Bug#25710 * lisp/vc/vc-git.el (vc-git-list-branches): New function. * lisp/vc/vc.el (vc-retrieve-tag-history): New global. (vc-retrieve-tag): Call 'list-branches. Use vc-retrieve-tag-history. (vc-default-list-branches): New function. diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 8a22d74..0c11a7f 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1242,6 +1242,9 @@ vc-git-retrieve-tag (let ((default-directory dir)) (vc-git-command nil 0 nil "checkout" name))) +(defun vc-git-list-branches (dir) + (let ((default-directory dir)) + (vc-git-branches))) ;;; MISCELLANEOUS diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index c66a092..72151c0 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -450,6 +450,12 @@ ;; does a sanity check whether there aren't any uncommitted changes at ;; or below DIR, and then performs a tree walk, using the `checkout' ;; function to retrieve the corresponding revisions. +;; +;; - list-branches (dir) +;; +;; Return a list of strings, each of which names a branch that can +;; be switched to with `vc-git-retrieve-tag'. The default +;; implementation returns nil. ;; MISCELLANEOUS ;; @@ -2151,6 +2157,9 @@ vc-create-tag (vc-resynch-buffer dir t t t) (message "Making %s... done" (if branchp "branch" "tag"))) +(defvar vc-retrieve-tag-history nil + "History for `vc-retrieve-tag'.") + ;;;###autoload (defun vc-retrieve-tag (dir name) "For each file in or below DIR, retrieve their tagged version NAME. @@ -2172,7 +2181,11 @@ vc-retrieve-tag ;; to ask for a directory, branches are created at repository level. default-directory (read-directory-name "Directory: " default-directory default-directory t)) - (read-string "Tag name to retrieve (default latest revisions): ")))) + (completing-read "Tag name to retrieve (default latest revisions): " + (vc-call-backend (vc-responsible-backend + default-directory) + 'list-branches default-directory) + nil nil nil 'vc-retrieve-tag-history)))) (let ((update (yes-or-no-p "Update any affected buffers? ")) (msg (if (or (not name) (string= name "")) (format "Updating %s... " (abbreviate-file-name dir)) @@ -2853,6 +2866,12 @@ vc-default-retrieve-tag (vc-call-backend backend 'checkout f nil name) (when update (vc-resynch-buffer f t t))))))))) +(defun vc-default-list-branches (backend dir) + "Default implementation of 'list-branches function. +This function should return a list of possible branches to switch to. +The default implementation returns nil." + nil) + (defun vc-default-revert (backend file contents-done) (unless contents-done (let ((rev (vc-working-revision file)) From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2017 10:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey , 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.148706785420387 (code B ref 25710); Tue, 14 Feb 2017 10:25:02 +0000 Received: (at 25710) by debbugs.gnu.org; 14 Feb 2017 10:24:14 +0000 Received: from localhost ([127.0.0.1]:39286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdaHO-0005Il-Hq for submit@debbugs.gnu.org; Tue, 14 Feb 2017 05:24:14 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdaHM-0005IS-Pv for 25710@debbugs.gnu.org; Tue, 14 Feb 2017 05:24:13 -0500 Received: by mail-wm0-f46.google.com with SMTP id c85so13901117wmi.1 for <25710@debbugs.gnu.org>; Tue, 14 Feb 2017 02:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j0FJ6Io01IMQXqdLF+nk9bPEox1ni6Dpx77NcSNyJ58=; b=eLJG3RSVLg5WqmoDUgxSnD2N7avsHcFhinyIAhvtSCOH4IpH030dnn1hL76uUATw3R xfsxj5x5+OKhxsdcfNvtwBVV0s5ooUTBxja2ORB/ahsfaeD6KrfLHSW+Di+UB5VeaDfF L6qgeyHDGV70heU89v12Btfxb48nNFMPtiLSmxpX137nXYVsmmaYj7QvszVmZ0ryDvz3 02yVvUQCsmrxe1w5TzUbouMYhu3NXLIhujDvnDkaK9acXvgutVKukKhnyD+BToIrMw0r 5JM/Lr6CUjkZxjVphIPkoMnNXtQTqlXkxD1v3j4Xs+aCZkTs4+3sENdAay07cNWiRtcH ik/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j0FJ6Io01IMQXqdLF+nk9bPEox1ni6Dpx77NcSNyJ58=; b=oAe+19mGU/gK9dwkFCAkFn6wbtXI5kz0FRcyP1Z07KP+/YcoCBs3JQPyscVcUpRY0y x5nmDgJT8rsa0qGUuM9wVKbRHtUuO6hdOGKdXJ2flaZ1JQ2gSbO3muJX8DiI+jBni5Yc zauc1d8lNVePAlcjnK20ECfOSQpSHz0IcHBdG1q5Hb/6DW7KWPTSrn276bneuqUcDI/N 4BmTku7zD1gq30F5g31f+DIDHcX0X8fG795r+Pg74tXLx/NHr8x0VF3iX04e9qur2Hlx vUgaAaU888GDj+R0bcIGbndElZtIGCzV/iKguNYNhB7gSUbfofAp2py4DZ6YUw3GdFWa ebpg== X-Gm-Message-State: AMke39k2l6R20uIUCBv0ZTfQtpiyVYopps+TI1FAJuLKiNCiuVZfVEK59E5wmWrf42joXg== X-Received: by 10.28.94.2 with SMTP id s2mr2333688wmb.127.1487067846790; Tue, 14 Feb 2017 02:24:06 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id g11sm135642wrb.63.2017.02.14.02.24.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Feb 2017 02:24:06 -0800 (PST) References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> From: Dmitry Gutov Message-ID: <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> Date: Tue, 14 Feb 2017 12:24:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87r331zcqd.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 14.02.2017 05:13, Tom Tromey wrote: > +;; - list-branches (dir) Should we call it list-tags, similarly to the name of the command? And return tags together with branches in the Git implementation. From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2017 23:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.148711507820249 (code B ref 25710); Tue, 14 Feb 2017 23:32:02 +0000 Received: (at 25710) by debbugs.gnu.org; 14 Feb 2017 23:31:18 +0000 Received: from localhost ([127.0.0.1]:40320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdmZ3-0005GW-Sc for submit@debbugs.gnu.org; Tue, 14 Feb 2017 18:31:18 -0500 Received: from mail-wr0-f169.google.com ([209.85.128.169]:35869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdmZ0-0005Fo-Ez for 25710@debbugs.gnu.org; Tue, 14 Feb 2017 18:31:16 -0500 Received: by mail-wr0-f169.google.com with SMTP id k90so179984650wrc.3 for <25710@debbugs.gnu.org>; Tue, 14 Feb 2017 15:31:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JEBnv52j3B8ZYUSzRtvDtYhuVi0caxAAV8n9Fj2SIO4=; b=d2uenVrNDZwneF08vG6AM05X0rs+IDej2JiuA+azI1NwiuJv1+Imay/a6CQuuEae4a CodoDz5JqgUsESyHkvDeZrugliewE+QlZJ2Uq1VEjfLxSeRGEubKnvCXU9xtLQEjPSYn +nLutlrmnUOu+OcHmabSs2MlVtttgzf+SinBvY5lgyd/JpqQ4+uNEMu9bcU2NfIAn4sV mVdWOYpszzF9LQk1DfETUkVVMmK/D397IHICfBmRK7kcup+YyH+Z5QucaHj3LHiS/AXR +jVkALjKEnF5sfd05OJ4YWv+AYiof1qW82P2Y8+qLW5WX14I5sql2+WdBRd2mtZGTisq Yw9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JEBnv52j3B8ZYUSzRtvDtYhuVi0caxAAV8n9Fj2SIO4=; b=I3trqSX29eIMeCEmbvY9Z57ShYXciHV+08y8a47CV0uJ7HoYnE1iCUblhPX6876YET Hs+DRPO722mPKHcmTMhDGNxWCUM99BQ9vLUeFzgBBhsQGfWmddoJqJk3QT8QoTceWthC VyFt3zIQi3Ski7DdYj0uW/SYsa7Agu6MTgQxdNbXgX9eRqngC7CkscFzQxQ+78AoiEOl YSbLKVopqf9IGPBHJv9HpG53jbNOndi9kxHht+qnIZ0SpFZ5ouTaJE11PzXJlYCzxYlB YGcaryMaVfUk2FeZosvJIUPeqkfDfzRNqu7BB+WmS78bwDIdnTDfLOnoC8VcnPhTTWYJ x64Q== X-Gm-Message-State: AMke39mHovYIvv5lzGdSojcWDD2JlGKg+bbF6v6D51UC2UY3AvcaYzMvBLlQzVGsSnx/Fg== X-Received: by 10.223.152.175 with SMTP id w44mr30474873wrb.151.1487115068264; Tue, 14 Feb 2017 15:31:08 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id b87sm3085673wmi.0.2017.02.14.15.31.06 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 14 Feb 2017 15:31:07 -0800 (PST) References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> From: Dmitry Gutov Message-ID: <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> Date: Wed, 15 Feb 2017 01:31:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87inoczdun.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On 14.02.2017 23:01, Tom Tromey wrote: > Dmitry> Should we call it list-tags, similarly to the name of the command? > > This bit is fine by me. It would be a bit pointless without the second part. If we decide against it, list-branches is probably the better choice. So I wonder what other people think. > Dmitry> And return tags together with branches in the Git implementation. > > I am not so sure about this. I've never (literally never) wanted to > check out a tag with Git. I do sometimes check out a specific revision. Me neither, but... people do use tags to mark specific, *important* revisions. And supposedly check them out sometimes (maybe to see the exact code the "current production" version has?). I do check out specific revisions sometimes too, but providing completion for that is fairly impossible. Completing tags seems like the next best thing. > But... the UI doesn't prohibit this, it just only offers branches for > completion. I tend to think that's the most useful. Branches are most useful indeed. > Another idea would be to add a defcustom for this. I don't imagine having tags in there would really hurt, even if we don't pick them. IME tags usually follow a particular naming convention, so they won't interfere with completion. From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Feb 2017 04:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Tom Tromey , 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.148713335815536 (code B ref 25710); Wed, 15 Feb 2017 04:36:02 +0000 Received: (at 25710) by debbugs.gnu.org; 15 Feb 2017 04:35:58 +0000 Received: from localhost ([127.0.0.1]:40411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdrJt-00042W-Vq for submit@debbugs.gnu.org; Tue, 14 Feb 2017 23:35:58 -0500 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:33278 helo=gproxy9.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdrJs-00042J-N8 for 25710@debbugs.gnu.org; Tue, 14 Feb 2017 23:35:57 -0500 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id 03D781E0967 for <25710@debbugs.gnu.org>; Tue, 14 Feb 2017 21:35:43 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id ksbc1u00L2f2jeq01sbfmY; Tue, 14 Feb 2017 21:35:42 -0700 X-Authority-Analysis: v=2.1 cv=U+QBU4bu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=vaJtXVxTAAAA:8 a=8gsJwcEf86dx8mK1H44A:9 a=hCt-GehETBxEYQOojhlW:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kQKVegTU1DK7pliFDAdqx+0BbSQjc2dUjQRFFHdm0Xs=; b=Bm16Kv816yeZT4gl/9kJKVdXWO Y+cVAVjQTkbBVvynj1mQeUyKMEsrbas+Fk+VrTGiGjhiIkMFSQzV8422lckg9aMuCnXvnGJMiTC2S ++Cd4GGERY7zPa2uQk1cx8htg; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:35306 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cdrJY-0000Wx-CJ; Tue, 14 Feb 2017 21:35:36 -0700 From: Tom Tromey References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> X-Attribution: Tom Date: Tue, 14 Feb 2017 21:35:33 -0700 In-Reply-To: <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> (Dmitry Gutov's message of "Wed, 15 Feb 2017 01:31:05 +0200") Message-ID: <87wpcsxe96.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1cdrJY-0000Wx-CJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:35306 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >>>>> "Dmitry" == Dmitry Gutov writes: >> Another idea would be to add a defcustom for this. Dmitry> I don't imagine having tags in there would really hurt, even if we Dmitry> don't pick them. IME tags usually follow a particular naming Dmitry> convention, so they won't interfere with completion. Emacs itself has 144 tags, while I have about 16 branches. So for me at least, for this project, that's 90% clutter and 10% things I might actually want to complete. For my gdb checkout I have 32 branches and there are 636 tags, so the ratio is even worse there -- about 5% useful things. Tom From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Branch completion on vc-retrive-tag References: <87a89p1yaz.fsf@tromey.com> In-Reply-To: <87a89p1yaz.fsf@tromey.com> Resent-From: Artem Malyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Feb 2017 03:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.148721634222098 (code B ref 25710); Thu, 16 Feb 2017 03:40:02 +0000 Received: (at 25710) by debbugs.gnu.org; 16 Feb 2017 03:39:02 +0000 Received: from localhost ([127.0.0.1]:41534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceCuM-0005kJ-1L for submit@debbugs.gnu.org; Wed, 15 Feb 2017 22:39:02 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:34096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceCuK-0005k3-CZ for 25710@debbugs.gnu.org; Wed, 15 Feb 2017 22:39:00 -0500 Received: by mail-lf0-f53.google.com with SMTP id v186so2262784lfa.1 for <25710@debbugs.gnu.org>; Wed, 15 Feb 2017 19:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=1fCu7Vu9e4hHh4a0aWdydplZKOBCr/cjmK9tt+c5iFQ=; b=iiM8VpHoFsg4R9LCBDNCjh0hr/qK4nL0KhN87zwSJ8F6uibkiC8fLEuFIRMsJSlhIg gRdRSyEW1RY/v0TFianSbhMmBAII0TgZldTRAN3KG//sD+eTR58q0Sd9gdNdL7gAqsUs fo2q8x4fwgQQh9AIdvEt58qd26H0VhBQCLmrhfFWdpm5RLxuS0nTRCAm6Hi+ksg5qZko /T3V1aVpJlS/+6A3pu1HC2rxw7WCMvjmffoc/CRD51yRVYc/nxFvJE7pyRudYfsZBjDT 0hGJRCbpvnzhTdE4OMuQDW5AbnfOJMdkFArt24zj/7J1cfL5V0qYB21kUwbx1dFIbVMF lBMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=1fCu7Vu9e4hHh4a0aWdydplZKOBCr/cjmK9tt+c5iFQ=; b=aWdRbZE4upQ4FQtz8gTOXz2r776o1/FNom9WjyjQdSUzpAvk6BQpAUB/kbTwD4u/kk tl9N6+NexbJJN4R5Ax/3uOTTS1cRtfymybwQPBs1UbviCF5glPfl7Of+HDmFnSTujRW2 TS+DjskTC2tmMswhi06SUwP6ZESEgruHE+s6jEFo/7zKQa4sizyr3PnYhKEfLaZjbJVq tgyO+xiD9Q2lHt0tFezWCGfAr3F8NOBmWE7O4wNr5D/IdkvzxVaYDqA7qGH73ikgbYkX WVCBB6f9JuE3cfNSFAS5lgBW6v2lRhZL2gjHh35V7vFKQypPEvfmBZF77URtJzqIMYj9 0P6g== X-Gm-Message-State: AMke39mAbmI/saDAlUoQL8scx/rWvDI+lSXsL7NXAW4t5W3PbDNAd+F9AdzXNq5asLhMRyB9NpYQZUntOqEdYg== X-Received: by 10.25.150.69 with SMTP id y66mr33152lfd.124.1487216334137; Wed, 15 Feb 2017 19:38:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.211.209 with HTTP; Wed, 15 Feb 2017 19:38:53 -0800 (PST) From: Artem Malyshev Date: Thu, 16 Feb 2017 06:38:53 +0300 Message-ID: Content-Type: multipart/alternative; boundary=001a114034744cf15605489d89b4 X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --001a114034744cf15605489d89b4 Content-Type: text/plain; charset=UTF-8 Hello, Thank you guys for taking this feature into account. Currently I'm working on Django project. It has 43 branches and 155 tags. Most of them I don't need of course. Usually I work in 4-5 local branches. Every thing else have origin prefix and probably outdated from master by ten years. I guess that complete on full list of tags plus branches is good to be similar to vc-revision-other-window. But I don't know until I try. Regards, Artem. --001a114034744cf15605489d89b4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

Thank you guys for= taking this feature into account.

Currently I'm working o= n Django project. It has 43 branches and 155 tags. Most of them I don't= need of course. Usually I work in 4-5 local branches. Every thing else hav= e origin prefix and probably outdated from master by ten years.

I guess that complete on full list of tags plus branches is good to be si= milar to vc-revision-other-window. But I don't know until I try.
Regards, Artem.
--001a114034744cf15605489d89b4-- From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Feb 2017 01:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.148729480717959 (code B ref 25710); Fri, 17 Feb 2017 01:27:02 +0000 Received: (at 25710) by debbugs.gnu.org; 17 Feb 2017 01:26:47 +0000 Received: from localhost ([127.0.0.1]:42855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceXJv-0004fY-L2 for submit@debbugs.gnu.org; Thu, 16 Feb 2017 20:26:47 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceXJt-0004fJ-Js for 25710@debbugs.gnu.org; Thu, 16 Feb 2017 20:26:46 -0500 Received: by mail-wm0-f68.google.com with SMTP id v77so201463wmv.0 for <25710@debbugs.gnu.org>; Thu, 16 Feb 2017 17:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=JAiZ2X8ZP+ch+Q+1iU8wYOPHhJhGABYeDNqSaBhX/Sk=; b=GHU5c9+brByIxiCuU/yvh9h9p1rPBsDzbqpsTEU+1p00mfDzu+o2nepZbq10OZOf5l ZuEXtSRmZMy3P76ZGe7oiAzpyXldpeNYU6yeyOxtdBv8rzfKVHdiYuj+SG/Q0iDNNw+V yA8C7mR0vVDmMDm1wpe/faxbfz6fJivU8NM8TWOLCs+Gu9NhADu+bmKZNq3smfmyAANC PKv2tuTOMzDt6SE1F+5gduB331dIlzYHoPQ1KrOyidNh0BUzRanapGNkj84v4XyDBt9W ZkF1KvSeytn26+lZLQkJAzx1+aIZrAzdHL8ZkB0XZzUTh0RO5sxUcuQtns7eongwh2uG ET8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=JAiZ2X8ZP+ch+Q+1iU8wYOPHhJhGABYeDNqSaBhX/Sk=; b=L+vCL1mXnkcvoHV6bz6zo8toP2A9YsMkstOb37GkffwuDBDINxh/0RHv6+Kp6ZsnHS bJhoAZ9QZCgI3e1yYb7TkNIuyexBXxdlSWgfe6raz0t1O6vJ2IL2texU7YajM2kuzeRs pYQW1fm9f/k6kQt85vC31UI/ZUqrAf5IN5NHVWVYe2raPcS6e1xpOfgsFv2l5EW545Lt gtarA/kSLscs4vCQcRlrAFzAm6oVpOHqLJEDKDlZgGuEtN14h5GyZ0aSvuw/01lEuIvm DP5Dd6R3crbFpNe87WY1TMiKDwMfztJlSu+U9XbuWPE10g4C/LBIDSla/3SIg7ku0E4l kDpA== X-Gm-Message-State: AMke39nIVmcbfndkTJZbU165mOPeoyzJPmqoozKSK9jfud+St50bmf/EBeoUs1u7y5rf0w== X-Received: by 10.28.27.69 with SMTP id b66mr287477wmb.50.1487294800023; Thu, 16 Feb 2017 17:26:40 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id 32sm4872358wrr.20.2017.02.16.17.26.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 17:26:39 -0800 (PST) References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> <87wpcsxe96.fsf@tromey.com> From: Dmitry Gutov Message-ID: Date: Fri, 17 Feb 2017 03:26:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87wpcsxe96.fsf@tromey.com> Content-Type: multipart/mixed; boundary="------------04673D97EB78BE23FBD09A43" Content-Language: en-US X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) This is a multi-part message in MIME format. --------------04673D97EB78BE23FBD09A43 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 15.02.2017 06:35, Tom Tromey wrote: > Emacs itself has 144 tags, while I have about 16 branches. > So for me at least, for this project, that's 90% clutter and 10% things > I might actually want to complete. All Emacs tags start with "emacs-", so if you just input any other character and press TAB, you won't see the tags. > For my gdb checkout I have 32 branches and there are 636 tags, so the > ratio is even worse there -- about 5% useful things. I think we should consider whether it's likely to be a problem, and not just reject the unlikely options. Because other people's workflows can be different. And I do anticipate having to check out a particular release version, someday. Further, like Artem reminded us, we already have a revisions completion table. So the attached patch seems preferable to me. WDYT? --------------04673D97EB78BE23FBD09A43 Content-Type: text/x-patch; name="vc-retrieve-tag-completion.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="vc-retrieve-tag-completion.diff" diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index c308856..358f36a 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2163,18 +2163,22 @@ vc-retrieve-tag locked files at or below DIR (but if NAME is empty, locked files are allowed and simply skipped)." (interactive - (let ((granularity - (vc-call-backend (vc-responsible-backend default-directory) - 'revision-granularity))) + (let* ((granularity + (vc-call-backend (vc-responsible-backend default-directory) + 'revision-granularity)) + (dir + (if (eq granularity 'repository) + ;; For VC's that do not work at file level, it's pointless + ;; to ask for a directory, branches are created at repository level. + ;; XXX: Either we call expand-file-name here, or use + ;; file-in-directory-p inside vc-resynch-buffers-in-directory. + (expand-file-name (vc-root-dir)) + (read-directory-name "Directory: " default-directory nil t)))) (list - (if (eq granularity 'repository) - ;; For VC's that do not work at file level, it's pointless - ;; to ask for a directory, branches are created at repository level. - ;; XXX: Either we call expand-file-name here, or use - ;; file-in-directory-p inside vc-resynch-buffers-in-directory. - (expand-file-name (vc-root-dir)) - (read-directory-name "Directory: " default-directory default-directory t)) - (read-string "Tag name to retrieve (default latest revisions): ")))) + dir + (vc-read-revision "Tag name to retrieve (default latest revisions): " + (list dir) + (vc-responsible-backend dir))))) (let ((update (yes-or-no-p "Update any affected buffers? ")) (msg (if (or (not name) (string= name "")) (format "Updating %s... " (abbreviate-file-name dir)) --------------04673D97EB78BE23FBD09A43-- From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Feb 2017 04:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Tom Tromey , 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.14873046016448 (code B ref 25710); Fri, 17 Feb 2017 04:10:02 +0000 Received: (at 25710) by debbugs.gnu.org; 17 Feb 2017 04:10:01 +0000 Received: from localhost ([127.0.0.1]:42919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceZrt-0001fw-6m for submit@debbugs.gnu.org; Thu, 16 Feb 2017 23:10:01 -0500 Received: from gproxy6-pub.mail.unifiedlayer.com ([67.222.39.168]:47425) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1ceZrs-0001fh-0X for 25710@debbugs.gnu.org; Thu, 16 Feb 2017 23:10:00 -0500 Received: (qmail 15726 invoked by uid 0); 17 Feb 2017 04:09:49 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 17 Feb 2017 04:09:49 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id lg9i1u0162f2jeq01g9lna; Thu, 16 Feb 2017 21:09:49 -0700 X-Authority-Analysis: v=2.1 cv=U+QBU4bu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=vaJtXVxTAAAA:8 a=xuzpS0f3kvbqEbnSlLUA:9 a=hCt-GehETBxEYQOojhlW:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YsMuywfGU6wgG2R5uplJ/A6/QTW6/ezYIh56EsgK/q0=; b=gMilugYOMrjDZBgD02uiEuicSu jVb94KHVuwzZYVi99YN0UgkahVFaGpxhLyHipHJHkSjyw5HzqaMWHTdnwbBDxYl45+3bFycKYDd2R gvPZaBUMayr3Jkl9U0yHH63t0; Received: from 174-16-128-54.hlrn.qwest.net ([174.16.128.54]:47392 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1ceZra-0005hD-MZ; Thu, 16 Feb 2017 21:09:42 -0700 From: Tom Tromey References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> <87wpcsxe96.fsf@tromey.com> X-Attribution: Tom Date: Thu, 16 Feb 2017 21:09:41 -0700 In-Reply-To: (Dmitry Gutov's message of "Fri, 17 Feb 2017 03:26:37 +0200") Message-ID: <87h93txxtm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.128.54 X-Exim-ID: 1ceZra-0005hD-MZ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-128-54.hlrn.qwest.net (bapiya) [174.16.128.54]:47392 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >>>>> "Dmitry" == Dmitry Gutov writes: Dmitry> I think we should consider whether it's likely to be a problem, and Dmitry> not just reject the unlikely options. Because other people's workflows Dmitry> can be different. That seems fair. I still want to add a defcustom to control this. For all my cases, the tags would just completely drown out the usefulness of this feature. I don't mind writing that separately. Tom From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Feb 2017 22:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.148754241612700 (code B ref 25710); Sun, 19 Feb 2017 22:14:02 +0000 Received: (at 25710) by debbugs.gnu.org; 19 Feb 2017 22:13:36 +0000 Received: from localhost ([127.0.0.1]:46574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfZjc-0003Im-CD for submit@debbugs.gnu.org; Sun, 19 Feb 2017 17:13:36 -0500 Received: from mail-wr0-f170.google.com ([209.85.128.170]:34842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfZja-0003IN-LO for 25710@debbugs.gnu.org; Sun, 19 Feb 2017 17:13:34 -0500 Received: by mail-wr0-f170.google.com with SMTP id s27so7809058wrb.2 for <25710@debbugs.gnu.org>; Sun, 19 Feb 2017 14:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A9tuxnL0TAVIJEdXBuEj10GSRM36+Vsth3vxk/GjCaw=; b=Qh+8S3l71cxqg2zD+GNEKa6OVT1FPXXvSoPx0fHGqKkACKGwgkvYFEC29MPk5AOZSv JFhbV0sVs1KCtK5UjblJqKA2gx/osQjoAhH8La+0FmSiSJ+L7jdCiRo0jJG17J3n2lH2 kT+4YQXUNwWdkMFhLn7DdiGmZU9tCkY4gHXU94xPJOcm0OEY4fpZ4U5PlfEeYmHKICYz n4qRaewiKOvXojoK3UbbmcDXMqZaWrQ95HovyeB1FTnne5licwkOFjZCn1oOT9mTitq9 VoFunrmCdTQPSuzRteg2L5ZThA2qoX36S0S+tKHuaUpTMiGvwL9o3mOQ0drl+aQhEEDA ZTzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A9tuxnL0TAVIJEdXBuEj10GSRM36+Vsth3vxk/GjCaw=; b=e93IKV4Pxm/3C+AlyR3rnI2NYwryXN1pVyBYTnwLTSz5GrQl3q0ThqQ7VbUHuxYXOF WrqPufGgYnogXyBZcXio77Dx8W65s6ReQpHAkze9f3Gw+LAZN4Y11zRyqAD8iBjbIgRm a0UF6Eeawem9wEttkJHKqZ0q7sKBFR+aq8OkGikvZrLFgu7KIlTo3J/rKC5cTdeK9LuU S1Ig4LIaCv+DWDaVnB93XmHXBeZE15og4DYwJgeACVYX256gJSyXAq6VhOiwtOmgWzPp 6brNyrlyDPPBvx8o3ammJ40hIfa3PiCGpzXp5QvdeN8oPSu544lDzovncUeFdcoG0ZPP N9YA== X-Gm-Message-State: AMke39kPXUjjoBbGZHU8udKHS51GE7FQZiKftPQFpbWTJwHpPXuyLSR/ymoGaSXAgZQqoA== X-Received: by 10.223.145.45 with SMTP id j42mr14961139wrj.141.1487542408839; Sun, 19 Feb 2017 14:13:28 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id d29sm8792644wrc.34.2017.02.19.14.13.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Feb 2017 14:13:28 -0800 (PST) References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> <87wpcsxe96.fsf@tromey.com> <87h93txxtm.fsf@tromey.com> From: Dmitry Gutov Message-ID: Date: Mon, 20 Feb 2017 00:13:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <87h93txxtm.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -3.1 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.1 (---) On 17.02.2017 06:09, Tom Tromey wrote: > That seems fair. Thanks, installed. > I still want to add a defcustom to control this. > For all my cases, the tags would just completely drown out the > usefulness of this feature. I don't mind writing that separately. Will it change how vc-git-revision-completion-table works, across all commands? If so, I'm good with it. From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2017 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Tom Tromey , 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.148865080811110 (code B ref 25710); Sat, 04 Mar 2017 18:07:01 +0000 Received: (at 25710) by debbugs.gnu.org; 4 Mar 2017 18:06:48 +0000 Received: from localhost ([127.0.0.1]:40234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckE4u-0002t8-2h for submit@debbugs.gnu.org; Sat, 04 Mar 2017 13:06:48 -0500 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:36166 helo=gproxy9.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckE4s-0002su-3s for 25710@debbugs.gnu.org; Sat, 04 Mar 2017 13:06:46 -0500 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id E35521E08F8 for <25710@debbugs.gnu.org>; Sat, 4 Mar 2017 11:06:36 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id ru6X1u00L2f2jeq01u6ad4; Sat, 04 Mar 2017 11:06:36 -0700 X-Authority-Analysis: v=2.1 cv=U+QBU4bu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=6Iz7jQTuP9IA:10 a=vaJtXVxTAAAA:8 a=P0_UZS9Lpsi0ntiITbsA:9 a=hCt-GehETBxEYQOojhlW:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ib5nq2CTCVi8/UIWYvNR2Zeq6SXEBlDBSluNPeQk6nQ=; b=AwbiH5iEgnopDiViDmkUCvof6p 9zxOpBWygTF5aE0OTG3e1fCUSoTHw+Pv6wVLqvmYtf3zCErFQCtLMpM4I+EwjEzCWHzF8A9/KyqQu a5tVqcH56LrmGNID8WTxdoH9N; Received: from 71-218-43-111.hlrn.qwest.net ([71.218.43.111]:52102 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1ckE4d-0000zF-50; Sat, 04 Mar 2017 11:06:31 -0700 From: Tom Tromey References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> <87wpcsxe96.fsf@tromey.com> <87h93txxtm.fsf@tromey.com> X-Attribution: Tom Date: Sat, 04 Mar 2017 11:06:30 -0700 In-Reply-To: (Dmitry Gutov's message of "Mon, 20 Feb 2017 00:13:26 +0200") Message-ID: <8760jokjbt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.218.43.111 X-Exim-ID: 1ckE4d-0000zF-50 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-218-43-111.hlrn.qwest.net (bapiya) [71.218.43.111]:52102 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) >>>>> "Dmitry" == Dmitry Gutov writes: Dmitry> Will it change how vc-git-revision-completion-table works, Dmitry> across all commands? If so, I'm good with it. Yeah. What do you think of the appended? Tom diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 1a3f1bf..d20b10e 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -180,6 +180,16 @@ vc-git-log-output-coding-system :type '(coding-system :tag "Coding system to decode Git log output") :version "25.1") +(defcustom vc-git-revision-complete-only-branches nil + "Control whether tags are returned by revision completion for Git. + +When non-nil, only branches and remotes will be returned by +`vc-git-revision-completion-table'. This is used by various VC +commands when completing branch names. When nil, tags are also +included in the completions." + :type 'boolean + :version "26.1") + ;; History of Git commands. (defvar vc-git-history nil) @@ -1187,9 +1197,11 @@ vc-git-revision-table (with-temp-buffer (vc-git-command t nil nil "for-each-ref" "--format=%(refname)") (goto-char (point-min)) - (while (re-search-forward "^refs/\\(heads\\|tags\\|remotes\\)/\\(.*\\)$" - nil t) - (push (match-string 2) table))) + (let ((regexp (if vc-git-revision-complete-only-branches + "^refs/\\(heads\\|remotes\\)/\\(.*\\)$" + "^refs/\\(heads\\|tags\\|remotes\\)/\\(.*\\)$"))) + (while (re-search-forward regexp nil t) + (push (match-string 2) table)))) table)) (defun vc-git-revision-completion-table (files) From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Mar 2017 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.148880053327960 (code B ref 25710); Mon, 06 Mar 2017 11:43:01 +0000 Received: (at 25710) by debbugs.gnu.org; 6 Mar 2017 11:42:13 +0000 Received: from localhost ([127.0.0.1]:41791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckr1p-0007Gu-4L for submit@debbugs.gnu.org; Mon, 06 Mar 2017 06:42:13 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckr1o-0007Gg-8i for 25710@debbugs.gnu.org; Mon, 06 Mar 2017 06:42:12 -0500 Received: by mail-wm0-f42.google.com with SMTP id t193so61909868wmt.1 for <25710@debbugs.gnu.org>; Mon, 06 Mar 2017 03:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2iadz3tJtzJ6EraQj7BHhwnpEJFlRpNbzsG5doR6rkQ=; b=CbnnXglXak00bVXymbUCxbiN1jUkvg1pbqe+qI2/lluO8s8SCexTgqVjV15jwTX/Rn BdqmKk58jdZ/Vjo5IwyndeFY7Va1xY/yWSkf2Ij/1LvYpleVYDFP/KCXklsEtaoxr0pt 6NrswV+xwPv9XzI9KpjSUDw3Wua2kVVIdl6AXB9tT5SN1ZT0VzX0MdiKidgkY35Tne8q Er9CNkqSdPwuYaiFMb3TQEcO7S+BWHIXgHIK6IzVsiwFKzRsZI2OmXDgPW7ZbZoVP6wy P6OVjvsJVlRQGZcvR5AoatbPmoI+LLootrq2APCi2eMBOMarEyK26NnWzIOT5JOd7VN3 pPPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2iadz3tJtzJ6EraQj7BHhwnpEJFlRpNbzsG5doR6rkQ=; b=BJcebrj4va240LR5mgcA+tdfs0MNgqQ5MLknZe8GyTnMVpQte8W12RALksrTMUINLc jbhjqxZQGN/2kSYwjT6Xlgl0K1l8CZq6moGBc4mpZ3qHAEI1jn+xL1VIPIaR9CzYK+ep c8duQz48Fsd2UgJFgIA2JWLLRk2/8J7wdCHlxdnX4nQau11NoOnDAhcfR0JYujHDHH7d NMbFzuX+MuRo0FUjQoJrjnjfaEI5IjxEfYglNQMNtWUz6Jjr9vsYuMORWHT9g3J1+6bw HzQZ9A7EBcwLVQExsKCDdWKoMbl0qYnEHV//jX2cbPE2gyzDHoaLjLOUhi2/xPeuX4vB /kbQ== X-Gm-Message-State: AMke39kMLY9RBtDfI4LAfJdO0ThhsS3g7R6NLI1mWGCaY4WJ8iE0UxCLDAtxs5379o4D5w== X-Received: by 10.28.7.20 with SMTP id 20mr12237120wmh.115.1488800526037; Mon, 06 Mar 2017 03:42:06 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id o26sm26594711wro.44.2017.03.06.03.42.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Mar 2017 03:42:04 -0800 (PST) References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> <87wpcsxe96.fsf@tromey.com> <87h93txxtm.fsf@tromey.com> <8760jokjbt.fsf@tromey.com> From: Dmitry Gutov Message-ID: <94822cdb-159e-133b-a067-8ae8c765b9a6@yandex.ru> Date: Mon, 6 Mar 2017 13:42:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <8760jokjbt.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 04.03.2017 20:06, Tom Tromey wrote: >>>>>> "Dmitry" == Dmitry Gutov writes: > > Dmitry> Will it change how vc-git-revision-completion-table works, > Dmitry> across all commands? If so, I'm good with it. > > Yeah. What do you think of the appended? Looks good, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 11 03:45:32 2020 Received: (at control) by debbugs.gnu.org; 11 Aug 2020 07:45:32 +0000 Received: from localhost ([127.0.0.1]:38437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5OyR-0002sv-Vr for submit@debbugs.gnu.org; Tue, 11 Aug 2020 03:45:32 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:33673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5OyQ-0002mN-GL for control@debbugs.gnu.org; Tue, 11 Aug 2020 03:45:31 -0400 Received: by mail-yb1-f170.google.com with SMTP id p191so6569075ybg.0 for ; Tue, 11 Aug 2020 00:45:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=iz4IbdAdiSeytbBIL4RASPrTbaIYUXYUlzkvYwbg70Y=; b=E6nVwAEFbh0mVchx6qmZpi6XZkXAPfV9YosXEqLUL++ZO716nh8a3ern5VMHy1Py/D YpgxBfhc+0WjFrQ1uk1VWIx/230dEIYS7zSdbivCPXWOOp2LbuERI3n9L8vrFCr57DfO mLc2wm1tRxkxH7i3rDJ5FQ8rNJeINMhPqKaQVHl+R/KV4LdtMb2R4ij9deW0gAH1zn6X MYk+mSA01kBgqT3PPHMJYK+tKjYr9TD5RkEESGd5Tr/FBuHtaE66SZfGfM0nbtYOYt+Q Xxh6T/5iNOQ6MRKLaQA3pn4EK/kKk8821lvO4kGMHbsHn+n04sk+HZ7PsnWqsuYi5Acn Gu5w== X-Gm-Message-State: AOAM531dGjvAHu77zke5hnICDhSRqHp5mDS3CmhVtEIALzFT8nsVy5+b 1Bz91DjSwoFyUyFM1YXEgC+/hlsBkXFPAI9KVfBZrZC3ww1Tqw== X-Google-Smtp-Source: ABdhPJyWKPm1WK9zDn6fZg71bWTI24/6RHfhIGMofO+I6ynBR95HwA1GxAG02ozc6f1TLxNMHrjtiMBWpab/IC9FDbo= X-Received: by 2002:a25:b88b:: with SMTP id w11mr48270806ybj.129.1597131924932; Tue, 11 Aug 2020 00:45:24 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 11 Aug 2020 09:45:13 +0200 Message-ID: Subject: To: control Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 25710 + patch thanks Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.170 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.170 listed in wl.mailspike.net] 1.0 PDS_TONAME_EQ_TOLOCAL_VSHORT Very short body and From looks like 2 different emails 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 25710 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.170 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.170 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 1.0 PDS_TONAME_EQ_TOLOCAL_VSHORT Very short body and From looks like 2 different emails -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty tags 25710 + patch thanks From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Aug 2020 07:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: Tom Tromey , 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.159713261818783 (code B ref 25710); Tue, 11 Aug 2020 07:57:03 +0000 Received: (at 25710) by debbugs.gnu.org; 11 Aug 2020 07:56:58 +0000 Received: from localhost ([127.0.0.1]:38476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5P9W-0004st-5c for submit@debbugs.gnu.org; Tue, 11 Aug 2020 03:56:58 -0400 Received: from mail-yb1-f178.google.com ([209.85.219.178]:42219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5P9U-0004sS-3J for 25710@debbugs.gnu.org; Tue, 11 Aug 2020 03:56:56 -0400 Received: by mail-yb1-f178.google.com with SMTP id a34so6570411ybj.9 for <25710@debbugs.gnu.org>; Tue, 11 Aug 2020 00:56:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=Abgz628kjDJgFHCEHFy6OtqW4ud14k/c/T/67peXUkk=; b=PzPSvX8L6OgccG5u96g4RTWRB7zo9nAGLtiFiXLwLKdGm8DwcXayRWBSBHLlk5AyWR CE8JzH7TLGrThaaXgcD/saWaiwJWTWGlOM4ICmcVPjHqlN/Q3lv0BHLXzMML7KQnbA4m GaokfnHFPYWzF/Ciyt0k5Eqhjk0ra9Rfy4wkXThdX2mU6Y/g4CP9ilBt4OltwcX2BqwV oKoR9cM3W1lGMLpVtfJfKR3al69JvPq3yT/szs0k/nkVgsG6pB+OFC2D39gSL7yVrgwQ bSs/Wkt2AyCJYSwK/uQqBhEw0mzCboawVAviGR93qqU26Gzt/kMkIaEdqUsYLEcDo4QQ 3d9A== X-Gm-Message-State: AOAM530tg0qRzYrpHu60El+nvE/g26P9HaSbHd+6JutiLnzztvi0N0XX hhD9098a65ApIGvVPiHZzJCQg+feJIRAwHc2pK6EKha7+jY= X-Google-Smtp-Source: ABdhPJz2XWaihbTbDyvkHmYTmDVW4M8rmnJMtRgjKvH7Q7m60vq6a2ZEjehXZMemXLfasI3049ueI8Zb9c4UKA70EFQ= X-Received: by 2002:a25:9843:: with SMTP id k3mr46326817ybo.466.1597132610652; Tue, 11 Aug 2020 00:56:50 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Aug 2020 00:56:50 -0700 From: Stefan Kangas In-Reply-To: <94822cdb-159e-133b-a067-8ae8c765b9a6@yandex.ru> (Dmitry Gutov's message of "Mon, 6 Mar 2017 13:42:03 +0200") References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> <87wpcsxe96.fsf@tromey.com> <87h93txxtm.fsf@tromey.com> <8760jokjbt.fsf@tromey.com> <94822cdb-159e-133b-a067-8ae8c765b9a6@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 11 Aug 2020 00:56:50 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 04.03.2017 20:06, Tom Tromey wrote: >>>>>>> "Dmitry" == Dmitry Gutov writes: >> Dmitry> Will it change how vc-git-revision-completion-table works, >> Dmitry> across all commands? If so, I'm good with it. >> Yeah. What do you think of the appended? > > Looks good, thanks. That was 3 years ago. It seems like the patch here was never installed. Should it be? Best regards, Stefan Kangas From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Aug 2020 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: Tom Tromey , 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.159717509522100 (code B ref 25710); Tue, 11 Aug 2020 19:45:02 +0000 Received: (at 25710) by debbugs.gnu.org; 11 Aug 2020 19:44:55 +0000 Received: from localhost ([127.0.0.1]:41732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5aCc-0005kO-Qg for submit@debbugs.gnu.org; Tue, 11 Aug 2020 15:44:54 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:37082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5aCX-0005k4-6Z for 25710@debbugs.gnu.org; Tue, 11 Aug 2020 15:44:52 -0400 Received: by mail-wm1-f46.google.com with SMTP id k8so3994368wma.2 for <25710@debbugs.gnu.org>; Tue, 11 Aug 2020 12:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LNtmzHi2GoSXjJ9YgwvDJIM1jy57z2Bw6lQ/JUlkSnE=; b=I9YKWhiqv4YPZsJRJf+3MVz2y9C68QJvK/AV5vtFByEg6KO8riFLPVkaNNKxWiZ8Em TzKmhJGh9miC66b686nF5mbEJvtVRmApc2Hw2vFQdtFKT++v5CXYkQA4NA7SqRs5PB67 UGhcRwL5zpcsseJ8xw0RY4VnUlXwiq29Stak9q6m3SlaPXKHNJ2w8H7tA6RJNu+MJVjz sJ9wnVCgv45fTHPTn5bdTLtx2gRfMfz6SYmvwG4Giw2ZUVi62V+TPxOjRFFI7bU6vUin /GiadcSzTZWuF4qaZkRFf7fsYXHUS+4OXb6Ay4EutyeO01wl/Qrhqis6KLefUqicSpUN V1iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LNtmzHi2GoSXjJ9YgwvDJIM1jy57z2Bw6lQ/JUlkSnE=; b=A5CwRzmnKupGgE7KACmo1phJlGJq+1frvFiBKDL8g4q2g7yl9OLLdLvOdplrFw/jHT 1qNErQuyz65X0AzTerKYRjVEuzmylBk+i/2oMiw95Bin8ufYBwM6vOQ4bu+5f5qiMafK Nd4aWhW4qgytxyeC+ljRo/+H7UlhHVLt320cTqqxDtv/LGDiUTpdJUGLcOFJzGrXl08j xMO6aY32XyGpe0OOgU1dASCY+EpeLQ6od2gK/5Z3PHp38RMMjlfyOi4zai9ZktuxOomN AwYqHs/8AxCvHXKwIkiFo2yttfYIqBLlVyyqbPcA2glIT82oJZG+89ntyxVIQP/3N1Hb 78Ow== X-Gm-Message-State: AOAM533c+z4fIrcckjwqWLA+8Y8xZ2NgQ3mYXm7CmLuN6rYl1tsfaKMX RjTfIzg9CzzNo+hjKLU1A/OszQOz X-Google-Smtp-Source: ABdhPJyYYvF19VagXeyx5jVHP8sGU/x6bzXi9EeLIkJRwwqEq0XvdSZIjfJPFeWGQdXoQgXbIeaNTA== X-Received: by 2002:a1c:2b04:: with SMTP id r4mr5024044wmr.76.1597175082793; Tue, 11 Aug 2020 12:44:42 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id 69sm7809447wmb.8.2020.08.11.12.44.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2020 12:44:41 -0700 (PDT) References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> <87wpcsxe96.fsf@tromey.com> <87h93txxtm.fsf@tromey.com> <8760jokjbt.fsf@tromey.com> <94822cdb-159e-133b-a067-8ae8c765b9a6@yandex.ru> From: Dmitry Gutov Message-ID: Date: Tue, 11 Aug 2020 22:44:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11.08.2020 10:56, Stefan Kangas wrote: > It seems like the patch here was never installed. Should it be? I'm still okay with it. Kinda curious why Tom checked out of the discussion, since it was apparently important for his use cases. From unknown Mon Aug 18 19:29:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25710: Acknowledgement (25.1.91; vc-retrieve-tag does not offer branch namd completion) Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Aug 2020 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: Tom Tromey , Stefan Kangas , 25710@debbugs.gnu.org Received: via spool by 25710-submit@debbugs.gnu.org id=B25710.159783718024704 (code B ref 25710); Wed, 19 Aug 2020 11:40:02 +0000 Received: (at 25710) by debbugs.gnu.org; 19 Aug 2020 11:39:40 +0000 Received: from localhost ([127.0.0.1]:38258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8MRQ-0006QO-Ir for submit@debbugs.gnu.org; Wed, 19 Aug 2020 07:39:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8MRO-0006Q8-Qx for 25710@debbugs.gnu.org; Wed, 19 Aug 2020 07:39:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eWFMo+A2vSrqFWudTN1B92itxi/PNtAnwjewqfGPsCM=; b=uulOW5SIbuSQTGrL+GVLKx2X2k BXWIA3TFtDlx+HfeQz/fROmQ+6Jki1sEZG/myOb/3tAMvk5bHlpnLSR++8mRzjvAM8csnBa/C10mR +4QQ5JSqzhhIZOtJpETxktZ86k7AnYfW5k6Oeo1vyHCi+dd7LyzVyBYmnrUMPIoVkALg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8MRE-0004Bd-Nc; Wed, 19 Aug 2020 13:39:32 +0200 From: Lars Ingebrigtsen References: <87a89p1yaz.fsf@tromey.com> <87r331zcqd.fsf@tromey.com> <8a4466fb-af60-785b-ffdd-563f2b0248d3@yandex.ru> <87inoczdun.fsf@tromey.com> <93d9799f-955c-0451-55a0-3595ad26dc96@yandex.ru> <87wpcsxe96.fsf@tromey.com> <87h93txxtm.fsf@tromey.com> <8760jokjbt.fsf@tromey.com> <94822cdb-159e-133b-a067-8ae8c765b9a6@yandex.ru> X-Now-Playing: Dead Can Dance's _Within the Realm of a Dying Sun_: "Catara" Date: Wed, 19 Aug 2020 13:39:27 +0200 In-Reply-To: (Dmitry Gutov's message of "Tue, 11 Aug 2020 22:44:40 +0300") Message-ID: <87r1s26f0w.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > On 11.08.2020 10:56, Stefan Kangas wrote: >> It seems like the patch here was never installed. Should it be? > > I'm still okay with it. OK; applied to Emacs 28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 11.08.2020 10:56, Stefan Kangas wrote: >> It seems like the patch here was never installed. Should it be? > > I'm still okay with it. OK; applied to Emacs 28. > Kinda curious why Tom checked out of the discussion, since it was > apparently important for his use cases. Abducted by aliens? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 19 07:39:46 2020 Received: (at control) by debbugs.gnu.org; 19 Aug 2020 11:39:46 +0000 Received: from localhost ([127.0.0.1]:38261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8MRV-0006Qf-Pa for submit@debbugs.gnu.org; Wed, 19 Aug 2020 07:39:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8MRU-0006QG-2v for control@debbugs.gnu.org; Wed, 19 Aug 2020 07:39:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TVz+Xccyu0En6gpepSJ1Rejv6f+Q8B8/TPDdBtV07tM=; b=uTXyIhUAPp1yHWDIbfj36Vf68R f7Eut5TIlNr8HOy3SUB8RZ/KOVmc5FubDYOeB9McjBLkn4umG071yfauy0kOLePlxEHob/iR8IlxD 10nLLVQgPYhGHfRTwJGmqeclpJ4ruDtkVtjb8OzUV+XELTOwfBzvG/jqi7OFrR3+demo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8MRM-0004Bm-Cf for control@debbugs.gnu.org; Wed, 19 Aug 2020 13:39:38 +0200 Date: Wed, 19 Aug 2020 13:39:35 +0200 Message-Id: <87pn7m6f0o.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #25710 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 25710 fixed close 25710 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 25710 fixed close 25710 28.1 quit