Subject: Re: bug#25695: angband [new package]

From: Ricardo Wurmus <[email-masked]>
Date: Sun, 12 Feb 2017 18:39:43 +0100

Christopher Allan Webber <[email-masked]> writes:

> This patch adds Angband, one of those delightfully life-destroying
> roguelikes.  Now you too can ruin your life chasing an @ around a screen
> for hours at a time.  Horray!

Neat!

> From c167b96d38acf580e42a618b6211c007760949f0 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <[email-masked]>
> Date: Fri, 10 Feb 2017 16:45:11 -0600
> Subject: [PATCH] gnu: Add angband.
>
> * gnu/packages/games.scm (angband): New variable.
> ---
>  gnu/packages/games.scm | 37 ++++++++++++++++++++++++++++++++++++-
>  1 file changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 0867089d5..0df1f69e5 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -10,7 +10,7 @@
>  ;;; Copyright © 2014, 2015 Mark H Weaver <[email-masked]>
>  ;;; Copyright © 2015, 2016 Andreas Enge <[email-masked]>
>  ;;; Copyright © 2015 David Hashe <[email-masked]>
> -;;; Copyright © 2015 Christopher Allan Webber <[email-masked]>
> +;;; Copyright © 2015, 2017 Christopher Allan Webber <[email-masked]>
>  ;;; Copyright © 2015, 2016, 2017 Ricardo Wurmus <[email-masked]>
>  ;;; Copyright © 2015, 2016, 2017 Alex Kost <[email-masked]>
>  ;;; Copyright © 2015 Paul van der Walt <[email-masked]>
> @@ -227,6 +227,41 @@ them, called Jean Raymond, found an old church in which to hide, not knowing
>  that beneath its ruins lay buried an ancient evil.")
>      (license license:gpl3)))
>  
> +(define-public angband
> +  (package
> +    (name "angband")
> +    (version "4.0.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "http://rephial.org/downloads/4.0/"
> +                           "angband-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0lpq2kms7hp421vrasx2bkkn9w08kr581ldwik3v0hlq6h7rlxhd"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f                                 ;no check target
> +       ;; #:configure-flags '("--enable-sdl")
> +       #:configure-flags (list (string-append "--bindir=" %output "/bin"))

Did you leave the commented entry for #:configure-flags on purpose?  If
that’s a TODO or FIXME I’d prefer if it was made explicit.

> +       #:phases (modify-phases %standard-phases
> +                  (add-after
> +                   'unpack 'autogen.sh

Nitpick: move the phase names onto the same line as “add-after”.

> +                   (lambda _
> +                     (substitute* "acinclude.m4"
> +                       (("ncursesw5-config") "ncursesw6-config"))
> +                     (zero? (system* "sh" "autogen.sh")))))))
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)))
> +    (inputs `(("ncurses" ,ncurses)))
> +    (home-page "http://rephial.org/")
> +    (synopsis "Dungeon exploration roguelike")
> +    (description "Classic dungeon exploration roguelike.  Explore the depths
> +below Angband, seeking riches, fighting monsters, and preparing to fight
> +Morgoth, the Lord of Darkness.")

Please turn the first sentence fragment into a full sentence?

> +    (license license:gpl2)))

Would it be better to add that the sounds and graphics are under
different licenses?

“copying.txt” says:

--8<---------------cut here---------------start------------->8---
 * Adam Bolt's (16x16) graphics may be redistributed and used for any purpose, 
   with or without modification.

 * David Gervais' (32x32) graphics may be redistributed, modified, and used
   only under the terms of the Creative Commons Attribution 3.0 licence:
   http://creativecommons.org/licenses/by/3.0/

 * Shockbolt's (64x64) graphics are distributed under the licence at the end
   of this file.  Currently some of the tiles in the 64x64.png tilesheet were
   resized from tiles made by David Gervais for the 32x32 set.

 * The sounds are licenced under the Creative Commons Attribution-NonCommercial-
   Sharealike licence.  They were created by Dubtrain <[email-masked]>.
   You can find them in Wave format at http://www.dubtrain.com/angband/.
--8<---------------cut here---------------end--------------->8---

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net