From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 11 01:41:12 2017 Received: (at submit) by debbugs.gnu.org; 11 Feb 2017 06:41:12 +0000 Received: from localhost ([127.0.0.1]:35274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccRMt-0005qd-Q7 for submit@debbugs.gnu.org; Sat, 11 Feb 2017 01:41:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccRMp-0005qD-26 for submit@debbugs.gnu.org; Sat, 11 Feb 2017 01:41:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccRMi-0003b7-PB for submit@debbugs.gnu.org; Sat, 11 Feb 2017 01:41:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49956) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ccRMi-0003b2-Ld for submit@debbugs.gnu.org; Sat, 11 Feb 2017 01:41:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccRMh-0000wc-5d for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2017 01:41:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccRMe-0003aV-1U for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2017 01:40:59 -0500 Received: from smtpbgbr2.qq.com ([54.207.22.56]:45019) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ccRMd-0003ZU-LG for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2017 01:40:55 -0500 X-QQ-mid: bizesmtp5t1486795242t3ys1ynpy Received: from Chunyangs-MacBook-Air.local (unknown [121.234.19.12]) by esmtp4.qq.com (ESMTP) with SMTP id 0 for ; Sat, 11 Feb 2017 14:40:41 +0800 (CST) X-QQ-SSF: 0110000000200060F410B00A0000000 X-QQ-FEAT: cVyAxUU2dcit7p5k1hpsic5hk90y9FRZYlsqphybZ9CKNbOKUmNw39Vi4B0Ak U54pW285CWKnAv7HPt1dOifkgJtEyVgRSydib1YYm6BOrslo5Cq+f/DS73iWSkwz5m8dy+v xgIvbt1VU/Af2nElOlylOb40qll9ow+KcL6mtfHVL0uQ+FvL6ekInRCdHKnbYmODMEVhyYK 7B0HyEMqHfUytW1X0ylsyAvbA11ca3bzCeoOJBLT3Sd/cLpcgdwCDfGW3rJ0aZtk= X-QQ-GoodBg: 0 From: Chunyang Xu To: bug-gnu-emacs@gnu.org Subject: 26.0.50; [PATCH] Fix completing-read call in reb-change-syntax Date: Sat, 11 Feb 2017 14:40:41 +0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-QQ-SENDSIZE: 520 X-QQ-Bgrelay: 1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hi, I find it makes more sense to use 'default' arg of completing-read than 'initial-input' arg, because I don't have to delete it before I can actually change to another. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-completing-read-call-in-reb-change-syntax.patch >From c0b4621083a6947f75ea58b4c535452a4caad4a5 Mon Sep 17 00:00:00 2001 From: Chunyang Xu Date: Sat, 11 Feb 2017 14:17:26 +0800 Subject: [PATCH] Fix completing-read call in reb-change-syntax * lisp/emacs-lisp/re-builder.el (reb-change-syntax): Use 'default' arg of completing-read. Copyright-paperwork-exempt: yes --- lisp/emacs-lisp/re-builder.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/re-builder.el b/lisp/emacs-lisp/re-builder.el index 5264dae52a..f60d723a88 100644 --- a/lisp/emacs-lisp/re-builder.el +++ b/lisp/emacs-lisp/re-builder.el @@ -488,10 +488,10 @@ reb-change-syntax Optional argument SYNTAX must be specified if called non-interactively." (interactive (list (intern - (completing-read "Select syntax: " - (mapcar (lambda (el) (cons (symbol-name el) 1)) - '(read string sregex rx)) - nil t (symbol-name reb-re-syntax))))) + (completing-read + (format "Select syntax (default %s): " reb-re-syntax) + '(read string sregex rx) + nil t nil nil (symbol-name reb-re-syntax))))) (if (memq syntax '(read string sregex rx)) (let ((buffer (get-buffer reb-buffer))) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 19:12:33 2017 Received: (at 25687) by debbugs.gnu.org; 3 Mar 2017 00:12:33 +0000 Received: from localhost ([127.0.0.1]:37149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjapk-0006OH-TQ for submit@debbugs.gnu.org; Thu, 02 Mar 2017 19:12:33 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:33630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjaph-0006Nx-UF; Thu, 02 Mar 2017 19:12:30 -0500 Received: by mail-io0-f170.google.com with SMTP id f84so63868070ioj.0; Thu, 02 Mar 2017 16:12:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xROlEtQJIxf3RBJFniHxDOwspQ/0zQx30WdizTyGOOw=; b=OpGU2R4S+NCkO2+xfKuip4Lw9pIaMx4WjzpfAN6lCPyUaaJqgHaYLfaaDg+v7P+cOr k6wURlHkyBELTi1pa/DUT9narWosV7XoFjlug3GUVd1SHH8LsOW1asiJzCaQh/r1R00+ V3nE+NJIeO+/Meu/EOg1ewit5rJ/YPbgi3ngQDsq3jYW7QOdfNNuvGMkEbYWSph1xPuy THCe4epDKVM/ox9LIZdXtDm/1bztBM+UP034/fLi/1xEzsFewEY+03dpzZ21NJZGcAVK QdvqMfvT0NSa+8Z8H09nOy4WPEORQOBRBaynhKu6ycNyACwvqJS6D19603lcIF1jmpxa uFwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=xROlEtQJIxf3RBJFniHxDOwspQ/0zQx30WdizTyGOOw=; b=gbb3rnsG4SgiPF5KDtHgpeiQQYy5vnNIrrMmdM+/E1E4HjFygfQVRgXDtu5fds8Z8x ZjSXwOfaopKxpVmztnNFt3itVjomVsf3IpAOy0zAKEr7p9WJ1lUAXmdCCoL8KbunVobK rmernn4OEPC5Hoib7Rl2NehZxwtYVZBLBzJvsr1dwE7vxTk8WIbSYyeMsRGIYZa0YGIp kfwRvnTLocgP8vG1dd0R00WLNhITCkbN8kZ9Of429+su8vqqdIUrKzCkxfboGaSn7s8N rA4In0rEeU6RYT5mubfSEZOHcX28PNb/ynqyK3SQ9IcEyii2Y178SHojA0Bm89QfKFxh bngg== X-Gm-Message-State: AMke39kHEmD20kN0nnM3Qs4M0vUSt7rRLKxtxXwVvxqmjDDI2ihoLZxEu+/VgKHwOUd8Yg== X-Received: by 10.107.56.11 with SMTP id f11mr459251ioa.131.1488499944261; Thu, 02 Mar 2017 16:12:24 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id k66sm916438iof.30.2017.03.02.16.12.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Mar 2017 16:12:23 -0800 (PST) From: npostavs@users.sourceforge.net To: Chunyang Xu Subject: Re: bug#25687: 26.0.50; [PATCH] Fix completing-read call in reb-change-syntax References: Date: Thu, 02 Mar 2017 19:13:37 -0500 In-Reply-To: (Chunyang Xu's message of "Sat, 11 Feb 2017 14:40:41 +0800") Message-ID: <8760jrb4jy.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25687 Cc: 25687@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 25687 fixed close 25687 26.1 quit Chunyang Xu writes: > From: Chunyang Xu > Date: Sat, 11 Feb 2017 14:17:26 +0800 > Subject: [PATCH] Fix completing-read call in reb-change-syntax Pushed to master [1: 55c0c3e31b]. 1: 2017-03-02 19:01:18 -0500 55c0c3e31bc3dff83753cdba6288228bd025ac84 Fix completing-read call in reb-change-syntax From unknown Fri Aug 22 01:33:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 31 Mar 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator