GNU bug report logs - #25680
[PATCH] copy: Avoid race when creating hard link over recently-created file

Previous Next

Package: coreutils;

Reported by: Mike Crowe <mac <at> mcrowe.com>

Date: Fri, 10 Feb 2017 19:50:02 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #25 received at 25680 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 25680 <at> debbugs.gnu.org
Subject: Re: bug#25680: maint: tweaks so syntax tests pass for previous commit
Date: Wed, 15 Feb 2017 17:32:23 -0800
On 15/02/17 11:46, Paul Eggert wrote:
> I see some problems with this followup patch:
> 
> http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=bd4bb42d65aac6591277066739ca42d1ddcc2d0e
> 
> in that it will make force-link.c and force-link.h harder to move to 
> gnulib. Is there some way that we can have the code pass syntax checks 
> without tying it so tightly to coreutils?

Generally we put stuff in gl/ that's intended for gnulib at some stage.

> Also, why do the syntax checks require those redundant 'extern's? 
> They're not that common in practice and I'd rather avoid them.

I guess to match up with the declaration in the header.
Existing modules in gl/ don't use the explicit extern
in either the header or the c file.

thanks,
Pádraig





This bug report was last modified 8 years and 101 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.