GNU bug report logs - #25678
25.1; defcustom type `(file :must-match t)' seems not to work

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Fri, 10 Feb 2017 18:33:02 UTC

Severity: normal

Tags: fixed

Found in versions 25.1, 26.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #35 received at 25678 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: dieter <at> duenenhof-wilhelm.de, 25678 <at> debbugs.gnu.org,
 Noam Postavsky <npostavs <at> gmail.com>, Drew Adams <drew.adams <at> oracle.com>,
 tim <at> tim-landscheidt.de
Subject: Re: bug#25678: 25.1; defcustom type `(file :must-match t)' seems
 not to work
Date: Thu, 10 Sep 2020 15:13:10 +0200

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> I found that the :match function will return false positives when
> :must-match is nil and value is not a string.  This can happen is
> the defcustom is of type:
> :type '(choice file (const nil))), and the value is nil, because we
> check if nil matches with the widget file first.
>
> Here's a patch to fix it.

Thanks; applied to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 4 years and 257 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.