From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 10 13:32:41 2017 Received: (at submit) by debbugs.gnu.org; 10 Feb 2017 18:32:41 +0000 Received: from localhost ([127.0.0.1]:34992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccFzt-0002Cy-Io for submit@debbugs.gnu.org; Fri, 10 Feb 2017 13:32:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccFzr-0002Cm-Kp for submit@debbugs.gnu.org; Fri, 10 Feb 2017 13:32:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccFzl-00075o-NT for submit@debbugs.gnu.org; Fri, 10 Feb 2017 13:32:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51568) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ccFzl-00075g-Js for submit@debbugs.gnu.org; Fri, 10 Feb 2017 13:32:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccFzk-0006a1-H7 for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 13:32:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccFzf-000745-M3 for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 13:32:32 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:46428) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ccFzf-00073Y-CJ for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 13:32:27 -0500 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v1AIWPet011812 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 10 Feb 2017 18:32:25 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v1AIWPkQ020228 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 10 Feb 2017 18:32:25 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v1AIWOCk025893 for ; Fri, 10 Feb 2017 18:32:24 GMT MIME-Version: 1.0 Message-ID: <77a3abe9-258c-4863-a87d-2f236babafe4@default> Date: Fri, 10 Feb 2017 10:32:23 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.1; defcustom type `(file :must-match t)' seems not to work X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) (defcustom foo-file "" "" :type '(file :must-match t) :group 'convenience) M-x customize-option foo-file I don't see anything that prevents you from using a file name that corresponds to no existing file. I don't see that completion (`M-TAB')=20 enforces it to name an existing file. And I don't see that simply=20 inserting a bad file name is prevented, nor is setting the option to a bad file name or saving it prevented. What effect does (file :must-match t) actually have, if any? If this is just confusion on my part, please consider clarifying the description of the behavior in the doc: (elisp) `Simple Types'. (I see the same behavior if `(file :must-match t)' is used within a complex type, e.g. as the :value-type of an alist entry.) In GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-11-15 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 18:56:53 2017 Received: (at 25678) by debbugs.gnu.org; 17 Feb 2017 23:56:53 +0000 Received: from localhost ([127.0.0.1]:43929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cesOT-0002M4-47 for submit@debbugs.gnu.org; Fri, 17 Feb 2017 18:56:53 -0500 Received: from mail-io0-f173.google.com ([209.85.223.173]:35424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cesOQ-0002Ls-PJ for 25678@debbugs.gnu.org; Fri, 17 Feb 2017 18:56:51 -0500 Received: by mail-io0-f173.google.com with SMTP id j18so3421940ioe.2 for <25678@debbugs.gnu.org>; Fri, 17 Feb 2017 15:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7vTxFzSmXvbhkoGh8d8C/6rO3yo9zYPRzmdYLxOFfbI=; b=FnLFJADRtb5Ebbf7tHaG21umAl4Y4e8Lx9wXMAnuEFHbJDSwKZtU1RI8E3sYSgktmI U44GJPsWi2j6mX4nzKiMVxBJcmOHvXpqX/Kz9T4Z3aeO5dtb9TFD0eOh/VwizeREXsy7 45X6Wggvxm2n3gRUsonnslWdFtkirvIdOKYmuTAfurTeC/2bzCnJIeR0pn1N85tkqtWZ yGRt+8LqLSbIZColwCmMbhD0C2LOnfK2ISVO5YfU4pYCbcVDPnmXhMQjjc+0T0z549HI rscG8/c3+bQm8YBqulrXUMHdTNwd70dxV23OslDbMgNUCFzkZW1+amJp/Ap6WLF9S/9F NLOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=7vTxFzSmXvbhkoGh8d8C/6rO3yo9zYPRzmdYLxOFfbI=; b=cii6ZrcdMH16WpdwSlVR/4DZxNqypSZuiiUhdNzdwPrZpCCE5TkaYbCYXHhM0dAyOO ZqHOj5RzYApAO8R/r8MQlYXtBCIXGpeUUMdIHm8XP3L+ykTH6aiM7SANq/wS8MYem624 ZSc8jyiF0g6kNvpkCvhu7atxL4LjFgqlE3x1byC5zUE5Q7w82S+GCtrOD5MFhOHeBmvC VmzUflRhF3jwvydHKk9nlALFIs0SgHqOy4LomOLPFRCUQippym3WuKmFExHSKSUFmnBY B/6o9YPXbhKAOfXvqQK+rm25grii42z/m80L4hsvunWbIV2BhmkksKJ+shFKesC+88oP tvGA== X-Gm-Message-State: AMke39lABfuS3W+U1b1cW3AdPJ7arE3gQ3bqIxmPmJFk3Q/QOjp2IHGUWZ6j4/m7Pks1NQ== X-Received: by 10.107.130.80 with SMTP id e77mr8721195iod.193.1487375805255; Fri, 17 Feb 2017 15:56:45 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id n75sm1262398itg.19.2017.02.17.15.56.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Feb 2017 15:56:44 -0800 (PST) From: npostavs@users.sourceforge.net To: Drew Adams Subject: Re: bug#25678: 25.1; defcustom type `(file :must-match t)' seems not to work References: <77a3abe9-258c-4863-a87d-2f236babafe4@default> Date: Fri, 17 Feb 2017 18:57:56 -0500 In-Reply-To: <77a3abe9-258c-4863-a87d-2f236babafe4@default> (Drew Adams's message of "Fri, 10 Feb 2017 10:32:23 -0800 (PST)") Message-ID: <871suwl69n.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 25678 Cc: 25678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Drew Adams writes: > (defcustom foo-file "" > "" > :type '(file :must-match t) :group 'convenience) > > M-x customize-option foo-file > > I don't see anything that prevents you from using a file name that > corresponds to no existing file. I don't see that completion (`M-TAB') > enforces it to name an existing file. And I don't see that simply > inserting a bad file name is prevented, nor is setting the option to a > bad file name or saving it prevented. > > What effect does (file :must-match t) actually have, if any? It looks like `widget-file-prompt-value' consults it, but I can't tell when this function is called. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 14 18:07:16 2018 Received: (at 25678) by debbugs.gnu.org; 14 Jan 2018 23:07:16 +0000 Received: from localhost ([127.0.0.1]:56449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1earMy-0003zu-HA for submit@debbugs.gnu.org; Sun, 14 Jan 2018 18:07:16 -0500 Received: from mezzogiorno.tim-landscheidt.de ([78.47.87.37]:36622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1earMx-0003zm-9M for 25678@debbugs.gnu.org; Sun, 14 Jan 2018 18:07:15 -0500 Received: from dslb-092-076-023-076.092.076.pools.vodafone-ip.de ([92.76.23.76]:49630 helo=passepartout.tim-landscheidt.de) by mezzogiorno.tim-landscheidt.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1earMv-0006yb-EB; Sun, 14 Jan 2018 23:07:13 +0000 From: Tim Landscheidt To: npostavs@users.sourceforge.net Subject: Re: bug#25678: 25.1; defcustom type `(file :must-match t)' seems not to work Organization: http://www.tim-landscheidt.de/ References: <77a3abe9-258c-4863-a87d-2f236babafe4@default> <871suwl69n.fsf@users.sourceforge.net> Date: Sun, 14 Jan 2018 23:07:12 +0000 In-Reply-To: <871suwl69n.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Fri, 17 Feb 2017 18:57:56 -0500") Message-ID: <87h8rot4yn.fsf@passepartout.tim-landscheidt.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25678 Cc: 25678@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) AFAICT, this setting is only obeyed when executing M-x customize-set-value RET foo-file RET. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 21 13:36:36 2020 Received: (at 25678) by debbugs.gnu.org; 21 Mar 2020 17:36:36 +0000 Received: from localhost ([127.0.0.1]:47942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFi32-0000B6-DX for submit@debbugs.gnu.org; Sat, 21 Mar 2020 13:36:36 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:45279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFi2z-0000Ar-IG for 25678@debbugs.gnu.org; Sat, 21 Mar 2020 13:36:34 -0400 Received: from ping ([92.116.129.179]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N63i4-1jMP4K0Z1k-016PWk; Sat, 21 Mar 2020 18:36:08 +0100 From: dieter@duenenhof-wilhelm.de (H. Dieter Wilhelm) To: Tim Landscheidt Subject: Re: bug#25678: 25.1; defcustom type `(file :must-match t)' seems not to work References: <77a3abe9-258c-4863-a87d-2f236babafe4@default> <871suwl69n.fsf@users.sourceforge.net> <87h8rot4yn.fsf@passepartout.tim-landscheidt.de> Date: Sat, 21 Mar 2020 18:36:07 +0100 In-Reply-To: <87h8rot4yn.fsf@passepartout.tim-landscheidt.de> (Tim Landscheidt's message of "Sun, 14 Jan 2018 23:07:12 +0000") Message-ID: <86zhc9liew.fsf@duenenhof-wilhelm.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:rBcd/GJzVpNPowHXe5KEqzf3NH6+LWHMKD/+81YYuZSoaXiSxQY 6Xr/XQw4sNQuUyLqOeTQkKd4Bfib96CDCTQ9rV2dhq4d1X/FeRioOa0Wj5aDPXoyz8bxyJ2 5Bm1bgwd+Wj1XK52CYQar8p0pTyZL9X9rCaasEsG+O1jaDnNW0sh9gCNJxdiB6nOXUzhaW6 XX2Qt6U+oZJDmT9bpw9oQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:VaV9BkSfJBE=:6mj4wlgb/c3CwycQKgejWr 6feF9eDhDeGsg3E5L5JVoBGS4dPV8eFqM5z//gunwf695A9Ie08sVXkdcqUmj8frgw+0TeGBP MwdHdYhDsUIBjrUrbJTnKL2R4rotzcKUFN0DeymPNdXdbl3YOSFp46vRBhyLtNXo3sn4QUIqg KKfHX4ojOigECtj86tPc5BLw5IZYbAVSj1MZb8t9AzyGalcznYDiN6hod6c7CcyQCRYlhnXYS Y85TS3mjf6BGIu+MavJLGIIbuwdMP6UowqpgDrnCCBNzDomweGOmCRS6qNkjsHUN+ynkDbzvA kdDaNjGb7Houucx0jvks5zxisvNilmrp9w/dDixoXxij98hH40cBTdxLN6AzZmfMyPCkpEyV2 1FNifCyUsuezNVivNjhgU5zTmJ/q/xUo93dnWvRF1vnRL6PHlfeugYG5cBmvfzvdDAJ9YHbuP YxXuuj/5gG1WIWwsi3HU/NPfmFuiHFPLj9NyWZ+X+fNa/4dtNNLDNWEHF+RW8XnxJ6qOZIODR +WWj0uL62G920fVE3EXUKa23zmT/sZRcvyU3bt5CSi88HhdS0icHSqB8bD1PfNRG6MHf7aLh4 niU6XuAL8urW17pZoylHxdg+3rc1LrNuRNxz74Zlju5xByWGC80+K3vo9zdWMVQFVdOVTjVlC 9ULP84+EexfRbrVPOxhU+Im7u2XxhYMb84b+0OfH3ioxWupFtogAomZJqU9w/Cq2/BAgw3EdY ezXNv22Fj32A/QcG9IXCh+cpSjCmNnJyCntb9+aw8uNIjvbt983ErrxqSc/y8BarhIjeQMnBr UH7hu/79O5hSZ3l4R038JHOnkKxuJoYacC5Yk1T9gaa8uJ0mWzkL/xdtND0rdMAuQSy54oJ X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25678 Cc: 25678@debbugs.gnu.org, Drew Adams , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tim Landscheidt writes: > AFAICT, this setting is only obeyed when executing M-x > customize-set-value RET foo-file RET. Right, customize-set-value is working but Easy Customizations claims: (info (emacs) Changing a Variable) [State]: SET for current session only. You don=E2=80=99t have to worry about specifying a value that is not valid= ; the =E2=80=98Set for Current Session=E2=80=99 operation checks for validity an= d will not install an unacceptable value. Which is clearly not the case in Emacs-26.3 Thanky you Dieter --=20 Best wishes H. Dieter Wilhelm Zwingenberg, Germany From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 21 13:38:45 2020 Received: (at control) by debbugs.gnu.org; 21 Mar 2020 17:38:46 +0000 Received: from localhost ([127.0.0.1]:47946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFi57-0000Ej-Oh for submit@debbugs.gnu.org; Sat, 21 Mar 2020 13:38:45 -0400 Received: from mail-qv1-f50.google.com ([209.85.219.50]:40460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFi56-0000EW-Db for control@debbugs.gnu.org; Sat, 21 Mar 2020 13:38:44 -0400 Received: by mail-qv1-f50.google.com with SMTP id cy12so4895677qvb.7 for ; Sat, 21 Mar 2020 10:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=oO7DfdAh7gm2IMYPQ8asx1W88P9klb2XSzUwn1UyUd0=; b=WcjcxXu3/r2WpFxrTqgnKNDBlKnNoFahiopbh8cGHdDWjEC/IgT7tKqLYKKEqcfj/f oacsXBlDDDSserGFQ/J/jC9c8dCqt6/NXeZodkYHuQm5OFGxVQWnrTB9oVFriWi4WLZf 7HMyZn7MX5luYyRh7SW5WwoQepBr/0CJKaAHjfypWgFbuXzjCq3Xxt0eJQoRGqjug6Dx HT7TbovDmx0IyhvdwgH3kPFfmBaHpTlqbUJ4VyAWxJfG/+f3AxIlJzEOm/als4sDabUF R5lsNvksT9EvgbxLaY1fBd+VaDPagxS51tmzzgVQcFyxJPzvoqLZSSeGsK6hZYy5hPy8 A1oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=oO7DfdAh7gm2IMYPQ8asx1W88P9klb2XSzUwn1UyUd0=; b=pDBsv9xM+bowBew7DAQvShWRV1m+pT3cnSef3LjZgapGfZQeJyV7yY9Hkg7Rnm4E1V dac5O62D9GQKTwqTBs9Byc1wFsrWwpnc3axa+qUSV/q0LMXNWc7i04B9aP5bgMjGTvl1 GrttBJELn5o3qzxWWDplUs4rZvkrIzwec/HbyzvhG1J8C71USp/Ip22l5TEqYfFiXhcK ih9iL57UmFT3wRs7I7jitkutuXyYF/F79J3LWQNNQMFY445MrWddBL9I0OOpXNuNa/dw 66SJZAjZfcECQYySum4KgH7Nl/usvj9G+MNKcLBVTF8jaudh6lEMPJzgjUDmymMDG03z vwzw== X-Gm-Message-State: ANhLgQ0oL15+KlIUenf7JH1uMYAK2ClGLEbq0s69C6+nsT+0gZulI6xE 3i8FYODLrjYJa+Y+O87Imxq0vI7U X-Google-Smtp-Source: ADFU+vsbN7Kj4yiG+u5JA2VDNCsx7FuOjUC8M/NQ5HWK6MGbehXkv0L6x3fYnzmbR8CsTVHhgW9yOg== X-Received: by 2002:a0c:bd2a:: with SMTP id m42mr14279327qvg.163.1584812318656; Sat, 21 Mar 2020 10:38:38 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id f19sm3637132qtq.78.2020.03.21.10.38.38 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Mar 2020 10:38:38 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #25678 Date: Sat, 21 Mar 2020 13:38:37 -0400 Message-ID: <87a749liaq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) found 25678 26.3 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 11:33:35 2020 Received: (at 25678) by debbugs.gnu.org; 29 Aug 2020 15:33:35 +0000 Received: from localhost ([127.0.0.1]:48878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2rH-0002db-BA for submit@debbugs.gnu.org; Sat, 29 Aug 2020 11:33:35 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:34609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2rE-0002dN-TL for 25678@debbugs.gnu.org; Sat, 29 Aug 2020 11:33:33 -0400 Received: by mail-wr1-f48.google.com with SMTP id f7so1912916wrw.1 for <25678@debbugs.gnu.org>; Sat, 29 Aug 2020 08:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=4dsNax6gIc2Zsdz0BYb2i4v8pt8mrzsiwKPagLi/L54=; b=HT0iBiPh9esbkoerj9QbntK7M1fWQhwOFC3y9K+0TNFMHjj+qe9im1Ivq0iDaI+Pjt ymah0/lQ8O7kMnt5Qs+rqnAxpLxxYyzFAEo+qCDBEAI2yVKK/eGrqJSB16IxD89PeClY upYcl6QkjyP6mB2XC8T9aiONRVBNzUtoJSwGql87nT2Hv777O6SMG4ttE9HhnnZMEC0u eK3LMYdj21SvTayclqteLtE1TXNzhyUIy6+fXYq4+ajv0H5MVf1jRLHH8U7cTPeuTSV3 zFYEeMawdoI7YSFTxlHC9qiVD1UdPgbVFXZ3q/7EnAZsZSTen6BwUg3R3g9ZvKD3UBr3 +PVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=4dsNax6gIc2Zsdz0BYb2i4v8pt8mrzsiwKPagLi/L54=; b=S5FDkIflQkK1B6+9ZTgGfQNa+rVNlIysZ9dr987QcyLRcRTK2vWkXKBZMM4+1Zh1Qx uEXKzS1DxQhStDFmXgwlh2Q3KGx7LkyqGZIDb5jcSTZuKuTyhh9OowZkN4L5vcmsnqnM hQAIPZ/f+Q1GjjJ0+Ge3/l9IrNnqMJj/9GDU1AC1oLmeEn+8wPS8l5TDySY6SZKfsENO //LDk5gFjNGB+ge2ZMc+mzW3heyApE0dPD18LHtqp0dOxfxRwOHH74ovyarXxpHIZQQv nFMe3Ju48CVuYy1PIhSN6mUk8UbMx8J3dVwFWc/HyiriIvuvTelwZZifPuqOh3GcEbYd JaVw== X-Gm-Message-State: AOAM5315Qn7nnUnJ6fFEvR54o+h5SPtt2w5bU+oJro9d2WpGoQ0eTPtT 0hSY25zLy2VP6wN+MnDzv1M901OK56Iz0zaXvaGqx61nwsoryjrK X-Google-Smtp-Source: ABdhPJxcIhS0uo5UujANci+GhRyOBU242pk5e/EeT+p0/Th4ceHgj3GPl8Z+CobANsB8aArCqZBn5pPLEVQOp3fDM6Q= X-Received: by 2002:a5d:540c:: with SMTP id g12mr3894769wrv.120.1598715206715; Sat, 29 Aug 2020 08:33:26 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Sat, 29 Aug 2020 12:33:15 -0300 Message-ID: Subject: Re: bug#25678: 25.1; defcustom type `(file :must-match t)' seems not to work To: 25678@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000fe83b305ae05e393" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25678 Cc: dieter@duenenhof-wilhelm.de, Noam Postavsky , Drew Adams , tim@tim-landscheidt.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000fe83b305ae05e393 Content-Type: multipart/alternative; boundary="000000000000fe83b105ae05e391" --000000000000fe83b105ae05e391 Content-Type: text/plain; charset="UTF-8" I think it makes sense to expand the impact of :must-match t to Customization buffers, like in the attached patch. --000000000000fe83b105ae05e391 Content-Type: text/html; charset="UTF-8"
I think it makes sense to expand the impact of :must-match t to
Customization buffers, like in the attached patch.
--000000000000fe83b105ae05e391-- --000000000000fe83b305ae05e393 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Respect-must-match-for-file-types-in-customization-b.patch" Content-Disposition: attachment; filename="0001-Respect-must-match-for-file-types-in-customization-b.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_keftqpgx0 RnJvbSAxMDg5NmRlZGZjNjg2MWRjYzY0ZGQ4NzA1ODE4ZGFjYzZhYWEwYTk4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFdlZCwgMjYgQXVnIDIwMjAgMTI6NDk6NTggLTAzMDAKU3ViamVjdDogW1BBVENIXSBS ZXNwZWN0IDptdXN0LW1hdGNoIGZvciBmaWxlIHR5cGVzIGluIGN1c3RvbWl6YXRpb24gYnVmZmVy cwoKKiBsaXNwL3dpZC1lZGl0LmVsIChmaWxlIHdpZGdldCk6IEFkZCBhIDptYXRjaCBhbmQgYSA6 dmFsaWRhdGUKICBmdW5jdGlvbiB0byB0aGUgJ2ZpbGUgd2lkZ2V0LCB0byBiZSBhYmxlIHRvIGNo ZWNrIGlmIHRoZSB3aWRnZXQKICB2YWx1ZSBpcyBhbiBleGlzdGVudCBmaWxlLCB3aGVuIHJlcXVp cmVkLiAgKEJ1ZyMyNTY3OCkKLS0tCiBsaXNwL3dpZC1lZGl0LmVsIHwgOSArKysrKysrKysKIDEg ZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL3dpZC1lZGl0 LmVsIGIvbGlzcC93aWQtZWRpdC5lbAppbmRleCBlYTdlMjY2ZTBkLi4xMDE1ZjAxMGNlIDEwMDY0 NAotLS0gYS9saXNwL3dpZC1lZGl0LmVsCisrKyBiL2xpc3Avd2lkLWVkaXQuZWwKQEAgLTMxNjEs NiArMzE2MSwxNSBAQCAnZmlsZQogICA6Y29tcGxldGlvbnMgKGNvbXBsZXRpb24tdGFibGUtY2Fz ZS1mb2xkCiAgICAgICAgICAgICAgICAgIydjb21wbGV0aW9uLWZpbGUtbmFtZS10YWJsZQogICAg ICAgICAgICAgICAgIChub3QgcmVhZC1maWxlLW5hbWUtY29tcGxldGlvbi1pZ25vcmUtY2FzZSkp CisgIDptYXRjaCAjJyhsYW1iZGEgKHdpZGdldCB2YWx1ZSkKKyAgICAgICAgICAgICAob3IgKG5v dCAod2lkZ2V0LWdldCB3aWRnZXQgOm11c3QtbWF0Y2gpKQorICAgICAgICAgICAgICAgICAoZmls ZS1leGlzdHMtcCB2YWx1ZSkpKQorICA6dmFsaWRhdGUgIycobGFtYmRhICh3aWRnZXQpCisgICAg ICAgICAgICAgICAgKGxldCAoKHZhbHVlICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSkpCisgICAgICAg ICAgICAgICAgICAodW5sZXNzICh3aWRnZXQtYXBwbHkgd2lkZ2V0IDptYXRjaCB2YWx1ZSkKKyAg ICAgICAgICAgICAgICAgICAgKHdpZGdldC1wdXQgd2lkZ2V0CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDplcnJvciAoZm9ybWF0ICJGaWxlICVzIGRvZXMgbm90IGV4aXN0IiB2YWx1 ZSkpCisgICAgICAgICAgICAgICAgICAgIHdpZGdldCkpKQogICA6cHJvbXB0LXZhbHVlICd3aWRn ZXQtZmlsZS1wcm9tcHQtdmFsdWUKICAgOmZvcm1hdCAiJXsldCV9OiAldiIKICAgOzsgRG9lc24n dCB3b3JrIHdlbGwgd2l0aCB0ZXJtaW5hdGluZyBuZXdsaW5lLgotLSAKMi4yOC4wCgo= --000000000000fe83b305ae05e393-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 09:56:37 2020 Received: (at 25678) by debbugs.gnu.org; 30 Aug 2020 13:56:37 +0000 Received: from localhost ([127.0.0.1]:50418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNoz-0001Iv-0d for submit@debbugs.gnu.org; Sun, 30 Aug 2020 09:56:37 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNow-0001Ih-OS for 25678@debbugs.gnu.org; Sun, 30 Aug 2020 09:56:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1Y0d5jRnb/hnvYDnH9v0ZV8q8ZqG5FqqX3gc4ATgGuY=; b=t3eENmGH8QvpFi5ZCd8EYO6jUQ N15+blG2TkRv1UTkNrVtbQZmNXmBYXgF3SzKK7c6WgfZv7NCM5tS3NpAPtmCRlN2cl4qFwiWgT1AX iVCvJfDcDWNhhZSZLh/d0MrFAvWceCo8WQjqHYvpE9dMLOGF2QFhBDAR+syq4MeyCzQE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCNoh-0001KK-Kn; Sun, 30 Aug 2020 15:56:27 +0200 From: Lars Ingebrigtsen To: Mauro Aranda Subject: Re: bug#25678: 25.1; defcustom type `(file :must-match t)' seems not to work References: <77a3abe9-258c-4863-a87d-2f236babafe4@default> X-Now-Playing: Mega Bog's _Dolphine_: "Spit In The Eye Of The Fire King (by Ash Rickli)" Date: Sun, 30 Aug 2020 15:56:17 +0200 In-Reply-To: (Mauro Aranda's message of "Sat, 29 Aug 2020 12:33:15 -0300") Message-ID: <87pn78s0e6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > I think it makes sense to expand the impact of :must-match t to > Customization buffers, like in the attached patch. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25678 Cc: dieter@duenenhof-wilhelm.de, 25678@debbugs.gnu.org, Noam Postavsky , Drew Adams , tim@tim-landscheidt.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > I think it makes sense to expand the impact of :must-match t to > Customization buffers, like in the attached patch. [...] > + :match #'(lambda (widget value) > + (or (not (widget-get widget :must-match)) > + (file-exists-p value))) Makes sense to me. I've now applied this to Emacs 28 (but I removed the #''s before the lambdas first (they're superfluous)). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 09:56:40 2020 Received: (at control) by debbugs.gnu.org; 30 Aug 2020 13:56:40 +0000 Received: from localhost ([127.0.0.1]:50421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNp2-0001JA-8y for submit@debbugs.gnu.org; Sun, 30 Aug 2020 09:56:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNp0-0001Im-UI for control@debbugs.gnu.org; Sun, 30 Aug 2020 09:56:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ITtaXuu0xtyTTTbLCyPI4SwMAgG0L0JxcIMDzX6LEnw=; b=GtCHxYSa02qSOHDcmy7BQt9cH3 UkLs2bdSOnDk+VdXGE4oR9tMvgJDTwty+Cmc8fLaUN7rh81Ni/2TPMLAKOmL+Q4g6bCzhOy91Q0ev JeiKyGLxQY4Zr73ZVoOSvWUA3Cohf/8YYbyNK4JjiqGgoLwR2PO5p9QBidzwWSnkZnzc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCNot-0001KZ-3m for control@debbugs.gnu.org; Sun, 30 Aug 2020 15:56:33 +0200 Date: Sun, 30 Aug 2020 15:56:29 +0200 Message-Id: <87o8mss0du.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #25678 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 25678 fixed close 25678 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 25678 fixed close 25678 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 11:22:54 2020 Received: (at 25678) by debbugs.gnu.org; 30 Aug 2020 15:22:54 +0000 Received: from localhost ([127.0.0.1]:50563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCPAU-0005fT-8U for submit@debbugs.gnu.org; Sun, 30 Aug 2020 11:22:54 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:53897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCPAS-0005fH-IO for 25678@debbugs.gnu.org; Sun, 30 Aug 2020 11:22:53 -0400 Received: by mail-wm1-f50.google.com with SMTP id u18so3206600wmc.3 for <25678@debbugs.gnu.org>; Sun, 30 Aug 2020 08:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XY2l6calclyu6PiO52aKk2XamuioQ5sUxLDelJt1BeU=; b=qD2loWcyAq3wClPff6RvEt8ML0AQtEPYpiJSiwhxSHYC8ybedHRx/Gqry8ukYTrLT3 WqfNQIb6pYexDkrKlXBt+US0xIQVZJtl//8k6xnsIuHISnjG9praiMRpmNfByOY+5lDb mSzGGxQKzptZ844tRpZFzBz2GKpD7j0jmcnv2MSm74J9MjyL0fICZVdHL0c0QnDeuLPE CulMqRsoUuEz99kqdEuBlzVB7Lvb5Hi2UwpZjsUz584BKRNwEPoC5fb58I81dIxVMs8b cQiNhVaZI+2Rr8q3oE8apNSTMAw1hxm3qR9TcnQZkaG9OQ/XIFitpyF65MC8yZTqO2wr +w+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XY2l6calclyu6PiO52aKk2XamuioQ5sUxLDelJt1BeU=; b=kJrhbqTxqd465MuzJHZKdm3Eti3kqvRilwOcHYNCk7u+kKIUVD22T1Q4ztV7nr4jHx qRI64vI3r0MyiWYM05MxE698cgCRKrJw7XijhuvYVx+HauOIdimEehCMp6MHvfgMK27O nCumfMaVTOpFymj3wCX/q2Y4N4TrM+5VNuMZkF8Q67THfVSHhqJStLwr3ZBTS0dAEC5Q 5/lFSUUyxtKsGjMmv8eiwmpFsh2Nq5Mw8DQx2vmLDnVGYHb980dOzpdKyDFxAQajH5Y+ OpcoU7aU/7uLbJrFa7H9lJAsTiEK8Hf4r8nZN9OoUZUaAZBp8skQmbDax56jx0AWBjpx Iswg== X-Gm-Message-State: AOAM530LIcHRJd0U/UZQ1zOUaKl5sCRetay7p/G50vXybRIhg82fU3PD hqGmRs4stIAMoBAHOdllqcp+ZGdSVmjavT89ZiE= X-Google-Smtp-Source: ABdhPJyv3LEl/t6PdrJwGadse1WDYAM6/HLb9EPYghVvl8ct0Pl8N5acuWl81EFm0rwxgktM6lPzwv1hQI2BQKyjuag= X-Received: by 2002:a7b:cc90:: with SMTP id p16mr7533795wma.100.1598800966805; Sun, 30 Aug 2020 08:22:46 -0700 (PDT) MIME-Version: 1.0 References: <77a3abe9-258c-4863-a87d-2f236babafe4@default> <87pn78s0e6.fsf@gnus.org> In-Reply-To: <87pn78s0e6.fsf@gnus.org> From: Mauro Aranda Date: Sun, 30 Aug 2020 12:22:34 -0300 Message-ID: Subject: Re: bug#25678: 25.1; defcustom type `(file :must-match t)' seems not to work To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="000000000000b16e7705ae19dbe2" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25678 Cc: dieter@duenenhof-wilhelm.de, 25678@debbugs.gnu.org, Noam Postavsky , Drew Adams , tim@tim-landscheidt.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b16e7705ae19dbe2 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> I think it makes sense to expand the impact of :must-match t to >> Customization buffers, like in the attached patch. > > [...] > >> + :match #'(lambda (widget value) >> + (or (not (widget-get widget :must-match)) >> + (file-exists-p value))) > > Makes sense to me. I've now applied this to Emacs 28 (but I removed the > #''s before the lambdas first (they're superfluous)). Noted. Thanks for taking the trouble! --000000000000b16e7705ae19dbe2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
= >> I think it makes sense to expand the impact of :must-match t to>> Customization buffers, like in the attached patch.
>
>= ; [...]
>
>> + =C2=A0:match #'(lambda (widget value)
= >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (or (not (widget-get w= idget :must-match))
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 (file-exists-p value)))
>
> Makes sense to me.= =C2=A0 I've now applied this to Emacs 28 (but I removed the
> #&#= 39;'s before the lambdas first (they're superfluous)).

Noted= .=C2=A0 Thanks for taking the trouble!
--000000000000b16e7705ae19dbe2-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 13:21:31 2020 Received: (at 25678) by debbugs.gnu.org; 9 Sep 2020 17:21:31 +0000 Received: from localhost ([127.0.0.1]:33185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG3ml-0008M8-Hh for submit@debbugs.gnu.org; Wed, 09 Sep 2020 13:21:31 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG3mk-0008Lv-5Z for 25678@debbugs.gnu.org; Wed, 09 Sep 2020 13:21:30 -0400 Received: by mail-wr1-f67.google.com with SMTP id o5so3769124wrn.13 for <25678@debbugs.gnu.org>; Wed, 09 Sep 2020 10:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lGXxNnwxDMyiXocPiSfV+7T/7Mm6vIis77jvx8QFFCk=; b=MWKwfRf1uWHKrCLKubzlnql1EdHab/y9YXCEMpU2a5sSTUNDdLo2SfqhJwO402afm7 qYkqBZfOsF4b8OFk1jPWpJmE3XTIr8NCeTZWylgXWibP1S0B5YhJRsoasiPxQBp2KfYV MOnXosMZt3ea6JHQ+pr4yMDFEWi+bkxnHDwaap9Zpb3WqAbpd4sCV6BKFErdBUvPlzCP kVkAmjylwb6K5+IEkTcc9kzoh9ul77bpivGxMdhE1ZZoUWulyNZSnywOFCZkVzVy5uvo ml8aSUvpdHb4Cx+PEEL4slo+f8cA97JQo1RxGBPJW7kmSbWTSgEVjNE346RS/Oo8XUSa lulA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lGXxNnwxDMyiXocPiSfV+7T/7Mm6vIis77jvx8QFFCk=; b=CZcEIea+/5RFz7kukLTnP1ZZ6Cbh8vLam2o2jaTAgd1Nw9pplwpeYz7FmWlouCojd0 Wn/l/Ra732D18jTZdaIHpavwvkMJSUPxh3qksR5bcKydQ8b/+/1OY8b4zl5zCAwI5ITp vQrk5I2lwyKMekWaI01XFkfTl2hx8W18tDT5c2ws+RinBowaInpRhAfyZ+lqb8UZX2cE mmcLE4lBvrQ4EalrNea4SwFRwoix0noLm251sOt8ibd1BTuUVlaO5QRDDyiR7r7EaFtp OeUe04JtN06/kxVm9344684SPqRSZpG/y/LOuWf1nTpPFl/R9LkX/U7U8ifQGgVJCusz weQg== X-Gm-Message-State: AOAM532/EhNXSyXKlttwZdN7gqoX5fBX5fvNGzmm+lOab+ATRS1lXSfi 0/9H2LVNWpVveoHcbso/lLfL8hl9wOf8uFaN2ao= X-Google-Smtp-Source: ABdhPJwuBIfg7TT6pk6q3LSkcFNxq0cHBdGih5WutcImNxDI/A+oBzt+p1C0rCpbBLTV/DXjqRtjoifMuPxey/s/Ec8= X-Received: by 2002:adf:9f10:: with SMTP id l16mr5216988wrf.77.1599672084230; Wed, 09 Sep 2020 10:21:24 -0700 (PDT) MIME-Version: 1.0 References: <77a3abe9-258c-4863-a87d-2f236babafe4@default> <87pn78s0e6.fsf@gnus.org> In-Reply-To: <87pn78s0e6.fsf@gnus.org> From: Mauro Aranda Date: Wed, 9 Sep 2020 14:21:11 -0300 Message-ID: Subject: Re: bug#25678: 25.1; defcustom type `(file :must-match t)' seems not to work To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="00000000000056940205aee4ae95" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25678 Cc: dieter@duenenhof-wilhelm.de, 25678@debbugs.gnu.org, Noam Postavsky , Drew Adams , tim@tim-landscheidt.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000056940205aee4ae95 Content-Type: multipart/alternative; boundary="00000000000056940005aee4ae93" --00000000000056940005aee4ae93 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> I think it makes sense to expand the impact of :must-match t to >> Customization buffers, like in the attached patch. > > [...] > >> + :match #'(lambda (widget value) >> + (or (not (widget-get widget :must-match)) >> + (file-exists-p value))) > > Makes sense to me. I've now applied this to Emacs 28 (but I removed the > #''s before the lambdas first (they're superfluous)). I found that the :match function will return false positives when :must-match is nil and value is not a string. This can happen is the defcustom is of type: :type '(choice file (const nil))), and the value is nil, because we check if nil matches with the widget file first. Here's a patch to fix it. --00000000000056940005aee4ae93 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
= >> I think it makes sense to expand the impact of :must-match t to>> Customization buffers, like in the attached patch.
>
>= ; [...]
>
>> + =C2=A0:match #'(lambda (widget value)
= >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (or (not (widget-get w= idget :must-match))
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 (file-exists-p value)))
>
> Makes sense to me.= =C2=A0 I've now applied this to Emacs 28 (but I removed the
> #&#= 39;'s before the lambdas first (they're superfluous)).

I fou= nd that the :match function will return false positives when
:must-match= is nil and value is not a string.=C2=A0 This can happen is
the defcusto= m is of type:
:type '(choice file (const nil))), and the value is ni= l, because we
check if nil matches with the widget file first.

He= re's a patch to fix it.


--00000000000056940005aee4ae93-- --00000000000056940205aee4ae95 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-match-function-for-the-file-widget.patch" Content-Disposition: attachment; filename="0001-Fix-match-function-for-the-file-widget.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kevnelsm0 RnJvbSBkNmFiZTE1ZGE1ZmYzOTk5NmFiNGY1ZWJmYmMzNDI4ZTkyMDE3NDUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFdlZCwgOSBTZXAgMjAyMCAxNDoxMTo0OSAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCA6bWF0Y2ggZnVuY3Rpb24gZm9yIHRoZSBmaWxlIHdpZGdldAoKKiBsaXNwL3dpZC1lZGl0LmVs IChmaWxlIHdpZGdldCk6IFJldHVybiBuaWwgaWYgdmFsdWUgaXMgbm90IGEKICBzdHJpbmcuICAo QnVnIzI1Njc4KQotLS0KIGxpc3Avd2lkLWVkaXQuZWwgfCA1ICsrKy0tCiAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avd2lk LWVkaXQuZWwgYi9saXNwL3dpZC1lZGl0LmVsCmluZGV4IGU5Nzk5ZGMwMGYuLmJjMmFmYzZhNmYg MTAwNjQ0Ci0tLSBhL2xpc3Avd2lkLWVkaXQuZWwKKysrIGIvbGlzcC93aWQtZWRpdC5lbApAQCAt MzE2Miw4ICszMTYyLDkgQEAgJ2ZpbGUKICAgICAgICAgICAgICAgICAjJ2NvbXBsZXRpb24tZmls ZS1uYW1lLXRhYmxlCiAgICAgICAgICAgICAgICAgKG5vdCByZWFkLWZpbGUtbmFtZS1jb21wbGV0 aW9uLWlnbm9yZS1jYXNlKSkKICAgOm1hdGNoIChsYW1iZGEgKHdpZGdldCB2YWx1ZSkKLSAgICAg ICAgICAgKG9yIChub3QgKHdpZGdldC1nZXQgd2lkZ2V0IDptdXN0LW1hdGNoKSkKLSAgICAgICAg ICAgICAgIChmaWxlLWV4aXN0cy1wIHZhbHVlKSkpCisgICAgICAgICAgIChhbmQgKHN0cmluZ3Ag dmFsdWUpCisgICAgICAgICAgICAgICAgKG9yIChub3QgKHdpZGdldC1nZXQgd2lkZ2V0IDptdXN0 LW1hdGNoKSkKKyAgICAgICAgICAgICAgICAgICAgKGZpbGUtZXhpc3RzLXAgdmFsdWUpKSkpCiAg IDp2YWxpZGF0ZSAobGFtYmRhICh3aWRnZXQpCiAgICAgICAgICAgICAgIChsZXQgKCh2YWx1ZSAo d2lkZ2V0LXZhbHVlIHdpZGdldCkpKQogICAgICAgICAgICAgICAgICh1bmxlc3MgKHdpZGdldC1h cHBseSB3aWRnZXQgOm1hdGNoIHZhbHVlKQotLSAKMi4yOC4wCgo= --00000000000056940205aee4ae95-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 10 09:13:24 2020 Received: (at 25678) by debbugs.gnu.org; 10 Sep 2020 13:13:24 +0000 Received: from localhost ([127.0.0.1]:37615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGMOC-0006Td-BA for submit@debbugs.gnu.org; Thu, 10 Sep 2020 09:13:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGMOA-0006TM-I8 for 25678@debbugs.gnu.org; Thu, 10 Sep 2020 09:13:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Uc3x+y/ZQpoeD8kB3XCvCcvx3XmHoARWFAWWN3HNdIk=; b=PpL2wAhZp6+T9nwTOGfaLzaCEa H6wW8D/boXEVsy7TWBnyca3pEioVlCrTJez3ypaf32vlpyt4e1ibQNemPNKbRHWe4EAzcVN/DlDqQ 8DGCz6Dy/u4zFsCScmOQbwhY7oE6Y3eDW+USXw0BBk0CNW4r6glzbygScMp46XJ5EYkk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGMO0-0006ju-1A; Thu, 10 Sep 2020 15:13:14 +0200 From: Lars Ingebrigtsen To: Mauro Aranda Subject: Re: bug#25678: 25.1; defcustom type `(file :must-match t)' seems not to work References: <77a3abe9-258c-4863-a87d-2f236babafe4@default> <87pn78s0e6.fsf@gnus.org> X-Now-Playing: Various's _Disco Rallado_: "Jason Forrest - Song For My Grandmother" Date: Thu, 10 Sep 2020 15:13:10 +0200 In-Reply-To: (Mauro Aranda's message of "Wed, 9 Sep 2020 14:21:11 -0300") Message-ID: <87mu1x7p21.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > I found that the :match function will return false positives when > :must-match is nil and value is not a string. This can happen is > the defcustom is of type: > :type '(choice file (const nil))), [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25678 Cc: dieter@duenenhof-wilhelm.de, 25678@debbugs.gnu.org, Noam Postavsky , Drew Adams , tim@tim-landscheidt.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > I found that the :match function will return false positives when > :must-match is nil and value is not a string. This can happen is > the defcustom is of type: > :type '(choice file (const nil))), and the value is nil, because we > check if nil matches with the widget file first. > > Here's a patch to fix it. Thanks; applied to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 22:44:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Oct 2020 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator