GNU bug report logs - #25677
[PATCH 01/22] oldXMenu: add missing #include <string.h>

Previous Next

Package: emacs;

Reported by: Michal Nazarewicz <mina86 <at> mina86.com>

Date: Fri, 10 Feb 2017 18:17:02 UTC

Severity: minor

Tags: patch

Done: Michal Nazarewicz <mina86 <at> mina86.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michal Nazarewicz <mina86 <at> mina86.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#25677: closed ([PATCH 01/22] oldXMenu: add missing #include
 <string.h>)
Date: Wed, 15 Feb 2017 16:14:02 +0000

[Message part 1 (text/plain, inline)]
Your message dated Wed, 15 Feb 2017 17:13:13 +0100
with message-id <xa1twpcr5t5y.fsf <at> mina86.com>
and subject line Re: [PATCH 01/22] oldXMenu: add missing #include <string.h>
has caused the debbugs.gnu.org bug report #25677,
regarding [PATCH 01/22] oldXMenu: add missing #include <string.h>
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
25677: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25677
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Michal Nazarewicz <mina86 <at> mina86.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH 01/22] oldXMenu: add missing #include <string.h>
Date: Fri, 10 Feb 2017 19:16:37 +0100

Some of the files in oldXMenu use functions from string.h without
including that header which results in compile warnings:

	ChgPane.c:46:5: warning: implicit declaration of function ‘strlen’
	ChgPane.c:46:20: warning: incompatible implicit declaration of
		built-in function ‘strlen’
	ChgSel.c:62:2: warning: implicit declaration of function ‘strlen’
	ChgSel.c:62:17: warning: incompatible implicit declaration of built-in
		function ‘strlen’
	Create.c:220:5: warning: implicit declaration of function ‘strcmp’
	InsPane.c:65:5: warning: implicit declaration of function ‘strlen’
	InsPane.c:65:20: warning: incompatible implicit declaration of
		built-in function ‘strlen’
	InsSel.c:68:5: warning: implicit declaration of function ‘strlen’
	InsSel.c:68:20: warning: incompatible implicit declaration of built-in
		function ‘strlen’
	InsSel.c:75:5: warning: implicit declaration of function ‘strcmp’

Add the necessary ‘#include <string.h>’.

oldXMenu/ChgPane.c, oldXMenu/ChgSel.c, oldXMenu/Create.c, oldXMenu/InsPane.c,
oldXMenu/InsSel.c: add missing #include <string.h>
---
 oldXMenu/ChgPane.c | 1 +
 oldXMenu/ChgSel.c  | 1 +
 oldXMenu/Create.c  | 1 +
 oldXMenu/InsPane.c | 1 +
 oldXMenu/InsSel.c  | 1 +
 5 files changed, 5 insertions(+)

Unless there are some objections I’ll commit this in a few days.

diff --git a/oldXMenu/ChgPane.c b/oldXMenu/ChgPane.c
index d2977b73faf..733f65950f5 100644
--- a/oldXMenu/ChgPane.c
+++ b/oldXMenu/ChgPane.c
@@ -14,6 +14,7 @@
  */
 
 #include "XMenuInt.h"
+#include <string.h>
 
 int
 XMenuChangePane(register XMenu *menu, register int p_num, char *label)
diff --git a/oldXMenu/ChgSel.c b/oldXMenu/ChgSel.c
index d24e61f56d5..5a46b5cf587 100644
--- a/oldXMenu/ChgSel.c
+++ b/oldXMenu/ChgSel.c
@@ -14,6 +14,7 @@
  */
 
 #include "XMenuInt.h"
+#include <string.h>
 
 int
 XMenuChangeSelection(Display *display, register XMenu *menu, register int p_num, register int s_num, char *data, int data_sw, char *label, int label_sw)
diff --git a/oldXMenu/Create.c b/oldXMenu/Create.c
index 0e72a2d2e58..a0913685365 100644
--- a/oldXMenu/Create.c
+++ b/oldXMenu/Create.c
@@ -31,6 +31,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "XMenuInt.h"
 #include <stdlib.h>
+#include <string.h>
 
 #ifdef EMACS_BITMAP_FILES
 #include "../src/bitmaps/dimple1.xbm"
diff --git a/oldXMenu/InsPane.c b/oldXMenu/InsPane.c
index d8470f3a5bf..da92f49aa77 100644
--- a/oldXMenu/InsPane.c
+++ b/oldXMenu/InsPane.c
@@ -15,6 +15,7 @@
  */
 
 #include "XMenuInt.h"
+#include <string.h>
 
 int
 XMenuInsertPane(register XMenu *menu, register int p_num, char *label, int active)
diff --git a/oldXMenu/InsSel.c b/oldXMenu/InsSel.c
index 66f4968197d..f5380437958 100644
--- a/oldXMenu/InsSel.c
+++ b/oldXMenu/InsSel.c
@@ -14,6 +14,7 @@
  */
 
 #include "XMenuInt.h"
+#include <string.h>
 
 int
 XMenuInsertSelection(register XMenu *menu, register int p_num, register int s_num, char *data, char *label, int active)
-- 
2.11.0.483.g087da7b7c-goog




[Message part 3 (message/rfc822, inline)]
From: Michal Nazarewicz <mina86 <at> mina86.com>
To: 25677-close <at> debbugs.gnu.org
Subject: Re: [PATCH 01/22] oldXMenu: add missing #include <string.h>
Date: Wed, 15 Feb 2017 17:13:13 +0100

On Fri, Feb 10 2017, Michal Nazarewicz wrote:
> Some of the files in oldXMenu use functions from string.h without
> including that header which results in compile warnings:
>
> 	ChgPane.c:46:5: warning: implicit declaration of function ‘strlen’
> 	ChgPane.c:46:20: warning: incompatible implicit declaration of
> 		built-in function ‘strlen’
> 	ChgSel.c:62:2: warning: implicit declaration of function ‘strlen’
> 	ChgSel.c:62:17: warning: incompatible implicit declaration of built-in
> 		function ‘strlen’
> 	Create.c:220:5: warning: implicit declaration of function ‘strcmp’
> 	InsPane.c:65:5: warning: implicit declaration of function ‘strlen’
> 	InsPane.c:65:20: warning: incompatible implicit declaration of
> 		built-in function ‘strlen’
> 	InsSel.c:68:5: warning: implicit declaration of function ‘strlen’
> 	InsSel.c:68:20: warning: incompatible implicit declaration of built-in
> 		function ‘strlen’
> 	InsSel.c:75:5: warning: implicit declaration of function ‘strcmp’
>
> Add the necessary ‘#include <string.h>’.
>
> oldXMenu/ChgPane.c, oldXMenu/ChgSel.c, oldXMenu/Create.c, oldXMenu/InsPane.c,
> oldXMenu/InsSel.c: add missing #include <string.h>

Pushed.

> ---
>  oldXMenu/ChgPane.c | 1 +
>  oldXMenu/ChgSel.c  | 1 +
>  oldXMenu/Create.c  | 1 +
>  oldXMenu/InsPane.c | 1 +
>  oldXMenu/InsSel.c  | 1 +
>  5 files changed, 5 insertions(+)
>
> Unless there are some objections I’ll commit this in a few days.
>
> diff --git a/oldXMenu/ChgPane.c b/oldXMenu/ChgPane.c
> index d2977b73faf..733f65950f5 100644
> --- a/oldXMenu/ChgPane.c
> +++ b/oldXMenu/ChgPane.c
> @@ -14,6 +14,7 @@
>   */
>  
>  #include "XMenuInt.h"
> +#include <string.h>
>  
>  int
>  XMenuChangePane(register XMenu *menu, register int p_num, char *label)
> diff --git a/oldXMenu/ChgSel.c b/oldXMenu/ChgSel.c
> index d24e61f56d5..5a46b5cf587 100644
> --- a/oldXMenu/ChgSel.c
> +++ b/oldXMenu/ChgSel.c
> @@ -14,6 +14,7 @@
>   */
>  
>  #include "XMenuInt.h"
> +#include <string.h>
>  
>  int
>  XMenuChangeSelection(Display *display, register XMenu *menu, register int p_num, register int s_num, char *data, int data_sw, char *label, int label_sw)
> diff --git a/oldXMenu/Create.c b/oldXMenu/Create.c
> index 0e72a2d2e58..a0913685365 100644
> --- a/oldXMenu/Create.c
> +++ b/oldXMenu/Create.c
> @@ -31,6 +31,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
>  
>  #include "XMenuInt.h"
>  #include <stdlib.h>
> +#include <string.h>
>  
>  #ifdef EMACS_BITMAP_FILES
>  #include "../src/bitmaps/dimple1.xbm"
> diff --git a/oldXMenu/InsPane.c b/oldXMenu/InsPane.c
> index d8470f3a5bf..da92f49aa77 100644
> --- a/oldXMenu/InsPane.c
> +++ b/oldXMenu/InsPane.c
> @@ -15,6 +15,7 @@
>   */
>  
>  #include "XMenuInt.h"
> +#include <string.h>
>  
>  int
>  XMenuInsertPane(register XMenu *menu, register int p_num, char *label, int active)
> diff --git a/oldXMenu/InsSel.c b/oldXMenu/InsSel.c
> index 66f4968197d..f5380437958 100644
> --- a/oldXMenu/InsSel.c
> +++ b/oldXMenu/InsSel.c
> @@ -14,6 +14,7 @@
>   */
>  
>  #include "XMenuInt.h"
> +#include <string.h>
>  
>  int
>  XMenuInsertSelection(register XMenu *menu, register int p_num, register int s_num, char *data, char *label, int active)
> -- 
> 2.11.0.483.g087da7b7c-goog
>

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
This bug report was last modified 8 years and 100 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.